Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Kalle Valo
Abhishek Kumar wrote: > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option looks as follows > board name 'bus=sn

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-07 Thread Enrico Weigelt, metux IT consult
On 05.12.20 08:06, Sven Eckelmann wrote: Hi, > Is there some explanation besides an opinion? Some kind goal which you want > to > achieve with it maybe? Just a cleanup. I've been under the impression that this version is just an relic from oot times. > At least for us it was an easy way to qu

Re: [PATCH] net: carl9170: remove trailing semicolon in macro definition

2020-12-07 Thread Kalle Valo
t...@redhat.com wrote: > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e65e8b608f68 carl9170: remove trailing semicolon in macro definition -- https://patchwork.kernel.org/project/linu

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 22:54:18 -0800 > On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > > > @@ -242,8 +244,12 @@ void reuseport_detach_sock(struct sock *sk) > > > > reuse->num_socks--; > > reuse->socks[i] = reuse->socks[reus

general protection fault in hci_chan_del

2020-12-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b3298500 Merge tag 'for-5.10/dm-fixes' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=144f0bf750 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433cfed49b7d9 das

[PATCH v2 1/1] xdp: avoid calling kfree twice

2020-12-07 Thread Zhu Yanjun
In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again to handle umem->pgs. Eventually, umem->pgs is freed twice.

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Martin KaFai Lau
On Tue, Dec 08, 2020 at 03:31:34PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Mon, 7 Dec 2020 12:33:15 -0800 > > On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > > > From: Eric Dumazet > > > Date: Tue, 1 Dec 2020 16:25:51 +0100 > > > > On 12/1/20

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-07 Thread Kalle Valo
Xiaohui Zhang wrote: > From: Zhang Xiaohui > > mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by putting the length

Re: BUG: unable to handle kernel paging request in bpf_lru_populate

2020-12-07 Thread Dmitry Vyukov
On Mon, Dec 7, 2020 at 12:43 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:bcd684aa net/nfc/nci: Support NCI 2.x initial sequence > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=12001bd350 > kernel config: https

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-07 Thread Emmanuel Grumbach
On Mon, Dec 7, 2020 at 10:14 PM Jakub Kicinski wrote: > > On Mon, 7 Dec 2020 11:35:53 -0800 Brian Norris wrote: > > On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote: > > > Jakub Kicinski writes: > > > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > > > > There's also a patch which

Re: [PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-07 Thread Björn Töpel
On 2020-12-08 04:56, Yonghong Song wrote: On 12/7/20 1:53 PM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. [...] All tests passed in my environment. Tested-by: Yonghong Song Thanks for the hard work, Weqaar! And thanks Yonghong for testing/feed

[PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-12-07 Thread DENG Qingfang
MT7530 has a global address age control register, so use it to set ageing time. The applied timer is (AGE_CNT + 1) * (AGE_UNIT + 1) seconds Signed-off-by: DENG Qingfang --- drivers/net/dsa/mt7530.c | 41 drivers/net/dsa/mt7530.h | 13 + 2 fil

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > @@ -242,8 +244,12 @@ void reuseport_detach_sock(struct sock *sk) > > reuse->num_socks--; > reuse->socks[i] = reuse->socks[reuse->num_socks]; > + prog = rcu_dereference(reuse->prog); > >

RE: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
> From: Randy Dunlap > Sent: Tuesday, December 8, 2020 6:45 AM > > Hi-- > > On 12/7/20 2:13 PM, Parav Pandit wrote: > > Added documentation for devlink port and port function related > commands. > > > > Signed-off-by: Parav Pandit > > Reviewed-by: Jiri Pirko > > Reviewed-by: Jacob Keller >

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:48 -0800, Andrii Nakryiko wrote: > On Mon, Dec 7, 2020 at 10:45 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > > > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > > > wrote: > > > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nak

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 19:16 -0800, Alexander Duyck wrote: > On Mon, Dec 7, 2020 at 3:03 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi < > > > lore...@kernel.org> > > > wrote: > > > > Introduce multi-bu

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 10:45 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > > wrote: > > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > >

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > > From: Saeed Mahameed > > > > [...] > > > > > > > > I am not sure

Re: [RFC PATCH net-next 01/13] RDMA/mlx4: remove bogus dev_base_lock usage

2020-12-07 Thread Leon Romanovsky
On Mon, Dec 07, 2020 at 01:59:07AM +0200, Vladimir Oltean wrote: > The dev_base_lock does not protect dev->dev_addr, so it serves no > purpose here. > > Cc: Leon Romanovsky > Signed-off-by: Vladimir Oltean > --- > drivers/infiniband/hw/mlx4/main.c | 3 --- > 1 file changed, 3 deletions(-) Agree

[PATCH v2 bpf-next] bpf: return -ENOTSUPP when attaching to non-kernel BTF

2020-12-07 Thread Andrii Nakryiko
Return -ENOTSUPP if tracing BPF program is attempted to be attached with specified attach_btf_obj_fd pointing to non-kernel (neither vmlinux nor module) BTF object. This scenario might be supported in the future and isn't outright invalid, so -EINVAL isn't the most appropriate error code. Suggeste

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > From: Saeed Mahameed > > > > > > While playing with BTF for modules, i noticed that executing the > > > command: > > > $ bpftool btf

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 12:33:15 -0800 > On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > > From: Eric Dumazet > > Date: Tue, 1 Dec 2020 16:25:51 +0100 > > > On 12/1/20 3:44 PM, Kuniyuki Iwashima wrote: > > > > This patch lets reuseport_detach_sock

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 12:14:38 -0800 > On Sun, Dec 06, 2020 at 01:03:07AM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Fri, 4 Dec 2020 17:42:41 -0800 > > > On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > > > [ ... ] > > >

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > From: Saeed Mahameed > > > > While playing with BTF for modules, i noticed that executing the > > command: > > $ bpftool btf dump id > > > > Fails due to lack of information in the BTF data. >

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Michal Kubecek
On Mon, Dec 07, 2020 at 02:11:48PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > >

RE: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
Hi Randy, > From: Randy Dunlap > Sent: Tuesday, December 8, 2020 6:45 AM > > > +An eswitch on the PCI device may suppport ports of multiple controllers. > > support > > > + > > +An example view of two controller systems:: > > I think that this is > > An

[PATCH] [v10] wireless: Initial driver submission for pureLiFi STA devices

2020-12-07 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Willy Tarreau
On Mon, Dec 07, 2020 at 03:40:42PM -0800, Jakub Kicinski wrote: > Thanks for the report, I remember that one. In hindsight maybe we > should have punted it to 5.11... Well, not necessarily as it was simple, well documented and *appeared* to work fine. > Let's revert ASAP, 5.10 is going to be LTS,

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Neftin, Sasha
On 12/7/2020 17:41, Limonciello, Mario wrote: First of all thank you for working on this. I must say though that I don't like the approach taken here very much. This is not so much a criticism of this series as it is a criticism of the earlier decision to simply disable s0ix on all devices with

RE: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Rakesh Pillai
Hi, > -Original Message- > From: Abhishek Kumar > Sent: Tuesday, December 8, 2020 4:50 AM > To: kv...@codeaurora.org > Cc: linux-ker...@vger.kernel.org; kua...@chromium.org; linux- > wirel...@vger.kernel.org; ath...@lists.infradead.org; > pill...@codeaurora.org; briannor...@chromium.org;

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-07 Thread Martin K. Petersen
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fal

[PATCH v3] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2020-12-07 Thread Andrea Parri (Microsoft)
From: Andres Beltran Pointers to ring-buffer packets sent by Hyper-V are used within the guest VM. Hyper-V can send packets with erroneous values or modify packet fields after they are processed by the guest. To defend against these scenarios, return a copy of the incoming VMBus packet after vali

Re: [PATCH v2] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2020-12-07 Thread Andrea Parri
> > @@ -419,17 +446,52 @@ static u32 hv_pkt_iter_avail(const struct > > hv_ring_buffer_info *rbi) > > struct vmpacket_descriptor *hv_pkt_iter_first(struct vmbus_channel > > *channel) > > { > > struct hv_ring_buffer_info *rbi = &channel->inbound; > > - struct vmpacket_descriptor *desc; > >

Re: [PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-07 Thread Yonghong Song
On 12/7/20 1:53 PM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- # _ | Process | _ # / --- \ # /|\ #/ |

Refcount mismatch when unregistering netdevice from kernel

2020-12-07 Thread stranche
Hi everyone, We've recently been investigating a refcount problem when unregistering a netdevice from the kernel. It seems that the IPv6 module is still holding various references to the inet6_dev associated with the main netdevice struct that are not being released, preventing the unregistra

Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework

2020-12-07 Thread Yonghong Song
On 12/7/20 1:55 PM, Weqaar Janjua wrote: On Sat, 28 Nov 2020 at 03:13, Yonghong Song wrote: On 11/27/20 9:54 AM, Weqaar Janjua wrote: On Fri, 27 Nov 2020 at 04:19, Yonghong Song wrote: On 11/26/20 1:22 PM, Weqaar Janjua wrote: On Thu, 26 Nov 2020 at 09:01, Björn Töpel wrote: On

Re: [PATCH v2 bpf-next 0/3] bpf: support module BTF in BTF display helpers

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 4:44 PM Alan Maguire wrote: > > > On Sat, 5 Dec 2020, Yonghong Song wrote: > > > > > > > __builtin_btf_type_id() is really only supported in llvm12 > > and 64bit return value support is pushed to llvm12 trunk > > a while back. The builtin is introduced in llvm11 but has a >

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 7:12 PM Alexei Starovoitov wrote: > > On Mon, Dec 07, 2020 at 04:38:16PM +, Alan Maguire wrote: > > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > > relocation, > > > put module BTF FD, containi

Re: [PATCH bpf] tools/bpftool: fix PID fetching with a lot of results

2020-12-07 Thread Yonghong Song
On 12/7/20 6:55 PM, Andrii Nakryiko wrote: On Sat, Dec 5, 2020 at 11:11 AM Yonghong Song wrote: On 12/4/20 3:20 PM, Andrii Nakryiko wrote: In case of having so many PID results that they don't fit into a singe page (4096) bytes, bpftool will erroneously conclude that it got corrupted dat

Re: [PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 7 Dec 2020 13:37:20 +0100 you wrote: > __htab_map_lookup_and_delete_batch() stores a user pointer in the local > variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a > __user annotation. > > So

Re: [pull request][for-next V2] mlx5-next auxbus support

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sun, 6 Dec 2020 21:33:49 -0800 you wrote: > Hi Jakub, Jason > > v1->v2: Fix compilation warning when compiling with W=1 in the mlx5 > patches. > > This pull request is targeting net-next and rdma-next branches.

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 4:38 PM Alan Maguire wrote: > > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > relocation, > > put module BTF FD, containing target type, into upper 32 bits of imm64. > > > > Because this FD is internal

Re: [PATCH net-next v10 0/4] GVE Raw Addressing

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 2:45 PM David Awogbemila wrote: > > Patchset description: > This patchset introduces "raw addressing" mode to the GVE driver. > Previously (in "queue_page_list" or "qpl" mode), the driver would > pre-allocate and dma_map buffers to be used on egress and ingress. > On egress

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 3:03 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > wrote: > > > Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data > > > structure > > > in order to specify if this is

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Sun, Dec 6, 2020 at 9:21 PM wrote: > > From: Saeed Mahameed > > While playing with BTF for modules, i noticed that executing the command: > $ bpftool btf dump id > > Fails due to lack of information in the BTF data. > > Maybe I am missing a step but actually adding the support for this is > v

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Alexei Starovoitov
On Mon, Dec 07, 2020 at 04:38:16PM +, Alan Maguire wrote: > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > relocation, > > put module BTF FD, containing target type, into upper 32 bits of imm64. > > > > Because this FD i

RE: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-07 Thread Qiang Zhao
On 06/12/2020 05:12, Rasmus Villemoes wrote: > -Original Message- > From: Rasmus Villemoes > Sent: 2020年12月6日 5:12 > To: Jakub Kicinski > Cc: Leo Li ; David S. Miller ; > Qiang Zhao ; netdev@vger.kernel.org; > linuxppc-...@lists.ozlabs.org; linux-ker...@vger.kernel.org; > linux-arm-ker

Re: [PATCH bpf] tools/bpftool: fix PID fetching with a lot of results

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 11:11 AM Yonghong Song wrote: > > > > On 12/4/20 3:20 PM, Andrii Nakryiko wrote: > > In case of having so many PID results that they don't fit into a singe page > > (4096) bytes, bpftool will erroneously conclude that it got corrupted data > > due > > to 4096 not being a mu

Re: [PATCH bpf-next v9 00/34] bpf: switch to memcg-based memory accounting

2020-12-07 Thread Andrii Nakryiko
On Fri, Dec 4, 2020 at 4:37 PM Daniel Borkmann wrote: > > On 12/3/20 4:26 AM, Roman Gushchin wrote: > > On Wed, Dec 02, 2020 at 06:54:46PM -0800, Alexei Starovoitov wrote: > >> On Tue, Dec 1, 2020 at 1:59 PM Roman Gushchin wrote: > >>> > >>> 5) Cryptic -EPERM is returned on exceeding the limit. L

Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Chris Mi
On 12/8/2020 10:28 AM, Jakub Kicinski wrote: On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. Th

[PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Chris Mi
The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. The remaining indirect flow blocks will never be freed. Fixes: 1fac52da5942 ("net: flow_offload: con

Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-07 Thread Jason Wang
On 2020/12/7 下午9:38, wangyunjian wrote: I think the newly added code is easy to miss this problem, so I want to copy ubuf_info until we're sure there's no errors. Thanks, Yunjian But isn't this actually a disabling of zerocopy? Thanks

Re: pull request (net): ipsec 2020-12-07

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 10:39:33 +0100 Steffen Klassert wrote: > 1) Sysbot reported fixes for the new 64/32 bit compat layer. >From Dmitry Safonov. > > 2) Fix a memory leak in xfrm_user_policy that was introduced >by adding the 64/32 bit compat layer. From Yu Kuai. Pulled, thank you!

Re: [PATCH net-next] net/mlx4: Remove unused #define MAX_MSIX_P_PORT

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 6 Dec 2020 11:12:54 +0200 you wrote: > From: Tariq Toukan > > All usages of the definition MAX_MSIX_P_PORT were removed. > It's not in use anymore. Remove it. > > Signed-off-by: Tariq Toukan > Reviewed-by: Mosh

Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: > The offending commit introduces a cleanup callback that is invoked > when the driver module is removed to clean up the tunnel device > flow block. But it returns on the first iteration of the for loop. > The remaining indirect flow blocks will ne

Re: vlan_filtering=1 breaks all traffic

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 08:15:28PM +, Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 08:43:18PM +0100, Rasmus Villemoes wrote: > > # uname -a > > Linux (none) 5.10.0-rc7-00035-g66d777e1729d #194 Mon Dec 7 16:00:30 CET > > 2020 ppc GNU/Linux > > # devlink dev > > mdio_bus/mdio@e0102120:10 > >

Re: [PATCH net-next] bonding: set xfrm feature flags more sanely

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 12:40:03 -0500 Jarod Wilson wrote: > We can remove one of the ifdef blocks here, and instead of setting both > the xfrm hw_features and features flags, then unsetting the the features > flags if not in AB, wait to set the features flags if we're actually in AB > mode. > > Cc: J

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:31:16 +0100 Andrew Lunn wrote: > On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > Port counts in microchip dsa drivers can be quite confusing: > > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > > yet on

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 08:43:32PM +0100, Jean Pihet wrote: > Hi Andrew, > > On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > > > Configure the host port of the switch to match the host interface > > > settings. This is useful when the switch is directly connected to the > > > host MAC int

Re: [PATCH] net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 10:31:46 +0100 Jerome Brunet wrote: > > The m250_sel mux clock uses bit 4 in the PRG_ETH0 register. Fix this by > > shifting the PRG_ETH0_CLK_M250_SEL_MASK accordingly as the "mask" in > > struct clk_mux expects the mask relative to the "shift" field in the > > same struct. > >

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-12-07 Thread Chunfeng Yun
On Mon, 2020-12-07 at 15:19 -0600, Rob Herring wrote: > On Wed, Nov 18, 2020 at 04:21:22PM +0800, Chunfeng Yun wrote: > > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > > > Cc: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > > --- > > v3: new patch > > --- > > .../display

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 15:04:58 + Ioana Ciornei wrote: > On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > > Add an 'of_node_put()' call when a tested device node is not available. > > > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > > Signed-off-

[PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-07 Thread Zhang Changzhong
platform_get_resource() may fail and in this case a NULL dereference will occur. Fix it to use devm_platform_ioremap_resource() instead of calling platform_get_resource() and devm_ioremap(). This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = \(plat

Re: [PATCH net v2] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 15:56:33 +0800 Jianguo Wu wrote: > From: Jianguo Wu > > When do cat /proc/net/netstat, the output isn't append with a new line, it > looks like this: > [root@localhost ~]# cat /proc/net/netstat > ... > MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@localhost ~]# > > This is because

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 18:47:19 -0600 George McCollister wrote: > On Mon, Dec 7, 2020 at 6:40 PM kernel test robot wrote: > >drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct > > dsa_switch_ops' has no member named 'get_stats64' > > This patch depends on "net: dsa: add optional sta

Re: [PATCH v3] bridge: Fix a deadlock when enabling multicast snooping

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 10:56:45 +0200 Nikolay Aleksandrov wrote: > On 05/12/2020 01:56, Joseph Huang wrote: > > When enabling multicast snooping, bridge module deadlocks on multicast_lock > > if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 > > network. > > > > The deadlock wa

Re: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Randy Dunlap
Hi-- On 12/7/20 2:13 PM, Parav Pandit wrote: > Added documentation for devlink port and port function related commands. > > Signed-off-by: Parav Pandit > Reviewed-by: Jiri Pirko > Reviewed-by: Jacob Keller > --- > Changelog: > v4->v5: > - described logically ingress and egress point of devlin

Re: [PATCH net-next v3 1/1] ibmvnic: add some debugs

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 18:22:35 -0800 Sukadev Bhattiprolu wrote: > We sometimes run into situations where a soft/hard reset of the adapter > takes a long time or fails to complete. Having additional messages that > include important adapter state info will hopefully help understand what > is happening

Re: [PATCH v3 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 02:43:15 +0200 Vladimir Oltean wrote: > Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has > a very nice ocelot_mact_wait_for_completion at the end. Introduced in > commit 639c1b2625af ("net: mscc: ocelot: Register poll timeout should be > wall time not att

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread David Ahern
On 12/7/20 1:52 PM, John Fastabend wrote: >> >> I think we need to keep XDP_TX action separate, because I think that >> there are use-cases where the we want to disable XDP_TX due to end-user >> policy or hardware limitations. > > How about we discover this at load time though. Meaning if the prog

Re: [PATCH net] enetc: Fix reporting of h/w packet counters

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:15:05 +0200 Claudiu Manoil wrote: > Noticed some inconsistencies in packet statistics reporting. > This patch adds the missing Tx packet counter registers to > ethtool reporting and fixes the information strings for a > few of them. > > Fixes: 16eb4c85c964 ("enetc: Add ethto

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread George McCollister
On Mon, Dec 7, 2020 at 6:40 PM kernel test robot wrote: >drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct > dsa_switch_ops' has no member named 'get_stats64' This patch depends on "net: dsa: add optional stats64 support" being merged first: https://lore.kernel.org/netdev/2020120

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:27:31 + Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > > Jakub Kicinski writes: > > > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > > >> Jakub Kicinski writes: > > >> >> + * @min_frag_size_mul

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-07 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > This commit introduces direct data placement offload for TCP. > This capability is accompanied by new net_device operations that > configure > hardware contexts. There is a context per socket, and a context per DDP > opreation. Additionally, a resynchroni

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread kernel test robot
Hi George, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-07 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > When using direct data placement the NIC writes some of the payload > directly to the destination buffer, and constructs the SKB such that it > points to this data. As a result, the skb_copy datagram_iter call will > attempt to copy data when it is not ne

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Vladimir Oltean writes: > On Mon, Dec 07, 2020 at 02:49:35PM -0800, Vinicius Costa Gomes wrote: >> Jakub Kicinski writes: >> >> > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: >> >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ >> >> num_tc 3 \ >> >>

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > >> Jakub Kicinski writes: > >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> >> + * expressed in t

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: >> Jakub Kicinski writes: >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, >> >> + * expressed in terms of X in '(1 + X)*64 + 4' >> > >> > Is this way of expressing the min frag

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > Introduce xdp_shared_info data structure to contain info about > "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info > allowing to keep most of the frags in the same cache-line. > Introduce some xdp_shared_info helpers alig

Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 18:43:00 +0200 Mickey Rachamim wrote: > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > Signed-off-by: Mickey Rachamim > --- > v2: > Update the maintainers list according to community recommendation. > > MAINTAINERS | 8 > 1 file changed, 8

[PATCH 1/1] Bluetooth: Remove hci_req_le_suspend_config

2020-12-07 Thread Abhishek Pandit-Subedi
Add a missing SUSPEND_SCAN_ENABLE in passive scan, remove the separate function for configuring le scan during suspend and update the request complete function to clear both enable and disable tasks. Fixes: dce0a4be8054 ("Bluetooth: Set missing suspend task bits") Reviewed-by: Alain Michaud Signe

[PATCH 0/1] Bluetooth: Further improvements for suspend tasks

2020-12-07 Thread Abhishek Pandit-Subedi
Hi Marcel, This patch further improves suspend handling by getting rid of the separate function used for always configuring LE scan. Instead, we only configure LE scan if it is necessary and properly set the task bits depending on what actions were taken. The previously sent-up CL was incomplet

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Doug Anderson
Hi, On Mon, Dec 7, 2020 at 3:23 PM Abhishek Kumar wrote: > > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option l

RE: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread Tristram.Ha
> In order to get this driver used with other switches the functions need > to use different offsets and register shifts. This patch changes the > direct use of the register defines to register description structures, > which can be set depending on the chips register layout. > > Signed-off-by: Mi

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Alexandre Belloni
Hi, On 07/12/2020 15:40:42-0800, Jakub Kicinski wrote: > On Sun, 6 Dec 2020 10:20:41 +0100 Willy Tarreau wrote: > > Hi Jakub, > > > > Two months ago I implemented a small change in the macb driver to > > support the two Tx descriptors that AT91RM9200 supports. I implemented > > this using the onl

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Jakub Kicinski
On Sun, 6 Dec 2020 10:20:41 +0100 Willy Tarreau wrote: > Hi Jakub, > > Two months ago I implemented a small change in the macb driver to > support the two Tx descriptors that AT91RM9200 supports. I implemented > this using the only compatible device I had which is the MSC313E-based > Breadbee boar

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > Port counts in microchip dsa drivers can be quite confusing: > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > yet on the ksz9477, it includes the cpu port. > > Add comments to docum

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 10:19:47PM +0100, Tobias Waldekranz wrote: > On Fri, Dec 04, 2020 at 03:20, Andrew Lunn wrote: > >> +static int dsa_tree_setup_lags(struct dsa_switch_tree *dst) > >> +{ > >> + struct dsa_port *dp; > >> + unsigned int num; > >> + > >> + list_for_each_entry(dp, &dst->ports

[PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Abhishek Kumar
In some devices difference in chip-id should be enough to pick the right BDF. Add another support for chip-id based BDF selection. With this new option, ath10k supports 2 fallback options. The board name with chip-id as option looks as follows board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'

Re: [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 14:15:25 -0800 Vinicius Costa Gomes wrote: > > WARNING: 'PREEMPTABLE' may be misspelled - perhaps 'PREEMPTIBLE'? > > In the datasheet the term PREEMPTABLE is used, and when refering to > register values I chose to be consistent with the datasheet. But as the > margin for conf

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > > >

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:37 +0100, Maciej Fijalkowski wrote: > On Mon, Dec 07, 2020 at 01:15:00PM -0800, Alexander Duyck wrote: > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > wrote: > > > Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. > > > This is a preliminary patch t

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Maciej Fijalkowski
On Mon, Dec 07, 2020 at 12:52:22PM -0800, John Fastabend wrote: > Jesper Dangaard Brouer wrote: > > On Fri, 4 Dec 2020 16:21:08 +0100 > > Daniel Borkmann wrote: > > > > > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland-Jørgensen wrote:

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 02:49:35PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > > > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: > >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ > >> num_tc 3 \ > >> map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > wrote: > > Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data > > structure > > in order to specify if this is a linear buffer (mb = 0) or a multi- > > buffer > > frame (mb = 1).

Re: [PATCH] drivers: broadcom: save return value of pci_find_capability() in u8

2020-12-07 Thread Bjorn Helgaas
On Mon, Dec 07, 2020 at 01:40:33AM +0530, Puranjay Mohan wrote: > Callers of pci_find_capability() should save the return value in u8. > change the type of pcix_cap from int to u8, to match the specification. > > Signed-off-by: Puranjay Mohan > --- > drivers/net/ethernet/broadcom/tg3.h | 2 +- >

Re: [PATCH bpf-next] bpf: avoid overflows involving hash elem_size

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 7 Dec 2020 10:28:21 -0800 you wrote: > From: Eric Dumazet > > Use of bpf_map_charge_init() was making sure hash tables would not use more > than 4GB of memory. > > Since the implicit check disappeared, we have to b

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ >> num_tc 3 \ >> map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \ >> queues 1@0 1@1 2@2 \ >> base-time $BASE_TIME \ >> sched-

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 12:52 -0800, John Fastabend wrote: > Jesper Dangaard Brouer wrote: > > On Fri, 4 Dec 2020 16:21:08 +0100 > > Daniel Borkmann wrote: > > > > > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland- > > > > Jørgensen wrote

  1   2   3   4   >