Jakub Kicinski <k...@kernel.org> writes: > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: >> Jakub Kicinski <k...@kernel.org> writes: >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, >> >> + * expressed in terms of X in '(1 + X)*64 + 4' >> > >> > Is this way of expressing the min frag size from the standard? >> > >> >> The standard has this: "A 2-bit integer value indicating, in units of 64 >> octets, the minimum number of octets over 64 octets required in >> non-final fragments by the receiver" from IEEE 802.3br-2016, Table >> 79-7a. > > Thanks! Let's drop the _mult suffix and add a mention of this > controlling the addFragSize variable from the standard. Perhaps > it should in fact be called add_frag_size (with an explanation > that the "additional" means "above the 64B" which are required in > Ethernet, and which are accounted for by the "1" in the 1 + X > formula)?
Sounds good :-) Will add a comment with the standard reference and change the name to 'add_frag_size'. Cheers, -- Vinicius