On 2020-11-24 01:04, Jakub Kicinski wrote:
On Thu, 19 Nov 2020 09:30:15 +0100 Björn Töpel wrote:
+ /* The NAPI context has more processing work, but busy-polling
+* is preferred. Exit early.
+*/
+ if (napi_prefer_busy_poll(n)) {
+ if (napi_complete_done(
On Mon, Nov 23, 2020 at 9:49 PM Alexei Starovoitov
wrote:
>
> On Thu, Nov 19, 2020 at 03:22:39PM -0800, Andrii Nakryiko wrote:
> > __module_address() needs to be called with preemption disabled or with
> > module_mutex taken. preempt_disable() is enough for read-only uses, which is
> > what this f
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ
defines instead of a driver internal enumeration.
Signed-off-by: Christian Eggers
Reviewed-by: Antoine Tenart
Cc: Antoine Tenart
---
drivers/net/phy/mscc/mscc_ptp.c | 14 +++---
drivers/net/phy/mscc/mscc_ptp.h | 5
Use recently introduced PTP wide defines instead of a driver internal
enumeration.
Signed-off-by: Christian Eggers
Reviewed-by: Ido Schimmel
Cc: Petr Machata
Cc: Jiri Pirko
Cc: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8
drivers/net/ethernet/mellanox/mlx
Replace use of magic number with recently introduced define.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
drivers/net/phy/dp83640.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index f2caccaf4408..9757ca
Changes in v2:
- resend, as v1 was sent before the prerequisites were merged
- removed mismatch between From: and Signed-off-by:
- [2/3] Reviewed-by: Ido Schimmel
- [3/3] Reviewed-by: Antoine Tenart
- [3/3] removed dead email addresses from Cc:
This series replaces further driv
On Mon, Nov 23, 2020 at 07:34:22PM -0800, Alexei Starovoitov wrote:
> It's a missing hook for out-of-tree module. That's why it stinks so much.
As I've said before, the motivation for these patches has pivoted away
from the original use case (which was indeed an out-of-tree module by
a company for
Add a new function for returning descriptors the user received
after an xsk_ring_cons__peek call. After the application has
gotten a number of descriptors from a ring, it might not be able
to or want to process them all for various reasons. Therefore,
it would be useful to have an interface for ret
在 2020/11/24 9:22, Jakub Kicinski 写道:
On Sun, 22 Nov 2020 10:34:56 +0800 Wang Hai wrote:
kmemleak report a memory leak as follows:
unreferenced object 0x8880059c6a00 (size 64):
comm "ip", pid 23696, jiffies 4296590183 (age 1755.384s)
hex dump (first 32 bytes):
20 01 00 10 00 00
hby writes:
> I am sorry for the HTML email, and I change the email client. The
> patch update.
>
> From b87d429158b4efc3f6835828f495a261e17d5af4 Mon Sep 17 00:00:00 2001
> From: hby
> Date: Tue, 24 Nov 2020 09:16:24 +0800
> Subject: [PATCH] brmcfmac: fix compile when DEBUG is defined
>
> The st
On Mon Nov 23 2020, Vladimir Oltean wrote:
> Hi Kurt,
>
> On Sat, Nov 21, 2020 at 12:57:03PM +0100, Kurt Kanzenbach wrote:
>> The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
>> schedules may be configured individually on each front port. Each port has
>> eight
>> egress qu
Jakub Kicinski writes:
> On Mon, 23 Nov 2020 16:10:37 + (UTC) Kalle Valo wrote:
>> wireless-drivers fixes for v5.10
>>
>> First set of fixes for v5.10. One fix for iwlwifi kernel panic, others
>> less notable.
>>
>> rtw88
>>
>> * fix a bogus test found by clang
>>
>> iwlwifi
>>
>> * fix
kmemleak report a memory leak as follows:
unreferenced object 0x8880059c6a00 (size 64):
comm "ip", pid 23696, jiffies 4296590183 (age 1755.384s)
hex dump (first 32 bytes):
20 01 00 10 00 00 00 00 00 00 00 00 00 00 00 00 ...
1c 00 00 00 00 00 00 00 00 00 00 00 07 00 00
On 2020/11/24 下午3:01, Jason Wang wrote:
On 2020/11/21 上午3:04, Samudrala, Sridhar wrote:
On 11/20/2020 9:58 AM, Alexander Duyck wrote:
On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote:
On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote:
On 11/18/20 7:14 PM, Jakub Kicinski wrote:
On 2020/11/21 上午3:04, Samudrala, Sridhar wrote:
On 11/20/2020 9:58 AM, Alexander Duyck wrote:
On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote:
On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote:
On 11/18/20 7:14 PM, Jakub Kicinski wrote:
On Tue, 17 Nov 2020 14:49:54 -0400 Jason G
IS_ERR_VALUE macro should be used only with unsigned long type.
Especially it works incorrectly with unsigned shorter types on
64bit machines.
Fixes: 976de6a8c304 ("fs_enet: Be an of_platform device when
CONFIG_PPC_CPM_NEW_BINDING is set.")
Fixes: 4c35630ccda5 ("[POWERPC] Change rheap functions t
IS_ERR_VALUE macro should be used only with unsigned long type.
Especially it works incorrectly with unsigned shorter types on
64bit machines.
Fixes: 4c35630ccda5 ("[POWERPC] Change rheap functions to use ulongs instead of
pointers")
Signed-off-by: Wei Li
---
drivers/net/ethernet/freescale/ucc_
On Wed, Nov 18, 2020 at 09:34:05AM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> The list of tracepoint callbacks is managed by an array that is protected
> by RCU. To update this array, a new array is allocated, the updates are
> copied over to the new array, and then the li
On Thu, Nov 19, 2020 at 03:22:39PM -0800, Andrii Nakryiko wrote:
> __module_address() needs to be called with preemption disabled or with
> module_mutex taken. preempt_disable() is enough for read-only uses, which is
> what this fix does.
>
> Fixes: a38d1107f937 ("bpf: support raw tracepoints in m
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, November 23, 2020 6:49 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com;
On 2020-11-23 23:09, Xie He wrote:
On Mon, Nov 23, 2020 at 11:36 AM Jakub Kicinski
wrote:
> > From this point of view it will be the best to handle the NETDEV_UP in
> > the lapb event handler and establish the link analog to the
> > NETDEV_CHANGE event if the carrier is UP.
>
> Thanks! This w
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, November 23, 2020 6:58 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com;
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, November 23, 2020 6:44 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com;
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, November 23, 2020 7:59 PM
> To: Jianyong Wu
> Cc: Justin He ; k...@vger.kernel.org;
> netdev@vger.kernel.org; richardcoch...@gmail.com; linux-
> ker...@vger.kernel.org; sean.j.christopher...@intel.com; Steven Price
> ; An
If the underlying read operation failed we would end up writing stale
data to the supplied buffer. This would end up with the last
successfully read value repeating. Fix this by only writing the data
when we know the read was good. This will mean that failed values will
return 0x.
Signed-off-b
The MV88E6097 presents the serdes interrupts for ports 8 and 9 via the
Switch Global 2 registers. There is no additional layer of
enablinh/disabling the serdes interrupts like other mv88e6xxx switches.
Even though most of the serdes behaviour is the same as the MV88E6185
that chip does not provide
When a port is configured with 'managed = "in-band-status"' switch chips
like the 88E6390 need to propagate the SERDES link state to the MAC
because the link state is not correctly detected. This causes problems
on the 88E6185/88E6097 where the link partner won't see link state
changes because we'r
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for
the MV88E6097/6095/6185 so that ports 8 & 9 can be supported as serdes
ports and directly connected to other network interfaces or to SFPs
without a PHY.
Signed-off-by: Chris Packham
Reviewed-by: Andrew Lunn
---
Changes in
This small series gets my hardware into a working state. The key points are to
make sure we don't force the link and that we ask the MAC for the link status.
I also have updated my dts to say `phy-mode = "1000base-x";` and `managed =
"in-band-status";`
I've dropped the patch for the 88E6123 as it'
We sometimes run into situations where a soft/hard reset of the adapter
takes a long time or fails to complete. Having additional messages that
include important adapter state info will hopefully help understand what
is happening, reduce the guess work and minimize requests to reproduce
problems wi
On Tue, Nov 24, 2020 at 01:46:00AM +0100, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 16:02:08 +0100 Vincent Whitchurch wrote:
> > This driver uses a normal timer for TX coalescing, which means that the
> > with the default tx-usecs of 1000 microseconds the cleanups actually
> > happen 10 ms or mor
On Sun, Nov 22, 2020 at 12:01:45PM +0100, Pablo Neira Ayuso wrote:
> Hi Alexei,
>
> On Sat, Nov 21, 2020 at 07:24:24PM -0800, Alexei Starovoitov wrote:
> > On Sat, Nov 21, 2020 at 10:59 AM Pablo Neira Ayuso
> > wrote:
> > >
> > > We're lately discussing more and more usecases in the NFWS meeting
On 2020/11/24 上午3:21, Jakub Kicinski wrote:
On Mon, 23 Nov 2020 14:09:34 -0500 Steven Rostedt wrote:
On Mon, 23 Nov 2020 10:52:52 -0800
Jakub Kicinski wrote:
On Mon, 23 Nov 2020 09:31:28 -0500 Steven Rostedt wrote:
On Mon, 23 Nov 2020 13:08:55 +0200
Leon Romanovsky wrote:
[ 10
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sun, 22 Nov 2020 19:07:04 +0100 you wrote:
> s/tranport/transport/
>
> Signed-off-by: Christophe JAILLET
> ---
> net/sctp/transport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary wi
On Sat, 21 Nov 2020 08:23:30 -0500 Willem de Bruijn wrote:
> On Sat, Nov 21, 2020 at 2:56 AM Jason A. Donenfeld wrote:
> >
> > On 11/21/20, Eyal Birger wrote:
> > > In the patchset merged by commit b9fcf0a0d826
> > > ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which
> >
On Mon, 23 Nov 2020, Joe Perches wrote:
> On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> > it's not for me to prove that such patches don't affect code
> > generation. That's for the patch author and (unfortunately) for
> > reviewers.
>
> Ideally, that proof would be provided by the c
ATENCIÓN;
Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por
el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser
capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de
correo electrónico. Para revalidar su buzón de corre
ATENCIÓN;
Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por
el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser
capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de
correo electrónico. Para revalidar su buzón de corre
On Mon, 23 Nov 2020 23:55:05 +0100
Guillaume Nault wrote:
> On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote:
> > From 2f27f92d5a6f4dd69ac4af32cdb51ba8d2083606 Mon Sep 17 00:00:00 2001
> > From: Russell Strong
> > Date: Sat, 21 Nov 2020 18:12:43 +1000
> > Subject: [PATCH] DSCP in I
ATENCIÓN;
Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por
el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser
capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de
correo electrónico. Para revalidar su buzón de corre
Hi Vladimir,
> -Original Message-
> From: Vladimir Oltean
> Sent: 2020年11月24日 9:20
> To: Jakub Kicinski ; netdev@vger.kernel.org; Po Liu
> ; Claudiu Manoil
> Cc: Vinicius Costa Gomes
> Subject: [PATCH net] enetc: Advance the taprio base time in the future
>
> The tc-taprio base time i
ATENCIÓN;
Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por
el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser
capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de
correo electrónico. Para revalidar su buzón de corre
The 11/23/2020 14:05, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote:
> > >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr {
> > >>> __be16 interval;
> >
On 2020/11/20 18:30, Yang Yingliang wrote:
Hi,
I got a memleak report when doing fault-inject test:
unreferenced object 0x88810ace9000 (size 1024):
comm "ip", pid 4622, jiffies 4295457037 (age 43.378s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 .
The series LGTM, great to see chacha support!
One nit here, and when you post v2 would you mind ccing crypto?
From TLS perspective I think this code is ready to be merged, but
my crypto knowledge is close to none, so best if we give crypto
folks a chance to take a look.
On Sun, 22 Nov 2020 04:57
I am sorry for the HTML email, and I change the email client. The patch
update.
From b87d429158b4efc3f6835828f495a261e17d5af4 Mon Sep 17 00:00:00 2001
From: hby
Date: Tue, 24 Nov 2020 09:16:24 +0800
Subject: [PATCH] brmcfmac: fix compile when DEBUG is defined
The steps:
1. add "#define DEBUG"
On Mon, 23 Nov 2020 20:36:39 +0100 Matteo Croce wrote:
> On Fri, Nov 20, 2020 at 10:12 PM Jakub Kicinski wrote:
> > On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote:
> > > Currently, the openvswitch module is not accepting the correctly formated
> > > netlink message for the TTL decrement
On Mon, Nov 23, 2020 at 03:20:06PM -0500, min.li...@renesas.com wrote:
> From: Min Li
>
> Feed kstrtou8 with NULL terminated string.
>
> Changes since v1:
> -Use strscpy instead of strncpy for safety.
>
> Signed-off-by: Min Li
> ---
> drivers/ptp/ptp_clockmatrix.c | 60
>
On Sun, 22 Nov 2020 10:34:56 +0800 Wang Hai wrote:
> kmemleak report a memory leak as follows:
>
> unreferenced object 0x8880059c6a00 (size 64):
> comm "ip", pid 23696, jiffies 4296590183 (age 1755.384s)
> hex dump (first 32 bytes):
> 20 01 00 10 00 00 00 00 00 00 00 00 00 00 00 00 .
The tc-taprio base time indicates the beginning of the tc-taprio
schedule, which is cyclic by definition (where the length of the cycle
in nanoseconds is called the cycle time). The base time is a 64-bit PTP
time in the TAI domain.
Logically, the base-time should be a future time. But that imposes
On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote:
> Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable
> transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add
> CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5.
So th
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sat, 21 Nov 2020 10:03:02 +0100 you wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> Signed-off-by: Christ
On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg
wrote:
>
> Alexander Duyck wrote:
>
> > > > I'm not sure this logic is correct. Can the flow director rules
> > > > handle
> > > > a field that is removed? Last I knew it couldn't. If that is the case
> > > > you should be using ACL for any case in
On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> it's not for me to prove that such patches don't affect code
> generation. That's for the patch author and (unfortunately) for reviewers.
Ideally, that proof would be provided by the compilation system itself
and not patch authors nor reviewe
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sat, 21 Nov 2020 12:44:53 +0100 you wrote:
> Hi,
>
> fix two minor issues in the hellcreek driver.
>
> Thanks,
> Kurt
>
> [...]
Here is the summary with links:
- [net-next,1/2] net: dsa: tag_hellcreek: Cleanup inc
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 20 Nov 2020 10:06:40 -0800 you wrote:
> From: Sylwester Dziedziuch
>
> Prevent VFs from resetting when PF driver is being unloaded:
> - introduce new pf state: __I40E_VF_RESETS_DISABLED;
> - check if pf state has __I40
On Mon, 23 Nov 2020, Miguel Ojeda wrote:
> On Mon, 23 Nov 2020, Finn Thain wrote:
>
> > On Sun, 22 Nov 2020, Miguel Ojeda wrote:
> >
> > >
> > > It isn't that much effort, isn't it? Plus we need to take into
> > > account the future mistakes that it might prevent, too.
> >
> > We should als
Hi,
On Thu, Nov 12, 2020 at 12:09 PM Abhishek Kumar wrote:
>
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
>
> The board name with chip-id as option
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 20 Nov 2020 11:11:33 + you wrote:
> When the TCP stack is in SYN flood mode, the server child socket is
> created from the SYN cookie received in a TCP packet with the ACK flag
> set.
>
> The child socket is created
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 20 Nov 2020 11:47:36 +0100 you wrote:
> Starting from commit 8692cefc433f ("virtio_vsock: Fix race condition
> in virtio_transport_recv_pkt"), we discard packets in
> virtio_transport_recv_pkt() if the socket has been re
On Fri, 20 Nov 2020 16:02:08 +0100 Vincent Whitchurch wrote:
> This driver uses a normal timer for TX coalescing, which means that the
> with the default tx-usecs of 1000 microseconds the cleanups actually
> happen 10 ms or more later with HZ=100. This leads to very low
> througput with TCP when b
On Thu, 19 Nov 2020 20:37:27 -0500 Limin Wang wrote:
> Under relatively recent kernels (v4.4+), creating a vlan subport on a
> LRO supported parent NIC may turn LRO off on the parent port and
> further render its LRO feature practically unchangeable.
That does sound like an oversight in commit fd8
Hi,
I'm running into a problem with lladdr pinging all-host mcast all nodes
addr. The ping intially works but after cycling the interface that
receives the ping, the echo request packet causes a neigh solicitation
being sent on a different interface.
To repro, I included the attached namespace sc
> @@ -335,10 +336,19 @@ static int sfp_i2c_read(struct sfp *sfp, bool a2, u8
> dev_addr, void *buf,
> size_t len)
> {
> struct i2c_msg msgs[2];
> - u8 bus_addr = a2 ? 0x51 : 0x50;
> + size_t block_size;
> size_t this_len;
> + u8 bus_addr;
> int
/kernel/git/davem/net-next.git
8e1e33ffa696b2d779dd5cd422a80960b88e508c
config: arc-randconfig-r016-20201123 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin
On Mon, Nov 23, 2020 at 10:06:16PM +, Russell King wrote:
> Add debugfs support to SFP so that the internal state of the SFP state
> machines and hardware signal state can be viewed from userspace, rather
> than having to compile a debug kernel to view state state transitions
> in the kernel lo
On Thu, 19 Nov 2020 09:30:14 +0100 Björn Töpel wrote:
> Performance netperf UDP_RR:
>
> Note that netperf UDP_RR is not a heavy traffic tests, and preferred
> busy-polling is not typically something we want to use here.
>
> $ echo 20 | sudo tee /proc/sys/net/core/busy_read
> $ netperf -H 192.
On Thu, 19 Nov 2020 09:30:15 +0100 Björn Töpel wrote:
> @@ -105,7 +105,8 @@ static inline void sk_busy_loop(struct sock *sk, int
> nonblock)
> unsigned int napi_id = READ_ONCE(sk->sk_napi_id);
>
> if (napi_id >= MIN_NAPI_ID)
> - napi_busy_loop(napi_id, nonblock ? NULL : s
On Mon, Nov 23, 2020 at 02:30:09PM +0100, Daniel Borkmann wrote:
> On 11/19/20 6:37 PM, Roman Gushchin wrote:
> > Currently bpf is using the memlock rlimit for the memory accounting.
> > This approach has its downsides and over time has created a significant
> > amount of problems:
> >
> > 1) The
On Thu, 19 Nov 2020 09:30:15 +0100 Björn Töpel wrote:
> + /* The NAPI context has more processing work, but busy-polling
> + * is preferred. Exit early.
> + */
> + if (napi_prefer_busy_poll(n)) {
> + if (napi_complete_done(n, work)) {
> + /* If time
Currently ibmvnic does not support the "Disable vNIC" command from
the Hardware Management Console. The HMC uses this command to disconnect
the adapter from the network if the adapter is misbehaving or sending
malicious traffic. The effect of this command is equivalent to setting
the link to the "d
When ibmvnic fails to reset, it breaks out of the reset loop and frees
all of the remaining resets from the workqueue. Doing so prevents the
adapter from recovering if no reset is scheduled after that. Instead,
have the driver continue to process resets on the workqueue.
Remove the no longer need
scrq->msgs could be NULL during device reset, causing Linux to crash.
So, check before memset scrq->msgs.
Fixes: c8b2ad0a4a901 ("ibmvnic: Sanitize entire SCRQ buffer on reset")
Signed-off-by: Dany Madden
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 18 ++
1
send_login() does not check for the result of ibmvnic_send_crq() of the
login request. This results in the driver needlessly retrying the login
10 times even when CRQ is no longer active. Check the return code and
give up in case of errors in sending the CRQ.
The only time we want to retry is if w
From: Sukadev Bhattiprolu
If auto-priority failover is enabled, the backing device needs time
to settle if hard resetting fails for any reason. Add a delay of 60
seconds before retrying the hard-reset.
Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery")
Signed-off-by: Sukadev Bhattip
Reduce the wait time for Command Response Queue response from 30 seconds
to 20 seconds, as recommended by VIOS and Power Hypervisor teams.
Fixes: bd0b672313941 ("ibmvnic: Move login and queue negotiation into
ibmvnic_open")
Fixes: 53da09e92910f ("ibmvnic: Add set_link_state routine for setting
ada
Reset timeout is going off right after adapter reset. This patch ensures
that timeout is scheduled if it has been 5 seconds since the last reset.
5 seconds is the default watchdog timeout.
Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling")
Signed-off-by: Dany Madden
---
drivers/net/ethern
From: Sukadev Bhattiprolu
If after ibmvnic sends a LOGIN it gets a FAILOVER, it is possible that
the worker thread will start reset process and free the login response
buffer before it gets a (now stale) LOGIN_RSP. The ibmvnic tasklet will
then try to access the login response buffer and crash.
In a failed reset, driver could end up in VNIC_PROBED or VNIC_CLOSED
state and cannot recover in subsequent resets, leaving it offline.
This patch restores the adapter state to reset_state, the original
state when reset was called.
Fixes: b27507bb59ed5 ("net/ibmvnic: unlock rtnl_lock in reset so
Assorted fixes for ibmvnic originated from "[PATCH net 00/15] ibmvnic:
assorted bug fixes" sent by Lijun Pan.
V2 Changes as suggested by Jakub Kicinski:
- Added "Fixes" to each patch
- Remove "ibmvnic: process HMC disable command" from the series. Submitting it
separately to net-next.
- Squash
Inconsistent login with the vnicserver is causing the device to be
removed. This does not give the device a chance to recover from error
state. This patch schedules a FATAL reset instead to bring the adapter
up.
Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol")
Signed-off-by: Dany
On Mon, 23 Nov 2020 14:31:14 +0100 Björn Töpel wrote:
> Eric/Jakub, any more thoughts/input? Tomatoes? :-P
Looking now, sorry for the delay. Somehow patches without net in their
tag feel like they can wait..
On Thu, Nov 19, 2020 at 10:02 PM James Morris wrote:
> On Thu, 19 Nov 2020, Paul Moore wrote:
> > As pointed out by Herbert in a recent related patch, the LSM hooks do
> > not have the necessary address family information to use the flowi
> > struct safely. As none of the LSMs currently use any o
On Mon, 23 Nov 2020 16:10:37 + (UTC) Kalle Valo wrote:
> wireless-drivers fixes for v5.10
>
> First set of fixes for v5.10. One fix for iwlwifi kernel panic, others
> less notable.
>
> rtw88
>
> * fix a bogus test found by clang
>
> iwlwifi
>
> * fix long memory reads causing soft lockup w
Alexander Duyck wrote:
> > > I'm not sure this logic is correct. Can the flow director rules
> > > handle
> > > a field that is removed? Last I knew it couldn't. If that is the case
> > > you should be using ACL for any case in which a full mask is not
> > > provided. So in your tests below you co
On Mon, Nov 23, 2020 at 10:39:34PM +, Alex Belits wrote:
>
> On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote:
> > External Email
> >
> > ---
> > ---
> > On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote:
>
On Mon, Nov 23, 2020 at 02:37:13PM -0800, Jakub Kicinski wrote:
> On Mon, 23 Nov 2020 23:13:11 +0100 Martin Blumenstingl wrote:
> > > Ioana Ciornei (15):
> > > net: phy: intel-xway: implement generic .handle_interrupt() callback
> > > net: phy: intel-xway: remove the use of .ack_interrupt()
> >
On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote:
> From 2f27f92d5a6f4dd69ac4af32cdb51ba8d2083606 Mon Sep 17 00:00:00 2001
> From: Russell Strong
> Date: Sat, 21 Nov 2020 18:12:43 +1000
> Subject: [PATCH] DSCP in IPv4 routing v2
>
> This patch allows the use of DSCP values in routin
Huazhong Tan wrote:
> There are several updates relating to the interrupt coalesce for
> the HNS3 ethernet driver.
>
> #1 adds support for QL(quantity limiting, interrupt coalesce
>based on the frame quantity).
> #2 queries the maximum value of GL from the firmware instead of
>a fixed val
On Sun, Nov 22, 2020 at 10:36:01AM +0200, Tariq Toukan wrote:
>
>
> On 11/20/2020 8:31 PM, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of just letting the code
> > fall through to the ne
On Fri, Nov 20, 2020 at 09:50:06PM +0300, Igor Russkikh wrote:
>
>
> On 20/11/2020 9:26 pm, Gustavo A. R. Silva wrote:
> > External Email
> >
> > --
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> >
On Fri, Nov 20, 2020 at 11:47:37PM +0100, Florian Westphal wrote:
> Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> > warnings by explicitly adding multiple break statements instead of just
> > letting the code fall through to the next case.
Claudiu Manoil wrote:
> These particular fields are specified in the H/W reference
> manual as having network byte order format, so enforce big
> endian annotation for them and clear the related sparse
> warnings in the process.
>
> Signed-off-by: Claudiu Manoil
Thanks for fixing these warnings
On Mon, 23 Nov 2020 23:31:48 +0100 Horatiu Vultur wrote:
> > The existing structs are only present in net-next as well, so if you
> > don't mind Horatiu it'd be good to follow up and remove the unused ones
> > and move the ones (if any) which are only used by the kernel but not by
> > the user spac
Jakub Kicinski wrote:
> linux/netdevice.h is included in very many places, touching any
> of its dependecies causes large incremental builds.
>
> Drop the linux/ethtool.h include, linux/netdevice.h just needs
> a forward declaration of struct ethtool_ops.
>
> Fix all the places which made use of
On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote:
> External Email
>
> ---
> ---
> On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote:
> > From: Yuri Norov
> >
> > Make sure that kick_all_cpus_sync() does not c
Moshe Shemesh wrote:
> From: Vladyslav Tarasiuk
>
> CMIS 4.0 document describes a universal EEPROM memory layout, which is
> used for some modules such as DSFP, OSFP and QSFP-DD modules. In order
> to distinguish them in userspace from existing standards, add
> corresponding values.
>
> CMIS 4.
On Mon, 23 Nov 2020 23:13:11 +0100 Martin Blumenstingl wrote:
> > Ioana Ciornei (15):
> > net: phy: intel-xway: implement generic .handle_interrupt() callback
> > net: phy: intel-xway: remove the use of .ack_interrupt()
> > net: phy: icplus: implement generic .handle_interrupt() callback
> >
On Mon, Nov 23 2020 at 17:58, Alex Belits wrote:
> From: Yuri Norov
>
> For nohz_full CPUs the desirable behavior is to receive interrupts
> generated by tick_nohz_full_kick_cpu(). But for hard isolation it's
> obviously not desirable because it breaks isolation.
>
> This patch adds check for it.
On Mon, 2020-11-23 at 23:13 +0100, Frederic Weisbecker wrote:
> External Email
>
> ---
> ---
> Hi Alex,
>
> On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote:
> > From: Yuri Norov
> >
> > For nohz_full CPUs the desirable
1 - 100 of 377 matches
Mail list logo
