On Mon, Nov 23, 2020 at 10:06:16PM +0000, Russell King wrote: > Add debugfs support to SFP so that the internal state of the SFP state > machines and hardware signal state can be viewed from userspace, rather > than having to compile a debug kernel to view state state transitions > in the kernel log. The 'state' output looks like: > > Module state: empty > Module probe attempts: 0 0 > Device state: up > Main state: down > Fault recovery remaining retries: 5 > PHY probe remaining retries: 12 > moddef0: 0 > rx_los: 1 > tx_fault: 1 > tx_disable: 1 > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
Hi Russell This looks useful. I always seem to end up recompiling the kernel, which as you said, this should avoid. Reviewed-by: Andrew Lunn <and...@lunn.ch> Andrew