Re: [PATCH 1/3] net: mac80211: use core API for updating TX stats

2020-11-12 Thread Heiner Kallweit
Am 12.11.2020 um 12:09 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") > has added function "dev_sw_netstats_tx_add()" to update > net device per-cpu TX stats. > > Use this function instead of ieee80211_tx_stats(). > I think you can do the same with ieee8021

Re: [PATCH 2/3] net: openvswitch: use core API for updating TX stats

2020-11-12 Thread Heiner Kallweit
Am 12.11.2020 um 12:11 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. While on it, replace > "len" variable with "skb->len". >

Re: [PATCH 1/3] net: mac80211: use core API for updating TX stats

2020-11-12 Thread Heiner Kallweit
Am 13.11.2020 um 00:30 schrieb Jakub Kicinski: > On Thu, 12 Nov 2020 13:09:53 +0200 Lev Stipakov wrote: >> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") >> has added function "dev_sw_netstats_tx_add()" to update >> net device per-cpu TX stats. >> >> Use this function instead of iee

Re: [PATCH 3/3] net: xfrm: use core API for updating TX stats

2020-11-12 Thread Heiner Kallweit
Am 12.11.2020 um 12:13 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > LGTM. In addition you can replace xfrmi_get_stats64()

Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-11-12 Thread Kristian Evensen
Hi Daniele, On Thu, Nov 12, 2020 at 7:29 PM Daniele Palmas wrote: > thanks for testing. Still thinking it could be better to differentiate > between raw-ip and qmap, but not yet able to find the time to perform > some tests on my own. I agree that separating between qmap and non-qmap would be ni

Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-12 Thread Kegl Rohit
> What are the addresses of the ring entries? > I bet there is something wrong with the cache coherency and/or > flushing. > > So the MAC hardware has done the write but (somewhere) it > isn't visible to the cpu for ages. CMA memory is disabled in our kernel config. So the descriptors allocated wi

Re: [PATCH net-next 2/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Krzysztof Kozlowski
On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon wrote: > > > Add the device tree bindings for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: Bongsu Jeon > --- > .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 +++

Re: [PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Krzysztof Kozlowski
On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon wrote: > > > Add driver for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/Kconfig | 1 + > drivers/nfc/Makefile| 1 + > dr

[PATCH net-next RFC v2] MAINTAINERS: Add Martin Schiller as a maintainer for the X.25 stack

2020-11-12 Thread Xie He
Martin Schiller is an active developer and reviewer for the X.25 code. His company is providing products based on the Linux X.25 stack. So he is a good candidate for maintainers of the X.25 code. The original maintainer of the X.25 network layer (Andrew Hendry) has not sent any email to the netdev

Re: [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()

2020-11-12 Thread Kurt Kanzenbach
On Thu Nov 12 2020, YueHaibing wrote: > drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn: > passing zero to 'PTR_ERR' > > ptp_clock_register() returns ERR_PTR() and never returns > NULL. The NULL test should be removed. Which is not true. From the documentation: * Ret

[PATCH net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe()

2020-11-12 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/

[PATCH net] net: stmmac: dwmac-intel-plat: fix error return code in intel_eth_plat_probe()

2020-11-12 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 9efc9b2b04c7 ("net: stmmac: Add dwmac-intel-plat for GBE driver") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel

[PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()

2020-11-12 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/wireless/broadcom/brcm80211/brc

[PATCH net] qlcnic: fix error return code in qlcnic_83xx_restart_hw()

2020-11-12 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 3ced0a88cd4c ("qlcnic: Add support to run firmware POST") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c |

[PATCH net] cx82310_eth: fix error return code in cx82310_bind()

2020-11-12 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: ca139d76b0d9 ("cx82310_eth: re-enable ethernet mode after router reboot") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/usb/cx82310_eth.c | 3 ++-

Re: [PATCH net-next 12/12] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-12 Thread drt
On 2020-11-12 11:10, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the pack

Re: [PATCH net-next 01/12] ibmvnic: Ensure that subCRQ entry reads are ordered

2020-11-12 Thread drt
On 2020-11-12 11:09, Thomas Falcon wrote: Ensure that received Subordinate Command-Response Queue entries are properly read in order by the driver. Signed-off-by: Thomas Falcon Acked-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 file changed, 4 insertions(+) diff --g

Re: KASAN: vmalloc-out-of-bounds Read in bpf_trace_run3

2020-11-12 Thread Matt Mullins
On Wed, Nov 11, 2020 at 03:57:50PM +0100, Dmitry Vyukov wrote: > On Mon, Nov 2, 2020 at 12:54 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:080b6f40 bpf: Don't rely on GCC __attribute__((optimize)) .. > > git tree: bpf > > console outp

Re: linux-x25 mail list not working

2020-11-12 Thread Martin Schiller
On 2020-11-13 03:17, John 'Warthog9' Hawley wrote: Give it a try now, there was a little wonkiness with the alias setup for it, and I have no historical context for a 'why', but I adjusted a couple of things and I was able to subscribe myself. - John 'Warthog9' Hawley Thanks a lot John! Now it

[PATCH net-next 2/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Bongsu Jeon
Add the device tree bindings for Samsung S3FWRN82 NFC controller. S3FWRN82 is using NCI protocol and I2C communication interface. Signed-off-by: Bongsu Jeon --- .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Document

[PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Bongsu Jeon
Add driver for Samsung S3FWRN82 NFC controller. S3FWRN82 is using NCI protocol and I2C communication interface. Signed-off-by: Bongsu Jeon --- drivers/nfc/Kconfig | 1 + drivers/nfc/Makefile| 1 + drivers/nfc/s3fwrn82/Kconfig| 15 ++ drivers/nfc/s3fwrn82/Makefi

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2020 at 7:40 PM Andrew Morton wrote: > > On Thu, 12 Nov 2020 19:25:48 -0800 Alexei Starovoitov > wrote: > > > On Thu, Nov 12, 2020 at 7:18 PM Andrew Morton > > wrote: > > > > > > On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov > > > wrote: > > > > > > > On Thu, Nov 12,

Re: [PATCH net V4] Exempt multicast addresses from five-second neighbor lifetime

2020-11-12 Thread David Ahern
On 11/12/20 6:58 PM, Jeff Dike wrote: > Commit 58956317c8de ("neighbor: Improve garbage collection") > guarantees neighbour table entries a five-second lifetime. Processes > which make heavy use of multicast can fill the neighour table with > multicast addresses in five seconds. At that point, ne

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Roman Gushchin
On Thu, Nov 12, 2020 at 07:25:48PM -0800, Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 7:18 PM Andrew Morton > wrote: > > > > On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov > > wrote: > > > > > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > > > > > > > These p

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-12 Thread David Ahern
On 11/12/20 4:20 PM, Daniel Borkmann wrote: > built-in given it otherwise comes with the base distro already. But then > my question is what is planned here as deprecation process for the built-in > lib/bpf.c code? I presume we'll remove it eventually to move on? It will need to follow the establi

Re: [PATCH stable] net: sch_generic: fix the missing new qdisc assignment bug

2020-11-12 Thread Brian Norris
On Tue, Nov 03, 2020 at 11:25:38AM +0800, Yunsheng Lin wrote: > commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue op > for lockless qdisc") > > When the above upstream commit is backported to stable kernel, > one assignment is missing, which causes two problems reported >

[PATCH] net/nfc/nic: refined function nci_hci_resp_received

2020-11-12 Thread Alex Shi
We don't use the parameter result actually, so better to remove it and skip a gcc warning for unused variable. Signed-off-by: Alex Shi Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- net/nfc/nci/hci.c | 9 +++-- 1 file changed, 3

Re: [PATCH net-next v2 10/11] net: dsa: microchip: ksz9477: add Pulse Per Second (PPS) support

2020-11-12 Thread Richard Cochran
On Fri, Nov 13, 2020 at 04:53:11AM +0200, Vladimir Oltean wrote: > Richard, do you think we can clarify the intended usage of PTP_CLK_REQ_PPS > in the documentation? It doesn't appear to be written anywhere that > PTP_ENABLE_PPS is supposed to enable event generation for the drivers/pps > subsyste

Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-11-12 Thread Florian Fainelli
On 11/9/2020 4:38 AM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 02:31:11PM +0200, Vladimir Oltean wrote: >> I need to sit on this for a while. How many DSA drivers do we have that >> don't do SA learning in hardware for CPU-injected packets? ocelot/felix >> and mv88e6xxx? Who else? Becaus

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Andrew Morton
On Thu, 12 Nov 2020 19:25:48 -0800 Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 7:18 PM Andrew Morton > wrote: > > > > On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov > > wrote: > > > > > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > > > > > > > These patch

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-12 Thread Stephen Hemminger
On Fri, 13 Nov 2020 12:06:37 +1000 Russell Strong wrote: > diff --git a/include/uapi/linux/in_route.h > b/include/uapi/linux/in_route.h index 0cc2c23b47f8..db5d236b9c50 100644 > --- a/include/uapi/linux/in_route.h > +++ b/include/uapi/linux/in_route.h > @@ -28,6 +28,6 @@ > > #define RTCF_NAT

Re: [PATCH net-next v2 09/11] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-11-12 Thread Richard Cochran
On Fri, Nov 13, 2020 at 04:40:20AM +0200, Vladimir Oltean wrote: > > @@ -103,6 +108,10 @@ static int ksz9477_ptp_adjtime(struct ptp_clock_info > > *ptp, s64 delta) > > if (ret) > > goto error_return; > > > > + spin_lock_irqsave(&dev->ptp_clock_lock, flags); > > I believe that sp

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2020 at 7:18 PM Andrew Morton wrote: > > On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov > wrote: > > > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > > > > > These patches are not intended to be merged through the bpf tree. > > > They are included into

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-12 Thread Richard Cochran
On Thu, Nov 12, 2020 at 03:46:12PM -0800, Vinicius Costa Gomes wrote: > I wanted it so using PCIe PTM was transparent to applications, so adding > another API wouldn't be my preference. > > That being said, having a trigger from the application to start/stop the > PTM cycles doesn't sound too bad

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Andrew Morton
On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > > > These patches are not intended to be merged through the bpf tree. > > They are included into the patchset to make bpf selftests pass and for > > informational p

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-11-12 Thread Herbert Xu
On Wed, Nov 11, 2020 at 04:10:39PM -0800, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote: > > CPT offload module utilises the linux crypto framework to offload > > crypto processing. This patch registers supported algorithms by > > calling registration functions prov

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > These patches are not intended to be merged through the bpf tree. > They are included into the patchset to make bpf selftests pass and for > informational purposes. > It's written in the cover letter. ... > Maybe I had to just lis

Re: [PATCH v2 bpf-next 0/4] bpf: Enable bpf_sk_storage for FENTRY/FEXIT/RAW_TP

2020-11-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 12 Nov 2020 13:12:55 -0800 you wrote: > This set is to allow the FENTRY/FEXIT/RAW_TP tracing program to use > bpf_sk_storage. The first two patches are a cleanup. The last patch is > tests. Patch 3 has the required

Re: [PATCH net-next v2 10/11] net: dsa: microchip: ksz9477: add Pulse Per Second (PPS) support

2020-11-12 Thread Vladimir Oltean
On Thu, Nov 12, 2020 at 04:35:36PM +0100, Christian Eggers wrote: > static int ksz9477_ptp_enable(struct ptp_clock_info *ptp, struct > ptp_clock_request *req, int on) > { > - return -ENOTTY; > + struct ksz_device *dev = container_of(ptp, struct ksz_device, ptp_caps); > + int ret; > +

Re: [PATCH net-next v2 09/11] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-11-12 Thread Vladimir Oltean
On Thu, Nov 12, 2020 at 04:35:35PM +0100, Christian Eggers wrote: > Add routines required for TX hardware time stamping. > > The KSZ9563 only supports one step time stamping > (HWTSTAMP_TX_ONESTEP_P2P), which requires linuxptp-2.0 or later. PTP > mode is permanently enabled (changes tail tag; depen

Re: [net-next 1/8] tcp: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-11-12 Thread kernel test robot
Hi Arjun, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Arjun-Roy/Perf-optimizations-for-TCP-Recv-Zerocopy/20201113-030506 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-nex

Re: [PATCH net] net: dsa: lantiq_gswip: add missed clk_disable_unprepare() in gswip_gphy_fw_load()

2020-11-12 Thread Zhang Changzhong
On 2020/11/12 20:41, Vladimir Oltean wrote: > > gswip_gphy_fw_list > -> gswip_gphy_fw_probe >-> gswip_gphy_fw_load > -> clk_prepare_enable > -> then fails > > Then gswip_gphy_fw_list does this: > for_each_available_child_of_node(gphy_fw_list_np, gphy_fw_np) { >

Re: [PATCH net] net/tls: Fix wrong record sn in async mode of device resync

2020-11-12 Thread Jakub Kicinski
On Wed, 11 Nov 2020 14:55:56 +0200 Tariq Toukan wrote: > +static inline bool tls_bigint_subtract(unsigned char *seq, int len, u16 n) Please make n something more natural than u16. Helper should be general, not just serving the current use case. > + if (WARN_ON_ONCE(len != 8)) You can do a B

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-12 Thread Marcelo Ricardo Leitner
On Thu, Nov 12, 2020 at 02:20:58PM -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 11:24:57 +0800 we...@ucloud.cn wrote: > > v7-v10: fix __rcu warning > > Are you reposting stuff just to get it build tested? > > This is absolutely unacceptable. I don't know if that's the case, but maybe we c

Re: linux-x25 mail list not working

2020-11-12 Thread John 'Warthog9' Hawley
Give it a try now, there was a little wonkiness with the alias setup for it, and I have no historical context for a 'why', but I adjusted a couple of things and I was able to subscribe myself. - John 'Warthog9' Hawley On 11/12/2020 10:27 AM, Xie He wrote: Hi Linux maintainers, The linux-x25

Re: [PATCH net-next 00/18] net: phy: add support for shared interrupts (part 2)

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 17:54:55 +0200 Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set aims to actually add support for shared interrupts in > phylib and not only for multi-PHY devices. While we are at it, > streamline the interrupt handling in phylib. Ioana, would you mind resending?

Re: [PATCH v6] lib: optimize cpumask_local_spread()

2020-11-12 Thread Shaokun Zhang
Hi Dave, 在 2020/11/5 0:10, Dave Hansen 写道: > On 11/3/20 5:39 AM, Shaokun Zhang wrote: >> Currently, Intel DDIO affects only local sockets, so its performance >> improvement is due to the relative difference in performance between the >> local socket I/O and remote socket I/O.To ensure that Intel D

Re: [PATCH net-next 1/1] netdevsim: support ethtool ring and coalesce settings

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 16:12:29 +0100 Antonio Cardace wrote: > Add ethtool ring and coalesce settings support for testing. > > Signed-off-by: Antonio Cardace Please add a test to tools/testing/.../netdevsim/ We don't add functionality to netdevsim unless there is a in-tree test that exercises it.

[PATCH net-next] net: DSCP in IPv4 routing

2020-11-12 Thread Russell Strong
TOS handling in ipv4 routing does not support using dscp. This change widens masks to use the 6 DSCP bits in routing. Tested with ip rule add dsfield EF lookup main ip rule 0: from all lookup local 32765: from all tos EF lookup main 32766: from all lookup main 32767: from all lookup defau

Re: [PATCH net v2] net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 02:35:06 -0800 Xie He wrote: > The x25_disconnect function in x25_subr.c would decrease the refcount of > "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL. > > However, the x25_rx_call_request function in af_x25.c, which is called > when we receive a connectio

Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Dave Hansen
On 11/12/20 5:53 PM, Jakub Kicinski wrote: >> I do agree, though, that it's confusing *what* they reported, especially >> if the patch in question is fixing something *else*. Rather than invent >> a new tag, maybe a comment would suffice: >> >> Reported-by: kernel test robot # bug in earlier revi

Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 12:41:26 +0100 Bartosz Golaszewski wrote: > On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong > wrote: > > > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk

Re: [PATCH net V3] Exempt multicast addresses from five-second neighbor lifetime

2020-11-12 Thread Jeff Dike
Hi Jakub, Yes to all your suggestions. Thanks for the review. Jeff On 11/12/20 12:32 PM, Jakub Kicinski wrote: > On Tue, 10 Nov 2020 12:23:05 -0500 Jeff Dike wrote: >> Commit 58956317c8de ("neighbor: Improve garbage collection") >> guarantees neighbour table entries a five-second lifetime. Pro

[PATCH net V4] Exempt multicast addresses from five-second neighbor lifetime

2020-11-12 Thread Jeff Dike
Commit 58956317c8de ("neighbor: Improve garbage collection") guarantees neighbour table entries a five-second lifetime. Processes which make heavy use of multicast can fill the neighour table with multicast addresses in five seconds. At that point, neighbour entries can't be GC-ed because they ar

Re: [PATCH net-next] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Jakub Kicinski
On Fri, 13 Nov 2020 10:47:30 +0900 Bongsu Jeon wrote: > Add driver for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: bongsujeon I think you've only read my first review comment, there is more comments inline in my reply.

[PATCH net-next V4] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Dmytro Shytyi
Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly generated hostID or stable privacy + privacy extensions). The main problem is that SLAAC RA or PD allocates a /64 by the Wireless carrier 4G, 5G to a mobile hotspot, however segmentation of the /64 via SLAAC is required so tha

Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 17:43:56 -0800 Dave Hansen wrote: > On 11/12/20 4:24 PM, Jakub Kicinski wrote: > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > >> If you fix the issue, kindly add following tag as appropriate > >> Reported-by: kernel test robot > > Good people of kernel te

Re: [PATCH net-next V3] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Dmytro Shytyi
Hello, On Fri, 13 Nov 2020 01:21:56 +0100 Jakub Kicinski wrote > On Thu, 12 Nov 2020 16:44:54 +0100 Dmytro Shytyi wrote: > > Reported-by: kernel test robot > > You don't have to add the reported by tag just because the bot pointed > out issues in the previous vers

Re: [PATCH net-next V3] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Dmytro Shytyi
Hello, On Thu, 12 Nov 2020 17:55:08 +0100 Hideaki Yoshifuji wrote > Hi, > > 2020年11月13日(金) 0:46 Dmytro Shytyi : > > > > Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly > > generated hostID or stable privacy + privacy extensions). > > The main pro

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-12 Thread David Ahern
On 11/12/20 6:28 PM, Andrea Mayer wrote: > The implementation of SRv6 End.DT4 differs from the the implementation of SRv6 > End.DT6 due to the different *route input* lookup functions. For IPv6 is it > possible to force the routing lookup specifying a routing table through the > ip6_pol_route() fun

[PATCH net-next] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Bongsu Jeon
Add driver for Samsung S3FWRN82 NFC controller. S3FWRN82 is using NCI protocol and I2C communication interface. Signed-off-by: bongsujeon --- .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 ++ drivers/nfc/Kconfig | 1 + drivers/nfc/Makefile

Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Dave Hansen
On 11/12/20 4:24 PM, Jakub Kicinski wrote: > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot > Good people of kernel test robot, could you please rephrase this to say > that the tag is on

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-12 Thread Andrea Mayer
Hi Jakub, many thanks for your review. Please see my responses inline: On Tue, 10 Nov 2020 15:12:55 -0800 Jakub Kicinski wrote: > On Sat, 7 Nov 2020 16:31:38 +0100 Andrea Mayer wrote: > > SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. > > > > The SRv6 End.DT4 is used to implement

Re: [PATCH] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 17:20:47 +0900 Bongsu Jeon wrote: > Add driver for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: bongsujeon Please put [PATCH net-next] in the subject so we know this will go into the net-next tree. > di

[PATCH] net: stmmac: dwmac_lib: enlarge dma reset timeout

2020-11-12 Thread Jisheng Zhang
If the phy enables power saving technology, the dwmac's software reset needs more time to complete, enlarge dma reset timeout to 20us. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [net-next,v2,3/5] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-11-12 Thread Andrea Mayer
Hi Jakub, many thanks for your review. Please see my responses inline: On Tue, 10 Nov 2020 14:56:55 -0800 Jakub Kicinski wrote: > On Sat, 7 Nov 2020 16:31:37 +0100 Andrea Mayer wrote: > > We introduce two callbacks used for customizing the creation/destruction of > > a SRv6 behavior. Such callb

Re: [PATCH netdev 2/2] virtio, xdp: Allow xdp to load, even if there is not enough queue

2020-11-12 Thread Jason Wang
On 2020/11/12 下午5:15, Xuan Zhuo wrote: Since XDP_TX uses an independent queue to send data by default, and requires a queue for each CPU, this condition is often not met when the number of CPUs is relatively large, but XDP_TX is not used in many cases. I hope In this case, XDP is allowed to loa

Re: [PATCH netdev 1/2] virtio: add module option to turn off guest offloads

2020-11-12 Thread Jason Wang
On 2020/11/12 下午4:11, Xuan Zhuo wrote: * VIRTIO_NET_F_GUEST_CSUM * VIRTIO_NET_F_GUEST_TSO4 * VIRTIO_NET_F_GUEST_TSO6 * VIRTIO_NET_F_GUEST_ECN * VIRTIO_NET_F_GUEST_UFO * VIRTIO_NET_F_MTU If these features are negotiated successfully, it may cause virtio-net to receive large packages, which will

Re: [PATCH v2] net/ncsi: Fix netlink registration

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 08:25:39 -0800 Samuel Mendoza-Jonas wrote: > On Thu, 2020-11-12 at 16:42 +1030, Joel Stanley wrote: > > If a user unbinds and re-binds a NC-SI aware driver the kernel will > > attempt to register the netlink interface at runtime. The structure > > is > > marked __ro_after_init s

RE: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Li, Philip
> > On Fri, 13 Nov 2020 00:32:55 + Li, Philip wrote: > > > Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC > with > > > prefixes of arbitrary length in PIO > > > > > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > > > > If you fix the issue, kindly add fol

Re: [GIT PULL] Networking

2020-11-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Thu, 12 Nov 2020 11:02:45 -0800 you wrote: > The following changes since commit bf3e76289cd28b87f679cd53e26d67fd708d718a: > > Merge branch 'mtd/fixes' of > git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux (2

Re: [net-next,v2,2/5] seg6: improve management of behavior attributes

2020-11-12 Thread Andrea Mayer
Hi Jakub, many thanks for your review. Please see my responses inline: On Tue, 10 Nov 2020 14:50:21 -0800 Jakub Kicinski wrote: > On Sat, 7 Nov 2020 16:31:36 +0100 Andrea Mayer wrote: > > Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), > > the parse() callback performs

Re: [PATCH net-next v2 08/11] net: ptp: add helper for one-step P2P clocks

2020-11-12 Thread Vladimir Oltean
On Thu, Nov 12, 2020 at 04:35:34PM +0100, Christian Eggers wrote: > This function subtracts the ingress hardware time stamp from the > correction field of a PTP header and updates the UDP checksum (if UDP is > used as transport. It is needed for hardware capable of one-step P2P Please close the pa

Re: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Jakub Kicinski
On Fri, 13 Nov 2020 00:32:55 + Li, Philip wrote: > > Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with > > prefixes of arbitrary length in PIO > > > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > > > If you fix the issue, kindly add following tag as

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-12 Thread John Fastabend
Jakub Sitnicki wrote: > On Thu, Nov 12, 2020 at 12:06 AM CET, Daniel Borkmann wrote: > > [...] > > >>> I'm not initimately familiar with this test, but looking at the change > >>> I'd consider that Destinations Options and encapsulation headers can > >>> follow the Fragment Header. > >>> > >>> Wi

Re: [PATCH v2 bpf-next 0/3] bpf: Pointers beyond packet end.

2020-11-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 10 Nov 2020 19:12:10 -0800 you wrote: > From: Alexei Starovoitov > > v1->v2: > - removed set-but-unused variable. > - added Jiri's Tested-by. > > In some cases LLVM uses the knowledge that branch is taken to optimz

Re: [PATCH v2 bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-11-12 Thread Daniel Borkmann
On 11/13/20 1:09 AM, Alexei Starovoitov wrote: On Fri, Nov 13, 2020 at 12:56:52AM +0100, Daniel Borkmann wrote: On 11/12/20 8:16 PM, John Fastabend wrote: Alexei Starovoitov wrote: From: Alexei Starovoitov This patch adds the verifier support to recognize inlined branch conditions. The LLVM

Re: [PATCH net] net: lan78xx: Disable hardware vlan filtering in promiscuous mode

2020-11-12 Thread Jakub Kicinski
On Wed, 11 Nov 2020 07:43:41 -0800 Jakub Kicinski wrote: > > In order to receive those tagged frames it is necessary to manually > > disable > > rx vlan filtering using ethtool ( `ethtool -K ethX rx-vlan-filter off` > > or > > corresponding ioctls ). Setting all bits in the vlan filte

Re: [PATCH net-next 2/2] net/mlx5e: Add DSFP EEPROM dump support to ethtool

2020-11-12 Thread Andrew Lunn
On Thu, Nov 12, 2020 at 05:54:51PM +0200, Moshe Shemesh wrote: > > On 11/12/2020 3:13 PM, Andrew Lunn wrote: > > On Thu, Nov 12, 2020 at 07:49:41AM +0200, Moshe Shemesh wrote: > > > From: Vladyslav Tarasiuk > > > > > > DSFP is a new cable module type, which EEPROM uses memory layout > > > descri

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2020 at 4:35 PM Stephen Hemminger wrote: > > On Fri, 13 Nov 2020 00:20:52 +0100 > Daniel Borkmann wrote: > > > On 11/12/20 11:36 PM, Toke Høiland-Jørgensen wrote: > > > Daniel Borkmann writes: > > > > > >>> Besides, for the entire history of BPF support in iproute2 so far, the >

Re: [net-next,v2,1/5] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-12 Thread Andrea Mayer
Hi Jakub, On Tue, 10 Nov 2020 14:50:45 -0800 Jakub Kicinski wrote: > On Sat, 7 Nov 2020 16:31:35 +0100 Andrea Mayer wrote: > > Before this patch, a sniffer attached to a VRF used as the receiving > > interface of L3 tunneled packets detects them as malformed packets and > > it complains about t

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-12 Thread Stephen Hemminger
On Fri, 13 Nov 2020 00:20:52 +0100 Daniel Borkmann wrote: > On 11/12/20 11:36 PM, Toke Høiland-Jørgensen wrote: > > Daniel Borkmann writes: > > > >>> Besides, for the entire history of BPF support in iproute2 so far, the > >>> benefit has come from all the features that libbpf has just starte

Re: [PATCH v2 bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-11-12 Thread John Fastabend
Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 11:16:11AM -0800, John Fastabend wrote: > > Alexei Starovoitov wrote: > > > From: Alexei Starovoitov > > > > > > This patch adds the verifier support to recognize inlined branch > > > conditions. > > > The LLVM knows that the branch evaluates t

RE: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Li, Philip
> Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with > prefixes of arbitrary length in PIO > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > Good people

Re: [PATCH bpf] MAINTAINERS/bpf: Update Andrii's entry.

2020-11-12 Thread Andrii Nakryiko
On Thu, Nov 12, 2020 at 12:52 PM KP Singh wrote: > > On Thu, Nov 12, 2020 at 9:13 PM Toke Høiland-Jørgensen > wrote: > > > > Daniel Borkmann writes: > > > > > On 11/12/20 7:03 PM, Alexei Starovoitov wrote: > > >> From: Alexei Starovoitov > > >> > > >> Andrii has been a de-facto maintainer for

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Roman Gushchin
On Fri, Nov 13, 2020 at 09:56:32AM +1100, Stephen Rothwell wrote: > Hi Roman, > > On Thu, 12 Nov 2020 14:15:10 -0800 Roman Gushchin wrote: > > > > Patch series "mm: allow mapping accounted kernel pages to userspace", v6. > > > > Currently a non-slab kernel page which has been charged to a memory

Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Jakub Kicinski
On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot Good people of kernel test robot, could you please rephrase this to say that the tag is only appropriate if someone is sending a fix up/foll

Re: [PATCH net-next V3] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 16:44:54 +0100 Dmytro Shytyi wrote: > Reported-by: kernel test robot You don't have to add the reported by tag just because the bot pointed out issues in the previous version.

Re: [PATCH net-next] selftests: set conf.all.rp_filter=0 in bareudp.sh

2020-11-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 11 Nov 2020 16:05:35 +0100 you wrote: > When working on the rp_filter problem, I didn't realise that disabling > it on the network devices didn't cover all cases: rp_filter could also > be enabled globally in the na

Re: [PATCH v2 bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-11-12 Thread Alexei Starovoitov
On Fri, Nov 13, 2020 at 12:56:52AM +0100, Daniel Borkmann wrote: > On 11/12/20 8:16 PM, John Fastabend wrote: > > Alexei Starovoitov wrote: > > > From: Alexei Starovoitov > > > > > > This patch adds the verifier support to recognize inlined branch > > > conditions. > > > The LLVM knows that the

[net-next] devlink: move request_firmware out of driver

2020-11-12 Thread Jacob Keller
All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_update implementation, perform the request_firmw

Re: [PATCH net-next 00/15] mlxsw: spectrum: Prepare for XM implementation - prefix insertion and removal

2020-11-12 Thread Jakub Kicinski
On Tue, 10 Nov 2020 11:48:45 +0200 Ido Schimmel wrote: > Jiri says: > > This is a preparation patchset for follow-up support of boards with > extended mezzanine (XM), which is going to allow extended (scale-wise) > router offload. > > XM requires a separate PRM register named XMDR to be used inst

Re: [PATCH v2 bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2020 at 11:16:11AM -0800, John Fastabend wrote: > Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > This patch adds the verifier support to recognize inlined branch conditions. > > The LLVM knows that the branch evaluates to the same value, but the verifier > > couldn

Re: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Saeed Mahameed
On Thu, 2020-11-12 at 22:28 +0800, YueHaibing wrote: > Fix smatch warnings: > > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105 > esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR' > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177 > esw_acl_egress_ofld_

Re: [PATCH v2 bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-11-12 Thread Daniel Borkmann
On 11/12/20 8:16 PM, John Fastabend wrote: Alexei Starovoitov wrote: From: Alexei Starovoitov This patch adds the verifier support to recognize inlined branch conditions. The LLVM knows that the branch evaluates to the same value, but the verifier couldn't track it. Hence causing valid program

Re: [PATCH net-next v2 07/11] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-11-12 Thread Vladimir Oltean
On Thu, Nov 12, 2020 at 04:35:33PM +0100, Christian Eggers wrote: > diff --git a/drivers/net/dsa/microchip/Kconfig > b/drivers/net/dsa/microchip/Kconfig > index 4ec6a47b7f72..71cc910e5941 100644 > --- a/drivers/net/dsa/microchip/Kconfig > +++ b/drivers/net/dsa/microchip/Kconfig > @@ -24,6 +24,15 @

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-12 Thread Vinicius Costa Gomes
Miroslav Lichvar writes: > Considering how the existing applications work, ideally the > measurements would be performed on demand from the ioctl to minimize > the delay. If that's not possible, maybe it would be better to provide > the measurements on a descriptor at their own rate, which could

Re: [PATCH 1/3] net: mac80211: use core API for updating TX stats

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:09:53 +0200 Lev Stipakov wrote: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") > has added function "dev_sw_netstats_tx_add()" to update > net device per-cpu TX stats. > > Use this function instead of ieee80211_tx_stats(). > > Signed-off-by: Lev Stipakov

[bpf PATCH v2 6/6] bpf, sockmap: Avoid failures from skb_to_sgvec when skb has frag_list

2020-11-12 Thread John Fastabend
When skb has a frag_list its possible for skb_to_sgvec() to fail. This happens when the scatterlist has fewer elements to store pages than would be needed for the initial skb plus any of its frags. This case appears rare, but is possible when running an RX parser/verdict programs exposed to the in

[bpf PATCH v2 5/6] bpf, sockmap: Handle memory acct if skb_verdict prog redirects to self

2020-11-12 Thread John Fastabend
If the skb_verdict_prog redirects an skb knowingly to itself, fix your BPF program this is not optimal and an abuse of the API please use SK_PASS. That said there may be cases, such as socket load balancing, where picking the socket is hashed based or otherwise picks the same socket it was received

  1   2   3   4   5   >