On Wed, 11 Nov 2020 14:55:56 +0200 Tariq Toukan wrote: > +static inline bool tls_bigint_subtract(unsigned char *seq, int len, u16 n)
Please make n something more natural than u16. Helper should be general, not just serving the current use case. > + if (WARN_ON_ONCE(len != 8)) You can do a BUILD_BUG_ON on TLS_MAX_REC_SEQ_SIZE instead, please. > + /* shouldn't get to wraparound, too long in async stage, > something bad happened */ Umpf. Please wrap this comment. In general for networking code prefer the 80 char wrapping.
