On 03-10-2020 04:08, David Miller wrote:
> From: Anant Thazhemadam
> Date: Fri, 2 Oct 2020 17:04:13 +0530
>
>> But this patch is about ensuring that an uninitialized variable's
>> value (whatever that may be) is not set as the ethernet address
>> blindly (without any form of checking if get_regi
On 2020-10-03 07:59 +0800, Coiby Xu wrote:
> This fixes commit 0107635e15ac
> ("staging: qlge: replace pr_err with netdev_err") which introduced an
> build breakage of missing `struct ql_adapter *qdev` for some functions
> and a warning of type mismatch with dumping enabled, i.e.,
>
> $ make CFLAG
On 02-10-2020 19:59, Petko Manolov wrote:
> On 20-10-02 17:35:25, Anant Thazhemadam wrote:
>> Yes, this clears things up for me. I'll see to it that this gets done in a
>> v3.
> If set_ethernet_addr() fail, don't return error, but use eth_hw_addr_random()
> instead to set random MAC address and
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path. As the inflight pinned
pages, specifically for memory region that strides across
multiple chunks, would need more than one free page for
book keeping an
Commit 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
has following issues in the failure path of IOTLB update:
1) vhost_vdpa_map() does not clean up dangling iotlb entry
upon mapping failure
2) vhost_vdpa_process_iotlb_update() has leakage of pinned
pages in case of vhost_vdpa_map()
vhost_vdpa_map() should remove the iotlb entry just added
if the corresponding mapping fails to set up properly.
Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
drivers/vhost/vdpa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/vhost/vdp
On 10/2/20 6:36 AM, Ciara Loftus wrote:
Categorise and record syscalls issued in the xdpsock sample app. The
categories recorded are:
rx_empty_polls:polls when the rx ring is empty
fill_fail_polls: polls when failed to get addr from fill ring
copy_tx_sendtos: sendtos issued f
On 10/2/20 6:36 AM, Ciara Loftus wrote:
New statistics will be added in future commits. In preparation for this,
let's split out the existing statistics into their own struct.
Signed-off-by: Ciara Loftus
Acked-by: Yonghong Song
On 10/2/20 9:22 PM, Andrii Nakryiko wrote:
On Fri, Oct 2, 2020 at 7:19 PM Yonghong Song wrote:
With latest llvm trunk, bpf programs under samples/bpf
directory, if using CORE, may experience the following
errors:
LLVM ERROR: Cannot select: intrinsic %llvm.preserve.struct.access.index
PLEAS
On Fri, Oct 02, 2020 at 04:13:18PM -0700, David Miller wrote:
> From: Ioana Ciornei
> Date: Sat, 3 Oct 2020 00:07:27 +0300
>
> > This patch set aims to add the necessary DTS nodes to complete the
> > MAC/PCS/PHY representation on DPAA2 devices. The external MDIO bus nodes
> > and the PHYs found
On Fri, Oct 2, 2020 at 7:19 PM Yonghong Song wrote:
>
> With latest llvm trunk, bpf programs under samples/bpf
> directory, if using CORE, may experience the following
> errors:
>
> LLVM ERROR: Cannot select: intrinsic %llvm.preserve.struct.access.index
> PLEASE submit a bug report to https://bugs
On Sat, Oct 03, 2020 at 05:54:38AM +0200, Eric Dumazet wrote:
>
> Sure, a WQ is already giving nice results on appliances, because there
> you do not need strong isolation.
> Would a kthread approach also work well on appliances ? Probably...
Right. I think we're on the same page.
The only reason
On Tue, Sep 29, 2020 at 09:49:07PM +0800, Xin Long wrote:
> This patch is to enable udp tunneling socks by calling
> sctp_udp_sock_start() in sctp_ctrlsock_init(), and
> sctp_udp_sock_stop() in sctp_ctrlsock_exit().
>
> Also add sysctl udp_port to allow changing the listening
> sock's port by user
On Tue, Sep 29, 2020 at 09:49:04PM +0800, Xin Long wrote:
> sk_setup_caps() was originally called in Commit 90017accff61 ("sctp:
> Add GSO support"), as:
>
> "We have to refresh this in case we are xmiting to more than one
>transport at a time"
>
> This actually happens in the loop of sctp_
On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote:
> Hi Xin,
>
> Thank you for the patch! Yet something to improve:
I wonder how are you planning to fix this. It is quite entangled.
This is not performance critical. Maybe the cleanest way out is to
move it to a .c file.
Adding a
On Tue, Sep 29, 2020 at 09:49:03PM +0800, Xin Long wrote:
> sctp_mtu_payload() is for calculating the frag size before making
> chunks from a msg. So we should only add udphdr size to overhead
> when udp socks are listening, as only then sctp can handling the
On Tue, Sep 29, 2020 at 09:49:02PM +0800, Xin Long wrote:
> static int sctp_udp_rcv(struct sock *sk, struct sk_buff *skb)
> {
> + memset(skb->cb, 0, sizeof(skb->cb));
> + SCTP_INPUT_CB(skb)->encap_port = ntohs(udp_hdr(skb)->source);
Here it's in host order already. The fact that is does
On Tue, Sep 29, 2020 at 09:49:01PM +0800, Xin Long wrote:
...
> +struct sctp_udpencaps {
> + sctp_assoc_t sue_assoc_id;
> + struct sockaddr_storage sue_address;
> + uint16_t sue_port;
> +};
...
> +static int sctp_setsockopt_encap_port(struct sock *sk,
> +
On Tue, Sep 29, 2020 at 09:48:55PM +0800, Xin Long wrote:
> This patch fixes two things:
>
> When skb->ip_summed == CHECKSUM_PARTIAL, skb_checksum_help() should be
> called do the checksum, instead of gso_make_checksum(), which is used
> to do the checksum for current proto after calling skb
On 10/2/20 4:42 PM, Gustavo A. R. Silva wrote:
Replace /* fallthrough */ comments with the new pseudo-keyword macro
fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
syzbot has bisected this issue to:
commit 135f971181d779c96ff3725c1a350a721785cc66
Author: Alex Deucher
Date: Mon Nov 20 22:49:53 2017 +
drm/amdgpu: don't skip attributes when powerplay is enabled
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=120f55bd90
start commit
On Fri, Oct 2, 2020 at 5:25 PM Stanislav Fomichev wrote:
>
> We are missing a deref for the case when we are doing BPF_PROG_BIND_MAP
> on a map that's being already held by the program.
> There is 'if (ret) bpf_map_put(map)' below which doesn't trigger
> because we don't consider this an error.
>
With latest llvm trunk, bpf programs under samples/bpf
directory, if using CORE, may experience the following
errors:
LLVM ERROR: Cannot select: intrinsic %llvm.preserve.struct.access.index
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash
backtrace.
Stack dump:
0. P
Compiling samples/bpf hits an error related to fallthrough marking.
...
CC samples/bpf/hbm.o
samples/bpf/hbm.c: In function ‘main’:
samples/bpf/hbm.c:486:4: error: ‘fallthrough’ undeclared (first use in this
function)
fallthrough;
^~~
The "fallthrough" is not defi
From: Jakub Kicinski
Date: Fri, 2 Oct 2020 14:49:51 -0700
> The objective of this series is to dump ethtool policies
> to be able to tell which flags are supported by the kernel.
> Current release adds ETHTOOL_FLAG_STATS for dumping extra
> stats, but because of strict checking we need to make s
From: Grygorii Strashko
Date: Thu, 1 Oct 2020 13:52:57 +0300
> This patch adds multi-port support to TI AM65x CPSW driver xmit/rx path in
> preparation for adding support for multi-port devices, like Main CPSW0 on
> K3 J721E SoC or future CPSW3g on K3 AM64x SoC.
> Hence DMA channels are common/sh
From: Anant Thazhemadam
Date: Wed, 30 Sep 2020 10:47:20 +0530
> The structures virtnet_info and receive_queue have byte holes in
> middle, and their members could do with some rearranging
> (order-of-declaration wise) in order to overcome this.
>
> Rearranging the members helps in:
> * elimi
On 2020/10/2 上午4:23, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path. As the inflight pinned
pages, specifically for memory region that strides across
multiple chunks, would need
On 2020/9/30 上午12:30, Greg Kurz wrote:
When the IOTLB device is enabled, the log_guest_addr that is passed by
userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written
to vq->log_addr, is a GIOVA. All writes to this address are translated
by log_user() to writes to an HVA, and then
On 2020/9/30 上午12:30, Greg Kurz wrote:
When the IOTLB device is enabled, the vring addresses we get
from userspace are GIOVAs. It is thus wrong to pass them down
to access_ok() which only takes HVAs.
Access validation is done at prefetch time with IOTLB. Teach
vq_access_ok() about that by movi
Assalamu alaikum,
I have a business Proposal for you and I need mutual respect, trust,
honesty, transparency, adequate support and assistance, Hope to hear
from you for more details.
Warmest regards
Mrs Aisha Gaddafi
السلام عليكم،
لدي اقتراح عمل لك وأنا بحاجة إلى الاحترام المتبادل والثقة والأ
On Fri, Oct 2, 2020 at 5:26 PM Stanislav Fomichev wrote:
>
> We are missing a deref for the case when we are doing BPF_PROG_BIND_MAP
> on a map that's being already held by the program.
> There is 'if (ret) bpf_map_put(map)' below which doesn't trigger
> because we don't consider this an error.
>
Vinicius,
On Fri, Oct 02 2020 at 12:01, Vinicius Costa Gomes wrote:
> I think that there's an underlying problem/limitation that is the cause
> of the issue (or at least a step in the right direction) you are trying
> to solve: the issue is that PTP clocks can't be used as hrtimers.
That's only a
On 10/2/20 4:41 PM, Rob Herring wrote:
> Another round of wack-a-mole. The json-schema default is additional
> unknown properties are allowed, but for DT all properties should be
> defined.
>
> Cc: Thierry Reding
> Cc: Linus Walleij
> Cc: Stephen Boyd
> Cc: Shawn Guo
> Cc: Bjorn Andersson
> C
> On Oct 2, 2020, at 4:09 PM, Daniel Borkmann wrote:
>
> On 9/26/20 2:07 AM, Song Liu wrote:
>> Recent improvements in LOCKDEP highlighted a potential A-A deadlock with
>> pcpu_freelist in NMI:
>> ./tools/testing/selftests/bpf/test_progs -t stacktrace_build_id_nmi
>> [ 18.984807] ===
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and a warning of type mismatch with dumping enabled, i.e.,
$ make CFLAGS_MODULE="-DQL_ALL_DUMP -DQL_OB_DUMP -DQL_CB_DUMP \
Another round of wack-a-mole. The json-schema default is additional
unknown properties are allowed, but for DT all properties should be
defined.
Cc: Thierry Reding
Cc: Linus Walleij
Cc: Stephen Boyd
Cc: Shawn Guo
Cc: Bjorn Andersson
Cc: Baolin Wang
Cc: Guenter Roeck
Cc: Jonathan Cameron
Cc
The PTP clock associated with a networking device is reported by the
ETHTOOL_GET_TS_INFO ioctl, by using the ptp->index clock index variable.
In order to associate this clock index with the proper device,
userspace applications make the assumption that /dev/ptpX has a clock
index of X. If this ass
Replace /* fallthrough */ comments with the new pseudo-keyword macro
fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
kernel/bpf/verifier.c | 4 ++--
1 file changed, 2
From: Ioana Ciornei
Date: Thu, 1 Oct 2020 18:11:44 +0300
> This patch set adds support in the dpaa2-eth driver for a new group of
> devlink drop traps - PARSER_ERROR_DROPS.
>
> The first patch adds a new generic trap group and associated traps,
> their definitions in devlink and their correspon
From: Shannon Nelson
Date: Thu, 1 Oct 2020 09:22:38 -0700
> This set of patches comes mostly from error recovery path testing,
> as well as a couple of upstream review comments.
Series applied, thank you.
From: Julian Wiedmann
Date: Thu, 1 Oct 2020 19:11:29 +0200
> please apply the following patch series to netdev's net-next tree.
>
> Patches 1-3 enable qeth to also support the .set_channels() ethtool
> callback for OSA devices. This completes support for the full range
> of device types.
>
> T
From: sa...@kernel.org
Date: Fri, 2 Oct 2020 11:06:40 -0700
> This series introduces some fixes to mlx5 driver.
>
> v1->v2:
> - Patch #1 Don't return while mutex is held. (Dave)
>
> v2->v3:
> - Drop patch #1, will consider a better approach (Jakub)
> - use cpu_relax() instead of cond_resched
Replace /* no break */ comments with the new pseudo-keyword macro
fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4
On Wed, Sep 30, 2020 at 10:55:37AM -0700, Vishnu Rangayyan wrote:
Hi,
Can we have this backport applied to 5.4 stable, its a useful fix.
commit df12eb6d6cd920ab2f0e0a43cd6e1c23a05cea91 upstream
The call has a minor api change in 5.4 vs higher, only the pkt arg is
required.
Queued up. I took
On Fri, Oct 2, 2020 at 4:02 PM David Miller wrote:
>
> From: Wei Wang
> Date: Wed, 30 Sep 2020 12:21:35 -0700
>
> ...
> > And the reason we prefer 1 kthread per napi, instead of 1 workqueue
> > entity per host, is that kthread is more configurable than workqueue,
> > and we could leverage existi
From: Ioana Ciornei
Date: Sat, 3 Oct 2020 00:07:27 +0300
> This patch set aims to add the necessary DTS nodes to complete the
> MAC/PCS/PHY representation on DPAA2 devices. The external MDIO bus nodes
> and the PHYs found on them are added, along with the PCS MDIO internal
> buses and their PCS
On 9/26/20 2:07 AM, Song Liu wrote:
Recent improvements in LOCKDEP highlighted a potential A-A deadlock with
pcpu_freelist in NMI:
./tools/testing/selftests/bpf/test_progs -t stacktrace_build_id_nmi
[ 18.984807]
[ 18.984807] WARNING: inconsistent lock state
On Fri, 2 Oct 2020 16:04:21 -0700 Jakub Kicinski wrote:
> On Fri, 2 Oct 2020 12:56:43 +0300 Grygorii Strashko wrote:
> > On 02/10/2020 02:08, Jakub Kicinski wrote:
> > > On Thu, 1 Oct 2020 13:52:50 +0300 Grygorii Strashko wrote:
> > >> This series adds multi-port support in mac-only mode (mul
On Fri, 2 Oct 2020 12:56:43 +0300 Grygorii Strashko wrote:
> On 02/10/2020 02:08, Jakub Kicinski wrote:
> > On Thu, 1 Oct 2020 13:52:50 +0300 Grygorii Strashko wrote:
> >> This series adds multi-port support in mac-only mode (multi MAC mode) to TI
> >> AM65x CPSW driver in preparation for enablin
From: David Howells
Date: Thu, 01 Oct 2020 15:56:43 +0100
> The patches are tagged here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> rxrpc-next-20201010
No, they aren't.
git pull --no-ff
git://git.kernel.org/pub/scm/linux/kernel/g
From: Wei Wang
Date: Wed, 30 Sep 2020 12:21:35 -0700
...
> And the reason we prefer 1 kthread per napi, instead of 1 workqueue
> entity per host, is that kthread is more configurable than workqueue,
> and we could leverage existing tuning tools for threads, like taskset,
> chrt, etc to tune sche
Replace /* Fallthrough... */ comment with the new pseudo-keyword macro
fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/micrel/ksz884x.c | 3 +--
From: Jarod Wilson
Date: Fri, 2 Oct 2020 16:23:46 -0400
> I'd had a bit of feedback that people would rather see both, and be
> able to toggle off the old ones, rather than only having one or the
> other, depending on the toggle, so I thought I'd give this a try. I
> kind of liked the one or the
From: Jarod Wilson
Date: Fri, 2 Oct 2020 16:12:49 -0400
> The documentation was updated to point to the new names, but the old
> ones still exist across the board, there should be no userspace
> breakage here. (My lnst bonding tests actually fall flat currently
> if the old names are gone).
The
Replace /* !!! fall through !!! */ comments with the new pseudo-keyword
macro fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/brocade/bna/bfa_ioc
On Thu, 1 Oct 2020 18:44:40 -0700 Wei Wang wrote:
> > Can you share relative performance delta of this banchmark?
> >
> > Could you explain why threads are slower than ksoftirqd if you pin the
> > application away? From your cover letter it sounded like you want the
> > scheduler to see the NAPI lo
From: Stephen Hemminger
Date: Fri, 2 Oct 2020 12:13:17 -0700
> On Fri, 2 Oct 2020 13:40:01 -0400
> Jarod Wilson wrote:
>
>> By default, enable retaining all user-facing API that includes the use of
>> master and slave, but add a Kconfig knob that allows those that wish to
>> remove it entirely
On Fri, 2 Oct 2020 09:56:31 +0200 Eric Dumazet wrote:
> On Thu, Oct 1, 2020 at 10:26 PM Jakub Kicinski wrote:
> >
> > On Thu, 1 Oct 2020 09:52:45 +0200 Eric Dumazet wrote:
>
> > > The unique work queue is a problem on server class platforms, with
> > > NUMA placement.
> > > We now have servers
Replace // FALLTHROUGH comment with the new pseudo-keyword macro
fallthrough[1].
[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 in
Implement TCA_VLAN_ACT_POP_ETH and TCA_VLAN_ACT_PUSH_ETH, to
respectively pop and push a base Ethernet header at the beginning of a
frame.
POP_ETH is just a matter of pulling ETH_HLEN bytes. VLAN tags, if any,
must be stripped before calling POP_ETH.
PUSH_ETH is restricted to skbs with no mac_hea
Define the MAC_PUSH action which pushes an MPLS LSE before the mac
header (instead of between the mac and the network headers as the
plain PUSH action does).
The only special case is when the skb has an offloaded VLAN. In that
case, it has to be inlined before pushing the MPLS header.
Signed-off-
This patch series adds the necessary TC actions for supporting layer 2
MPLS VPNs (VPLS).
The objective is to give the possibility to add an MPLS header right
before an skb's mac header, then to prepend this MPLS packet with a
new Ethernet header with the MAC address of the next hop.
Patch 1 imple
From: Kalle Valo
Date: Fri, 2 Oct 2020 14:08:26 + (UTC)
> here's a pull request to net-next tree, more info below. Please let me know if
> there are any problems.
Pulled, thank you.
On Fri, 2 Oct 2020 16:23:46 -0400
Jarod Wilson wrote:
> On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger
> wrote:
> >
> > On Fri, 2 Oct 2020 13:40:01 -0400
> > Jarod Wilson wrote:
> >
> > > By default, enable retaining all user-facing API that includes the use of
> > > master and slave, but
On Fri, Sep 25, 2020 at 05:07:56PM -0700, Song Liu wrote:
> Recent improvements in LOCKDEP highlighted a potential A-A deadlock with
> pcpu_freelist in NMI:
>
> ./tools/testing/selftests/bpf/test_progs -t stacktrace_build_id_nmi
>
> [ 18.984807]
> [ 18.984807]
From: Vladimir Oltean
Date: Fri, 2 Oct 2020 15:02:19 +0300
> The purpose of this patch is to add more comprehensive support for flow
> offloading in the mscc_ocelot library and switch drivers.
>
> The design (with chains) is the result of this discussion:
> https://lkml.org/lkml/2020/6/2/203
>
From: Anant Thazhemadam
Date: Fri, 2 Oct 2020 17:04:13 +0530
> But this patch is about ensuring that an uninitialized variable's
> value (whatever that may be) is not set as the ethernet address
> blindly (without any form of checking if get_registers() worked
> as expected, or not).
Right, and
From: Paolo Abeni
Date: Fri, 2 Oct 2020 12:39:44 +0200
> If a syn-cookies request socket don't pass MPTCP-level
> validation done in syn_recv_sock(), we need to release
> it immediately, or it will be leaked.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/89
> Fixes: 9466a1c
From: Johannes Berg
Date: Fri, 2 Oct 2020 12:11:25 +0200
> Here's a - probably final - set of patches for net-next.
> Really the big thing is more complete S1G support, along
> with a small list of other things, see the tag message.
>
> Please pull and let me know if there's any problem.
Pulle
From: Coly Li
Date: Fri, 2 Oct 2020 16:30:12 +0800
> Obviously my fault and no excuse for leaking this uncompleted version to
> you. I just re-post a v10 version which I make sure all patches are the
> latest version.
>
> Sorry for the inconvenience and thank you in advance for taking this set.
From: Coly Li
Date: Fri, 2 Oct 2020 16:27:27 +0800
> As Sagi Grimberg suggested, the original fix is refind to a more common
> inline routine:
> static inline bool sendpage_ok(struct page *page)
> {
> return (!PageSlab(page) && page_count(page) >= 1);
> }
> If sendpage_ok()
Can you please not send the same posting to the mailing list
three times, from three different email addresses?
Once is enough, thank you.
From: Johannes Berg
Date: Fri, 2 Oct 2020 09:46:04 +0200
> From: Johannes Berg
>
> If userspace doesn't complete the policy dump, we leak the
> allocated state. Fix this.
>
> Fixes: d07dcf9aadd6 ("netlink: add infrastructure to expose policies to
> userspace")
> Signed-off-by: Johannes Berg
From: Lukasz Stelmach
Date: Fri, 02 Oct 2020 09:39:40 +0200
> In both drivers the second to last line of the *_init_mac_address()[1][2]
> functions is
>
> eth_hw_addr_random(dev->net);
My bad, indeed it does take care of this already.
Applied to net-next, thanks.
From: Kurt Kanzenbach
Date: Fri, 2 Oct 2020 08:20:51 +0200
> The switch has a certain MDIO address and this needs to be specified using the
> reg property. Add it to the example.
>
> Signed-off-by: Kurt Kanzenbach
Applied, thank you.
On Tue, Sep 29, 2020 at 11:48 PM Hao Luo wrote:
>
> Ah, this is the bug in pahole described in
> https://lkml.org/lkml/2020/8/20/1862. I proposed a fix [1] but it
> hasn't reached pahole's master branch. Let me ask Arnaldo to see if he
> is OK merging it.
>
> [1] https://www.spinics.net/lists/dwar
From: Mauro Carvalho Chehab
Date: Fri, 2 Oct 2020 07:49:45 +0200
> As warned by "make htmldocs", there are two new struct elements
> that aren't documented:
>
> ../include/linux/netdevice.h:2159: warning: Function parameter or
> member 'unlink_list' not described in 'net_device'
>
A driver may refuse to enable VLAN filtering for any reason beyond what
the DSA framework cares about, such as:
- having tc-flower rules that rely on the switch being VLAN-aware
- the particular switch does not support VLAN, even if the driver does
(the DSA framework just checks for the presence
On Fri, 2 Oct 2020 14:22:05 -0700 Jakub Kicinski wrote:
> > > Forgot the link ...
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/log/?h=genetlink-op-policy-export
> > >
> >
> > If it's not too late for you - do you want to merge the two series and
> > pos
Whenever netlink dump uses more than 2 cb->args[] entries
code gets hard to read. We're about to add more state to
ctrl_dumppolicy() so create a structure.
Since the structure is typed and clearly named we can remove
the local fam_id variable and use ctx->fam_id directly.
v3:
- rebase onto expli
There are holes and oversized members in struct genl_family.
Before: /* size: 104, cachelines: 2, members: 16 */
After: /* size: 88, cachelines: 2, members: 16 */
The command field in struct genlmsghdr is a u8, so no point
in the operation count being 32 bit. Also operation 0 is
usually undefin
Bulk of the genetlink users can use smaller ops, move them.
Signed-off-by: Jakub Kicinski
Reviewed-by: Johannes Berg
---
drivers/block/nbd.c | 6 +++---
drivers/net/gtp.c| 6 +++---
drivers/net/ieee802154/mac802154_hwsim.c | 6 +++---
drivers/net/
In preparation for adding a new attribute to CTRL_CMD_GETPOLICY
split the policies for getpolicy and getfamily apart.
This will cause a slight user-visible change in that dumping
the policies will switch from per family to per op, but
supposedly sniffer-type applications (which are the main use
ca
The structure of ctrl_dumppolicy() is clearly split into
init and dumping. Move the init to a .start callback
for clarity, it's a more idiomatic netlink dump code structure.
Signed-off-by: Jakub Kicinski
Reviewed-by: Johannes Berg
---
net/netlink/genetlink.c | 48 ---
We want to add maxattr and policy back to genl_ops, to enable
dumping per command policy to user space. This, however, would
cause bloat for all the families with global policies. Introduce
smaller version of ops (half the size of genl_ops). Translate
these smaller ops into a full blown struct befo
commit 3b0f31f2b8c9 ("genetlink: make policy common to family")
had to work around removal of policy from ops by parsing in
the pre_doit callback. Now that policy is back in full ops
we can switch again. Set maxattr to actual size of the policies
- both commands set GENL_DONT_VALIDATE_STRICT so out
Attributes are already parsed based on the policy specified
in the family and ready-to-use in info->attrs. No need to
call genlmsg_parse() again.
Signed-off-by: Jakub Kicinski
Reviewed-by: Johannes Berg
---
net/netlink/genetlink.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
Add policy to the struct genl_ops structure, this time
with maxattr, so it can be used properly.
Propagate .policy and .maxattr from the family
in genl_get_cmd() if needed, this way the rest of the
code does not have to worry if the policy is per op
or global.
Signed-off-by: Jakub Kicinski
Revie
Hi!
The objective of this series is to dump ethtool policies
to be able to tell which flags are supported by the kernel.
Current release adds ETHTOOL_FLAG_STATS for dumping extra
stats, but because of strict checking we need to make sure
that the flag is actually supported before setting it in
a r
On Thu, Oct 01, 2020 at 06:09:34PM -0700, John Fastabend wrote:
> This implements the helper skb_adjust_room() for BPF_SKS_SK_STREAM_VERDICT
> programs so we can push/pop headers from the data on recieve. One use
> case is to pop TLS headers off kTLS packets.
>
> The first patch implements the hel
On Fri, 2 Oct 2020 14:17:01 -0700 Jakub Kicinski wrote:
> On Fri, 02 Oct 2020 23:00:15 +0200 Johannes Berg wrote:
> > On Fri, 2020-10-02 at 22:59 +0200, Johannes Berg wrote:
> > > On Fri, 2020-10-02 at 13:50 -0700, Jakub Kicinski wrote:
> > > > My thinking was that until kernel actually start
On Fri, 02 Oct 2020 23:00:15 +0200 Johannes Berg wrote:
> On Fri, 2020-10-02 at 22:59 +0200, Johannes Berg wrote:
> > On Fri, 2020-10-02 at 13:50 -0700, Jakub Kicinski wrote:
> > > My thinking was that until kernel actually start using separate dump
> > > policies user space can assume policy 0 i
Add PCS MDIO nodes for the internal MDIO buses on the LX2160A, along
with their internal PCS PHYs, which will be used when the DPMAC is
in TYPE_PHY mode.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
.../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 252 ++
1 file change
Annotate the external MDIO2 node and describe the 10GBASER PHY found on
the LS1088ARDB board and add a phy-handle for DPMAC2 to link it.
Also, add the internal PCS MDIO node for the internal MDIO buses found
on the LS1088A SoC along with its internal PCS PHY and link the
corresponding DPMAC to the
Annotate the EMDIO1 node and describe the 2 AQR107 PHYs found on the
LX2160ARDB board. Also, add the necessary phy-handles for DPMACs 3 and 4
to their associated PHY.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
.../boot/dts/freescale/fsl-lx2160a-rdb.dts| 32 +++
Annotate the external MDIO1 node and describe the 8 QSGMII PHYs found on
the LS1088ARDB board and add phy-handles for DPMACs 3-10 to its
associated PHY. Also, add the internal PCS MDIO nodes for the internal
MDIO buses found on the LS1088A SoC along with their internal PCS PHY
and link the corresp
Add the external MDIO device nodes found in the WRIOP global memory
region. This is needed for management of external PHYs.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- removed the 0x from the unit addresses
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 18 ++
1 file ch
Add a documentation entry for the DTS bindings needed and supported by
the dpaa2-mac driver.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- new patch
.../devicetree/bindings/net/dpaa2-mac.yaml| 55 +++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/de
Add the external MDIO device nodes found in the WRIOP global memory
region. This is needed for management of external PHYs.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- removed the 0x from the unit addresses
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++
1 file ch
1 - 100 of 358 matches
Mail list logo
