On Tue, Sep 29, 2020 at 09:49:07PM +0800, Xin Long wrote:
> This patch is to enable udp tunneling socks by calling
> sctp_udp_sock_start() in sctp_ctrlsock_init(), and
> sctp_udp_sock_stop() in sctp_ctrlsock_exit().
>
> Also add sysctl udp_port to allow changing the listening
> sock's port by users.
>
> Wit this patch, the whole sctp over udp feature can be
With
> enabled and used.
...
> @@ -1466,6 +1466,10 @@ static int __net_init sctp_ctrlsock_init(struct net
> *net)
> if (status)
> pr_err("Failed to initialize the SCTP control sock\n");
>
> + status = sctp_udp_sock_start(net);
This can be masking the previous error.
> + if (status)
> + pr_err("Failed to initialize the SCTP udp tunneling sock\n");
SCTP UDP
> +
> return status;
> }
>
This is the last comment I had.
Thanks Xin! Nice patches.