Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-04 Thread Vasundhara Volam
On Wed, Aug 5, 2020 at 12:02 PM Moshe Shemesh wrote: > > > On 8/4/2020 1:13 PM, Vasundhara Volam wrote: > > On Mon, Aug 3, 2020 at 7:23 PM Moshe Shemesh wrote: > >> > >> On 8/3/2020 3:47 PM, Vasundhara Volam wrote: > >>> On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: > On 8/3/2020 1:24

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-04 Thread Andrii Nakryiko
On Tue, Aug 4, 2020 at 11:26 PM Song Liu wrote: > > > > > On Aug 4, 2020, at 10:32 PM, Andrii Nakryiko > > wrote: > > > > On Tue, Aug 4, 2020 at 8:59 PM Song Liu wrote: > >> > >> > >> > >>> On Aug 4, 2020, at 6:38 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Mon, Aug 3, 2020 at 6:18 PM Son

Re: [PATCH v9 bpf-next 14/14] selftests/bpf: Add set test to resolve_btfids

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding test to for sets resolve_btfids. We're checking that > testing set gets properly resolved and sorted. > > Signed-off-by: Jiri Olsa > --- Acked-by: Andrii Nakryiko > .../selftests/bpf/prog_tests/resolve_btfids.c | 39 +

Re: [PATCH v9 bpf-next 13/14] selftests/bpf: Add test for d_path helper

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:05 AM Jiri Olsa wrote: > > Adding test for d_path helper which is pretty much > copied from Wenbo Zhang's test for bpf_get_fd_path, > which never made it in. > > The test is doing fstat/close on several fd types, > and verifies we got the d_path helper working on > kernel

Re: [PATCH v9 bpf-next 10/14] bpf: Add d_path helper

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding d_path helper function that returns full path for > given 'struct path' object, which needs to be the kernel > BTF 'path' object. The path is returned in buffer provided > 'buf' of size 'sz' and is zero terminated. > > bpf_d_path(&file-

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-04 Thread Moshe Shemesh
On 8/4/2020 1:13 PM, Vasundhara Volam wrote: On Mon, Aug 3, 2020 at 7:23 PM Moshe Shemesh wrote: On 8/3/2020 3:47 PM, Vasundhara Volam wrote: On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: On 8/3/2020 1:24 PM, Vasundhara Volam wrote: On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wr

Re: [PATCH v9 bpf-next 09/14] bpf: Add BTF_SET_START/END macros

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding support to define sorted set of BTF ID values. > > Following defines sorted set of BTF ID values: > > BTF_SET_START(btf_allowlist_d_path) > BTF_ID(func, vfs_truncate) > BTF_ID(func, vfs_fallocate) > BTF_ID(func, dentry_open) > B

Re: [PATCH v9 bpf-next 08/14] bpf: Add btf_struct_ids_match function

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding btf_struct_ids_match function to check if given address provided > by BTF object + offset is also address of another nested BTF object. > > This allows to pass an argument to helper, which is defined via parent > BTF object + offset, like

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-04 Thread Song Liu
> On Aug 4, 2020, at 10:32 PM, Andrii Nakryiko > wrote: > > On Tue, Aug 4, 2020 at 8:59 PM Song Liu wrote: >> >> >> >>> On Aug 4, 2020, at 6:38 PM, Andrii Nakryiko >>> wrote: >>> >>> On Mon, Aug 3, 2020 at 6:18 PM Song Liu wrote: > On Aug 2, 2020, at 6:40 PM, And

Re: [PATCH v9 bpf-next 07/14] bpf: Factor btf_struct_access function

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding btf_struct_walk function that walks through the > struct type + given offset and returns following values: > > enum bpf_struct_walk_result { >/* < 0 error */ >WALK_SCALAR = 0, >WALK_PTR, >WALK_STRUCT, >

WARNING: locking bug in hci_dev_reset

2020-08-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ac3a0c84 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1088779290 kernel config: https://syzkaller.appspot.com/x/.config?x=c0cfcf935bcc94d2 dashboar

Re: The card speed limited to 100 Mb/s

2020-08-04 Thread Heiner Kallweit
On 04.08.2020 18:17, Janusz S. Bień wrote: > > I apologize for a false alarm - the cable had to be replaced. > It wouldn't have been a question for the kernel community anyway because it's about a out-of-tree vendor driver. And the 150MB/s - 300MB/s obviously refer to WiFi. > Regards > > Janus

WARNING: refcount bug in l2cap_global_chan_by_psm

2020-08-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c0842fbc random32: move the pseudo-random 32-bit definitio.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=142980c290 kernel config: https://syzkaller.appspot.com/x/.config?x=76cacb0fe58c4a1e das

Re: [PATCH v9 bpf-next 06/14] bpf: Remove recursion call in btf_struct_access

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Andrii suggested we can simply jump to again label > instead of making recursion call. > > Suggested-by: Andrii Nakryiko > Signed-off-by: Jiri Olsa > --- > kernel/bpf/btf.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) >

Re: [PATCH v9 bpf-next 05/14] bpf: Add type_id pointer as argument to __btf_resolve_size

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > Adding type_id pointer as argument to __btf_resolve_size > to return also BTF ID of the resolved type. It will be > used in following changes. > > Signed-off-by: Jiri Olsa > --- Acked-by: Andrii Nakryiko > kernel/bpf/btf.c | 13 +---

Re: [PATCH v9 bpf-next 02/14] tools resolve_btfids: Add support for set symbols

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > The set symbol does not have the unique number suffix, > so we need to give it a special parsing function. > > This was omitted in the first batch, because there was > no set support yet, so it slipped in the testing. > > Signed-off-by: Jiri Ols

Re: [PATCH v9 bpf-next 01/14] tools resolve_btfids: Add size check to get_id function

2020-08-04 Thread Andrii Nakryiko
On Sat, Aug 1, 2020 at 10:04 AM Jiri Olsa wrote: > > To make sure we don't crash on malformed symbols. > > Signed-off-by: Jiri Olsa > --- Acked-by: Andrii Nakryiko > tools/bpf/resolve_btfids/main.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > [...]

Re: [PATCH V5 1/6] vhost: introduce vhost_vring_call

2020-08-04 Thread Jason Wang
On 2020/8/5 下午1:49, Zhu, Lingshan wrote: On 8/5/2020 10:16 AM, Jason Wang wrote: On 2020/8/4 下午5:21, Michael S. Tsirkin wrote:    +struct vhost_vring_call { +    struct eventfd_ctx *ctx; +    struct irq_bypass_producer producer; +    spinlock_t ctx_lock; It's not clear to me why we need c

Re: [PATCH V5 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

2020-08-04 Thread Jason Wang
On 2020/8/5 下午1:45, Zhu, Lingshan wrote: On 8/5/2020 10:36 AM, Jason Wang wrote: On 2020/8/4 下午5:31, Zhu, Lingshan wrote: On 8/4/2020 4:51 PM, Jason Wang wrote: On 2020/7/31 下午2:55, Zhu Lingshan wrote: This patch introduce a set of functions for setup/unsetup and update irq offloading

[PATCH bpf v4 2/2] tools/bpf: support new uapi for map element bpf iterator

2020-08-04 Thread Yonghong Song
Previous commit adjusted kernel uapi for map element bpf iterator. This patch adjusted libbpf API due to uapi change. bpftool and bpf_iter selftests are also changed accordingly. Acked-by: Andrii Nakryiko Acked-by: John Fastabend Signed-off-by: Yonghong Song --- tools/bpf/bpftool/iter.c

[PATCH bpf v4 0/2] bpf: change uapi for bpf iterator map elements

2020-08-04 Thread Yonghong Song
Andrii raised a concern that current uapi for bpf iterator map element is a little restrictive and not suitable for future potential complex customization. This is a valid suggestion, considering people may indeed add more complex custimization to the iterator, e.g., cgroup_id + user_id, etc. for t

[PATCH bpf v4 1/2] bpf: change uapi for bpf iterator map elements

2020-08-04 Thread Yonghong Song
Commit a5cbe05a6673 ("bpf: Implement bpf iterator for map elements") added bpf iterator support for map elements. The map element bpf iterator requires info to identify a particular map. In the above commit, the attr->link_create.target_fd is used to carry map_fd and an enum bpf_iter_link_info is a

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-04 Thread Andrii Nakryiko
On Tue, Aug 4, 2020 at 9:47 PM Song Liu wrote: > > > > > On Aug 4, 2020, at 6:52 PM, Andrii Nakryiko > > wrote: > > > > On Tue, Aug 4, 2020 at 2:01 PM Song Liu wrote: > >> > >> > >> > >>> On Aug 2, 2020, at 10:10 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Sun, Aug 2, 2020 at 9:47 PM Song

AW: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Gaube, Marvin (THSE-TL1)
Hello, I'm using the upstream driver Vladimir mentioned, as of 5.4.51. Best regards Marvin Gaube -Ursprüngliche Nachricht- Von: Florian Fainelli Gesendet: Dienstag, 4. August 2020 22:20 An: Vladimir Oltean Cc: Gaube, Marvin (THSE-TL1) ; Woojung Huh ; Microchip Linux Driver Support ; n

Question about TC filter

2020-08-04 Thread satish dhote
Hi Team, I have a question regarding tc filter behavior. I tried to look for the answer over the web and netdev FAQ but didn't get the answer. Hence I'm looking for your help. I added ingress qdisc for interface enp0s25 and then configured the tc filter as shown below, but after adding filters I

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-04 Thread Andrii Nakryiko
On Tue, Aug 4, 2020 at 8:59 PM Song Liu wrote: > > > > > On Aug 4, 2020, at 6:38 PM, Andrii Nakryiko > > wrote: > > > > On Mon, Aug 3, 2020 at 6:18 PM Song Liu wrote: > >> > >> > >> > >>> On Aug 2, 2020, at 6:40 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Sat, Aug 1, 2020 at 1:50 AM Song

Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-08-04 Thread Martin Schiller
On 2020-08-04 21:20, Xie He wrote: On Tue, Aug 4, 2020 at 5:43 AM Martin Schiller wrote: I'm not an expert in the field, but after reading the commit message and the previous comments, I'd say that makes sense. Thanks! Shouldn't this kernel panic be intercepted by a skb_cow() before the

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-04 Thread Song Liu
> On Aug 4, 2020, at 6:52 PM, Andrii Nakryiko wrote: > > On Tue, Aug 4, 2020 at 2:01 PM Song Liu wrote: >> >> >> >>> On Aug 2, 2020, at 10:10 PM, Andrii Nakryiko >>> wrote: >>> >>> On Sun, Aug 2, 2020 at 9:47 PM Song Liu wrote: > On Aug 2, 2020, at 6:51 PM, Andrii Nakryi

Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table

2020-08-04 Thread Yoshiki Komachi
> 2020/08/01 6:12、Daniel Borkmann のメール: > > On 7/31/20 6:44 AM, Yoshiki Komachi wrote: >> This patch adds a new bpf helper to access FDB in the kernel tables >> from XDP programs. The helper enables us to find the destination port >> of master bridge in XDP layer with high speed. If an entry in

Re: linux-next: manual merge of the kspp tree with the net-next tree

2020-08-04 Thread Stephen Rothwell
Hi all, On Mon, 27 Jul 2020 19:27:21 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the kspp tree got a conflict in: > > net/ipv6/ip6_flowlabel.c > > between commit: > > ff6a4cf214ef ("net/ipv6: split up ipv6_flowlabel_opt") > > from the net-next tree and commit: > > 3f

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-04 Thread Song Liu
> On Aug 4, 2020, at 6:38 PM, Andrii Nakryiko wrote: > > On Mon, Aug 3, 2020 at 6:18 PM Song Liu wrote: >> >> >> >>> On Aug 2, 2020, at 6:40 PM, Andrii Nakryiko >>> wrote: >>> >>> On Sat, Aug 1, 2020 at 1:50 AM Song Liu wrote: >> >> [...] >> >>> }; LIBBPF_API i

[PATCH net 2/4] can: j1939: cancel rxtimer on multipacket broadcast session complete

2020-08-04 Thread Zhang Changzhong
If j1939_xtp_rx_dat_one() receive last frame of multipacket broadcast message, j1939_session_timers_cancel() should be called to cancel rxtimer. Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Signed-off-by: Zhang Changzhong --- net/can/j1939/transport.c | 1 + 1 file changed, 1 i

[PATCH net 4/4] can: j1939: add rxtimer for multipacket broadcast session

2020-08-04 Thread Zhang Changzhong
According to SAE J1939/21 (Chapter 5.12.3 and APPENDIX C), for transmit side the required time interval between packets of a multipacket broadcast message is 50 to 200 ms, the responder shall use a timeout of 250ms (provides margin allowing for the maximumm spacing of 200ms). For receive side a tim

[PATCH net 3/4] can: j1939: abort multipacket broadcast session when timeout occurs

2020-08-04 Thread Zhang Changzhong
If timeout occurs, j1939_tp_rxtimer() first calls hrtimer_start() to restart rxtimer, and then calls __j1939_session_cancel() to set session->state = J1939_SESSION_WAITING_ABORT. At next timeout expiration, because of the J1939_SESSION_WAITING_ABORT session state j1939_tp_rxtimer() will call j1939_

[PATCH net 1/4] can: j1939: fix support for multipacket broadcast message

2020-08-04 Thread Zhang Changzhong
Currently j1939_tp_im_involved_anydir() in j1939_tp_recv() check the previously set flags J1939_ECU_LOCAL_DST and J1939_ECU_LOCAL_SRC of incoming skb, thus multipacket broadcast message was aborted by receive side because it may come from remote ECUs and have no exact dst address. Similarly, j1939_

[PATCH net 0/4] support multipacket broadcast message

2020-08-04 Thread Zhang Changzhong
Zhang Changzhong (4): can: j1939: fix support for multipacket broadcast message can: j1939: cancel rxtimer on multipacket broadcast session complete can: j1939: abort multipacket broadcast session when timeout occurs can: j1939: add rxtimer for multipacket broadcast session net/can/j1939/

Re: [PATCH net-next] net: dsa: sja1105: use detected device id instead of DT one on mismatch

2020-08-04 Thread Florian Fainelli
On 8/4/2020 3:59 PM, David Miller wrote: > From: Vladimir Oltean > Date: Mon, 3 Aug 2020 19:48:23 +0300 > >> Although we can detect the chip revision 100% at runtime, it is useful >> to specify it in the device tree compatible string too, because >> otherwise there would be no way to assess t

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-04 Thread Willy Tarreau
Hi Marc, On Tue, Aug 04, 2020 at 05:52:36PM -0700, Marc Plumb wrote: > Seeding two PRNGs with the same entropy causes two problems. The minor one > is that you're double counting entropy. The major one is that anyone who can > determine the state of one PRNG can determine the state of the other. >

[PATCH net] Revert "vxlan: fix tos value before xmit"

2020-08-04 Thread Hangbin Liu
This reverts commit 71130f29979c7c7956b040673e6b9d5643003176. In commit 71130f29979c ("vxlan: fix tos value before xmit") we want to make sure the tos value are filtered by RT_TOS() based on RFC1349. 0 1 2 3 4 5 6 7 +-+-+-+-+-+-+-

Re: [PATCH V5 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

2020-08-04 Thread Jason Wang
On 2020/8/4 下午5:31, Zhu, Lingshan wrote: On 8/4/2020 4:51 PM, Jason Wang wrote: On 2020/7/31 下午2:55, Zhu Lingshan wrote: This patch introduce a set of functions for setup/unsetup and update irq offloading respectively by register/unregister and re-register the irq_bypass_producer. With th

RE: [EXT] Re: [PATCH v4 2/2] net: dsa: ocelot: Add support for QinQ Operation

2020-08-04 Thread Hongbo Wang
> Caution: EXT Email > > On 8/3/2020 11:36 PM, Hongbo Wang wrote: > >>> + if (vlan->proto == ETH_P_8021AD) { > >>> + ocelot->enable_qinq = true; > >>> + ocelot_port->qinq_mode = true; > >>> + } > >> ... > >>> + if (vlan->proto == ETH_P_8021AD) { > >>> +

Re: [PATCH V5 1/6] vhost: introduce vhost_vring_call

2020-08-04 Thread Jason Wang
On 2020/8/4 下午5:21, Zhu, Lingshan wrote: Hi Jason, we use this lock to protect the eventfd_ctx and irq from race conditions, We don't support irq notification from vDPA device driver in this version, do we still have race condition? as we discussed before: (1)if vendor change IRQ after D

Re: [PATCHv2 net 2/2] vxlan: fix getting tos value from DSCP field

2020-08-04 Thread Hangbin Liu
On Tue, Aug 04, 2020 at 12:47:56PM -0700, David Miller wrote: > From: Hangbin Liu > Date: Tue, 4 Aug 2020 09:43:12 +0800 > > > In commit 71130f29979c ("vxlan: fix tos value before xmit") we strict > > the vxlan tos value before xmit. But as IP tos field has been obsoleted > > by RFC2474, and upd

Re: [PATCH V5 1/6] vhost: introduce vhost_vring_call

2020-08-04 Thread Jason Wang
On 2020/8/4 下午5:21, Michael S. Tsirkin wrote:   +struct vhost_vring_call { +    struct eventfd_ctx *ctx; +    struct irq_bypass_producer producer; +    spinlock_t ctx_lock; It's not clear to me why we need ctx_lock here. Thanks Hi Jason, we use this lock to protect the eventfd_ctx and irq

Re: [PATCH v3 net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Richard Cochran
On Wed, Aug 05, 2020 at 03:10:47AM +0300, Vladimir Oltean wrote: > The way we define the phase (the difference between the time of the > signal's rising edge, and the closest integer multiple of the period), > it doesn't make sense to have a phase value equal or larger than 1 > period. > > So deny

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-04 Thread Andrii Nakryiko
On Tue, Aug 4, 2020 at 2:01 PM Song Liu wrote: > > > > > On Aug 2, 2020, at 10:10 PM, Andrii Nakryiko > > wrote: > > > > On Sun, Aug 2, 2020 at 9:47 PM Song Liu wrote: > >> > >> > >>> On Aug 2, 2020, at 6:51 PM, Andrii Nakryiko > >>> wrote: > >>> > >>> On Sat, Aug 1, 2020 at 1:50 AM Song Liu

Re: [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs

2020-08-04 Thread Andrii Nakryiko
On Mon, Aug 3, 2020 at 6:18 PM Song Liu wrote: > > > > > On Aug 2, 2020, at 6:40 PM, Andrii Nakryiko > > wrote: > > > > On Sat, Aug 1, 2020 at 1:50 AM Song Liu wrote: > >> > > [...] > > > > >> }; > >> > >> LIBBPF_API int bpf_prog_test_run_xattr(struct bpf_prog_test_run_attr > >> *test_attr); >

[PATCH nf,v2] netfilter: nf_tables: nft_exthdr: the presence return value should be little-endian

2020-08-04 Thread Stephen Suryaputra
On big-endian machine, the returned register data when the exthdr is present is not being compared correctly because little-endian is assumed. The function nft_cmp_fast_mask(), called by nft_cmp_fast_eval() and nft_cmp_fast_init(), calls cpu_to_le32(). The following dump also shows that little end

RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

2020-08-04 Thread Wang, Haiyue
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, August 4, 2020 04:46 > To: Wang, Haiyue > Cc: Tom Herbert ; Venkataramanan, Anirudh > ; > da...@davemloft.net; nhor...@redhat.com; sassm...@redhat.com; Bowers, AndrewX > ; Kirsher, Jeffrey T ; > netdev@vger.kernel.org; > Nguye

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-04 Thread Linus Torvalds
On Tue, Aug 4, 2020 at 5:52 PM Marc Plumb wrote: > > TL;DR This change takes the seed data from get_random_bytes and broadcasts it > to the network, thereby destroying the security of dev/random. This change > needs to be reverted and redesigned. This was discussed., It's theoretical, not prac

Flaw in "random32: update the net random state on interrupt and activity"

2020-08-04 Thread Marc Plumb
Willy and Ted, This commit has serious security flaws f227e3ec3b5cad859ad15666874405e8c1bbc1d4 TL;DR This change takes the seed data from get_random_bytes and broadcasts it to the network, thereby destroying the security of dev/random. This change needs to be reverted and redesigned. It

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-04 Thread Eric Dumazet
On 8/4/20 5:30 AM, Colin King wrote: > From: Colin Ian King > > The current test will exit with a failure if it cannot set affinity on > specific CPUs which is problematic when running this on single CPU > systems. Add a check for the number of CPUs and skip the test if > the CPU requirement i

[PATCH bpf] selftests/bpf: prevent runqslower from racing on building bpftool

2020-08-04 Thread Andrii Nakryiko
runqslower's Makefile is building/installing bpftool into $(OUTPUT)/sbin/bpftool, which coincides with $(DEFAULT_BPFTOOL). In practice this means that often when building selftests from scratch (after `make clean`), selftests are racing with runqslower to simultaneously build bpftool and one of the

Re: WARNING: suspicious RCU usage in ovs_flow_tbl_masks_cache_size

2020-08-04 Thread syzbot
syzbot has bisected this issue to: commit 9bf24f594c6acf676fb8c229f152c21bfb915ddb Author: Eelco Chaudron Date: Fri Jul 31 12:21:34 2020 + net: openvswitch: make masks cache size configurable bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=110e06dc90 start commit: 2

Re: [PATCH v2 net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Vladimir Oltean
On Tue, Aug 04, 2020 at 05:04:47PM -0700, Jacob Keller wrote: > > A nit: this could read "therefore anything equal or larger than 1 period > is invalid"? a number modulo itself is 0, right? and we use ">=" below > as well now. > Thanks, I've corrected that too, now. -Vladimir

[PATCH v3 net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Vladimir Oltean
The way we define the phase (the difference between the time of the signal's rising edge, and the closest integer multiple of the period), it doesn't make sense to have a phase value equal or larger than 1 period. So deny these settings coming from the user. Signed-off-by: Vladimir Oltean --- Ch

Re: [PATCH v2 net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Jacob Keller
On 8/4/2020 4:43 PM, Vladimir Oltean wrote: > The way we define the phase (the difference between the time of the > signal's rising edge, and the closest integer multiple of the period), > it doesn't make sense to have a phase value larger than 1 period. > > So deny these settings coming from t

[PATCH v2 net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Vladimir Oltean
The way we define the phase (the difference between the time of the signal's rising edge, and the closest integer multiple of the period), it doesn't make sense to have a phase value larger than 1 period. So deny these settings coming from the user. Signed-off-by: Vladimir Oltean --- Changes in

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-08-04 Thread Anchal Agarwal
On Fri, Jul 31, 2020 at 10:13:48AM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 7/30/20 7:06 PM, Anchal Agarwal wrote: > > O

Re: [PATCH net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Vladimir Oltean
On Tue, Aug 04, 2020 at 04:23:35PM -0700, Richard Cochran wrote: > On Mon, Aug 03, 2020 at 10:49:21PM +0300, Vladimir Oltean wrote: > > @@ -218,6 +218,19 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int > > cmd, unsigned long arg) > > break; > >

Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Steinar H. Gunderson
On Wed, Aug 05, 2020 at 01:44:30AM +0300, Vladimir Oltean wrote: What bug? What repro? You just said you don't have any. >>> Ask Steinar ? >>> >> Hi Steinar, do you have a reproducer for the bug that Eric fixed in >> commit d4b812dea4a2 ("vlan: mask vlan prio bits")? > The Google email addres

Re: [PATCH net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread Richard Cochran
On Mon, Aug 03, 2020 at 10:49:21PM +0300, Vladimir Oltean wrote: > @@ -218,6 +218,19 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, > unsigned long arg) > break; > } > } > + i

Re: [PATCH] farsync: switch from 'pci_' to 'dma_' API

2020-08-04 Thread David Miller
From: Christophe JAILLET Date: Tue, 4 Aug 2020 22:19:24 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] wan: wanxl: switch from 'pci_' to 'dma_' API

2020-08-04 Thread David Miller
From: Christophe JAILLET Date: Tue, 4 Aug 2020 22:08:09 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] hv_netvsc: do not use VF device if link is down

2020-08-04 Thread David Miller
From: Stephen Hemminger Date: Tue, 4 Aug 2020 09:54:15 -0700 > If the accelerated networking SRIOV VF device has lost carrier > use the synthetic network device which is available as backup > path. This is a rare case since if VF link goes down, normally > the VMBus device will also loose extern

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 01:04:31AM +0300, Grygorii Strashko wrote: > On 05/08/2020 00:44, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko wrote: > > > On 05/08/2020 00:07, Russell King - ARM Linux admin wrote: > > > > On Tue, Aug 04, 2020 at 11:

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread David Miller
From: izabela.bakoll...@gmail.com Date: Tue, 4 Aug 2020 18:09:08 +0200 > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > return -EOPNOTSUPP; > } > > +static int net_dm_interface_start(struct net *net, const char *ifname) > +{ > + struct net_device *nd = dev_

Re: [PATCH net-next] flow_dissector: Add IPv6 flow label to symmetric keys

2020-08-04 Thread David Miller
Kernel patch submissions must have proper signoffs.

Re: [PATCH] dpaa2-eth: Fix passing zero to 'PTR_ERR' warning

2020-08-04 Thread David Miller
From: YueHaibing Date: Tue, 4 Aug 2020 21:26:43 +0800 > Fix smatch warning: > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2419 > alloc_channel() warn: passing zero to 'ERR_PTR' > > setup_dpcon() should return ERR_PTR(err) instead of zero in error > handling case. > > Fixes: d7f5a9d89a5

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-04 Thread David Miller
From: Colin King Date: Tue, 4 Aug 2020 13:30:12 +0100 > From: Colin Ian King > > The current test will exit with a failure if it cannot set affinity on > specific CPUs which is problematic when running this on single CPU > systems. Add a check for the number of CPUs and skip the test if > the

Re: [PATCH] net: macb: Properly handle phylink on at91sam9x

2020-08-04 Thread David Miller
From: Stefan Roese Date: Tue, 4 Aug 2020 14:17:16 +0200 > I just recently noticed that ethernet does not work anymore since v5.5 > on the GARDENA smart Gateway, which is based on the AT91SAM9G25. > Debugging showed that the "GEM bits" in the NCFGR register are now > unconditionally accessed, whi

Re: [PATCH net-next] ptp: only allow phase values lower than 1 period

2020-08-04 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 22:49:21 +0300 > The way we define the phase (the difference between the time of the > signal's rising edge, and the closest integer multiple of the period), > it doesn't make sense to have a phase value larger than 1 period. > > So deny these setting

Re: [PATCH net-next] net: dsa: sja1105: use detected device id instead of DT one on mismatch

2020-08-04 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 19:48:23 +0300 > Although we can detect the chip revision 100% at runtime, it is useful > to specify it in the device tree compatible string too, because > otherwise there would be no way to assess the correctness of device tree > bindings statically,

Re: [PATCH] net: core: explicitly call linkwatch_fire_event to speed up the startup of network services

2020-08-04 Thread David Miller
From: Wen Yang Date: Sat, 1 Aug 2020 16:58:45 +0800 > diff --git a/net/core/link_watch.c b/net/core/link_watch.c > index 75431ca..6b9d44b 100644 > --- a/net/core/link_watch.c > +++ b/net/core/link_watch.c > @@ -98,6 +98,9 @@ static bool linkwatch_urgent_event(struct net_device *dev) > if (

Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Vladimir Oltean
On Wed, Aug 05, 2020 at 01:39:52AM +0300, Vladimir Oltean wrote: > On Tue, Aug 04, 2020 at 03:29:05PM -0700, Eric Dumazet wrote: > > On Tue, Aug 4, 2020 at 2:24 PM Vladimir Oltean wrote: > > > > > > On Tue, Aug 04, 2020 at 01:36:56PM -0700, Eric Dumazet wrote: > > > > On Tue, Aug 4, 2020 at 12:43

Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Vladimir Oltean
On Tue, Aug 04, 2020 at 03:29:05PM -0700, Eric Dumazet wrote: > On Tue, Aug 4, 2020 at 2:24 PM Vladimir Oltean wrote: > > > > On Tue, Aug 04, 2020 at 01:36:56PM -0700, Eric Dumazet wrote: > > > On Tue, Aug 4, 2020 at 12:43 PM Vladimir Oltean wrote: > > > > > > > > On Tue, Aug 04, 2020 at 12:40:24

linux-next: Signed-off-by missing for commit in the net-next tree

2020-08-04 Thread Stephen Rothwell
Hi all, Commit 6c4e9bcfb489 ("net/mlx5: Delete extra dump stack that gives nothing") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpNY8pbv7z1s.pgp Description: OpenPGP digital signature

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Grygorii Strashko
On 05/08/2020 00:44, Russell King - ARM Linux admin wrote: On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko wrote: On 05/08/2020 00:07, Russell King - ARM Linux admin wrote: On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote: On 31/07/2020 13:06, Kurt Kanzenbach

Re: [Linux-kernel-mentees] [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread Neil Horman
On Tue, Aug 04, 2020 at 02:28:28PM -0700, Cong Wang wrote: > On Tue, Aug 4, 2020 at 9:14 AM wrote: > > > > From: Izabela Bakollari > > > > Dropwatch is a utility that monitors dropped frames by having userspace > > record them over the dropwatch protocol over a file. This augument > > allows live

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko wrote: > On 05/08/2020 00:07, Russell King - ARM Linux admin wrote: > > On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote: > > > > > > > > > On 31/07/2020 13:06, Kurt Kanzenbach wrote: > > > > On Thu Jul 30 2020, Petr Mac

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Grygorii Strashko
On 05/08/2020 00:07, Russell King - ARM Linux admin wrote: On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote: On 31/07/2020 13:06, Kurt Kanzenbach wrote: On Thu Jul 30 2020, Petr Machata wrote: Kurt Kanzenbach writes: @@ -107,6 +107,37 @@ unsigned int ptp_classify_raw(c

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread Cong Wang
On Tue, Aug 4, 2020 at 9:14 AM wrote: > > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools like tcpdump. > > With this fea

Re: [PATCH net-next v2 2/2] net: sched: Lockless Token Bucket (LTB) qdisc

2020-08-04 Thread YU, Xiangning
Hi Maxim, So glad that you find this useful! Please stay tuned, I will take a look at this problem. Something might have gone wrong while merging the code with net-next. Thanks, - Xiangning On 8/4/20 3:37 AM, Maxim Mikityanskiy wrote: > On 2020-07-08 19:38, YU, Xiangning wrote: >> Lockless Tok

Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Vladimir Oltean
On Tue, Aug 04, 2020 at 01:36:56PM -0700, Eric Dumazet wrote: > On Tue, Aug 4, 2020 at 12:43 PM Vladimir Oltean wrote: > > > > On Tue, Aug 04, 2020 at 12:40:24PM -0700, Eric Dumazet wrote: > > > On Tue, Aug 4, 2020 at 12:29 PM Vladimir Oltean wrote: > > > > > > > > On Tue, Aug 04, 2020 at 07:54:1

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Russell King - ARM Linux admin
On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote: > > > On 31/07/2020 13:06, Kurt Kanzenbach wrote: > > On Thu Jul 30 2020, Petr Machata wrote: > > > Kurt Kanzenbach writes: > > > > > > > @@ -107,6 +107,37 @@ unsigned int ptp_classify_raw(const struct sk_buff > > > > *skb) > >

[PATCH] cfg80211: switch from WARN() to pr_warn() in is_user_regdom_saved()

2020-08-04 Thread Rustam Kovhaev
this warning can be triggered by userspace, so it should not cause a panic if panic_on_warn is set Reported-and-tested-by: syzbot+d451401ffd00a6067...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=d451401ffd00a60677ee Signed-off-by: Rustam Kovhaev --- net/wireless/reg.c

Re: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog

2020-08-04 Thread Song Liu
> On Aug 2, 2020, at 10:10 PM, Andrii Nakryiko > wrote: > > On Sun, Aug 2, 2020 at 9:47 PM Song Liu wrote: >> >> >>> On Aug 2, 2020, at 6:51 PM, Andrii Nakryiko >>> wrote: >>> >>> On Sat, Aug 1, 2020 at 1:50 AM Song Liu wrote: Add a benchmark to compare performance of 1)

RE: [PATCH][v2] i40e: optimise prefetch page refcount

2020-08-04 Thread Bowers, AndrewX
> -Original Message- > From: Li RongQing > Sent: Friday, July 31, 2020 3:38 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; > k...@kernel.org; Bowers, AndrewX ; > Nguyen, Anthony L > Subject: [PATCH][v2] i40e: optimise prefetch page refcount > > refcount of rx_buffer p

Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function

2020-08-04 Thread Grygorii Strashko
On 31/07/2020 13:06, Kurt Kanzenbach wrote: On Thu Jul 30 2020, Petr Machata wrote: Kurt Kanzenbach writes: @@ -107,6 +107,37 @@ unsigned int ptp_classify_raw(const struct sk_buff *skb) } EXPORT_SYMBOL_GPL(ptp_classify_raw); +struct ptp_header *ptp_parse_header(struct sk_buff *skb,

Re: [PATCH] net: add support for threaded NAPI polling

2020-08-04 Thread Eric Dumazet
On 8/2/20 7:27 AM, Sebastian Gottschall wrote: > > Am 31.07.2020 um 18:36 schrieb Eric Dumazet: >> >> On 7/30/20 10:21 AM, Sebastian Gottschall wrote: >>> Am 30.07.2020 um 18:08 schrieb Eric Dumazet: On 7/30/20 7:30 AM, Sebastian Gottschall wrote: > Am 29.07.2020 um 19:44 schrieb Eric

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-08-04 Thread Jakub Kicinski
On Tue, 4 Aug 2020 12:04:18 +0200 Jiri Pirko wrote: > Mon, Aug 03, 2020 at 10:57:03PM CEST, k...@kernel.org wrote: > >I was trying to avoid having to provide a Cartesian product of > >operation and system disruption level, if any other action can > >be done "live" at some point. > > > >But no stron

Re: [PATCH 0/5] Netfilter fixes for net

2020-08-04 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 4 Aug 2020 22:02:03 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Flush the cleanup xtables worker to make sure destructors >have completed, from Florian Westphal. > > 2) iifgroup is matching erroneously, also from Florian. > >

Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-08-04 Thread Florian Fainelli
On 8/4/2020 12:54 PM, Vladimir Oltean wrote: > On Tue, Aug 04, 2020 at 08:51:00AM -0700, Florian Fainelli wrote: >> "I looked into it deeper, the driver does rxvlan offloading." >> >> Is this part of the driver upstream or are you using a vendor tree from >> Freescale which has that change inclu

[PATCH] farsync: switch from 'pci_' to 'dma_' API

2020-08-04 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'fst_add_one()', GFP_KERNEL can be used because it i

[PATCH] wan: wanxl: switch from 'pci_' to 'dma_' API

2020-08-04 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'wanxl_pci_init_one()', GFP_KERNEL can be used becau

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-04 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 4 Aug 2020 07:40:30 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCHv2 net] net: thunderx: use spin_lock_bh in nicvf_set_rx_mode_task()

2020-08-04 Thread David Miller
From: Xin Long Date: Tue, 4 Aug 2020 15:02:30 +0800 > A dead lock was triggered on thunderx driver: > > CPU0CPU1 > >[01] lock(&(&nic->rx_mode_wq_lock)->rlock); >[11] lock(&(&mc->mca_lock)->rlock); >

[PATCH 5/5] netfilter: flowtable: Set offload timeout when adding flow

2020-08-04 Thread Pablo Neira Ayuso
From: Roi Dayan On heavily loaded systems the GC can take time to go over all existing conns and reset their timeout. At that time other calls like from nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as expired. To fix this when we set the offload bit we should also reset the t

[PATCH 1/5] netfilter: nft_compat: make sure xtables destructors have run

2020-08-04 Thread Pablo Neira Ayuso
From: Florian Westphal Pablo Neira found that after recent update of xt_IDLETIMER the iptables-nft tests sometimes show an error. He tracked this down to the delayed cleanup used by nf_tables core: del rule (transaction A) add rule (transaction B) Its possible that by time transaction B (both i

[PATCH 3/5] selftests: netfilter: add meta iif/oif match test

2020-08-04 Thread Pablo Neira Ayuso
From: Florian Westphal simple test case, but would have caught this: FAIL: iifgroupcount, want "packets 2", got table inet filter { counter iifgroupcount { packets 0 bytes 0 } } Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- tools/testing

  1   2   3   >