Re: [PATCH v2 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

On 2020/7/14 15:32, Weilong Chen wrote: > When vlan_newlink call register_vlan_dev fails, it might return error > with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should > free the memory. But currently rtnl_newlink only free the memory which > state is NETREG_UNINITIALIZED. > > BUG:

[PATCH v2 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

When vlan_newlink call register_vlan_dev fails, it might return error with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should free the memory. But currently rtnl_newlink only free the memory which state is NETREG_UNINITIALIZED. BUG: memory leak unreferenced object 0x8881051de000 (si

Re: [PATCH net-next] rtnetlink: Fix memory(net_device) leak when ->newlink fails

On 2020/7/14 3:02, David Miller wrote: > From: Weilong Chen > Date: Mon, 13 Jul 2020 15:55:28 +0800 > >> When vlan_newlink call register_vlan_dev fails, it might return error >> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should >> free the memory. But currently rtnl_newlink only

[PATCH net-next] can: silence remove_proc_entry warning

If can_init_proc() fail to create /proc/net/can directory, can_remove_proc() will trigger a warning: WARNING: CPU: 6 PID: 7133 at fs/proc/generic.c:672 remove_proc_entry+0x17b0 Kernel panic - not syncing: panic_on_warn set ... Fix to return early from can_remove_proc() if can proc_dir does not ex

[net-next PATCH 2/2] octeontx2-af: add nix error af interrupt handlers

From: Jerin Jacob Added debug messages for NIX_AF_RVU_INT, NIX_AF_ERR_INT and NIX_AF_RAS error AF interrupts. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Rakesh Babu Signed-off-by: Subbaraya Sundeep --- .../net/ethernet/marvell/octeontx2/af/rvu.c | 5 +

Re: [PATCH v2 bpf-next 3/8] bpf, xdp: add bpf_link-based XDP attachment API

Hi Andrii, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/BPF-XDP-link/20200714-120909 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-defconf

[net-next PATCH 1/2] octeontx2-af: add npa error af interrupt handlers

From: Jerin Jacob Added debug messages for NPA NPA_AF_RVU_INT, NPA_AF_GEN_INT, NPA_AF_ERR_INT and NPA_AF_RAS error AF interrupts Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Rakesh Babu Signed-off-by: Subbaraya Sundeep --- .../net/ethernet/marvell/octeontx2

[net-next PATCH 0/2] Interrupt handler support for NPA and NIX in

From: Rakesh Babu Different types of error interrupts are reported by NPA and NIX blocks like unmapped slot errors, RAS interrupts, memory fault errors etc. This patch series adds interrupt handler support for NPA and NIX functional blocks in RVU AF driver to know the source of error interrupts.

[PATCHv7 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test

Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMA

[PATCHv7 bpf-next 0/3] xdp: add a new helper for dev map multicast support

This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv7 bpf-next 1/3] xdp: add a new helper for dev map multicast support

This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv7 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test

This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. Signed-off-by: Hangbin Liu --- v5: add a null_map as we have strict the arg2 to ARG_CONST_MAP_PTR. Move the testing part to bpf selftest in next patch. v4: no update. v3: add rxcnt map to

KASAN: global-out-of-bounds Read in __xfrm6_tunnel_spi_lookup

Hello, syzbot found the following crash on: HEAD commit:be978f8f Add linux-next specific files for 20200713 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=11e7916710 kernel config: https://syzkaller.appspot.com/x/.config?x=3fe4fccb94cbc1a6 dashboard

general protection fault in batadv_hardif_get_by_netdev

Hello, syzbot found the following crash on: HEAD commit:0aea6d5c Merge tag 'for-linus-5.8b-rc5-tag' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1596004f10 kernel config: https://syzkaller.appspot.com/x/.config?x=66ad203c2bb6d8b dash

Re: PATCH ax25: Don't hold skb lock while doing blocking read

On Thu, Jul 9, 2020 at 12:53 PM Thomas Habets wrote: > > Here's a test program that illustrates the problem: > https://github.com/ThomasHabets/radiostuff/blob/master/ax25/axftp/examples/client_lockcheck.cc > > Before this patch, this hangs, because the read(2) blocks the > write(2). > > I see that

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

Hi Rob, On Mon Jul 13 2020, Rob Herring wrote: > On Sat, Jul 11, 2020 at 5:59 AM Kurt Kanzenbach wrote: >> How? > > I don't know, just call it 'ethernet switch' binding or something. OK. >> Yes, it's a conversion of the dsa.txt. I should have stated that more >> clearly. I didn't remove the .tx

Re: linux-next: build failure after merge of the bpf-next tree

l type "" > tmp/ccsqpVCY.s:91: Error: unrecognized symbol type "" > > I don't know what has caused this (I guess maybe the resolve_btfids > branch). > > I have used the bpf-next tree from next-20200713 for today. ok, trying to reproduce thanks, jirka

Re: [PATCH v3 1/4] Simplify usbnet_cdc_update_filter

On Mon, Jul 13, 2020 at 04:43:11PM -0400, Wxcafé wrote: > Hey, > > I've encountered that same problem a few days ago, found this thread > and these (unmerged) patches, "ported" them to a more current version > of the kernel (wasn't much work, let's be honest), and I was wondering > if it would be

Re: [PATCH bpf-next 4/4] bpf: try to use existing cgroup storage in bpf_prog_test_run_skb

Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/bpf-cgroup-skb-improvements-for-bpf_prog_test_run/20200714-022728 base: https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH v2 bpf-next 4/8] bpf, xdp: implement LINK_UPDATE for BPF XDP link

Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/BPF-XDP-link/20200714-120909 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: alpha-de

Re: [PATCH v2 bpf-next 4/8] bpf, xdp: implement LINK_UPDATE for BPF XDP link

Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/BPF-XDP-link/20200714-120909 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: parisc-d

Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

On 2020-07-13 17:50 +0530, Suraj Upadhyay wrote: > Simplify while loops into more readable and simple for loops. > > Signed-off-by: Suraj Upadhyay > --- [...] > @@ -1824,7 +1821,7 @@ static struct sk_buff *ql_build_rx_skb(struct > ql_adapter *qdev, > sbq_desc->p.skb = NULL;

BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

On Mon, Jul 13, 2020 at 1:13 PM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > Sync addition of new members from main kernel tree. > > Signed-off-by: Toke Høiland-Jørgensen > --- > tools/include/uapi/linux/bpf.h |9 +++-- > 1 file changed, 7 insertions(+), 2 deletion

Re: [PATCH 0/5] RFC: connector: Add network namespace awareness

On Tue, 2020-07-14 at 15:03 +1000, Aleksa Sarai wrote: > On 2020-07-13, Eric W. Biederman wrote: > > Matt Bennett writes: > > > > > On Thu, 2020-07-02 at 21:10 +0200, Christian Brauner wrote: > > > > On Thu, Jul 02, 2020 at 08:17:38AM -0500, Eric W. Biederman wrote: > > > > > Matt Bennett write

Re: [pull request][net-next 00/13] Mellanox, mlx5 CT updates 2020-07-09

On Fri, 2020-07-10 at 14:12 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 9 Jul 2020 20:44:19 -0700 > > > This series provides updates to mlx5 CT (connection tracking) > offloads > > For more information please see tag log below. > > > > Please pull and let me know if there is

Re: [PATCH 0/5] RFC: connector: Add network namespace awareness

On 2020-07-13, Eric W. Biederman wrote: > Matt Bennett writes: > > > On Thu, 2020-07-02 at 21:10 +0200, Christian Brauner wrote: > >> On Thu, Jul 02, 2020 at 08:17:38AM -0500, Eric W. Biederman wrote: > >> > Matt Bennett writes: > >> > > >> > > Previously the connector functionality could only

Re: [Linux-kernel-mentees] [PATCH v2] bpf: Fix NULL pointer dereference in __btf_resolve_helper_id()

On Mon, Jul 13, 2020 at 6:29 PM Peilin Ye wrote: > > Prevent __btf_resolve_helper_id() from dereferencing `btf_vmlinux` > as NULL. This patch fixes the following syzbot bug: > > > https://syzkaller.appspot.com/bug?id=5edd146856fd513747c1992442732e5a0e9ba355 > > Reported-by: syzbot+ee09bda7017

[PATCH v2 bpf-next 5/8] bpf: implement BPF XDP link-specific introspection APIs

Implement XDP link-specific show_fdinfo and link_info to emit ifindex. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 3 +++ net/core/dev.c | 31 +++ 2 files changed, 34 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linu

[PATCH v2 bpf-next 0/8] BPF XDP link

Following cgroup and netns examples, implement bpf_link support for XDP. The semantics is described in patch #2. Program and link attachments are mutually exclusive, in the sense that neither link can replace attached program nor program can replace attached link. Link can't replace attached link

[PATCH v2 bpf-next 7/8] selftests/bpf: add BPF XDP link selftests

Add selftest validating all the attachment logic around BPF XDP link. Test also link updates and get_obj_info() APIs. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/xdp_link.c | 137 ++ .../selftests/bpf/progs/test_xdp_link.c | 12 ++ 2 files changed

[PATCH v2 bpf-next 8/8] bpf, xdp: remove XDP_QUERY_PROG and XDP_QUERY_PROG_HW XDP commands

Now that BPF program/link management is centralized in generic net_device code, kernel code never queries program id from drivers, so XDP_QUERY_PROG/XDP_QUERY_PROG_HW commands are unnecessary. This patch removes all the implementations of those commands in kernel, along the xdp_attachment_query().

[PATCH v2 bpf-next 4/8] bpf, xdp: implement LINK_UPDATE for BPF XDP link

Add support for LINK_UPDATE command for BPF XDP link to enable reliable replacement of underlying BPF program. Signed-off-by: Andrii Nakryiko --- net/core/dev.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index

[PATCH v2 bpf-next 2/8] bpf, xdp: extract commong XDP program attachment logic

Further refactor XDP attachment code. dev_change_xdp_fd() is split into two parts: getting bpf_progs from FDs and attachment logic, working with bpf_progs. This makes attachment logic a bit more straightforward and prepares code for bpf_xdp_link inclusion, which will share the common logic. Signe

[PATCH v2 bpf-next 1/8] bpf, xdp: maintain info on attached XDP BPF programs in net_device

Instead of delegating to drivers, maintain information about which BPF programs are attached in which XDP modes (generic/skb, driver, or hardware) locally in net_device. This effectively obsoletes XDP_QUERY_PROG command. Such re-organization simplifies existing code already. But it also allows to

[PATCH v2 bpf-next 6/8] libbpf: add support for BPF XDP link

Sync UAPI header and add support for using bpf_link-based XDP attachment. Make xdp/ prog type set expected attach type. Kernel didn't enforce attach_type for XDP programs before, so there is no backwards compatiblity issues there. Also fix section_names selftest to recognize that xdp prog types no

[PATCH v2 bpf-next 3/8] bpf, xdp: add bpf_link-based XDP attachment API

Add bpf_link-based API (bpf_xdp_link) to attach BPF XDP program through BPF_LINK_CREATE command. bpf_xdp_link is mutually exclusive with direct BPF program attachment, previous BPF program should be detached prior to attempting to create a new bpf_xdp_link attachment (for a given XDP mode). Once B

Re: [PATCH bpf-next 2/6] bpf: verifier: refactor check_attach_btf_id()

Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on vhost/linux-next ipvs/master v5.8-rc5 next-20200713] [cannot apply to bpf-next/master bpf/master net/master] [If your patch is applied to the wrong git tree, k

WARNING in __nf_unregister_net_hook (2)

Hello, syzbot found the following crash on: HEAD commit:0aea6d5c Merge tag 'for-linus-5.8b-rc5-tag' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1646fd6710 kernel config: https://syzkaller.appspot.com/x/.config?x=b1a5a263f7a540cb das

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

On Tue, Jul 14, 2020 at 03:00:45AM +0200, Maciej Fijalkowski wrote: > On Fri, Jul 10, 2020 at 08:25:20PM -0700, Alexei Starovoitov wrote: > > On Fri, Jul 10, 2020 at 8:20 PM Alexei Starovoitov > > wrote: > > > > > > Of course you are right. > > > pop+nop+push is incorrect. > > > > > > How about th

Re: [PATCH] tipc: Don't using smp_processor_id() in preemptible code

On 7/13/20 6:53 PM, qiang.zh...@windriver.com wrote: > From: Zhang Qiang > > CPU: 0 PID: 6801 Comm: syz-executor201 Not tainted 5.8.0-rc4-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, > BIOS Google 01/01/2011 > > Reported-by: syzbot+263f8c0d007dc09b2...@syzk

Re: [PATCH bpf-next 3/4] bpf: export some cgroup storages allocation helpers for reusing

/bpf-next.git master config: mips-randconfig-r034-20200713 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master

Re: [PATCH net-next 04/12] xgbe: convert to new udp_tunnel_nic infra

Hi Jakub, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/udp_tunnel-NIC-RX-port-offload-infrastructure/20200714-083337 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Re: [PATCH net-next v3 2/4] net/sched: Introduce action hash

On 7/13/20 6:04 PM, Cong Wang wrote: On Sat, Jul 11, 2020 at 2:28 PM Ariel Levkovich wrote: Allow user to set a packet's hash value using a bpf program. The user provided BPF program is required to compute and return a hash value for the packet which is then stored in skb->hash. Can be done b

Re: [PATCH v2 7/7] dt-bindings: net: renesas,etheravb: Convert to json-schema

On Mon, 06 Jul 2020 16:35:29 +0200, Geert Uytterhoeven wrote: > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding > documentation to json-schema. > > Add missing properties. > Update the example to match reality. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Sergei Sht

Re: [PATCH v2 2/7] dt-bindings: net: renesas,ravb: Document internal clock delay properties

On Mon, 06 Jul 2020 16:35:24 +0200, Geert Uytterhoeven wrote: > Some EtherAVB variants support internal clock delay configuration, which > can add larger delays than the delays that are typically supported by > the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" > properties). > > Add

Re: [PATCH v2 1/7] dt-bindings: net: ethernet-controller: Add internal delay properties

On Mon, 06 Jul 2020 16:35:23 +0200, Geert Uytterhoeven wrote: > Internal Receive and Transmit Clock Delays are a common setting for > RGMII capable devices. > > While these delays are typically applied by the PHY, some MACs support > configuring internal clock delay settings, too. Hence add stand

Re: [PATCH] net: xilinx: fix potential NULL dereference in temac_probe()

On 7/13/2020 7:23 PM, Xu Wang wrote: > platform_get_resource() may return NULL, add proper > check to avoid potential NULL dereferencing. > > Signed-off-by: Xu Wang > --- If you use devm_ioremap_resource() you can remove the !res check entirely which would be equally acceptable as a fix. >

Re: [PATCH net-next v1 2/5] net: sched: Introduce helpers for qevent blocks

On Fri, Jul 10, 2020 at 7:40 AM Petr Machata wrote: > > > Cong Wang writes: > > > On Wed, Jul 8, 2020 at 5:13 PM Petr Machata wrote: > >> > >> > >> Petr Machata writes: > >> > >> > Cong Wang writes: > >> > > >> > I'll think about it some more. For now I will at least fix the lack of > >> > loc

[PATCH] net: xilinx: fix potential NULL dereference in temac_probe()

platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Signed-off-by: Xu Wang --- drivers/net/ethernet/xilinx/ll_temac_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xili

linux-next: build failure after merge of the bpf-next tree

what has caused this (I guess maybe the resolve_btfids branch). I have used the bpf-next tree from next-20200713 for today. -- Cheers, Stephen Rothwell pgpZMWbcrGf6S.pgp Description: OpenPGP digital signature

linux-next: build warning after merge of the bpf-next tree

Hi all, After merging the bpf-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: ld: warning: orphan section `.BTF_ids' from `kernel/trace/bpf_trace.o' being placed in section `.BTF_ids' ld: warning: orphan section `.BTF_ids' from `kernel/bpf/btf.o' being placed

RE: [PATCH net-next 08/12] liquidio: convert to new udp_tunnel_nic infra

> From: Jakub Kicinski > Sent: Monday, July 13, 2020 5:31 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; oss-driv...@netronome.com; > simon.hor...@netronome.com; ajit.khapa...@broadcom.com; > sriharsha.basavapa...@broadcom.com; somnath.ko...@broadcom.com; > thomas.lenda...@amd.com; Ari

[PATCH] tipc: Don't using smp_processor_id() in preemptible code

From: Zhang Qiang CPU: 0 PID: 6801 Comm: syz-executor201 Not tainted 5.8.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x18f/0x20d lib/dump_stack.c:118 check_preempti

[Linux-kernel-mentees] [PATCH v2] bpf: Fix NULL pointer dereference in __btf_resolve_helper_id()

Prevent __btf_resolve_helper_id() from dereferencing `btf_vmlinux` as NULL. This patch fixes the following syzbot bug: https://syzkaller.appspot.com/bug?id=5edd146856fd513747c1992442732e5a0e9ba355 Reported-by: syzbot+ee09bda7017345f1f...@syzkaller.appspotmail.com Signed-off-by: Peilin Ye --

RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, July 14, 2020 06:49 > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Wang, Haiyue ; > netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; Kirsher, Jeffrey T > ; Lu, Nannan > ; Bowers, AndrewX > Subject: Re: [

Re: [PATCH bpf-next 4/4] bpf: try to use existing cgroup storage in bpf_prog_test_run_skb

Hi Dmitry, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/bpf-cgroup-skb-improvements-for-bpf_prog_test_run/20200714-022728 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/

Re: [PATCH net-next v3 08/12] bridge: mrp: Implement the MRP Interconnect API

The 07/13/2020 21:54, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 12/07/2020 17:05, Horatiu Vultur wrote: > > Thie patch adds support for MRP Interconnect. Similar with the MRP ring, > > if the HW can't generate

Re: [RFC PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

On Fri, Jul 10, 2020 at 08:25:20PM -0700, Alexei Starovoitov wrote: > On Fri, Jul 10, 2020 at 8:20 PM Alexei Starovoitov > wrote: > > > > Of course you are right. > > pop+nop+push is incorrect. > > > > How about the following instead: > > - during JIT: > > emit_jump(to_skip_below) <- poke->tailca

Re: pull-request: bpf-next 2020-07-13

From: Alexei Starovoitov Date: Mon, 13 Jul 2020 17:17:46 -0700 > The following pull-request contains BPF updates for your *net-next* tree. > > We've added 36 non-merge commits during the last 7 day(s) which contain > a total of 62 files changed, 2242 insertions(+), 468 deletions(-). > > The mai

Re: [PATCH] tls: add zerocopy device sendpage

From: Boris Pismenny Date: Tue, 14 Jul 2020 01:15:26 +0300 > On 13/07/2020 22:05, David Miller wrote: >> From: Boris Pismenny >> Date: Mon, 13 Jul 2020 10:49:49 +0300 >> >> Why can't the device generate the correct TLS signature when >> offloading? Just like for the protocol checksum, the devic

Re: [RFC] bonding driver terminology change proposal

From: Michal Kubecek Date: Tue, 14 Jul 2020 00:00:16 +0200 > Could we, please, avoid breaking existing userspace tools and scripts? I will not let UAPI breakage, don't worry.

Re: [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

From: Laurence Oberman Date: Mon, 13 Jul 2020 17:15:41 -0400 > This is likely firmware causing this but its starting to annoy customers. > Change the message level to verbose to prevent the spam. > > Signed-off-by: Laurence Oberman "iscsi:" doesn't belong in this Subject line. Please look at

Re: [PATCH net-next v1] hinic: add firmware update support

On 2020/7/14 6:42, Jakub Kicinski wrote: > On Mon, 13 Jul 2020 22:05:22 +0800 Luo bin wrote: >> add support to update firmware by the devlink flashing API >> >> Signed-off-by: Luo bin >> --- >> V0~V1: remove the implementation from ethtool to devlink > > Thanks! > >> +static int check_image_devi

Re: [PATCH] wan: Replace HTTP links with HTTPS ones

From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 22:48:12 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [RFC] bonding driver terminology change proposal

Stephen Hemminger wrote: >On Tue, 14 Jul 2020 00:00:16 +0200 >Michal Kubecek wrote: > >> On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: >> > To start out with, I'd like to attempt to eliminate as much of the use >> > of master and slave in the bonding driver as possible. For the m

Re: [PATCH] pcnet32: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET Date: Mon, 13 Jul 2020 22:18:45 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] amd8111e: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET Date: Mon, 13 Jul 2020 21:55:03 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [Linux-kernel-mentees] [PATCH] bpf: Fix NULL pointer dereference in __btf_resolve_helper_id()

On Mon, Jul 13, 2020 at 5:43 PM Peilin Ye wrote: > > Prevent __btf_resolve_helper_id() from dereferencing `btf_vmlinux` > as NULL. This patch fixes the following syzbot bug: > > > https://syzkaller.appspot.com/bug?id=5edd146856fd513747c1992442732e5a0e9ba355 > > Reported-by: syzbot+ee09bda7017

Re: [RFC] bonding driver terminology change proposal

From: Jarod Wilson Date: Mon, 13 Jul 2020 14:51:39 -0400 > To start out with, I'd like to attempt to eliminate as much of the use > of master and slave in the bonding driver as possible. For the most > part, I think this can be done without breaking UAPI, but may require > changes to anything acc

Re: [PATCH net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings

From: Vladimir Oltean Date: Mon, 13 Jul 2020 20:42:27 +0300 > One difference from VLAN is that in that case, the entire > register_vlan_device() function runs under RTNL. > When those bugs that you talk about are found, who starts using the > network interface too early? User space or someone els

Re: [PATCH] net: wan: cosa: Replace HTTP links with HTTPS ones

From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:34:47 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] net: jme: Replace HTTP links with HTTPS ones

From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:24:39 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH ghak90 V9 01/13] audit: collect audit task parameters

On Mon, Jul 13, 2020 at 4:30 PM Richard Guy Briggs wrote: > On 2020-07-07 21:42, Paul Moore wrote: > > On Mon, Jul 6, 2020 at 10:50 PM Richard Guy Briggs wrote: > > > On 2020-07-05 11:09, Paul Moore wrote: > > > > On Sat, Jun 27, 2020 at 9:21 AM Richard Guy Briggs > > > > wrote: ... > > > > I

Re: pull-request: wireless-drivers-2020-07-13

From: Kalle Valo Date: Mon, 13 Jul 2020 17:21:37 + (UTC) > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. ... > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > tags/wireless-drivers-2020-07-13 Pulled, than

[Linux-kernel-mentees] [PATCH] bpf: Fix NULL pointer dereference in __btf_resolve_helper_id()

Prevent __btf_resolve_helper_id() from dereferencing `btf_vmlinux` as NULL. This patch fixes the following syzbot bug: https://syzkaller.appspot.com/bug?id=5edd146856fd513747c1992442732e5a0e9ba355 Reported-by: syzbot+ee09bda7017345f1f...@syzkaller.appspotmail.com Signed-off-by: Peilin Ye --

Re: [PATCH] net: ethernet: Replace HTTP links with HTTPS ones

From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:14:29 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH v4 net-next 00/11] New DSA driver for VSC9953 Seville switch

From: Vladimir Oltean Date: Mon, 13 Jul 2020 19:57:00 +0300 > From: Vladimir Oltean > > Looking at the Felix and Ocelot drivers, Maxim asked if it would be > possible to use them as a base for a new driver for the Seville switch > inside NXP T1040. Turns out, it is! The result is that the mscc_

Re: [RFC PATCH bpf-next 0/5] bpf: tailcalls in BPF subprograms

On Fri, Jul 10, 2020 at 05:10:08PM -0700, Alexei Starovoitov wrote: > On Thu, Jul 02, 2020 at 03:49:25PM +0200, Maciej Fijalkowski wrote: > > Hello, > > > > today bpf2bpf calls and tailcalls exclude each other. This set is a > > proposal to make them work together. It is still a RFC because we nee

Re: [PATCH] ip6_gre: fix null-ptr-deref in ip6gre_init_net()

From: Wei Yongjun Date: Mon, 13 Jul 2020 23:59:50 +0800 > KASAN report null-ptr-deref error when register_netdev() failed: ... > ip6gre_tunnel_uninit() has set 'ign->fb_tunnel_dev' to NULL, later > access to ign->fb_tunnel_dev cause null-ptr-deref. Fix it by saving > 'ign->fb_tunnel_dev' to loca

[PATCH net-next 08/12] liquidio: convert to new udp_tunnel_nic infra

This driver is just a super thin FW interface. Assume it wants 256 ports at most. Not much we can do here. Signed-off-by: Jakub Kicinski --- .../net/ethernet/cavium/liquidio/lio_main.c | 59 +++ 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/drivers/net/etherne

[PATCH net-next 12/12] qlcnic: convert to new udp_tunnel_nic infra

Straightforward conversion to new infra, 1 VxLAN port, handler may sleep. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 7 +- .../ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 31 ++--- .../net/ethernet/qlogic/qlcnic/qlcnic_main.c | 64 +++

[PATCH net-next 01/12] nfp: convert to new udp_tunnel_nic infra

NFP conversion is pretty straightforward. We want to be able to sleep, and only get callbacks when the device is open. NFP did not ask for port replay when ports were removed, now new infra will provide this feature for free. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/

[PATCH net-next 11/12] qede: convert to new udp_tunnel_nic infra

Covert to new infra. Looks like this driver was not doing ref counting, and sleeping in the callback. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/qlogic/qede/qede.h | 1 + .../net/ethernet/qlogic/qede/qede_filter.c| 142 ++ drivers/net/ethernet/qlogic/qede/

[PATCH net-next 10/12] fm10k: convert to new udp_tunnel_nic infra

Straightforward conversion to new infra. Driver restores info after close/open cycle by calling its internal restore function so just use that, no need for udp_tunnel_nic_reset_ntf() here. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/fm10k/fm10k.h | 10 +- drivers/net/ether

[PATCH net-next 07/12] enic: convert to new udp_tunnel_nic infra

Convert to new infra, now the refcounting will be correct, and driver gets port replay of other ports when offloaded port gets removed. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/cisco/enic/enic_main.c | 105 1 file changed, 39 insertions(+), 66 deletions(-) dif

[PATCH net-next 05/12] bnx2x: convert to new udp_tunnel_nic infra

Fairly straightforward conversion - no need to keep track of the use count, and replay when ports get removed, also callbacks can just sleep. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 8 +- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 8 +- .../net/

[PATCH net-next 04/12] xgbe: convert to new udp_tunnel_nic infra

Make use of the new udp_tunnel_nic infra. Don't clear the features when VxLAN port is not present to make all drivers behave the same. Driver will now (until we address the problem in the core) leave the RX UDP tunnel feature always on, since this is what most drivers do. Remove the list of VxLAN

[PATCH net-next 06/12] cxgb4: convert to new udp_tunnel_nic infra

Convert to new infra, this driver is very simple. The check of adapter->rawf_cnt in cxgb_udp_tunnel_unset_port() is kept from the old port deletion function but it's dodgy since nothing ever updates that member once its set during init. Also .set_port callback always adds the raw mac filter.. Sign

[PATCH net-next 09/12] liquidio_vf: convert to new udp_tunnel_nic infra

Carbon copy of the previous change. This driver is just a super thin FW interface. Assume it wants 256 ports at most. Not much we can do here. Signed-off-by: Jakub Kicinski --- .../ethernet/cavium/liquidio/lio_vf_main.c| 59 +++ 1 file changed, 33 insertions(+), 26 deletions

[PATCH net-next 03/12] xgbe: switch to more generic VxLAN detection

Instead of looping though the list of ports just check if the geometry of the packet is correct for VxLAN. HW most likely doesn't care about the exact port, anyway, since only first port is actually offloaded, and this way we won't have to maintain the port list at all. Signed-off-by: Jakub Kicins

[PATCH net-next 02/12] be2net: convert to new udp_tunnel_nic infra

Convert be2net to new udp_tunnel_nic infra. NIC only takes one VxLAN port. Remove the port tracking using a list. The warning in be_work_del_vxlan_port() looked suspicious - like the driver expected ports to be removed in order of addition. be2net unregisters ports when going down and re-registers

[PATCH net-next 00/12] udp_tunnel: NIC RX port offload infrastructure

Hi! This set of patches converts further drivers to use the new infrastructure to UDP tunnel port offload merged in commit 0ea460474d70 ("Merge branch 'udp_tunnel-add-NIC-RX-port-offload-infrastructure'"). Jakub Kicinski (12): nfp: convert to new udp_tunnel_nic infra be2net: convert to new u

Re: [PATCH] net: phy: fix mdio-mscc-miim build

From: Bartosz Golaszewski Date: Mon, 13 Jul 2020 17:12:07 +0200 > From: Bartosz Golaszewski > > PHYLIB is not selected by mdio-mscc-miim but it uses mdio devres helpers. > Explicitly select MDIO_DEVRES in this driver's Kconfig entry. > > Reported-by: kernel test robot > Fixes: 1814cff26739 ("

Re: [PATCH net-next] devlink: Fix use-after-free when destroying health reporters

From: Ido Schimmel Date: Mon, 13 Jul 2020 18:20:14 +0300 > From: Ido Schimmel > > Dereferencing the reporter after it was destroyed in order to unlock the > reporters lock results in a use-after-free [1]. > > Fix this by storing a pointer to the lock in a local variable before > destroying the

Re: [RFC] bonding driver terminology change proposal

Hi Jarod Do you have this change scripted? Could you apply the script to v5.4 and then cherry-pick the 8 bonding fixes that exist in v5.4.51. How many result in conflicts? Could you do the same with v4.19...v4.19.132, which has 20 fixes. This will give us an idea of the maintenance overhead such

Re: [PATCH] isdn/capi: Replace HTTP links with HTTPS ones

From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 16:30:54 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH net-next v2] net: make symbol 'flush_works' static

From: Wei Yongjun Date: Mon, 13 Jul 2020 22:23:44 +0800 > The sparse tool complains as follows: > > net/core/dev.c:5594:1: warning: > symbol '__pcpu_scope_flush_works' was not declared. Should it be static? > > 'flush_works' is not used outside of dev.c, so marks > it static. > > Fixes: 41852

Re: [PATCH net-next v2 00/13] mlxsw: Add support for buffer drops mirroring

From: Petr Machata Date: Sat, 11 Jul 2020 00:55:02 +0300 > This set offloads the recently introduced qevent infrastructure in TC and > allows mlxsw to support mirroring of packets that were dropped due to > buffer related reasons (e.g., early drops) during forwarding. ... Series applied, thanks

Re: [PATCH net-next 00/20] net simple kerneldoc fixes

From: Andrew Lunn Date: Mon, 13 Jul 2020 01:14:56 +0200 > This is a collection of simple kerneldoc fixes. They are all low > hanging fruit, were not real understanding of the code was needed. Series applied, thanks Andrew.

pull-request: bpf-next 2020-07-13

Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 36 non-merge commits during the last 7 day(s) which contain a total of 62 files changed, 2242 insertions(+), 468 deletions(-). The main changes are: 1) Avoid trace_printk warning banner by switching

  1   2   3   4   5   >