Hi Dmitry, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/bpf-cgroup-skb-improvements-for-bpf_prog_test_run/20200714-022728 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: microblaze-randconfig-s031-20200714 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-41-g14e84ffc-dirty # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> net/bpf/test_run.c:25:17: sparse: sparse: incompatible types in comparison >> expression (different address spaces): >> net/bpf/test_run.c:25:17: sparse: struct bpf_prog_array [noderef] __rcu * >> net/bpf/test_run.c:25:17: sparse: struct bpf_prog_array * net/bpf/test_run.c:50:46: sparse: sparse: using member 'effective' in incomplete struct cgroup_bpf net/bpf/test_run.c:53:54: sparse: sparse: using member 'effective' in incomplete struct cgroup_bpf net/bpf/test_run.c:67:15: sparse: sparse: undefined identifier 'bpf_cgroup_storages_alloc' net/bpf/test_run.c:115:9: sparse: sparse: undefined identifier 'bpf_cgroup_storages_free' vim +25 net/bpf/test_run.c 17 18 static struct bpf_prog_array_item *bpf_prog_find_active(struct bpf_prog *prog, 19 struct bpf_prog_array *effective) 20 { 21 struct bpf_prog_array_item *item; 22 struct bpf_prog_array *array; 23 struct bpf_prog *p; 24 > 25 array = rcu_dereference(effective); 26 if (!array) 27 return NULL; 28 29 item = &array->items[0]; 30 while ((p = READ_ONCE(item->prog))) { 31 if (p == prog) 32 return item; 33 item++; 34 } 35 36 return NULL; 37 } 38 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
