Hi Dmitry, Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/bpf-cgroup-skb-improvements-for-bpf_prog_test_run/20200714-022728 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-rhel-7.6 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): net/bpf/test_run.c: In function 'bpf_prog_find_active_storage': >> net/bpf/test_run.c:50:18: error: 'struct cgroup_bpf' has no member named >> 'effective' 50 | cgrp->bpf.effective[BPF_CGROUP_INET_INGRESS]); | ^ net/bpf/test_run.c:53:19: error: 'struct cgroup_bpf' has no member named 'effective' 53 | cgrp->bpf.effective[BPF_CGROUP_INET_EGRESS]); | ^ net/bpf/test_run.c: In function 'bpf_test_run': net/bpf/test_run.c:67:8: error: implicit declaration of function 'bpf_cgroup_storages_alloc'; did you mean 'bpf_cgroup_storage_alloc'? [-Werror=implicit-function-declaration] 67 | ret = bpf_cgroup_storages_alloc(dummy_storage, prog); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | bpf_cgroup_storage_alloc net/bpf/test_run.c:115:2: error: implicit declaration of function 'bpf_cgroup_storages_free'; did you mean 'bpf_cgroup_storage_free'? [-Werror=implicit-function-declaration] 115 | bpf_cgroup_storages_free(dummy_storage); | ^~~~~~~~~~~~~~~~~~~~~~~~ | bpf_cgroup_storage_free cc1: some warnings being treated as errors vim +50 net/bpf/test_run.c 38 39 static struct bpf_cgroup_storage **bpf_prog_find_active_storage(struct bpf_prog *prog) 40 { 41 struct bpf_prog_array_item *item; 42 struct cgroup *cgrp; 43 44 if (prog->type != BPF_PROG_TYPE_CGROUP_SKB) 45 return NULL; 46 47 cgrp = task_dfl_cgroup(current); 48 49 item = bpf_prog_find_active(prog, > 50 cgrp->bpf.effective[BPF_CGROUP_INET_INGRESS]); 51 if (!item) 52 item = bpf_prog_find_active(prog, 53 cgrp->bpf.effective[BPF_CGROUP_INET_EGRESS]); 54 55 return item ? item->cgroup_storage : NULL; 56 } 57 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
