Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-11 Thread Christophe JAILLET
Le 12/07/2020 à 08:32, Joe Perches a écrit : On Sun, 2020-07-12 at 08:29 +0200, Christophe JAILLET wrote: Le 11/07/2020 à 23:20, Joe Perches a écrit : On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote: The wrappers in include/linux/pci-dma-compat.h should go away. why? From Chr

Re: [PATCH bpf-next 1/5] bpf: block bpf_get_[stack|stackid] on perf_event with PEBS entries

2020-07-11 Thread Song Liu
> On Jul 11, 2020, at 10:06 PM, Andrii Nakryiko > wrote: > > On Fri, Jul 10, 2020 at 11:28 PM Song Liu wrote: >> >> >> >>> On Jul 10, 2020, at 8:53 PM, Andrii Nakryiko >>> wrote: >>> >>> On Fri, Jul 10, 2020 at 6:30 PM Song Liu wrote: Calling get_perf_callchain() on perf_ev

Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-11 Thread Joe Perches
On Sun, 2020-07-12 at 08:29 +0200, Christophe JAILLET wrote: > Le 11/07/2020 à 23:20, Joe Perches a écrit : > > On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote: > > > The wrappers in include/linux/pci-dma-compat.h should go away. > > why? > > > > > From Christoph Hellwig > https://m

Re: [PATCH bpf-next 1/5] bpf: block bpf_get_[stack|stackid] on perf_event with PEBS entries

2020-07-11 Thread Andrii Nakryiko
On Fri, Jul 10, 2020 at 11:28 PM Song Liu wrote: > > > > > On Jul 10, 2020, at 8:53 PM, Andrii Nakryiko > > wrote: > > > > On Fri, Jul 10, 2020 at 6:30 PM Song Liu wrote: > >> > >> Calling get_perf_callchain() on perf_events from PEBS entries may cause > >> unwinder errors. To fix this issue, t

Re: amplifying qdisc

2020-07-11 Thread Russell Strong
On Wed, 8 Jul 2020 23:26:34 -0700 Stephen Hemminger wrote: > On Thu, 9 Jul 2020 16:10:34 +1000 > Russell Strong wrote: > > > Hi, > > > > I'm attempting to fill a link with background traffic that is sent > > whenever the link is idle. To do this I've creates a qdisc that > > will repeat the l

[PATCH net 3/3] bnxt_en: Fix completion ring sizing with TPA enabled.

2020-07-11 Thread Michael Chan
The current completion ring sizing formula is wrong with TPA enabled. The formula assumes that the number of TPA completions are bound by the RX ring size, but that's not true. TPA_START completions are immediately recycled so they are not bound by the RX ring size. We must add bp->max_tpa to the

[PATCH net 2/3] bnxt_en: Init ethtool link settings after reading updated PHY configuration.

2020-07-11 Thread Michael Chan
From: Vasundhara Volam In a shared port PHY configuration, async event is received when any of the port modifies the configuration. Ethtool link settings should be initialised after updated PHY configuration from firmware. Fixes: b1613e78e98d ("bnxt_en: Add async. event logic for PHY configurati

[PATCH net 0/3] bnxt_en: 3 bug fixes.

2020-07-11 Thread Michael Chan
2 Fixes related to PHY/link settings. The last one fixes the sizing of the completion ring. Please also queue for -stable. Thanks. Michael Chan (1): bnxt_en: Fix completion ring sizing with TPA enabled. Vasundhara Volam (2): bnxt_en: Fix race when modifying pause settings. bnxt_en: Init

[PATCH net 1/3] bnxt_en: Fix race when modifying pause settings.

2020-07-11 Thread Michael Chan
From: Vasundhara Volam The driver was modified to not rely on rtnl lock to protect link settings about 2 years ago. The pause setting was missed when making that change. Fix it by acquiring link_lock mutex before calling bnxt_hwrm_set_pause(). Fixes: e2dc9b6e38fa ("bnxt_en: Don't use rtnl lock

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Implement MTU change

2020-07-11 Thread Andrew Lunn
On Sun, Jul 12, 2020 at 01:29:44AM +0200, Marek Behun wrote: > On Sat, 11 Jul 2020 22:32:05 +0200 > Andrew Lunn wrote: > > > The Marvell Switches support jumbo packages. So implement the > > callbacks needed for changing the MTU. > > > > Signed-off-by: Andrew Lunn > > Hi Andrew, > > maybe thi

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Implement MTU change

2020-07-11 Thread Marek Behun
On Sat, 11 Jul 2020 22:32:05 +0200 Andrew Lunn wrote: > The Marvell Switches support jumbo packages. So implement the > callbacks needed for changing the MTU. > > Signed-off-by: Andrew Lunn Hi Andrew, maybe this could be sent to net, not only net-next. Or maybe even better, with a Fixes tag t

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-11 Thread Vladimir Oltean
Hi Sergey, On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: > Fix support for external PTP-aware devices such as DSA or PTP PHY: > > Make sure we never time stamp tx packets when hardware time stamping > is disabled. > > Check for PTP PHY being in use and then pass ioctls related

Re: [PATCH net-next 0/2] Fix MTU warnings for fec/mv886xxx combo

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 10:26:18PM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jul 11, 2020 at 10:32:04PM +0200, Andrew Lunn wrote: > > Since changing the MTU of dsa slave interfaces was implemented, the > > fec/mv88e6xxx combo has been giving warnings: > > > > [2.275925] mv88e6085

[PATCH v7 bpf-next 0/9] bpf: Add d_path helper - preparation changes

2020-07-11 Thread Jiri Olsa
hi, this patchset does preparation work for adding d_path helper, which still needs more work, but the initial set of patches is ready and useful to have. This patchset adds: - support to generate BTF ID lists that are resolved during kernel linking and usable within kernel code with followi

[PATCH v7 bpf-next 5/9] bpf: Remove btf_id helpers resolving

2020-07-11 Thread Jiri Olsa
Now when we moved the helpers btf_id arrays into .BTF_ids section, we can remove the code that resolve those IDs in runtime. Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 89 +++- 1 file changed,

[PATCH v7 bpf-next 8/9] tools headers: Adopt verbatim copy of btf_ids.h from kernel sources

2020-07-11 Thread Jiri Olsa
It will be needed by bpf selftest for resolve_btfids tool. Also adding __PASTE macro as btf_ids.h dependency, which is defined in: include/linux/compiler_types.h but because tools/include do not have this header, I'm putting the macro into linux/compiler.h header. Acked-by: Andrii Nakryiko T

[PATCH v7 bpf-next 4/9] bpf: Resolve BTF IDs in vmlinux image

2020-07-11 Thread Jiri Olsa
Using BTF_ID_LIST macro to define lists for several helpers using BTF arguments. And running resolve_btfids on vmlinux elf object during linking, so the .BTF_ids section gets the IDs resolved. Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- Makefile

[PATCH v7 bpf-next 3/9] bpf: Add BTF_ID_LIST/BTF_ID/BTF_ID_UNUSED macros

2020-07-11 Thread Jiri Olsa
Adding support to generate .BTF_ids section that will hold BTF ID lists for verifier. Adding macros that will help to define lists of BTF ID values placed in .BTF_ids section. They are initially filled with zeros (during compilation) and resolved later during the linking phase by resolve_btfids to

[PATCH v7 bpf-next 6/9] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-07-11 Thread Jiri Olsa
This way the ID is resolved during compile time, and we can remove the runtime name search. Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/kernel/bpf/btf.c b/k

[PATCH v7 bpf-next 9/9] selftests/bpf: Add test for resolve_btfids

2020-07-11 Thread Jiri Olsa
Adding resolve_btfids test under test_progs suite. It's possible to use btf_ids.h header and its logic in user space application, so we can add easy test for it. The test defines BTF_ID_LIST and checks it gets properly resolved. For this reason the test_progs binary (and other binaries that use

[PATCH v7 bpf-next 7/9] bpf: Add info about .BTF_ids section to btf.rst

2020-07-11 Thread Jiri Olsa
Updating btf.rst doc with info about .BTF_ids section Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- Documentation/bpf/btf.rst | 36 1 file changed, 36 insertions(+) diff --git a/Documentation/bpf/btf.rst b/Documentation/

[PATCH v7 bpf-next 2/9] bpf: Compile resolve_btfids tool at kernel compilation start

2020-07-11 Thread Jiri Olsa
The resolve_btfids tool will be used during the vmlinux linking, so it's necessary it's ready for it. Acked-by: Andrii Nakryiko Tested-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- Makefile | 22 ++ tools/Makefile | 3 +++ tools/bpf/Makefile | 9 -

[PATCH v7 bpf-next 1/9] bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object

2020-07-11 Thread Jiri Olsa
The resolve_btfids tool scans elf object for .BTF_ids section and resolves its symbols with BTF ID values. It will be used to during linking time to resolve arrays of BTF ID values used in verifier, so these IDs do not need to be resolved in runtime. The expected layout of .BTF_ids section is des

Re: [net-next PATCH v6 4/6] net: phy: introduce phy_find_by_mdio_handle()

2020-07-11 Thread Florian Fainelli
On 7/10/2020 11:55 PM, Calvin Johnson wrote: > The PHYs on an mdiobus are probed and registered using mdiobus_register(). > Later, for connecting these PHYs to MAC, the PHYs registered on the > mdiobus have to be referenced. > > For each MAC node, a property "mdio-handle" is used to reference t

Re: [net-next PATCH v6 5/6] phylink: introduce phylink_fwnode_phy_connect()

2020-07-11 Thread Florian Fainelli
On 7/10/2020 11:55 PM, Calvin Johnson wrote: > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. > > Signed-off-by: Calvin Johnson > > --- [snip] > +int phylink_fwnode_phy_connect(struct phylink *pl, > +struct fwnod

Re: [net-next PATCH v6 2/6] net: phy: introduce device_mdiobus_register()

2020-07-11 Thread Florian Fainelli
On 7/10/2020 11:55 PM, Calvin Johnson wrote: > Introduce device_mdiobus_register() to register mdiobus > in cases of either DT or ACPI. > > Signed-off-by: Calvin Johnson > > --- > > Changes in v6: > - change device_mdiobus_register() parameter position > - improve documentation > > Changes

[PATCH net-next v3 2/4] net/sched: Introduce action hash

2020-07-11 Thread Ariel Levkovich
Allow user to set a packet's hash value using a bpf program. The user provided BPF program is required to compute and return a hash value for the packet which is then stored in skb->hash. Using this action to set the skb->hash is an alternative to setting it with act_skbedit and can be useful for

[PATCH net-next v3 3/4] net/flow_dissector: add packet hash dissection

2020-07-11 Thread Ariel Levkovich
Retreive a hash value from the SKB and store it in the dissector key for future matching. Signed-off-by: Ariel Levkovich Reviewed-by: Jiri Pirko --- include/linux/skbuff.h | 4 include/net/flow_dissector.h | 9 + net/core/flow_dissector.c| 17 + 3 files

[PATCH net-next v3 1/4] net/sched: Add skb->hash field editing via act_skbedit

2020-07-11 Thread Ariel Levkovich
Extend act_skbedit api to allow writing into skb->hash field. To modify skb->hash user selects the hash algorithm to use for the hash computation and can provide a hash basis value to be used in the calculation. The hash value will be calculated on the packet in the datapath and will be set into s

[PATCH net-next v3 0/4] ] TC datapath hash api

2020-07-11 Thread Ariel Levkovich
Supporting datapath hash allows user to set up rules that provide load balancing of traffic across multiple vports and for ECMP path selection while keeping the number of rule at minimum. Instead of matching on exact flow spec, which requires a rule per flow, user can define rules based on hashing

[PATCH net-next v3 4/4] net/sched: cls_flower: Add hash info to flow classification

2020-07-11 Thread Ariel Levkovich
Adding new cls flower keys for hash value and hash mask and dissect the hash info from the skb into the flow key towards flow classication. Signed-off-by: Ariel Levkovich Reviewed-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 3 +++ net/sched/cls_flower.c | 16 2 fil

Re: [PATCH net-next 0/2] Fix MTU warnings for fec/mv886xxx combo

2020-07-11 Thread Russell King - ARM Linux admin
On Sat, Jul 11, 2020 at 10:32:04PM +0200, Andrew Lunn wrote: > Since changing the MTU of dsa slave interfaces was implemented, the > fec/mv88e6xxx combo has been giving warnings: > > [2.275925] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 9 > [2.284306] eth1: mtu greater than d

Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-11 Thread Joe Perches
On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. why?

[PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-11 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GPF_ with a correct flag. It has been compile tested. When memory is allocated in 'sky2_alloc_buffers()', GFP_KERNEL can be used becau

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-11 Thread Richard Cochran
On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: > +static void hellcreek_get_rxts(struct hellcreek *hellcreek, > +struct hellcreek_port_hwtstamp *ps, > +struct sk_buff *skb, struct sk_buff_head *rxq, > +

Re: [PATCH v1 3/8] net: dsa: hellcreek: Add PTP clock support

2020-07-11 Thread Florian Fainelli
On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: > From: Kamil Alkhouri > > The switch has internal PTP hardware clocks. Add support for it. There are > three > clocks: > > * Synchronized > * Syntonized > * Free running > > Currently the synchronized clock is exported to user space which is

[PATCH] net: skge: switch from 'pci_' to 'dma_' API

2020-07-11 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GPF_ with a correct flag. It has been compile tested. When memory is allocated in 'skge_up()', GFP_KERNEL can be used because some oth

Re: [PATCH v1 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-07-11 Thread Florian Fainelli
On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time Aware > Shaper. >

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Implement MTU change

2020-07-11 Thread Andrew Lunn
The Marvell Switches support jumbo packages. So implement the callbacks needed for changing the MTU. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa

[PATCH net-next 2/2] net: fec: Set max MTU size to allow the MTU to be changed

2020-07-11 Thread Andrew Lunn
The FEC allocates 2K buffers, but looses some of it due to alignment. It can however support an MTU bigger than the default. This is particularly interesting when used in combination with Ethernet switches supporting DSA, which have extra headers. The DSA core will try to increase the MTU to suppor

[PATCH net-next 0/2] Fix MTU warnings for fec/mv886xxx combo

2020-07-11 Thread Andrew Lunn
Since changing the MTU of dsa slave interfaces was implemented, the fec/mv88e6xxx combo has been giving warnings: [2.275925] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 9 [2.284306] eth1: mtu greater than device maximum [2.287759] fec 400d1000.ethernet eth1: error -22 sett

Re: [PATCH v1 3/8] net: dsa: hellcreek: Add PTP clock support

2020-07-11 Thread Richard Cochran
On Fri, Jul 10, 2020 at 01:36:06PM +0200, Kurt Kanzenbach wrote: > From: Kamil Alkhouri > > The switch has internal PTP hardware clocks. Add support for it. There are > three > clocks: > > * Synchronized > * Syntonized > * Free running > > Currently the synchronized clock is exported to use

Re: [PATCH v1 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-07-11 Thread Florian Fainelli
On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: > Add basic documentation and example. > > Signed-off-by: Kurt Kanzenbach > --- > .../bindings/net/dsa/hellcreek.yaml | 132 ++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ne

Re: [PATCH v1 7/8] dt-bindings: Add vendor prefix for Hirschmann

2020-07-11 Thread Florian Fainelli
On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: > Hirschmann is building devices for automation and networking. Add them to the > vendor prefixes. > > Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v6 bpf-next 0/9] bpf: Add d_path helper - preparation changes

2020-07-11 Thread Jiri Olsa
On Fri, Jul 10, 2020 at 01:46:02PM -0700, Andrii Nakryiko wrote: > On Fri, Jul 10, 2020 at 12:38 PM Jiri Olsa wrote: > > > > hi, > > this patchset does preparation work for adding d_path helper, > > which still needs more work, but the initial set of patches > > is ready and useful to have. > > >

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 11:41:25AM -0400, min.li...@renesas.com wrote: > From: Min Li > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > It will create a debugfs directory called idtptp{x} and x is the ptp index. > Three inerfaces are present, which are cmd, help and

Re: [PATCH v1 1/8] net: dsa: Add tag handling for Hirschmann Hellcreek switches

2020-07-11 Thread Florian Fainelli
On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: The Hirschmann Hellcreek TSN switches have a special tagging protocol for frames exchanged between the CPU port and the master interface. The format is a one byte trailer indicating the destination or origin port. It's quite similar to the Micrel K

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-11 Thread Russell King - ARM Linux admin
On Sat, Jul 11, 2020 at 06:23:49PM +0200, Andrew Lunn wrote: > So i'm guessing it is the connection between the CPU and the switch. > Could you confirm this? Create a bridge, add two ports of the switch > to the bridge, and then see if packets can pass between switch ports. > > If it is the connec

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 11:38:39AM -0700, Richard Cochran wrote: > On Sat, Jul 11, 2020 at 06:38:06PM +0200, Andrew Lunn wrote: > > But configuration does not belong in debugfs. It would be good to > > explain what is being configured by these parameters, then we can > > maybe make a suggestion abo

Re: [PATCH net-next v2 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-07-11 Thread Andrew Lunn
> @@ -302,6 +357,48 @@ static int dp83822_config_init(struct phy_device *phydev) > } > } > > + if (dp83822->fx_enabled) { > + err = phy_modify(phydev, MII_DP83822_CTRL_2, > + DP83822_FX_ENABLE, 1); > + if (err < 0) > +

Re: [PATCH net-next v2 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-07-11 Thread Andrew Lunn
> +#define MII_DP83822_FIBER_ADVERTISE (SUPPORTED_AUI | SUPPORTED_FIBRE | \ > + SUPPORTED_BNC | SUPPORTED_Pause | \ > + SUPPORTED_Asym_Pause | \ > + SUPPORTED_100baseT_Full) > + > +

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Richard Cochran
On Sat, Jul 11, 2020 at 06:38:06PM +0200, Andrew Lunn wrote: > But configuration does not belong in debugfs. It would be good to > explain what is being configured by these parameters, then we can > maybe make a suggestion about the correct API to use. Can we at least enumerate the possibilities?

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > This patch support for cable test for the ksz886x switches and the > ksz8081 PHY. > > The patch was tested on a KSZ8873RLL switch with following results: > > - port 1: > - cannot detect any distance > - provides inverted values

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > This patch support for cable test for the ksz886x switches and the > ksz8081 PHY. > > The patch was tested on a KSZ8873RLL switch with following results: > > - port 1: > - cannot detect any distance > - provides inverted values

Re: [PATCH net-next v2 01/13] net: sched: Pass qdisc reference in struct flow_block_offload

2020-07-11 Thread Jakub Kicinski
On Sat, 11 Jul 2020 00:55:03 +0300 Petr Machata wrote: > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > index 0a9a4467d7c7..e82e5cf64d61 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > +++ b/drivers/net/ethernet/broadcom/b

Re: [PATCH] xsk: ixgbe: solve the soft interrupt 100% CPU usage when xdp rx traffic congestion

2020-07-11 Thread Jakub Kicinski
On Sat, 11 Jul 2020 18:10:38 +0800 Yahui Chen wrote: > 2. If the wakeup mechanism is used, that is, use the > `XDP_UMEM_USES_NEED_WAKEUP` flag. This method takes advantage of the > interrupt delay function of ixgbe skillfully, thus solving the problem > that the si CPU is always 100%. However, it w

INFO: trying to register non-static key in addrconf_notify

2020-07-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=102d01a310 kernel config: https://syzkaller.appspot.com/x/.config?x=183dd243398ba7ec das

general protection fault in htab_elem_free_rcu

2020-07-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d31958b3 Add linux-next specific files for 20200710 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1393585710 kernel config: https://syzkaller.appspot.com/x/.config?x=3fe4fccb94cbc1a6 dashboard

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 01:35:12PM +0200, Kurt Kanzenbach wrote: > On Fri Jul 10 2020, Rob Herring wrote: > > On Fri, 10 Jul 2020 11:06:18 +0200, Kurt Kanzenbach wrote: > >> For future DSA drivers it makes sense to add a generic DSA yaml binding > >> which > >> can be used then. This was created u

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

2020-07-11 Thread Andrew Lunn
> > Though I missed that this is really just a conversion of dsa.txt which > > should be removed in this patch. Otherwise, you'll get me re-reviewing > > the binding. > > Yes, it's a conversion of the dsa.txt. I should have stated that more > clearly. I didn't remove the .txt file, because it's re

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 06:46:01AM -0700, Richard Cochran wrote: > On Fri, Jul 10, 2020 at 01:58:44PM -0700, Jakub Kicinski wrote: > > On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > > > From: Min Li > > > > > > This patch is to add debugfs support for ptp_clockmatrix and ptp_id

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 01:50:21PM +, Martin Rowe wrote: > Hello, > > I hope this is the right forum. > > I have been troubleshooting an issue with my Clearfog GT 8Ks where I > am unable to tx or rx on the switch interface, which uses the > mv88e6xxx driver. Based on git bisect, I believe it

Re: [PATCHv6 bpf-next 1/3] xdp: add a new helper for dev map multicast support

2020-07-11 Thread David Ahern
On 7/10/20 6:26 PM, Hangbin Liu wrote: >> >> The point of DEVMAP_HASH is to allow map management where key == device >> index (vs DEVMAP which for any non-trivial use case is going to require >> key != device index). You could require the exclude map to be >> DEVMAP_HASH and the key to be the index

Re: [PATCH v4] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

2020-07-11 Thread Alexander Duyck
On Fri, Jul 10, 2020 at 11:13 PM Sridhar Samudrala wrote: > > This patch triggers non-blocking busy poll when busy_poll is enabled, > epoll is called with a timeout of 0 and is associated with a napi_id. > This enables an app thread to go through napi poll routine once by > calling epoll with a 0

NAT performance issue 944mbit -> ~40mbit

2020-07-11 Thread Ian Kumlien
Hi, I first detected this with 5.7.6 but it seems to apply as far back as 5.6.1... (so, 5.7.8 client -> nat (5.6.1 -> 5.8-rc4 -> server 5.7.7) It seems to me that the window size doesn't advance, so i did revert the tcp: grow window for OOO packets only for SACK flows [1] but it did no difference

[PATCH net-next] net: bridge: notify on vlan tunnel changes done via the old api

2020-07-11 Thread Nikolay Aleksandrov
If someone uses the old vlan API to configure tunnel mappings we'll only generate the old-style full port notification. That would be a problem if we are monitoring the new vlan notifications for changes. The patch resolves the issue by adding vlan notifications to the old tunnel netlink code. As u

bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

2020-07-11 Thread Martin Rowe
Hello, I hope this is the right forum. I have been troubleshooting an issue with my Clearfog GT 8Ks where I am unable to tx or rx on the switch interface, which uses the mv88e6xxx driver. Based on git bisect, I believe it is related to commit 34b5e6a33c1a8e466c3a73fd437f66fb16cb83ea from around t

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Richard Cochran
On Fri, Jul 10, 2020 at 01:58:44PM -0700, Jakub Kicinski wrote: > On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > > From: Min Li > > > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > > It will create a debugfs directory called idtptp{x} and x is th

WARNING in disable_device

2020-07-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e44f65fd xen-netfront: remove redundant assignment to vari.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16ff23a310 kernel config: https://syzkaller.appspot.com/x/.config?x=829871134ca5e230 das

[PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. - PCI_DMA_BIDIRECTIO

[PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-11 Thread Sergey Organov
Fix support for external PTP-aware devices such as DSA or PTP PHY: Make sure we never time stamp tx packets when hardware time stamping is disabled. Check for PTP PHY being in use and then pass ioctls related to time stamping of Ethernet packets to the PTP PHY rather than handle them ourselves. I

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

2020-07-11 Thread Kurt Kanzenbach
Hi, On Fri Jul 10 2020, Rob Herring wrote: > On Fri, Jul 10, 2020 at 11:20 AM Florian Fainelli > wrote: >> >> >> >> On 7/10/2020 9:45 AM, Rob Herring wrote: >> > On Fri, Jul 10, 2020 at 11:06:18AM +0200, Kurt Kanzenbach wrote: >> >> For future DSA drivers it makes sense to add a generic DSA yaml

Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

2020-07-11 Thread Kurt Kanzenbach
On Fri Jul 10 2020, Rob Herring wrote: > On Fri, 10 Jul 2020 11:06:18 +0200, Kurt Kanzenbach wrote: >> For future DSA drivers it makes sense to add a generic DSA yaml binding which >> can be used then. This was created using the properties from dsa.txt. It >> includes the ports and the dsa,member p

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

2020-07-11 Thread Joe Perches
On Sat, 2020-07-11 at 10:23 +0200, Jesper Dangaard Brouer wrote: > On Fri, 10 Jul 2020 12:37:47 -0700 > Joe Perches wrote: > > > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > > > Rationale: > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > > which has no

Re: [PATCH] net/9p: validate fds in p9_fd_open

2020-07-11 Thread Dominique Martinet
Doug Nazar wrote on Fri, Jul 10, 2020: > On 2020-07-10 04:57, Christoph Hellwig wrote: > > >diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c > >index 13cd683a658ab6..1cd8ea0e493617 100644 > >--- a/net/9p/trans_fd.c > >+++ b/net/9p/trans_fd.c > >@@ -803,20 +803,28 @@ static int p9_fd_open(struct

[PATCH] xsk: ixgbe: solve the soft interrupt 100% CPU usage when xdp rx traffic congestion

2020-07-11 Thread Yahui Chen
If the user mode APP of drv-mode xsk does not process packets fast enough, the packet receiving speed is lower than the flow rate. For example, the flow rate is 1Mpps, and the APP processing speed is 10Kpss only, this will cause a series of problems: 1. If the APP doesn't use wakeup mechanism, in

[vhost:config-endian 33/36] drivers/vdpa/vdpa_sim/vdpa_sim.c:335:21: sparse: sparse: incorrect type in assignment (different base types)

2020-07-11 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git config-endian head: 6aef2378a564fea8e69c0419d94dc3ad9b4b7a99 commit: 0cf222ef876b95893406eebe685e595d88de0950 [33/36] virtio_net: correct tags for config space fields config: parisc-randconfig-s032-20200710 (attached as .conf

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

2020-07-11 Thread Jesper Dangaard Brouer
On Fri, 10 Jul 2020 12:37:47 -0700 Joe Perches wrote: > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > > Rationale: > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > which has nothing to do with XDP. > > > > Signed-off-by: Alexander A. Klimov > > --- > >

Re: [PATCH net-next v6 0/4] net: enetc: remove bootloader dependency

2020-07-11 Thread Vladimir Oltean
On Thu, Jul 09, 2020 at 11:35:22PM +0200, Michael Walle wrote: > This is a resend [now a new v6] of the series because the conversion to the > phylink interface will likely take longer: > https://lore.kernel.org/netdev/CA+h21hpBodyY8CtNH2ktRdc2FqPi=Fjp94=vvzvzsvbnvnf...@mail.gmail.com/ > Also the d

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

2020-07-11 Thread Magnus Karlsson
On Sat, Jul 11, 2020 at 1:28 AM Daniel Borkmann wrote: > > Hi Magnus, > > On 7/10/20 8:45 AM, Magnus Karlsson wrote: > > In the skb Tx path, transmission of a packet is performed with > > dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit > > routines, it returns NETDEV_TX_BUSY sign