On Sun, Jul 12, 2020 at 01:29:44AM +0200, Marek Behun wrote:
> On Sat, 11 Jul 2020 22:32:05 +0200
> Andrew Lunn <and...@lunn.ch> wrote:
>
> > The Marvell Switches support jumbo packages. So implement the
> > callbacks needed for changing the MTU.
> >
> > Signed-off-by: Andrew Lunn <and...@lunn.ch>
>
> Hi Andrew,
>
> maybe this could be sent to net, not only net-next. Or maybe even
> better, with a Fixes tag to some commit - DSA now prints warnings on
> some systems when initializing switch interfaces, that MTU cannot be
> changed, so maybe we could look at this patch as a fix and get it
> backported...
Hi Marek
It does not really 'fix' anything. The warning clearly says it is nonfatal
[ 2.091447] mv88e6085 0.1:00: nonfatal error -95 setting MTU on port 1
[ 2.123378] mv88e6085 0.1:00: nonfatal error -95 setting MTU on port 2
[ 2.144035] mv88e6085 0.1:00: nonfatal error -95 setting MTU on port 3
[ 2.165546] mv88e6085 0.1:00: nonfatal error -95 setting MTU on port 4
[ 2.189840] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 1
[ 2.213373] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 2
[ 2.232762] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 3
[ 2.253840] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 4
[ 2.275925] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 9
and the switch works as before. As such, i don't think this patch
meets the requirements of stable:
Documentation/process/stable-kernel-rules.rst
Andrew
