[PATCH net 3/3] rxrpc: Fix ack discard [ver #2]

The Rx protocol has a "previousPacket" field in it that is not handled in the same way by all protocol implementations. Sometimes it contains the serial number of the last DATA packet received, sometimes the sequence number of the last DATA packet received and sometimes the highest sequence number

[PATCH net 1/3] rxrpc: Fix the excessive initial retransmission timeout [ver #2]

rxrpc currently uses a fixed 4s retransmission timeout until the RTT is sufficiently sampled. This can cause problems with some fileservers with calls to the cache manager in the afs filesystem being dropped from the fileserver because a packet goes missing and the retransmission timeout is greate

[PATCH net 2/3] rxrpc: Trace discarded ACKs [ver #2]

Add a tracepoint to track received ACKs that are discarded due to being outside of the Tx window. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 35 +++ net/rxrpc/input.c| 12 ++-- 2 files changed, 45 insertions(+), 2 dele

[PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard [ver #2]

t rxrpc-fixes-20200520 and can also be found on the following branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (1): rxrpc: Fix ack discard fs/afs/fs_probe.c| 18 ++-- fs/afs/vl_probe.c

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

On Tue, May 19, 2020 at 4:53 PM Steffen Klassert wrote: > > On Fri, May 15, 2020 at 04:39:57PM +0800, Yuehaibing wrote: > > > > Friendly ping... > > > > Any plan for this issue? > > There was still no consensus between you and Xin on how > to fix this issue. Once this happens, I consider applying

Re: Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_op_suspend

There is a check against ret after out_sleep tag. If wl1271_configure_suspend_ap() returns an error code, ret will be caught by this check and a warning will be issued. "Tony Lindgren" 写道： > * Dinghao Liu [200520 12:58]: > > When wlcore_hw_interrupt_notify() returns an error

Re: [PATCH bpf-next v4 01/15] xsk: fix xsk_umem_xdp_frame_sz()

On Wed, 20 May 2020 16:34:05 +0200 Björn Töpel wrote: > On 2020-05-20 15:18, Jesper Dangaard Brouer wrote: > > On Wed, 20 May 2020 11:47:28 +0200 > > Björn Töpel wrote: > > > >> From: Björn Töpel > >> > >> Calculating the "data_hard_end" for an XDP buffer coming from AF_XDP > >> zero-copy mo

Re: getting bpf_tail_call to work with bpf function calls. Was: [RFC PATCH bpf-next 0/1] bpf, x64: optimize JIT prologue/epilogue generation

On Mon, May 18, 2020 at 08:44:58PM +0200, Maciej Fijalkowski wrote: > On Sat, May 16, 2020 at 09:32:27PM -0700, Alexei Starovoitov wrote: > > On Wed, May 13, 2020 at 01:58:55PM +0200, Maciej Fijalkowski wrote: > > > > > > So to me, if we would like to get rid of maxing out stack space, then we > >

Re: [PATCH] net: nlmsg_cancel() if put fails for nhmsg

From: Stephen Worley Date: Tue, 19 May 2020 21:57:12 -0400 > Fixes data remnant seen when we fail to reserve space for a > nexthop group during a larger dump. > > If we fail the reservation, we goto nla_put_failure and > cancel the message. > > Reproduce with the following iproute2 commands: .

Re: [PATCH net] ax24: fix setsockopt(SO_BINDTODEVICE)

From: Eric Dumazet Date: Tue, 19 May 2020 18:24:43 -0700 > syzbot was able to trigger this trace [1], probably by using > a zero optlen. > > While we are at it, cap optlen to IFNAMSIZ - 1 instead of IFNAMSIZ. > > [1] ... > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Eric Dumazet

Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

From: "Kirsher, Jeffrey T" Date: Thu, 21 May 2020 03:39:26 + > Thanks, have you been able to push you tree to kernel.org yet? Sorry, it's there now.

Re: [PATCH net 0/4] wireguard fixes for 5.7-rc7

From: "Jason A. Donenfeld" Date: Tue, 19 May 2020 22:49:26 -0600 > Hopefully these are the last fixes for 5.7: > > 1) A trivial bump in the selftest harness to support gcc-10. >build.wireguard.com is still on gcc-9 but I'll probably switch to >gcc-10 in the coming weeks. > > 2) A concur

RE: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

> -Original Message- > From: David Miller > Sent: Wednesday, May 20, 2020 19:28 > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com > Subject: Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver > Updates 2020-05-19 > > From: Jeff Kir

Re: [PATCH bpf] bpf: prevent mmap()'ing read-only maps as writable

On Thu, May 21, 2020 at 04:50:32AM +0200, Jann Horn wrote: > On Tue, May 19, 2020 at 7:38 AM Andrii Nakryiko wrote: > > As discussed in [0], it's dangerous to allow mapping BPF map, that's meant > > to > > be frozen and is read-only on BPF program side, because that allows > > user-space > > to

RE: [EXT] Re: [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format

From: Andrew Lunn Sent: Thursday, May 21, 2020 1:03 AM > On Wed, May 20, 2020 at 04:31:55PM +0800, fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > Update the gpr property to define gpr register offset and bit in DT. > > > > Signed-off-by: Fugang Duan > > --- > > arch/arm/boot/dts/imx6q

RE: [EXT] Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

From: Jakub Kicinski Sent: Thursday, May 21, 2020 12:54 AM > On Wed, 20 May 2020 16:31:53 +0800 fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > The commit da722186f654(net: fec: set GPR bit on suspend by DT > > configuration) set the GPR reigster offset and bit in driver for wake > > on

Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

From: Jeff Kirsher Date: Tue, 19 May 2020 17:04:05 -0700 > This series contains updates to igc only. > > Sasha cleans up the igc driver code that is not used or needed. > > Vitaly cleans up driver code that was used to support Virtualization on > a device that is not supported by igc, so remove

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

On 2020/5/21 9:36, Jakub Kicinski wrote: On Thu, 21 May 2020 09:33:14 +0800 tanhuazhong wrote: On 2020/5/21 5:06, Jakub Kicinski wrote: On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: From: GuoJia Liao There is a scenario which needs vNICs enable the VLAN filter in access port, whi

Re: [RFC][PATCHES] uaccess-related stuff in net/*

From: Al Viro Date: Thu, 21 May 2020 01:36:57 +0100 > On Mon, May 11, 2020 at 05:02:51PM -0700, David Miller wrote: >> From: Al Viro >> Date: Mon, 11 May 2020 05:43:28 +0100 >> >> >Assorted uaccess-related work in net/*. First, there's >> > getting rid of compat_alloc_user_space() mess in

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20200519] [cannot apply to net/master linus/master ipvs/master v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help imp

[RFC PATCH] net: atlantic: ptp_ring_idx() can be static

Signed-off-by: kbuild test robot --- aq_ptp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c index 9aee49c50f1f8..599ced261b2a4 100644 --- a/drivers/net/ethernet/aquantia/a

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

On Thu, 21 May 2020 09:33:14 +0800 tanhuazhong wrote: > On 2020/5/21 5:06, Jakub Kicinski wrote: > > On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: > >> From: GuoJia Liao > >> > >> There is a scenario which needs vNICs enable the VLAN filter > >> in access port, while disable the VLAN fi

Re: [PATCH net-next 1/2] flow_dissector: Parse multiple MPLS Label Stack Entries

Hi Guillaume, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on net/master sparc-next/master linus/master v5.7-rc6 next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help improve the syste

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

On 2020/5/21 5:06, Jakub Kicinski wrote: On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: From: GuoJia Liao There is a scenario which needs vNICs enable the VLAN filter in access port, while disable the VLAN filter in trunk port. Access port and trunk port can switch according to the

Re: [PATCH bpf] flow_dissector: Drop BPF flow dissector prog ref on netns cleanup

On Wed, May 20, 2020 at 10:40:00AM -0700, s...@google.com wrote: > On 05/20, Jakub Sitnicki wrote: > > When attaching a flow dissector program to a network namespace with > > bpf(BPF_PROG_ATTACH, ...) we grab a reference to bpf_prog. > > > If netns gets destroyed while a flow dissector is still at

[PATCH net-next 06/19] ipv4: do compat setsockopt for MCAST_MSFILTER directly

From: Al Viro Parallel to what the native setsockopt() does, except that unlike the native setsockopt() we do not use memdup_user() - we want the sockaddr_storage fields properly aligned, so we allocate 4 bytes more and copy compat_group_filter at the offset 4, which yields the proper alignments.

[PATCH net-next 02/19] compat_ip{,v6}_setsockopt(): enumerate MCAST_... options explicitly

From: Al Viro We want to check if optname is among the MCAST_... ones; do that as an explicit switch. Signed-off-by: Al Viro --- net/ipv4/ip_sockglue.c | 10 +- net/ipv6/ipv6_sockglue.c | 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_sockg

[PATCH net-next 07/19] ip6_mc_msfilter(): pass the address list separately

From: Al Viro that way we'll be able to reuse it for compat case Signed-off-by: Al Viro --- include/net/ipv6.h | 3 ++- net/ipv6/ipv6_sockglue.c | 2 +- net/ipv6/mcast.c | 7 --- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/ipv6.h b/include/net/i

[PATCH net-next 03/19] ip*_mc_gsfget(): lift copyout of struct group_filter into callers

From: Al Viro pass the userland pointer to the array in its tail, so that part gets copied out by our functions; copyout of everything else is done in the callers. Rationale: reuse for compat; the array is the same in native and compat, the layout of parts before it is different for compat. Sig

[PATCH net-next 01/19] lift compat definitions of mcast [sg]etsockopt requests into net/compat.h

From: Al Viro We want to get rid of compat_mc_[sg]etsockopt() and to have that stuff handled without compat_alloc_user_space(), extra copying through userland, etc. To do that we'll need ipv4 and ipv6 instances of ->compat_[sg]etsockopt() to manipulate the 32bit variants of mcast requests, so we

[PATCH net-next 08/19] ipv6: do compat setsockopt for MCAST_MSFILTER directly

From: Al Viro similar to the ipv4 counterpart of that patch - the same trick used to align the tail array properly. Signed-off-by: Al Viro --- net/ipv6/ipv6_sockglue.c | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/net/ipv6/

[PATCH net-next 04/19] get rid of compat_mc_getsockopt()

From: Al Viro now we can do MCAST_MSFILTER in compat ->getsockopt() without playing silly buggers with copying things back and forth. We can form a native struct group_filter (sans the variable-length tail) on stack, pass that + pointer to the tail of original request to the helper doing the bulk

[PATCH net-next 16/19] atm: move copyin from atm_getnames() into the caller

From: Al Viro Signed-off-by: Al Viro --- net/atm/ioctl.c | 19 ++- net/atm/resources.c | 19 +-- net/atm/resources.h | 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/net/atm/ioctl.c b/net/atm/ioctl.c index 0b4b07740fe4..e239cebf48da 1

[PATCH net-next 10/19] ipv4: take handling of group_source_req options into a helper

From: Al Viro Signed-off-by: Al Viro --- net/ipv4/ip_sockglue.c | 83 ++ 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index 34c3a43a9c98..7f065a68664e 100644 --- a/net/ipv4/ip_sock

[PATCH net-next 05/19] set_mcast_msfilter(): take the guts of setsockopt(MCAST_MSFILTER) into a helper

From: Al Viro Signed-off-by: Al Viro --- net/ipv4/ip_sockglue.c | 73 +++--- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index 65a30e7672ff..cc0441157b02 100644 --- a/net/ipv4/ip_sock

[PATCH net-next 18/19] atm: lift copyin from atm_dev_ioctl()

From: Al Viro Signed-off-by: Al Viro --- net/atm/ioctl.c | 25 - net/atm/resources.c | 35 +-- net/atm/resources.h | 4 ++-- 3 files changed, 31 insertions(+), 33 deletions(-) diff --git a/net/atm/ioctl.c b/net/atm/ioctl.c index fdd0

[PATCH net-next 14/19] batadv_socket_read(): get rid of pointless access_ok()

From: Al Viro address is passed only to copy_to_user() Signed-off-by: Al Viro --- net/batman-adv/icmp_socket.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c index ccb535c77e5d..8bdabc03b0b2 100644 --- a/net/batman-adv/icmp_soc

[PATCH net-next 19/19] atm: switch do_atmif_sioc() to direct use of atm_dev_ioctl()

From: Al Viro Signed-off-by: Al Viro --- net/atm/ioctl.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/net/atm/ioctl.c b/net/atm/ioctl.c index 52f2c77e656f..838ebf0cabbf 100644 --- a/net/atm/ioctl.c +++ b/net/atm/ioctl.c @@ -286,30 +286,13 @@ sta

[PATCH net-next 11/19] ipv6: take handling of group_source_req options into a helper

From: Al Viro Signed-off-by: Al Viro --- net/ipv6/ipv6_sockglue.c | 65 +++- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 209d827950cc..bb049feeb787 100644 --- a/net/ipv6/ipv

[PATCH net-next 17/19] atm: switch do_atm_iobuf() to direct use of atm_getnames()

From: Al Viro ... and sod the compat_alloc_user_space() with its complications Signed-off-by: Al Viro --- net/atm/ioctl.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/net/atm/ioctl.c b/net/atm/ioctl.c index e239cebf48da..fdd0e3434523 100644 ---

[PATCH net-next 12/19] handle the group_source_req options directly

From: Al Viro Native ->setsockopt() handling of these options (MCAST_..._SOURCE_GROUP and MCAST_{,UN}BLOCK_SOURCE) consists of copyin + call of a helper that does the actual work. The only change needed for ->compat_setsockopt() is a slightly different copyin - the helpers can be reused as-is.

[PATCH net-next 15/19] atm: separate ATM_GETNAMES handling from the rest of atm_dev_ioctl()

From: Al Viro atm_dev_ioctl() does copyin in two different ways - one for ATM_GETNAMES, another for everything else. Start with separating the former into a new helper (atm_getnames()). The next step will be to lift the copyin into the callers. Signed-off-by: Al Viro --- net/atm/ioctl.c

[PATCH net-next 13/19] get rid of compat_mc_setsockopt()

From: Al Viro not used anymore Signed-off-by: Al Viro --- include/net/compat.h | 4 --- net/compat.c | 90 2 files changed, 94 deletions(-) diff --git a/include/net/compat.h b/include/net/compat.h index d714076d63d5..f241666117d8 1

[PATCH net-next 09/19] ipv[46]: do compat setsockopt for MCAST_{JOIN,LEAVE}_GROUP directly

From: Al Viro direct parallel to the way these two are handled in the native ->setsockopt() instances - the helpers that do the real work are already separated and can be reused as-is in this case. Signed-off-by: Al Viro --- net/ipv4/ip_sockglue.c | 31 +++ net/ip

Re: [RFC][PATCHES] uaccess-related stuff in net/*

On Mon, May 11, 2020 at 05:02:51PM -0700, David Miller wrote: > From: Al Viro > Date: Mon, 11 May 2020 05:43:28 +0100 > > > Assorted uaccess-related work in net/*. First, there's > > getting rid of compat_alloc_user_space() mess in MCAST_... > > [gs]etsockopt() - no need to play with copying

Re: [PATCH net-next] sctp: Pull the user copies out of the individual sockopt functions.

On Wed, May 20, 2020 at 03:08:13PM +, David Laight wrote: ... > Only SCTP_SOCKOPT_CONNECTX3 contains an indirect pointer. > It is also the only getsockopt() that wants to return a buffer > and an error code. It is also definitely abusing getsockopt(). ... > @@ -1375,11 +1350,11 @@ struct compat

Re: devlink interface for asynchronous event/messages from firmware?

On Wed, 20 May 2020 17:03:02 -0700 Jacob Keller wrote: > Hi Jiri, Jakub, > > I've been asked to investigate using devlink as a mechanism for > reporting asynchronous events/messages from firmware including > diagnostic messages, etc. > > Essentially, the ice firmware can report various status or

Re: [PATCH net 1/3] rxrpc: Fix the excessive initial retransmission timeout

On Thu, 21 May 2020 00:21:49 +0100 David Howells wrote: > Fixes: 17926a79320a ([AF_RXRPC]: Provide secure RxRPC sockets for use by > userspace and kernel both"") > Signed-off-by: David Howells FWIW Fixes tag: Fixes: 17926a79320a ([AF_RXRPC]: Provide secure RxRPC sockets for use by userspace an

devlink interface for asynchronous event/messages from firmware?

Hi Jiri, Jakub, I've been asked to investigate using devlink as a mechanism for reporting asynchronous events/messages from firmware including diagnostic messages, etc. Essentially, the ice firmware can report various status or diagnostic messages which are useful for debugging internal behavior.

[PATCHv2 iproute2-next] lwtunnel: add support for rpl segment routing

This patch adds support for rpl segment routing settings. Example: ip -n ns0 -6 route add 2001::3 encap rpl segs \ fe80::c8fe:beef:cafe:cafe,fe80::c8fe:beef:cafe:beef dev lowpan0 Signed-off-by: Alexander Aring --- changes since v2: - change output to display segments count and nice segment brac

Re: [PATCH net-next] sctp: Pull the user copies out of the individual sockopt functions.

Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on net/master linus/master v5.7-rc6 next-20200519] [cannot apply to ipvs/master] [if your patch is applied to the wrong git tree, please drop us a note to help im

Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay

On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be

Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay

From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 20:10:01 -0300 > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > API could be a bit more complete than that. The APIs are being designed based upon wh

[PATCH net 3/3] rxrpc: Fix ack discard

The Rx protocol has a "previousPacket" field in it that is not handled in the same way by all protocol implementations. Sometimes it contains the serial number of the last DATA packet received, sometimes the sequence number of the last DATA packet received and sometimes the highest sequence number

[PATCH net 2/3] rxrpc: Trace discarded ACKs

Add a tracepoint to track received ACKs that are discarded due to being outside of the Tx window. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 35 +++ net/rxrpc/input.c| 12 ++-- 2 files changed, 45 insertions(+), 2 dele

[PATCH net 1/3] rxrpc: Fix the excessive initial retransmission timeout

rxrpc currently uses a fixed 4s retransmission timeout until the RTT is sufficiently sampled. This can cause problems with some fileservers with calls to the cache manager in the afs filesystem being dropped from the fileserver because a packet goes missing and the retransmission timeout is greate

[PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

e ACK field that should be used for this sometimes has the wrong information in it. (3) Add a tracepoint to log a discarded ACK. The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20200520 and can also be found o

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20200519] [cannot apply to net/master linus/master ipvs/master v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help imp

Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay

On Wed, May 20, 2020 at 09:55:07PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. > > Signed-off-by: Christoph Hellwig > --- > fs/dlm/lowcomms.c | 10 ++ > include/net/sctp/sctp.h |

Re: [PATCH 32/33] net: add a new bind_add method

On Wed, May 20, 2020 at 09:55:08PM +0200, Christoph Hellwig wrote: > The SCTP protocol allows to bind multiple address to a socket. That > feature is currently only exposed as a socket option. Add a bind_add > method struct proto that allows to bind additional addresses, and > switch the dlm code

Re: [Intel-wired-lan] [next-queue RFC 0/4] ethtool: Add support for frame preemption

Andre Guedes writes: >> If standard defines it as per-MAC and we can reasonably expect vendors >> won't try to "add value" and make it per queue (unlikely here AFAIU), >> then for this part ethtool configuration seems okay to me. > > Before we move forward with this hybrid approach, let's recap a

Re: [PATCH 3/7] perf metricgroup: Delay events string creation

On Wed, May 20, 2020 at 05:34:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > > break; > > > > } > > > > } > > > > + if (!re

Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events

On Wed, May 20, 2020 at 09:50:13AM -0700, Ian Rogers wrote: SNIP > > > + } > > > > is the groupping still enabled when we merge groups? could part > > of the metric (events) be now computed in different groups? > > By default the change will take two metrics and allow the shorter > m

Re: [PATCH net 1/1] sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and socket is closed

On Wed, 20 May 2020, Marcelo Ricardo Leitner wrote: > On Wed, May 20, 2020 at 06:15:31PM +0300, Jere Leppänen wrote: > > Commit bdf6fa52f01b ("sctp: handle association restarts when the > > socket is closed.") starts shutdown when an association is restarted, > > if in SHUTDOWN-PENDING state and t

mvneta and phy_speed_up()

Hi Daniel I have a WRT1900AC which uses a Marvel XP SoC. One of its mvneta interfaces is connected to an Ethernet switch. I now get: [ 21.934996] mvneta f107.ethernet eth0: configuring for fixed/rgmii-id link mode [ 21.942783] 8<--- cut here --- [ 21.945876] Unable to handle kernel NUL

Re: [Intel-wired-lan] [next-queue RFC 0/4] ethtool: Add support for frame preemption

Hi, Quoting Jakub Kicinski (2020-05-18 16:09:06) > On Mon, 18 May 2020 16:05:08 -0700 Vinicius Costa Gomes wrote: > > Jakub Kicinski writes: > > >> That was the (only?) strong argument in favor of having frame preemption > > >> in the TC side when this was last discussed. > > >> > > >> We can ha

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

On Wed, 20 May 2020 21:37:11 +0200 Thomas Gleixner wrote: > David Miller writes: > > From: Thomas Gleixner > > Date: Wed, 20 May 2020 01:42:30 +0200 > >>> Please try, it isn't that hard.. > >>> > >>> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done > >>> > >>> real

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

Joergen Andreasen writes: >> So I thought I was better to let the driver decide what values are >> acceptable. >> >> This is a good question for people working with other hardware. >> > > I think it's most intuitive to use the values for AddFragSize as described in > 802.3br (N = 0, 1, 2, 3). >

Re: [PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

On 20/05/2020 20:17, David Miller wrote: > From: Antonio Quartulli > Date: Wed, 20 May 2020 10:39:33 +0200 > >> I don't think it's BUILD_BUG_ON()'s fault, because qcb->data is passed >> to sizeof() first. >> >> My best guess is that gcc is somewhat optimizing the sizeof(gcb->data) >> and thus lea

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > I just noticed how the naming of NET_MEDIATEK_MAC and NET_MEDIATEK_SOC > > for two different drivers doing the same thing is really confusing. > > > > Maybe someone can come up wit

RE: [EXT] Re: [PATCH net-next,v2 2/2] qed: Add XRC to RoCE

> From: Yuval Basson > Date: Tue, 19 May 2020 23:51:26 +0300 > > > @@ -1748,24 +1839,26 @@ static int qed_rdma_modify_srq(void > *rdma_cxt, > > u16 opaque_fid, srq_id; > > struct qed_bmap *bmap; > > u32 returned_id; > > + u16 offset; > > int rc; > > > > - bmap = &p_hwfn->p_rdm

Re: [PATCH] rds: fix crash in rds_info_getsockopt()

From: John Hubbard Date: Wed, 20 May 2020 12:41:47 -0700 > The conversion to pin_user_pages() had a bug: it overlooked > the case of allocation of pages failing. Fix that by restoring > an equivalent check. > > Reported-by: syzbot+118ac0af4ac7f785a...@syzkaller.appspotmail.com > Fixes: dbfe7d743

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: > From: GuoJia Liao > > There is a scenario which needs vNICs enable the VLAN filter > in access port, while disable the VLAN filter in trunk port. > Access port and trunk port can switch according to the user's > configuration. > > This pat

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

On Wed, 20 May 2020 16:47:25 +0300 Igor Russkikh wrote: > From: Dmitry Bezrukov > > This patch contains the following changes: > * add cfg->is_ptp (used for PTP enable/disable switch, which > is described in more details below); > * add cfg->tc_mode (A1 supports 2 HW modes only); > * setup queu

Re: [PATCH] ath9k: release allocated buffer if timed out

On Wed, May 13, 2020 at 12:02 PM Brian Norris wrote: > > On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: > > Actually it's already reverted in -next, nobody just realised that it's > > a regression from commit 728c1e2a05e4: > > > > ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_ser

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

Andrew On 5/20/20 3:44 PM, Andrew Lunn wrote: I think adding it in the core would be a bit of a challenge.  I think each PHY driver needs to handle parsing and validating this property on its own (like fifo-depth).  It is a PHY specific setting. fifo-depth yes. But some delays follow a common p

Re: [net v3 0/2] net/tls: fix encryption error path

On Wed, 20 May 2020 11:41:42 +0300 Vadim Fedorenko wrote: > The problem with data stream corruption was found in KTLS > transmit path with small socket send buffers and large > amount of data. bpf_exec_tx_verdict() frees open record > on any type of error including EAGAIN, ENOMEM and ENOSPC > whil

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

> I think adding it in the core would be a bit of a challenge.  I think each > PHY driver needs to handle parsing and validating this property on its own > (like fifo-depth).  It is a PHY specific setting. fifo-depth yes. But some delays follow a common pattern. e.g. Documentation/devicetree/bind

Re: [PATCH net] net/tls: Fix driver request resync

On Wed, 20 May 2020 18:14:08 +0300 Tariq Toukan wrote: > From: Boris Pismenny > > In driver request resync, the hardware requests a resynchronization > request at some TCP sequence number. If that TCP sequence number does > not point to a TLS record header, then the resync attempt has failed. >

Re: [PATCH 3/7] perf metricgroup: Delay events string creation

Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > break; > > > } > > > } > > > + if (!ret) { > > > > could you please do instead: > > > > if (ret) > >

RE: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic classes

> Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic > classes > > On Wed, 20 May 2020 15:10:42 + Ioana Ciornei wrote: > > DPAA2 has frame queues per each Rx traffic class and the decision from > > which queue to pull frames from is made by the HW based on the queue > >

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

On Wed, 20 May 2020 15:56:56 -0400 Pooja Trivedi wrote: > On Tue, May 19, 2020 at 5:43 PM Jakub Kicinski wrote: > > > > On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > > > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

Andrew On 5/20/20 2:27 PM, Andrew Lunn wrote: Hi Dan UGH I think I just got volunteered to do make them common. There is code you can copy from PHY drivers. :-) What would be kind of nice is if the validate was in the core as well. Pass a list of possible delays in pS, and it will do a phyde

[PATCH 01/33] dlm: use the tcp version of accept_from_sock for sctp as well

The only difference between a few missing fixes applied to the SCTP one is that TCP uses ->getpeername to get the remote address, while SCTP uses kernel_getsockopt(.. SCTP_PRIMARY_ADDR). But given that getpeername is defined to return the primary address for sctp, there doesn't seem to be any reas

[PATCH 04/33] net: add sock_no_linger

Add a helper to directly set the SO_LINGER sockopt from kernel space with onoff set to true and a linger time of 0 without going through a fake uaccess. Signed-off-by: Christoph Hellwig Acked-by: Sagi Grimberg --- drivers/nvme/host/tcp.c | 9 + drivers/nvme/target/tcp.c | 6 +-

[PATCH 02/33] net: remove kernel_getsockopt

No users left. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 2 -- net/socket.c| 34 -- 2 files changed, 36 deletions(-) diff --git a/include/linux/net.h b/include/linux/net.h index 6451425e828f5..74ef5d7315f70 100644 --- a/include/linux/net

[PATCH 08/33] net: add sock_enable_timestamps

Add a helper to directly enable timestamps instead of setting the SO_TIMESTAMP* sockopts from kernel space and going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/sock.h | 1 + net/core/sock.c | 47 +--- net/rxrpc/loc

[PATCH 07/33] net: add sock_bindtoindex

Add a helper to directly set the SO_BINDTOIFINDEX sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/sock.h| 1 + net/core/sock.c | 21 +++-- net/ipv4/udp_tunnel.c | 4 +--- net/ipv6/ip6_udp_tun

[PATCH 12/33] tcp: add tcp_sock_set_cork

Add a helper to directly set the TCP_CORK sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 14 drivers/block

[PATCH 09/33] net: add sock_set_keepalive

Add a helper to directly set the SO_KEEPALIVE sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 6 +- include/net/sock.h| 1 + net/core/sock.c | 10 ++ net/rds/tcp_listen.c | 6 +- net/sunrpc

remove kernel_setsockopt and kernel_getsockopt v2

Hi Dave, this series removes the kernel_setsockopt and kernel_getsockopt functions, and instead switches their users to small functions that implement setting (or in one case getting) a sockopt directly using a normal kernel function call with type safety and all the other benefits of not having a

[PATCH 13/33] tcp: add tcp_sock_set_nodelay

Add a helper to directly set the TCP_NODELAY sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig Acked-by: Sagi Grimberg Acked-by: Jason Gunthorpe --- drivers/

[PATCH 14/33] tcp: add tcp_sock_set_quickack

Add a helper to directly set the TCP_QUICKACK sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 7 -- drivers/blo

[PATCH 22/33] ipv4: add ip_sock_set_recverr

Add a helper to directly set the IP_RECVERR sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig Reviewed-by: David Howells --- include/net/ip.h | 1 + net/ipv4/ip_sockglue.c | 8 net/rxrpc/local_object.c | 8 +--- 3 files chang

[PATCH 15/33] tcp: add tcp_sock_set_syncnt

Add a helper to directly set the TCP_SYNCNT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig Acked-by: Sagi Grimberg --- drivers/nvme/host/tcp.c | 9 + include/linux/tcp.h | 1 + net/ipv4/tcp.c | 12 3 files cha

[PATCH 19/33] tcp: add tcp_sock_set_keepcnt

Add a helper to directly set the TCP_KEEPCNT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/linux/tcp.h | 1 + net/ipv4/tcp.c| 12 net/rds/tcp.h | 2 +- net/rds/tcp_listen.c | 17 +++-- ne

Re: [PATCH net-next] net/tls: fix race condition causing kernel panic

On Wed, 20 May 2020 22:39:11 +0530 Vinay Kumar Yadav wrote: > On 5/20/2020 12:46 AM, David Miller wrote: > > From: Vinay Kumar Yadav > > Date: Tue, 19 May 2020 13:13:27 +0530 > > > >> + spin_lock_bh(&ctx->encrypt_compl_lock); > >> + pending = atomic_read(&ctx->encrypt_pending);

[PATCH 21/33] ipv4: add ip_sock_set_freebind

Add a helper to directly set the IP_FREEBIND sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/target/iscsi/iscsi_target_login.c | 13 +++-- include/net/ip.h | 1 + net/ipv4/ip_sockglue.c

[PATCH 20/33] ipv4: add ip_sock_set_tos

Add a helper to directly set the IP_TOS sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig Acked-by: Sagi Grimberg --- drivers/nvme/host/tcp.c | 14 +++--- drivers/nvme/target/tcp.c | 10 ++ include/net/ip.h | 2 ++ net/i

[PATCH 26/33] ipv6: add ip6_sock_set_recverr

Add a helper to directly set the IPV6_RECVERR sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig Reviewed-by: David Howells --- include/net/ipv6.h | 7 +++ net/rxrpc/local_object.c | 10 ++ 2 files changed, 9 insertions(+), 8 dele

  1   2   3   4   >