TSN - tc usage for a tbs setup

2019-07-24 Thread Stéphane Ancelot
Hi, I am trying to setup my network queue for offline time based configuration. initial setup is : tc qdisc show dev eth1: qdisc mq 0: root qdisc pfifo_fast 0: parent :1 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 I won't need pfifo , I have to send one frame at a precise xmit time

[PATCH net-next] can: kvaser_pciefd: Remove unused including

2019-07-24 Thread YueHaibing
Remove including that don't need it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/can/kvaser_pciefd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c index 3af747cbbde4..952a022b8343 100644 --- a/drivers/

[PATCH net-next] can: ti_hecc: remove set but not used variable 'mbx_mask'

2019-07-24 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/can/ti_hecc.c: In function 'ti_hecc_mailbox_read': drivers/net/can/ti_hecc.c:533:12: warning: variable 'mbx_mask' set but not used [-Wunused-but-set-variable] It is never used so can be removed. Reported-by: Hulk Robot Signed-off-by: Y

[PATCH net-next] can: sja1000: f81601: remove unused including

2019-07-24 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/net/can/sja1000/f81601.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/sja1000/f81601.c b/drivers/net/can/sja1000/f81601.c index 362a9d4f44d5..8f25e95814ef 100644 --- a/drivers/net/can/sja1000/f81601

Re: [PATCH bpf-next 5/7] sefltests/bpf: support FLOW_DISSECTOR_F_PARSE_1ST_FRAG

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 4:52 PM Stanislav Fomichev wrote: > > On 07/24, Song Liu wrote: > > On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > > > > > bpf_flow.c: exit early unless FLOW_DISSECTOR_F_PARSE_1ST_FRAG is passed > > > in flags. Also, set ip_proto earlier, this makes sure we

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-24 Thread Song Liu
> On Jul 24, 2019, at 5:37 PM, Andrii Nakryiko > wrote: > > On Wed, Jul 24, 2019 at 5:00 PM Song Liu wrote: >> >> >> >>> On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: >>> >>> Add support for BPF CO-RE offset relocations. Add section/record >>> iteration macros for .BTF.ext. These

Re: [PATCH net-next] netfilter: nf_table_offload: Fix zero prio of flow_cls_common_offload

2019-07-24 Thread Marcelo Ricardo Leitner
On Thu, Jul 25, 2019 at 11:03:52AM +0800, wenxu wrote: > > On 7/25/2019 7:51 AM, Marcelo Ricardo Leitner wrote: > > On Thu, Jul 11, 2019 at 04:03:30PM +0800, we...@ucloud.cn wrote: > >> From: wenxu > >> > >> The flow_cls_common_offload prio should be not zero > >> > >> It leads the invalid table

Re: [PATCH net-next] netfilter: nf_table_offload: Fix zero prio of flow_cls_common_offload

2019-07-24 Thread wenxu
On 7/25/2019 7:51 AM, Marcelo Ricardo Leitner wrote: > On Thu, Jul 11, 2019 at 04:03:30PM +0800, we...@ucloud.cn wrote: >> From: wenxu >> >> The flow_cls_common_offload prio should be not zero >> >> It leads the invalid table prio in hw. >> >> # nft add table netdev firewall >> # nft add chain n

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-24 Thread Leon Romanovsky
On Wed, Jul 24, 2019 at 08:56:08PM +, Saeed Mahameed wrote: > On Tue, 2019-07-23 at 22:04 +0300, Leon Romanovsky wrote: > > On Tue, Jul 23, 2019 at 11:28:50AM -0700, David Miller wrote: > > > From: Leon Romanovsky > > > Date: Tue, 23 Jul 2019 10:12:55 +0300 > > > > > > > From: Edward Srouji >

Re: [PATCH bpf-next v3 03/11] xsk: add support to allow unaligned chunk placement

2019-07-24 Thread Jakub Kicinski
On Wed, 24 Jul 2019 05:10:35 +, Kevin Laatz wrote: > Currently, addresses are chunk size aligned. This means, we are very > restricted in terms of where we can place chunk within the umem. For > example, if we have a chunk size of 2k, then our chunks can only be placed > at 0,2k,4k,6k,8k... and

RE: [PATCH net-next 2/2] qed: Add API for flashing the nvm attributes.

2019-07-24 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Saeed Mahameed > Sent: Thursday, July 25, 2019 1:13 AM > To: Sudarsana Reddy Kalluru ; > da...@davemloft.net > Cc: Ariel Elior ; Michal Kalderon > ; netdev@vger.kernel.org > Subject: [EXT] Re: [PATCH net-next 2/2] qed: Add API for flashing the nvm > attributes.

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-24 Thread Andrii Nakryiko
On Wed, Jul 24, 2019 at 5:00 PM Song Liu wrote: > > > > > On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > > > > Add support for BPF CO-RE offset relocations. Add section/record > > iteration macros for .BTF.ext. These macro are useful for iterating over > > each .BTF.ext record, either for

Re: [PATCH net] selftests/net: add missing gitignores (ipv6_flowlabel)

2019-07-24 Thread Willem de Bruijn
On Wed, Jul 24, 2019 at 8:07 PM Jakub Kicinski wrote: > > ipv6_flowlabel and ipv6_flowlabel_mgr are missing from > gitignore. Quentin points out that the original > commit 3fb321fde22d ("selftests/net: ipv6 flowlabel") > did add ignore entries, they are just missing the "ipv6_" > prefix. > > Sign

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Add in the basic ethtool callbacks for device information > and control. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/Makefile | 2 +- > .../net/ethernet/pensando/ionic/ionic_dev.h | 3 + > .../eth

[PATCH net] selftests/net: add missing gitignores (ipv6_flowlabel)

2019-07-24 Thread Jakub Kicinski
ipv6_flowlabel and ipv6_flowlabel_mgr are missing from gitignore. Quentin points out that the original commit 3fb321fde22d ("selftests/net: ipv6 flowlabel") did add ignore entries, they are just missing the "ipv6_" prefix. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/tes

Re: [PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Add code to handle the link status event, and wire up the > basic netdev hardware stats. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pensando/ionic/ionic_lif.c | 116 > ++ > .../net/ethernet/pensando/ioni

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-24 Thread Song Liu
> On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > > Add support for BPF CO-RE offset relocations. Add section/record > iteration macros for .BTF.ext. These macro are useful for iterating over > each .BTF.ext record, either for dumping out contents or later for BPF > CO-RE relocation han

Re: [PATCH bpf-next 5/7] sefltests/bpf: support FLOW_DISSECTOR_F_PARSE_1ST_FRAG

2019-07-24 Thread Stanislav Fomichev
On 07/24, Song Liu wrote: > On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > > > bpf_flow.c: exit early unless FLOW_DISSECTOR_F_PARSE_1ST_FRAG is passed > > in flags. Also, set ip_proto earlier, this makes sure we have correct > > value with fragmented packets. > > > > Add selftest c

Re: [PATCH v4 net-next 10/19] ionic: Add management of rx filters

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Set up the infrastructure for managing Rx filters. We can't ask the > hardware for what filters it has, so we keep a local list of filters > that we've pushed into the HW. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/p

Re: [PATCH net-next] netfilter: nf_table_offload: Fix zero prio of flow_cls_common_offload

2019-07-24 Thread Marcelo Ricardo Leitner
On Thu, Jul 11, 2019 at 04:03:30PM +0800, we...@ucloud.cn wrote: > From: wenxu > > The flow_cls_common_offload prio should be not zero > > It leads the invalid table prio in hw. > > # nft add table netdev firewall > # nft add chain netdev firewall acl { type filter hook ingress device > mlx_pf

Re: [PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Set up the initial NDO structure and callbacks for netdev > to use, and register the netdev. This will allow us to do > a few basic operations on the device, but no traffic yet. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethe

Re: [PATCH bpf-next 7/7] selftests/bpf: support FLOW_DISSECTOR_F_STOP_AT_ENCAP

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > Exit as soon as we found that packet is encapped when > FLOW_DISSECTOR_F_STOP_AT_ENCAP is passed. > Add appropriate selftest cases. > > Cc: Willem de Bruijn > Cc: Petar Penkov > Signed-off-by: Stanislav Fomichev Acked-by: Song Liu

Re: [PATCH bpf-next 6/7] bpf/flow_dissector: support ipv6 flow_label and FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > Add support for exporting ipv6 flow label via bpf_flow_keys. > Export flow label from bpf_flow.c and also return early when > FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL is passed. > > Cc: Willem de Bruijn > Cc: Petar Penkov > Signed-off-by:

Re: [PATCH v4 net-next 08/19] ionic: Add notifyq support

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > The AdminQ is fine for sending messages and requests to the NIC, > but we also need to have events published from the NIC to the > driver. The NotifyQ handles this for us, using the same interrupt > as AdminQ. > > Signed-off-by: Shannon N

Re: [PATCH bpf-next 5/7] sefltests/bpf: support FLOW_DISSECTOR_F_PARSE_1ST_FRAG

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > bpf_flow.c: exit early unless FLOW_DISSECTOR_F_PARSE_1ST_FRAG is passed > in flags. Also, set ip_proto earlier, this makes sure we have correct > value with fragmented packets. > > Add selftest cases to test ipv4/ipv6 fragments and ski

Re: [PATCH bpf-next 4/7] tools/bpf: sync bpf_flow_keys flags

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > Export bpf_flow_keys flags to tools/libbpf/selftests. > > Cc: Willem de Bruijn > Cc: Petar Penkov > Signed-off-by: Stanislav Fomichev Acked-by: Song Liu > --- > tools/include/uapi/linux/bpf.h | 5 + > 1 file changed, 5 inser

Re: [Patch net] netrom: hold sock when setting skb->destructor

2019-07-24 Thread David Miller
From: Cong Wang Date: Mon, 22 Jul 2019 20:41:22 -0700 > sock_efree() releases the sock refcnt, if we don't hold this refcnt > when setting skb->destructor to it, the refcnt would not be balanced. > This leads to several bug reports from syzbot. > > I have checked other users of sock_efree(), all

Re: [RFC PATCH net-next 00/12] drop_monitor: Capture dropped packets and metadata

2019-07-24 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 22 Jul 2019 21:43:15 +0200 > I like this! I definitely think this is going in the right direction as well.

Re: [PATCH bpf-next 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 3:32 PM Stanislav Fomichev wrote: > > On 07/24, Song Liu wrote: > > On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > > > > > C flow dissector supports input flags that tell it to customize parsing > > > by either stopping early or trying to parse as deep as p

Re: [PATCH RFC net-next] net: use helper skb_ensure_writable in skb_checksum_help and skb_crc32c_csum_help

2019-07-24 Thread David Miller
From: Heiner Kallweit Date: Wed, 24 Jul 2019 23:47:49 +0200 > Instead of open-coding making the checksum writable we can use an > appropriate helper. skb_ensure_writable is a candidate, however we > might also use skb_header_unclone. Hints welcome. > > Signed-off-by: Heiner Kallweit FWIW these

Re: [PATCH v2 net-next] r8169: improve rtl_set_rx_mode

2019-07-24 Thread David Miller
From: Heiner Kallweit Date: Wed, 24 Jul 2019 23:34:45 +0200 > This patch improves and simplifies rtl_set_rx_mode a little. > No functional change intended. > > Signed-off-by: Heiner Kallweit > --- > v2: > - change variable declarations to reverse xmas tree Applied.

Re: [net-next v2 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2019-07-24

2019-07-24 Thread David Miller
From: Jeff Kirsher Date: Wed, 24 Jul 2019 14:26:08 -0700 > This series contains updates to igc and e1000e client drivers only. > > Sasha provides a couple of cleanups to remove code that is not needed > and reduce structure sizes. Updated the MAC reset flow to use the > device reset flow instea

Re: [PATCH bpf-next 3/7] bpf/flow_dissector: support flags in BPF_PROG_TEST_RUN

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > This will allow us to write tests for those flags. > > Cc: Willem de Bruijn > Cc: Petar Penkov > Signed-off-by: Stanislav Fomichev Acked-by: Song Liu > --- > net/bpf/test_run.c | 39 +++ > 1 f

Re: [PATCH bpf-next 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-24 Thread Stanislav Fomichev
On 07/24, Song Liu wrote: > On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > > > C flow dissector supports input flags that tell it to customize parsing > > by either stopping early or trying to parse as deep as possible. Pass > > those flags to the BPF flow dissector so it can make

Re: [PATCH net-next] net/tls: add myself as a co-maintainer

2019-07-24 Thread David Miller
From: Jakub Kicinski Date: Wed, 24 Jul 2019 11:02:48 -0700 > I've been spending quite a bit of time fixing and > preventing bit rot in the core TLS code. TLS seems > to only be growing in importance, I'd like to help > ensuring the quality of our implementation. > > Signed-off-by: Jakub Kicinski

Re: [PATCH bpf-next 2/7] bpf/flow_dissector: document flags

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > Describe what each input flag does and who uses it. > > Cc: Willem de Bruijn > Cc: Petar Penkov > Signed-off-by: Stanislav Fomichev Acked-by: Song Liu > --- > Documentation/bpf/prog_flow_dissector.rst | 18 ++ >

[PATCH iproute2] iplink: document the 'link change' subcommand

2019-07-24 Thread Matteo Croce
ip link can set parameters both via the 'set' and 'change' keyword. In fact, 'change' is an alias for 'set'. Document this in the help and manpage. Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") Signed-off-by: Matteo Croce --- ip/iplink.c | 4 ++-- man/man8/ip-link.

Re: [PATCH bpf-next 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-24 Thread Song Liu
On Wed, Jul 24, 2019 at 10:11 AM Stanislav Fomichev wrote: > > C flow dissector supports input flags that tell it to customize parsing > by either stopping early or trying to parse as deep as possible. Pass > those flags to the BPF flow dissector so it can make the same > decisions. In the next co

Re: [PATCH bpf-next 0/7] bpf/flow_dissector: support input flags

2019-07-24 Thread Willem de Bruijn
On Wed, Jul 24, 2019 at 1:11 PM Stanislav Fomichev wrote: > > C flow dissector supports input flags that tell it to customize parsing > by either stopping early or trying to parse as deep as possible. > BPF flow dissector always parses as deep as possible which is sub-optimal. > Pass input flags t

Re: [RFC PATCH net-next 0/3] net: batched receive in GRO path

2019-07-24 Thread Edward Cree
On 12/07/2019 17:48, Eric Dumazet wrote: >> but the rest is the stuff we're polling for for low latency. >> I'm putting a gro_normal_list() call after the trace_napi_poll() in >>  napi_busy_loop() and testing that, let's see how it goes... One thing that's causing me some uncertainty: busy_poll_sto

[PATCH v2 bpf] libbpf: silence GCC8 warning about string truncation

2019-07-24 Thread Andrii Nakryiko
Despite a proper NULL-termination after strncpy(..., ..., IFNAMSIZ - 1), GCC8 still complains about *expected* string truncation: xsk.c:330:2: error: 'strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(ifr.ifr_name, xsk->ifnam

[PATCH RFC net-next] net: use helper skb_ensure_writable in skb_checksum_help and skb_crc32c_csum_help

2019-07-24 Thread Heiner Kallweit
Instead of open-coding making the checksum writable we can use an appropriate helper. skb_ensure_writable is a candidate, however we might also use skb_header_unclone. Hints welcome. Signed-off-by: Heiner Kallweit --- net/core/dev.c | 20 1 file changed, 8 insertions(+), 12

Re: [PATCH 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2019-07-24 Thread David Miller
From: Marek Vasut Date: Wed, 24 Jul 2019 15:40:48 +0200 > +static void ksz8795_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, > + u64 *cnt) > +{ > + u32 data; > + u16 ctrl_addr; > + u8 check; > + int loop; Reverse christmas tree for these local va

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-24 Thread Andrii Nakryiko
On Wed, Jul 24, 2019 at 12:28 PM Andrii Nakryiko wrote: > > Add support for BPF CO-RE offset relocations. Add section/record > iteration macros for .BTF.ext. These macro are useful for iterating over > each .BTF.ext record, either for dumping out contents or later for BPF > CO-RE relocation handli

Re: [PATCH v2] net: phylink: don't start and stop SGMII PHYs in SFP modules twice

2019-07-24 Thread David Miller
From: Arseny Solokha Date: Wed, 24 Jul 2019 20:31:39 +0700 > SFP modules connected using the SGMII interface have their own PHYs which > are handled by the struct phylink's phydev field. On the other hand, for > the modules connected using 1000Base-X interface that field is not set. > > Since co

Re: [PATCH net-next] r8169: improve rtl_set_rx_mode

2019-07-24 Thread Heiner Kallweit
On 24.07.2019 23:24, Saeed Mahameed wrote: > On Wed, 2019-07-24 at 23:04 +0200, Heiner Kallweit wrote: >> This patch improves and simplifies rtl_set_rx_mode a little. >> No functional change intended. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/net/ethernet/realtek/r8169_main.c | 52 ++

[PATCH v2 net-next] r8169: improve rtl_set_rx_mode

2019-07-24 Thread Heiner Kallweit
This patch improves and simplifies rtl_set_rx_mode a little. No functional change intended. Signed-off-by: Heiner Kallweit --- v2: - change variable declarations to reverse xmas tree --- drivers/net/ethernet/realtek/r8169_main.c | 52 ++- 1 file changed, 22 insertions(+), 30

[net-next v2 2/5] igc: Remove the unused field from a device specification structure

2019-07-24 Thread Jeff Kirsher
From: Sasha Neftin This patch comes to clean up the device specification structure. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_hw.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ig

[net-next v2 3/5] igc: Update the MAC reset flow

2019-07-24 Thread Jeff Kirsher
From: Sasha Neftin Use Device Reset flow instead of Port Reset flow. This flow performs a reset of the entire controller device, resulting in a state nearly approximating the state following a power-up reset or internal PCIe reset, except for system PCI configuration. Signed-off-by: Sasha Neftin

[net-next v2 5/5] e1000e: add workaround for possible stalled packet

2019-07-24 Thread Jeff Kirsher
From: Kai-Heng Feng This works around a possible stalled packet issue, which may occur due to clock recovery from the PCH being too slow, when the LAN is transitioning from K1 at 1G link speed. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204057 Signed-off-by: Kai-Heng Feng Tested-by:

[net-next v2 4/5] igc: Add more SKUs for i225 device

2019-07-24 Thread Jeff Kirsher
From: Sasha Neftin Add support for more SKUs. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_base.c | 3 +++ drivers/net/ethernet/intel/igc/igc_hw.h | 3 +++ drivers/net/ethernet/intel/igc/igc_main.c | 3 +++ 3 files ch

[net-next v2 1/5] igc: Remove the polarity field from a PHY information structure

2019-07-24 Thread Jeff Kirsher
From: Sasha Neftin Polarity and cable length fields is not applicable for the i225 device. This patch comes to clean up PHY information structure. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_hw.h | 6 -- 1 file cha

[net-next v2 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2019-07-24

2019-07-24 Thread Jeff Kirsher
This series contains updates to igc and e1000e client drivers only. Sasha provides a couple of cleanups to remove code that is not needed and reduce structure sizes. Updated the MAC reset flow to use the device reset flow instead of a port reset flow. Added addition device id's that will be supp

Re: [PATCH net-next] r8169: improve rtl_set_rx_mode

2019-07-24 Thread Saeed Mahameed
On Wed, 2019-07-24 at 23:04 +0200, Heiner Kallweit wrote: > This patch improves and simplifies rtl_set_rx_mode a little. > No functional change intended. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_main.c | 52 ++--- > -- > 1 file changed, 22 ins

Re: pull-request: can 2019-07-24

2019-07-24 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 24 Jul 2019 15:03:15 +0200 > this is a pull reqeust of 7 patches for net/master. Pulled, thank you.

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-24 Thread Saeed Mahameed
On Tue, 2019-07-23 at 17:07 -0700, Shannon Nelson wrote: > On 7/23/19 4:20 PM, Saeed Mahameed wrote: > > On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > > > @@ -607,6 +947,8 @@ static void ionic_lif_free(struct lif *lif) > > > ionic_qcqs_free(lif); > > > ionic_lif_res

[PATCH net-next] r8169: improve rtl_set_rx_mode

2019-07-24 Thread Heiner Kallweit
This patch improves and simplifies rtl_set_rx_mode a little. No functional change intended. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 52 ++- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/realtek/r816

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-24 Thread Saeed Mahameed
On Tue, 2019-07-23 at 22:04 +0300, Leon Romanovsky wrote: > On Tue, Jul 23, 2019 at 11:28:50AM -0700, David Miller wrote: > > From: Leon Romanovsky > > Date: Tue, 23 Jul 2019 10:12:55 +0300 > > > > > From: Edward Srouji > > > > > > Fix modify_cq_in alignment to match the device specification. >

Re: [net-next 6/6] e1000e: disable force K1-off feature

2019-07-24 Thread Jeff Kirsher
On Tue, 2019-07-23 at 14:04 -0700, David Miller wrote: > From: Jeff Kirsher > Date: Tue, 23 Jul 2019 10:36:50 -0700 > > > diff --git a/drivers/net/ethernet/intel/e1000e/hw.h > > b/drivers/net/ethernet/intel/e1000e/hw.h > > index eff75bd8a8f0..e3c71fd093ee 100644 > > --- a/drivers/net/ethernet/int

Re: [PATCH net-next 2/2] mlx4/en_netdev: call notifiers when hw_enc_features change

2019-07-24 Thread Saeed Mahameed
On Wed, 2019-07-24 at 16:02 +0200, Davide Caratti wrote: > ensure to call netdev_features_change() when the driver flips its > hw_enc_features bits. > > Signed-off-by: Davide Caratti The patch is correct, but can you explain how did you come to this ? did you encounter any issue with the curren

Re: [PATCH net-next 1/4] sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectx

2019-07-24 Thread Neil Horman
On Wed, Jul 24, 2019 at 04:12:43PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Jul 24, 2019 at 04:05:43PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, Jul 24, 2019 at 02:44:56PM -0400, Neil Horman wrote: > > > On Wed, Jul 24, 2019 at 09:49:07AM -0300, Marcelo Ricardo Leitner wrote: > > > >

Re: [PATCH bpf-next] libbpf: silence GCC8 warning about string truncation

2019-07-24 Thread Song Liu
On Tue, Jul 23, 2019 at 7:33 PM Andrii Nakryiko wrote: > > Despite a proper NULL-termination after strncpy(..., ..., IFNAMSIZ - 1), > GCC8 still complains about *expected* string truncation: > > xsk.c:330:2: error: 'strncpy' output may be truncated copying 15 bytes > from a string of length 15

Re: [PATCH net-next 1/4] sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectx

2019-07-24 Thread Neil Horman
On Wed, Jul 24, 2019 at 04:05:43PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Jul 24, 2019 at 02:44:56PM -0400, Neil Horman wrote: > > On Wed, Jul 24, 2019 at 09:49:07AM -0300, Marcelo Ricardo Leitner wrote: > > > On Wed, Jul 24, 2019 at 09:36:50AM -0300, Marcelo Ricardo Leitner wrote: > > > >

Re: [PATCH net-next 1/2] mlx4/en_netdev: update vlan features with tunnel offloads

2019-07-24 Thread Saeed Mahameed
On Wed, 2019-07-24 at 16:02 +0200, Davide Caratti wrote: > ConnectX-3 Pro can offload transmission of VLAN packets with VXLAN > inside: > enable tunnel offloads in dev->vlan_features, like it's done with > other > NIC drivers (e.g. be2net and ixgbe). > > Signed-off-by: Davide Caratti LGTM Revie

[PATCH net-next 1/3] net: ethernet: mediatek: Add basic PHYLINK support

2019-07-24 Thread René van Dorst
This convert the basics to PHYLINK API. SGMII support is not in this patch. Signed-off-by: René van Dorst Tested-by: Frank Wunderlich --- drivers/net/ethernet/mediatek/Kconfig | 2 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 404 +++- drivers/net/ethernet/mediatek/m

[PATCH net-next 0/3] net: dsa: MT7530: Convert to PHYLINK and add support for port 5

2019-07-24 Thread René van Dorst
1. net: dsa: mt7530: Convert to PHYLINK API This patch converts mt7530 to PHYLINK API. 2. dt-bindings: net: dsa: mt7530: Add support for port 5 3. net: dsa: mt7530: Add support for port 5 These 2 patches adding support for port 5 of the switch. rfc -> v1: * Mostly phylink improvements after

[PATCH net-next 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-07-24 Thread René van Dorst
Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst rfc->v1: * Renamed P5_MODE_* to P5_INTF_SEL_*. fits the function more * Convert if-statement for speed bits to a switch suggested by Daniel Santos * Refactor flow_control pause bits and don't use state->link in mt7530_phylink_mac_co

[PATCH bpf-next 00/10] CO-RE offset relocations

2019-07-24 Thread Andrii Nakryiko
This patch set implements central part of CO-RE (Compile Once - Run Everywhere, see [0] and [1] for slides and video): relocating field offsets. Most of the details are written down as comments to corresponding parts of the code. Patch #1 adds loading of .BTF.ext offset relocations section and mac

[PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-24 Thread Andrii Nakryiko
Add support for BPF CO-RE offset relocations. Add section/record iteration macros for .BTF.ext. These macro are useful for iterating over each .BTF.ext record, either for dumping out contents or later for BPF CO-RE relocation handling. To enable other parts of libbpf to work with .BTF.ext contents

[PATCH bpf-next 04/10] selftests/bpf: add CO-RE relocs struct flavors tests

2019-07-24 Thread Andrii Nakryiko
Add tests verifying that BPF program can use various struct/union "flavors" to extract data from the same target struct/union. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 34 ++ .../bpf/progs/btf__core_reloc_flavors.c | 3 + .../btf__core_rel

[PATCH bpf-next 03/10] selftests/bpf: add CO-RE relocs testing setup

2019-07-24 Thread Andrii Nakryiko
Add CO-RE relocation test runner. Add one simple test validating that libbpf's logic for searching for kernel image and loading BTF out of it works. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 126 ++ .../bpf/progs/test_core_reloc_kernel.c

[PATCH bpf-next 10/10] selftests/bpf: add CO-RE relocs ints tests

2019-07-24 Thread Andrii Nakryiko
Add various tests validating handling compatible/incompatible integer types. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 40 +++ .../bpf/progs/btf__core_reloc_ints.c | 3 + .../bpf/progs/btf__core_reloc_ints___bool.c | 3 + .../btf__core

[PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-24 Thread Andrii Nakryiko
This patch implements the core logic for BPF CO-RE offsets relocations. All the details are described in code comments. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 866 - tools/lib/bpf/libbpf.h | 1 + 2 files changed, 861 insertions(+), 6

[PATCH bpf-next 08/10] selftests/bpf: add CO-RE relocs modifiers/typedef tests

2019-07-24 Thread Andrii Nakryiko
Add tests validating correct handling of various combinations of typedefs and const/volatile/restrict modifiers. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 27 +++ .../bpf/progs/btf__core_reloc_mods.c | 3 + .../progs/btf__core_reloc_mods___m

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-24 Thread Shannon Nelson
On 7/23/19 5:25 PM, Shannon Nelson wrote: On 7/23/19 4:47 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: + +    /* Wait for dev cmd to complete, retrying if we get EAGAIN, + * but don't wait any longer than max_seconds. + */ +    max_wait = jiffies

Re: [PATCH net-next 0/4] sctp: clean up __sctp_connect function

2019-07-24 Thread David Miller
From: Neil Horman Date: Wed, 24 Jul 2019 14:47:29 -0400 > On Wed, Jul 24, 2019 at 11:25:12AM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, Jul 23, 2019 at 01:37:56AM +0800, Xin Long wrote: >> > This patchset is to factor out some common code for >> > sctp_sendmsg_new_asoc() and __sctp_connect(

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-24 Thread David Miller
From: Shannon Nelson Date: Wed, 24 Jul 2019 10:49:09 -0700 > On 7/23/19 4:05 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Tue, 23 Jul 2019 15:50:22 -0700 >> >>> On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 > +v

Re: Driver support for Realtek RTL8125 2.5GB Ethernet

2019-07-24 Thread Heiner Kallweit
On 24.07.2019 10:19, Jian-Hong Pan wrote: > Hi all, > > We have got a consumer desktop equipped with Realtek RTL8125 2.5GB > Ethernet [1] recently. But, there is no related driver in mainline > kernel yet. So, we can only use the vendor driver [2] and customize > it [3] right now. > > Is anyone

Re: [PATCH net-next 2/2] qed: Add API for flashing the nvm attributes.

2019-07-24 Thread Saeed Mahameed
On Tue, 2019-07-23 at 21:51 -0700, Sudarsana Reddy Kalluru wrote: > The patch adds driver interface for reading the NVM config request > and > update the attributes on nvm config flash partition. > You didn't not use the get_cfg API you added in previous patch. Also can you please clarify how th

[PATCH bpf-next 07/10] selftests/bpf: add CO-RE relocs enum/ptr/func_proto tests

2019-07-24 Thread Andrii Nakryiko
Test CO-RE relocation handling of ints, enums, pointers, func protos, etc. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 36 ++ .../bpf/progs/btf__core_reloc_primitives.c| 3 + ...f__core_reloc_primitives___diff_enum_def.c | 3 + ..._core_reloc_

[PATCH bpf-next 05/10] selftests/bpf: add CO-RE relocs nesting tests

2019-07-24 Thread Andrii Nakryiko
Add a bunch of test validating correct handling of nested structs/unions. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 39 +++ .../bpf/progs/btf__core_reloc_nesting.c | 3 + .../btf__core_reloc_nesting___anon_embed.c| 3 + ...f__core_reloc_nes

[PATCH bpf-next 06/10] selftests/bpf: add CO-RE relocs array tests

2019-07-24 Thread Andrii Nakryiko
Add tests for various array handling/relocation scenarios. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 41 ++ .../bpf/progs/btf__core_reloc_arrays.c| 3 + .../btf__core_reloc_arrays___diff_arr_dim.c | 3 + ...btf__core_reloc_arrays___dif

[PATCH bpf-next 09/10] selftest/bpf: add CO-RE relocs ptr-as-array tests

2019-07-24 Thread Andrii Nakryiko
Add test validating correct relocation handling for cases where pointer to something is used as an array. E.g.: int *ptr = ...; int x = ptr[42]; Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 20 +++ .../bpf/progs/btf__core_reloc_ptr_as_arr.c|

[PATCH net-next 2/3] dt-bindings: net: dsa: mt7530: Add support for port 5

2019-07-24 Thread René van Dorst
MT7530 port 5 has many modes/configurations. Update the documentation how to use port 5. Signed-off-by: René van Dorst rfc->v1: * No change --- .../devicetree/bindings/net/dsa/mt7530.txt| 215 ++ 1 file changed, 215 insertions(+) diff --git a/Documentation/devicetree/bindin

[PATCH net-next 3/3] net: dsa: mt7530: Add support for port 5

2019-07-24 Thread René van Dorst
Adding support for port 5. Port 5 can muxed/interface to: - internal 5th GMAC of the switch; can be used as 2nd CPU port or as extra port with an external phy for a 6th ethernet port. - internal PHY of port 0 or 4; Used in most applications so that port 0 or 4 is the WAN port and interfaces wi

[PATCH net-next 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-07-24 Thread René van Dorst
This patch the removes the recently added mediatek,physpeed property. Use the fixed-link property speed = <2500> to set the phy in 2.5Gbit. See mt7622-bananapi-bpi-r64.dts for a working example. Signed-off-by: René van Dorst Tested-by: Frank Wunderlich --- .../arm/mediatek/mediatek,sgmiisys.txt

[PATCH net-next 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-07-24 Thread René van Dorst
* Re-add SGMII support but now with PHYLINK API support So the SGMII changes are more clear * Move SGMII block setup from mtk_gmac_sgmii_path_setup() to mtk_mac_config() * Merge mtk_setup_hw_path() into mtk_mac_config() * Remove mediatek,physpeed property, fixed-link supports now any speed so

[PATCH net-next 0/3] net: ethernet: mediatek: convert to phylink.

2019-07-24 Thread René van Dorst
These patches converts mediatek driver to phylink api. SGMII support is only tested with fixed speed of 2.5Gbit on a Bananapi R64. Frank tested these patches on this Bananapi R64 (mt7622) and Bananapi R2 (mt7623). Tested on hardware: mt7621, mt7622 and mt7623. René van Dorst (3): net: ethernet:

Re: [PATCH net-next 1/4] sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectx

2019-07-24 Thread Marcelo Ricardo Leitner
On Wed, Jul 24, 2019 at 04:05:43PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Jul 24, 2019 at 02:44:56PM -0400, Neil Horman wrote: > > On Wed, Jul 24, 2019 at 09:49:07AM -0300, Marcelo Ricardo Leitner wrote: > > > On Wed, Jul 24, 2019 at 09:36:50AM -0300, Marcelo Ricardo Leitner wrote: > > > >

Re: [PATCH net-next 1/4] sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectx

2019-07-24 Thread Marcelo Ricardo Leitner
On Wed, Jul 24, 2019 at 02:44:56PM -0400, Neil Horman wrote: > On Wed, Jul 24, 2019 at 09:49:07AM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, Jul 24, 2019 at 09:36:50AM -0300, Marcelo Ricardo Leitner wrote: > > > On Wed, Jul 24, 2019 at 07:22:35AM -0400, Neil Horman wrote: > > > > On Wed, Jul

Re: [PATCH net-next v3 8/8] net: mscc: PTP Hardware Clock (PHC) support

2019-07-24 Thread David Miller
From: Antoine Tenart Date: Wed, 24 Jul 2019 10:17:15 +0200 > +static int ocelot_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > +{ > + struct ocelot *ocelot = container_of(ptp, struct ocelot, ptp_info); > + u32 unit = 0, direction = 0; > + unsigned long flags;

Re: [PATCH net-next 0/4] sctp: clean up __sctp_connect function

2019-07-24 Thread Neil Horman
On Wed, Jul 24, 2019 at 11:25:12AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jul 23, 2019 at 01:37:56AM +0800, Xin Long wrote: > > This patchset is to factor out some common code for > > sctp_sendmsg_new_asoc() and __sctp_connect() into 2 > > new functioins. > > > > Xin Long (4): > > sctp:

Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

2019-07-24 Thread David Miller
From: Matthew Wilcox Date: Wed, 24 Jul 2019 04:41:21 -0700 > On Wed, Jul 24, 2019 at 10:49:03AM +, David Laight wrote: >> This is 'just plain stupid'. >> The 'bv_' prefix of the members of 'struct bvec' is there so that 'grep' >> (etc) can be used to find the uses of the members. >> >> In a

Re: [PATCH] Build fixes for skb_frag_size conversion

2019-07-24 Thread David Miller
From: Matthew Wilcox Date: Wed, 24 Jul 2019 04:36:15 -0700 > From: "Matthew Wilcox (Oracle)" > > I missed a few places. One is in some ifdeffed code which will probably > never be re-enabled; the others are in drivers which can't currently be > compiled on x86. > > Signed-off-by: Matthew Wilc

Re: [PATCH net-next 1/4] sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectx

2019-07-24 Thread Neil Horman
On Wed, Jul 24, 2019 at 09:49:07AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Jul 24, 2019 at 09:36:50AM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, Jul 24, 2019 at 07:22:35AM -0400, Neil Horman wrote: > > > On Wed, Jul 24, 2019 at 03:21:12PM +0800, Xin Long wrote: > > > > On Tue, Jul 23

Re: pull-request: can-next 2019-07-24,pull-request: can-next 2019-07-24

2019-07-24 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 24 Jul 2019 11:00:24 +0200 > this is a pull request for net-next/master consisting of 26 patches. Pulled, thanks Marc.

[PATCH net-next] net/tls: add myself as a co-maintainer

2019-07-24 Thread Jakub Kicinski
I've been spending quite a bit of time fixing and preventing bit rot in the core TLS code. TLS seems to only be growing in importance, I'd like to help ensuring the quality of our implementation. Signed-off-by: Jakub Kicinski Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: John

Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

2019-07-24 Thread Saeed Mahameed
On Tue, 2019-07-23 at 18:30 -0700, Matthew Wilcox wrote: > On Tue, Jul 23, 2019 at 10:33:59PM +, Saeed Mahameed wrote: > > > struct skb_frag_struct { > > > struct page *bv_page; > > > - __u32 size; > > > + unsigned int bv_len; > > > __u32 page_offset; > > > > Why do you keep page_offset n

Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t

2019-07-24 Thread Saeed Mahameed
On Tue, 2019-07-23 at 18:28 -0700, Matthew Wilcox wrote: > On Tue, Jul 23, 2019 at 10:29:06PM +, Saeed Mahameed wrote: > > On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > > > Match the layout of bio_vec. > > > > > > Signed-off-by: Matthe

Re: [PATCH v2] net: dsa: qca8k: enable port flow control

2019-07-24 Thread Andrew Lunn
On Wed, Jul 24, 2019 at 01:02:56PM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. Hi Xiaofeis It seems like you are still using the wrong, and old tree. Please rebase on net-next/master. Thanks Andrew

  1   2   >