On Tue, 2019-07-23 at 18:28 -0700, Matthew Wilcox wrote: > On Tue, Jul 23, 2019 at 10:29:06PM +0000, Saeed Mahameed wrote: > > On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > > > From: "Matthew Wilcox (Oracle)" <wi...@infradead.org> > > > > > > Match the layout of bio_vec. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org> > > > --- > > > include/linux/skbuff.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > > index 7910935410e6..b9dc8b4f24b1 100644 > > > --- a/include/linux/skbuff.h > > > +++ b/include/linux/skbuff.h > > > @@ -314,8 +314,8 @@ struct skb_frag_struct { > > > struct { > > > struct page *p; > > > } page; > > > - __u32 page_offset; > > > __u32 size; > > > + __u32 page_offset; > > > }; > > > > > > > Why do you need this patch? this struct is going to be removed > > downstream eventually .. > > If there's a performance regression, this is the perfect patch to > include > as part of the bisection. You'd think that this change could have no > effect, but I've seen weirder things.
ok make sense !