Re: [PATCH 1/2] net: sh_eth: add support for SH7786

2017-12-04 Thread Thomas Petazzoni
Hello, On Mon, 4 Dec 2017 19:56:35 +0300, Sergei Shtylyov wrote: > On 12/04/2017 05:17 PM, Thomas Petazzoni wrote: > > > This commit adds the sh_eth_cpu_data structure that describes the > > SH7786 variant of the IP. > > The manual seems to be unavailable, so I have to trust you. :-) Yes,

[PATCH] net: netfilter: fix coding style

2017-12-04 Thread Lin Zhang
I think use variable 'min' instead of number '1024' is better. Signed-off-by: Lin Zhang --- net/netfilter/nf_nat_proto_common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/nf_nat_proto_common.c b/net/netfilter/nf_nat_proto_common.c index fbce552..e87e

Re:

2017-12-04 Thread ''CCB ENTERPRISE''
Hello Dear, we saw your product on google we are interested in some of your product, can you send me your product catalog or price list for our review? kindly reply so that we can make a trial order Thanks Sales Rep. Yvette Thompson Special Education Coordinator 5216 ythomp...@tesidea.com<

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-04 Thread Jason Wang
On 2017年12月05日 08:16, Willem de Bruijn wrote: On Mon, Dec 4, 2017 at 4:31 AM, Jason Wang wrote: This patch introduces an eBPF based queue selection method. With this, the policy could be offloaded to userspace completely through a new ioctl TUNSETSTEERINGEBPF. Signed-off-by: Jason Wang ---

Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

2017-12-04 Thread Yafang Shao
2017-12-05 3:28 GMT+08:00 Marcelo Ricardo Leitner : > On Sat, Dec 02, 2017 at 09:36:41AM +, Yafang Shao wrote: >> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other >> transitions are not traced with tcp_set_state tracepoint. >> >> In order to trace the whole tcp lifespans, tw

[PATCH v3 11/14] nubus: Rename struct nubus_dev

2017-12-04 Thread Finn Thain
It is misleading to call a functional resource a "device". In adopting the Linux Driver Model, the struct device will be embedded in struct nubus_board. That will compound the terminlogy problem because drivers will bind with boards, not with functional resources. Avoid this by renaming struct nubu

[PATCH v3 12/14] nubus: Adopt standard linked list implementation

2017-12-04 Thread Finn Thain
This increases code re-use and improves readability. Cc: Bartlomiej Zolnierkiewicz Signed-off-by: Finn Thain Tested-by: Stan Johnson --- drivers/net/ethernet/8390/mac8390.c | 7 +++-- drivers/net/ethernet/cirrus/mac89x0.c | 6 +++-- drivers/net/ethernet/natsemi/macsonic.c | 8 +++---

[PATCH v3 13/14] nubus: Add expansion_type values for various Mac models

2017-12-04 Thread Finn Thain
Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/include/asm/macintosh.h | 9 ++- arch/m68k/mac/config.c | 110 +

Re: Regression in e1000e since Kernel 4.14.3

2017-12-04 Thread Greg KH
On Tue, Dec 05, 2017 at 07:18:34AM +0100, Greg KH wrote: > On Tue, Dec 05, 2017 at 12:47:10AM +0100, Gabriel C wrote: > > On 04.12.2017 23:10, rwar...@gmx.de wrote: > > > > > Hallo > > > > > > someone and I got an regression with e1000e since kernel 4.14.3 and it > > > seems there is 4.14.4 on t

Re: Regression in e1000e since Kernel 4.14.3

2017-12-04 Thread Greg KH
On Tue, Dec 05, 2017 at 12:47:10AM +0100, Gabriel C wrote: > On 04.12.2017 23:10, rwar...@gmx.de wrote: > > > Hallo > > > > someone and I got an regression with e1000e since kernel 4.14.3 and it > > seems there is 4.14.4 on the way without a fix. > > > > > > bug report is here: > > > > https:

[next-queue 04/10] ixgbe: add ipsec data structures

2017-12-04 Thread Shannon Nelson
Set up the data structures to be used by the ipsec offload. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 40 ++ 2 files changed, 45 insertions(+) diff --git a/drivers/net/ethe

[next-queue 05/10] ixgbe: implement ipsec add and remove of offloaded SA

2017-12-04 Thread Shannon Nelson
Add the functions for setting up and removing offloaded SAs (Security Associations) with the x540 hardware. We set up the callback structure but we don't yet set the hardware feature bit to be sure the XFRM service won't actually try to use us for an offload yet. The software tables are made up t

[next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-04 Thread Shannon Nelson
If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 10 +++- dri

[next-queue 00/10] ixgbe: Add ipsec offload

2017-12-04 Thread Shannon Nelson
This is an implementation of the ipsec hardware offload feature for the ixgbe driver and Intel's 10Gbe series NICs: x540, x550, 82599. These patches apply to net-next v4.14 as well as Jeff Kirsher's next-queue v4.15-rc1-206-ge47375b. The ixgbe NICs support ipsec offload for 1024 Rx and 1024 Tx Sec

[next-queue 02/10] ixgbe: add ipsec register access routines

2017-12-04 Thread Shannon Nelson
Add a few routines to make access to the ipsec registers just a little easier, and throw in the beginnings of an initialization. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/Makefile | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe.h | 6 + drivers/net/ethernet/

[next-queue 09/10] ixgbe: ipsec offload stats

2017-12-04 Thread Shannon Nelson
Add a simple statistic to count the ipsec offloads. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 28 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 +++ 3 files change

[next-queue 06/10] ixgbe: restore offloaded SAs after a reset

2017-12-04 Thread Shannon Nelson
On a chip reset most of the table contents are lost, so must be restored. This scans the driver's ipsec tables and restores both the filled and empty table slots to their pre-reset values. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + drivers/net/ether

[next-queue 07/10] ixgbe: process the Rx ipsec offload

2017-12-04 Thread Shannon Nelson
If the chip sees and decrypts an ipsec offload, set up the skb sp pointer with the ralated SA info. Since the chip is rude enough to keep to itself the table index it used for the decryption, we have to do our own table lookup, using the hash for speed. Signed-off-by: Shannon Nelson --- drivers

[next-queue 01/10] ixgbe: clean up ipsec defines

2017-12-04 Thread Shannon Nelson
Clean up the ipsec/macsec descriptor bit definitions to match the rest of the defines and file organization. Also recognise the bit-definition overlap in the error mask macro. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 20 +++- 1 file chang

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-04 Thread Arvind Yadav
Hi David, On Monday 04 December 2017 11:55 PM, David Miller wrote: From: Arvind Yadav Date: Mon, 4 Dec 2017 23:18:20 +0530 @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if

[next-queue 03/10] ixgbe: add ipsec engine start and stop routines

2017-12-04 Thread Shannon Nelson
Add in the code for running and stopping the hardware ipsec encryption/decryption engine. It is good to keep the engine off when not in use in order to save on the power draw. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 140 + 1 fil

Re: [PATCH net-next 3/3] Add support for building the new cake qdisc

2017-12-04 Thread kbuild test robot
Hi Dave, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dave-Taht/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20171205-053924 config: parisc-allmodconfig (attached as .config) compiler: hp

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-04 Thread Jason Wang
On 2017年12月05日 00:28, Andreas Hartmann wrote: On 12/03/2017 at 12:35 PM Andreas Hartmann wrote: On 12/01/2017 at 11:11 AM Andreas Hartmann wrote: Hello! I hopefully could get rid of both of my problems (hanging network w/ virtio) and endless hanging qemu-process on VM shutdown by upgrading q

Re: [PATCH v15 4/5] scsi: mpt3sas: Replace PCI pool old API

2017-12-04 Thread Martin K. Petersen
Romain, > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. Applied to 4.16/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Claudiu Manoil ; da...@davemloft.net Subject: [PATCH 1/1] gianfar: fix a f

Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

2017-12-04 Thread kbuild test robot
Hi Shaohua, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Shaohua-Li/net-fix-flowlabel-inconsistency-in-reset-packet/20171205-072626 config: i386-randconfig-x002-12041112 (attached as .config) compi

Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

2017-12-04 Thread kbuild test robot
Hi Shaohua, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Shaohua-Li/net-fix-flowlabel-inconsistency-in-reset-packet/20171205-072626 config: x86_64-randconfig-x004-201749 (attached as .config) compiler: g

RE: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Jon Maloy
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, December 04, 2017 17:34 > To: Jon Maloy > Cc: David Miller ; Linux Kernel Network Developers > ; tipc-discuss...@lists.sourceforge.net; Ying Xue > > Subject: Re: [Patch net v2] tipc: fix a null poin

Re: [PATCH net-next v4 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-04 Thread Kunihiko Hayashi
Hi Andrew, On Fri, 1 Dec 2017 14:49:00 +0100 Andrew Lunn wrote: > On Fri, Dec 01, 2017 at 10:03:50AM +0900, Kunihiko Hayashi wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that includes MAC and MDIO bus supporting RGMII/RMII > > modes. The controller is

[PATCH v4 6/6] bpf: add new test test_many_kprobe

2017-12-04 Thread Song Liu
The test compares old text based kprobe API with perf_kprobe. Here is a sample output of this test: Creating 1000 kprobes with text-based API takes 6.979683 seconds Cleaning 1000 kprobes with text-based API takes 84.897687 seconds Creating 1000 kprobes with perf_kprobe (function name) takes 5.077

[PATCH v4 5/6] bpf: add option for bpf_load.c to use perf_kprobe

2017-12-04 Thread Song Liu
Function load_and_attach() is updated to be able to create kprobes with either old text based API, or the new perf_event_open API. A global flag use_perf_kprobe is added to select between the two APIs. Signed-off-by: Song Liu Reviewed-by: Josef Bacik --- samples/bpf/bpf_load.c | 59 +++

[PATCH v4 1/6] perf: prepare perf_event.h for new types perf_kprobe and perf_uprobe

2017-12-04 Thread Song Liu
Two new perf types, perf_kprobe and perf_uprobe, will be added to allow creating [k,u]probe with perf_event_open. These [k,u]probe are associated with the file decriptor created by perf_event_open, thus are easy to clean when the file descriptor is destroyed. kprobe_func and uprobe_path are added

[PATCH v4] perf_event_open.2: add type kprobe and uprobe

2017-12-04 Thread Song Liu
Two new types kprobe and uprobe are being added to perf_event_open, which allow creating kprobe or uprobe with perf_event_open. This patch adds information about these types. Signed-off-by: Song Liu --- man2/perf_event_open.2 | 49 + 1 file changed

[PATCH v4] bcc: Try use new API to create [k,u]probe with perf_event_open

2017-12-04 Thread Song Liu
New kernel API allows creating [k,u]probe with perf_event_open. This patch tries to use the new API. If the new API doesn't work, we fall back to old API. bpf_detach_probe() looks up the event being removed. If the event is not found, we skip the clean up procedure. Signed-off-by: Song Liu ---

[PATCH v4 4/6] perf: implement pmu perf_uprobe

2017-12-04 Thread Song Liu
This patch adds perf_uprobe support with similar pattern as previous patch (for kprobe). Two functions, create_local_trace_uprobe() and destroy_local_trace_uprobe(), are created so a uprobe can be created and attached to the file descriptor created by perf_event_open(). Signed-off-by: Song Liu R

[PATCH v4 2/6] perf: copy new perf_event.h to tools/include/uapi

2017-12-04 Thread Song Liu
perf_event.h is updated in previous patch, this patch applies same changes to the tools/ version. This is part is put in a separate patch in case the two files are back ported separately. Signed-off-by: Song Liu Reviewed-by: Yonghong Song Reviewed-by: Josef Bacik Acked-by: Alexei Starovoitov -

[PATCH v4 0/6] enable creating [k,u]probe with perf_event_open

2017-12-04 Thread Song Liu
Changes PATCH v3 to PATCH v4: Remove uapi define MAX_PROBE_FUNC_NAME_LEN, use KSYM_NAME_LEN instead. Add flag PERF_PROBE_CONFIG_IS_RETPROBE for config field of [k,u]probe. Optimize ifdef's of CONFIG_KPROBE_EVENTS and CONFIG_UPROBE_EVENTS. Optimize checks in perf_event_is_tracing(). Optimi

[PATCH v4 3/6] perf: implement pmu perf_kprobe

2017-12-04 Thread Song Liu
A new pmu, perf_kprobe is added. Based attr from perf_event_open(), perf_kprobe creates a kprobe (or kretprobe) for the perf_event. This kprobe is private to this perf_event, and thus not added to global lists, and not available in tracefs. Two functions, create_local_trace_kprobe() and destroy_lo

Re: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error

2017-12-04 Thread Doug Berger
On 12/02/2017 11:26 AM, Arvind Yadav wrote: > The change is to call free_netdev(), If of_match_node() will fail. > > Signed-off-by: Arvind Yadav > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethe

Re: [PATCH net-next 2/2] veth: allow configuring GSO maximums

2017-12-04 Thread Eric Dumazet
On Mon, 2017-12-04 at 16:03 -0800, Cong Wang wrote: > On Fri, Dec 1, 2017 at 12:11 PM, Stephen Hemminger > wrote: > > Veth's can be used in environments (like Azure) where the > > underlying > > network device is impacted by large GSO packets. This patch allows > > gso maximum values to be passed

Re: [PATCH 1/7 v2] net: bcmgenet: Fix platform_get_irq's error checking

2017-12-04 Thread Doug Berger
On 12/04/2017 09:48 AM, Arvind Yadav wrote: > The platform_get_irq() function returns negative number if an error occurs, > Zero if No irq is found and positive number if irq gets successful. > platform_get_irq() error checking only for zero is not correct. > > Signed-off-by: Arvind Yadav > --- >

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Claudiu Manoil ; da...@davemloft.net Subject: [PATCH 1/1] gianfar: fix a f

Re: [PATCH net-next] bpf: Add access to snd_cwnd and others in sock_ops

2017-12-04 Thread Lawrence Brakmo
On 12/4/17, 2:32 PM, "netdev-ow...@vger.kernel.org on behalf of Daniel Borkmann" wrote: Hi Lawrence, On 12/01/2017 07:15 PM, Lawrence Brakmo wrote: > Adds read access to snd_cwnd and srtt_us fields of tcp_sock. Since these > fields are only valid if the socket associated wi

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-04 Thread Willem de Bruijn
On Mon, Dec 4, 2017 at 4:31 AM, Jason Wang wrote: > This patch introduces an eBPF based queue selection method. With this, > the policy could be offloaded to userspace completely through a new > ioctl TUNSETSTEERINGEBPF. > > Signed-off-by: Jason Wang > --- > +static u16 tun_ebpf_select_queue(str

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-04 Thread Michael Chan
On Mon, Dec 4, 2017 at 2:00 PM, Eric Dumazet wrote: > On Mon, 2017-12-04 at 23:06 +0200, Or Gerlitz wrote: >> On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan > om> wrote: >> >> > All the logic is already in these 3 drivers in the tree. You can >> > see >> > the additional logic in any of these drive

Re: [PATCH net-next 2/2] veth: allow configuring GSO maximums

2017-12-04 Thread Cong Wang
On Fri, Dec 1, 2017 at 12:11 PM, Stephen Hemminger wrote: > Veth's can be used in environments (like Azure) where the underlying > network device is impacted by large GSO packets. This patch allows > gso maximum values to be passed in when creating the device via > netlink. > > In theory, other ps

Re: Regression in e1000e since Kernel 4.14.3

2017-12-04 Thread Gabriel C
On 04.12.2017 23:10, rwar...@gmx.de wrote: Hallo someone and I got an regression with e1000e since kernel 4.14.3 and it seems there is 4.14.4 on the way without a fix. bug report is here: https://bugzilla.kernel.org/show_bug.cgi?id=198047 ( added stable and netdev to CC ) Yes I have a bo

[PATCH net-next 1/2] net: sched: sch_api: fix code style issues

2017-12-04 Thread Alexander Aring
This patch fix checkpatch issues for upcomming patches according to the sched api file. It changes checking on null pointer, remove unnecessary brackets, add variable names for parameters and adjust 80 char width. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/sch_generic.h | 10

[PATCH net-next 0/2] net: sched: sch_api: fix coding style issues for extack

2017-12-04 Thread Alexander Aring
Hi, this patch prepares to handle extack for qdiscs and fixes checkpatch issues. There are a bunch of warnings issued by checkpatch which bothered me. This first patchset is to get rid of those warnings to make way for the next patchsets. I plan to followup with qdiscs, classifiers and actions a

[PATCH net-next 2/2] net: sched: sch_api: rearrange init handling

2017-12-04 Thread Alexander Aring
This patch fixes the following checkpatch error: ERROR: do not use assignment in if condition by rearranging the if condition to execute init callback only if init callback exists. The whole setup afterwards is called in any case, doesn't matter if init callback is set or not. This patch has the

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

2017-12-04 Thread Michael Chan
On Mon, Dec 4, 2017 at 12:58 PM, Alexander Duyck wrote: > On Mon, Dec 4, 2017 at 11:52 AM, Michael Chan > wrote: >> NETIF_F_GRO_HW is a flag that depends on NETIF_F_GRO. In some ways, >> it is similar to a private flag that depends on NETIF_F_LRO. But I >> think a standard flag is better. > >

linux-next: manual merge of the net-next tree with Linus' tree

2017-12-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/can/flexcan.c between commit: 29c64b17a0bc ("can: flexcan: fix VF610 state transition issue") from Linus' tree and commit: 99b7668c04b2 ("can: flexcan: adding platform specific details for LS1021A") fr

Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15

2017-12-04 Thread Hin-Tak Leung
On Tue, 14/11/17, Colin King wrote: > From: Colin Ian King > cck_poweri cannot be greated than 15 as > is derived from the bottom 4 bits > from riv->channels[channel - > 1].hw_value & 0xf.  Hence the check for it > being greater than 15 is redund

Re: [PATCH net-next] bpf: move bpf csum flag check

2017-12-04 Thread Daniel Borkmann
On 12/04/2017 11:18 PM, William Tu wrote: > trivial move the BPF_F_ZERO_CSUM_TX check right below the > 'flags & BPF_F_DONT_FRAGMENT', so common tun_flags handling > is logically together. > > Signed-off-by: William Tu > Acked-by: Daniel Borkmann Applied to bpf-next, thanks William.

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

2017-12-04 Thread Andrew Lunn
> So why not: > > switch@0 { > compatible = "acme,switch"; > #address-cells = <1>; > #size-cells = <0>; > > ports { > > port@0 { > reg = <0>; > phy@0 { > reg = <0>; >

Re: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

2017-12-04 Thread Michael Chan
On Mon, Dec 4, 2017 at 1:48 PM, Yuval Mintz wrote: >> Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on >> NETIF_F_GRO_FW flag. >> >> Cc: Ariel Elior >> Cc: everest-linux...@cavium.com >> Signed-off-by: Michael Chan >> --- >> drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++

[PATCH net-next 02/10] nfp: load debug dump spec

2017-12-04 Thread Simon Horman
From: Carl Heymann Load the TLV-based binary specification of what needs to be included in a dump, from the "_abi_dump_spec" rtsymbol. If the symbol is not defined, then dumps for levels >= 1 are not supported. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next 10/10] nfp: dump indirect ME CSRs

2017-12-04 Thread Simon Horman
From: Carl Heymann - The spec defines CSR address ranges for indirect ME CSRs. For Each TLV chunk in the spec, dump a chunk that includes the spec and the data over the defined address range. - Each indirect CSR has 8 contexts. To read one context, first write the context to a specific deri

[PATCH net-next 03/10] nfp: dump prolog

2017-12-04 Thread Simon Horman
From: Carl Heymann - Use a TLV structure, with the typed chunks aligned to 8-byte sizes. - Dump numeric fields as big-endian. - Prolog contains the dump level. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debug

Re: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Cong Wang
On Mon, Dec 4, 2017 at 12:32 PM, Jon Maloy wrote: > >> You are right. The right solution is to just call conn_put() twice here. >> I already have a patch ready for this, but it is part of a series that needs >> more >> review. >> I should probably post it separately... > > Well, calling conn_put(

[PATCH net-next 09/10] nfp: dump CPP, XPB and direct ME CSRs

2017-12-04 Thread Simon Horman
From: Carl Heymann - The spec defines CSR address ranges for these types. - Dump each TLV chunk in the spec as a chunk that includes the spec and the data over the defined address range. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/etherne

[PATCH net-next 08/10] nfp: dump firmware name

2017-12-04 Thread Simon Horman
From: Carl Heymann Dump FW name as TLV, based on dump specification. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/

[PATCH net-next 07/10] nfp: dump single hwinfo field by key

2017-12-04 Thread Simon Horman
From: Carl Heymann - Add spec TLV for hwinfo field, containing key string as data. - Add dump TLV for hwinfo field, with data being key and value as packed zero-terminated strings. - If specified hwinfo field is not found, dump the spec TLV as -ENOENT error. Signed-off-by: Carl Heymann Revi

[PATCH net-next 06/10] nfp: dump all hwinfo

2017-12-04 Thread Simon Horman
From: Carl Heymann - Dump hwinfo as separate TLV chunk, in a packed format containing zero-separated key and value strings. - This provides additional debug context, if requested by the dumpspec. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../ne

[PATCH net-next 04/10] nfp: dumpspec TLV traversal

2017-12-04 Thread Simon Horman
From: Carl Heymann - Perform dumpspec traversals for calculating size and populating the dump. - Initially, wrap all spec TLVs in dump error TLVs (changed by later patches in the series). Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethe

[PATCH net-next 05/10] nfp: dump rtsyms

2017-12-04 Thread Simon Horman
From: Carl Heymann - Support rtsym TLVs. - If specified rtsym is not found, dump the spec TLV as -ENOENT error. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 124 + 1 file chang

[PATCH net-next 01/10] nfp: debug dump ethtool ops

2017-12-04 Thread Simon Horman
From: Carl Heymann - Skeleton code to perform a binary debug dump via ethtoolops "set_dump", "get_dump_flags" and "get_dump_data", i.e. the ethtool -W/w mechanism. - Skeleton functions for debugdump operations provided. - An integer "dump level" can be specified, this is stored between etht

[PATCH net-next 00/10] nfp: enhanced debug dump via ethtool

2017-12-04 Thread Simon Horman
Add debug dump implementation to the NFP driver. This makes use of existing ethtool infrastructure. ethtool -W is used to select the dump level and ethtool -w is used to dump NFP state. The existing behaviour of dump level 0, dumping the arm.diag resource, is preserved. Dump levels greater than 0

Re: [PATCH net-next] bpf: Add access to snd_cwnd and others in sock_ops

2017-12-04 Thread Daniel Borkmann
Hi Lawrence, On 12/01/2017 07:15 PM, Lawrence Brakmo wrote: > Adds read access to snd_cwnd and srtt_us fields of tcp_sock. Since these > fields are only valid if the socket associated with the sock_ops program > call is a full socket, the field is_fullsock is also added to the > bpf_sock_ops struc

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

2017-12-04 Thread Michael Chan
On Mon, Dec 4, 2017 at 2:15 PM, Yuval Mintz wrote: >> @@ -96,6 +98,7 @@ enum { >> #define NETIF_F_FRAGLIST __NETIF_F(FRAGLIST) >> #define NETIF_F_FSO __NETIF_F(FSO) >> #define NETIF_F_GRO __NETIF_F(GRO) >> +#define NETIF_F_GRO_HW __NETIF_F(GRO_HW) >> #define

Re: [PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet

2017-12-04 Thread Rob Herring
On Sat, Dec 02, 2017 at 12:06:39PM +0100, Linus Walleij wrote: > This adds the device tree bindings for the Gemini ethernet > controller. It is pretty straight-forward, using standard > bindings and modelling the two child ports as child devices > under the parent ethernet controller device. > > C

[PATCH net-next] bpf: move bpf csum flag check

2017-12-04 Thread William Tu
trivial move the BPF_F_ZERO_CSUM_TX check right below the 'flags & BPF_F_DONT_FRAGMENT', so common tun_flags handling is logically together. Signed-off-by: William Tu Acked-by: Daniel Borkmann --- net/core/filter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/cor

RE: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

2017-12-04 Thread Yuval Mintz
> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware > GRO. With this flag, we can now independently turn on or off hardware > GRO when GRO is on. Hardware GRO guarantees that packets can be > re-segmented by TSO/GSO to reconstruct the original packet stream. > > Cc: Ariel Elio

[PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread simo . ghannam
From: Mohamed Ghannam Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. Signed-off-by: Mohamed Ghannam --- net/dccp/proto.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/dc

Re: [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread Eric Dumazet
On Mon, 2017-12-04 at 22:02 +0100, simo.ghan...@gmail.com wrote: > From: Mohamed Ghannam > > Whenever the sock object is in DCCP_CLOSED state, > dccp_disconnect() must free >dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. > > Signed-off-by: Mohamed Ghannam > --- Reviewed-b

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-04 Thread Eric Dumazet
On Mon, 2017-12-04 at 23:06 +0200, Or Gerlitz wrote: > On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan om> wrote: > > > All the logic is already in these 3 drivers in the tree.  You can > > see > > the additional logic in any of these drivers.  It's just that these > > drivers have been using NETIF_

RE: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

2017-12-04 Thread Yuval Mintz
> Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on > NETIF_F_GRO_FW flag. > > Cc: Ariel Elior > Cc: everest-linux...@cavium.com > Signed-off-by: Michael Chan > --- > drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++--- > drivers/net/ethernet/qlogic/qede/qede_main.c |

[PATCH net-next] rtnetlink: fix rtnl_link msghandler rcu annotations

2017-12-04 Thread Florian Westphal
Incorrect/missing annotations caused a few sparse warnings: rtnetlink.c:155:15: incompatible types .. (different address spaces) rtnetlink.c:157:23: incompatible types .. (different address spaces) rtnetlink.c:185:15: incompatible types .. (different address spaces) rtnetlink.c:285:15: incompatibl

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-04 Thread Or Gerlitz
On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan wrote: > All the logic is already in these 3 drivers in the tree. You can see > the additional logic in any of these drivers. It's just that these > drivers have been using NETIF_F_GRO to turn on this mode in > hardware/firmware. What happens for tc

[PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread simo . ghannam
From: Mohamed Ghannam Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. Signed-off-by: Mohamed Ghannam --- net/dccp/proto.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/dccp/pro

[net 1/1] tipc: fix memory leak in tipc_accept_from_sock()

2017-12-04 Thread Jon Maloy
When the function tipc_accept_from_sock() fails to create an instance of struct tipc_subscriber it omits to free the already created instance of struct tipc_conn instance before it returns. We fix that with this commit. Reported-by: David S. Miller Signed-off-by: Jon Maloy --- net/tipc/server.

RE: ethtool-copy.h out of sync with linux header file?

2017-12-04 Thread Greenwalt, Paul
John, Can this patch be reverted? As Stephen Hemminger mentioned there is an ABI compatibility issue with this patch: https://patchwork.ozlabs.org/patch/806049/#1757846 Thanks, Paul > -Original Message- > From: Scott Branden [mailto:scott.bran...@broadcom.com] > Sent: Monday, December 4

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

2017-12-04 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 11:52 AM, Michael Chan wrote: > On Mon, Dec 4, 2017 at 10:43 AM, Alexander Duyck > wrote: >> On Mon, Dec 4, 2017 at 10:23 AM, Michael Chan >> wrote: >>> On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck >>> wrote: On Mon, Dec 4, 2017 at 3:12 AM, Michael Chan wr

Re: [Bloat] Linux network is damn fast, need more use XDP (Was: DC behaviors today)

2017-12-04 Thread Joel Wirāmu Pauling
On 5 December 2017 at 06:00, Dave Taht wrote: >>> The route table lookup also really expensive on the main cpu. > > To clarify the context here, I was asking specifically if the X5 mellonox card > did routing table offlload or only switching. > To clarify what I know the X5 using it's smart offlo

Re: [PATCH] tcp/dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread Eric Dumazet
On Mon, 2017-12-04 at 12:41 -0800, Eric Dumazet wrote: > On Mon, 2017-12-04 at 21:27 +0100, simo.ghan...@gmail.com wrote: > > From: Mohamed Ghannam > > > > Whenever the sock object is in DCCP_CLOSED state, > > dccp_disconnect() must free > > dccps_hc_tx_ccid and dccps_hc_rx_ccid and set

Re: [PATCH iproute2 net-next] gre6: add collect metadata support

2017-12-04 Thread William Tu
On Mon, Dec 4, 2017 at 9:26 AM, Gregory Rose wrote: > On 12/1/2017 3:03 PM, William Tu wrote: >> >> The patch adds 'external' option to support collect metadata >> gre6 tunnel. Example of L3 and L2 gre device: >> bash:~# ip link add dev ip6gre123 type ip6gre external >> bash:~# ip link add dev ip6

Re: [PATCH] tcp/dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread Eric Dumazet
On Mon, 2017-12-04 at 21:27 +0100, simo.ghan...@gmail.com wrote: > From: Mohamed Ghannam > > Whenever the sock object is in DCCP_CLOSED state, > dccp_disconnect() must free >dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. > > Signed-off-by: Mohamed Ghannam > --- Small nit

RE: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jon Maloy > Sent: Monday, December 04, 2017 14:50 > To: Cong Wang ; David Miller > > Cc: Linux Kernel Network Developers ; tipc- > discuss...@lists.sourceforge.net; Ying Xue >

[PATCH] tcp/dccp: CVE-2017-8824: use-after-free in DCCP code

2017-12-04 Thread simo . ghannam
From: Mohamed Ghannam Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. Signed-off-by: Mohamed Ghannam --- net/dccp/proto.c | 4 1 file changed, 4 insertions(+) diff --git a/net/dccp/prot

Re: BPF: bug without effect in BPF_RSH case of adjust_scalar_min_max_vals()

2017-12-04 Thread Jann Horn
On Mon, Dec 4, 2017 at 6:03 PM, Jann Horn wrote: > As far as I can tell, commit b03c9f9fdc37 ("bpf/verifier: track signed > and unsigned min/max values") introduced the following effectless bug > in the BPF_RSH case of adjust_scalar_min_max_vals() (unless that's > intentional): [...] > ===

Re: BPF: bug without effect in BPF_RSH case of adjust_scalar_min_max_vals()

2017-12-04 Thread Edward Cree
On 04/12/17 17:03, Jann Horn wrote: > As far as I can tell, commit b03c9f9fdc37 ("bpf/verifier: track signed > and unsigned min/max values") introduced the following effectless bug > in the BPF_RSH case of adjust_scalar_min_max_vals() (unless that's > intentional): > > `dst_reg->smax_value` is only

Re: [PATCH] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-04 Thread Scott Branden
Hi Gal, I do not understand you're comment - questions inline On 17-12-03 12:07 AM, Gal Pressman wrote: On 30-Nov-17 21:24, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME flagnames currently match the ETH_RESET_xxx names: mgmt,irq,dma,filte

ethtool-copy.h out of sync with linux header file?

2017-12-04 Thread Scott Branden
Hi Paul/John, I see a commit "ethtool: Add DMA Coalescing support" was added to ethtool-copy.h yet I cannot find the change in the ethtool.h in the linux kernel. As such, I am unable to commit a change to ethtool-copy.h to sync it with net-next.  If I sync then ethtool will fail to compile.

Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-04 Thread Sergei Shtylyov
On 12/04/2017 04:33 PM, Thomas Petazzoni wrote: There are two types of "struct device": the one representing the physical device on its physical bus (platform, SPI, PCI, etc.), and the one representing the logical device in its device class (net, etc.). The DMA mapping API expects to receive as

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

2017-12-04 Thread Michael Chan
On Mon, Dec 4, 2017 at 10:43 AM, Alexander Duyck wrote: > On Mon, Dec 4, 2017 at 10:23 AM, Michael Chan > wrote: >> On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck >> wrote: >>> On Mon, Dec 4, 2017 at 3:12 AM, Michael Chan >>> wrote: Introduce NETIF_F_GRO_HW feature flag for NICs that su

RE: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Jon Maloy
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, December 04, 2017 14:41 > To: David Miller > Cc: Linux Kernel Network Developers ; tipc- > discuss...@lists.sourceforge.net; Jon Maloy ; > Ying Xue > Subject: Re: [Patch net v2] tipc: fix a null poi

Re: [bisected] x86 boot still broken on -rc2

2017-12-04 Thread Jakub Kicinski
On Mon, 4 Dec 2017 11:45:21 -0500, Prarit Bhargava wrote: > On 12/04/2017 08:13 AM, Prarit Bhargava wrote: > > x86: Booting SMP configuration: > > node #0, CPUs:#1 #2 #3 #4 > > node #1, CPUs:#5 #6 #7 #8 #9 > > node #0, CPUs: #10 #11 #12 #13 #14 > > node

Re: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread David Miller
From: Cong Wang Date: Mon, 4 Dec 2017 11:23:13 -0800 > On Mon, Dec 4, 2017 at 10:57 AM, David Miller wrote: >> From: Cong Wang >> Date: Mon, 4 Dec 2017 10:31:43 -0800 >> >>> In tipc_topsrv_kern_subscr() when s->tipc_conn_new() fails >>> we call tipc_close_conn() to clean up, but in this case >

RE: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Miller > Sent: Monday, December 04, 2017 13:57 > To: xiyou.wangc...@gmail.com > Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; Jon > Maloy ; Ying Xue

Re: [Patch net v2] tipc: fix a null pointer deref on error path

2017-12-04 Thread Cong Wang
On Mon, Dec 4, 2017 at 11:23 AM, Cong Wang wrote: > On Mon, Dec 4, 2017 at 10:57 AM, David Miller wrote: >> >> It looks like tipc_accept_from_sock() has a similar problem? The >> tipc_close_conn() will get invoked indirectly from the sock_release() >> path right? > > Not sure, the sock_release()

  1   2   3   >