Hi Dave, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dave-Taht/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20171205-053924 config: parisc-allmodconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=parisc All warnings (new ones prefixed by >>): net/sched/sch_cake.c: In function 'cake_dump_stats': >> net/sched/sch_cake.c:2530:1: warning: the frame size of 1424 bytes is larger >> than 1280 bytes [-Wframe-larger-than=] } ^ vim +2530 net/sched/sch_cake.c 8c28e37b Dave Taht 2017-12-03 2479 8c28e37b Dave Taht 2017-12-03 2480 static int cake_dump_stats(struct Qdisc *sch, struct gnet_dump *d) 8c28e37b Dave Taht 2017-12-03 2481 { 8c28e37b Dave Taht 2017-12-03 2482 struct cake_sched_data *q = qdisc_priv(sch); 8c28e37b Dave Taht 2017-12-03 2483 struct tc_cake_xstats *st = kvzalloc(sizeof(*st), GFP_KERNEL); 8c28e37b Dave Taht 2017-12-03 2484 int i; 8c28e37b Dave Taht 2017-12-03 2485 8c28e37b Dave Taht 2017-12-03 2486 if (!st) 8c28e37b Dave Taht 2017-12-03 2487 return -ENOMEM; 8c28e37b Dave Taht 2017-12-03 2488 8c28e37b Dave Taht 2017-12-03 2489 st->version = 5; 8c28e37b Dave Taht 2017-12-03 2490 st->max_tins = TC_CAKE_MAX_TINS; 8c28e37b Dave Taht 2017-12-03 2491 st->tin_cnt = q->tin_cnt; 8c28e37b Dave Taht 2017-12-03 2492 8c28e37b Dave Taht 2017-12-03 2493 for (i = 0; i < q->tin_cnt; i++) { 8c28e37b Dave Taht 2017-12-03 2494 struct cake_tin_data *b = &q->tins[q->tin_order[i]]; 8c28e37b Dave Taht 2017-12-03 2495 8c28e37b Dave Taht 2017-12-03 2496 st->threshold_rate[i] = b->tin_rate_bps; 8c28e37b Dave Taht 2017-12-03 2497 st->target_us[i] = cobalt_time_to_us(b->cparams.target); 8c28e37b Dave Taht 2017-12-03 2498 st->interval_us[i] = cobalt_time_to_us(b->cparams.interval); 8c28e37b Dave Taht 2017-12-03 2499 8c28e37b Dave Taht 2017-12-03 2500 /* TODO FIXME: add missing aspects of these composite stats */ 8c28e37b Dave Taht 2017-12-03 2501 st->sent[i].packets = b->packets; 8c28e37b Dave Taht 2017-12-03 2502 st->sent[i].bytes = b->bytes; 8c28e37b Dave Taht 2017-12-03 2503 st->dropped[i].packets = b->tin_dropped; 8c28e37b Dave Taht 2017-12-03 2504 st->ecn_marked[i].packets = b->tin_ecn_mark; 8c28e37b Dave Taht 2017-12-03 2505 st->backlog[i].bytes = b->tin_backlog; 8c28e37b Dave Taht 2017-12-03 2506 st->ack_drops[i].packets = b->ack_drops; 8c28e37b Dave Taht 2017-12-03 2507 8c28e37b Dave Taht 2017-12-03 2508 st->peak_delay_us[i] = cobalt_time_to_us(b->peak_delay); 8c28e37b Dave Taht 2017-12-03 2509 st->avge_delay_us[i] = cobalt_time_to_us(b->avge_delay); 8c28e37b Dave Taht 2017-12-03 2510 st->base_delay_us[i] = cobalt_time_to_us(b->base_delay); 8c28e37b Dave Taht 2017-12-03 2511 8c28e37b Dave Taht 2017-12-03 2512 st->way_indirect_hits[i] = b->way_hits; 8c28e37b Dave Taht 2017-12-03 2513 st->way_misses[i] = b->way_misses; 8c28e37b Dave Taht 2017-12-03 2514 st->way_collisions[i] = b->way_collisions; 8c28e37b Dave Taht 2017-12-03 2515 8c28e37b Dave Taht 2017-12-03 2516 st->sparse_flows[i] = b->sparse_flow_count + 8c28e37b Dave Taht 2017-12-03 2517 b->decaying_flow_count; 8c28e37b Dave Taht 2017-12-03 2518 st->bulk_flows[i] = b->bulk_flow_count; 8c28e37b Dave Taht 2017-12-03 2519 st->unresponse_flows[i] = b->unresponsive_flow_count; 8c28e37b Dave Taht 2017-12-03 2520 st->spare[i] = 0; 8c28e37b Dave Taht 2017-12-03 2521 st->max_skblen[i] = b->max_skblen; 8c28e37b Dave Taht 2017-12-03 2522 } 8c28e37b Dave Taht 2017-12-03 2523 st->capacity_estimate = q->avg_peak_bandwidth; 8c28e37b Dave Taht 2017-12-03 2524 st->memory_limit = q->buffer_limit; 8c28e37b Dave Taht 2017-12-03 2525 st->memory_used = q->buffer_max_used; 8c28e37b Dave Taht 2017-12-03 2526 8c28e37b Dave Taht 2017-12-03 2527 i = gnet_stats_copy_app(d, st, sizeof(*st)); 8c28e37b Dave Taht 2017-12-03 2528 cake_free(st); 8c28e37b Dave Taht 2017-12-03 2529 return i; 8c28e37b Dave Taht 2017-12-03 @2530 } 8c28e37b Dave Taht 2017-12-03 2531 :::::: The code at line 2530 was first introduced by commit :::::: 8c28e37b67a2c9259e413f7dc39d6c84c08e8c75 Add Common Applications Kept Enhanced (cake) qdisc :::::: TO: Dave Taht <dave.t...@gmail.com> :::::: CC: 0day robot <fengguang...@intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
