Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Michal Kubecek
On Thu, Apr 20, 2017 at 07:19:55PM -0400, Vlad Yasevich wrote: > > Having said that, the other alternative is to inherit hw_features from > lower devices. BTW, bonding I think has a similar "issue" you are > describing since it prefers HW_CSUM if any of the slaves have it set. It does but bondin

[PATCH net-next 4/5] qed: Support dcbnl IEEE selector field.

2017-04-20 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c| 53 ++- drivers/net/ethernet/qlogic/qede/qede_dcbnl.c | 5 +++ 2 files changed, 49 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/qlogi

[PATCH net-next 5/5] qed: Add support for static dcbx.

2017-04-20 Thread Sudarsana Reddy Kalluru
The patch adds driver support for static/local dcbx mode. In this mode adapter brings up the dcbx link with locally configured parameters instead of performing the dcbx negotiation with the peer. The feature is useful when peer device/switch doesn't support dcbx. Signed-off-by: Sudarsana Reddy Kal

[PATCH net-next 2/5] qed: Separate RoCE DCBx support for V2.

2017-04-20 Thread Sudarsana Reddy Kalluru
In the older firmware there was no distinction between RoCE and RoCEv2 whereas the newer firmware (8.15.3.0) allows us to configure each independently. Driver need to populate the RoCEv2 data in its specific structure. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- driver

[PATCH net-next 1/5] qed: Cleanup DCBx unnecessary parameters.

2017-04-20 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 38 -- drivers/net/ethernet/qlogic/qed/qed_dcbx.h | 2 +- drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +- 3 files changed, 17 insertions(+), 25 dele

[PATCH net-next 3/5] qed: Add additional DCBx debug messages.

2017-04-20 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index d

[PATCH net-next 0/5] qed*: Dcbx/dcbnl enhancements.

2017-04-20 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The series has set of enhancements for dcbx/dcbnl implementation of qed/qede drivers. - Patches (1) & (3) capture the sematic and debug changes. - Patch (2) adds the driver support for populating RoCEv2 dcb data. - Patch (4) adds the required support for reading/c

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 12:50:29PM +0200, Steffen Klassert wrote: > On Thu, Apr 20, 2017 at 05:52:35PM +0800, Herbert Xu wrote: > > On Thu, Apr 20, 2017 at 11:17:52AM +0200, Steffen Klassert wrote: > > > > > > I tried to use async algorithms but it lead to serveral problems. > > > The GSO layer can

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

2017-04-20 Thread Giuseppe CAVALLARO
On 4/18/2017 2:39 PM, Niklas Cassel wrote: From: Niklas Cassel The hardware has a LPI interrupt. There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding. At the same time, improve the description of the existing in

Re: macvlan: Fix device ref leak when purging bc_queue

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 04:09:56PM +, joe.gha...@dell.com wrote: > I agree with this change, but the same purge would be needed for the > macvlan_dellink() call also. I don't think that's necessary because as long as the master device is still around it will continue to process the broadcast

[PATCH net v3] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats

2017-04-20 Thread Martin KaFai Lau
We have observed a sudden spike in rx/tx_packets and rx/tx_bytes reported under /proc/net/dev. There is a race in mlx5e_update_stats() and some of the get-stats functions (the one that we hit is the mlx5e_get_stats() which is called by ndo_get_stats64()). In particular, the very first thing mlx5e

Re: [PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-20 Thread Jason Wang
On 2017年04月20日 23:34, Vlad Yasevich wrote: On 04/17/2017 11:01 PM, Jason Wang wrote: On 2017年04月16日 00:38, Vladislav Yasevich wrote: Curreclty virtion net header is fixed size and adding things to it is rather difficult to do. This series attempt to add the infrastructure as well as some ex

[PATCH 2/2] ipv6: don't deliver packets with zero length to raw sockets

2017-04-20 Thread Jamie Bainbridge
IPv6 assumes there is data after the network header and blindly delivers skbs to raw sockets without checking the presence of data. With an application in a common loop where it checks select/poll/epoll then ioctl(SIOCINQ/FIONREAD) is positive before continuing to recvfrom(), this behaviour can ca

[PATCH 1/2] ipv6: check raw payload size correctly in ioctl

2017-04-20 Thread Jamie Bainbridge
In situations where an skb is paged, the transport header pointer and tail pointer will be the same because the payload is in skb frags. This results in ioctl(SIOCINQ/FIONREAD) returning a length of 0 when the length to receive is actually greater than zero. skb->len is already correctly set in i

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-20 Thread Jason Wang
On 2017年04月20日 21:58, Willem de Bruijn wrote: On Thu, Apr 20, 2017 at 2:27 AM, Jason Wang wrote: On 2017年04月19日 04:21, Willem de Bruijn wrote: +static void virtnet_napi_tx_enable(struct virtnet_info *vi, + struct virtqueue *vq, +

Re: [PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

2017-04-20 Thread Neal Cardwell
On Thu, Apr 20, 2017 at 8:30 PM, Yuchung Cheng wrote: > On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: >> From: Wei Wang >> >> This counter records the number of times the firewall blackhole issue is >> detected and active TFO is disabled. >> >> Signed-off-by: Wei Wang > Acked-by: Yuchung Che

Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

2017-04-20 Thread Neal Cardwell
On Thu, Apr 20, 2017 at 5:29 PM, Yuchung Cheng wrote: > On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: >> From: Wei Wang >> >> Christoph Paasch from Apple found another firewall issue for TFO: >> After successful 3WHS using TFO, server and client starts to exchange >> data. Afterwards, a 10s i

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Alexander Duyck
On Thu, Apr 20, 2017 at 4:19 PM, Vlad Yasevich wrote: > On 04/20/2017 06:31 PM, Alexander Duyck wrote: >> On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich >> wrote: >>> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >>> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >>>

Re: FEC on i.MX 7 transmit queue timeout

2017-04-20 Thread Andy Duan
On 2017年04月20日 07:15, Stefan Agner wrote: > I tested again with imx6sx-fec compatible string. I could reproduce it > on a Colibri with i.MX 7Dual. But not always: It really depends whether > queue 2 is counting up or not. Just after boot, I check /proc/interrupts > twice, if queue 2 is counting it

Re: [PATCH net-next 1/3] net/tcp_fastopen: Disable active side TFO in certain scenarios

2017-04-20 Thread Neal Cardwell
On Thu, Apr 20, 2017 at 5:45 PM, Wei Wang wrote: > From: Wei Wang > > Middlebox firewall issues can potentially cause server's data being > blackholed after a successful 3WHS using TFO. Following are the related > reports from Apple: > https://www.nanog.org/sites/default/files/Paasch_Network_Supp

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Gavin Shan
On Thu, Apr 20, 2017 at 05:58:58PM -0700, David Miller wrote: >From: Gavin Shan >Date: Fri, 21 Apr 2017 09:38:12 +1000 > >> (1) ethtool usually dumps statistics collected by hardware, but this >> debugfs file dumps the statistics of packets seen (collected) by >> software. > >ethtool is not strict

Re: [PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

2017-04-20 Thread Leon Romanovsky
On Thu, Apr 20, 2017 at 04:45:43PM -0400, Doug Ledford wrote: > On Thu, 2017-04-20 at 21:49 +0300, Leon Romanovsky wrote: > > On Thu, Apr 20, 2017 at 02:41:17PM -0400, Doug Ledford wrote: > > > > > > On Mon, 2017-04-17 at 11:08 -0400, David Miller wrote: > > > > > > > > From: Saeed Mahameed > > >

[net-next 02/11] ixgbe: add XDP support for pass and drop actions

2017-04-20 Thread Jeff Kirsher
From: John Fastabend Basic XDP drop support for ixgbe. Uses READ_ONCE/xchg semantics on XDP programs instead of rcu primitives as suggested by Daniel Borkmann and Alex Duyck. Signed-off-by: John Fastabend Acked-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- dri

[net-next 05/11] ixgbe: clean macvlan MAC filter table on VF reset

2017-04-20 Thread Jeff Kirsher
From: Emil Tantilov Flush the macvlan filters on VF reset to avoid conflict with other VFs that may end up using the same MAC address. The main change here is the call to ixgbe_set_vf_macvlan() with index 0. Moved ixgbe_set_vf_macvlan() in front of ixgbe_vf_reset_event() to avoid adding a proto

[net-next 07/11] ixgbe: Allow setting zero MAC address for VF

2017-04-20 Thread Jeff Kirsher
From: Tony Nguyen Currently, there is no logic that allows a VF's MAC address to be removed from the RAR table. Allow the user to specify a zero MAC address in order to clear the VF's MAC address from the RAR table. This functionality is also utilized by libvirt when removing VFs. Signed-off-b

[net-next 09/11] ixgbe: Check for RSS key before setting value

2017-04-20 Thread Jeff Kirsher
From: Tony Nguyen The RSS key is being repopulated every time the interface is brought up regardless of whether there is an existing value. If the user sets the RSS key and the interface is brought up (e.g. reset), the user specified RSS key will be overwritten. This patch changes the rss_key to

[net-next 04/11] ixgbe: delay tail write to every 'n' packets

2017-04-20 Thread Jeff Kirsher
From: John Fastabend Current XDP implementation hits the tail on every XDP_TX return code. This patch changes driver behavior to only hit the tail after packet processing is complete. With this patch I can run XDP drop programs @ 14+Mpps and XDP_TX programs are at ~13.5Mpps. Signed-off-by: John

[net-next 08/11] ixgbe: Add 1000Base-T device based on X550EM_X MAC

2017-04-20 Thread Jeff Kirsher
From: Paul Greenwalt Add support for new 1000Base-T device based on X550EM_X MAC type. All PHY operations are disabled as the PHY is controlled by FW. Signed-off-by: Paul Greenwalt Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +

[net-next 11/11] ixgbevf: Check for RSS key before setting value

2017-04-20 Thread Jeff Kirsher
From: Tony Nguyen The RSS key is being repopulated every time the interface is brought up regardless of whether there is an existing value. If the user sets the RSS key and the interface is brought up (e.g. reset), the user specified RSS key will be overwritten. This patch changes the rss_key to

[net-next 10/11] ixgbevf: Fix errors in retrieving RETA and RSS from PF

2017-04-20 Thread Jeff Kirsher
From: Tony Nguyen Mailbox support for getting RETA and RSS is available for only 82599 and x540; a previous patch reversed the logic and these adapters were returning not supported. Also, the NACK check in ixgbevf_get_rss_key_locked() was checking for the command IXGBE_VF_GET_RETA instead of IXG

[net-next 06/11] ixgbevf: fix size of queue stats length

2017-04-20 Thread Jeff Kirsher
From: Emil Tantilov IXGBEVF_QUEUE_STATS_LEN is based on ixgebvf_stats, not ixgbe_stats. This change fixes a bug where ethtool -S displayed some empty fields. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/ethtool.c |

[net-next 00/11][pull request] 10GbE Intel Wired LAN Driver Updates 2017-04-20

2017-04-20 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf only, most notable is the addition of XDP support to our 10GbE drivers. Paul fixes ixgbe to acquire the PHY semaphore before accessing PHY registers when issuing a device reset. John adds XDP support (yeah!) for ixgbe. Emil fixes an issue by flus

[net-next 01/11] ixgbe: Acquire PHY semaphore before device reset

2017-04-20 Thread Jeff Kirsher
From: Paul Greenwalt A recent firmware change fixed an issue to acquire the PHY semaphore before accessing PHY registers. This led to a case where SW can issue a device reset clearing the MDIO registers. This patch makes SW acquire the PHY semaphore before issuing a device reset. Signed-off-by:

[net-next 03/11] ixgbe: add support for XDP_TX action

2017-04-20 Thread Jeff Kirsher
From: John Fastabend A couple design choices were made here. First I use a new ring pointer structure xdp_ring[] in the adapter struct instead of pushing the newly allocated xdp TX rings into the tx_ring[] structure. This means we have to duplicate loops around rings in places we want to initiali

Re: [PATCH 2/2] sparc64: Add eBPF JIT.

2017-04-20 Thread David Miller
From: Daniel Borkmann Date: Wed, 19 Apr 2017 11:35:39 +0200 > On 04/18/2017 08:58 PM, David Miller wrote: >> +if (!prog || !prog->len) >> +return orig_prog; > > This condition can be removed, see also 93a73d442d37 > ("bpf, x86/arm64: remove useless checks on prog"), since > there

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Joe Perches
On Fri, 2017-04-21 at 11:35 +1000, Gavin Shan wrote: > Yes, it's definitely good idea to cover everything using one interface. > It's for sure that the statistics collected by hardware should be dumped > by ethtool in future. I will move functionalities introduced by this > patchset to ethtool as w

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Andrew Lunn
> > + gpiod_set_value_cansleep(gpiod, 1); > > + udelay(bus->reset_delay_us); > > + gpiod_set_value_cansleep(gpiod, 0); > > Does that work even if the polarity of the reset line is active low? Hi Florian Yes, it does. The gpiod_ API takes care

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Gavin Shan
On Thu, Apr 20, 2017 at 05:59:27PM -0700, Florian Fainelli wrote: >On 04/20/2017 05:44 PM, Gavin Shan wrote: >> On Thu, Apr 20, 2017 at 05:26:14PM -0700, Florian Fainelli wrote: >>> On 04/20/2017 04:38 PM, Gavin Shan wrote: On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: > Fr

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Florian Fainelli
Hi Roger, On 04/20/2017 07:11 AM, Roger Quadros wrote: > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these PHYs need to be RESE

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Andrew Lunn
On Thu, Apr 20, 2017 at 05:11:53PM +0300, Roger Quadros wrote: > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these PHYs need to

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Florian Fainelli
On 04/20/2017 05:44 PM, Gavin Shan wrote: > On Thu, Apr 20, 2017 at 05:26:14PM -0700, Florian Fainelli wrote: >> On 04/20/2017 04:38 PM, Gavin Shan wrote: >>> On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: From: Gavin Shan Date: Tue, 18 Apr 2017 16:51:32 +1000 > T

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread David Miller
From: Gavin Shan Date: Fri, 21 Apr 2017 09:38:12 +1000 > (1) ethtool usually dumps statistics collected by hardware, but this > debugfs file dumps the statistics of packets seen (collected) by > software. ethtool is not strictly for hardware statistics, it's often used for software maintained va

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Gavin Shan
On Thu, Apr 20, 2017 at 05:26:14PM -0700, Florian Fainelli wrote: >On 04/20/2017 04:38 PM, Gavin Shan wrote: >> On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >>> From: Gavin Shan >>> Date: Tue, 18 Apr 2017 16:51:32 +1000 >>> This creates /sys/kernel/debug/ncsi//stats to dump t

Re: [PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

2017-04-20 Thread Yuchung Cheng
On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > This counter records the number of times the firewall blackhole issue is > detected and active TFO is disabled. > > Signed-off-by: Wei Wang Acked-by: Yuchung Cheng > --- > include/net/tcp.h | 2 +- > include/uapi/li

Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

2017-04-20 Thread Yuchung Cheng
On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > Christoph Paasch from Apple found another firewall issue for TFO: > After successful 3WHS using TFO, server and client starts to exchange > data. Afterwards, a 10s idle time occurs on this connection. After that, > firewall sta

Re: [PATCH net-next 1/3] net/tcp_fastopen: Disable active side TFO in certain scenarios

2017-04-20 Thread Yuchung Cheng
On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > Middlebox firewall issues can potentially cause server's data being > blackholed after a successful 3WHS using TFO. Following are the related > reports from Apple: > https://www.nanog.org/sites/default/files/Paasch_Network_Supp

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Florian Fainelli
On 04/20/2017 04:38 PM, Gavin Shan wrote: > On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >> From: Gavin Shan >> Date: Tue, 18 Apr 2017 16:51:32 +1000 >> >>> This creates /sys/kernel/debug/ncsi//stats to dump the NCSI >>> packets sent and received over all packages and channels. It

[net:master 15/18] drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset

2017-04-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: e0535ce58b92d7baf0b33284a6c4f8f0338f943e commit: 62289ba27558553871fd047baadaaeda886c6a63 [15/18] qed: Fix possible system hang in the dcbnl-getdcbx() path. coccinelle warnings: (new ones prefixed by >>) >> dri

[PATCH] qed: fix kzalloc-simple.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset Use kzalloc rather than kmalloc followed by memset with 0 This considers some simple cases that are common and easy to validate Note in particular that there are no

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

2017-04-20 Thread Martin KaFai Lau
On Thu, Apr 20, 2017 at 04:37:18PM -0700, Cong Wang wrote: > On Thu, Apr 20, 2017 at 3:43 PM, David Ahern wrote: > > > > I scanned the others. It is not clear that others should fail with > > EINVAL. Certainly a mask of unused flags can be added, but to me that is > > on top of this bug fix. > > >

RE: netlink: question about netlink testsuite

2017-04-20 Thread Yasuhara, Hiroyuki
Hi, > -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Wednesday, April 19, 2017 3:06 PM > Hello, > > On Tue, Apr 18, 2017 at 10:00 PM, Yasuhara, Hiroyuki > wrote: > > Hi, > > > > I'm looking for a testset about netlink function, > > for example, making a lo

[PATCH v2] net: core: Prevent from dereferencing null pointer when

2017-04-20 Thread Myungho Jung
Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung --- Changes in v2: - Correct category in subject net/core/dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/n

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-20 Thread Gavin Shan
On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >From: Gavin Shan >Date: Tue, 18 Apr 2017 16:51:32 +1000 > >> This creates /sys/kernel/debug/ncsi//stats to dump the NCSI >> packets sent and received over all packages and channels. It's useful >> to diagnose NCSI problems, especially

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

2017-04-20 Thread Martin KaFai Lau
On Thu, Apr 20, 2017 at 04:43:03PM -0600, David Ahern wrote: > On 4/20/17 4:39 PM, Cong Wang wrote: > > On Wed, Apr 19, 2017 at 2:19 PM, David Ahern > > wrote: > >> > >> Fix by checking for the flag and failing with EINVAL. > >> > > > > I am still not sure about this. There are a few unused bits

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

2017-04-20 Thread Cong Wang
On Thu, Apr 20, 2017 at 3:43 PM, David Ahern wrote: > > I scanned the others. It is not clear that others should fail with > EINVAL. Certainly a mask of unused flags can be added, but to me that is > on top of this bug fix. > If we want to preserve those unused bits, we should reject them too. R

[net-next 6/7] igb: Enable reading of wake up packet

2017-04-20 Thread Jeff Kirsher
From: Kim Tatt Chuah Currently, in igb_resume(), igb driver ignores the Wake Up Status (WUS) and Wake Up Packet Memory (WUPM) registers. This patch enables the igb driver to read the WUPM if the controller was woken by a wake up packet that is not more than 128 bytes long (maximum WUPM size), the

[net-next 3/7] e1000e: fix timing for 82579 Gigabit Ethernet controller

2017-04-20 Thread Jeff Kirsher
From: Bernd Faust After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel upgrade. The difference is that after the upgrade the driver sets

[net-next 4/7] igb: improve MAC filter handling

2017-04-20 Thread Jeff Kirsher
From: Yury Kylulin Using the work which was done for ixgbe driver by Jacob Keller commit 5d7daa35b9eb ("ixgbe: improve mac filter handling") and Alexander Duyck commit 0f079d22834a ("ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses") and out-of-tree igb driver add functionality

[net-next 0/7][pull request] 1GbE Intel Wired LAN Driver Updates 2017-04-20

2017-04-20 Thread Jeff Kirsher
This series contains updates to e1000, e1000e, igb/vf and ixgb. Tobias Klauser cleans up e1000, ixgb and igbvf from having a local function or structure for netdev stats. Bernd Faust fixes an issue for 82579 devices, where the clock frequency was being incorrectly set for these devices. These de

[net-next 1/7] e1000: Omit private ndo_get_stats function

2017-04-20 Thread Jeff Kirsher
From: Tobias Klauser e1000_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/e1000/e1000_main.c |

[net-next 7/7] igbvf: Use net_device_stats from struct net_device

2017-04-20 Thread Jeff Kirsher
From: Tobias Klauser Instead of using a private copy of struct net_device_stats in struct igbvf_adapter, use stats from struct net_device. Also remove the now unnecessary .ndo_get_stats function. Signed-off-by: Tobias Klauser Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net

[net-next 2/7] ixgb: Omit private ndo_get_stats function

2017-04-20 Thread Jeff Kirsher
From: Tobias Klauser ixgb_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 16

[net-next 5/7] igb/igbvf: Add VF MAC filter request capabilities

2017-04-20 Thread Jeff Kirsher
From: Yury Kylulin Add functionality for the VF to request up to 3 additional MAC filters. This is done using existing E1000_VF_SET_MAC_ADDR message, but with additional message info - E1000_VF_MAC_FILTER_CLR to clear all unicast MAC filters previously set for this VF and E1000_VF_MAC_FILTER_ADD

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

2017-04-20 Thread Greg Rose
On Thu, 2017-04-20 at 16:23 -0700, Myungho Jung wrote: > On Thu, Apr 20, 2017 at 04:03:43PM -0700, Greg Rose wrote: > > On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > > > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > > > family of functions. > > > > > > Link: https

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

2017-04-20 Thread Myungho Jung
On Thu, Apr 20, 2017 at 04:03:43PM -0700, Greg Rose wrote: > On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > > family of functions. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 > > > > Signed-off-b

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vlad Yasevich
On 04/20/2017 06:31 PM, Alexander Duyck wrote: > On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting situation when the software >>

Re: more on FP operations

2017-04-20 Thread Alexei Starovoitov
On Thu, Apr 20, 2017 at 11:52:44PM +0200, Daniel Borkmann wrote: > On 04/20/2017 08:06 PM, David Miller wrote: > > > >I'm running test_verifier for testing, and I notice in my JIT that a > >32-bit move from the frame pointer (BPF_REG_10) ends up in the JIT. > > > >It is from this test: > > > >

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

2017-04-20 Thread Greg Rose
On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > family of functions. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 > > Signed-off-by: Myungho Jung Hi, I think the patch is fine but I'm confused by the

[PATCH v2] netpoll: Check for skb->queue_mapping

2017-04-20 Thread Tushar Dave
Reducing real_num_tx_queues needs to be in sync with skb queue_mapping otherwise skbs with queue_mapping greater than real_num_tx_queues can be sent to the underlying driver and can result in kernel panic. One such event is running netconsole and enabling VF on the same device. Or running netconso

Re: [PATCH] Fix values type used in test_maps

2017-04-20 Thread Alexei Starovoitov
On Thu, Apr 20, 2017 at 11:24:53PM +0200, Daniel Borkmann wrote: > On 04/20/2017 09:20 PM, David Miller wrote: > > > >Maps of per-cpu type have their value element size adjusted to 8 if it > >is specified smaller during various map operations. > > > >This makes test_maps as a 32-bit binary fail, in

[PATCH net-next] net: dsa: Remove redundant NULL dst check

2017-04-20 Thread Florian Fainelli
tag_lan9303.c does check for a NULL dst but that's already checked by dsa_switch_rcv() one layer above. Signed-off-by: Florian Fainelli --- net/dsa/tag_lan9303.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c index 563b6c8fe445..70130ed5c21a

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

2017-04-20 Thread David Ahern
On 4/20/17 4:39 PM, Cong Wang wrote: > On Wed, Apr 19, 2017 at 2:19 PM, David Ahern wrote: >> >> Fix by checking for the flag and failing with EINVAL. >> > > I am still not sure about this. There are a few unused bits in > this flag, we simply ignore the rest, right? Why should we > reject this o

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

2017-04-20 Thread Cong Wang
On Wed, Apr 19, 2017 at 2:19 PM, David Ahern wrote: > > Fix by checking for the flag and failing with EINVAL. > I am still not sure about this. There are a few unused bits in this flag, we simply ignore the rest, right? Why should we reject this one instead of all of those we don't use?

Re: [PATCH net-next v8 2/3] Add a eBPF helper function to retrieve socket uid

2017-04-20 Thread Mickaël Salaün
On 23/03/2017 01:27, Chenbo Feng wrote: > From: Chenbo Feng > > Returns the owner uid of the socket inside a sk_buff. This is useful to > perform per-UID accounting of network traffic or per-UID packet > filtering. The socket need to be a fullsock otherwise overflowuid is > returned. > > Signed

Re: [PATCH net-next 0/3] l3mdev: Improve use with main table

2017-04-20 Thread David Ahern
On 4/10/17 8:21 AM, Robert Shearman wrote: > Attempting to create a TCP socket not bound to a VRF device when a TCP > socket bound to a VRF device with the same port exists (and vice > versa) fails with EADDRINUSE. This limits the ability to use programs > in selected mixed VRF/non-VRF contexts. >

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Alexander Duyck
On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich wrote: > While hardware device use either NETIF_F_(IP|IPV6)_CSUM or > NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. > This results in an interesting situation when the software > device is configured on top of hw device using (IP|IPV

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Williams, Mitch A
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of David Miller > Sent: Thursday, April 20, 2017 8:20 AM > To: yuval.mi...@cavium.com > Cc: gerlitz...@gmail.com; Kirsher, Jeffrey T ; > Williams, Mitch A ; netdev@vger.kernel.org;

Re: [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check

2017-04-20 Thread David Ahern
On 4/20/17 6:58 AM, Robert Shearman wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index acd69cfe2951..f667783ffd19 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2125,6 +2125,14 @@ static struct rtable *__mkroute_output(const struct > fib_result *res, >

Re: [PATCH v4 net-next RFC] net: Generic XDP

2017-04-20 Thread Andy Gospodarek
On Wed, Apr 19, 2017 at 09:40:49PM -0400, David Miller wrote: > From: Andy Gospodarek > Date: Wed, 19 Apr 2017 10:29:03 -0400 > > > So I tried a variety of things and the simplest change on top of yours that > > works well for xdp1, xdp2, and xdp_tx_iptunnel. > > > > diff --git a/net/core/dev.c

Re: [PATCH 1/1] bonding: use 'M' or 'G' based on the speed

2017-04-20 Thread Stephen Hemminger
On Thu, 20 Apr 2017 05:06:35 -0400 Zhu Yanjun wrote: > If the speed of the slave netdev is more than 1000M, > it is better to use 'G' instead of 'M'. > > Signed-off-by: Zhu Yanjun > --- > drivers/net/bonding/bond_main.c | 8 ++-- > drivers/net/bonding/bond_procfs.c | 6 +- > 2 files

Re: more on FP operations

2017-04-20 Thread Daniel Borkmann
On 04/20/2017 08:06 PM, David Miller wrote: I'm running test_verifier for testing, and I notice in my JIT that a 32-bit move from the frame pointer (BPF_REG_10) ends up in the JIT. It is from this test: "unpriv: partial copy of pointer", .insns = {

Re: net/xfrm: stack-out-of-bounds in xfrm_state_find

2017-04-20 Thread Sabrina Dubroca
2017-04-20, 19:30:27 +0200, Andrey Konovalov wrote: > On Thu, Apr 20, 2017 at 6:47 PM, Andrey Konovalov > wrote: > > Hi, > > > > I've got the following error report while fuzzing the kernel with syzkaller. > > > > On linux-next commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (4.11-rc7). > > > > A

[PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

2017-04-20 Thread Wei Wang
From: Wei Wang Christoph Paasch from Apple found another firewall issue for TFO: After successful 3WHS using TFO, server and client starts to exchange data. Afterwards, a 10s idle time occurs on this connection. After that, firewall starts to drop every packet on this connection. The fix for thi

[PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

2017-04-20 Thread Wei Wang
From: Wei Wang This counter records the number of times the firewall blackhole issue is detected and active TFO is disabled. Signed-off-by: Wei Wang --- include/net/tcp.h | 2 +- include/uapi/linux/snmp.h | 1 + net/ipv4/proc.c | 1 + net/ipv4/tcp_fastopen.c | 5 +++-- net/

Re: net/bonding: stack-out-of-bounds in bond_enslave

2017-04-20 Thread Cong Wang
On Thu, Apr 20, 2017 at 9:32 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On linux-next commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (4.11-rc7). > > A reproducer and .config are attached. > > =

[PATCH net-next 1/3] net/tcp_fastopen: Disable active side TFO in certain scenarios

2017-04-20 Thread Wei Wang
From: Wei Wang Middlebox firewall issues can potentially cause server's data being blackholed after a successful 3WHS using TFO. Following are the related reports from Apple: https://www.nanog.org/sites/default/files/Paasch_Network_Support.pdf Slide 31 identifies an issue where the client ACK to

[PATCH net-next 0/3] net/tcp_fastopen: Fix for various TFO firewall issues

2017-04-20 Thread Wei Wang
From: Wei Wang Currently there are still some firewall issues in the middlebox which make the middlebox drop packets silently for TFO sockets. This kind of issue is hard to be detected by the end client. This patch series tries to detect such issues in the kernel and disable TFO temporarily. Mor

Re: [PATCHv2 next] bonding: fix wq initialization for links created via netlink

2017-04-20 Thread Andy Gospodarek
On Thu, Apr 20, 2017 at 12:49:24PM -0700, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Earlier patch 4493b81bea ("bonding: initialize work-queues during > creation of bond") moved the work-queue initialization from bond_open() > to bond_create(). However this caused the link those are creat

[GIT] [4.12] NFC update

2017-04-20 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.12. We have: - Improvements for the pn533 command queue handling and device registration order. - Removal of platform data for the pn544 and st21nfca drivers. - Additional device tree options to support more trf7970a hardware options. - Support for S

Re: [PATCH] dp83640: don't recieve time stamps twice

2017-04-20 Thread Richard Cochran
On Thu, Apr 20, 2017 at 04:02:27PM -0400, David Miller wrote: > Oops, I read this too late. > > I already applied and pushed out Dan's fix. No problem, i'll submit a patch on top of that to move the netif calls out of the spin-locked regions. Thanks, Richard

Re: [PATCH] Fix values type used in test_maps

2017-04-20 Thread Daniel Borkmann
On 04/20/2017 09:20 PM, David Miller wrote: Maps of per-cpu type have their value element size adjusted to 8 if it is specified smaller during various map operations. This makes test_maps as a 32-bit binary fail, in fact the kernel writes past the end of the value's array on the user's stack.

Order

2017-04-20 Thread Damian Colins
Hi , I would like to place an order for some items which I want to know the below : Do you ship to Liechtenstein ? Do you accept Credit Card payment Also send me your current product price list. Thanks

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:50:55 + > Nope, I don't mind doing the work. What I would appreciate is some > constructive suggestions on a seemingly feasible approach that might work. > I feel like I've been bashed enough for one day. :-) Well, it seems like the thing that y

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> > I surely wouldn't want to write a million lines of code just to > > provide such a detailed abstraction. > > So now the argument has gone from "it's not possible" to "it's going to be a > HUGE amount of code." Nothing here's is strictly impossible - you can always create a simulated HW model

Re: [PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

2017-04-20 Thread Doug Ledford
On Thu, 2017-04-20 at 21:49 +0300, Leon Romanovsky wrote: > On Thu, Apr 20, 2017 at 02:41:17PM -0400, Doug Ledford wrote: > > > > On Mon, 2017-04-17 at 11:08 -0400, David Miller wrote: > > > > > > From: Saeed Mahameed > > > Date: Thu, 13 Apr 2017 06:36:50 +0300 > > > > > > > > > > > This serie

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-20 Thread David Miller
From: David Woodhouse Date: Thu, 20 Apr 2017 21:14:37 +0100 > I agree, except I don't think you're going far enough. Those "standard > names" you mention... some of this stuff actually depends on __GLIBC__, > and *that* isn't right either. Yep, that's something that needs correcting.

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:12:59 + > I surely wouldn't want to write a million lines of code just to > provide such a detailed abstraction. So now the argument has gone from "it's not possible" to "it's going to be a HUGE amount of code." I wonder what the next argument

Re: [PATCH v3 net] net sched actions: allocate act cookie early

2017-04-20 Thread David Miller
From: Wolfgang Bumiller Date: Thu, 20 Apr 2017 14:08:26 +0200 > Policing filters do not use the TCA_ACT_* enum and the tb[] > nlattr array in tcf_action_init_1() doesn't get filled for > them so we should not try to look for a TCA_ACT_COOKIE > attribute in the then uninitialized array. > The erro

Re: [PATCH net 0/4] qed: Dcbx bug fixes

2017-04-20 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 19 Apr 2017 03:19:51 -0700 > The series has set of bug fixes for dcbx implementation of qed driver. > Please consider applying this to 'net' branch. Series applied, thanks.

Re: [PATCH net-next] net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()

2017-04-20 Thread David Miller
From: Dan Carpenter Date: Wed, 19 Apr 2017 12:59:15 +0300 > The labels were out of order, so it either could result in an Oops or a > leak. > > Fixes: 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton") > Signed-off-by: Dan Carpenter Applied.

  1   2   3   4   >