On 4/20/17 4:39 PM, Cong Wang wrote: > On Wed, Apr 19, 2017 at 2:19 PM, David Ahern <[email protected]> wrote: >> >> Fix by checking for the flag and failing with EINVAL. >> > > I am still not sure about this. There are a few unused bits in > this flag, we simply ignore the rest, right? Why should we > reject this one instead of all of those we don't use? >
RTF_PCPU most definitely should not be set by userspace. arguably it should not be returned to userspace either, but it is part of the uapi. I scanned the others. It is not clear that others should fail with EINVAL. Certainly a mask of unused flags can be added, but to me that is on top of this bug fix.
