Re: [PATCH v6 03/15] IB/mthca: Replace PCI pool old API

2017-03-24 Thread Doug Ledford
On Sun, 2017-03-19 at 18:03 +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin > Tested-by: Peter Senna Tschudin >  Change

[PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling

2017-03-24 Thread kys
From: K. Y. Srinivasan All netvsc channels are handled via NAPI. Setup the "read mode" correctly for the netvsc sub-channels. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/rndis_filter.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/hyperv/rn

[PATCH net-next 2/2] netvsc: Properly initialize the return value

2017-03-24 Thread kys
From: K. Y. Srinivasan Initialize the return value correctly. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index eb7ae79..f830bbb 1

[PATCH net-next 0/2] netvsc: Fix miscellaneous issues

2017-03-24 Thread kys
From: K. Y. Srinivasan Fix miscellaneous issues. K. Y. Srinivasan (2): netvsc: Fix a bug in sub-channel handling netvsc: Properly initialize the return value drivers/net/hyperv/netvsc_drv.c |2 +- drivers/net/hyperv/rndis_filter.c |5 + 2 files changed, 6 insertions(+), 1 del

Re: [PATCH net] bpf: improve verifier packet range checks

2017-03-24 Thread David Miller
From: Alexei Starovoitov Date: Fri, 24 Mar 2017 15:57:33 -0700 > llvm can optimize the 'if (ptr > data_end)' checks to be in the order > slightly different than the original C code which will confuse verifier. > Like: > if (ptr + 16 > data_end) > return TC_ACT_SHOT; > // may be followed by > if

Re: [PATCH v2 net] ping: implement proper locking

2017-03-24 Thread David Miller
From: Eric Dumazet Date: Fri, 24 Mar 2017 19:36:13 -0700 > From: Eric Dumazet > > We got a report of yet another bug in ping > > http://www.openwall.com/lists/oss-security/2017/03/24/6 > > ->disconnect() is not called with socket lock held. > > Fix this by acquiring ping rwlock earlier. > >

Re: [net-next PATCH v3 0/8] Add busy poll support for epoll

2017-03-24 Thread David Miller
From: Alexander Duyck Date: Fri, 24 Mar 2017 10:07:47 -0700 > This patch set adds support for using busy polling with epoll. Series applied, thanks!

Re: [PATCH v6 06/15] mlx5: Replace PCI pool old API

2017-03-24 Thread Doug Ledford
On Mon, 2017-03-20 at 08:31 +0200, Leon Romanovsky wrote: > On Sun, Mar 19, 2017 at 06:03:55PM +0100, Romain Perier wrote: > > > > The PCI pool API is deprecated. This commit replaces the PCI pool > > old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain Per

Re: [net-next PATCH v3 5/8] net: Track start of busy loop instead of when it should end

2017-03-24 Thread Eric Dumazet
On Fri, 2017-03-24 at 10:08 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch flips the logic we were using to determine if the busy polling > has timed out. The main motivation for this is that we will need to > support two different possible timeout values in the future and

Re: [net-next PATCH v3 7/8] epoll: Add busy poll support to epoll with socket fds.

2017-03-24 Thread Eric Dumazet
On Fri, 2017-03-24 at 10:08 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > This patch adds busy poll support to epoll. The implementation is meant to > be opportunistic in that it will take the NAPI ID from the last socket > that is added to the ready list that contains a valid NAPI

RE: [PATCH net-next 1/1] tcp: sysctl: Fix a race to avoid unexpected 0 window from space

2017-03-24 Thread Gao Feng
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Stephen Hemminger > Sent: Saturday, March 25, 2017 4:32 AM > To: gfree.w...@foxmail.com > Cc: da...@davemloft.net; netdev@vger.kernel.org; Gao Feng > > Subject: Re: [PATCH net-nex

[PATCH v2 net] ping: implement proper locking

2017-03-24 Thread Eric Dumazet
From: Eric Dumazet We got a report of yet another bug in ping http://www.openwall.com/lists/oss-security/2017/03/24/6 ->disconnect() is not called with socket lock held. Fix this by acquiring ping rwlock earlier. Thanks to Daniel, Alexander and Andrey for letting us know this problem. Fixes:

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Eric Dumazet
On Fri, Mar 24, 2017 at 7:10 PM, David Miller wrote: > > > Eric, please add a proper signoff for yourself, and also please > add the following tag: > > Reported-by: Daniel Jiang Oh right, will send a v2 immediately. Thanks.

Re: [net 1/1] i40e: Do not enable NAPI on q_vectors that have no rings

2017-03-24 Thread David Miller
From: Jeff Kirsher Date: Fri, 24 Mar 2017 15:01:42 -0700 > From: Alexander Duyck > > When testing the epoll w/ busy poll code I found that I could get into a > state where the i40e driver had q_vectors w/ active NAPI that had no rings. > This was resulting in a divide by zero error. To correct

Re: [PATCH net] secure_seq: downgrade to per-host timestamp offsets

2017-03-24 Thread David Miller
From: Florian Westphal Date: Fri, 24 Mar 2017 19:42:37 +0100 > Unfortunately too many devices (not under our control) use tcp_tw_recycle=1, > which depends on timestamps being identical of the same saddr. > > Although tcp_tw_recycle got removed in net-next we can't make > such end hosts disappea

Re: [net-next PATCH v3 0/8] Add busy poll support for epoll

2017-03-24 Thread David Miller
From: Alexander Duyck Date: Fri, 24 Mar 2017 10:07:47 -0700 > v3: Split off the code for limiting busy_poll and busy_read into a separate > patch for net. > Updated patch that changed busy loop time tracking so that it uses > "local_clock() >> 10" as we originally did. > Tweaked "

RE: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Gao Feng
> -Original Message- > From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > Sent: Saturday, March 25, 2017 3:02 AM > To: f...@ikuai8.com > Cc: da...@davemloft.net; jo...@redhat.com; netfilter-de...@vger.kernel.org; > netdev@vger.kernel.org; gfree.w...@gmail.com > Subject: Re: [PATCH nf v3

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

2017-03-24 Thread David Miller
From: Saeed Mahameed Date: Sat, 25 Mar 2017 00:52:02 +0300 > This series provides some preformancee optimizations for mlx5e > driver, especially for XDP TX flows. This looks really great, series applied, thanks!

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread David Miller
From: Eric Dumazet Date: Fri, 24 Mar 2017 16:29:45 -0700 > From: Eric Dumazet > > We got a report of yet another bug in ping > > http://www.openwall.com/lists/oss-security/2017/03/24/6 > > ->disconnect() is not called with socket lock held. > > Fix this by acquiring ping rwlock earlier. > >

Re: [PATCH] IB/rxe: increment msn only when completing a request

2017-03-24 Thread Doug Ledford
On Fri, 2017-02-24 at 15:38 +0100, David Marchand wrote: > According to C9-147, MSN should only be incremented when the last > packet of > a multi packet request has been received. > > "Logically, the requester associates a sequential Send Sequence > Number > (SSN) with each WQE posted to the send

Re: [PATCH] uapi: fix rdma/mlx5-abi.h userspace compilation errors

2017-03-24 Thread Doug Ledford
On Fri, 2017-02-24 at 03:28 +0300, Dmitry V. Levin wrote: > Consistently use types from linux/types.h to fix the following > rdma/mlx5-abi.h userspace compilation errors: > > /usr/include/rdma/mlx5-abi.h:69:25: error: 'u64' undeclared here (not > in a function) >   MLX5_LIB_CAP_4K_UAR = (u64)1 <<

Re: [PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread Ben Greear
On 03/24/2017 04:14 PM, Stephen Hemminger wrote: On Fri, 24 Mar 2017 14:20:56 -0700 Ben Greear wrote: On 03/24/2017 02:12 PM, David Miller wrote: From: gree...@candelatech.com Date: Fri, 24 Mar 2017 13:58:47 -0700 From: Ben Greear In systems where you may have a very large number of net

[PATCH] cfg80211: Fix array-bounds warning in fragment copy

2017-03-24 Thread Matthias Kaehlcke
__ieee80211_amsdu_copy_frag intentionally initializes a pointer to array[-1] to increment it later to valid values. clang rightfully generates an array-bounds warning on the initialization statement. Work around this by initializing the pointer to array[0] and decrementing it later, which allows to

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Subash Abhinov Kasiviswanathan
(re-sending from an address that's actually subscribed to netdev@...) The first thing that jumps out at me is "why isn't this using rtnl_link_ops?" To me (and perhaps I'm completely wrong) the structure here is a lot like VLAN interfaces.  You have a base device (whether that's a netdev or not)

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Xose Vazquez Perez
Solar Designer wrote: > We should credit the original reporter, who most likely found this by > fuzzing. It's danieljiang0415 on GitHub and Twitter. Unfortunately, I > don't know their e-mail address. I'll try asking. Daniel Jiang

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Solar Designer
On Fri, Mar 24, 2017 at 04:29:45PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > We got a report of yet another bug in ping > > http://www.openwall.com/lists/oss-security/2017/03/24/6 > > ->disconnect() is not called with socket lock held. > > Fix this by acquiring ping rwlock earlier. >

Re: [oss-security] Linux kernel ping socket / AF_LLC connect() sin_family race

2017-03-24 Thread Solar Designer
On Fri, Mar 24, 2017 at 03:21:06PM -0700, Eric Dumazet wrote: > Looks easy enough to fix ? Oh. Probably. Thanks. Need to test, but I guess you already did? > diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c > index > 2af6244b83e27ae384e96cf071c10c5a89674804..ccfbce13a6333a65dab64e4847dd510dfafb1

Re: [PATCHv2 net-next 2/7] sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter

2017-03-24 Thread Marcelo Ricardo Leitner
On Tue, Mar 21, 2017 at 01:44:32PM +0800, Xin Long wrote: > On Tue, Mar 21, 2017 at 2:04 AM, Marcelo Ricardo Leitner > wrote: > > On Fri, Mar 10, 2017 at 12:11:07PM +0800, Xin Long wrote: > >> This patch is to implement Receiver-Side Procedures for the SSN/TSN > >> Reset Request Parameter describe

[PATCH net] ping: implement proper locking

2017-03-24 Thread Eric Dumazet
From: Eric Dumazet We got a report of yet another bug in ping http://www.openwall.com/lists/oss-security/2017/03/24/6 ->disconnect() is not called with socket lock held. Fix this by acquiring ping rwlock earlier. Thanks to Alexander and Andrey for letting us know of this problem. Fixes: c319

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

2017-03-24 Thread Alexei Starovoitov
On 3/24/17 2:52 PM, Saeed Mahameed wrote: Hi Dave, This series provides some preformancee optimizations for mlx5e driver, especially for XDP TX flows. 1st patch is a simple change of rmb to dma_rmb in CQE fetch routine which shows a huge gain for both RX and TX packet rates. 2nd patch removes

Re: EINVAL when using connect() for udp sockets

2017-03-24 Thread Eric Dumazet
On Fri, 2017-03-24 at 15:34 -0700, Cong Wang wrote: > (Cc'ing Michael Kerrisk) > > On Wed, Mar 22, 2017 at 10:18 PM, Eric Dumazet wrote: > > On Thu, 2017-03-23 at 13:22 +1100, Daurnimator wrote: > >> On 9 March 2017 at 14:10, Daurnimator wrote: > >> > When debugging https://github.com/daurnimato

Re: [PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2017 14:20:56 -0700 Ben Greear wrote: > On 03/24/2017 02:12 PM, David Miller wrote: > > From: gree...@candelatech.com > > Date: Fri, 24 Mar 2017 13:58:47 -0700 > > > >> From: Ben Greear > >> > >> In systems where you may have a very large number of network > >> adapters, certain

[PATCH net] bpf: improve verifier packet range checks

2017-03-24 Thread Alexei Starovoitov
llvm can optimize the 'if (ptr > data_end)' checks to be in the order slightly different than the original C code which will confuse verifier. Like: if (ptr + 16 > data_end) return TC_ACT_SHOT; // may be followed by if (ptr + 14 > data_end) return TC_ACT_SHOT; while llvm can see that 'ptr' is v

[PATCH] irda: vlsi_ir: fix check for dma mapping errors

2017-03-24 Thread Alexey Khoroshilov
vlsi_alloc_ring() checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/irda/vlsi_ir.c | 8 1 file changed, 4

Re: EINVAL when using connect() for udp sockets

2017-03-24 Thread Cong Wang
(Cc'ing Michael Kerrisk) On Wed, Mar 22, 2017 at 10:18 PM, Eric Dumazet wrote: > On Thu, 2017-03-23 at 13:22 +1100, Daurnimator wrote: >> On 9 March 2017 at 14:10, Daurnimator wrote: >> > When debugging https://github.com/daurnimator/lua-http/issues/73 which >> > uses https://github.com/wahern/d

[PATCH net-next v5 2/2] gtp: support SGSN-side tunnels

2017-03-24 Thread Jonas Bonn
The GTP-tunnel driver is explicitly GGSN-side as it searches for PDP contexts based on the incoming packets _destination_ address. If we want to place ourselves on the SGSN side of the tunnel, then we want to be identifying PDP contexts based on _source_ address. Let it be noted that in a "real"

[PATCH net-next v5 1/2] gtp: rename SGSN netlink attribute

2017-03-24 Thread Jonas Bonn
This is a mostly cosmetic rename of the SGSN netlink attribute to the GTP link. The justification for this is that we will be making the module support decapsulation of "downstream" SGSN packets, in which case the netlink parameter actually refers to the upstream GGSN peer. Renaming the parameter

[PATCH net-next v5 0/2] GTP SGSN-side tunnel

2017-03-24 Thread Jonas Bonn
Changes since v4: * Respin the series on top of net-next; the conflicts were trivial, amounting to just code having been shifted about Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 64 --

[PATCH net-next 1/2] net: mpls: Don't show nexthop if device has been deleted

2017-03-24 Thread David Ahern
If the device for a nexthop in a multipath route is deleted, the nexthop is effectively removed from the route. Currently, a route dump still returns the nexhop though without the device set: $ ip -f mpls ro ls 100 nexthopvia inet 10.11.1.2 dev br0 nexthopvia inet 10.100.3.1 dev

[PATCH net-next 0/2] net: mpls: multipath route cleanups

2017-03-24 Thread David Ahern
When a device associated with a nexthop is deleted, the nexthop in the route is effectively removed, so remove it from the route dump. Further, when all nexhops have been deleted the route is effectively done, so remove the route. David Ahern (2): mpls: Don't show nexthop if device has been de

[PATCH net-next 2/2] net: mpls: Delete route when all nexthops have been deleted

2017-03-24 Thread David Ahern
When all devices for all nexthops in a route have been deleted, the route is effectively dead, so remove it. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 3861f8dfa9c1..7

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Dan Williams
On Mon, 2017-03-13 at 01:43 -0600, Subash Abhinov Kasiviswanathan wrote: > RmNet Data driver provides a transport agnostic MAP (multiplexing and > aggregation protocol) support in embedded and bridge modes. Module > provides virtual network devices which can be attached to any IP-mode > physical de

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Dan Williams
On Mon, 2017-03-13 at 01:43 -0600, Subash Abhinov Kasiviswanathan wrote: > RmNet Data driver provides a transport agnostic MAP (multiplexing and > aggregation protocol) support in embedded and bridge modes. Module > provides virtual network devices which can be attached to any IP-mode > physical de

RE: [PATCH net-next] ixgb: Omit private ndo_get_stats function

2017-03-24 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Tobias Klauser > Sent: Wednesday, February 15, 2017 3:08 AM > To: netdev@vger.kernel.org > Cc: Kirsher, Jeffrey T ; intel-wired- > l...@lists.osuosl.org; Joe Perches > Subject: [PATCH net-next] ixgb: Omit pr

[RESEND PATCH 3/3] infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data

2017-03-24 Thread Arnd Bergmann
hns_roce_v1_cq_set_ci() calls roce_set_bit() on an uninitialized field, which will then change only a few of its bits, causing a warning with the latest gcc: infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_cq_set_ci': infiniband/hw/hns/hns_roce_hw_v1.c:1854:23: error: 'doorbell[1]' is

[net 1/1] i40e: Do not enable NAPI on q_vectors that have no rings

2017-03-24 Thread Jeff Kirsher
From: Alexander Duyck When testing the epoll w/ busy poll code I found that I could get into a state where the i40e driver had q_vectors w/ active NAPI that had no rings. This was resulting in a divide by zero error. To correct it I am updating the driver code so that we only support NAPI on q_v

[RESEND PATCH 2/3] net: hns: avoid gcc-7.0.1 warning for uninitialized data

2017-03-24 Thread Arnd Bergmann
hns_dsaf_set_mac_key() calls dsaf_set_field() on an uninitialized field, which will then change only a few of its bits, causing a warning with the latest gcc: hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_mac_uc_entry': hisilicon/hns/hns_dsaf_reg.h:1046:12: error: 'mac_key.low.bits.port

[PATCH net-next] net: dsa: bcm_sf2: Add missing OF_MDIO dependency

2017-03-24 Thread Florian Fainelli
bcm_sf2 does require the MDIO_BCM_UNIMAC driver which is now dependent on OF_MDIO but also internally uses of_mdio.c provided routines which are guarted with OF_MDIO. Reported-by: kbuild test robot Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") Signed-off-by:

[RESEND PATCH 0/3] hisilicon hns warning fixes for gcc-7.0.1

2017-03-24 Thread Arnd Bergmann
Building with gcc-7 found three new warnings in the hns ethernet and rdma drivers. Only one of them appears to be an actual bug, the other two are variations of a single problem, but are unfortunately part of different subsystems. I'm resending all three patches to both the ethernet and the rdma m

[RESEND PATCH 1/3] net: hns: fix uninitialized data use

2017-03-24 Thread Arnd Bergmann
When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1 now points out: ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_promisc_tcam': ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.low.val' may be used uninitialized in this function [-Werror=

Re: [net PATCH] net: Do not allow negative values for busy_read and busy_poll sysctl interfaces

2017-03-24 Thread David Miller
From: Alexander Duyck Date: Fri, 24 Mar 2017 09:38:03 -0700 > From: Alexander Duyck > > This change basically codifies what I think was already the limitations on > the busy_poll and busy_read sysctl interfaces. We weren't checking the > lower bounds and as such could input negative values. Th

[PATCH net-next 03/12] net/mlx5e: Single bfreg (UAR) for all mlx5e SQs and netdevs

2017-03-24 Thread Saeed Mahameed
One is sufficient since Blue Flame is not supported anymore. This will also come in handy for switchdev mode to save resources, since VF representors will use same single UAR as well for their own SQs. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

2017-03-24 Thread Saeed Mahameed
Hi Dave, This series provides some preformancee optimizations for mlx5e driver, especially for XDP TX flows. 1st patch is a simple change of rmb to dma_rmb in CQE fetch routine which shows a huge gain for both RX and TX packet rates. 2nd patch removes write combining logic from the driver TX han

[PATCH net-next 09/12] net/mlx5e: Generalize tx helper functions for different SQ types

2017-03-24 Thread Saeed Mahameed
In the next patches we will introduce different SQ types, for that we here generalize some TX helper functions to work with more basic SQ parameters, in order to re-use them for the different SQ types. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next 12/12] net/mlx5e: Different SQ types

2017-03-24 Thread Saeed Mahameed
Different SQ types (tx, xdp, ico) are growing apart, we separate them and remove unwanted parts in each one of them, to simplify data path and utilize data cache. Remove DB union from SQ structures since it is not needed anymore as we now have different SQ data type for each SQ. Signed-off-by: Sa

[PATCH net-next 02/12] net/mlx5e: Xmit, no write combining

2017-03-24 Thread Saeed Mahameed
mlx5e netdev Blue Flame (write combining) support demands a lot of overhead for a little latency gain for some special cases, this overhead is hurting the common case. Here we remove xmit Blue Flame support by creating all bfregs with no write combining for all SQs, and we remove a lot of BF logic

[PATCH net-next 05/12] net/mlx5e: Move mlx5e_rq struct declaration

2017-03-24 Thread Saeed Mahameed
Move struct mlx5e_rq and friends to appear after mlx5e_sq declaration in en.h. We will need this for next patch to move the mlx5e_sq instance into mlx5e_rq struct for XDP SQs. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 213 +++

[PATCH net-next 08/12] net/mlx5e: Optimize XDP frame xmit

2017-03-24 Thread Saeed Mahameed
XDP SQ has a fixed size WQE (MLX5E_XDP_TX_WQEBBS = 1) and only posts one kind of WQE (MLX5_OPCODE_SEND), Also we initialize SQ descriptors static fields once on open_xdpsq, rather than every time on critical path. Optimize the code in light of those facts and add a prefetch of the TX descriptor f

[PATCH net-next 07/12] net/mlx5e: Poll XDP TX CQ before RX CQ

2017-03-24 Thread Saeed Mahameed
Handle XDP TX completions before handling RX packets, to make sure more free space is available for XDP TX packets a moment before handling RX packets. Performance improvement: System: Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz Test case Before Now improvement ---

[PATCH net-next 11/12] net/mlx5e: Generalize SQ create/modify/destroy functions

2017-03-24 Thread Saeed Mahameed
In the next patches we will introduce different SQ types, and we would want to reuse those functions, in this patch we make them agnostic to SQ type (txq, xdp, ico). Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 111 +

[PATCH net-next 06/12] net/mlx5e: Move XDP SQ instance into RQ

2017-03-24 Thread Saeed Mahameed
To save many rq->channel->sq dereferences in fast-path. And rename it to xdpsq. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 +++- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 12 ++-- drivers/net/ethernet/mell

Re: [net-next:master 566/583] warning: (NET_DSA_BCM_SF2) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && ..)

2017-03-24 Thread Florian Fainelli
On 03/24/2017 02:47 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: ff41c7fa64854cc95a472d43af82c17c043aa757 > commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 [566/583] net: phy: Allow > splitting MDIO bus/device suppor

[PATCH net-next 01/12] net/mlx5e: Use dma_rmb rather than rmb in CQE fetch routine

2017-03-24 Thread Saeed Mahameed
Use dma_rmb in mlx5e_get_cqe rather than aggressive rmb (at least on some architectures), this should help improve the performance on such CPU archs where dma_rmb is optimized. Performance improvement: System: Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz Test case Baseline Now

[PATCH net-next 10/12] net/mlx5e: Proper names for SQ/RQ/CQ functions

2017-03-24 Thread Saeed Mahameed
Rename mlx5e_{create,destroy}_{sq,rq,cq} to mlx5e_{alloc,free}_{sq,rq,cq}. Rename mlx5e_{enable,disable}_{sq,rq,cq} to mlx5e_{create,destroy}_{sq,rq,cq}. mlx5e_{enable,disable}_{sq,rq,cq} used to actually create/destroy the SQ in FW, so we rename them to align the functions names with FW semantic

[PATCH net-next 04/12] net/mlx5e: Move XDP completion functions to rx file

2017-03-24 Thread Saeed Mahameed
XDP code belongs to RX path, move mlx5e_poll_xdp_tx_cq and mlx5e_free_xdp_tx_descs to en_rx.c. Rename them to mlx5e_poll_xdpsq_cq and mlx5e_free_xdpsq_descs. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 + drivers/net/ethern

Re: [PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread David Miller
From: Ben Greear Date: Fri, 24 Mar 2017 14:20:56 -0700 > On 03/24/2017 02:12 PM, David Miller wrote: >> From: gree...@candelatech.com >> Date: Fri, 24 Mar 2017 13:58:47 -0700 >> >>> From: Ben Greear >>> >>> In systems where you may have a very large number of network >>> adapters, certain driver

[net-next:master 566/583] warning: (NET_DSA_BCM_SF2) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && ..)

2017-03-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: ff41c7fa64854cc95a472d43af82c17c043aa757 commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 [566/583] net: phy: Allow splitting MDIO bus/device support from PHYs config: x86_64-randconfig-x009-201712 (attached

Re: [PATCH net-next 0/2] Performances improvement for IPv6 Segment Routing

2017-03-24 Thread David Miller
From: David Lebrun Date: Fri, 24 Mar 2017 10:46:25 +0100 > This patch series improves the performances of IPv6 SR by optimizing skb head > reallocation and extending the use of dst_cache. The overall performances > improve > by 35%. Series applied, thanks. I think you should make SEG6_IPTUNNEL

Re: [PATCH] net_sched: use setup_deferrable_timer

2017-03-24 Thread David Miller
From: Geliang Tang Date: Fri, 24 Mar 2017 22:14:36 +0800 > Use setup_deferrable_timer() instead of init_timer_deferrable() to > simplify the code. > > Signed-off-by: Geliang Tang Applied, thanks.

Re: [PATCH net-next v4 0/2] GTP SGSN-side tunnels

2017-03-24 Thread David Miller
From: Jonas Bonn Date: Fri, 24 Mar 2017 14:56:26 +0100 > Changes from v3: > > * Coding style fixup: remove extraneous braces on if-statement > * Ack from Harald These patches do not apply cleanly to the net-next tree, please respin. Thanks.

Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2

2017-03-24 Thread David Ahern
On 3/24/17 3:11 PM, David Miller wrote: > I did a merge yesterday, so I am not likely to do another for about a week. hmmm some how I missed it. That merge has what I need.

Re: Problem: net: mvneta: auto-negotiation with disconnected network cable

2017-03-24 Thread Stas Sergeev
24.03.2017 17:39, Maxime Morin пишет: I did a "git bisect" to find when the regression was introduced, because it previously worked with kernel 4.4, but not with the recent ones. The commit that made appear the issue is this one: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g

Re: [PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread Ben Greear
On 03/24/2017 02:12 PM, David Miller wrote: From: gree...@candelatech.com Date: Fri, 24 Mar 2017 13:58:47 -0700 From: Ben Greear In systems where you may have a very large number of network adapters, certain drivers may consume an unfair amount of IRQ resources. So, allow a module param that

Re: [PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread David Miller
From: gree...@candelatech.com Date: Fri, 24 Mar 2017 13:58:47 -0700 > From: Ben Greear > > In systems where you may have a very large number of network > adapters, certain drivers may consume an unfair amount of > IRQ resources. So, allow a module param that will limit the > number of IRQs at d

Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2

2017-03-24 Thread David Miller
From: David Ahern Date: Fri, 24 Mar 2017 14:32:42 -0600 > On 3/24/17 2:29 PM, David Miller wrote: >> From: David Ahern >> Date: Thu, 23 Mar 2017 19:02:27 -0600 >> >>> Fix copy and paste error setting rt_ttl_propagate. >>> >>> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to b

[PATCH] igb: add module param to set max-rss-queues.

2017-03-24 Thread greearb
From: Ben Greear In systems where you may have a very large number of network adapters, certain drivers may consume an unfair amount of IRQ resources. So, allow a module param that will limit the number of IRQs at driver load time. This way, other drivers (40G Ethernet, for instance), which pro

Re: [patch net-next 0/5] mlxsw: Query resources from firmware

2017-03-24 Thread David Miller
From: Jiri Pirko Date: Fri, 24 Mar 2017 08:02:46 +0100 > From: Jiri Pirko > > Ido says: > > Some parts of the driver already use the resource query mechanism, but > in other parts we still rely on hard coded values that may change over > time. > > This patchset removes most of these remaining

Re: Performance issue with igb with lots of different src-ip addrs.

2017-03-24 Thread Ben Greear
On 03/16/2017 08:51 PM, Ben Greear wrote: I think we can, might take us a day or two to get time to do it. Thanks, Ben On 03/16/2017 08:05 PM, Alexander Duyck wrote: I'm not really interested in installing a custom version of pktgen. Any chance you can recreate the issue with standard pktgen?

Re: [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-23

2017-03-24 Thread David Miller
From: Jeff Kirsher Date: Thu, 23 Mar 2017 22:14:22 -0700 > This series contains updates to i40e and i40e.txt documentation. Pulled, thanks Jeff.

Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2

2017-03-24 Thread David Ahern
On 3/24/17 2:29 PM, David Miller wrote: > From: David Ahern > Date: Thu, 23 Mar 2017 19:02:27 -0600 > >> Fix copy and paste error setting rt_ttl_propagate. >> >> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be >> configured") >> Signed-off-by: David Ahern > > Applied. >

Re: [net] Revert "e1000e: driver trying to free already-free irq"

2017-03-24 Thread David Miller
From: Jeff Kirsher Date: Thu, 23 Mar 2017 20:47:15 -0700 > This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56. > > After additional regression testing, several users are experiencing > kernel panics during shutdown on e1000e devices. Reverting this > change resolves the issue. > > Si

Re: [oss-security] Linux kernel ping socket / AF_LLC connect() sin_family race

2017-03-24 Thread Andrey Konovalov
On Fri, Mar 24, 2017 at 9:27 PM, Solar Designer wrote: > Hi, > > I haven't fully investigated this issue, and the Subject is provisional > (but will probably get stuck). I am not yet sure which kernel > subsystem(s) to blame here (ping sockets? LLC sockets? other/more?), and > there might be othe

Re: [PATCH net-next 1/1] tcp: sysctl: Fix a race to avoid unexpected 0 window from space

2017-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2017 07:05:12 +0800 gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because sysctl_tcp_adv_win_scale could be changed any time, so there > is one race in tcp_win_from_space. > For example, > 1.sysctl_tcp_adv_win_scale<=0 (sysctl_tcp_adv_win_scale is negative now) > 2.space>>(-s

Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2

2017-03-24 Thread David Miller
From: David Ahern Date: Thu, 23 Mar 2017 19:02:27 -0600 > Fix copy and paste error setting rt_ttl_propagate. > > Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be > configured") > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next 1/1] tcp: sysctl: Fix a race to avoid unexpected 0 window from space

2017-03-24 Thread David Miller
From: gfree.w...@foxmail.com Date: Fri, 24 Mar 2017 07:05:12 +0800 > From: Gao Feng > > Because sysctl_tcp_adv_win_scale could be changed any time, so there > is one race in tcp_win_from_space. > For example, > 1.sysctl_tcp_adv_win_scale<=0 (sysctl_tcp_adv_win_scale is negative now) > 2.space>>(

Re: [PATCH] net: make in_aton() 32-bit internally

2017-03-24 Thread David Miller
From: Alexey Dobriyan Date: Fri, 24 Mar 2017 00:58:26 +0300 > Converting IPv4 address doesn't need 64-bit arithmetic. > > Space savings: 10 bytes! > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10) > function old new delta > in_aton

Re: [PATCH net-next v5] net: Add sysctl to toggle early demux for tcp and udp

2017-03-24 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Thu, 23 Mar 2017 13:34:16 -0600 > Certain system process significant unconnected UDP workload. > It would be preferrable to disable UDP early demux for those systems > and enable it for TCP only. > > By disabling UDP demux, we see these slight gains on

Re: [PATCH net-next] liquidio: do not reset Octeon if NIC firmware was preloaded

2017-03-24 Thread David Miller
From: Felix Manlunas Date: Thu, 23 Mar 2017 13:26:28 -0700 > The PF driver is incorrectly resetting Octeon when the module parameter > "fw_type=none" is there. "fw_type=none" means the PF should not load any > firmware to the NIC because Octeon is already running preloaded firmware. > > Fix it

Re: [Patch net] kcm: return immediately after copy_from_user() failure

2017-03-24 Thread David Miller
From: Cong Wang Date: Thu, 23 Mar 2017 11:03:31 -0700 > There is no reason to continue after a copy_from_user() > failure. > > Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module") > Cc: Tom Herbert > Signed-off-by: Cong Wang Applied and queued up for -stable and this bug could ma

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread Cong Wang
On Fri, Mar 24, 2017 at 12:46 PM, David Miller wrote: > From: Cong Wang > Date: Fri, 24 Mar 2017 10:59:15 -0700 > >> On Thu, Mar 23, 2017 at 9:02 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> sch_choke is classless qdisc so it does not define cl_ops. Therefore >>> filter_list cannot be eve

Re: [PATCH net-next 0/3] net: systemport: TX/NAPI improvements

2017-03-24 Thread David Miller
From: Florian Fainelli Date: Thu, 23 Mar 2017 10:36:45 -0700 > This patch series builds up on Doug's latest changes done in BCMGENET to > reduce > the number of spurious interrupts in NAPI, simplify pointer arithmetic and > finally tracking of per TX ring statistics to be SMP friendly. Series a

Re: [PATCH net-next v3 0/3] net: phy: Allow splitting MDIO bus/device support

2017-03-24 Thread David Miller
From: Florian Fainelli Date: Thu, 23 Mar 2017 10:01:16 -0700 > This patch series allows building support for MDIO bus controllers which > are sometimes usable and necessary in cases where there are no Ethernet PHYs. > > Changes in v3: > - corrected of_mdio compile guards for prototypes vs. stubs

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread David Miller
From: Jiri Pirko Date: Thu, 23 Mar 2017 17:02:16 +0100 > From: Jiri Pirko > > sch_choke is classless qdisc so it does not define cl_ops. Therefore > filter_list cannot be ever changed, being NULL all the time. > Reason is this check in tc_ctl_tfilter: > > /* Is it classful? */ > co

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread David Miller
From: Cong Wang Date: Fri, 24 Mar 2017 10:59:15 -0700 > On Thu, Mar 23, 2017 at 9:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> sch_choke is classless qdisc so it does not define cl_ops. Therefore >> filter_list cannot be ever changed, being NULL all the time. >> Reason is this check in tc

Re: [net PATCH] net: Do not allow negative values for busy_read and busy_poll sysctl interfaces

2017-03-24 Thread Eric Dumazet
On Fri, 2017-03-24 at 09:38 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This change basically codifies what I think was already the limitations on > the busy_poll and busy_read sysctl interfaces. We weren't checking the > lower bounds and as such could input negative values. The be

Re: [PATCH net 0/3] s390/qeth patches for net

2017-03-24 Thread David Miller
From: Ursula Braun Date: Thu, 23 Mar 2017 14:55:07 +0100 > here are 2 s390/qeth patches built for net fixing a problem with AF_IUCV > traffic through HiperSockets. > And we come up with an update for the MAINTAINERS file to establish > Julian as Co-Maintainer for drivers/s390/net and net/iucv. S

Re: [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries

2017-03-24 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 23 Mar 2017 12:27:11 +0200 > This set adds the ability to add externally learned entries from > user-space. For symmetry and proper function we need to allow SW entries > to take over HW learned ones (similar to how HW can take over SW entries > currently) whi

Re: [PATCH] isdn: use setup_timer

2017-03-24 Thread David Miller
From: Geliang Tang Date: Thu, 23 Mar 2017 21:15:57 +0800 > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang Applied, thanks. It would be really nice to get rid of all of the (void *) casts these calls do. In particular this turns off type checki

Re: [PATCH v2] net: stmmac: add set_mac to the stmmac_ops

2017-03-24 Thread David Miller
From: Corentin Labbe Date: Thu, 23 Mar 2017 14:40:22 +0100 > Two different set_mac functions exists but stmmac_dwmac4_set_mac() is > only used for enabling and never for disabling. > So on dwmac4, the MAC RX/TX is never disabled. > > This patch add a generic function pointer set_mac() to stmmac_

Re: [PATCH v3 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-24 Thread David Miller
From: Pavel Belous Date: Thu, 23 Mar 2017 14:19:40 +0300 > From: Pavel Belous > > The following patchset containg several fixes for aQuantia AQtion driver > for net tree: A couple fixes for IPv6 and other fixes. > > v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead >

  1   2   3   >