From: gfree.w...@foxmail.com Date: Fri, 24 Mar 2017 07:05:12 +0800 > From: Gao Feng <f...@ikuai8.com> > > Because sysctl_tcp_adv_win_scale could be changed any time, so there > is one race in tcp_win_from_space. > For example, > 1.sysctl_tcp_adv_win_scale<=0 (sysctl_tcp_adv_win_scale is negative now) > 2.space>>(-sysctl_tcp_adv_win_scale) (sysctl_tcp_adv_win_scale is postive now) > > As a result, tcp_win_from_space returns 0. It is unexpected. > > Certainly if the compiler put the sysctl_tcp_adv_win_scale into one > register firstly, then use the register directly, it would be ok. > But we could not depend on the compiler behavior. > > Signed-off-by: Gao Feng <f...@ikuai8.com>
Applied.