From: Ben Greear <gree...@candelatech.com> Date: Fri, 24 Mar 2017 14:20:56 -0700
> On 03/24/2017 02:12 PM, David Miller wrote: >> From: gree...@candelatech.com >> Date: Fri, 24 Mar 2017 13:58:47 -0700 >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> In systems where you may have a very large number of network >>> adapters, certain drivers may consume an unfair amount of >>> IRQ resources. So, allow a module param that will limit the >>> number of IRQs at driver load time. This way, other drivers >>> (40G Ethernet, for instance), which probably will need the >>> multiple IRQs more, will not be starved of IRQ resources. >>> >>> Signed-off-by: Ben Greear <gree...@candelatech.com> >> >> Sorry, no module params. >> >> Use generic run-time facilities such as ethtool to configure >> such things. > > You cannot call ethtool before module load time, and that is when > the IRQs are first acquired. It may be way more useful to give each > of 20 network adapters 2 irqs than have the first few grab 16 and the > rest > get lumped into legacy crap. Sorry, you'll have to find a way to fix this without a module parameter. I understand it might not be easy, but that's not a reason to add countless driver private module parameters all over the tree which is the worst user experience possible.