[PATCH 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-27 Thread Zumeng Chen
When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations, so add wmb to ensure an flip from 0 to 1 for NCR. Signed-off-by: Zumeng Chen --- drivers/net

Re: [PATCH net] net/sched: act_pedit: limit negative offset

2016-11-27 Thread Amir Vadai"
On Mon, Nov 28, 2016 at 12:49:36AM -0500, David Miller wrote: > From: Cong Wang > Date: Sun, 27 Nov 2016 21:39:33 -0800 > > > On Sun, Nov 27, 2016 at 7:58 AM, Amir Vadai wrote: > >> Should not allow setting a negative offset that goes below the skb head. > > ... > >> diff --git a/net/sched/act_p

Re: [PATCH net-next v3 0/4] Documentation: net: phy: Improve documentation

2016-11-27 Thread Jerome Brunet
On Sun, 2016-11-27 at 18:45 -0800, Florian Fainelli wrote: > Hi all, > > This patch series addresses discussions and feedback that was > recently received > on the mailing-list in the area of: flow control/pause frames, > interpretation of > phy_interface_t and finally add some links to useful sta

[PATCH] net: arc_emac: add dependencies on associated arches and compile test

2016-11-27 Thread Peter Robinson
Add dependencies on the architectures that support these devices and add compile test to ensure ongoing code build coverage. Signed-off-by: Peter Robinson --- drivers/net/ethernet/arc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/arc/Kconfi

[PATCH net-next v2 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch exports the sender chronograph stats via the socket SO_TIMESTAMPING channel. Currently we can instrument how long a particular application unit of data was queued in TCP by tracking SOF_TIMESTAMPING_TX_SOFTWARE and SOF_TIMESTAMPING_TX_SCHED. Having these sender chrono

[PATCH net-next v2 5/6] tcp: export sender limits chronographs to TCP_INFO

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch exports all the sender chronograph measurements collected in the previous patches to TCP_INFO interface. Note that busy time exported includes all the other sending limits (rwnd-limited, sndbuf-limited). Internally the time unit is jiffy but externally the measurement

[PATCH net-next v2 4/6] tcp: instrument how long TCP is limited by insufficient send buffer

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch measures the amount of time when TCP runs out of new data to send to the network due to insufficient send buffer, while TCP is still busy delivering (i.e. write queue is not empty). The goal is to indicate either the send buffer autotuning or user SO_SNDBUF setting ha

[PATCH net-next v2 3/6] tcp: instrument how long TCP is limited by receive window

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch measures the total time when the TCP stops sending because the receiver's advertised window is not large enough. Note that once the limit is lifted we are likely in the busy status if we have data pending. Signed-off-by: Francis Yan Signed-off-by: Yuchung Cheng Sig

[PATCH net-next v2 1/6] tcp: instrument tcp sender limits chronographs

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch implements the skeleton of the TCP chronograph instrumentation on sender side limits: 1) idle (unspec) 2) busy sending data other than 3-4 below 3) rwnd-limited 4) sndbuf-limited The limits are enumerated 'tcp_chrono'. Since a connect

[PATCH net-next v2 0/6] tcp: sender chronographs instrumentation

2016-11-27 Thread Yuchung Cheng
This patch set provides instrumentation on TCP sender limitations. While developing the BBR congestion control, we noticed that TCP sending process is often limited by factors unrelated to congestion control: insufficient sender buffer and/or insufficient receive window/buffer to saturate the netwo

[PATCH net-next v2 2/6] tcp: instrument how long TCP is busy sending

2016-11-27 Thread Yuchung Cheng
From: Francis Yan This patch measures TCP busy time, which is defined as the period of time when sender has data (or FIN) to send. The time starts when data is buffered and stops when the write queue is flushed by ACKs or error events. Note the busy time does not include SYN time, unless data is

Re: [PATCH] net: fec: turn on device when extracting statistics

2016-11-27 Thread Nikita Yushchenko
28.11.2016 04:29, David Miller пишет: > From: Nikita Yushchenko > Date: Fri, 25 Nov 2016 13:02:00 +0300 > >> +int i, ret; >> + >> +ret = pm_runtime_get_sync(&fep->pdev->dev); >> +if (IS_ERR_VALUE(ret)) { >> +memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats)); >> +

[PATCH] vxlan: fix a potential issue when create a new vxlan fdb entry.

2016-11-27 Thread Haishuang Yan
vxlan_fdb_append may return error, so add the proper check, otherwise it will cause memory leak. Signed-off-by: Haishuang Yan --- drivers/net/vxlan.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 21e92be..3b7b237 10

RE: BALANCE PAYMENT

2016-11-27 Thread coral
Dear Sir/s, Please see attached. Thanks and regards, Accounts Department Al Omraniya Trading Co. LLC P.O. Box: 10757, Al Khabaisi Area, Deira 2, Dubai, U.A.E. Tel: +971 4 268 2730 / Fax: +971 4 268 4117

Re: [PATCH net] net, sched: respect rcu grace period on cls destruction

2016-11-27 Thread Cong Wang
On Sat, Nov 26, 2016 at 4:18 PM, Daniel Borkmann wrote: > Roi reported a crash in flower where tp->root was NULL in ->classify() > callbacks. Reason is that in ->destroy() tp->root is set to NULL via > RCU_INIT_POINTER(). It's problematic for some of the classifiers, because > this doesn't respect

RE: BALANCE PAYMENT

2016-11-27 Thread coral
Dear Sir/s, Please see attached. Thanks and regards, Accounts Department Al Omraniya Trading Co. LLC P.O. Box: 10757, Al Khabaisi Area, Deira 2, Dubai, U.A.E. Tel: +971 4 268 2730 / Fax: +971 4 268 4117

Re: Crash due to mutex genl_lock called from RCU context

2016-11-27 Thread Cong Wang
On Sun, Nov 27, 2016 at 8:23 AM, Eric Dumazet wrote: > On Sat, 2016-11-26 at 22:28 -0800, Cong Wang wrote: >> On Sat, Nov 26, 2016 at 6:26 PM, Eric Dumazet wrote: >> > >> > Are you telling me inet_release() is called when we close() the first >> > file descriptor ? >> > >> > fd1 = socket() >> > f

[patch net] net: dsa: fix unbalanced dsa_switch_tree reference counting

2016-11-27 Thread Nikita Yushchenko
_dsa_register_switch() gets a dsa_switch_tree object either via dsa_get_dst() or via dsa_add_dst(). Former path does not increase kref in returned object (resulting into caller not owning a reference), while later path does create a new object (resulting into caller owning a reference). The rest o

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 1:07 PM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 9:50 PM, 张胜举 wrote: > > No, when dump request must

Re: [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel.

2016-11-27 Thread Pravin Shelar
On Sun, Nov 27, 2016 at 9:26 PM, Haishuang Yan wrote: > It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel. > > Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()') > > Signed-off-by: Haishuang Yan Thanks for fix. Acked-by: Pravin B Shelar

Re: [PATCH net] net/sched: act_pedit: limit negative offset

2016-11-27 Thread David Miller
From: Cong Wang Date: Sun, 27 Nov 2016 21:39:33 -0800 > On Sun, Nov 27, 2016 at 7:58 AM, Amir Vadai wrote: >> Should not allow setting a negative offset that goes below the skb head. > ... >> diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c >> index b54d56d4959b..e79e8a88f2d2 100644 >>

Re: [PATCH net] net/sched: act_pedit: limit negative offset

2016-11-27 Thread Cong Wang
On Sun, Nov 27, 2016 at 7:58 AM, Amir Vadai wrote: > Should not allow setting a negative offset that goes below the skb head. ... > diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c > index b54d56d4959b..e79e8a88f2d2 100644 > --- a/net/sched/act_pedit.c > +++ b/net/sched/act_pedit.c > @@

[PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel.

2016-11-27 Thread Haishuang Yan
It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel. Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()') Signed-off-by: Haishuang Yan --- drivers/net/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 9:50 PM, 张胜举 wrote: > No, when dump request must be processed by multiple 'recv/recvmsg' system > calls, > idx stores which dev/neigh the previous call have processed, so that next > call will scan > from the right place. I have tested multiple calls and I do not see redundant info

Re: [PATCH net-next 2/9] liquidio CN23XX: VF registration

2016-11-27 Thread David Miller
From: Raghu Vatsavayi Date: Sun, 27 Nov 2016 20:51:35 -0800 > +static int > +liquidio_vf_probe(struct pci_dev *pdev, > + const struct pci_device_id *ent __attribute__((unused))) > +{ > + struct octeon_device *oct_dev = NULL; ... > + /* set linux specific device pointer */ >

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-27 Thread Florian Fainelli
On 11/26/2016 04:20 AM, Lino Sanfilippo wrote: > Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer > interface control) technology. The driver provides basic support without > SLIC for the following devices: > > - Mojave cards (single port PCI Gigabit) both copper and fiber

Re: [PATCH net v2 0/5] net: fix phydev reference leaks

2016-11-27 Thread David Miller
From: Timur Tabi Date: Sun, 27 Nov 2016 20:11:17 -0600 > David Miller wrote: >> Series applied, thanks. > > I was really hoping you'd give me the chance to test the patches > before applying them. Sorry, if anything is broken I will happily revert if it isn't fixed promptly.

[PATCH net-next 4/9] liquidio CN23XX: VF queue setup

2016-11-27 Thread Raghu Vatsavayi
Adds support for configuring VF input/output queues. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.c| 144 + .../ethernet/cavium/liquidio/cn23xx

[PATCH net-next 8/9] liquidio CN23XX: VF interrupt

2016-11-27 Thread Raghu Vatsavayi
Adds support for VF interrupt processing. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.c| 265 + .../ethernet/cavium/liquidio/cn23xx_vf_device.

[PATCH net-next 5/9] liquidio CN23XX: VF register access

2016-11-27 Thread Raghu Vatsavayi
This patch adds support for VF device register access. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.c| 189 + .../ethernet/cavium/liquidio/cn23

[PATCH net-next 6/9] liquidio CN23XX: init VF softcommand queues

2016-11-27 Thread Raghu Vatsavayi
Adds support for initializing softcommand, dispatch and instructions queues for VF. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 74 +- .../

[PATCH net-next 7/9] liquidio CN23XX: VF mailbox

2016-11-27 Thread Raghu Vatsavayi
Adds support for VF mailbox setup. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.c| 59 ++ drivers/net/ethernet/cavium/liquidio/lio_vf_main.c |

[PATCH net-next 9/9] liquidio CN23XX: VF init and destroy

2016-11-27 Thread Raghu Vatsavayi
Adds support for VF initialization and destroy resources. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.h| 2 + drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

[PATCH net-next 0/9] liquidio VF operations

2016-11-27 Thread Raghu Vatsavayi
Hi Dave, Following patches add support for VF device specific operations like mailbox, queues and register access. Please apply the patches in following order as these patches depend on each other. Thanks Raghu Vatsavayi (9): liquidio CN23XX: VF register definitions liquidio CN23XX: VF re

[PATCH net-next 3/9] liquidio CN23XX: VF config setup

2016-11-27 Thread Raghu Vatsavayi
Adds support for setting up VF configuration. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/Makefile | 1 + .../ethernet/cavium/liquidio/cn23xx_vf_device.c| 44 +

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 11:10 AM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 7:56 PM, David Ahern wrote: > > On 11/27/16 7:5

[PATCH net-next 1/9] liquidio CN23XX: VF register definitions

2016-11-27 Thread Raghu Vatsavayi
Adds support for CN23xx VF registers. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../net/ethernet/cavium/liquidio/cn23xx_vf_regs.h | 274 + 1 file changed, 274 insertions(+) create mode 100

[PATCH net-next 2/9] liquidio CN23XX: VF registration

2016-11-27 Thread Raghu Vatsavayi
Adds support for cn23xx VF probe and registration. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/Kconfig| 12 +++ drivers/net/ethernet/cavium/liquidio/Makefile | 2

[PATCH net-next] bpf: samples: Fix compile of test_lru_dist.c

2016-11-27 Thread David Ahern
Build of samples/bpf on debian/jessie fails with: HOSTCC /home/dsa/kernel-3.git/samples/bpf/test_lru_dist.o /home/dsa/kernel-3.git/samples/bpf/test_lru_dist.c: In function ‘main’: /home/dsa/kernel-3.git/samples/bpf/test_lru_dist.c:490:9: error: variable ‘r’ has initializer but incomplete type

Re: [RFC net-next 2/3] net: dsa: Propagate VLAN add/del to CPU port(s)

2016-11-27 Thread Florian Fainelli
On 11/22/2016 08:50 AM, Vivien Didelot wrote: > Hi Florian, > > Open question: will we need to do the same for FDB and MDB objects? (overlooked that question early this week), I do expect that this could be helpful for FDB and MBD objects as well, yes. > > Florian Fainelli writes: > >> Now

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-27 Thread Michael S. Tsirkin
On Sun, Nov 27, 2016 at 07:56:09PM -0800, John Fastabend wrote: > On 16-11-27 07:36 PM, Michael S. Tsirkin wrote: > > On Fri, Nov 25, 2016 at 01:24:03PM -0800, John Fastabend wrote: > >> On 16-11-22 06:58 AM, Michael S. Tsirkin wrote: > >>> On Tue, Nov 22, 2016 at 12:27:03AM -0800, John Fastabend w

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-27 Thread John Fastabend
On 16-11-27 07:36 PM, Michael S. Tsirkin wrote: > On Fri, Nov 25, 2016 at 01:24:03PM -0800, John Fastabend wrote: >> On 16-11-22 06:58 AM, Michael S. Tsirkin wrote: >>> On Tue, Nov 22, 2016 at 12:27:03AM -0800, John Fastabend wrote: On 16-11-21 03:20 PM, Michael S. Tsirkin wrote: > On Sat,

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-27 Thread Michael S. Tsirkin
On Fri, Nov 25, 2016 at 01:24:03PM -0800, John Fastabend wrote: > On 16-11-22 06:58 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 22, 2016 at 12:27:03AM -0800, John Fastabend wrote: > >> On 16-11-21 03:20 PM, Michael S. Tsirkin wrote: > >>> On Sat, Nov 19, 2016 at 06:50:33PM -0800, John Fastabend w

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 7:56 PM, David Ahern wrote: > On 11/27/16 7:53 PM, 张胜举 wrote: >> >> >>> -Original Message- >>> From: David Ahern [mailto:d...@cumulusnetworks.com] >>> Sent: Monday, November 28, 2016 10:39 AM >>> To: 张胜举 ; >>> netdev@vger.kernel.org >>> Subject: Re: [net,v2] neigh: fix the loop

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-27 Thread John Fastabend
On 16-11-23 05:58 PM, Cong Wang wrote: > Roi reported we could have a race condition where in ->classify() path > we dereference tp->root and meanwhile a parallel ->destroy() makes it > a NULL. > > This is possible because ->destroy() could be called when deleting > a filter to check if we are the

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 7:53 PM, 张胜举 wrote: > > >> -Original Message- >> From: David Ahern [mailto:d...@cumulusnetworks.com] >> Sent: Monday, November 28, 2016 10:39 AM >> To: 张胜举 ; >> netdev@vger.kernel.org >> Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump >> >> On 11/27/16 7:34

Re: [PATCH net] net, sched: respect rcu grace period on cls destruction

2016-11-27 Thread John Fastabend
On 16-11-26 04:18 PM, Daniel Borkmann wrote: > Roi reported a crash in flower where tp->root was NULL in ->classify() > callbacks. Reason is that in ->destroy() tp->root is set to NULL via > RCU_INIT_POINTER(). It's problematic for some of the classifiers, because > this doesn't respect RCU grace p

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:39 AM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 7:34 PM, 张胜举 wrote: > >> -Original Message-

[PATCH] net: handle no dst on skb in icmp6_send

2016-11-27 Thread David Ahern
Andrey reported the following while fuzzing the kernel with syzkaller: kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in: CPU: 0 PID: 3859 Comm: a.out Not tainted 4.9.0-rc6+ #429 Har

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-27 Thread John Fastabend
On 16-11-27 06:26 PM, John Fastabend wrote: > On 16-11-26 10:29 PM, Roi Dayan wrote: >> >> >> On 27/11/2016 06:47, Roi Dayan wrote: >>> >>> >>> On 27/11/2016 02:33, Daniel Borkmann wrote: On 11/26/2016 12:09 PM, Daniel Borkmann wrote: > On 11/26/2016 07:46 AM, Cong Wang wrote: >> On Th

[PATCH net-next v3 2/4] Documentation: net: phy: Add a paragraph about pause frames/flow control

2016-11-27 Thread Florian Fainelli
Describe that the Ethernet MAC controller is ultimately responsible for dealing with proper pause frames/flow control advertisement and enabling, and that it is therefore allowed to have it change phydev->supported/advertising with SUPPORTED_Pause and SUPPORTED_AsymPause. Reviewed-by: Martin Blume

[PATCH net-next v3 3/4] Documentation: net: phy: Add blurb about RGMII

2016-11-27 Thread Florian Fainelli
RGMII is a recurring source of pain for people with Gigabit Ethernet hardware since it may require PHY driver and MAC driver level configuration hints. Document what are the expectations from PHYLIB and what options exist. Reviewed-by: Martin Blumenstingl Signed-off-by: Florian Fainelli --- Doc

[PATCH net-next v3 4/4] Documentation: net: phy: Add links to several standards documents

2016-11-27 Thread Florian Fainelli
Add links to the IEEE 802.3-2008 document, and the RGMII v1.3 and v2.0 revisions of the standard. Reviewed-by: Martin Blumenstingl Signed-off-by: Florian Fainelli --- Documentation/networking/phy.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/networking/phy.tx

[PATCH net-next v3 1/4] Documentation: net: phy: remove description of function pointers

2016-11-27 Thread Florian Fainelli
Remove the function pointers documentation which duplicates information found in include/linux/phy.h. Maintaining documentation about two different locations just does not work, but the code is less likely to be outdated. Reviewed-by: Martin Blumenstingl Signed-off-by: Florian Fainelli --- Docu

[PATCH net-next v3 0/4] Documentation: net: phy: Improve documentation

2016-11-27 Thread Florian Fainelli
Hi all, This patch series addresses discussions and feedback that was recently received on the mailing-list in the area of: flow control/pause frames, interpretation of phy_interface_t and finally add some links to useful standards documents. Changes in v3: - add Timur's feedback into patch 3 C

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 7:34 PM, 张胜举 wrote: >> -Original Message- >> From: David Ahern [mailto:d...@cumulusnetworks.com] >> Sent: Monday, November 28, 2016 10:10 AM >> To: Zhang Shengju ; >> netdev@vger.kernel.org >> Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump >> >> On 11/27/16

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:10 AM > To: Zhang Shengju ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 6:32 PM, Zhang Shengju wrote: > > Loop

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-27 Thread John Fastabend
On 16-11-26 10:29 PM, Roi Dayan wrote: > > > On 27/11/2016 06:47, Roi Dayan wrote: >> >> >> On 27/11/2016 02:33, Daniel Borkmann wrote: >>> On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: > On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann > wr

Re: [PATCH net v2 0/5] net: fix phydev reference leaks

2016-11-27 Thread Timur Tabi
David Miller wrote: Series applied, thanks. I was really hoping you'd give me the chance to test the patches before applying them. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Fou

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 6:32 PM, Zhang Shengju wrote: > Loop index in neigh dump function is not updated correctly under some > circumstances, this patch will fix it. What's an example? > > Fixes: 16660f0bd9 ("net: Add support for filtering neigh dump by device > index") > Fixes: 21fdd092ac ("net: Add supp

Re: [PATCH net-next 0/6] BPF cleanups and misc updates

2016-11-27 Thread David Miller
From: Daniel Borkmann Date: Sat, 26 Nov 2016 01:28:03 +0100 > This patch set adds couple of cleanups in first few patches, > exposes owner_prog_type for array maps as well as mlocked mem > for maps in fdinfo, allows for mount permissions in fs and > fixes various outstanding issues in selftests a

Re: [PATCH net 1/1] tipc: fix link statistics counter errors

2016-11-27 Thread David Miller
From: Jon Maloy Date: Fri, 25 Nov 2016 10:35:02 -0500 > In commit e4bf4f76962b ("tipc: simplify packet sequence number > handling") we changed the internal representation of the packet > sequence number counters from u32 to u16, reflecting what is really > sent over the wire. > > Since then some

Re: [PATCH v2 0/7] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-27 Thread David Miller
From: Martin Blumenstingl Date: Fri, 25 Nov 2016 14:01:49 +0100 > Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 > cycle TX clock delay. This seems to work fine for many boards (for > example Odroid-C2 or Amlogic's reference boards) but there are some > others where TX traffi

[net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread Zhang Shengju
Loop index in neigh dump function is not updated correctly under some circumstances, this patch will fix it. Fixes: 16660f0bd9 ("net: Add support for filtering neigh dump by device index") Fixes: 21fdd092ac ("net: Add support for filtering neigh dump by master device") Signed-off-by: Zhang Shengj

Re: [patch v2 net-next] sfc: remove unneeded variable

2016-11-27 Thread David Miller
From: Dan Carpenter Date: Fri, 25 Nov 2016 13:43:04 +0300 > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > TSO") so let's remove the last traces. > > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: [PATCH] net: fec: turn on device when extracting statistics

2016-11-27 Thread David Miller
From: Nikita Yushchenko Date: Fri, 25 Nov 2016 13:02:00 +0300 > + int i, ret; > + > + ret = pm_runtime_get_sync(&fep->pdev->dev); > + if (IS_ERR_VALUE(ret)) { > + memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats)); > + return; > + } This really isn't t

Re: pull-request: wireless-drivers-next 2016-11-25

2016-11-27 Thread David Miller
From: Kalle Valo Date: Fri, 25 Nov 2016 11:39:49 +0200 > here's a pull request for 4.10. ath9k has now been converted to use > mac80211 intermediate software queues to fix bufferbloat problems. rsi > has become active again and latevy mwifiex has been getting a _lot_ of > love. > > I'm not expec

Re: [PATCH 1/1] net: macb: fix the RX queue reset in macb_rx()

2016-11-27 Thread David Miller
From: Cyrille Pitchen Date: Fri, 25 Nov 2016 09:49:32 +0100 > On macb only (not gem), when a RX queue corruption was detected from > macb_rx(), the RX queue was reset: during this process the RX ring > buffer descriptor was initialized by macb_init_rx_ring() but we forgot > to also set bp->rx_tai

Re: pull request (net): ipsec 2016-11-25

2016-11-27 Thread David Miller
From: Steffen Klassert Date: Fri, 25 Nov 2016 07:57:57 +0100 > 1) Fix a refcount leak in vti6. >From Nicolas Dichtel. > > 2) Fix a wrong if statement in xfrm_sk_policy_lookup. >From Florian Westphal. > > 3) The flowcache watermarks are per cpu. Take this into >account when comparing

Re: [PATCH net 1/1] driver: macvtap: Unregister netdev rx_handler if macvtap_newlink fails

2016-11-27 Thread David Miller
From: f...@ikuai8.com Date: Fri, 25 Nov 2016 10:05:06 +0800 > From: Gao Feng > > The macvtap_newlink registers the netdev rx_handler firstly, but it > does not unregister the handler if macvlan_common_newlink failed. > > Signed-off-by: Gao Feng Applied.

Re: [PATCH net v2 0/5] net: fix phydev reference leaks

2016-11-27 Thread David Miller
From: Johan Hovold Date: Thu, 24 Nov 2016 19:21:26 +0100 > This series fixes a number of phydev reference leaks (and one of_node > leak) due to failure to put the reference taken by of_phy_find_device(). > > Note that I did not try to fix drivers/net/phy/xilinx_gmii2rgmii.c which > still leaks a

Re: [PATCH] irda: fix overly long udelay()

2016-11-27 Thread David Miller
From: Arnd Bergmann Date: Thu, 24 Nov 2016 17:26:22 +0100 > irda_get_mtt() returns a hardcoded '1' in some cases, > and with gcc-7, we get a build error because this triggers a > compile-time check in udelay(): > > drivers/net/irda/w83977af_ir.o: In function `w83977af_hard_xmit': > w83977af_

Re: [PATCH net 1/1] driver: ipvlan: Fix one possible memleak in ipvlan_link_new

2016-11-27 Thread David Miller
From: f...@ikuai8.com Date: Thu, 24 Nov 2016 23:39:59 +0800 > From: Gao Feng > > When ipvlan_link_new fails and creates one ipvlan port, it does not > destroy the ipvlan port created. It causes mem leak and the physical > device contains invalid ipvlan data. > > Signed-off-by: Gao Feng Applie

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andrew Lunn
> Try to see it from my perspective: I see that some vf610 device I don't > have (found via `git grep marvell,mv88e6` or so) uses > "marvell,mv88e6085". I then assume it has that device on board. How > would I know it doesn't? Same for the other boards you mention. > > Unfortunately some of your r

Re: [PATCH net-next v2 3/4] Documentation: net: phy: Add blurb about RGMII

2016-11-27 Thread Florian Fainelli
Le 27/11/2016 à 14:24, Timur Tabi a écrit : >> + * PHY device drivers in PHYLIB being reusable by nature, being able to >> + configure correctly a specified delay enables more designs with >> similar delay >> + requirements to be operate correctly > > Ok, this one I don't know how to fix. I'm

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
Andrew, Am 27.11.2016 um 23:08 schrieb Andrew Lunn: >>> This driver already supports nearly 30 different Marvell switch >>> models. Please document why the marvell,mv88e6176 is special and why >>> it needs its own compatible string when the others don't. >> >> I don't understand. > > Think about

Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andrew Lunn
On Sun, Nov 27, 2016 at 11:26:28PM +0100, Andreas Färber wrote: > mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > so free the same amount. This will be 8 or 9 in practice, less than 16. > > Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") > Cc: An

[PATCH net-next] net: dsa: mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, so free the same amount. This will be 8 or 9 in practice, less than 16. Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") Cc: Andrew Lunn Signed-off-by: Andreas Färber --- drivers/net/dsa/mv88e6xxx/c

Re: [PATCH net-next v2 3/4] Documentation: net: phy: Add blurb about RGMII

2016-11-27 Thread Timur Tabi
Just some grammatical corrections. You might want to run a spellchecker on all the patches. Florian Fainelli wrote: + The Reduced Gigabit Medium Independent Interface (RGMII) is a 12 pins "is a 12-pin" + electrical signal interface using a synchronous 125Mhz clock signal and several + dat

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andrew Lunn
> > This driver already supports nearly 30 different Marvell switch > > models. Please document why the marvell,mv88e6176 is special and why > > it needs its own compatible string when the others don't. > > I don't understand. Think about what i said. Why does the 6176 need its own compatible str

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
Am 27.11.2016 um 22:27 schrieb Andrew Lunn: > On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas Färber wrote: >> This model is found on the Turris Omnia. > > This driver already supports nearly 30 different Marvell switch > models. Please document why the marvell,mv88e6176 is special and why > it

Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andrew Lunn
On Sun, Nov 27, 2016 at 10:32:41PM +0100, Andreas Färber wrote: > Hi Andrew, > > Am 27.11.2016 um 22:22 schrieb Andrew Lunn: > > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: > >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > >> so free the same amount

Re: [PATCH v2] MAINTAINERS: Add device tree bindings to mv88e6xx section

2016-11-27 Thread Andrew Lunn
On Sun, Nov 27, 2016 at 10:07:30PM +0100, Andreas Färber wrote: > Also include the netdev list for convenience, as done elsewhere. Please indicate which maintainer you expect to accept this. And if that is David Miller, please fix the Subject: line. > Cc: Andrew Lunn > Cc: Vivien Didelot > Sig

Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
Hi Andrew, Am 27.11.2016 um 22:22 schrieb Andrew Lunn: > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, >> so free the same amount. This will be 8 or 9 in practice, less than 16. > > Hi Andreas > > The pa

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andrew Lunn
On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas Färber wrote: > This model is found on the Turris Omnia. This driver already supports nearly 30 different Marvell switch models. Please document why the marvell,mv88e6176 is special and why it needs its own compatible string when the others don't.

Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andrew Lunn
On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: > mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > so free the same amount. This will be 8 or 9 in practice, less than 16. Hi Andreas The patch is correct, but please read Documentation/networking/netdev-FAQ.

Re: [PATCH net-next 09/11] qede: Better utilize the qede_[rt]x_queue

2016-11-27 Thread Mintz, Yuval
> > I'd say this is a false positive, given that MTU can't be so large. > False positive or not you must fix the warning and resubmit this > series with that fixed. Sure. I'll re-spin later this week [hopefully it'll get some additional review comments by then].

[PATCH v2] MAINTAINERS: Add device tree bindings to mv88e6xx section

2016-11-27 Thread Andreas Färber
Also include the netdev list for convenience, as done elsewhere. Cc: Andrew Lunn Cc: Vivien Didelot Signed-off-by: Andreas Färber --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f73e19277a70..677d73cfedc7 100644 --- a/MAINTAINERS +++ b/MAIN

[PATCH] MAINTAINERS: Add device tree bindings to mv88e6xx section

2016-11-27 Thread Andreas Färber
Also include the netdev list for convenience, as done elsewhere. Cc: Andrew Lunn Cc: Vivien Didelot Signed-off-by: Andreas Färber --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f73e19277a70..46ccf6eadcc9 100644 --- a/MAINTAINERS +++ b/MAINTA

[PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

2016-11-27 Thread Andreas Färber
This model is found on the Turris Omnia. Signed-off-by: Andreas Färber --- drivers/net/dsa/mv88e6xxx/chip.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 77f13ada2612..95b9efb33ec7 100644 --- a/drivers/net/dsa/mv

[PATCH 1/2] Documentation: net: dsa: marvell: Add 88E6176

2016-11-27 Thread Andreas Färber
Signed-off-by: Andreas Färber --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt index b3dd6b40e0de..000bc3b16edd 100644 --- a/

Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

2016-11-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 24 Nov 2016 07:04:08 +0200 > sparse warns about context imbalance in any code > that uses HARD_TX_LOCK/UNLOCK - this is because it's > unable to determine that flags don't change so > lock and unlock are paired. > > Seems easy enough to fix by adding __acqui

[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

2016-11-27 Thread Andreas Färber
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, so free the same amount. This will be 8 or 9 in practice, less than 16. Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") Cc: Andrew Lunn Signed-off-by: Andreas Färber --- drivers/net/dsa/mv88e6xxx/c

Re: [PATCH net-next v2 0/4] Documentation: net: phy: Improve documentation

2016-11-27 Thread Martin Blumenstingl
On Sun, Nov 27, 2016 at 7:44 PM, Florian Fainelli wrote: > Hi all, > > This patch series addresses discussions and feedback that was recently > received > on the mailing-list in the area of: flow control/pause frames, interpretation > of > phy_interface_t and finally add some links to useful sta

Re: [PATCH net-next 1/1] ptp: gianfar: Use high resolution frequency method.

2016-11-27 Thread David Miller
From: Ulrik De Bie Date: Wed, 23 Nov 2016 21:11:04 +0100 > This patch depends on commit d8d263541913 ("ptp: Introduce a high > resolution frequency adjustment method.") > > The gianfar devices offer a frequency resolution of about 0.46 ppb > (depends on actual value of tmr_add, for the calculati

Re: [PATCH v3] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-27 Thread David Miller
From: yegorsli...@googlemail.com Date: Thu, 24 Nov 2016 10:17:01 +0100 > From: Yegor Yefremov > > Add the ability to query and set Energy Efficient Ethernet parameters > via ethtool for applicable devices. > > This patch doesn't activate full EEE support in cpsw driver, but it > enables reading

Re: [PATCH net-next] mlx4: do not use priv->stats_lock in mlx4_en_auto_moderation()

2016-11-27 Thread David Miller
From: Eric Dumazet Date: Wed, 23 Nov 2016 09:46:52 -0800 > From: Eric Dumazet > > Per RX ring packets/bytes counters are not protected by global > priv->stats_lock. > > Better not confuse the reader, and use READ_ONCE() to show we read > these counters without surrounding synchronization. > >

Re: [PATCH v2] ipv6:ipv6_pinfo dereferenced after NULL check

2016-11-27 Thread David Miller
From: Manjeet Pawar Date: Thu, 24 Nov 2016 16:11:57 +0530 > From: Rohit Thapliyal > > np checked for NULL and then dereferenced. It should be modified > for NULL case. > > Signed-off-by: Rohit Thapliyal > Signed-off-by: Manjeet Pawar > Signed-off-by: Hannes Frederic Sowa > Reviewed-by: Akhi

Re: [PATCH net-next 09/11] qede: Better utilize the qede_[rt]x_queue

2016-11-27 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 27 Nov 2016 16:15:42 + > I'd say this is a false positive, given that MTU can't be so large. False positive or not you must fix the warning and resubmit this series with that fixed.

[PATCH] rtlwifi: Add updates for RTL8723BE and RTL8821AE

2016-11-27 Thread Larry Finger
The new versions will only work with new versions of the drivers. For that reason, they are given new names and the old versions are retained. Signed-off-by: Larry Finger --- WHENCE | 4 rtlwifi/rtl8723befw_36.bin | Bin 0 -> 31762 bytes rtlwifi/rtl8821aefw_29.bin | Bi

  1   2   >