Re: [RFC 06/12] nfp: add hardware cls_bpf offload

2016-06-01 Thread Jiri Pirko
Wed, Jun 01, 2016 at 11:36:48PM CEST, john.fastab...@gmail.com wrote: >On 16-06-01 01:52 PM, Alexei Starovoitov wrote: >> On Wed, Jun 01, 2016 at 10:20:54PM +0200, Daniel Borkmann wrote: >>> On 06/01/2016 06:50 PM, Jakub Kicinski wrote: Add hardware cls_bpf offload on our smart NICs. Detect i

Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump

2016-06-01 Thread David Miller
From: Kangjie Lu Date: Wed, 1 Jun 2016 12:34:55 -0400 > diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c > index f795b1d..115aafa 100644 > --- a/net/tipc/netlink_compat.c > +++ b/net/tipc/netlink_compat.c > @@ -604,6 +604,7 @@ static int tipc_nl_compat_link_dump(struct > tipc_

Re: [PATCH net-next] ravb: Remove manual pause frame transmit

2016-06-01 Thread David Miller
From: Yoshihiro Kaneko Date: Thu, 2 Jun 2016 01:41:05 +0900 > From: Masaru Nagai > > Writing a non-zero value to the manual PAUSE frame register (MPR) starts > the transmission of a PAUSE frame. > A PAUSE frame is sent in ravb_emac_init(), but it is not expected behavior. > > Signed-off-by: M

Re: [PATCH] net: fix potential infoleak in rds_inc_info_copy

2016-06-01 Thread David Miller
From: Kangjie Lu Date: Wed, 1 Jun 2016 12:11:16 -0400 > The last field "flags" of object "minfo" is not initialized. > Copying this object out may leak kernel stack data. > Assign 0 to it to avoid leak. > > Signed-off-by: Kangjie Lu The correct subsystem prefix is "rds: ". Please resubmit th

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

2016-06-01 Thread Nikolay Borisov
On 06/01/2016 07:00 PM, Eric W. Biederman wrote: > Cc'd the containers list. > > > Nikolay Borisov writes: > >> Currently the inotify instances/watches are being accounted in the >> user_struct structure. This means that in setups where multiple >> users in unprivileged containers map to th

[PATCH net-next v10 5/5] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-06-01 Thread Simon Horman
This allows GRE tunnels to send and receive both layer 2 packets (packets with an ethernet header) and layer 3 packets (packets without an ethernet header). Signed-off-by: Simon Horman --- v10 * Handle case of l3 only packets on vport-netdev * Use ARPHRD_NONE for ipgre interfaces as per recent ch

[PATCH net-next v10 4/5] openvswitch: add layer 3 flow/port support

2016-06-01 Thread Simon Horman
From: Lorand Jakab Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. This doesn't actually do anything yet as no layer 2 tunnel ports are supported yet. The original patch by Lorand was against the Open vSwitch tree which has L2 LISP tunnels but that is

[PATCH net-next v10 3/5] openvswitch: add support to push and pop mpls for layer3 packets

2016-06-01 Thread Simon Horman
Allow push and pop mpls actions to act on layer 3 packets by teaching them not to access non-existent L2 headers of such packets. Signed-off-by: Simon Horman --- v10 * Limit scope of hdr in {push,pop}_mpls() v9 * New Patch --- net/openvswitch/actions.c | 19 --- 1 file changed,

[PATCH net-next v10 0/5] openvswitch: support for layer 3 encapsulated packets

2016-06-01 Thread Simon Horman
At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. Support for layer 3 GRE tunnels is also added by this patchset. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding

[PATCH net-next v10 1/5] net: add skb_vlan_accel helper

2016-06-01 Thread Simon Horman
This breaks out some of of skb_vlan_pop into a separate helper. This new helper moves the outer-most vlan tag present in packet data into metadata. The motivation is to allow acceleration VLAN tags without adding a new one. This is in preparation for a push ethernet header support in Open vSwitch.

[PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-01 Thread Simon Horman
* Set skb protocol based on contents of packet. I have observed this is necessary to get actual protocol of a packet when it is injected into an internal device e.g. by libnet in which case skb protocol will be set to ETH_ALL. * Set the mac_len which has been observed to not be set up correc

Re: [PATCH net-next] sctp: sctp should change socket state when shutdown is received

2016-06-01 Thread Xin Long
On Thu, Jun 2, 2016 at 5:40 AM, Marcelo Ricardo Leitner wrote: > On Thu, Jun 02, 2016 at 03:38:45AM +0800, Xin Long wrote: >> Now sctp doesn't change socket state upon shutdown reception. It changes >> just the assoc state, even though it's a TCP-style socket. >> >> For some cases, if we really ne

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Hayes Wang
Mario Limonciello [mailto:mario_limoncie...@dell.com] [...] > static int set_ethernet_addr(struct r8152 *tp) > { > struct net_device *dev = tp->netdev; > @@ -1041,6 +1075,9 @@ static int set_ethernet_addr(struct r8152 *tp) > else > ret = pla_ocp_read(tp, PLA_BACKUP, 8, s

[ANNOUNCE] Netdev 1.2 call for proposals

2016-06-01 Thread Hajime Tazaki
We just opened call for proposals. We hope the conference will be the great venue as previous netdev conferences. http://netdevconf.org/1.2/submit-proposal.html Netdev 1.2 is a community-driven conference geared towards Linux netheads. Linux kernel networking and user space utilization of the

Re: [PATCH v2] qed: fix qed_fill_link() error handling

2016-06-01 Thread David Miller
From: Yuval Mintz Date: Wed, 1 Jun 2016 13:36:38 + >> gcc warns about qed_fill_link possibly accessing uninitialized data: >> >> drivers/net/ethernet/qlogic/qed/qed_main.c: In function 'qed_fill_link': >> drivers/net/ethernet/qlogic/qed/qed_main.c:1170:35: error: 'link_caps' may be >> used u

Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

2016-06-01 Thread David Miller
From: Colin King Date: Wed, 1 Jun 2016 14:16:50 +0100 > From: Colin Ian King > > priv is assigned to NULL however some of the early error exit paths to > label 'free' dereference priv, causing a null pointer dereference. > > Move the label 'free' to just the free_netdev statement, and add a n

[PATCH iputils v2] ping6: allow disabling of openssl/libgcrypt support

2016-06-01 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- Makefile | 5 - iputils_md5dig.h | 4 +++- ping6.c | 19 ++- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index b6cf512..8b9e2aa 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ A

Re: [PATCH v6 0/3] skb_array: array based FIFO for skbs

2016-06-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 1 Jun 2016 15:54:34 +0300 > This is in response to the proposal by Jason to make tun > rx packet queue lockless using a circular buffer. > My testing seems to show that at least for the common usecase > in networking, which isn't lockless, circular buffer > w

[PATCH iputils v2] ping: always accept . delimiter with -i number parsing

2016-06-01 Thread Mike Frysinger
Always allow #.# format for the -i flag even when the current locale uses a different separator. Locale de_DE which uses #,# normally. Simple testcase: $ make USE_IDN=1 $ LANG=de_DE.UTF8 ./ping -i 0.5 localhost $ LANG=de_DE.UTF8 ./ping -i 0,5 localhost Reported-by: Sergey Fionov Signed-off-by:

Re: [PATCH] stmmac: make platform drivers depend on their associated SoC

2016-06-01 Thread David Miller
From: Peter Robinson Date: Wed, 1 Jun 2016 13:28:58 +0100 > There's not much point, except compile test, enabling the stmmac > platform drivers unless their actual SoC is enabled. They're not > useful without it. > > Signed-off-by: Peter Robinson Seems reasonable, applied, thanks.

Re: [PATCH iputils 1/6] start gitignore files

2016-06-01 Thread Mike Frysinger
On 02 Jun 2016 11:06, YOSHIFUJI Hideaki wrote: > Mike Frysinger wrote: > > Signed-off-by: Mike Frysinger > > --- > > .gitignore | 22 ++ > > doc/.gitignore | 2 ++ > > 2 files changed, 24 insertions(+) > > create mode 100644 .gitignore > > create mode 100644 doc/.gitign

Re: [PATCH iputils 5/6] tftpd: fix syslog setup

2016-06-01 Thread Mike Frysinger
On 02 Jun 2016 11:10, YOSHIFUJI Hideaki wrote: > Mike Frysinger wrote: > > Commit d81a44625b04d487c895473aa77af13420b7afdd added support for checking > > the set*id calls, but would call syslog() before it had called openlog(). > > Move the call up earlier to fix that. > > Please describe what it

[PATCH v2 2/5] fsl/qe: setup clock source for TDM mode

2016-06-01 Thread Zhao Qiang
Add tdm clock configuration in both qe clock system and ucc fast controller. Signed-off-by: Zhao Qiang --- Changes for v2: - break codes getting clock_bits and source to smaller functions. - add __iomem to qe_mux_reg - add bits operation functions for qe and use it

[PATCH net-next] net: vrf: set operstate and mtu at link create

2016-06-01 Thread David Ahern
The VRF device exists to define L3 domains and guide FIB lookups. As such its operstate is not relevant. Seeing 'state UNKNOWN' in the output of 'ip link show' can be confusing, so set operstate at link create. Similarly, the MTU for a VRF device is not used; any fragmentation of the payload is do

[PATCH net-next 2/2] net: vrf: Add l3mdev rules on first device create

2016-06-01 Thread David Ahern
Add l3mdev rule per address family when the first VRF device is created. Remove them when the last is deleted. Signed-off-by: David Ahern --- drivers/net/vrf.c | 114 +- 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next 0/2] net: vrf: Improve use of FIB rules

2016-06-01 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH net-next 1/2] net: Add l3mdev rule

2016-06-01 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH v2 1/5] fsl/qe: add rx_sync and tx_sync for TDM mode

2016-06-01 Thread Zhao Qiang
Rx_sync and tx_sync are used by QE-TDM mode, add them to struct ucc_fast_info. Signed-off-by: Zhao Qiang --- Changes for v2: - use strcmp instead of strcasecmp drivers/soc/fsl/qe/qe.c | 6 ++ include/soc/fsl/qe/qe.h | 2 ++ include/soc/fsl/qe/ucc_fast.h | 2 ++ 3 files c

[PATCH v2] netfilter: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2016-06-01 Thread Xiubo Li
Since we cannot make sure that the 'hook_mask' will always be none zero here. If it equals to zero, the num_hooks will be zero too, and then kmalloc() will return ZERO_SIZE_PTR, which is (void *)16. Then the following error check will fails: ops = kmalloc(sizeof(*ops) * num_hooks, GFP_KERNEL);

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario_Limonciello
> > +static u8 amac_ascii_to_hex(int c) > > +{ > > + if (c <= 0x39) > > + return (u8)(c - 0x30); > > + else if (c <= 0x46) > > + return (u8)(c - 0x37); > > + return (u8)(c - 0x57); > > +} > Sorry forgot to address this. > We really don't have such a function somewhere

Re: [PATCH] netfilter: fix possible ZERO_SIZE_PTRpointerdereferencing error.

2016-06-01 Thread Xiubo Li
On 01/06/2016 19:04, Pablo Neira Ayuso wrote: On Wed, Jun 01, 2016 at 05:52:59PM +0800, Xiubo Li wrote: net/netfilter/x_tables.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index c8a0b7d..4df8e38 100644 --- a/net/netfilter/x_tab

Re: [PATCH iputils 2/6] doc: fix parallel build of html/man pages

2016-06-01 Thread YOSHIFUJI Hideaki
Hi, Mike Frysinger wrote: > The use of the same tempdir prevents building of these files in parallel. > So build all of them in unique tempdirs so we can do them in parallel. > > Signed-off-by: Mike Frysinger Applied. Thank you. -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORA

Re: [PATCH iputils 4/6] fix handling of CFLAGS

2016-06-01 Thread YOSHIFUJI Hideaki
Mike Frysinger wrote: > This defaults CFLAGS to -O3 without clobbering settings people have set > up in the environment already. > > Signed-off-by: Mike Frysinger Fixed in different way. Thank you. -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario_Limonciello
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, June 1, 2016 6:06 PM > To: Limonciello, Mario > Cc: hayesw...@realtek.com; LKML ; Netdev > ; Linux USB ; > pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: Re: [PATCH] r8152: Add support

Re: [PATCH iputils 5/6] tftpd: fix syslog setup

2016-06-01 Thread YOSHIFUJI Hideaki
Hi, Mike Frysinger wrote: > Commit d81a44625b04d487c895473aa77af13420b7afdd added support for checking > the set*id calls, but would call syslog() before it had called openlog(). > Move the call up earlier to fix that. Please describe what it really fixes. -- Hideaki Yoshifuji Technical Divisi

Re: [PATCH iputils 6/6] ping: fix -i number parsing in locales

2016-06-01 Thread YOSHIFUJI Hideaki
Mike Frysinger wrote: > Always use #.# format for the -i flag even when the current locale uses > a different separator. Locale de_DE which uses #,# normally. > > Simple testcase: > $ make USE_IDN=1 > $ LANG=de_DE.UTF8 ./ping -i 0.5 localhost > > Reported-by: Sergey Fionov > Signed-off-by: Mi

Re: [PATCH iputils 1/6] start gitignore files

2016-06-01 Thread YOSHIFUJI Hideaki
Hi, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger > --- > .gitignore | 22 ++ > doc/.gitignore | 2 ++ > 2 files changed, 24 insertions(+) > create mode 100644 .gitignore > create mode 100644 doc/.gitignore > files under ninfod/ as well, maybe? -- Hideaki Y

Re: [PATCH iputils 3/6] ping6: allow disabling of openssl support

2016-06-01 Thread YOSHIFUJI Hideaki
Hi, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger > --- > Makefile | 5 - > iputils_md5dig.h | 4 +++- > ping6.c | 10 ++ > 3 files changed, 17 insertions(+), 2 deletions(-) > : > diff --git a/ping6.c b/ping6.c > index 6d1a6db..cd140e2 100644 > --- a/ping

[Patch v2 5/5] drivers/net: support hdlc function for QE-UCC

2016-06-01 Thread Zhao Qiang
The driver add hdlc support for Freescale QUICC Engine. It support NMSI and TSA mode. Signed-off-by: Zhao Qiang --- Changes for v2: - remove useless code. - remove Unnecessary casts - return IRQ_NONE when there are no interrupt - remove Useless comments MAINTAINE

[PATCH v2 4/5] fsl/qe: Add QE TDM lib

2016-06-01 Thread Zhao Qiang
QE has module to support TDM, some other protocols supported by QE are based on TDM. add a qe-tdm lib, this lib provides functions to the protocols using TDM to configurate QE-TDM. Signed-off-by: Zhao Qiang --- Changes for v2: - delete dead code - use strcmp instead of strcasecmp

[PATCH v2 3/5] fsl/qe: Make regs resouce_size_t

2016-06-01 Thread Zhao Qiang
Signed-off-by: Zhao Qiang --- Changes for v2: - modify subject include/soc/fsl/qe/ucc_fast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/soc/fsl/qe/ucc_fast.h b/include/soc/fsl/qe/ucc_fast.h index b2633b7..e898895 100644 --- a/include/soc/fsl/qe/ucc_fast.h

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario_Limonciello
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, June 1, 2016 6:07 PM > To: Limonciello, Mario > Cc: and...@lunn.ch; hayesw...@realtek.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; linux-...@vger.kernel.org; pali.ro...@gmail.com; >

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:15 +0200, Arnd Bergmann wrote: > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > new file mode 100644 > index ..2f30698f5bcf > --- /dev/null > +++ b/drivers/soc/fsl/guts.c > @@ -0,0 +1,130 @@ > +/* > + * Freescale QorIQ Platforms GUTS Driver > + *

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > All users of this driver are PowerPC specific and the header file > has no business in the global include/linux/ hierarchy, so move > it back before anyone starts using it on ARM. > > This reverts commit 948486544713492f00ac8a9572909101ea89

Re: [net-next PATCH 1/2] net: Add function to allow configuration of RPS

2016-06-01 Thread Alexander Duyck
On Wed, Jun 1, 2016 at 6:17 PM, Alexander Duyck wrote: > This patch gives drivers the ability to set their own default RPS > configuration. The general idea is to allow drivers that might benefit > from enabling RPS an opportunity to configure it for themselves. > > Signed-off-by: Alexander Duyck

[net-next PATCH 2/2] tun: Configure Rx queues to default to RPS enabled

2016-06-01 Thread Alexander Duyck
This patch enables tun/tap interfaces to use RPS by default. The motivation behind this is to address the fact that the interfaces are currently using netif_rx_ni which in turn will queue packets on whatever CPU the function is called on, and when combined with load balancing this can result in pa

[net-next PATCH 1/2] net: Add function to allow configuration of RPS

2016-06-01 Thread Alexander Duyck
This patch gives drivers the ability to set their own default RPS configuration. The general idea is to allow drivers that might benefit from enabling RPS an opportunity to configure it for themselves. Signed-off-by: Alexander Duyck --- include/linux/netdevice.h |9 net/core/dev.c

[net-next PATCH 0/2] Prevent packet reordering on tap/tun interfaces

2016-06-01 Thread Alexander Duyck
This patch set is meant to address a recent issue I found with VMs sending traffic across a network. Specifically what I found was that the tap interfaces were spreading single flows across all CPUs on the system due to the fact that the sending VM was being load balanced across them. Under light

Re: [PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:16 +0200, Arnd Bergmann wrote: > This is a rewrite of an earlier patch from Yangbo Lu, adding a quirk > for the NXP QorIQ T4240 in the detection of the host device version. > > Unfortunately, this device cannot be detected using the compatible > string, as we have to suppo

Re: [PATCH 0/7] Netfilter fixes for net

2016-06-01 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 1 Jun 2016 14:03:17 +0200 > The following patchset contains Netfilter fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks Pablo.

Re: IOV iterator bug in net tree

2016-06-01 Thread Alexander Duyck
On Wed, Jun 1, 2016 at 5:42 PM, David Miller wrote: > From: Alexander Duyck > Date: Fri, 27 May 2016 21:32:39 -0700 > >> On Fri, May 27, 2016 at 11:21 AM, Alexander Duyck >> wrote: >>> I started out this morning by trying to run DevStack on the latest >>> "net' kernel and it looks like I am hang

Re: pull-request: mac80211 2016-06-01

2016-06-01 Thread David Miller
From: Johannes Berg Date: Wed, 1 Jun 2016 12:11:14 +0200 > For now, I have just three fixes for the current cycle. > > One of them, the hwsim one, becomes interesting with some pending > work to make hwsim work for unprivileged users in namespaces, and > I don't want to allow them to crash the

Re: [v2 PATCH 0/2] macvlan: Avoid unnecessary multicast cloning

2016-06-01 Thread David Miller
From: Herbert Xu Date: Wed, 1 Jun 2016 11:42:18 +0800 > This patch tries to improve macvlan multicast performance by > maintaining a filter hash at the macvlan_port level so that we > can quickly determine whether a given packet is needed or not. > > It is preceded by a patch that fixes a potent

Re: IOV iterator bug in net tree

2016-06-01 Thread David Miller
From: Alexander Duyck Date: Fri, 27 May 2016 21:32:39 -0700 > On Fri, May 27, 2016 at 11:21 AM, Alexander Duyck > wrote: >> I started out this morning by trying to run DevStack on the latest >> "net' kernel and it looks like I am hanging on some sort of locking >> problem with RabbitMQ. Specifi

Re: [PATCH net-next] udp: avoid csum_partial() for validated skb

2016-06-01 Thread David Miller
From: Eric Dumazet Date: Tue, 31 May 2016 15:22:41 -0700 > From: Eric Dumazet > > In commit e6afc8ace6dd5 ("udp: remove headers from UDP packets before > queueing"), udp_csum_pull_header() helper was added but missed fact > that CHECKSUM_UNNECESSARY packets were now converted to CHECKSUM_NONE >

[PATCH] netfilter/nflog: nflog-range does not truncate packets

2016-06-01 Thread Vishwanath Pai
netfilter/nflog: nflog-range does not truncate packets The --nflog-range parameter from userspace is ignored in the kernel and the entire packet is sent to the userspace. The per-instance parameter copy_range still works, with this change --nflog-range will have preference over copy_range. Signed

[PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-06-01 Thread Vishwanath Pai
libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit Add the following iptables rule. $ iptables -A INPUT -m hashlimit --hashlimit-above 200/sec \ --hashlimit-burst 5 --hashlimit-mode srcip --hashlimit-name hashlimit1 \ --hashlimit-htable-expire 3 -j DROP $ iptab

[PATCH iptables 1/3] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-06-01 Thread Vishwanath Pai
libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2 I am planning to add a revision 2 for the hashlimit xtables module to support higher packets per second rates. This patch renames all the functions and variables related to revision 1 by adding _v1 at the end of the names. Signed-off-by: V

[PATCH iptables 2/3] libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates

2016-06-01 Thread Vishwanath Pai
libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates Create a new revision for the hashlimit iptables extension module. Rev 2 will support higher pps of upto 1 million, Version 1 supports only 10k. To support this we have to increase the size of the variables avg and bur

[PATCH 3/3] netfilter: iptables-restore does not work as expected with xt_hashlimit

2016-06-01 Thread Vishwanath Pai
netfilter: iptables-restore does not work as expected with xt_hashlimit Add the following iptables rule. $ iptables -A INPUT -m hashlimit --hashlimit-above 200/sec \ --hashlimit-burst 5 --hashlimit-mode srcip --hashlimit-name hashlimit1 \ --hashlimit-htable-expire 3 -j DROP $ iptables-sa

[PATCH 2/3] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

2016-06-01 Thread Vishwanath Pai
netfilter: Create revision 2 of xt_hashlimit to support higher pps rates Create a new revision for the hashlimit iptables extension module. Rev 2 will support higher pps of upto 1 million, Version 1 supports only 10k. To support this we have to increase the size of the variables avg and burst in

[PATCH 1/3] netfilter: Prepare xt_hashlimit.c for revision 2

2016-06-01 Thread Vishwanath Pai
netfilter: Prepare xt_hashlimit.c for revision 2 I am planning to add a revision 2 for the hashlimit xtables module to support higher packets per second rates. This patch renames all the functions and variables related to revision 1 by adding _v1 at the end of the names. Signed-off-by: Vishwanath

Re: [v2 PATCH 1/2] macvlan: Fix potential use-after free for broadcasts

2016-06-01 Thread Cong Wang
On Tue, May 31, 2016 at 9:27 PM, Herbert Xu wrote: > On Tue, May 31, 2016 at 09:19:37PM -0700, Cong Wang wrote: >> >> Hmm, why could this happen? The upper device should be linked >> with the lower device, where a refcount is already held. >> Also, the work is cancelled in ->uninit(). > > Of cours

[Patch net] sch_prio: update backlog as well

2016-06-01 Thread Cong Wang
We need to update backlog too when we update qlen. Joint work with Stas. Reported-by: Stas Nichiporovich Tested-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_prio.c | 4 1 file ch

[Patch net] sch_hfsc: always keep backlog updated

2016-06-01 Thread Cong Wang
hfsc updates backlog lazily, that is only when we dump the stats. This is problematic after we begin to update backlog in qdisc_tree_reduce_backlog(). Reported-by: Stas Nichiporovich Tested-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi S

[Patch net] act_police: fix a crash during removal

2016-06-01 Thread Cong Wang
The police action is using its own code to initialize tcf hash info, which makes us to forgot to initialize a->hinfo correctly. Fix this by calling the helper function tcf_hash_create() directly. This patch fixed the following crash: BUG: unable to handle kernel NULL pointer dereference at 0

[Patch net] sch_tbf: update backlog as well

2016-06-01 Thread Cong Wang
Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_tbf.c | 4 1 file changed, 4 insertions(+) diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index 83b90b5..3161e49 100644 --- a/net/sched/sch_tbf.c +++ b

Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-01 Thread David Miller
From: Pramod Kumar Date: Tue, 31 May 2016 19:06:39 +0530 > +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) > +{ > + u32 val; > + unsigned int timeout = 1000; /* loop for 1s */ Please order your local variable declarations from longest to shortest line. > +static in

[Patch net] sch_drr: update backlog as well

2016-06-01 Thread Cong Wang
Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_drr.c | 4 1 file changed, 4 insertions(+) diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c index a63e879..bf8af2c 100644 --- a/net/sched/sch_drr.c +++ b

[Patch net] sch_red: update backlog as well

2016-06-01 Thread Cong Wang
Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_red.c | 4 1 file changed, 4 insertions(+) diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c index 8c0508c..91578bd 100644 --- a/net/sched/sch_red.c +++ b

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

2016-06-01 Thread Julian Calaby
Hi Javier, On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas wrote: > Hello Julian, > > Thanks a lot for your feedback and reviews. > > On 06/01/2016 12:20 AM, Julian Calaby wrote: >> Hi All, >> >> On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas >> wrote: >>> The Documentation

Re: [RFC 01/12] add basic register-field manipulation macros

2016-06-01 Thread Jakub Kicinski
On Wed, 01 Jun 2016 22:15:36 +0200, Hannes Frederic Sowa wrote: > Hello, > > On Wed, Jun 1, 2016, at 18:50, Jakub Kicinski wrote: > > C bitfields are problematic and best avoided. Developers > > interacting with hardware registers find themselves searching > > for easy-to-use alternatives. Commo

Re: [PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

2016-06-01 Thread David Miller
From: Yisen Zhuang Date: Mon, 30 May 2016 20:34:14 +0800 > -static void hns_mdio_bus_name(char *name, struct device_node *np) > +static void hns_mdio_bus_name(char *name, phys_addr_t addr) > { > - const u32 *addr; > - u64 taddr = OF_BAD_ADDR; > - > - addr = of_get_address(np, 0, NULL

Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Greg KH
On Wed, Jun 01, 2016 at 10:31:52PM +, mario_limoncie...@dell.com wrote: > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Wednesday, June 1, 2016 5:27 PM > > To: Limonciello, Mario > > Cc: hayesw...@realtek.com; LKML ; Netdev > > ; Linux USB ; > > pali.ro..

Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Greg KH
On Wed, Jun 01, 2016 at 04:50:44PM -0500, Mario Limonciello wrote: > Dell systems with Type-C ports have support for a persistent system > specific MAC address when used with Dell Type-C docks and dongles. > This means a dock plugged into two different systems will show different > (but persistent)

Re: [RFC 06/12] nfp: add hardware cls_bpf offload

2016-06-01 Thread Daniel Borkmann
On 06/01/2016 06:50 PM, Jakub Kicinski wrote: Add hardware cls_bpf offload on our smart NICs. Detect if capable firmware is loaded and use it to load the code JITed with just added translator onto programmable engines. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by:

Re: [PATCH net-next] ravb: Add SET_RUNTIME_PM_OPS macro

2016-06-01 Thread David Miller
From: Yoshihiro Kaneko Date: Mon, 30 May 2016 05:25:43 +0900 > From: Kazuya Mizuguchi > > Use SET_RUNTIME_PM_OPS macro instead of assigning a member of > dev_pm_ops directly. > > Signed-off-by: Kazuya Mizuguchi > Signed-off-by: Yoshihiro Kaneko Applied.

Re: [RFC 07/12] nfp: add skb mark support to the bpf offload

2016-06-01 Thread Jakub Kicinski
On Thu, 02 Jun 2016 00:30:07 +0200, Daniel Borkmann wrote: > On 06/02/2016 12:19 AM, Jakub Kicinski wrote: > > On Wed, 1 Jun 2016 14:56:26 -0700, Alexei Starovoitov wrote: > >> On Wed, Jun 01, 2016 at 05:50:09PM +0100, Jakub Kicinski wrote: > >>> Skb marking should be set in designated register

Re: [PATCH net-next v2] ravb: Add ESF in RCR for enabling separation filter

2016-06-01 Thread David Miller
From: Yoshihiro Kaneko Date: Wed, 1 Jun 2016 03:01:28 +0900 > From: Masaru Nagai > > The H/W manual recommends B'10 or B'11 in a value of the separation > filtering select bits in the receive configuration register (RCR.ESF). > When B'10 is set, frames from non-matching streams are discarded.

Re: [RFC 12/12] nfp: bpf: add denser mode of execution

2016-06-01 Thread Jakub Kicinski
On Wed, 1 Jun 2016 15:01:16 -0700, Alexei Starovoitov wrote: > On Wed, Jun 01, 2016 at 05:50:14PM +0100, Jakub Kicinski wrote: > > If BPF uses less than 7 registers programmable engines > > can process twice as many packets in parallel. Signal > > this denser mode of operation to FW by setting the

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario_Limonciello
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, June 1, 2016 5:27 PM > To: Limonciello, Mario > Cc: hayesw...@realtek.com; LKML ; Netdev > ; Linux USB ; > pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: Re: [PATCH] r8152: Add support for sett

Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-06-01 Thread Greg Rose
On Wed, Jun 1, 2016 at 3:07 PM, Phil Sutter wrote: > On Wed, Jun 01, 2016 at 03:00:08PM -0700, Greg Rose wrote: >> On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter wrote: >> > Not sure whether I misinterpret commit 7b8179c780a1a, but it looks >> > overly complicated. Instead rely upon parse_rtattr_nes

Re: [Intel-wired-lan] [RFC PATCH net] e1000e: keep vlan interfaces functional after rxvlan off

2016-06-01 Thread Alexander Duyck
On Wed, Jun 1, 2016 at 12:27 PM, Jarod Wilson wrote: > On Wed, Jun 01, 2016 at 07:31:53AM -0700, Alexander Duyck wrote: >> On Tue, May 17, 2016 at 12:03 PM, Jarod Wilson wrote: >> > I've got a bug report about an e1000e interface, where a vlan interface is >> > set up on top of it: >> > >> > $ ip

Re: [RFC 07/12] nfp: add skb mark support to the bpf offload

2016-06-01 Thread Daniel Borkmann
On 06/02/2016 12:19 AM, Jakub Kicinski wrote: On Wed, 1 Jun 2016 14:56:26 -0700, Alexei Starovoitov wrote: On Wed, Jun 01, 2016 at 05:50:09PM +0100, Jakub Kicinski wrote: Skb marking should be set in designated register, FW will prepend it to the packet for us. Signed-off-by: Jakub Kicinski R

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-06-01 Thread Timur Tabi
Florian Fainelli wrote: +/* Transmit the packet */ >+static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev) >+{ >+ struct emac_adapter *adpt = netdev_priv(netdev); >+ >+ return emac_mac_tx_buf_send(adpt, &adpt->tx_q, skb); I would inline emac_mac_tx_buf_send()'s body he

Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Andrew Lunn
On Wed, Jun 01, 2016 at 04:50:44PM -0500, Mario Limonciello wrote: > Dell systems with Type-C ports have support for a persistent system > specific MAC address when used with Dell Type-C docks and dongles. > This means a dock plugged into two different systems will show different > (but persistent)

Re: [RFC 07/12] nfp: add skb mark support to the bpf offload

2016-06-01 Thread Jakub Kicinski
On Wed, 1 Jun 2016 14:56:26 -0700, Alexei Starovoitov wrote: > On Wed, Jun 01, 2016 at 05:50:09PM +0100, Jakub Kicinski wrote: > > Skb marking should be set in designated register, FW will > > prepend it to the packet for us. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-by: Dinan Gunawarden

Re: [RFC 08/12] net: cls_bpf: allow offloaded filters to update stats

2016-06-01 Thread Daniel Borkmann
On 06/01/2016 06:50 PM, Jakub Kicinski wrote: Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman Acked-by: Daniel Borkmann

Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-06-01 Thread Phil Sutter
On Wed, Jun 01, 2016 at 03:00:08PM -0700, Greg Rose wrote: > On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter wrote: > > Not sure whether I misinterpret commit 7b8179c780a1a, but it looks > > overly complicated. Instead rely upon parse_rtattr_nested() to assign > > the relevant pointer if requested rta

Re: [RFC 12/12] nfp: bpf: add denser mode of execution

2016-06-01 Thread Alexei Starovoitov
On Wed, Jun 01, 2016 at 05:50:14PM +0100, Jakub Kicinski wrote: > If BPF uses less than 7 registers programmable engines > can process twice as many packets in parallel. Signal > this denser mode of operation to FW by setting the lowest > bit in DMA address of the machine code buffer. > > Signed-

Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-06-01 Thread Greg Rose
On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter wrote: > Not sure whether I misinterpret commit 7b8179c780a1a, but it looks > overly complicated. Instead rely upon parse_rtattr_nested() to assign > the relevant pointer if requested rtattr fields are present. I'm not sure if newer iproute2 utilities a

Re: [iproute PATCH] ipaddress: Allow listing addresses by type

2016-06-01 Thread Vadim Kochan
On Wed, Jun 01, 2016 at 09:57:27PM +0200, Phil Sutter wrote: > Not sure why this was limited to ip-link before. It is semantically > equal to the 'master' keyword, which is not restricted at all. > Hi Phil, I don't remember why I did so, but you are right, it might be used for 'ip addr' too. > C

Re: [RFC 07/12] nfp: add skb mark support to the bpf offload

2016-06-01 Thread Alexei Starovoitov
On Wed, Jun 01, 2016 at 05:50:09PM +0100, Jakub Kicinski wrote: > Skb marking should be set in designated register, FW will > prepend it to the packet for us. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dinan Gunawardena > Reviewed-by: Simon Horman > --- > drivers/net/ethernet/netronome/n

Re: [RFC 06/12] nfp: add hardware cls_bpf offload

2016-06-01 Thread Alexei Starovoitov
On Wed, Jun 01, 2016 at 10:15:57PM +0100, Jakub Kicinski wrote: > On Wed, 1 Jun 2016 13:52:01 -0700, Alexei Starovoitov wrote: > > On Wed, Jun 01, 2016 at 10:20:54PM +0200, Daniel Borkmann wrote: > > > On 06/01/2016 06:50 PM, Jakub Kicinski wrote: > > > >Add hardware cls_bpf offload on our smart

[PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario Limonciello
Dell systems with Type-C ports have support for a persistent system specific MAC address when used with Dell Type-C docks and dongles. This means a dock plugged into two different systems will show different (but persistent) MAC addresses. Dell Type-C docks and dongles use the r8152 driver. This

Re: [PATCH net-next] sctp: sctp should change socket state when shutdown is received

2016-06-01 Thread Marcelo Ricardo Leitner
On Thu, Jun 02, 2016 at 03:38:45AM +0800, Xin Long wrote: > Now sctp doesn't change socket state upon shutdown reception. It changes > just the assoc state, even though it's a TCP-style socket. > > For some cases, if we really need to check sk->sk_state, it's necessary to > fix this issue, at leas

Re: [RFC 06/12] nfp: add hardware cls_bpf offload

2016-06-01 Thread John Fastabend
On 16-06-01 01:52 PM, Alexei Starovoitov wrote: > On Wed, Jun 01, 2016 at 10:20:54PM +0200, Daniel Borkmann wrote: >> On 06/01/2016 06:50 PM, Jakub Kicinski wrote: >>> Add hardware cls_bpf offload on our smart NICs. Detect if >>> capable firmware is loaded and use it to load the code JITed >>> wit

Re: [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag

2016-06-01 Thread Daniel Borkmann
On 06/01/2016 11:26 PM, Jakub Kicinski wrote: On Wed, 01 Jun 2016 23:21:40 +0200, Daniel Borkmann wrote: On 06/01/2016 11:05 PM, Jakub Kicinski wrote: On Wed, 01 Jun 2016 21:40:23 +0200, Daniel Borkmann wrote: [...] @@ -400,8 +406,11 @@ static int cls_bpf_modify_existing(struct net *net, stru

Re: [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag

2016-06-01 Thread Jakub Kicinski
On Wed, 01 Jun 2016 23:21:40 +0200, Daniel Borkmann wrote: > On 06/01/2016 11:05 PM, Jakub Kicinski wrote: > > On Wed, 01 Jun 2016 21:40:23 +0200, Daniel Borkmann wrote: > [...] > >>> @@ -400,8 +406,11 @@ static int cls_bpf_modify_existing(struct net *net, > >>> struct tcf_proto *tp, > >>> > >>>

Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

2016-06-01 Thread Max Filippov
On Wed, Jun 01, 2016 at 02:16:50PM +0100, Colin King wrote: > From: Colin Ian King > > priv is assigned to NULL however some of the early error exit paths to > label 'free' dereference priv, causing a null pointer dereference. > > Move the label 'free' to just the free_netdev statement, and add

  1   2   3   >