Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump

[David Miller]

From: Kangjie Lu <kangji...@gmail.com>
Date: Wed,  1 Jun 2016 12:34:55 -0400

> diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
> index f795b1d..115aafa 100644
> --- a/net/tipc/netlink_compat.c
> +++ b/net/tipc/netlink_compat.c
> @@ -604,6 +604,7 @@ static int tipc_nl_compat_link_dump(struct 
> tipc_nl_compat_msg *msg,
>  
>       link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
>       link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
> +     memset((void *)link_info.str, 0, TIPC_MAX_LINK_NAME);
>       strcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME]));
>  

Please instead use "nla_strlcpy()".

Thanks.