> > +static u8 amac_ascii_to_hex(int c)
> > +{
> > + if (c <= 0x39)
> > + return (u8)(c - 0x30);
> > + else if (c <= 0x46)
> > + return (u8)(c - 0x37);
> > + return (u8)(c - 0x57);
> > +}
>
Sorry forgot to address this.
> We really don't have such a function somewhere in the kernel already?
There is a function in acpi/acpica/uthex.c that does this, but it doesn't seem
to be used by anything outside of acpica so far. Would it be OK style wise to
#include " ../../acpi/acpica/acutils.h" from r8152.c?
If not, then what is the proper thing to do here to re-use it from there?
> And why 'int', isn't "c" really a u8?
Yeah I guess u8 should be fine there, and avoid the casting then too.
