Re: [PATCH] iwlwifi: fix erroneous return value

2016-02-10 Thread Grumbach, Emmanuel
On 02/10/2016 07:10 PM, Anton Protopopov wrote: > The iwl_trans_pcie_start_fw() function may return the positive value EIO > instead of -EIO in case of error. > > Signed-off-by: Anton Protopopov > --- > drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH net v4] r8169: Bad implementation of netif_carrier_*

2016-02-10 Thread Corcodel Marian
On probe stage what carrier to stop and rest two situation netif_carrier_* is slow and disturbing autonegociation process. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/dri

Business Partnership

2016-02-10 Thread EYADEMA
Hello, I am Mr. LAURENT EYADEMA from Republic of Togo.please read the attached proposal. Thanks in anticipation of your urgent response, LAURENT EYADEMA proposal.docx Description: Binary data

Re: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

2016-02-10 Thread Florian Fainelli
On 10/02/2016 15:18, woojung@microchip.com wrote: >>> +static int lan88xx_config_init(struct phy_device *phydev) >>> +{ >>> + phydev->supported &= phydev->drv->features; >>> + phydev->advertising &= phydev->drv->features; >> >> This looks suspicious, phy_probe() takes the driver supported

RE: [Intel-wired-lan] [PATCH] igb: Fix VLAN tag stripping on Intel i350

2016-02-10 Thread Brown, Aaron F
> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Corinna Vinschen [vinsc...@redhat.com] > Sent: Thursday, January 28, 2016 4:53 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [PATCH] igb:

Business Partnership

2016-02-10 Thread EYADEMA
Hello, I am Mr. LAURENT EYADEMA from Republic of Togo.please read the attached proposal. Thanks in anticipation of your urgent response, LAURENT EYADEMA proposal.docx Description: Binary data

Re: possible patch

2016-02-10 Thread Jonathan Corbet
On Wed, 10 Feb 2016 19:49:11 -0500 Justin Keller wrote: > I am new to submitting patches, so sorry if I am doing it wrong. My idea was > to change line 147 in drivers/isdn/pcbit/callbacks.c from > if (cbdata->data.setup.CallingPN == NULL) { > > to > > if (cbdata->data.setup.CallingPN == NULL ||

linux-next: manual merge of the net-next tree with the net tree

2016-02-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/vxlan.c between commit: 72564b59ffc4 ("vxlan: Relax MTU constraints") from the net tree and commit: 1a8496ba4091 ("vxlan: consolidate output route calculation") from the net-next tree. I fixed it up (

Re: [PATCH net-next v7 15/19] net: bridge: use __ethtool_get_ksettings

2016-02-10 Thread Stephen Hemminger
On Sun, 7 Feb 2016 17:08:59 -0800 David Decotigny wrote: > From: David Decotigny > > Signed-off-by: David Decotigny > --- > net/bridge/br_if.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c > index c367b3e..cafe4e6 1006

Re: [PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-10 Thread Stephen Hemminger
On Tue, 9 Feb 2016 16:29:09 -0800 David Decotigny wrote: > Along the way, I chose to drop in the new structure the 3 ethtool_cmd > fields marked "deprecated" (transceiver/maxrxpkt/maxtxpkt). They are > still available for old drivers via the (old) ETHTOOL_GSET/SSET API, > but are not available t

possible patch

2016-02-10 Thread Justin Keller
Hello, I am new to submitting patches, so sorry if I am doing it wrong. My idea was to change line 147 in drivers/isdn/pcbit/callbacks.c from if (cbdata->data.setup.CallingPN == NULL) { to if (cbdata->data.setup.CallingPN == NULL || sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phon

RE: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

2016-02-10 Thread Woojung.Huh
> > +static int lan88xx_config_init(struct phy_device *phydev) > > +{ > > + phydev->supported &= phydev->drv->features; > > + phydev->advertising &= phydev->drv->features; > > This looks suspicious, phy_probe() takes the driver supported features > and assigns it to phydev->supported, and phyd

Re: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

2016-02-10 Thread Florian Fainelli
On 10/02/16 13:13, woojung@microchip.com wrote: > > Update to set default phy supported & advertising features from phy device > structure and remove unnecessary code in the nic driver. > > Signed-off-by: Woojung Huh > --- > drivers/net/phy/microchip.c | 10 +- > drivers/net/usb/lan

RE: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

2016-02-10 Thread Woojung.Huh
Thanks Sergei & Andrew, Will remove extra brackets and repost. Woojung > > @@ -471,7 +472,7 @@ static int lan78xx_read_raw_eeprom(struct > lan78xx_net *dev, u32 offset, > > */ > > ret = lan78xx_read_reg(dev, HW_CFG, &val); > > saved = val; > > - if ((dev->devid & ID_REV_CHIP_ID_MA

Re: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

2016-02-10 Thread Andrew Lunn
On Wed, Feb 10, 2016 at 09:13:37PM +, woojung@microchip.com wrote: > > Replace devid to chipid & chiprev for easy access. > > Signed-off-by: Woojung Huh > --- > drivers/net/usb/lan78xx.c | 20 +++- > drivers/net/usb/lan78xx.h | 1 + > 2 files changed, 12 insertions(+),

RE: [tipc-discussion] [PATCH net-next v2] tipc: add peer removal functionality

2016-02-10 Thread Jon Maloy
> -Original Message- > From: jason [mailto:huzhiji...@gmail.com] > Sent: Wednesday, 10 February, 2016 15:34 > To: Jon Maloy > Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; Richard > Alpe > Subject: RE: [tipc-discussion] [PATCH net-next v2] tipc: add peer removal > fun

[PATCH net 5/5] bnxt_en: Reduce default ring sizes.

2016-02-10 Thread Michael Chan
The current default tx ring size of 512 causes an extra page to be allocated for the tx ring with only 1 entry in it. Reduce it to 511. The default rx ring size is also reduced to 511 to use less memory by default. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +

[PATCH net 2/5] bnxt_en: Cleanup and Fix flow control setup logic

2016-02-10 Thread Michael Chan
Cleanup bnxt_probe_phy() to cleanly separate 2 code blocks for autoneg on and off. Autoneg flow control is possible only if autoneg is enabled. In bnxt_get_settings(), Pause and Asym_Pause are always supported. Only the advertisement bits change depending on the ethtool -A setting in auto mode.

[PATCH net 0/5] bnxt_en: Bug fixes.

2016-02-10 Thread Michael Chan
Fixed autoneg logic and some related cleanups, fixed tx push operation, and reduced default ring sizes. Michael Chan (5): bnxt_en: Fix ethtool autoneg logic. bnxt_en: Cleanup and Fix flow control setup logic bnxt_en: Remove 20G support and advertise only 40GbaseCR4. bnxt_en: Fix implementa

[PATCH net 3/5] bnxt_en: Remove 20G support and advertise only 40GbaseCR4.

2016-02-10 Thread Michael Chan
20G is not supported by production hardware and only the 40GbaseCR4 standard is supported. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bn

[PATCH net 1/5] bnxt_en: Fix ethtool autoneg logic.

2016-02-10 Thread Michael Chan
1. Determine autoneg on|off setting from link_info->autoneg. Using the firmware returned setting can be misleading if autoneg is changed and there hasn't been a phy update from the firmware. 2. If autoneg is disabled, link_info->autoneg should be set to 0 to indicate both speed and flow control a

[PATCH net 4/5] bnxt_en: Fix implementation of tx push operation.

2016-02-10 Thread Michael Chan
tx push is supported for small packets to reduce DMA latency. The following bugs are fixed in this patch: 1. Fix the definition of the push BD which is different from the DMA BD. 2. The push buffer has to be zero padded to the next 64-bit word boundary or tx checksum won't be correct. 3. Increase

Re: Micrel PHY and power down mode

2016-02-10 Thread Stefan Agner
On 2016-02-10 14:10, Florian Fainelli wrote: > Hi Stefan, > > On 10/02/16 11:25, Stefan Agner wrote: >> Hi David, Hi Florian, >> >> We use a Micrel KSZ8041NL and we observe sometimes continuous RX errors >> (PHY's RXER counter is continuously incrementing, activity LED blinks >> and no communicati

Re: [PATCH net] bpf: fix branch offset adjustment on backjumps after patching ctx expansion

2016-02-10 Thread David Miller
From: Daniel Borkmann Date: Wed, 10 Feb 2016 16:47:11 +0100 > When ctx access is used, the kernel often needs to expand/rewrite > instructions, so after that patching, branch offsets have to be > adjusted for both forward and backward jumps in the new eBPF program, > but for backward jumps it fai

Re: Micrel PHY and power down mode

2016-02-10 Thread Florian Fainelli
Hi Stefan, On 10/02/16 11:25, Stefan Agner wrote: > Hi David, Hi Florian, > > We use a Micrel KSZ8041NL and we observe sometimes continuous RX errors > (PHY's RXER counter is continuously incrementing, activity LED blinks > and no communication is possible). It seems that only some PHY's are > af

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-10 Thread Diego Viola
On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: > Hi Guo, > > I have an x86 computer with this network card: > > 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260 PCI > Express Fast Ethernet Controller (rev 03) > > Every time I initiate a suspend (systemctl suspend) the machine hang

Re: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

2016-02-10 Thread Sergei Shtylyov
On 02/11/2016 12:13 AM, woojung@microchip.com wrote: Replace devid to chipid & chiprev for easy access. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 20 +++- drivers/net/usb/lan78xx.h | 1 + 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/

[PATCH net 1/1] tipc: fix premature addition of node to lookup table

2016-02-10 Thread Jon Maloy
In commit 5266698661401a ("tipc: let broadcast packet reception use new link receive function") we introduced a new per-node broadcast reception link instance. This link is created at the moment the node itself is created. Unfortunately, the allocation is done after the node instance has already be

[PATCH net-next 3/3] lan78xx: add ethtool set & get pause functions

2016-02-10 Thread Woojung.Huh
Add ethtool operations of set_pauseram and get_pauseparm. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 88 --- 1 file changed, 83 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 1fd

[PATCH net-next 0/3] lan78xx: driver update

2016-02-10 Thread Woojung.Huh
Hi, This patch series update to get correct features from phylib and add new ethtool functions of set_pauseparam and get_pauseparam. Woojung Huh (3): lan78xx: replace devid to chipid & chiprev lan78xx: setting phy features in phy driver lan78xx: add ethtool set & get pause functions drive

[PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

2016-02-10 Thread Woojung.Huh
Replace devid to chipid & chiprev for easy access. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 20 +++- drivers/net/usb/lan78xx.h | 1 + 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 1c

[PATCH net-next 2/3] lan78xx: setting phy features in phy driver

2016-02-10 Thread Woojung.Huh
Update to set default phy supported & advertising features from phy device structure and remove unnecessary code in the nic driver. Signed-off-by: Woojung Huh --- drivers/net/phy/microchip.c | 10 +- drivers/net/usb/lan78xx.c | 7 +-- 2 files changed, 10 insertions(+), 7 deletion

Re: [net-next PATCH 06/11] RFC: mlx5: RX bulking or bundling of packets before calling network stack

2016-02-10 Thread Jesper Dangaard Brouer
On Tue, 9 Feb 2016 13:57:41 +0200 Saeed Mahameed wrote: > On Tue, Feb 2, 2016 at 11:13 PM, Jesper Dangaard Brouer > wrote: > > There are several techniques/concepts combined in this optimization. > > It is both a data-cache and instruction-cache optimization. > > > > First of all, this is primar

RE: [tipc-discussion] [PATCH net-next v2] tipc: add peer removal functionality

2016-02-10 Thread Jon Maloy
There is of course a CPU3 involved in the first scenario. Just forgot to add it to the header. ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jon Maloy > Sent: Wednesday, 10 February, 2016 14:44 > To: jason; Richard

RE: [tipc-discussion] [PATCH net-next v2] tipc: add peer removal functionality

2016-02-10 Thread Jon Maloy
Hi Jason, I believe you are right, although the real problem is not what you think it is. I can see at least two interesting scenarios here, of which I believe you are alluding to the first one below. However, I don't think the problem is the way Richard is using node_stop(), but rather with node

ip xfrm transport mode forwarding policy

2016-02-10 Thread Mukesh Hira
Hi, For a particular application, I am working on configuring a Linux host to receive IPSec traffic in transport mode on one interface, decrypt and forward the traffic in the clear on another interface. I have configured a transport mode ip xfrm policy with dir fwd and corresponding ip xfrm st

Micrel PHY and power down mode

2016-02-10 Thread Stefan Agner
Hi David, Hi Florian, We use a Micrel KSZ8041NL and we observe sometimes continuous RX errors (PHY's RXER counter is continuously incrementing, activity LED blinks and no communication is possible). It seems that only some PHY's are affected (3-4%) and only in certain temperature ranges (the PHY I

RE: [PATCH net-next] Add LAN9352 Ethernet Driver

2016-02-10 Thread Bryan.Whitehead
Hi Andrew, Thanks for your comment. The LAN9352 actually has 2 physical ports, and one virtual port which is tied internally to the 16-bit Non-PCI CPU Interface. This driver acts as a normal Ethernet controller on the virtual port, which itself is an input to the embedded switch. The switch di

RE: [PATCH net-next] Add LAN9352 Ethernet Driver

2016-02-10 Thread Bryan.Whitehead
Thanks David, I'll submit a revised patch soon. -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, February 10, 2016 5:34 AM To: Bryan Whitehead - C21958 Cc: netdev@vger.kernel.org; cor...@lwn.net Subject: Re: [PATCH net-next] Add LAN9352 Ethernet Driver

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-10 Thread Rasmus Villemoes
On Wed, Feb 10 2016, Yishai Hadas wrote: >> @@ -2429,7 +2429,7 @@ err_thread: >> flush_workqueue(priv->mfunc.master.comm_wq); >> destroy_workqueue(priv->mfunc.master.comm_wq); >> err_slaves: >> -while (--i) { >> +while (i--) { > > This fix is wrong as it hits the case that i a

Re: [PATCH net-next] Add LAN9352 Ethernet Driver

2016-02-10 Thread Andrew Lunn
On Tue, Feb 09, 2016 at 08:40:30PM +, bryan.whiteh...@microchip.com wrote: > This is the initial submission of an ethernet driver for > the Microchip LAN9352. > > The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch > with 16-Bit Non-PCI CPU Interface. > > While the LAN9352 is a Managed E

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-10 Thread Andrew Lunn
On Tue, Feb 09, 2016 at 09:01:12PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle Thanks for updating the Documentation. Reviewed-by: Andrew Lunn Andrew > --- > Changes compared to v1: > - Add

kernel BUG at net/netfilter/nf_nat_core.c:395

2016-02-10 Thread Oleksandr Natalenko
Hi. With 4.4.1 I've got BUG_ON() triggered in net/netfilter/nf_nat_core.c:395, nf_nat_setup_info(), today on my home router. Here is full trace got via netconsole: [1] I perform LAN NATting using nftables like this: === table ip nat { chain prerouting { type nat hook pr

Re: [PATCH] wlcore: Fix regression in wlcore_set_partition()

2016-02-10 Thread Kalle Valo
Emil Goode writes: > The below commit introduced a regression causing the wlcore > to time out and go into recovery. > > commit 3719c17e1816695f415dd3b4ddcb679f7dc617c8 > ("wlcore/wl18xx: fw logger over sdio") > > Reverting the changes regarding write of the last partition size > brings the modul

[PATCH net-next 1/2] be2net: Request RSS capability of Rx interface depending on number of Rx rings

2016-02-10 Thread ajit . khaparde
From: Ajit Khaparde Currently we request RSS capability even if a single Rx ring is created. As a result in few cases we unnecessarily consume an RSS capable interface which is a limited resource in the chip. This patch enables RSS on an interface only if more than one Rx ring is created. Signed

[PATCH net-next 0/2] be2net Patch series

2016-02-10 Thread ajit . khaparde
From: Ajit Khaparde Please consider applying these two patches to net-next Patch-1: Request RSS capability of Rx interface depending on number of Rx rings Patch-2: Interpret and log new data that's added to the port misconfigure async event drivers/net/ethernet/emulex/benet/be.h

[PATCH net-next 2/2] be2net: Interpret and log new data that's added to the port misconfigure async event

2016-02-10 Thread ajit . khaparde
From: Ajit Khaparde >From FW version 11.0. onwards, the PORT_MISCONFIG event generated by the FW will carry more information about the event in the "data_word1" and "data_word2" fields. This patch adds support in the driver to parse the new information and log it accordingly. This patch also chan

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-10 Thread Johannes Berg
On 2016-02-10 17:53, Dan Williams wrote: Yeah, I get that now.  It's just that to me, something called "AIRPLANE_MODE_CHANGE" seems like it should actually change airplane mode on/off, which implies killing radios.  I wouldn't have had the problem if it was named AIRPLANE_MODE_INDICATOR_CHANGE, w

[PATCH] iwlwifi: fix erroneous return value

2016-02-10 Thread Anton Protopopov
The iwl_trans_pcie_start_fw() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pc

[PATCH] ath10k: fix erroneous return value

2016-02-10 Thread Anton Protopopov
The ath10k_pci_hif_exchange_bmi_msg() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-10 Thread Andrew Lunn
On Wed, Feb 10, 2016 at 10:13:56AM +0100, John Holland wrote: > > > > Sent from my iPad > On Feb 9, 2016, at 12:54, Andrew Lunn wrote: > > >>> +static void igb_read_mac_addr_dts(struct e1000_hw *hw) > >>> +{ > >>> + const u8 *mac; > >>> + struct device_node *dn; > >>> + > >>> +

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-10 Thread Dan Williams
On Wed, 2016-02-10 at 17:07 +0100, Johannes Berg wrote: > On Mon, 2016-02-08 at 10:11 -0600, Dan Williams wrote: > > I'd like to clarify a bit, so tell me if I'm correct or not.  Using > > RFKILL_OP_AIRPLANE_MODE_CHANGE does not actually change any device > > state. It's just an indicator with no r

[PATCH net-next v4 5/7] soreuseport: Prep for fast reuseport TCP socket selection

2016-02-10 Thread Craig Gallek
From: Craig Gallek Both of the lines in this patch probably should have been included in the initial implementation of this code for generic socket support, but weren't technically necessary since only UDP sockets were supported. First, the sk_reuseport_cb points to a structure which assumes eac

[PATCH net-next v4 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-10 Thread Craig Gallek
From: Craig Gallek This change extends the fast SO_REUSEPORT socket lookup implemented for UDP to TCP. Listener sockets with SO_REUSEPORT and the same receive address are additionally added to an array for faster random access. This means that only a single socket from the group must be found i

[PATCH net-next v4 7/7] soreuseport: BPF selection functional test for TCP

2016-02-10 Thread Craig Gallek
From: Craig Gallek Unfortunately the existing test relied on packet payload in order to map incoming packets to sockets. In order to get this to work with TCP, TCP_FASTOPEN needed to be used. Since the fast open path is slightly different than the standard TCP path, I created a second test whic

[PATCH net-next v4 0/7] Faster SO_REUSEPORT for TCP

2016-02-10 Thread Craig Gallek
From: Craig Gallek This patch series complements an earlier series (6a5ef90c58da) which added faster SO_REUSEPORT lookup for UDP sockets by extending the feature to TCP sockets. It uses the same array-based data structure which allows for socket selection after finding the first listening socket

[PATCH net-next v4 1/7] sock: struct proto hash function may error

2016-02-10 Thread Craig Gallek
From: Craig Gallek In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at a

[PATCH net-next v4 4/7] inet: refactor inet[6]_lookup functions to take skb

2016-02-10 Thread Craig Gallek
From: Craig Gallek This is a preliminary step to allow fast socket lookup of SO_REUSEPORT groups. Doing so with a BPF filter will require access to the skb in question. This change plumbs the skb (and offset to payload data) through the call stack to the listening socket lookup implementations

[PATCH net-next v4 3/7] tcp: __tcp_hdrlen() helper

2016-02-10 Thread Craig Gallek
From: Craig Gallek tcp_hdrlen is wasteful if you already have a pointer to struct tcphdr. This splits the size calculation into a helper function that can be used if a struct tcphdr is already available. Signed-off-by: Craig Gallek --- include/linux/tcp.h | 7 ++- 1 file changed, 6 inserti

[PATCH net-next v4 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-10 Thread Craig Gallek
From: Craig Gallek In order to support fast lookups for TCP sockets with SO_REUSEPORT, the function that adds sockets to the listening hash set needs to be able to check receive address equality. Since this equality check is different for IPv4 and IPv6, we will need two different socket hashing

[PATCH 12/21] batman-adv: Convert batadv_tvlv_container to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 13/21] batman-adv: Convert batadv_tvlv_handler to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 11/21] batman-adv: Convert batadv_dat_entry to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 15/21] batman-adv: Convert batadv_neigh_ifinfo to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 21/21] batman-adv: Convert batadv_tt_common_entry to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 10/21] batman-adv: Convert batadv_nc_path to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 19/21] batman-adv: Convert batadv_orig_node_vlan to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 17/21] batman-adv: Convert batadv_neigh_node to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 20/21] batman-adv: Convert batadv_orig_node to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 14/21] batman-adv: Convert batadv_tt_orig_list_entry to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 16/21] batman-adv: Convert batadv_orig_ifinfo to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 18/21] batman-adv: Convert batadv_hard_iface to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-10 Thread Johannes Berg
On Mon, 2016-02-08 at 10:11 -0600, Dan Williams wrote: > I'd like to clarify a bit, so tell me if I'm correct or not.  Using > RFKILL_OP_AIRPLANE_MODE_CHANGE does not actually change any device > state. It's just an indicator with no relationship to any of the > registered rfkill switches, right?

[PATCH 09/21] batman-adv: Convert batadv_nc_node to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 07/21] batman-adv: Convert batadv_bla_backbone_gw to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 06/21] batman-adv: Convert batadv_softif_vlan to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 08/21] batman-adv: Convert batadv_bla_claim to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 04/21] batman-adv: Convert batadv_hardif_neigh_node to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 03/21] batman-adv: Add lockdep assert for container_list_lock

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann The batadv_tvlv_container* functions state in their kernel-doc that they require tvlv.container_list_lock. Add an assert to automatically detect when this might have been ignored by the caller. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Anton

[PATCH 02/21] batman-adv: add seqno maximum age and protection start flag parameters

2016-02-10 Thread Antonio Quartulli
From: Simon Wunderlich To allow future use of the window protected function with different maximum sequence numbers, add a parameter to set this value which was previously hardcoded. Another parameter added for future use is a flag to return whether the protection window has started. While at it

[PATCH 05/21] batman-adv: Convert batadv_gw_node to kref

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Li

[PATCH 01/21] batman-adv: Drop reference to netdevice on last reference

2016-02-10 Thread Antonio Quartulli
From: Sven Eckelmann The references to the network device should be dropped inside the release function for batadv_hard_iface similar to what is done with the batman-adv internal datastructures. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- n

pull request [net-next]: batman-adv 20160210

2016-02-10 Thread Antonio Quartulli
Hello David, this is another pull request intended for net-next. Here you have a batch of patches by Sven Eckelmann that drops our private reference counting implementation and substitutes it with the kref objects/functions. Then you have a patch, by Simon Wunderlich, that makes the broadcast pr

[PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-10 Thread Paolo Abeni
the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly controlled.") changed the default xmit checksum setting for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not set into external UDP header. This commit changes the rx checksum setting for both lwt vxlan/geneve

[PATCH net] bpf: fix branch offset adjustment on backjumps after patching ctx expansion

2016-02-10 Thread Daniel Borkmann
When ctx access is used, the kernel often needs to expand/rewrite instructions, so after that patching, branch offsets have to be adjusted for both forward and backward jumps in the new eBPF program, but for backward jumps it fails to account the delta. Meaning, for example, if the expansion happen

[PATCHv2 next 3/3] ipvlan: misc changes

2016-02-10 Thread Mahesh Bandewar
From: Mahesh Bandewar 1. scope correction for few functions that are used in single file. 2. Adjust variables that are used in fast-path to fit into single cacheline 3. Update rcv_frame() to skip shared check for frames coming over wire Signed-off-by: Mahesh Bandewar --- v1: initial patch v2: r

[PATCHv2 next 2/3] ipvlan: mode is u16

2016-02-10 Thread Mahesh Bandewar
From: Mahesh Bandewar The mode argument was erronusly defined as u32 but it has always been u16. Also use ipvlan_set_mode() helper to set the mode instead of assigning directly. This should avoid future erronus assignments / updates. Signed-off-by: Mahesh Bandewar --- v1: initial patch v2: comm

[PATCHv2 next 1/3] ipvlan: scrub skb before routing in L3 mode.

2016-02-10 Thread Mahesh Bandewar
From: Mahesh Bandewar Scrub skb before hitting the iptable hooks to ensure packets hit these hooks. Signed-off-by: Mahesh Bandewar --- v1: initial patch v2: resend drivers/net/ipvlan/ipvlan_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvla

Re: [PATCH 1/2] vhost: helpers to enable/disable vring endianness

2016-02-10 Thread Greg Kurz
On Wed, 10 Feb 2016 17:08:52 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 10, 2016 at 01:11:34PM +0100, Greg Kurz wrote: > > On Wed, 10 Feb 2016 13:21:22 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jan 13, 2016 at 06:09:41PM +0100, Greg Kurz wrote: > > > > The default use cas

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-10 Thread David Laight
From: George Spelvin > Sent: 10 February 2016 14:44 ... > > I think the fastest loop is: > > 10: adcq0(%rdi,%rcx,8),%rax > > inc %rcx > > jnz 10b > > That loop looks like it will have no overhead on recent cpu. > > Well, it should execute at 1 instruction/cycle. I presume you

Re: Scaling the Number of Network Interfaces on Linux

2016-02-10 Thread Nicolas Dichtel
Le 10/02/2016 12:59, David Ahern a écrit : On 2/10/16 12:15 PM, Nicolas Dichtel wrote: [snip] Instead of removing completly the sysctl entries, another idea could be to manage a group of interfaces which will share the same subtree. This come out from a side conversation as well -- for exampl

[PATCH] bridge: mdb: avoid uninitialized variable warning

2016-02-10 Thread Arnd Bergmann
A recent change to the mdb code confused the compiler to the point where it did not realize that the port-group returned from br_mdb_add_group() is always valid when the function returns a nonzero return value, so we get a spurious warning: net/bridge/br_mdb.c: In function 'br_mdb_add': net/bridge

Re: [PATCH 1/1] af_packet: Raw socket destruction warning fix

2016-02-10 Thread Eric Dumazet
On Wed, 2016-02-10 at 17:35 +0530, Maninder Singh wrote: > This Patch fixes below warning:- > WARNING: at net/packet/af_packet.c:xxx packet_sock_destruct > > There is following race between packet_rcv and packet_close > which keeps unfree packet in receive queue. > > CPU 1

Re: [PATCH 1/2] vhost: helpers to enable/disable vring endianness

2016-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2016 at 01:11:34PM +0100, Greg Kurz wrote: > On Wed, 10 Feb 2016 13:21:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 13, 2016 at 06:09:41PM +0100, Greg Kurz wrote: > > > The default use case for vhost is when the host and the vring have the > > > same endianness (defaul

Re: [PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-10 Thread Andy Gospodarek
On Wed, Feb 10, 2016 at 08:20:59AM -0500, Jarod Wilson wrote: > On Tue, Feb 09, 2016 at 08:52:38PM -0800, Eric Dumazet wrote: > > On Tue, 2016-02-09 at 17:41 -0800, Stephen Hemminger wrote: > > > On Tue, 9 Feb 2016 18:51:35 -0500 > > > Jarod Wilson wrote: > > > > > > > On Tue, Feb 09, 2016 at 11:

Re: [PATCH] af_packet: Raw socket destruction warning fix

2016-02-10 Thread Eric Dumazet
On Wed, 2016-02-10 at 12:43 +, Vaneet Narang wrote: > Hi, > > >What driver are you using (is that in-tree)? Can you reproduce the same issue > >with a latest -net kernel, for example (or, a 'reasonably' recent one like > >4.3 or > >4.4)? There has been quite a bit of changes in err queue hand

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-10 Thread Jesse Gross
On Wed, Feb 10, 2016 at 3:21 PM, Tom Herbert wrote: > On Wed, Feb 10, 2016 at 12:59 PM, Jesse Gross wrote: >> On Wed, Feb 10, 2016 at 12:41 PM, David Wragg wrote: >>> Tom Herbert writes: The correct thing to do is determine the maximum amount of encapsulation overhead that can ever be

BUSINESS INVESTMENT

2016-02-10 Thread Max Edward
Hello, I have interest of investing in your country as well as seek your services in a private and confidential issue. My name is Max Edward, an auditor with Scouts Bank London, On my routine inspection I discovered a dormant domiciliary account with the deposit of £4.6M (Four Million Six Hundred

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-10 Thread George Spelvin
David Laight wrote: > Separate renaming allows: > 1) The value to tested without waiting for pending updates to complete. >Useful for IE and DIR. I don't quite follow. It allows the value to be tested without waiting for pending updates *of other bits* to complete. Obviusly, the update of th

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-10 Thread Tom Herbert
On Wed, Feb 10, 2016 at 12:59 PM, Jesse Gross wrote: > On Wed, Feb 10, 2016 at 12:41 PM, David Wragg wrote: >> Tom Herbert writes: >>> The correct thing to do is determine the maximum amount of >>> encapsulation overhead that can ever be set in a packet and use for >>> setting the MTU. For insta

  1   2   >