Thanks David, I'll submit a revised patch soon.
-----Original Message----- From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, February 10, 2016 5:34 AM To: Bryan Whitehead - C21958 Cc: netdev@vger.kernel.org; cor...@lwn.net Subject: Re: [PATCH net-next] Add LAN9352 Ethernet Driver From: <bryan.whiteh...@microchip.com> Date: Tue, 9 Feb 2016 20:40:30 +0000 > +#ifdef USE_PHY_WORK_AROUND > +#define MIN_PACKET_SIZE (64) > + char loopback_tx_pkt[MIN_PACKET_SIZE]; > + char loopback_rx_pkt[MIN_PACKET_SIZE]; > + unsigned int resetcount; > +#endif ... > +#define USE_PHY_WORK_AROUND If you're going to unconditionally define this, and not provide a Kconfig mechanism to change it, just get rid of this and the CPP tests upon it. Thanks.