Re: [PATCH net v2] bonding: Fix ARP monitor validation

2016-02-07 Thread Jay Vosburgh
David Miller wrote: [...] >> This patch changes the logic in bond_arp_rcv to additionally >> accept an ARP reply for validation on any slave if there is a current ARP >> slave and it sent an ARP probe during the previous arp_interval. >> >> Fixes: aeea64ac717a ("bonding: don't trust arp req

Re: [PATCH 3/7] net: phy: spi_ks8995: add register initialization

2016-02-07 Thread Florian Fainelli
On 07/02/2016 14:39, Helmut Buchsbaum wrote: > Since several use cases need to setup at least some basic control > registers add the ability to configure an array containing such > register initialization values within the platform data of the switch. > Furthermore expose this capabilty to the devi

Re: [PATCH v2 2/4] staging: rtl8712: Rename local variable

2016-02-07 Thread Greg KH
On Wed, Nov 25, 2015 at 03:42:40PM -0200, Mauro Dreissig wrote: > Renames all instances of struct _adapter to adapter in rtl871x_ioctl_rtl.c, > avoiding camel case. > > Signed-off-by: Mauro Dreissig > --- > drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 > ++--- > 1 fi

Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

2016-02-07 Thread Greg KH
On Wed, Nov 25, 2015 at 01:04:14PM -0200, Mauro Dreissig wrote: > On 25-11-2015 12:56, Mauro Dreissig wrote: > > On 25-11-2015 09:44, Sudip Mukherjee wrote: > >> On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote: > >>> Some error handling paths are checking for success > >>> instead of

Re: [RFC PATCH net-next 2/3] macvlan: add queue selection functionality

2016-02-07 Thread Eric Dumazet
On Sun, 2016-02-07 at 22:14 -0500, Vladislav Yasevich wrote: > This patch adds a simple queue selection function to macvlan > layer. In most cases, this will just use the standard fallback > fuction, but when rx-queue has been recoreded we'll try to use > that value. > > Signed-off-by: Vladislav

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-07 Thread Eric Dumazet
On Sun, 2016-02-07 at 22:24 +, Rainer Weikusat wrote: > Rainer Weikusat writes: > > [...] > > > The start uses that to record an error which might need to be > > reported, the return statement uses it to indicate that an error has > > occurred. Hence, some kind of in-between translation must

[RFC PATCH net-next 3/3] macvtap: Record the rx queue based on the user tap queue

2016-02-07 Thread Vladislav Yasevich
Now that macvlan has a basic queue selection and macvtap has multiple qdiscs, we can record the the queue index into the skb based on the index of the macvtap user queue. This index will then be used to select the right qdisc. Signed-off-by: Vlad Yasevich --- drivers/net/macvtap.c | 1 + 1 file

[RFC PATCH net-next 1/3] macvtap: mutiple qdiscs support

2016-02-07 Thread Vladislav Yasevich
Since commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 macvtap: Add support of packet capture on macvtap device. macvtap has been using dev_queue_xmit() call. Since macvtap set the queue length, it ended up using a qdisc and that caused lock contention when multi-queue macvtap was used. This

[RFC PATCH net-next 2/3] macvlan: add queue selection functionality

2016-02-07 Thread Vladislav Yasevich
This patch adds a simple queue selection function to macvlan layer. In most cases, this will just use the standard fallback fuction, but when rx-queue has been recoreded we'll try to use that value. Signed-off-by: Vladislav Yasevich --- drivers/net/macvlan.c | 20 1 file ch

[RFC PATCH net-next 0/3] Extend macvtap with multiple qdiscs

2016-02-07 Thread Vladislav Yasevich
This is an RFC series to extend macvtap with multiple qdisc. Right now multiqueue macvtap setups suffer from lock contention. Macvtap sets the queue index and thus gets a default qdisc allocated to it. Since it later users dev_queue_xmit() call to the macvlan type device (so that we can packet c

Re: r8169 regression: UDP packets dropped intermittantly

2016-02-07 Thread Jonathan Woithe
Hi Francois On Wed, Dec 02, 2015 at 12:58:52AM +0100, Francois Romieu wrote: > Jonathan Woithe : > [...] > > Any thoughts or progress at this stage? Are there further tests you need me > > to do ? > > Yes but you should expect two more days without signal. FYI I am now back from annual leave a

[PATCH net-next v7 01/19] lib/bitmap.c: conversion routines to/from u32 array

2016-02-07 Thread David Decotigny
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- include/linux/bitmap.h | 6 lib/bitmap.c | 86 +++

[PATCH net-next v7 04/19] net: usnic: use __ethtool_get_settings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644 --

[PATCH net-next v7 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 6cdb4d2..ea003ec 100644 --- a/drivers/inf

[PATCH net-next v7 08/19] net: bonding: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 7c9eb67..c2baa86 100644 --- a/drivers/net/bonding/b

[PATCH net-next v7 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-07 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes ethtool_c

[PATCH net-next v7 06/19] tx4939: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips/

[PATCH net-next v7 07/19] net: usnic: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..e90dc64 1

[PATCH net-next v7 10/19] net: macvlan: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 94e6888..a54ad4c 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -940,

[PATCH net-next v7 09/19] net: ipvlan: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 7a3b414..9703610 100644 --- a/drivers/net/ipvlan/ipvlan

[PATCH net-next v7 11/19] net: team: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..7f96eca7 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team

[PATCH net-next v7 13/19] net: rdma: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..f669751 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_add

[PATCH net-next v7 12/19] net: fcoe: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..2d5909f

[PATCH net-next v7 15/19] net: bridge: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..cafe4e6 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10 @@ */

[PATCH net-next v7 14/19] net: 8021q: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index ad5e2fd..d4a6131 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -621,12 +6

[PATCH net-next v7 16/19] net: core: use __ethtool_get_ksettings

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index da7dbc2..b9c8b91 100644 --- a/net/cor

[PATCH net-next v7 18/19] net: mlx4: convenience predicate for debug messages

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d 100644

[PATCH net-next v7 17/19] net: ethtool: remove unused __ethtool_get_settings

2016-02-07 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux/ethtool.h

[PATCH net-next v7 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2016-02-07 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 177 insertions(+), 169 dele

[PATCH net-next v7 02/19] test_bitmap: unit tests for lib/bitmap.c

2016-02-07 Thread David Decotigny
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/t

[PATCH net-next v7 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-07 Thread David Decotigny
From: David Decotigny History: v7 - module_exit in test_bitmap v6 - fix copy_from_user in user/kernel handshake v5 note: please see v4 bullets for a question regarding bitmap.c - minor fix to make allyesconfig/allmodconfig v4 - removed typedef for link mode bitmaps - moved bitmap<->u32

[PATCH iproute2] ip route: add mpls multipath support

2016-02-07 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to add mpls multipath routes. example: ip -f mpls route add 100 \ nexthop as 200 via inet 10.1.1.2 dev swp1 \ nexthop as 700 via inet 10.1.1.6 dev swp2 Signed-off-by: Roopa Prabhu --- ip/iproute.c | 30 +-

Re: e1000e er32(TIMINCA) value returned 0 Virtual Machiens

2016-02-07 Thread Thomas Elliott
I don't know how TIMINCA is getting cleared to zero. All I know is this situation apparently occurs with VM's. And while I do agree a fix from the VM guys would be necessary, this simple one liner fixes it, because SOMETHING is causing it to get set to/as/reset to zero. If there's nothing to be

[PATCH 4/7] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-07 Thread Helmut Buchsbaum
When using device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allows to power down the switch when the it is not used any more. The patch introduces a new optional property "reset-gpios" denoting an appropriate GPIO handle, e.g.: reset-gpios = <&g

[PATCH 3/7] net: phy: spi_ks8995: add register initialization

2016-02-07 Thread Helmut Buchsbaum
Since several use cases need to setup at least some basic control registers add the ability to configure an array containing such register initialization values within the platform data of the switch. Furthermore expose this capabilty to the devicetree. Platform data now contains a pointer to an a

[PATCH 6/7] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-07 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/ph

[PATCH 5/7] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-07 Thread Helmut Buchsbaum
Prepare creating SPI reads and writes for other switch families. The KS8995 family uses the straight forward <8bit CMD><8bit ADDR> sequence. To be able to support KSZ8795 family, which uses <3bit CMD><12bit ADDR><1 bit TR> make the SPI command creation chip variant dependent. Signe

[PATCH 7/7] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-07 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt b

[PATCH 2/7] net: phy: spi_ks8995: verify chip and determine revision

2016-02-07 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Conflicts: drivers/net/phy/spi_ks8995.c Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed,

[PATCH 0/7] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-07 Thread Helmut Buchsbaum
This patch series refactors the spi-ks8995 driver to finally add support for the MICREL KSZ8795CLX. Additionally support for setting initial register values as well as controlling a GPIO line for resetting the switch is added. Helmut Buchsbaum (7): net: phy: spi_ks8995: introduce spi_device_id t

[PATCH 1/7] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-07 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/sp

Re: [PATCH v2 0/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Florian Fainelli
On 07/02/2016 09:47, Andrew F. Davis wrote: > Hello all, > > This series is [0] split into its logical components. > > Thanks, > Andrew > > [0] http://www.spinics.net/lists/netdev/msg363106.html Reviewed-by: Florian Fainelli Thanks for splitting things up! -- Florian

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-07 Thread Rainer Weikusat
Rainer Weikusat writes: [...] > The start uses that to record an error which might need to be > reported, the return statement uses it to indicate that an error has > occurred. Hence, some kind of in-between translation must occur. The > mutex_lock_interruptible happened to do that but that was

Re: e1000e er32(TIMINCA) value returned 0 Virtual Machiens

2016-02-07 Thread Richard Cochran
On Sun, Feb 07, 2016 at 10:28:48AM -0500, Thomas Elliott wrote: > task: 88003e4b8000 ti: 88003e4c task.ti: 88003e4c > RIP: 0010:[] [] 0x8172817a > RSP: :88003e4c3cf0 EFLAGS: 00010246 > RAX: RBX: 880038cdf640 RCX: > RDX: 000

[PATCH repost net-next] ethtool: future-proof interface for speed extensions

2016-02-07 Thread Michael S. Tsirkin
Many virtual and not quite virtual devices allow any speed to be set through ethtool. In particular, this applies to the virtio-net devices. Document this fact to make sure people don't assume the enum lists all possible values. Reserve values greater than INT_MAX for future extension and to avoid

Re: [PATCH net-next 1/2] ethtool: make validate_speed accept all speeds between 0 and INT_MAX

2016-02-07 Thread Michael S. Tsirkin
On Sun, Feb 07, 2016 at 09:52:23PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Devices these days can have any speed and as was recently pointed out > any speed from 0 to INT_MAX is valid so adjust speed validation to > accept such values. > > Signed-off-by: Nikolay Aleksan

Re: [PATCH net-next 2/2] virtio_net: validate ethtool port setting and explain the user validation

2016-02-07 Thread Michael S. Tsirkin
On Sun, Feb 07, 2016 at 09:52:24PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > We should validate the port setting that we got from the user and check > if it's what we've set it to (PORT_OTHER), also add explanation that > ignoring advertising is good as long as we don't ha

Re: [PATCH 1/2] ravb: factor out register bit twiddling code

2016-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2016 11:48 PM, Geert Uytterhoeven wrote: --- net-next.orig/drivers/net/ethernet/renesas/ravb_main.c +++ net-next/drivers/net/ethernet/renesas/ravb_main.c @@ -2,7 +2,7 @@ * * Copyright (C) 2014-2015 Renesas Electronics Corporation * Copyright (C) 2015 Renesas Solutions C

[PATCH net-next 2/2] virtio_net: validate ethtool port setting and explain the user validation

2016-02-07 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We should validate the port setting that we got from the user and check if it's what we've set it to (PORT_OTHER), also add explanation that ignoring advertising is good as long as we don't have autonegotiation. Signed-off-by: Nikolay Aleksandrov --- drivers/net/virti

[PATCH net-next 0/2] virtio_net: better ethtool setting validation

2016-02-07 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This small set is a follow-up for the recent patches that added ethtool get/set settings. Patch 1 changes the speed validation routine to check if the speed is between 0 and INT_MAX (or SPEED_UNKNOWN) and patch 2 adds port validation to virtio_net and better validati

[PATCH net-next 1/2] ethtool: make validate_speed accept all speeds between 0 and INT_MAX

2016-02-07 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Devices these days can have any speed and as was recently pointed out any speed from 0 to INT_MAX is valid so adjust speed validation to accept such values. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/ethtool.h | 19 +-- 1 file changed, 1

Re: [PATCH 2/2] sh_eth: factor out register bit twiddling code

2016-02-07 Thread Geert Uytterhoeven
Hi Sergei, On Sun, Feb 7, 2016 at 8:30 PM, Sergei Shtylyov wrote: > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c > +++ net-next/drivers/net/ethernet/renesas/sh_eth.c > @@ -428,6 +428,13 @@ static u32 sh_eth_read(struct net_device > return ioread32(mdp->addr + offset); > } > >

Re: [PATCH 1/2] ravb: factor out register bit twiddling code

2016-02-07 Thread Geert Uytterhoeven
Hi Sergei, On Sun, Feb 7, 2016 at 8:30 PM, Sergei Shtylyov wrote: > --- net-next.orig/drivers/net/ethernet/renesas/ravb_main.c > +++ net-next/drivers/net/ethernet/renesas/ravb_main.c > @@ -2,7 +2,7 @@ > * > * Copyright (C) 2014-2015 Renesas Electronics Corporation > * Copyright (C) 2015 Ren

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-07 Thread Rainer Weikusat
Rainer Weikusat writes: [...] > the real problem is that the function disagrees with itself on how to > use the err variable: The start uses that to record an error which > might need to be reported, the return statement uses it to indicate > that an error has occurred. This should have been "a

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-07 Thread Eric Dumazet
On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote: > > Why was this userspace ABI change allowed? > > The stats structure is exposed to user space via netlink > > and changing the size of responses will break iproute2 commands. I do not think it breaks anything. iproute2 always assumed kerne

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-07 Thread roopa
On 2/3/16, 2:47 AM, Jiri Pirko wrote: > From: Jiri Pirko > > There a is need for some userspace API that would allow to expose things > that are not directly related to any device class like net_device of > ib_device, but rather chip-wide/switch-ASIC-wide stuff. > > Use cases: > 1) get/set of port

Re: [RFC PATCH v2 08/18] ipv6: Add ipv6_renew_options_kern() that accepts a kernel mem pointer.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:44 AM Huw Davies wrote: > The functionality is equivalent to ipv6_renew_options() except > that the newopt pointer is in kernel, not user, memory > > The kernel memory implementation will be used by the CALIPSO network > labelling engine, which needs to be able to

Re: [RFC PATCH v2 14/18] calipso: Allow the lsm to label the skbuff directly.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:50 AM Huw Davies wrote: > In some cases, the lsm needs to add the label to the skbuff directly. > A NF_INET_LOCAL_OUT IPv6 hook is added to selinux to match the IPv4 > behaviour. This allows selinux to label the skbuffs that it requires. > > Signed-off-by: Huw Da

Re: [RFC PATCH v2 00/18] CALIPSO Implementation

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:36 AM Huw Davies wrote: > This patch series implements RFC 5570 - Common Architecture Label IPv6 > Security Option (CALIPSO). Its goal is to set MLS sensitivity labels > on IPv6 packets using a hop-by-hop option. CALIPSO is very similar to > its IPv4 cousin CIPSO

Re: [RFC PATCH v2 10/18] calipso: Set the calipso socket label to match the secattr.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:46 AM Huw Davies wrote: > CALIPSO is a hop-by-hop IPv6 option. A lot of this patch is based on > the equivalent CISPO code. The main difference is due to manipulating > the options in the hop-by-hop header. > > Signed-off-by: Huw Davies ... > diff --git a/net

Re: [RFC PATCH v2 12/18] ipv6: Allow request socks to contain IPv6 options.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:48 AM Huw Davies wrote: > If set, these will that precedence over the parent's options during take > both sending and child creation. If they're not set, the parent's > options (if any) will be used. > > This is to

Re: [RFC PATCH v2 06/18] netlabel: Add support for creating a CALIPSO protocol domain mapping.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:42 AM Huw Davies wrote: > This extends the NLBL_MGMT_C_ADD and NLBL_MGMT_C_ADDDEF commands > to accept CALIPSO protocol DOIs. > > Signed-off-by: Huw Davies ... > @@ -300,6 +311,11 @@ static int netlbl_domhsh_validate(const struct > netlbl_dom_map *entry) entry-

Re: [RFC PATCH v2 02/18] netlabel: Add an address family to domain hash entries.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:38 AM Huw Davies wrote: > The reason is to allow different labelling protocols for > different address families with the same domain. > > This requires the addition of an address family attribute > in the netlink communication protocol. It is used in several > me

Re: [RFC PATCH v2 03/18] netlabel: Initial support for the CALIPSO netlink protocol.

2016-02-07 Thread Paul Moore
On Friday, January 08, 2016 09:52:39 AM Huw Davies wrote: > CALIPSO is a packet labelling protocol for IPv6 which is very similar > to CIPSO. It is specified in RFC 5570. Much of the code is based on > the current CIPSO code. > > This adds support for adding passthrough-type CALIPSO DOIs through

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-07 Thread David Miller
From: Stephen Hemminger Date: Sun, 7 Feb 2016 11:37:32 -0800 > On Mon, 1 Feb 2016 18:51:05 -0500 > Jarod Wilson wrote: > >> --- a/include/uapi/linux/if_link.h >> +++ b/include/uapi/linux/if_link.h >> @@ -35,6 +35,8 @@ struct rtnl_link_stats { >> /* for cslip etc */ >> __u32 rx_comp

Re: [PATCH iproute2] bridge: support for static fdb entries

2016-02-07 Thread Stephen Hemminger
On Wed, 27 Jan 2016 09:09:37 -0800 Roopa Prabhu wrote: > From: Roopa Prabhu > > There is no intuitive option to add static fdb entries today. > 'temp' seems to have a side effect of adding > 'static' fdb entries. But the name and intent > of 'temp' does not say anything about it being static. >

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-07 Thread Stephen Hemminger
On Mon, 1 Feb 2016 18:51:05 -0500 Jarod Wilson wrote: > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -35,6 +35,8 @@ struct rtnl_link_stats { > /* for cslip etc */ > __u32 rx_compressed; > __u32 tx_compressed; > + > + __u32 rx_nohandler;

Re: [RESEND PATCH 0/9] Namespaceify more of the tcp sysctl knobs

2016-02-07 Thread David Miller
From: Nikolay Borisov Date: Wed, 3 Feb 2016 09:46:48 +0200 > This patch series continues making more of the tcp-related > sysctl knobs be per net-namespace. Most of these apply per > socket and have global defaults so should be safe and I > don't expect any breakages. > > Having those per net-

Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support

2016-02-07 Thread Nikolay Aleksandrov
On 02/07/2016 08:31 PM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Wed, 3 Feb 2016 04:04:35 +0100 > >> Patch 1 adds ethtool speed/duplex validation functions which check if the >> value is defined. Patch 2 adds support for ethtool (get|set)_settings and >> uses the validation functi

Re: pull request: batman-adv 20160203

2016-02-07 Thread David Miller
From: Antonio Quartulli Date: Wed, 3 Feb 2016 10:18:21 +0800 > Here you have our first pull request intended for net-next. > > This batch of patches includes a number of corrections and > improvements for our kernel-doc. These changes also make sure > that our doc is now properly processed by t

Re: [PATCH iproute2 master resend 0/4] Minor BPF updates on frontend

2016-02-07 Thread Stephen Hemminger
On Sun, 7 Feb 2016 02:11:49 +0100 Daniel Borkmann wrote: > Couple of minor updates on tc frontend. > > Resending with no changes and with John's Acked-by kept, orignal > version got set to 'Changes requested' by mistake. > > Thanks! > > Daniel Borkmann (4): > tc, bpf, examples: further bpf_

Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support

2016-02-07 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 3 Feb 2016 04:04:35 +0100 > Patch 1 adds ethtool speed/duplex validation functions which check if the > value is defined. Patch 2 adds support for ethtool (get|set)_settings and > uses the validation functions to check the user-supplied values. > > v2: split

[PATCH 1/2] ravb: factor out register bit twiddling code

2016-02-07 Thread Sergei Shtylyov
The driver has often repeated pattern of reading a register, AND'ing and/or OR'ing some bits and writing the value back. Factor the pattern out into ravb_modify() -- this saves 260 bytes of code with ARM gcc 4.7.3. While at it, update Cogent Embedded's copyrights. Signed-off-by: Sergei Shtyl

[PATCH 2/2] sh_eth: factor out register bit twiddling code

2016-02-07 Thread Sergei Shtylyov
The driver has often repeated pattern of reading a register, AND'ing and/or OR'ing some bits and writing the value back. Factor the pattern out into sh_eth_modify() -- this saves 84 bytes of code with ARM gcc 4.7.3. While at it, update Cogent Embedded's copyright. Signed-off-by: Sergei Shty

[PATCH 0/2] Factor out register bit twiddling in the Renesas Ethernet drivers

2016-02-07 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net-next.git' repo. We factor out the often repeated pattern of reading a register, AND'ing and/or OR'ing some bits, and then writing the value back. [1/2] ravb: factor out register bit twiddling code [2/2] sh_eth: factor out register bit twidd

Re: [PATCH net v2] bonding: Fix ARP monitor validation

2016-02-07 Thread David Miller
From: Jay Vosburgh Date: Tue, 02 Feb 2016 13:35:56 -0800 > > The current logic in bond_arp_rcv will accept an incoming ARP for > validation if (a) the receiving slave is either "active" (which includes > the currently active slave, or the current ARP slave) or, (b) there is a > currently a

Re: [net-next PATCH 00/11] net: mitigating kmem_cache slowpath and BoF discussion patches

2016-02-07 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 02 Feb 2016 22:11:28 +0100 > This patchset is relevant for my NetDev 1.1 "Network Performance BoF" [1]. > > The first 4 patches, is a repost[2], for the first real use-case of > kmem_cache bulk alloc and free API. They were adjusted slightly to > accomoda

Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-07 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned if

Re: [PATCH next 2/3] ipvlan: mode is u16

2016-02-07 Thread David Miller
From: Mahesh Bandewar Date: Tue, 2 Feb 2016 11:20:30 -0800 > From: Mahesh Bandewar > > The mode argument was erronusly defined as u32 but it has always > been u16. > > Signed-off-by: Mahesh Bandewar This patch is changing more than this. Specifically it is invoking ipvlan_set_port_mode() i

Re: [PATCH net-next 0/2] sunvnet: perf tracepoint hooks

2016-02-07 Thread David Miller
From: Sowmini Varadhan Date: Tue, 2 Feb 2016 10:41:54 -0800 > Added some perf tracepoints to help track and debug sunvnet > descriptor state at run-time. I'm not the biggest fan of putting tracepoints like this in the fast paths of a networking driver, but what can I say... if they are useful

Re: [PATCH net-next 0/6] tcp: congestion control refactoring

2016-02-07 Thread David Miller
From: Yuchung Cheng Date: Tue, 2 Feb 2016 10:33:03 -0800 > This patch set refactors the sequence of congestion control, > loss recovery, and transmission logic in TCP ack processing. > > The design goal is to decouple and sequence them in the following order: > > 0. ACK accounting: free or t

Re: [PATCH] net: drop write-only stack variable

2016-02-07 Thread David Miller
From: David Herrmann Date: Tue, 2 Feb 2016 18:17:54 +0100 > Remove a write-only stack variable from unix_attach_fds(). This is a > left-over from the security fix in: > > commit 712f4aad406bb1ed67f3f98d04c044191f0ff593 > Author: willy tarreau > Date: Sun Jan 10 07:54:56 2016 +010

Re: [PATCH net-next] net: Add support for fill_slave_info to VRF device

2016-02-07 Thread David Miller
From: David Ahern Date: Tue, 2 Feb 2016 07:43:45 -0800 > Allows userspace to have direct access to VRF table association > versus looking up master device and its table. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [PATCH] update be2net maintainers' email addresses

2016-02-07 Thread David Miller
From: Sathya Perla Date: Tue, 2 Feb 2016 08:10:10 -0500 > be2net maintainers' email addresses changed from avagotech.com to > broadcom.com starting today. While updating the list, I'm also adding > Somnath's name to the list. > > Signed-off-by: Sathya Perla Applied.

Re: [PATCH net-next v3] xen-netback: implement dynamic multicast control

2016-02-07 Thread David Miller
From: Paul Durrant Date: Tue, 2 Feb 2016 11:55:05 + > My recent patch to the Xen Project documents a protocol for 'dynamic > multicast control' in netif.h. This extends the previous multicast control > protocol to not require a shared ring reconnection to turn the feature off. > Instead the b

Re: [PATCH v2 net-next 0/8] be2net patch-set

2016-02-07 Thread David Miller
From: Sriharsha Basavapatna Date: Wed, 3 Feb 2016 09:49:15 +0530 > v2 changes: > Patch-4:Changed a tab to space in be.h > Patches-6,7,8: Updated commit log summary line: benet --> be2net > > Hi David, > > The following patch set contains a few non-critical bug fixes. Pleas

Re: [PATCH net-next v2 0/6] vxlan: cleanup headers and tx path

2016-02-07 Thread David Miller
From: Jiri Benc Date: Tue, 2 Feb 2016 18:09:10 +0100 > This is first part of vxlan cleanup. It makes vxlan.h better organized and > removes code duplication in the tx path. There's no change in functionality. > > This is in preparation for VXLAN-GPE support. Other sets will follow with > cleanu

Re: [PATCH net v4] r8169: Add EEPROM support and disable MWI on pci express.

2016-02-07 Thread Sergei Shtylyov
On 02/07/2016 09:40 PM, Corcodel Marian wrote: [No need to qulate the full patch if you ask a question unrelated to the comments.] Hi i have one question, this patch can be reused or need to create new one. In case you were asking whether you should repost the updated patch in the sa

Re: [PATCH net V1 0/3] mlx5 driver fixes for 4.5-rc2

2016-02-07 Thread David Miller
From: Or Gerlitz Date: Sun, 7 Feb 2016 17:44:32 +0200 > On 2/2/2016 5:26 PM, Or Gerlitz wrote: >> We added here a patch from Matan and Alaa for addressing Linus >> comments on >> the mess w.r.t reserved field names in the driver/firmware >> auto-generated file. >> >> Once the patch hits linus tre

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-07 Thread Rainer Weikusat
Eric Dumazet writes: > On Fri, 2016-02-05 at 21:44 +, Rainer Weikusat wrote: >> The present unix_stream_read_generic contains various code sequences of >> the form >> >> err = -EDISASTER; >> if () >> goto out; >> >> This has the unfortunate side effect of possibly causing the error code

Re: [PATCH net v4] r8169: Add EEPROM support and disable MWI on pci express.

2016-02-07 Thread Corcodel Marian
On Sun, 2016-02-07 at 21:10 +0300, Sergei Shtylyov wrote: > Hello. > > On 02/07/2016 08:38 PM, Corcodel Marian wrote: > > >On chip with external eeprom ASPM settings is loaded from eeprom > > and > > on pci express interface not support MWI. > > Does not support. > > > > > Signed-o

Re: [PATCH v2 3/5] net: phy: dp83848: Reorganize code for readability and safety

2016-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2016 08:47 PM, Andrew F. Davis wrote: Reorganize code by moving the desired interrupt mask definition out of function. Also rearrange the enable/disable interrupt function to prevent accidental over-writing of values in registers. Signed-off-by: Andrew F. Davis --- drivers/n

Re: [PATCH net v4] r8169: Add EEPROM support and disable MWI on pci express.

2016-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2016 08:38 PM, Corcodel Marian wrote: On chip with external eeprom ASPM settings is loaded from eeprom and on pci express interface not support MWI. Does not support. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 22 ++---

[PATCH v2 2/5] net: phy: dp83848: Add PHY ID for TI version of DP83848C

2016-02-07 Thread Andrew F. Davis
After acquiring National Semiconductor, TI appears to have changed the Vendor Model Number for the DP83848C PHYs, add this new ID to supported IDs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH v2 0/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Andrew F. Davis
Hello all, This series is [0] split into its logical components. Thanks, Andrew [0] http://www.spinics.net/lists/netdev/msg363106.html Andrew F. Davis (5): net: phy: dp83848: Add macro for dp83848 compatible devices net: phy: dp83848: Add PHY ID for TI version of DP83848C net: phy: dp8384

[PATCH v2 5/5] net: phy: dp83848: Add comments for register definitions

2016-02-07 Thread Andrew F. Davis
Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c index f897989..556904f 100644 --- a/drivers/net/phy/dp83848.c +++ b/drivers/net/phy/dp83848.c @@ -21,8 +21,8 @

[PATCH v2 4/5] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-07 Thread Andrew F. Davis
The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83848.c b/drivers/n

[PATCH v2 3/5] net: phy: dp83848: Reorganize code for readability and safety

2016-02-07 Thread Andrew F. Davis
Reorganize code by moving the desired interrupt mask definition out of function. Also rearrange the enable/disable interrupt function to prevent accidental over-writing of values in registers. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 33 - 1

[PATCH v2 1/5] net: phy: dp83848: Add macro for dp83848 compatible devices

2016-02-07 Thread Andrew F. Davis
Add a helper macro for defining dp83848 compatible phy devices. Update copyright info. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/net/phy/dp83848.c b/drivers/

[PATCH net v4] r8169: Add EEPROM support and disable MWI on pci express.

2016-02-07 Thread Corcodel Marian
On chip with external eeprom ASPM settings is loaded from eeprom and on pci express interface not support MWI. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethe

  1   2   >