Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-03 Thread Michael S. Tsirkin
On Wed, Dec 02, 2015 at 02:43:58PM +0800, Stefan Hajnoczi wrote: > v2: > * Rebased onto Linux v4.4-rc2 > * vhost: Refuse to assign reserved CIDs > * vhost: Refuse guest CID if already in use > * vhost: Only accept correctly addressed packets (no spoofing!) > * vhost: Support flexible rx/tx des

[PATCH v4 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-03 Thread LABBE Corentin
Hello Change since v3 - rework the test logic with ver/err Change since v2 - Invert a test logic Change since v1 - Always return error code from kstrtox. LABBE Corentin (1): atm: solos-pci: Replace simple_strtol by kstrtoint drivers/atm/solos-pci.c | 28 +--- 1 file

[PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-03 Thread LABBE Corentin
The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin --- drivers/atm/solos-pci.c | 28 +--- 1 file changed, 17 insert

[PATCH v2] Revert "i40e: remove CONFIG_I40E_VXLAN"

2015-12-03 Thread Anjali Singhai Jain
This reverts commit 8fe269991aece394a7ed274f525d96c73f94109a. The case where VXLAN is a module and i40e driver is inbuilt will not be handled properly with this change since i40e will have an undefined symbol vxlan_get_rx_port in it. v2: Add a signed-off-by. Signed-off-by: Anjali Singhai Jain --

Re: [PATCH (net.git)] stmmac: fix resource management when resume

2015-12-03 Thread Giuseppe CAVALLARO
Hi David This is the v2, sorry I missed it in the subject. Re-based on top of net.git. peppe On 12/4/2015 7:21 AM, Giuseppe Cavallaro wrote: There is a memleak when suspend/resume this driver version. Currently the stmmac, during resume step, reallocates all the resources but they are not rel

[PATCH (net.git)] stmmac: fix resource management when resume

2015-12-03 Thread Giuseppe Cavallaro
There is a memleak when suspend/resume this driver version. Currently the stmmac, during resume step, reallocates all the resources but they are not released when suspend. The patch is not to release these resources but the logic has been changed. In fact, it is not necessary to free and reallocate

Re: ipsec impact on performance

2015-12-03 Thread Sandy Harris
This article is old (turn of the century) but it may have numbers worth comparing to http://www.freeswan.org/freeswan_trees/CURRENT-TREE/doc/performance.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo inf

MERGE net --> net-next

2015-12-03 Thread David Miller
I've merged net into net-next. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] VSOCK: mark virtio_transport.ko experimental

2015-12-03 Thread Stefan Hajnoczi
Be explicit that the virtio_transport.ko code implements a draft virtio specification that is still subject to change. Signed-off-by: Stefan Hajnoczi --- If you'd rather wait until the device specification has been finalized, feel free to revert the virtio-vsock code for now. Apologies for not m

Re: Regression in 3.9 caused by "bridge: respect RFC2863 operational state"

2015-12-03 Thread YanBo
Sorry to pick up this thread again, it looks this issue still existed in the newer 4.3 kernel. (The EAP frames can not be received by wireless interface due to the bridge interface, http://marc.info/?l=linux-wireless&m=136743495526905&w=2) Wonder is anyone know some update for this issue? Cur

Re: [PATCH net-next 3/3] vhost_net: basic polling support

2015-12-03 Thread Jason Wang
On 12/02/2015 08:36 PM, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 01:04:03PM +0800, Jason Wang wrote: >> >> On 12/01/2015 10:43 PM, Michael S. Tsirkin wrote: >>> On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: > On W

Re: SoCFPGA ethernet broken

2015-12-03 Thread Andrew Lunn
On Fri, Dec 04, 2015 at 02:10:50AM +0100, Andrew Lunn wrote: > > > FWIW: My initial patch to address the failure worked with the original > > > DTB. > > > > Can I ask what patch are you referring to? I was sidetracked for a while > > on this issue, but I still see it failing as of v4.4-rc3. I'll

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-03 Thread David Miller
From: Sergei Shtylyov Date: Fri, 4 Dec 2015 02:38:30 +0300 > On 12/04/2015 02:08 AM, David Miller wrote: > >>> Perhaps worth adding me to MAINTAINERS as (a new role of) a >>> reviewer... >> >> I'll happily apply such a patch. > >OK, net.git would be OK as a base? Absolutely. -- To

Re: [PATCH] Revert "i40e: remove CONFIG_I40E_VXLAN"

2015-12-03 Thread David Miller
From: Anjali Singhai Jain Date: Thu, 3 Dec 2015 15:46:39 -0800 > This reverts commit 8fe269991aece394a7ed274f525d96c73f94109a. > The case where VXLAN is a module and i40e driver is in built > will not be handled properly with this change since i40e > will have an undefined symbol vxlan_get_rx_po

Re: SoCFPGA ethernet broken

2015-12-03 Thread Andrew Lunn
> > FWIW: My initial patch to address the failure worked with the original DTB. > > Can I ask what patch are you referring to? I was sidetracked for a while > on this issue, but I still see it failing as of v4.4-rc3. I'll try to > get back to debugging this. Hi Dinh There are two different patch

Re: SoCFPGA ethernet broken

2015-12-03 Thread Dinh Nguyen
On 12/03/2015 03:23 PM, David Daney wrote: > On 12/03/2015 12:48 PM, Pavel Machek wrote: >> On Thu 2015-10-15 13:25:59, Florian Fainelli wrote: >>> On 15/10/15 12:59, Dinh Nguyen wrote: On 10/15/2015 03:03 PM, Florian Fainelli wrote: > On 15/10/15 12:09, Dinh Nguyen wrote: >> Hi, >

Re: [net-next 10/17] fm10k: add TEB check to fm10k_gre_is_nvgre

2015-12-03 Thread Tom Herbert
On Thu, Dec 3, 2015 at 4:29 PM, Jeff Kirsher wrote: > From: Jacob Keller > > The NVGRE protocol should be run over transparent ethernet bridge > protocol, so we should verify this in our check whether the GRE tunnel > is NVGRE. While we're touching fm10k_main.c, update the copyright year. > > Sig

Re: [net-next 01/17] fm10k: Fix error handling in the function fm10k_setup_tc for certain function calls

2015-12-03 Thread Joe Perches
On Thu, 2015-12-03 at 16:29 -0800, Jeff Kirsher wrote: > From: Nick I guess this is an OK patch, but the From line isn't correct (missing full name) and the changelog is nigh on unreadable. > This fixes the function fm10k_setup_tc to properly check if the > calls to either the function fm10k_ini

[net-next 02/17] fm10k: set netdev features in one location

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Don't change netdev hw_features later in fm10k_probe, instead set all values inside fm10k_alloc_netdev. To do so, we need to know the MAC type (whether it is PF or VF) in order to determine what to do. This helps ensure that all logic regarding features is co-located. Signed-o

[net-next 09/17] fm10k: rename mbx_tx_oversized statistic to mbx_tx_dropped

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Originally this statistic was renamed because the method of dropping was called "drop_oversized_messages", but this logic has changed much, and this counter does actually represent messages which we failed to transmit for a number of reasons. Rename the counter back to tx_dropp

[net-next 13/17] fm10k: Update adaptive ITR algorithm

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller The existing adaptive ITR algorithm is overly restrictive. It throttles incorrectly for various traffic rates, and does not produce good performance. The algorithm now allows for more interrupts per second, and does some calculation to help improve for smaller packet loads. In

[net-next 08/17] fm10k: add statistics for actual DWORD count of mbmem mailbox

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller A previous bug was uncovered by addition of a debug stat to indicate the actual number of DWORDS we pulled from the mbmem. It turned out this was not the same as the tx_dwords counter. While the previous bug fix should have corrected this in all cases, add some debug stats that

[net-next 01/17] fm10k: Fix error handling in the function fm10k_setup_tc for certain function calls

2015-12-03 Thread Jeff Kirsher
From: Nick This fixes the function fm10k_setup_tc to properly check if the calls to either the function fm10k_init_queueing_scheme or the function fm10k_mbx_request_irq fail by returning a error code to signal that the call to either function has failed. Furthermore if this arises exit immediatel

[net-next 14/17] fm10k: use macro for default Tx and Rx ITR values

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Reviewed-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k.h | 2 ++ drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 4 ++-- drivers/net/ethernet/intel/fm10k/fm10k_pci.c

[net-next 04/17] fm10k: always check init_hw for errors

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller A recent change modified init_hw in some flows the function may fail on VF devices. For example, if a VF doesn't yet own its own queues. However, many callers of init_hw didn't bother to check the error code. Other callers checked but only displayed diagnostic messages without

[net-next 15/17] fm10k: change default Tx ITR to 25usec

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller The current default ITR for Tx is overly restrictive. Using a simple netperf TCP_STREAM test, we top out at about 10Gb/s for a single thread when running using 1500 byte frames. By reducing the ITR value to 25usec (up to 40K interrupts a second from 10K), we are able to achieve

[net-next 12/17] fm10k: introduce ITR_IS_ADAPTIVE macro

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Define a macro for identifying when the itr value is dynamic or adaptive. The concept was taken from i40e. This helps make clear what the check is, and reduces the line length to something more reasonable in a few places. Signed-off-by: Jacob Keller Reviewed-by: Bruce Allan

[net-next 05/17] fm10k: reinitialize queuing scheme after calling init_hw

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller The init_hw function may fail, and in the case of VFs, it might change the number of maximum queues available. Thus, for every flow which checks init_hw, we need to ensure that we clear the queue scheme before, and initialize it after. The fm10k_io_slot_reset path will end up t

[net-next 00/17][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-03

2015-12-03 Thread Jeff Kirsher
This series contains updates to fm10k only. I know I am going to regret this, but Nick Krause actually submitted a good patch for fm10k to fix error handling of fm10k_setup_tc(). There were two calls in the function which returned an integer which was being ignored and not handled properly. Jaco

[net-next 11/17] fm10k: Add support for ITR scaling based on PCIe link speed

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller The Intel Ethernet Switch FM1 Host Interface interrupt throttle timers are based on the PCIe link speed. Because of this, the value being programmed into the ITR registers must be scaled accordingly. For the PF, this is as simple as reading the PCIe link speed and storing

[net-next 17/17] fm10k: TRIVIAL cleanup order at top of fm10k_xmit_frame

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethern

[net-next 07/17] fm10k: explicitly typecast vlan values to u16

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/i

[net-next 06/17] fm10k: Correct typecast in fm10k_update_xc_addr_pf

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Since the resultant data type of the mac_update.mac_upper field is u16, it does not make sense to typecast u8 variables to u32 first. Since we're modifying fm10k_pf.c, also update the copyright year. Reported-by: Matthew Vick Signed-off-by: Jacob Keller Reviewed-by: Bruce Al

[net-next 03/17] fm10k: reset max_queues on init_hw_vf failure

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller VF drivers must detect how many queues are available. Previously, the driver assumed that each VF has at minimum 1 queue. This assumption is incorrect, since it is possible that the PF has not yet assigned the queues to the VF by the time the VF checks. To resolve this, we adde

[net-next 10/17] fm10k: add TEB check to fm10k_gre_is_nvgre

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller The NVGRE protocol should be run over transparent ethernet bridge protocol, so we should verify this in our check whether the GRE tunnel is NVGRE. While we're touching fm10k_main.c, update the copyright year. Signed-off-by: Jacob Keller Reviewed-by: Bruce Allan Tested-by: Kr

[net-next 16/17] fm10k: TRIVIAL fix typo of hardware

2015-12-03 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/i

Re: rhashtable: ENOMEM errors when hit with a flood of insertions

2015-12-03 Thread Herbert Xu
On Thu, Dec 03, 2015 at 08:08:39AM -0800, Eric Dumazet wrote: > > Well, it will fail before this point if memory is fragmented. Indeed, I was surprised that it even worked up to that point, possibly because the previous resizes might have actually been done in process context. > Anyway, __vmalloc

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-03 Thread Sergei Shtylyov
On 12/04/2015 02:08 AM, David Miller wrote: Perhaps worth adding me to MAINTAINERS as (a new role of) a reviewer... I'll happily apply such a patch. OK, net.git would be OK as a base? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH] Revert "i40e: remove CONFIG_I40E_VXLAN"

2015-12-03 Thread Anjali Singhai Jain
This reverts commit 8fe269991aece394a7ed274f525d96c73f94109a. The case where VXLAN is a module and i40e driver is in built will not be handled properly with this change since i40e will have an undefined symbol vxlan_get_rx_port in it. --- drivers/net/ethernet/intel/Kconfig | 11 ++

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-03 Thread David Miller
From: Sergei Shtylyov Date: Fri, 4 Dec 2015 00:10:56 +0300 >Perhaps worth adding me to MAINTAINERS as (a new role of) a >reviewer... I'll happily apply such a patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [RFC PATCH] af_unix: fix entry locking in unix_dgram_recvmsg

2015-12-03 Thread David Miller
From: Rainer Weikusat Date: Thu, 03 Dec 2015 21:24:17 + > David Miller writes: >> So with your patch, the "N * timeout" behavior, where N is the number >> of queues reading threads, no longer occurs? Do they all now properly >> get released at the appropriate timeout? > > As far as I can t

Re: SoCFPGA ethernet broken

2015-12-03 Thread David Daney
On 12/03/2015 12:48 PM, Pavel Machek wrote: On Thu 2015-10-15 13:25:59, Florian Fainelli wrote: On 15/10/15 12:59, Dinh Nguyen wrote: On 10/15/2015 03:03 PM, Florian Fainelli wrote: On 15/10/15 12:09, Dinh Nguyen wrote: Hi, commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, n

[PATCH] ravb: fix RX queue #1 frame error counter name

2015-12-03 Thread Sergei Shtylyov
The Rx queue #1 frame error counter name contains trailing underscore, probably due to a typo... Signed-off-by: Sergei Shtylyov --- The patch is against Dave Miller's 'net.git' repo but I won't mind if it gets merged to 'net-next.git' instead... drivers/net/ethernet/renesas/ravb_main.c |2

[PATCH v3] sh_eth: fix kernel oops in skb_put()

2015-12-03 Thread Sergei Shtylyov
In a low memory situation the following kernel oops occurs: Unable to handle kernel NULL pointer dereference at virtual address 0050 pgd = 8490c000 [0050] *pgd=4651e831, *pte=, *ppte= Internal error: Oops: 17 [#1] PREEMPT ARM Modules linked in: CPU: 0Not tainted (3.4-a

Re: [v9, 3/6] fsl/fman: Add FMan MAC support

2015-12-03 Thread Kenneth Klette Jonassen
> +/* PHY Control Register */ > +#define PHY_CR_PHY_RESET 0x8000 > +#define PHY_CR_SPEED0 0x2000 > +#define PHY_CR_ANE 0x1000 > +#define PHY_CR_RESET_AN0x0200 > +#define PHY_CR_FULLDUPLEX 0x0100 > +#define PHY_CR_SPEED1 0x0040 Reuse defines

Re: 4.4-rc2 xfrm_lookup kasan trace

2015-12-03 Thread Eric Dumazet
On Thu, 2015-12-03 at 09:09 -0800, Eric Dumazet wrote: > On Thu, 2015-12-03 at 11:59 -0500, David Miller wrote: > > From: Eric Dumazet > > Date: Mon, 30 Nov 2015 17:22:11 -0800 > > > > > @@ -2198,6 +2198,7 @@ struct dst_entry *xfrm_lookup(struct net *net, > > > struct dst_entry *dst_orig, > > >

[net 0/4][pull request] Intel Wired LAN Driver Updates 2015-12-03

2015-12-03 Thread Jeff Kirsher
This series contains updates to ixgbe, i40e/i40evf, MAINTAINERS and e100.txt Alex provides a fix for ixgbe where enabling SR-IOV and then bringing the interface up was resulting in the PF MAC addresses getting into a bad state. The workaround for this issue is to bring up the interface first and t

[net 3/4] MAINTAINERS: Update Intel Wired LAN reviewers

2015-12-03 Thread Jeff Kirsher
Since Matthew has moved on to other pastures and no longer works for Intel, remove him from the list of reviewers and add Bruce Allan as his replacement. CC: Bruce Allan Signed-off-by: Jeff Kirsher --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

[net 1/4] ixgbe: Reset interface after enabling SR-IOV

2015-12-03 Thread Jeff Kirsher
From: Alexander Duyck Enabling SR-IOV and then bringing the interface up was resulting in the PF MAC addresses getting into a bad state. Specifically the MAC address was enabled for both VF 0 and the PF. This resulted in some odd behaviors such as VF 0 receiving a copy of the PFs traffic, which

[net 2/4] e100.txt: Cleanup license info in kernel doc

2015-12-03 Thread Jeff Kirsher
Apparently the e100.txt document contained a "License" section left over from days of old, which does not need to be in the kernel documentation. So clean it up.. CC: John Ronciak Signed-off-by: Jeff Kirsher Tested-by: Aaron Brown --- Documentation/networking/e100.txt | 14 -- 1 f

[net 4/4] i40e/i40evf: avoid mutex re-init

2015-12-03 Thread Jeff Kirsher
From: Jesse Brandeburg If the driver were to happen to have a mutex held while the i40e_init_adminq call was called, the init_adminq might inadvertently call mutex_init on a lock that was held which is a violation of the calling semantics. Fix this by avoiding adminq.c code allocating/freeing th

Re: [RFC PATCH] af_unix: fix entry locking in unix_dgram_recvmsg

2015-12-03 Thread Eric Dumazet
On Thu, 2015-12-03 at 21:24 +, Rainer Weikusat wrote: > As far as I can tell, yes. With the change, unix_dgram_recvmsg has a > read loop looking like this: > > last = NULL; /* not really necessary */ I am not sure SO_RCVTIMEO is really used for af_unix, given its poor reaction to sysc

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-03 Thread Sowmini Varadhan
On (12/03/15 13:35), Jeff Kirsher wrote: > > I will drop your current patch in my next-queue tree (dev-queue branch) > and will await an updated patch.   sounds good. Let me work with Shannon and Andrew to make sure we cover all cases. --Sowmini -- To unsubscribe from this list: send the line

Re: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-03 Thread Jeff Kirsher
On Thu, 2015-12-03 at 10:48 -0500, Sowmini Varadhan wrote: > The patch here: http://patchwork.ozlabs.org/patch/540218/ > is marked "Awaiting Upstream", I think that means it has to first > show up in some other repo first (which one?)? > > On addiitonal testing, we found a bug in the patch: if > w

Re: [RFC PATCH] af_unix: fix entry locking in unix_dgram_recvmsg

2015-12-03 Thread Rainer Weikusat
David Miller writes: > From: Rainer Weikusat >> Rainer Weikusat writes: >> >> [...] >> >>> Insofar I understand the comment in this code block correctly, [...] >>> /* recvmsg() in non blocking mode is supposed to return >>> -EAGAIN >>> * sk_rcvtimeo is not h

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-03 Thread Sergei Shtylyov
Hello. On 12/03/2015 10:28 PM, David Miller wrote: From: Kazuya Mizuguchi This patch makes PTP support active in CONFIG mode on R-Car Gen3. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Applied, thank you. You were too fast for me. Alas, I overlooked it. :-/ Per

Re: Kernel 4.1.12 crash

2015-12-03 Thread Andrew
Hi. Thanks, I'll rebuild kernel with your patch "pppoe: fix memory corruption in padt work structure", tryto check it in test env, and try to update PPPoE servers. 03.12.2015 17:35, Guillaume Nault wrote: On Wed, Dec 02, 2015 at 06:23:35PM +0100, Guillaume Nault wrote: You can try the follo

Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-03 Thread Sergei Shtylyov
Hello. On 12/01/2015 08:04 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch makes PTP support active in CONFIG mode on R-Car Gen3. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tr

[GIT] Networking

2015-12-03 Thread David Miller
A lot of Thanksgiving turkey leftovers accumulated, here goes: 1) Fix bluetooth l2cap_chan object leak, from Johan Hedberg. 2) IDs for some new iwlwifi chips, from Oren Givon. 3) Fix rtlwifi lockups on boot, from Larry Finger. 4) Fix memory leak in fm10k, from Stephen Hemminger. 5) We have a

Re: pull-request: mac80211 2015-12-02

2015-12-03 Thread David Miller
From: Johannes Berg Date: Wed, 02 Dec 2015 22:42:10 +0100 > >> Please add them and send a new pull request, I'll just skip over your >> existing one. > > Ok, here we go, below a new pull request. Pulled, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Joe Perches
(adding lkml as this is likely better discussed there) On Thu, 2015-12-03 at 15:42 -0500, Jason Baron wrote: > On 12/03/2015 03:24 PM, Joe Perches wrote: > > On Thu, 2015-12-03 at 15:10 -0500, Jason Baron wrote: > > > On 12/03/2015 03:03 PM, Joe Perches wrote: > > > > On Thu, 2015-12-03 at 14:32 -

Re: SoCFPGA ethernet broken

2015-12-03 Thread Pavel Machek
On Thu 2015-10-15 13:25:59, Florian Fainelli wrote: > On 15/10/15 12:59, Dinh Nguyen wrote: > > On 10/15/2015 03:03 PM, Florian Fainelli wrote: > >> On 15/10/15 12:09, Dinh Nguyen wrote: > >>> Hi, > >>> > >>> commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > >>> the bus' pare

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Jason Baron
On 12/03/2015 03:24 PM, Joe Perches wrote: > On Thu, 2015-12-03 at 15:10 -0500, Jason Baron wrote: >> On 12/03/2015 03:03 PM, Joe Perches wrote: >>> On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: On 12/03/2015 01:52 PM, Aaron Conole wrote: > I think that as a minimum, the following

Re: [PATCH net-next v2 0/5] ila: Optimization to preserve value of early demux

2015-12-03 Thread David Miller
From: Tom Herbert Date: Thu, 3 Dec 2015 11:59:31 -0800 > On Thu, Dec 3, 2015 at 11:48 AM, David Miller wrote: >> From: Tom Herbert >> Date: Tue, 1 Dec 2015 15:11:07 -0800 >> >>> ip6tables -t mangle -A PREROUTING --dst 2001:0:0:33::/64 -j ILAIN >> >> The user should have to do anything like this

Re: ipsec impact on performance

2015-12-03 Thread Sowmini Varadhan
On (12/03/15 14:33), David Miller wrote: > > Doesn't skb_cow_data() contribute significantly to the ESP base cost, > especially for TCP packets? Indeed. For esp-null, it's about half of the total time spent in esp_output (for one run that I just instrumented with perf tracepoints 2.5 ms compared

Re: [patch net-next] mlxsw: core: Change BUG to WARN in hwmon code

2015-12-03 Thread David Miller
From: Jiri Pirko Date: Thu, 3 Dec 2015 10:12:03 +0100 > From: Jiri Pirko > > Better to just warn the user that something really odd is going on and > continue to run. > > Suggested-by: Or Gerlitz > Signed-off-by: Jiri Pirko Applied. -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] stmmac: ipq806x: Return error values instead of pointers

2015-12-03 Thread David Miller
From: Stephen Boyd Date: Wed, 2 Dec 2015 23:55:15 -0800 > Typically we return error pointers when we want to use those > pointers in the non-error case, but this function is just > returning error pointers or NULL for success. Change the style to > plain int to follow normal kernel coding styles

Re: [PATCH] net: phy: reset only targeted phy

2015-12-03 Thread David Miller
From: Jérôme Pouiller Date: Thu, 3 Dec 2015 10:02:35 +0100 > It is possible to address another chip on same MDIO bus. The case is > correctly handled for media advertising. It is taken into account > only if mii_data->phy_id == phydev->addr. However, this condition > was missing for reset case.

Re: [PATCH net-next v2] vxlan: consolidate output route calculation

2015-12-03 Thread David Miller
From: Jiri Benc Date: Thu, 3 Dec 2015 12:23:57 +0100 > The code for output route lookup is duplicated for ndo_start_xmit and > ndo_fill_metadata_dst. Move it to a common function. > > Signed-off-by: Jiri Benc Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubs

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Joe Perches
On Thu, 2015-12-03 at 15:10 -0500, Jason Baron wrote: > On 12/03/2015 03:03 PM, Joe Perches wrote: > > On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > > > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > > > I think that as a minimum, the following patch should be evaluted, > > > > but am un

Re: [v9, 3/6] fsl/fman: Add FMan MAC support

2015-12-03 Thread David Miller
From: Date: Thu, 3 Dec 2015 09:19:14 +0200 > +static u32 crc_table[256] = { No way. We have every conceivable implementation of CRC calculations in the kernel already. Use them. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kern

Re: [PATCH net-next 1/1] tipc: fix node reference count bug

2015-12-03 Thread David Miller
From: Jon Maloy Date: Wed, 2 Dec 2015 15:19:37 -0500 > Commit 5405ff6e15f40f2f ("tipc: convert node lock to rwlock") > introduced a bug to the node reference counter handling. When a > message is successfully sent in the function tipc_node_xmit(), > we return directly after releasing the node lo

Re: [PATCH 0/2] mvneta: implement ethtool autonegotiation control

2015-12-03 Thread David Miller
From: Stas Sergeev Date: Wed, 2 Dec 2015 20:32:24 +0300 > These 2 patches add an ability to control the > autonegotiation via ethtool. For example: > > ethtool -s eth0 autoneg off > ethtool -s eth0 autoneg on > > This is needed if you want to connect the mvneta's MII > to different switches or

Re: [PATCH 4/4] net: mv643xx: Use platform_register/unregister_drivers()

2015-12-03 Thread David Miller
From: Thierry Reding Date: Wed, 2 Dec 2015 17:30:29 +0100 > From: Thierry Reding > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > > Signed-off-by: Thierry Reding Appl

Re: [PATCH 1/4] net: bfin_mac: Use platform_register/unregister_drivers()

2015-12-03 Thread David Miller
From: Thierry Reding Date: Wed, 2 Dec 2015 17:30:26 +0100 > From: Thierry Reding > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > > Signed-off-by: Thierry Reding Appl

Re: [PATCH 2/4] net: bcm63xx: Use platform_register/unregister_drivers()

2015-12-03 Thread David Miller
From: Thierry Reding Date: Wed, 2 Dec 2015 17:30:27 +0100 > From: Thierry Reding > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > > Signed-off-by: Thierry Reding Appl

Re: [PATCH 3/4] net: mpc52xx: Use platform_register/unregister_drivers()

2015-12-03 Thread David Miller
From: Thierry Reding Date: Wed, 2 Dec 2015 17:30:28 +0100 > From: Thierry Reding > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > > Signed-off-by: Thierry Reding Appl

Re: ipsec impact on performance

2015-12-03 Thread Eric Dumazet
On Thu, 2015-12-03 at 14:33 -0500, David Miller wrote: > From: Sowmini Varadhan > Date: Tue, 1 Dec 2015 12:59:53 -0500 > > > I instrumented iperf with and without ipsec, just using esp-null, > > and 1 thread, to keep things simple. I'm seeing some pretty dismal > > performance numbers with ipse

Re: [PATCH net] pppox: use standard module auto-loading feature

2015-12-03 Thread David Miller
From: Guillaume Nault Date: Wed, 2 Dec 2015 16:27:39 +0100 > * Register PF_PPPOX with pppox module rather than with pppoe, > so that pppoe doesn't get loaded for any PF_PPPOX socket. > > * Register PX_PROTO_* with standard MODULE_ALIAS_NET_PF_PROTO() > instead of using pppox's own na

[PATCH net-next 1/4] WAN: HDLC: Detach protocol before unregistering device

2015-12-03 Thread Andrew Lunn
The current code first unregisters the device, and then detaches the protocol from it. This should be performed the other way around, since the detach may try to use state which has been freed by the unregister. Swap the order, so that we first detach and then remove the netdev. Signed-off-by: And

[PATCH net-next 4/4] batman-adv: Act on NETDEV_*_TYPE_CHANGE events

2015-12-03 Thread Andrew Lunn
A network interface can change type. It may change from a type which batman does not support, e.g. hdlc, to one it does, e.g. hdlc-eth. When an interface changes type, it sends two notifications. Handle these notifications. Signed-off-by: Andrew Lunn --- net/batman-adv/hard-interface.c | 4 +++-

[PATCH net-next 3/4] ipv6: Only act upon NETDEV_*_TYPE_CHANGE if we have ipv6 addresses

2015-12-03 Thread Andrew Lunn
An interface changing type may not have IPv6 addresses. Don't call the address configuration type change in this case. Signed-off-by: Andrew Lunn --- net/ipv6/addrconf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d84742f0

[PATCH net-next 2/4] WAN: HDLC: Call notifiers before and after changing device type

2015-12-03 Thread Andrew Lunn
An HDLC device can change type when the protocol driver is changed. Calling the notifier change allows potential users of the interface know about this planned change, and even block it. After the change has occurred, send a second notification to users can evaluate the new device type etc. Signed

[PATCH net-next 0/4] Allow BATMAN to use hdlc-eth interfaces

2015-12-03 Thread Andrew Lunn
BATMAN works over Ethernet like interfaces. hdlc-eth provides the need requirements. However, hdlc devices are often created as raw hdlc devices, which batman cannot use, and are then be transmuted into other types using sethdlc(1). Have the HDLC code emit NETDEV_*_TYPE_CHANGE events when the type

Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

2015-12-03 Thread David Miller
From: Teco Boot Date: Wed, 2 Dec 2015 10:55:40 +0100 > I faced this problem on 4.2.6, Debian Jessie, on PC Engines Alix6. > I applied the patch. It solved the problem. > > Queue up for -stable? Done. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Jason Baron
On 12/03/2015 03:03 PM, Joe Perches wrote: > On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: >> On 12/03/2015 01:52 PM, Aaron Conole wrote: >>> I think that as a minimum, the following patch should be evaluted, >>> but am unsure to whom I should submit it (after I test): > [] >> Agreed - th

Re: [PATCH v2 net 0/3] bnxt_en: set mac address and uc_list bug fixes.

2015-12-03 Thread David Miller
From: Michael Chan Date: Wed, 2 Dec 2015 01:54:05 -0500 > Fix ndo_set_mac_address() for PF and VF. > Re-apply uc_list after chip reset. > > v2: Fix compile error if CONFIG_BNXT_SRIOV is not set. Series applied, thanks Michael. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-03 Thread David Miller
From: Stefan Hajnoczi Date: Wed, 2 Dec 2015 14:43:58 +0800 > This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/6] usbnet: allow mini-drivers to consume L2 headers

2015-12-03 Thread Oliver Neukum
On Thu, 2015-12-03 at 19:24 +0100, Bjørn Mork wrote: > Assume the minidriver has taken care of all L2 header parsing > if it sets skb->protocol. This allows the minidriver to > support non-ethernet L2 headers, and even operate without > any L2 header at all. > > Signed-off-by: Bjørn Mork Acked-b

Re: [PATCH net-next v7] mpls: support for dead routes

2015-12-03 Thread David Miller
From: Roopa Prabhu Date: Tue, 1 Dec 2015 22:18:11 -0800 > From: Roopa Prabhu > > Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls > routes due to link events. Also adds code to ignore dead > routes during route selection. > > Unlike ip routes, mpls routes are not deleted when th

Re: [PATCH] net: lpc_eth: remove irq > NR_IRQS check from probe()

2015-12-03 Thread David Miller
From: Vladimir Zapolskiy Date: Wed, 2 Dec 2015 08:12:13 +0200 > If the driver is used on an ARM platform with SPARSE_IRQ defined, > semantics of NR_IRQS is different (minimal value of virtual irqs) and > by default it is set to 16, see arch/arm/include/asm/irq.h. > > This value may be less than

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Joe Perches
On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > I think that as a minimum, the following patch should be evaluted, > > but am unsure to whom I should submit it (after I test): [] > Agreed - the intention here is certainly to have no side effec

Re: [PATCH v2 net-next 0/2] ravb: More compatibility strings

2015-12-03 Thread David Miller
From: Simon Horman Date: Wed, 2 Dec 2015 14:58:31 +0900 > this short series adds generic gen2 and gen3, and soc-specific > compatibility strings for the missing gen2 SoCs. > > Key Changes in v2: > * Include "rcar-" in generic bindings Series applied, thanks Simon. -- To unsubscribe from this l

Re: [PATCH net] net_sched: fix qdisc_tree_decrease_qlen() races

2015-12-03 Thread David Miller
From: Eric Dumazet Date: Tue, 01 Dec 2015 20:08:51 -0800 > From: Eric Dumazet > > qdisc_tree_decrease_qlen() suffers from two problems on multiqueue > devices. > > One problem is that it updates sch->q.qlen and sch->qstats.drops > on the mq/mqprio root qdisc, while it should not : Daniele > re

Re: [PATCH net-next v2 0/5] ila: Optimization to preserve value of early demux

2015-12-03 Thread Tom Herbert
On Thu, Dec 3, 2015 at 11:48 AM, David Miller wrote: > From: Tom Herbert > Date: Tue, 1 Dec 2015 15:11:07 -0800 > >> ip6tables -t mangle -A PREROUTING --dst 2001:0:0:33::/64 -j ILAIN > > The user should have to do anything like this in order to just get > proper working functionality of ILA. > >

Re: [PATCH net-next v2 0/5] ila: Optimization to preserve value of early demux

2015-12-03 Thread David Miller
From: Tom Herbert Date: Tue, 1 Dec 2015 15:11:07 -0800 > ip6tables -t mangle -A PREROUTING --dst 2001:0:0:33::/64 -j ILAIN The user should have to do anything like this in order to just get proper working functionality of ILA. It should just work transparently. -- To unsubscribe from this list:

Re: [PATCH net-next v2 2/5] rhashtable: add function to replace an element

2015-12-03 Thread David Miller
From: Tom Herbert Date: Tue, 1 Dec 2015 15:11:09 -0800 > + lock = rht_bucket_lock(tbl, hash); > + > + spin_lock_bh(lock); > + > + pprev = &tbl->buckets[hash]; > + rht_for_each(he, tbl, hash) { > + if (he != obj_old) { > + pprev = &he->next; > +

Re: [net-next PATCH] net: ipv6: restrict hop_limit sysctl setting to range [1;255]

2015-12-03 Thread David Miller
From: Phil Sutter Date: Tue, 1 Dec 2015 22:45:15 +0100 > Setting a value bigger than 255 resulted in using only the lower eight > bits of that value as it is assigned to the u8 header field. To avoid > this unexpected result, reject such values. > > Setting a value of zero is technically possib

Re: [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection

2015-12-03 Thread Scott Wood
On Thu, 2015-12-03 at 04:02 -0600, Bucur Madalin-Cristian-B32716 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, December 02, 2015 11:41 PM > > > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > > > Allow the selection of the transmission queue bas

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-03 Thread Dan Williams
On Thu, 2015-12-03 at 19:24 +0100, Bjørn Mork wrote: > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless MC7455

  1   2   3   4   >