On Thu, 2015-12-03 at 14:33 -0500, David Miller wrote:
> From: Sowmini Varadhan <[email protected]>
> Date: Tue, 1 Dec 2015 12:59:53 -0500
>
> > I instrumented iperf with and without ipsec, just using esp-null,
> > and 1 thread, to keep things simple. I'm seeing some pretty dismal
> > performance numbers with ipsec, and trying to think of ways to
> > improve this. Here are my findings, please share feedback.
>
> Doesn't skb_cow_data() contribute significantly to the ESP base cost,
> especially for TCP packets?
>
> I mean, we're copying every TCP data frame.
>
> If this is the case, even with GSO/whatever offloads, I expect that
> performance will be roughly halfed.
This reminds me this thing I noticed is that we (un)clone all xmit GRE
GSO packets because of following code in iptunnel_handle_offloads() :
if (skb_is_gso(skb)) {
err = skb_unclone(skb, GFP_ATOMIC);
if (unlikely(err))
goto error;
skb_shinfo(skb)->gso_type |= gso_type_mask;
return skb;
}
This is certainly something we should avoid, since we have ~1500 bytes
of payload in skb->head per TCP skb
Ideally, part of gso_type should belong to skb, not skb_shinfo(skb) :(
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
