Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

2015-12-01 Thread Jiri Pirko
Wed, Dec 02, 2015 at 06:53:35AM CET, gerlitz...@gmail.com wrote: >On Tue, Dec 1, 2015 at 6:47 PM, Jiri Pirko wrote: >> Tue, Dec 01, 2015 at 05:35:43PM CET, gerlitz...@gmail.com wrote: >>>On Tue, Dec 1, 2015 at 5:12 PM, Jiri Pirko wrote: Tue, Dec 01, 2015 at 04:06:23PM CET, gerlitz...@gmail.c

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-01 Thread Jiri Pirko
Wed, Dec 02, 2015 at 06:47:51AM CET, gerlitz...@gmail.com wrote: >On Tue, Dec 1, 2015 at 3:49 PM, Jiri Pirko wrote: >> Implement basic procedures for joining/leaving port to/from LAG. That >> includes HW setup of collector, core LAG mapping setup. >> >> Signed-off-by: Jiri Pirko >> --- >> driver

Re: [patch net-next 09/26] team: fill-up LAG changeupper info struct and pass it along

2015-12-01 Thread Jiri Pirko
Wed, Dec 02, 2015 at 06:36:16AM CET, gerlitz...@gmail.com wrote: >On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko wrote: >> Initialize netdev_lag_upper_info structure by TX type according to >> current team mode and pass it along via netdev_master_upper_dev_link. >[...] >> --- a/drivers/net/team/team.c

Re: [patch net-next 07/26] net: add possibility to pass information about upper device via notifier

2015-12-01 Thread Jiri Pirko
Wed, Dec 02, 2015 at 06:28:35AM CET, gerlitz...@gmail.com wrote: >On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Sometimes the drivers and other code would find it handy to know some >> internal information about upper device being changed. So allow upper-code >> to p

Re: ipsec impact on performance

2015-12-01 Thread Steffen Klassert
On Tue, Dec 01, 2015 at 12:59:53PM -0500, Sowmini Varadhan wrote: > > I instrumented iperf with and without ipsec, just using esp-null, > and 1 thread, to keep things simple. I'm seeing some pretty dismal > performance numbers with ipsec, and trying to think of ways to > improve this. Here are m

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-12-01 Thread Jeff Kirsher
On Tue, 2015-12-01 at 12:48 -0800, Joe Perches wrote: > On Wed, 2015-11-25 at 11:36 -0800, Joe Perches wrote: > > On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > > > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > > >

RE: [v8, 2/6] fsl/fman: Add FMan support

2015-12-01 Thread Liberman Igal
Hi David, Thank you for your feedback, I'll address it and re-submit. Regards, Igal Liberman > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 01, 2015 11:28 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozla

[PATCH v2 net 0/3] bnxt_en: set mac address and uc_list bug fixes.

2015-12-01 Thread Michael Chan
Fix ndo_set_mac_address() for PF and VF. Re-apply uc_list after chip reset. v2: Fix compile error if CONFIG_BNXT_SRIOV is not set. Michael Chan (3): bnxt_en: Fixed incorrect implementation of ndo_set_mac_address bnxt_en: enforce proper storing of MAC address bnxt_en: Setup uc_list mac filte

[PATCH v2 net 1/3] bnxt_en: Fixed incorrect implementation of ndo_set_mac_address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang The existing ndo_set_mac_address only copies the new MAC addr and didn't set the new MAC addr to the HW. The correct way is to delete the existing default MAC filter from HW and add the new one. Because of RFS filters are also dependent on the default mac filter l2 context, th

[PATCH v2 net 3/3] bnxt_en: Setup uc_list mac filters after resetting the chip.

2015-12-01 Thread Michael Chan
Call bnxt_cfg_rx_mode() in bnxt_init_chip() to setup uc_list and mc_list mac address filters. Before the patch, uc_list is not setup again after chip reset (such as ethtool ring size change) and macvlans don't work any more after that. Modify bnxt_cfg_rx_mode() to return error codes appropriately

[PATCH v2 net 2/3] bnxt_en: enforce proper storing of MAC address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang For PF, the bp->pf.mac_addr always holds the permanent MAC addr assigned by the HW. For VF, the bp->vf.mac_addr always holds the administrator assigned VF MAC addr. The random generated VF MAC addr should never get stored to bp->vf.mac_addr. This way, when the VF wants to cha

[PATCH v2 5/5] VSOCK: Add Makefile and Kconfig

2015-12-01 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile | 4 net/vmw_vsock/Kconfig | 18 ++ net/vmw_v

[PATCH v2 4/5] VSOCK: Introduce vhost-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Add missing total_tx_buf decrement * Support flexible rx/tx descriptor layout * Refuse to assign reserved CIDs * Refuse guest CID if a

[PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-01 Thread Stefan Hajnoczi
v2: * Rebased onto Linux v4.4-rc2 * vhost: Refuse to assign reserved CIDs * vhost: Refuse guest CID if already in use * vhost: Only accept correctly addressed packets (no spoofing!) * vhost: Support flexible rx/tx descriptor layout * vhost: Add missing total_tx_buf decrement * virtio_transpo

[PATCH v2 1/5] VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic

2015-12-01 Thread Stefan Hajnoczi
From: Asias He Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 70 2 files changed, 72 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index e9eb

[PATCH v2 3/5] VSOCK: Introduce virtio-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix total_tx_buf accounting * Add virtio_transport global mutex to prevent races --- net/vmw_vsock/virtio_transport.c | 466 +

[PATCH v2 2/5] VSOCK: Introduce virtio-vsock-common.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix peer_buf_alloc inheritance on child socket * Notify other side of SOCK_STREAM disconnect (

[PATCH net-next v7] mpls: support for dead routes

2015-12-01 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is current mpls behaviour and this patch does not

[PATCH] net: lpc_eth: remove irq > NR_IRQS check from probe()

2015-12-01 Thread Vladimir Zapolskiy
If the driver is used on an ARM platform with SPARSE_IRQ defined, semantics of NR_IRQS is different (minimal value of virtual irqs) and by default it is set to 16, see arch/arm/include/asm/irq.h. This value may be less than the actual number of virtual irqs, which may break the driver initializati

Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-12-01 Thread Marcin Wojtas
2015-12-02 4:03 GMT+01:00 David Miller : > From: Marcin Wojtas > Date: Mon, 30 Nov 2015 13:27:40 +0100 > >> I'm sending v4 with corrected commit log of the last patch, in order >> to avoid possible conflicts between the branches as suggested by >> Gregory Clement. > > Series applied, thanks. Than

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-01 Thread David Decotigny
Hello, There is a set of conversion routines ulong[]<->u32[] to address this 32/64-bit compat issue. Using a u32-based bitmap would require drivers to handle the u32 bitmaps themselves, this might be confusing, considering there is a standard bitmap api; and might be error-prone as well. Plus ther

[PATCH v2 net-next 2/2] ravb: add device tree support for r8a779[123]

2015-12-01 Thread Simon Horman
Simply document new compatibility strings. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman --- v2 * No change --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 +++ 1 file changed, 3 in

[PATCH v2 net-next 1/2] ravb: add fallback compatibility strings

2015-12-01 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- v2 * Drop bogus typo non-fix * include "rcar-" in generic bindings --- Documentation/

[PATCH v2 net-next 0/2] ravb: More compatibility strings

2015-12-01 Thread Simon Horman
Hi, this short series adds generic gen2 and gen3, and soc-specific compatibility strings for the missing gen2 SoCs. Key Changes in v2: * Include "rcar-" in generic bindings Simon Horman (2): ravb: add fallback compatibility strings ravb: add device tree support for r8a779[123] Documentatio

Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

2015-12-01 Thread Or Gerlitz
On Tue, Dec 1, 2015 at 6:47 PM, Jiri Pirko wrote: > Tue, Dec 01, 2015 at 05:35:43PM CET, gerlitz...@gmail.com wrote: >>On Tue, Dec 1, 2015 at 5:12 PM, Jiri Pirko wrote: >>> Tue, Dec 01, 2015 at 04:06:23PM CET, gerlitz...@gmail.com wrote: On Tue, Dec 1, 2015 at 4:43 PM, Jiri Pirko wrote:

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

2015-12-01 Thread Sunil Kovvuri
>The driver should successfully recover from out of memory situations > and not stop RX/TX completely. This memory allocation is while interface bringup/initialization and not during packet I/O. >Don't put this off as not "related" to your patch, it is as this >introduces the behavior for this use

Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port join/leave

2015-12-01 Thread Or Gerlitz
On Tue, Dec 1, 2015 at 3:49 PM, Jiri Pirko wrote: > Implement basic procedures for joining/leaving port to/from LAG. That > includes HW setup of collector, core LAG mapping setup. > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 284 > ++

Re: Increasing skb->mark size

2015-12-01 Thread David Ahern
On 12/1/15 6:58 PM, Andi Kleen wrote: - skb_iff is either skb->dev->iff or 0. so it could be replaced with a single bit flag for the 0 case. ... and that one wouldn't work on ingress. Please explain. skb->dev is dropped fairly early in the Rx path. skb_iif is needed for example for IP_CMSG

Re: [patch net-next 09/26] team: fill-up LAG changeupper info struct and pass it along

2015-12-01 Thread Or Gerlitz
On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko wrote: > Initialize netdev_lag_upper_info structure by TX type according to > current team mode and pass it along via netdev_master_upper_dev_link. [...] > --- a/drivers/net/team/team.c > +++ b/drivers/net/team/team.c > @@ -1078,23 +1078,24 @@ static void

Re: [patch net-next 07/26] net: add possibility to pass information about upper device via notifier

2015-12-01 Thread Or Gerlitz
On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Sometimes the drivers and other code would find it handy to know some > internal information about upper device being changed. So allow upper-code > to pass information down to notifier listeners during linking. [...] > diff

Re: [PATCH net-next 3/3] vhost_net: basic polling support

2015-12-01 Thread Jason Wang
On 12/01/2015 10:43 PM, Michael S. Tsirkin wrote: > On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: >> >> On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason Wang wrote: > This patch tries to poll for new added tx buffer or socket

[P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

2015-12-01 Thread Christian Zigotzky
Hi all, We tested some 4.3 kernels on a P.A. Semi reference board. Ultimately, ethernet does not work, though on the reference board, the interface is detected, gets link, but will not pass any packets/traffic. Somewhere in the source code of the commit "'powerpc-4.3-1' of git://git.kernel.o

Re: [PATCH net 2/3] bnxt_en: enforce properly storing of MAC address

2015-12-01 Thread kbuild test robot
Hi Jeffrey, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-set-mac-address-and-uc_list-bug-fixes/20151202-112939 config: x86_64-randconfig-s2-12021213 (attached as .config) reproduce: # save the attached .config to linux build

Re: [PATCH net-next v6] mpls: support for dead routes

2015-12-01 Thread roopa
On 12/1/15, 12:43 PM, David Miller wrote: > From: Roopa Prabhu > Date: Sat, 28 Nov 2015 19:38:33 -0800 > >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead >> routes during route selection. > I agree with Robert's feedback

[v2] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-01 Thread Brent Taylor
Since commit 8437754c8335 ("ath6kl: Use vmalloc instead of kmalloc for fw") ar->fw is expected to be pointing to memory allocated by vmalloc. If the api1 method (via ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw, then kmemdup is used. This patch checks if the firmware being loaded is

[PATCH net] net_sched: fix qdisc_tree_decrease_qlen() races

2015-12-01 Thread Eric Dumazet
From: Eric Dumazet qdisc_tree_decrease_qlen() suffers from two problems on multiqueue devices. One problem is that it updates sch->q.qlen and sch->qstats.drops on the mq/mqprio root qdisc, while it should not : Daniele reported underflows errors : [ 681.774821] PAX: sch->q.qlen: 0 n: 1 [ 681.

Re: [PATCH iproute2 -next] examples, bpf: further improve examples

2015-12-01 Thread Alexei Starovoitov
On Wed, Dec 02, 2015 at 12:25:36AM +0100, Daniel Borkmann wrote: > Improve example files further and add a more generic set of possible > helpers for them that can be used. > > Signed-off-by: Daniel Borkmann looks good. Acked-by: Alexei Starovoitov -- To unsubscribe from this list: send the li

Re: [PATCH net-next v2 4/5] ila: Add generic ILA translation facility

2015-12-01 Thread kbuild test robot
Hi Tom, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/ila-Optimization-to-preserve-value-of-early-demux/20151202-111601 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDI

Re: Increasing skb->mark size

2015-12-01 Thread Lorenzo Colitti
On Wed, Dec 2, 2015 at 4:13 AM, Andi Kleen wrote: > This would be be great. I've recently ran into some issues with > the overhead of the Android firewall setup. Can you elaborate on which issues? If such a discussion would be off-topic here, you can open a bug at https://code.google.com/p/androi

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-01 Thread Tom Herbert
On Tue, Dec 1, 2015 at 7:49 AM, Hannes Frederic Sowa wrote: > On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote: >> On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert wrote: >> > On Mon, Nov 30, 2015 at 5:28 PM, Jesse Gross wrote: >> >> > > Based on what we can do today, I see only two rea

[PATCH net 0/3] bnxt_en: set mac address and uc_list bug fixes.

2015-12-01 Thread Michael Chan
Fix ndo_set_mac_address() for PF and VF. Re-apply uc_list after chip reset. Michael Chan (3): bnxt_en: Fixed incorrect implemenation of ndo_set_mac_address bnxt_en: enforce properly storing of MAC address bnxt_en: Setup uc_list mac filters after resetting the chip. drivers/net/ethernet/bro

[PATCH net 2/3] bnxt_en: enforce properly storing of MAC address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang For PF, the bp->pf.mac_addr always holds the permanent MAC addr assigned by the HW. For VF, the bp->vf.mac_addr always holds the administrator assigned VF MAC addr. The random generated VF MAC addr should never get stored to bp->vf.mac_addr. This way, when the VF wants to cha

[PATCH net 3/3] bnxt_en: Setup uc_list mac filters after resetting the chip.

2015-12-01 Thread Michael Chan
Call bnxt_cfg_rx_mode() in bnxt_init_chip() to setup uc_list and mc_list mac address filters. Before the patch, uc_list is not setup again after chip reset (such as ethtool ring size change) and macvlans don't work any more after that. Modify bnxt_cfg_rx_mode() to return error codes appropriately

[PATCH net 1/3] bnxt_en: Fixed incorrect implementation of ndo_set_mac_address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang The existing ndo_set_mac_address only copies the new MAC addr and didn't set the new MAC addr to the HW. The correct way is to delete the existing default MAC filter from HW and add the new one. Because of RFS filters are also dependent on the default mac filter l2 context, th

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-01 Thread David Miller
From: David Decotigny Date: Mon, 30 Nov 2015 14:05:41 -0800 > This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by > the new get_ksettings/set_ksettings callbacks. This API provides > support for most legacy ethtool_cmd fields, adds support for larger > link mode masks (up to 4064

Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-12-01 Thread David Miller
From: Marcin Wojtas Date: Mon, 30 Nov 2015 13:27:40 +0100 > I'm sending v4 with corrected commit log of the last patch, in order > to avoid possible conflicts between the branches as suggested by > Gregory Clement. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscr

Re: Increasing skb->mark size

2015-12-01 Thread Andi Kleen
> >This would be be great. I've recently ran into some issues with > >the overhead of the Android firewall setup. > > > >So basically you need 4 extra bytes in sk_buff. How about: > > > >- shrinking skb->priority to 2 byte > > That wouldn't work, see SO_PRIORITY and such (4 bytes) ... But does an

Re: [PATCH net] bpf, array: fix heap out-of-bounds access when updating elements

2015-12-01 Thread David Miller
From: Daniel Borkmann Date: Mon, 30 Nov 2015 13:02:55 +0100 > During own review but also reported by Dmitry's syzkaller [1] it has been > noticed that we trigger a heap out-of-bounds access on eBPF array maps > when updating elements. This happens with each map whose map->value_size > (specified

Re: [PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room

2015-12-01 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 1 Dec 2015 16:42:58 -0800 > In an attempt to avoid having to allocate memory on the send path, the netvsc > driver was requesting additional head room so that both rndis header and the > netvsc packet (the state that had to persist) could be placed in the skb.

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Jesse Brandeburg Date: Tue, 1 Dec 2015 15:44:54 -0800 > While I agree that ethtool provides a similar functionality, ethtool > was designed (particularly the ethtool -C/c commands) around one queue > NICs. We can't change the output or functionality of the user > interface without breaking

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Florian Fainelli Date: Tue, 01 Dec 2015 14:13:34 -0800 > The new interface you propose makes things inconsistent, since we have > two separate configuration paths (sysfs and ethtool), and it would seem > better to have per-queue awareness in ethtool, since there is a whole > bunch of other

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Alexander Duyck
On Tue, Dec 1, 2015 at 3:44 PM, Jesse Brandeburg wrote: > On Tue, 1 Dec 2015 14:13:34 -0800 > Florian Fainelli wrote: > >> On 01/12/15 00:01, kan.li...@intel.com wrote: >> > From: Kan Liang >> > >> > Network devices usually have many queues. Each queue has its own >> > tx_usecs options. Currentl

Re: [RFC] Stable interface index option

2015-12-01 Thread Andrew Lunn
> In general the ifindexes are designed to not be reused very fast. Some parts of multicast group management rely on this. You need to remove group memberships from a socket when an interface has disappeared, e.g. a VPN interface has gone away. You can pass the ifindex of the no longer existing in

Re: ipsec impact on performance

2015-12-01 Thread David Ahern
On 12/1/15 5:09 PM, Sowmini Varadhan wrote: The not-so-great news is that I see that just adding perf tracepoints (not even enabling them!) seems to make a small diff (3 Gbps vs 3.2 Gbps) to my numbers. Is that mere standard-deviation, or something one should be aware of, about perf? existence

Re: ipsec impact on performance

2015-12-01 Thread Sowmini Varadhan
On (12/01/15 16:56), David Ahern wrote: > > Using iperf3 and AH with NULL algorithm between 2 peers connected by > a 10G link. > I'm using esp-null, not AH, and iperf2, which I understand is quite different from, and more aggressive than, iperf3 (though I'm not sure that it matters for this sin

Re: ipsec impact on performance

2015-12-01 Thread David Ahern
On 12/1/15 10:17 AM, Rick Jones wrote: On 12/01/2015 09:59 AM, Sowmini Varadhan wrote: But these are all still relatively small things - tweaking them doesnt get me significantly past the 3 Gbps limit. Any suggestions on how to make this budge (or design criticism of the patch) would be welcome.

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-01 Thread Singhai, Anjali
On 12/1/2015 8:08 AM, John W. Linville wrote: On Tue, Dec 01, 2015 at 04:49:28PM +0100, Hannes Frederic Sowa wrote: On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote: On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert wrote: On Mon, Nov 30, 2015 at 5:28 PM, Jesse Gross wrote: Based

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

2015-12-01 Thread Simon Horman
On Tue, Dec 01, 2015 at 09:42:52AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 1, 2015 at 8:43 AM, Simon Horman > wrote: > > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers f

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

2015-12-01 Thread Simon Horman
On Tue, Dec 01, 2015 at 01:26:08PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/1/2015 10:43 AM, Simon Horman wrote: > > >Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for R

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
Hello, On Tue, Dec 1, 2015, at 23:43, Maximilian Wilhelm wrote: > Anno domini 2015 Hannes Frederic Sowa scripsit: > > > On Tue, Dec 1, 2015, at 20:27, David Miller wrote: > > > From: Hannes Frederic Sowa > > > Date: Tue, 01 Dec 2015 17:02:23 +0100 > > > > > > > On Tue, Dec 1, 2015, at 16:50, Ma

Re: r8169 regression: UDP packets dropped intermittantly

2015-12-01 Thread Francois Romieu
Jonathan Woithe : [...] > Any thoughts or progress at this stage? Are there further tests you need me > to do ? Yes but you should expect two more days without signal. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kern

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Jesse Brandeburg
On Tue, 1 Dec 2015 14:13:34 -0800 Florian Fainelli wrote: > On 01/12/15 00:01, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Network devices usually have many queues. Each queue has its own > > tx_usecs options. Currently, we can only set all the queues with same > > value by ethtool.

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-12-01 Thread Marcin Wojtas
Gregory, Please apply below patch: http://pastebin.com/t42xyU3i It will confirm if there's an overflow for CS0 size in your setup. Please let know. So far the issue may have been not noticed, because in every IO driver using mvebu_mbus_dram_info for configuring MBUS windows, there's following sub

[PATCH iproute2 -next] examples, bpf: further improve examples

2015-12-01 Thread Daniel Borkmann
Improve example files further and add a more generic set of possible helpers for them that can be used. Signed-off-by: Daniel Borkmann --- examples/bpf/bpf_cyclic.c | 38 examples/bpf/bpf_funcs.h| 76 --- examples/bpf/bpf_graft.c| 39 examples/bpf/bpf_p

[PATCH net-next V3 15/17] hv_netvsc: Eliminate xmit_more from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate xmit_more from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c | 13 - drivers/net/hyperv/netvsc_drv.c |1 - drivers/net/hyperv/rndis_filter.c |2 -- 4 files changed, 8 in

[PATCH net-next V3 02/17] hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficient

2015-12-01 Thread K. Y. Srinivasan
Rearrange the elements of struct hv_negtvsc_packet for optimal layout - eliminate unnecessary padding. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/driver

[PATCH net-next V3 06/17] hv_netvsc: Eliminate send_completion from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |3 +-- drivers/net/hyperv/netvsc.c |6 +++--- drivers/net/hyperv/netvsc_drv.c |2 +- drivers/net/hyperv/rndis_filter.c |

[PATCH net-next V3 03/17] hv_netvsc: Eliminate the channel field in hv_netvsc_packet structure

2015-12-01 Thread K. Y. Srinivasan
Eliminate the channel field in hv_netvsc_packet structure. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 22 ++ drivers/net/hyperv/netvsc.c | 19 --- drivers/net/hyperv/netvsc_drv.c |5 +++--

[PATCH net-next V3 14/17] hv_netvsc: Eliminate completion_func from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate completion_func from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc_drv.c |3 --- drivers/net/hyperv/rndis_filter.c |1 - 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH net-next V3 04/17] hv_netvsc: Eliminate rndis_msg pointer from hv_netvsc_packet structure

2015-12-01 Thread K. Y. Srinivasan
Eliminate rndis_msg pointer from hv_netvsc_packet structure. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |8 +++- drivers/net/hyperv/netvsc.c | 10 ++ drivers/net/hyperv/netvsc_drv.c |7 +++ drivers/net/hyper

[PATCH net-next V3 05/17] hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminatte the data field from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |5 ++--- drivers/net/hyperv/netvsc.c |5 +++-- drivers/net/hyperv/netvsc_drv.c |3 ++- drivers/net/hyperv/rndis_filter.c

[PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room

2015-12-01 Thread K. Y. Srinivasan
In an attempt to avoid having to allocate memory on the send path, the netvsc driver was requesting additional head room so that both rndis header and the netvsc packet (the state that had to persist) could be placed in the skb. Since the amount of head room requested was exceeding the default head

[PATCH net-next V3 10/17] hv_netvsc: remove locking in netvsc_send()

2015-12-01 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Packet scheduler guarantees there won't be multiple senders for the same queue and as we use q_idx for multi_send_data the spinlock is redundant. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hy

[PATCH net-next V3 08/17] hv_netvsc: Don't ask for additional head room in the skb

2015-12-01 Thread K. Y. Srinivasan
The rndis header is 116 bytes big and can be placed in the default head room that will be available in the skb. Since the netvsc packet is less than 48 bytes, we can use the skb control buffer for the netvsc packet. With these changes we don't need to ask for additional head room. Signed-off-by: K

[PATCH net-next V3 13/17] hv_netvsc: Eliminate is_data_pkt from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate is_data_pkt from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c | 14 -- drivers/net/hyperv/netvsc_drv.c |1 - drivers/net/hyperv/rndis_filter.c |1 - 4 files changed, 8

[PATCH ney-next V3 12/17] hv_netvsc: Eliminate send_completion_tid from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion_tid from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |8 ++-- drivers/net/hyperv/netvsc.c | 28 ++-- drivers/net/hyperv/netvsc_drv.c | 14 ++ drivers/net/hyperv/rn

[PATCH net-next V3 09/17] hv_netvsc: move subchannel existence check to netvsc_select_queue()

2015-12-01 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 15 --- drivers/net/hyperv/netvsc.c |5 ++--- drivers/net/hyperv/netvsc_drv.c |3 +++ 3 files changed, 5 insertions(+), 18 deletions(-) diff -

[PATCH net-next v2 0/5] ila: Optimization to preserve value of early demux

2015-12-01 Thread Tom Herbert
In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack c

[PATCH net-next V3 07/17] hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion_ctx from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c |3 +-- drivers/net/hyperv/netvsc_drv.c |1 - 3 files changed, 1 insertions(+), 4 deletion

[PATCH net-next v2 2/5] rhashtable: add function to replace an element

2015-12-01 Thread Tom Herbert
Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1 file changed, 82 insertio

[PATCH net-next V3 17/17] hv_netvsc: Eliminate vlan_tci from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate vlan_tci from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |4 ++-- drivers/net/hyperv/netvsc_drv.c | 14 +++--- drivers/net/hyperv/rndis_filter.c |7 +++ 3 files changed, 12 insertions(+), 13 deletions(-) diff

[PATCH net-next v2 1/5] ila: Create net/ipv6/ila directory

2015-12-01 Thread Tom Herbert
Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +- net/ipv6/ila.c

[PATCH net-next v2 5/5] net: ILA iptables target

2015-12-01 Thread Tom Herbert
Add two target ILAIN and ILAOUT which hook into the ILA module. Signed-off-by: Tom Herbert --- net/netfilter/Kconfig | 12 net/netfilter/Makefile | 1 + net/netfilter/xt_ILA.c | 82 ++ 3 files changed, 95 insertions(+) create mode 10064

[PATCH net-next v2 4/5] ila: Add generic ILA translation facility

2015-12-01 Thread Tom Herbert
This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using rhasht

[PATCH net-next V3 16/17] hv_netvsc: Eliminate status from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate status from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c |6 ++ drivers/net/hyperv/netvsc_drv.c |8 ++-- drivers/net/hyperv/rndis_filter.c | 20 +--- 4 file

[PATCH net-next v2 3/5] netlink: add a start callback for starting a netlink dump

2015-12-01 Thread Tom Herbert
The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c | 4 net/netlink/

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 14:47 -0800, Cong Wang wrote: > On Tue, Dec 1, 2015 at 2:33 PM, Eric Dumazet wrote: > > Hmm... it looks like we have a much more serious bug : > > > > qdisc_lookup() calls qdisc_match_from_root(dev->qdisc, handle) without > > proper lock being held, so we might actually crash

[PATCH net-next V3 01/17] hv_netvsc: Resize some of the variables in hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
As part of reducing the size of the hv_netvsc_packet, resize some of the variables based on their usage. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/n

[PATCH net-next V3 11/17] hv_netvsc: Eliminate page_buf from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate page_buf from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |4 ++-- drivers/net/hyperv/netvsc.c | 25 ++--- drivers/net/hyperv/netvsc_drv.c | 11 ++- drivers/net/hy

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Cong Wang
On Tue, Dec 1, 2015 at 2:33 PM, Eric Dumazet wrote: > Hmm... it looks like we have a much more serious bug : > > qdisc_lookup() calls qdisc_match_from_root(dev->qdisc, handle) without > proper lock being held, so we might actually crash the host, > if qdisc_tree_decrease_qlen() happens at the time

Re: [RFC] Stable interface index option

2015-12-01 Thread Maximilian Wilhelm
Anno domini 2015 Hannes Frederic Sowa scripsit: > On Tue, Dec 1, 2015, at 20:27, David Miller wrote: > > From: Hannes Frederic Sowa > > Date: Tue, 01 Dec 2015 17:02:23 +0100 > > > > > On Tue, Dec 1, 2015, at 16:50, Maximilian Wilhelm wrote: > > >> > I'm not sure I understand how this would work-

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Cong Wang
On Tue, Dec 1, 2015 at 12:06 PM, Eric Dumazet wrote: > On Tue, 2015-12-01 at 11:17 -0800, Cong Wang wrote: >> On Tue, Dec 1, 2015 at 11:09 AM, Eric Dumazet wrote: >> > On Tue, 2015-12-01 at 10:43 -0800, Cong Wang wrote: >> > >> >> This smells hacky... Another way to fix this is to hold the qdisc

Re: xen-netfront crash when detaching network while some network activity

2015-12-01 Thread Marek Marczykowski-Górecki
On Tue, Dec 01, 2015 at 05:00:42PM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 17, 2015 at 03:45:15AM +0100, Marek Marczykowski-Górecki wrote: > > On Wed, Oct 21, 2015 at 08:57:34PM +0200, Marek Marczykowski-Górecki wrote: > > > On Wed, May 27, 2015 at 12:03:12AM +0200, Marek Marczykowski-Gór

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 12:06 -0800, Eric Dumazet wrote: > On Tue, 2015-12-01 at 11:17 -0800, Cong Wang wrote: > > On Tue, Dec 1, 2015 at 11:09 AM, Eric Dumazet > > wrote: > > > On Tue, 2015-12-01 at 10:43 -0800, Cong Wang wrote: > > > > > >> This smells hacky... Another way to fix this is to hold

Re: [RFC] Stable interface index option

2015-12-01 Thread Stephen Hemminger
On Tue, 01 Dec 2015 22:54:54 +0100 Hannes Frederic Sowa wrote: > > On Tue, Dec 1, 2015, at 22:44, Stephen Hemminger wrote: > > On Tue, 01 Dec 2015 22:14:59 +0100 > > Hannes Frederic Sowa wrote: > > > I had several snmp installations with net-snmp and munin, cacti and so > > > on and all had the

Re: [RESEND PATCH] arm64: bpf: add 'store immediate' instruction

2015-12-01 Thread Shi, Yang
On 11/30/2015 2:24 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation has to be implemented by the below instruction sequence: Load immediate to register Store register Signed-off-by: Yang Shi CC: Zi Shen Lim Had email exchange offline with Zi Shen L

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Florian Fainelli
On 01/12/15 00:01, kan.li...@intel.com wrote: > From: Kan Liang > > Network devices usually have many queues. Each queue has its own > tx_usecs options. Currently, we can only set all the queues with same > value by ethtool. This patch expose the tx_usecs in sysfs. So the user > can set/get per q

Re: Increasing skb->mark size

2015-12-01 Thread Daniel Borkmann
On 12/01/2015 08:13 PM, Andi Kleen wrote: Lorenzo Colitti writes: On Wed, Nov 25, 2015 at 5:32 AM, Matt Bennett wrote: I'm emailing this list for feedback on the feasibility of increasing skb->mark or adding a new field for marking. Perhaps this extension could be done under a new CONFIG opti

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
On Tue, Dec 1, 2015, at 22:44, Stephen Hemminger wrote: > On Tue, 01 Dec 2015 22:14:59 +0100 > Hannes Frederic Sowa wrote: > > I had several snmp installations with net-snmp and munin, cacti and so > > on and all had the interface name in ifDescription already some years > > back. > > In net-snm

[net-next PATCH] net: ipv6: restrict hop_limit sysctl setting to range [1;255]

2015-12-01 Thread Phil Sutter
Setting a value bigger than 255 resulted in using only the lower eight bits of that value as it is assigned to the u8 header field. To avoid this unexpected result, reject such values. Setting a value of zero is technically possible, but hosts receiving such a packet have to treat it like hop_limi

  1   2   3   4   >