On Tue, 1 Dec 2015 14:13:34 -0800 Florian Fainelli <f.faine...@gmail.com> wrote:
> On 01/12/15 00:01, kan.li...@intel.com wrote: > > From: Kan Liang <kan.li...@intel.com> > > > > Network devices usually have many queues. Each queue has its own > > tx_usecs options. Currently, we can only set all the queues with same > > value by ethtool. This patch expose the tx_usecs in sysfs. So the user > > can set/get per queue coalesce parameter tx_usecs by sysfs. > > The new interface you propose makes things inconsistent, since we have > two separate configuration paths (sysfs and ethtool), and it would seem > better to have per-queue awareness in ethtool, since there is a whole > bunch of other parameters that could be configured on a per-queue basis. > > Have you tried to extend existing ethtool interfaces to cover the need > for multiple queues? While I agree that ethtool provides a similar functionality, ethtool was designed (particularly the ethtool -C/c commands) around one queue NICs. We can't change the output or functionality of the user interface without breaking a bunch of user's scripts and stuff. With this effort, Kan is laying groundwork for making further kernel changes, and having the kernel call back in to drivers via ethtool mechanisms that were designed before multiple queue adapters. We can also next migrate the legacy ethtool interfaces to use these new .ndo_ops should we wish. These patches were provided with the intent of getting some feedback about going down this path of making a *consistent* user interface that is driver agnostic in sysfs, and supports multiple queue adapters. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
