Re: [PATCH net-next rfc V2 0/2] basic busy polling support for vhost_net

2015-11-02 Thread Jason Wang
On 10/30/2015 07:58 PM, Jason Wang wrote: > > On 10/29/2015 04:45 PM, Jason Wang wrote: >> Hi all: >> >> This series tries to add basic busy polling for vhost net. The idea is >> simple: at the end of tx processing, busy polling for new tx added >> descriptor and rx receive socket for a while. Th

Re: [PATCH net-next] mpls: support for dead routes

2015-11-02 Thread Julia Lawall
Please check on what was intended. julia On Tue, 3 Nov 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1446498529-50275-1-git-send-email-ro...@cumulusnetworks.com> > TO: Roopa Prabhu > CC: ebied...@xmission.com, rshea...@brocade.com, da...@davemloft.net, > netdev@vger.ke

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-11-02 Thread Matthias Tafelmeier
> Your perception is incorrect. > I am still maintaining iproute2. Phil is just providing lots of feedback > and new patches. No offense intendet! I know, Phil has already clarified things in the other responses. Maybe you overlooked those accidentally. > The size of the change makes it harder to

[PATCH net-next V1 6/7] net/mlx5e: Re-eanble client vlan TX acceleration

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat This reverts commit cd58c714acb9 "net/mlx5e: Disable client vlan TX acceleration". Bring back client vlan insertion offload, the original performance issue was found and fixed in the next patch. Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/eth

Re: [PATCH net-next V1 0/7] Mellanox mlx5e driver update, Nov 3 2015

2015-11-02 Thread Or Gerlitz
On Tue, Nov 3, 2015 at 8:07 AM, Or Gerlitz wrote: > This series contains bunch of small fixes to the mlx5e driver from Achiad. Oops, I missed your email from 2h ago... but these all ARE bug fixes, so hopefully I didn't really violated the directive (I guess I should have just asked, but again, I

[PATCH net-next V1 1/7] net/mlx5e: Avoid NULL pointer access in case of configuration failure

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat In case a configuration operation that involves closing and re-opening resources (e.g RX/TX queue size change) fails at the re-opening stage these resources will remain closed. So when executing (following) configuration operations (e.g ifconfig down) we cannot assume that th

[PATCH net-next V1 4/7] net/mlx5e: Don't allow more than max supported channels

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat Consider MLX5E_MAX_NUM_CHANNELS @ethtool set/get_channels Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 ++ drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 5 ++--- drivers/net/ethernet/mell

[PATCH net-next V1 5/7] net/mlx5e: Return error in case mlx5e_set_features() fails

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat In case mlx5e_set_features() fails, return the failure status rather than 0. Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ether

[PATCH/RFC v2] ravb: use clock rate as basis for GTI.TIV

2015-11-02 Thread Simon Horman
The GTI.TIV may be set to 2GHz^2 / rate, where rate is that of the clock of the device. Rather than assuming a rate of 130MHz use the actual rate of the clock. The motivation for this is to use the correct rate on the r8a7795/Salvator-X which is advertised as 133MHz but may differ depending on the

[PATCH net-next V1 7/7] net/mlx5e: Fix LSO vlan insertion

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat Consider vlan insertion impact on headers copy size also for LSO packets. Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ether

[PATCH net-next V1 2/7] net/mlx5e: Wait for RX buffers initialization in a more proper manner

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat Use jiffies rather than wait loop with msleep(). The wait loop didn't take into consideration time when the process was not executing. Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 1 file changed,

[PATCH net-next V1 0/7] Mellanox mlx5e driver update, Nov 3 2015

2015-11-02 Thread Or Gerlitz
Hi Dave, This series contains bunch of small fixes to the mlx5e driver from Achiad. Applies on net-next commit e7b63ff "Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next" Or. Changes from V0: - removed the driver patch that dealt with IRQ affinity cha

[PATCH net-next V1 3/7] net/mlx5_core: Use the the real irqn in eq->irqn

2015-11-02 Thread Or Gerlitz
From: Achiad Shochat Instead of storing the msix array index in eq->irqn (vecidx), store the real irq number. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 8 1 file changed, 4 insertions(+),

Re: [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete

2015-11-02 Thread Eric W. Biederman
Sergei Shtylyov writes: > Hello. >> >> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c >> index c70d750148b6..893cd2dc3979 100644 >> --- a/net/mpls/af_mpls.c >> +++ b/net/mpls/af_mpls.c >> @@ -1162,6 +1162,8 @@ static int rtm_to_route_config(struct sk_buff *skb, >> struct nlmsghdr *nlh, >>

[PATCH net-next v2] mpls: support for dead routes

2015-11-02 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu --- RFC to v1: Addressed a few comments from Eric and Robert: - remove support for

Re: [PATCH net] net: avoid NULL deref in inet_ctl_sock_destroy()

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 22:46 -0500, David Miller wrote: > From: Eric Dumazet > Date: Mon, 02 Nov 2015 07:50:07 -0800 > > > From: Eric Dumazet > > > > Under low memory conditions, tcp_sk_init() and icmp_sk_init() > > can both iterate on all possible cpus and call inet_ctl_sock_destroy(), > > with

RE: [PATCH][v2] net: phy: fix a bug in get_phy_c45_ids

2015-11-02 Thread Shaohui Xie
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, November 03, 2015 12:02 PM > To: shh@gmail.com > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Xie Shaohui-B21989 > Subject: Re: [PATCH][v2] net: phy: fix a bug in get_phy_c45_ids > > From: > D

[PATCH][v3] net: phy: fix a bug in get_phy_c45_ids

2015-11-02 Thread shh.xie
From: Shaohui Xie When probing devices-in-package for a c45 phy, device zero is the last device to probe, however, if driver reads 0 from device zero, c45_ids->devices_in_package is set to '0', the loop condition of probing will be matched again, see codes below: for (i = 1;i < num_ids && c45_id

Re: [PATCH][v3] net: phy: fix a bug in get_phy_c45_ids

2015-11-02 Thread David Miller
From: Date: Tue, 3 Nov 2015 12:27:33 +0800 > From: Shaohui Xie > > When probing devices-in-package for a c45 phy, device zero is the last > device to probe, however, if driver reads 0 from device zero, > c45_ids->devices_in_package is set to '0', the loop condition of probing > will be matched

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

2015-11-02 Thread David Miller
From: Jarod Wilson Date: Mon, 2 Nov 2015 21:55:59 -0500 > There are some netdev features, which when disabled on an upper device, > such as a bonding master or a bridge, must be disabled and cannot be > re-enabled on underlying devices. > > This is a rework of an earlier more heavy-handed appra

Re: [PATCH net-next] mpls: support for dead routes

2015-11-02 Thread David Miller
From: Roopa Prabhu Date: Mon, 2 Nov 2015 13:08:49 -0800 > + if ((nh->nh_flags & RTNH_F_DEAD) || > + (nh->nh_flags & RTNH_F_LINKDOWN)) > + continue; A single "& (RTNH_F_DEAD | RTNH_F_LINKDOWN)" is more efficient and more canonical. > + if ((nh

Re: [v7, 2/6] fsl/fman: Add FMan support

2015-11-02 Thread David Miller
From: Date: Mon, 2 Nov 2015 14:30:12 +0200 > +static int clear_iram(struct fman *fman) > +{ > + struct fman_iram_regs __iomem *iram; > + int i, count; > + > + iram = (struct fman_iram_regs __iomem *)(fman->base_addr + IMEM_OFFSET); "fman->base_addr" is of type "void __iomem *", there

nothing other than BUG fixes please

2015-11-02 Thread David Miller
If it's not a bug fix, I really don't want to see it submitted at this time. No exceptions. Things will stay this way until some short period after the merge window opens and I open up net-next and patchwork to new feature patches and cleanups. Anyone violating this will not even get an email r

Re: [PATCH net] sfc: push partner queue for skb->xmit_more

2015-11-02 Thread David Miller
From: Martin Habets Date: Mon, 2 Nov 2015 12:51:31 + > When the IP stack passes SKBs the sfc driver puts them in 2 different TX > queues (called partners), one for checksummed and one for not checksummed. > If the SKB has xmit_more set the driver will delay pushing the work to the > NIC. > >

Re: [PATCH][v2] net: phy: fix a bug in get_phy_c45_ids

2015-11-02 Thread David Miller
From: Date: Mon, 2 Nov 2015 18:48:33 +0800 > @@ -205,6 +205,37 @@ struct phy_device *phy_device_create(struct mii_bus > *bus, int addr, int phy_id, > } > EXPORT_SYMBOL(phy_device_create); > > + /* get_phy_c45_devs_in_pkg - reads a MMD's devices in package registers. > + * @bus: the target MI

Re: [PATCH] sh_eth: fix typo in RX descriptor bit name

2015-11-02 Thread David Miller
From: Sergei Shtylyov Date: Tue, 03 Nov 2015 01:28:07 +0300 > The correct name of the RX descriptor 0 bit 30 is RDLE (receive descriptor > list end), not RDEL. > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against the Dave Miller's 'net-next.git' repo. Applied. -- To unsubscribe

Re: Resource leak in unshare

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Mon, 02 Nov 2015 17:16:44 -0800 > On Mon, 2015-11-02 at 17:08 -0800, Eric Dumazet wrote: >> From: Eric Dumazet > > Erm, patch title would be : > > [PATCH] sit: fix sit0 percpu double allocations :-) Applied and queued up for -stable. -- To unsubscribe from this list:

Re: [PATCH next 0/3] re-org actor admin/oper key updates

2015-11-02 Thread David Miller
From: Mahesh Bandewar Date: Sat, 31 Oct 2015 12:44:55 -0700 > I was observing machines entering into weird LACP state when the > partner is in passive mode. This issue is not because of the partners > in passive state but probably because of some operational key update > which is pushing the stat

Re: [PATCH net-next v2 0/5] BPF updates

2015-11-02 Thread David Miller
From: Daniel Borkmann Date: Thu, 29 Oct 2015 14:58:05 +0100 > This set adds support for persistent maps/progs. Please see > individual patches for further details. A man-page update > to bpf(2) will be sent later on, also a iproute2 patch for > support in tc. ... > v1 -> v2: > - Reworked most

Re: [PATCH -stable 3.18, backport] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread Sasha Levin
On 11/02/2015 10:32 PM, Ani Sinha wrote: > On Mon, Nov 2, 2015 at 4:50 PM, Eric Dumazet wrote: >> > On Mon, 2015-11-02 at 16:40 -0800, Ani Sinha wrote: >>> >> [ Upstream commit 44f49dd8b5a606870a1f2 ] >> > >> > Please carefully read Documentation/networking/netdev-FAQ.txt > I don't see any recent

Re: [PATCH net] net: avoid NULL deref in inet_ctl_sock_destroy()

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Mon, 02 Nov 2015 07:50:07 -0800 > From: Eric Dumazet > > Under low memory conditions, tcp_sk_init() and icmp_sk_init() > can both iterate on all possible cpus and call inet_ctl_sock_destroy(), > with eventual NULL pointer. > > Signed-off-by: Eric Dumazet > Reported-by

Re: [PATCH net-next] net: fix percpu memory leaks

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Mon, 02 Nov 2015 09:03:11 -0800 > From: Eric Dumazet > > This patch fixes following problems : > > 1) percpu_counter_init() can return an error, therefore > init_frag_mem_limit() must propagate this error so that > inet_frags_init_net() can do the same up to its ca

Re: [PATCH -stable 3.18, backport] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread Ani Sinha
On Mon, Nov 2, 2015 at 4:50 PM, Eric Dumazet wrote: > On Mon, 2015-11-02 at 16:40 -0800, Ani Sinha wrote: >> [ Upstream commit 44f49dd8b5a606870a1f2 ] > > Please carefully read Documentation/networking/netdev-FAQ.txt I don't see any recent releases of 3.18 version series in Greg KH's tree. Is the

Re: [PATCH v2 0/2] sh_eth: fix bugs in sh_eth_ring_init()

2015-11-02 Thread David Miller
From: Sergei Shtylyov Date: Tue, 3 Nov 2015 01:31:41 +0300 > On 11/02/2015 11:56 PM, David Miller wrote: > >>> Here's a set of 2 patches against DaveM's 'net.git' repo which fix >>> couple of >>> bugs in the sh_eth_ring_init() function. >> >> Series applied. > >As these fixed the er

[PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

2015-11-02 Thread Jarod Wilson
There are some netdev features, which when disabled on an upper device, such as a bonding master or a bridge, must be disabled and cannot be re-enabled on underlying devices. This is a rework of an earlier more heavy-handed appraoch, which simply disables and prevents re-enabling of netdev feature

Re: [GIT] Networking

2015-11-02 Thread Linus Torvalds
On Mon, Nov 2, 2015 at 5:58 PM, Andy Lutomirski wrote: > > Based in part on an old patch by Sasha, what if we relied on CSE: > > if (mul_would_overflow(size, n)) > return NULL; > do_something_with(size * n); I suspect we wouldn't even have to rely on CSE. Are these things in performance-critica

Re: [GIT] Networking

2015-11-02 Thread Andy Lutomirski
On Mon, Nov 2, 2015 at 5:54 PM, Linus Torvalds wrote: > > The biggest problem - and where the compiler could actually help us - > tends to be multiplication overflows. We have several (not *many*, but > certainly more than just a couple) cases where we simply check by > dividing MAX_INT or somethi

Re: [GIT] Networking

2015-11-02 Thread Linus Torvalds
On Mon, Nov 2, 2015 at 4:56 PM, Benjamin Herrenschmidt wrote: > > Also how much of the problem is simply that the function signature > (naming and choice of arguments) just plain sucks ? Some of that is pretty much inevitable. C really has no good way to return multiple values. The traditional (

Re: [PATCH -stable 3.18, backport] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread Ani Sinha
On Mon, Nov 2, 2015 at 4:50 PM, Eric Dumazet wrote: > On Mon, 2015-11-02 at 16:40 -0800, Ani Sinha wrote: >> [ Upstream commit 44f49dd8b5a606870a1f2 ] > > Please carefully read Documentation/networking/netdev-FAQ.txt > > A: Normally Greg Kroah-Hartman collects stable commits himself, but >for

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 17:08 -0800, Eric Dumazet wrote: > From: Eric Dumazet Erm, patch title would be : [PATCH] sit: fix sit0 percpu double allocations -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

[next PATCH 11/11] ixgbe: Clean stale VLANs when changing port vlan or resetting

2015-11-02 Thread Alexander Duyck
This patch guarantees that the VFs do not have access to VLANs that they were not supposed to. What this patch does is add code so that we delete the previous port VLAN after adding a new one, and if we reset the VF we clear all of the filters associated with it. Previously the code was leaving a

[next PATCH 10/11] ixgbe: Clear stale pool mappings

2015-11-02 Thread Alexander Duyck
From: Alexander Duyck This patch makes certain that we clear the pool mappings added when we configure default MAC addresses for the interface. Without this we run the risk of leaking an address into pool 0 which really belongs to VF 0 when SR-IOV is enabled. Signed-off-by: Alexander Duyck ---

[next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table

2015-11-02 Thread Alexander Duyck
Add a check to make certain mac_table was actually allocated and is not NULL. If it is NULL return -ENOMEM and allow the probe routine to fail rather then causing a NULL pointer dereference further down the line. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |

[next PATCH 04/11] ixgbe: Reduce VT code indent in set_vfta by introducing jump label

2015-11-02 Thread Alexander Duyck
In order to clear the way for upcoming work I thought it best to drop the level of indent in the ixgbe_set_vfta_generic function. Most of the code is held in the virtualization specific section. So the easiest approach is to just add a jump label and jump past the bulk of the code if it is not en

[next PATCH 05/11] ixgbe: Simplify configuration of setting VLVF and VLVFB

2015-11-02 Thread Alexander Duyck
This patch addresses several issues within the VLVF and VLVFB configuration First was the fact that code was overly complicated with multiple conditional paths depending on if we adding or removing and which bit we were going to add or remove. Instead of messing with all that I have simplified it

[next PATCH 02/11] ixgbe: Fix SR-IOV VLAN pool configuration

2015-11-02 Thread Alexander Duyck
The code for checking the PF bit in ixgbe_set_vf_vlan_msg was using the wrong offset and as a result it was pulling the VLAN off of the PF even if there were VFs numbered greater than 40 that still had the VLAN enabled. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbe/ixgbe_sr

[next PATCH 06/11] ixgbe: Add support for adding/removing VLAN on PF bypassing the VLVF

2015-11-02 Thread Alexander Duyck
This patch adds support for bypassing the VLVF entry creation when the PF is adding a new VLAN. The advantage to doing this is that we can then save the VLVF entries for the VFs which must have them in order to function, versus the PF which can fall back on the default pool entry. Signed-off-by:

[next PATCH 08/11] ixgbe: Add support for VLAN promiscuous with SR-IOV

2015-11-02 Thread Alexander Duyck
This patch adds support for VLAN promiscuous with SR-IOV enabled. The code prior to this patch was only adding the PF to VLANs that the VF had added. As such enabling promiscuous mode would actually not add any additional VLAN filters so visibility was limited. This lead to a number of issues as

[next PATCH 07/11] ixgbe: Reorder search to work from the top down instead of bottom up

2015-11-02 Thread Alexander Duyck
This patch is meant to reduce the complexity of the search function used for finding a VLVF entry associated with a given VLAN ID. The previous code was searching from bottom to top. I reordered it to search from top to bottom. In addition I pulled an AND statement out of the loop and instead re

[next PATCH 09/11] ixgbe: Fix VLAN promisc in relation to SR-IOV

2015-11-02 Thread Alexander Duyck
From: Alexander Duyck This patch is a follow-on for enabling VLAN promiscuous and allowing the PF to add VLANs without adding a VLVF entry. What this patch does is go through and free the VLVF registers if they are not needed as the VLAN belongs only to the PF which is the default pool. Signed-

[next PATCH 03/11] ixgbe: Simplify definitions for regidx and bit in set_vfta

2015-11-02 Thread Alexander Duyck
This patch simplifies the logic for setting the VFTA register by removing the number of conditional checks needed. Instead we just use some boolean logic to generate vfta_delta, and if that is set then we xor the vfta by that value and write it back. Signed-off-by: Alexander Duyck --- drivers/n

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
From: Eric Dumazet sit0 device allocates its percpu storage twice : - One time in ipip6_tunnel_init() - One time in ipip6_fb_tunnel_init() Thus we leak 48 bytes per possible cpu per network namespace dismantle. ipip6_fb_tunnel_init() can be much simpler and does not return an error, and should

[next PATCH 00/11] ixgbe: Add support for mixed PF/VF virtualization

2015-11-02 Thread Alexander Duyck
This patch series extends the abilities of the ixgbe driver so that we can now support VLAN trunking on top of the PF when SR-IOV is enabled. By doing this we are able to extend the existing capabilities that were enabled with the "bridge fdb add" support that was added some time ago. It had enab

Re: [GIT] Networking

2015-11-02 Thread Benjamin Herrenschmidt
On Mon, 2015-11-02 at 13:30 -0800, Andy Lutomirski wrote: > > I'll stop making inane arguments if you stop bashing arguments I > didn't make. :) I said the helpers were useful for multiplication (by > which I meant both signed and unsigned) and, to a lesser extent, for > signed addition and subtr

Re: [PATCH -stable 3.18, backport] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 16:40 -0800, Ani Sinha wrote: > [ Upstream commit 44f49dd8b5a606870a1f2 ] Please carefully read Documentation/networking/netdev-FAQ.txt A: Normally Greg Kroah-Hartman collects stable commits himself, but for networking, Dave collects up patches he deems critical for the

[PATCH -stable 3.18, backport] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread Ani Sinha
[ Upstream commit 44f49dd8b5a606870a1f2 ] Fixes the following kernel BUG : BUG: using __this_cpu_add() in preemptible [] code: bash/2758 caller is __this_cpu_preempt_check+0x13/0x15 CPU: 0 PID: 2758 Comm: bash Tainted: P O 3.18.19 #2 8170eaca 880110d1b788 fff

Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

2015-11-02 Thread Cong Wang
On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang wrote: > > Good catch! > > This is probably introduced by: > > commit baf606d9c9b12517e47e0d1370e8aa9f7323f210 > Author: Marcelo Ricardo Leitner > Date: Wed Mar 18 14:50:42 2015 -0300 > > ipv4,ipv6: grab rtnl before locking the socket > > I am think

linux-next: manual merge of the net-next tree with the net tree

2015-11-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ipmr.c between commit: 44f49dd8b5a6 ("ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.") from the net tree and commit: 758ccac8e741 ("ipv4: Only compute n

Re: Resource leak in unshare

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 11:54 -0800, Eric Dumazet wrote: > On Mon, 2015-11-02 at 13:01 -0600, Eric W. Biederman wrote: > > Dmitry Vyukov writes: > > > > > Hello, > > > > > > I am hitting the following warnings on > > > bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > > > Do you have any trace o

Re: [GIT] Networking

2015-11-02 Thread Linus Torvalds
On Mon, Nov 2, 2015 at 2:14 PM, Hannes Frederic Sowa wrote: > > overflow_usub was part of a larger header I already prepared to offer > support for *all* overflow_* checking builtins. While fixing this IPv6 > bug I thought I could hopefully introduce this interface slowly and > simply cut away the

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-11-02 Thread Stephen Hemminger
On Wed, 28 Oct 2015 08:07:47 + Matthias Tafelmeier wrote: > > > > Well, then we should wait for another voice aimed at the complexity of > > the patchset before amending and resending me the patchset. > > > > > > Well, I perceive that after Sutter has taken over the maintenance > responsib

Re: [PATCH v2 0/2] sh_eth: fix bugs in sh_eth_ring_init()

2015-11-02 Thread Sergei Shtylyov
On 11/02/2015 11:56 PM, David Miller wrote: Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of bugs in the sh_eth_ring_init() function. Series applied. As these fixed the error path, I don't expect you to push them to -stable, but your call. MBR, Sergei -

[PATCH] sh_eth: fix typo in RX descriptor bit name

2015-11-02 Thread Sergei Shtylyov
The correct name of the RX descriptor 0 bit 30 is RDLE (receive descriptor list end), not RDEL. Signed-off-by: Sergei Shtylyov --- The patch is against the Dave Miller's 'net-next.git' repo. drivers/net/ethernet/renesas/sh_eth.c |4 ++-- drivers/net/ethernet/renesas/sh_eth.h |2 +- 2

Re: [GIT] Networking

2015-11-02 Thread Hannes Frederic Sowa
Hello, On Mon, Nov 2, 2015, at 22:30, Andy Lutomirski wrote: > On Mon, Nov 2, 2015 at 1:19 PM, Linus Torvalds > wrote: > > On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds > > wrote: > >> On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote: > >>> > >>> Getting overflow checking right in more c

Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents

2015-11-02 Thread Arnd Bergmann
On Saturday 31 October 2015 02:18:19 Salil Mehta wrote: > On 10/31/2015 1:40 AM, huangdaode wrote: > > On 2015/10/30 22:20, Arnd Bergmann wrote: > >> On Tuesday 27 October 2015 19:16:34 huangdaode wrote: > >>>mdio@803c { > >>> #address-cells = <1>; > >>>

Re: [PATCH net-next] net/core: generic support for disabling netdev features down stack

2015-11-02 Thread Jarod Wilson
Alexander Duyck wrote: On 11/02/2015 09:53 AM, Jarod Wilson wrote: There are some netdev features, which when disabled on an upper device, such as a bonding master or a bridge, must be disabled and cannot be re-enabled on underlying devices. This is a rework of an earlier more heavy-handed appr

Re: [RFC] unix: fix use-after-free in unix_dgram_poll()/ 4.2.5

2015-11-02 Thread Rainer Weikusat
Olivier Mauras writes: [...] > I've encountered issues with Jason's patch ported to 3.14.x which would break > openldap, rendering it unable to answer any query - Here's a strace of the > slapd process in this state http://pastebin.ca/3226383 > Just ported Rainer's patch to 3.14 and so far I ca

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Cong Wang
On Mon, Nov 2, 2015 at 1:20 PM, Eric Dumazet wrote: > > Well, before your changes, the qdisc_tree_decrease_qlen(sch, 0) would > have been useless, since qdisc_tree_decrease_qlen() does nothing in this > case [1] > > But after your changes, we need to change the backlog, even if the qlen > does not

Re: [PATCH] bpf: fix trivial comment typo

2015-11-02 Thread Matthew Fernandez
On 03/11/15 08:31, David Miller wrote: From: Matthew Fernandez Date: Mon, 2 Nov 2015 11:59:03 +1100 bpf: fix trivial comment typo Signed-off-by: Matthew Fernandez This doesn't apply to any tree. I'm sorry, I think I must be missing something. This seems to apply cleanly to the current ti

Re: [PATCH net-next] ravb: use pdev rather than ndev for error messages

2015-11-02 Thread David Miller
From: Simon Horman Date: Mon, 2 Nov 2015 10:40:17 +0900 > This corrects what appear to be typos, making the code consistent with > itself, and allowing meaningful prefixes to be displayed with the errors in > question. > > Before: > (null): failed to initialize MDIO > (null): Cannot allocate

Re: [PATCH v2 net] ipv6: fix crash on ICMPv6 redirects with prohibited/blackholed source

2015-11-02 Thread David Miller
From: Matthias Schiffer Date: Mon, 2 Nov 2015 01:24:38 +0100 > There are other error values besides ip6_null_entry that can be returned by > ip6_route_redirect(): fib6_rule_action() can also result in > ip6_blk_hole_entry and ip6_prohibit_entry if such ip rules are installed. > > Only checking

Re: [PATCH] bpf: fix trivial comment typo

2015-11-02 Thread David Miller
From: Matthew Fernandez Date: Mon, 2 Nov 2015 11:59:03 +1100 > bpf: fix trivial comment typo > > Signed-off-by: Matthew Fernandez This doesn't apply to any tree. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majo

Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

2015-11-02 Thread Cong Wang
On Mon, Nov 2, 2015 at 7:22 AM, Sasha Levin wrote: > Hi all, > > While fuzzing with syzkaller inside a KVM tools guest running the latest > -next, I saw > the following warning: > > [ 2391.993558] == > [ 2391.995441] [ INFO: possible circular lo

Re: [BUG] Any-IP IPv6 support broken

2015-11-02 Thread Maciej Żenczykowski
> I would like to have a "bind-to-subnet" semantic with IPv6. Ah, this is something that I have reason to suspect may indeed be broken for IPv6. A coworker did some one-off testing on this a few months back, and didn't get it to trivially work. We didn't debug it, nor try to figure out what (if an

Re: [GIT] Networking

2015-11-02 Thread Andy Lutomirski
On Mon, Nov 2, 2015 at 1:19 PM, Linus Torvalds wrote: > On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds > wrote: >> On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote: >>> >>> Getting overflow checking right in more complicated cases is a PITA. >> >> No it is not. Not for unsigned values. > >

Re: [PATCH v2 net-next] net: make skb_set_owner_w() more robust

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Sun, 01 Nov 2015 15:36:55 -0800 > From: Eric Dumazet > > skb_set_owner_w() is called from various places that assume > skb->sk always point to a full blown socket (as it changes > sk->sk_wmem_alloc) > > We'd like to attach skb to request sockets, and in the future > to

Re: [PATCH net-next] bridge: vlan: Use rcu_dereference instead of rtnl_dereference

2015-11-02 Thread David Miller
From: Ido Schimmel Date: Sun, 1 Nov 2015 18:31:45 +0200 > br_should_learn() is protected by RCU and not by RTNL, so use correct > flavor of nbp_vlan_group(). > > Fixes: 907b1e6e83ed ("bridge: vlan: use proper rcu for the vlgrp > member") > Signed-off-by: Ido Schimmel > Acked-by: Nikolay Aleksan

Re: [PATCH v2 net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp_open()

2015-11-02 Thread David Miller
From: Ben Hutchings Date: Sun, 1 Nov 2015 16:21:24 + > Compile-tested only. > > Signed-off-by: Ben Hutchings Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH v2 net 2/2] ppp, slip: Validate VJ compression slot parameters completely

2015-11-02 Thread David Miller
From: Ben Hutchings Date: Sun, 1 Nov 2015 16:22:53 + > Currently slhc_init() treats out-of-range values of rslots and tslots > as equivalent to 0, except that if tslots is too large it will > dereference a null pointer (CVE-2015-7799). > > Add a range-check at the top of the function and mak

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 13:09 -0800, Cong Wang wrote: > (Sorry for the delay) > > On Fri, Oct 30, 2015 at 12:30 PM, Eric Dumazet wrote: > > On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote: > >> diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c > >> index 3abab53..498f0a2 100644 > >> --- a/n

Re: [GIT] Networking

2015-11-02 Thread Linus Torvalds
On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds wrote: > On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote: >> >> Getting overflow checking right in more complicated cases is a PITA. > > No it is not. Not for unsigned values. Just to clarify. The "oevrflow" test for unsigned subtracts of "a

Re: [PATCH net-next RFC] mpls: support for dead routes

2015-11-02 Thread roopa
On 11/1/15, 9:08 PM, Eric W. Biederman wrote: > roopa writes: > >> On 11/1/15, 1:27 PM, Eric W. Biederman wrote: >>> Roopa Prabhu writes: >>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index c70d750..7db9678 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c >>

Re: [GIT] Networking

2015-11-02 Thread Linus Torvalds
On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote: > On 10/28/2015 02:39 AM, Linus Torvalds wrote: >> >> I'm sorry, but we don't add idiotic new interfaces like this for >> idiotic new code like that. > > > As one of the people who encouraged gcc to add this interface, I'll speak up > in its

[PATCH net-next] mpls: support for dead routes

2015-11-02 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu --- RFC to v1: Addressed a few comments from Eric and Robert: - remove support for

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Cong Wang
(Sorry for the delay) On Fri, Oct 30, 2015 at 12:30 PM, Eric Dumazet wrote: > On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote: >> diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c >> index 3abab53..498f0a2 100644 >> --- a/net/sched/sch_sfq.c >> +++ b/net/sched/sch_sfq.c >> @@ -346,7 +346,

Re: [net-next v4 3/8] dpaa_eth: add support for S/G frames

2015-11-02 Thread Joe Perches
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add support for Scater/Gather (S/G) frames. The FMan can place > the frame content into multiple buffers and provide a S/G Table > (SGT) into one first buffer with references to the others. trivia: > diff --git a/drivers/net/ethernet/frees

Re: [PATCH net,stable] qmi_wwan: fix entry for HP lt4112 LTE/HSPA+ Gobi 4G Module

2015-11-02 Thread David Miller
From: Bjørn Mork Date: Sun, 1 Nov 2015 01:34:50 +0100 > The lt4112 is a HP branded Huawei me906e modem. Like other Huawei > modems, it does not have a fixed interface to function mapping. > Instead it uses a Huawei specific scheme: functions are mapped by > subclass and protocol. > > However, t

Re: [PATCH 1/1] ipmr: fix possible race resulting from improper usage of IP_INC_STATS_BH() in preemptible context.

2015-11-02 Thread David Miller
From: Ani Sinha Date: Fri, 30 Oct 2015 16:54:31 -0700 (PDT) > Fixes the following kernel BUG : ... > Signed-off-by: Ani Sinha Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH v2 0/2] sh_eth: fix bugs in sh_eth_ring_init()

2015-11-02 Thread David Miller
From: Sergei Shtylyov Date: Sat, 31 Oct 2015 02:05:19 +0300 >Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple > of > bugs in the sh_eth_ring_init() function. Series applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock

2015-11-02 Thread David Miller
From: Vivien Didelot Date: Fri, 30 Oct 2015 18:56:45 -0400 > It's easy to forget to lock the smi_mutex before calling the low-level > _mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them. > > Signed-off-by: Vivien Didelot Applied. -- To unsubscribe from this list: send the li

Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: lookup switch name

2015-11-02 Thread David Miller
From: Vivien Didelot Date: Fri, 30 Oct 2015 19:39:48 -0400 > All the mv88e6xxx drivers use the exact same code in their probe > function to lookup the switch name given its ID. Thus introduce a > mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in > the common mv88e6xxx code. >

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-11-02 Thread Ani Sinha
> On Thu, Oct 29, 2015 at 6:21 PM, Neal P. Murphy > wrote: > > On Thu, 29 Oct 2015 17:01:24 -0700 > > Ani Sinha wrote: > > > >> On Wed, Oct 28, 2015 at 11:40 PM, Neal P. Murphy > >> wrote: > >> > On Wed, 28 Oct 2015 02:36:50 -0400 > >> > "Neal P. Murphy" wrote: > >> > > >> >> On Mon, 26 Oct 201

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread David Miller
From: Yang Shi Date: Fri, 30 Oct 2015 15:16:26 -0700 > When running bpf samples on rt kernel, it reports the below warning: ... > Convert hashtab lock to raw lock to avoid such warning. > > Signed-off-by: Yang Shi Applied to net-next, thanks. -- To unsubscribe from this list: send the line "u

Re: [PATCH net-next] tcp/dccp: fix ireq->pktopts race

2015-11-02 Thread David Miller
From: Eric Dumazet Date: Fri, 30 Oct 2015 09:46:12 -0700 > From: Eric Dumazet > > IPv6 request sockets store a pointer to skb containing the SYN packet > to be able to transfer it to full blown socket when 3WHS is done > (ireq->pktopts -> np->pktoptions) > > As explained in commit 5e0724d027f0

Re: [net-next v4 6/8] dpaa_eth: add ethtool statistics

2015-11-02 Thread Joe Perches
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add a series of counters to be exported through ethtool: > - add detailed counters for reception errors; > - add detailed counters for QMan enqueue reject events; > - count the number of fragmented skbs received from the stack; > - count all

Re: [net-next PATCH v2] RDS: convert bind hash table to re-sizable hashtable

2015-11-02 Thread David Miller
From: Santosh Shilimkar Date: Fri, 30 Oct 2015 08:49:10 -0700 > To further improve the RDS connection scalabilty on massive systems > where number of sockets grows into tens of thousands of sockets, there > is a need of larger bind hashtable. Pre-allocated 8K or 16K table is > not very flexible

Re: [PATCH net-next 0/2] bridge: vlan: failure path and comment fixes

2015-11-02 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 30 Oct 2015 17:46:18 +0100 > This is a set from Ido which takes care of one failure path error in > nbp_vlan_init (patch 1) and a few comment errors (patch 2). > I must admit I didn't expect the port init continues after a vlan init > failure but should've che

Re: [PATCH v2] net: rds: changing the return type from int to void

2015-11-02 Thread David Miller
From: Saurabh Sengar Date: Fri, 30 Oct 2015 19:46:44 +0530 > as result of function rds_iw_flush_mr_pool is nowhere checked, > changing its return type from int to void. > also removing the unused variable rc as there is nothing to return > > Signed-off-by: Saurabh Sengar > --- > v2 : modify pa

Re: [GIT] Networking

2015-11-02 Thread Andy Lutomirski
On 10/28/2015 02:39 AM, Linus Torvalds wrote: I'm sorry, but we don't add idiotic new interfaces like this for idiotic new code like that. As one of the people who encouraged gcc to add this interface, I'll speak up in its favor: Getting overflow checking right in more complicated cases is

Re: pull-request: can 2015-10-30

2015-11-02 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 30 Oct 2015 14:39:58 +0100 > this is a pull request for the upcoming v4.3 release. > > Marek Vasut provides a patch to use the correct attrlen in the nla_put() in > the > can_fill_info() function. Pulled, but this missed the v4.3 release so you'll need to pus

  1   2   >