Re: [PATCH net-next] ipv6 route: use err pointers instead of returning pointer by reference

2015-10-09 Thread Scott Feldman
On Thu, Oct 8, 2015 at 10:26 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch makes ip6_route_info_create return err pointer instead of > returning the rt pointer by reference as suggested by Dave > > Signed-off-by: Roopa Prabhu > --- > Dave, sorry abt the delay on this one. net-next

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 9:38 PM, Eric Dumazet wrote: On Fri, 2015-10-09 at 20:19 -0700, Alexei Starovoitov wrote: since this bug wasn't fixed at once in all places, it means that it is hard to review _all_ needed call-sites. There are 7 places that call skb_sender_cpu_clear() in net-next. Plus 2 more in net

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 9:38 PM, Eric Dumazet wrote: On Fri, 2015-10-09 at 20:19 -0700, Alexei Starovoitov wrote: since this bug wasn't fixed at once in all places, it means that it is hard to review _all_ needed call-sites. There are 7 places that call skb_sender_cpu_clear() in net-next. Plus 2 more in net

Re: [PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device

2015-10-09 Thread Scott Feldman
On Thu, Oct 8, 2015 at 10:38 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch enables adding of fdb entries pointing to the bridge device. > This can be used to propagate mac address of vlan interfaces > configured on top of the vlan filtering bridge. > > Before: > $bridge fdb add 44:3

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Eric Dumazet
On Fri, 2015-10-09 at 20:19 -0700, Alexei Starovoitov wrote: > since this bug wasn't fixed at once in all places, it means > that it is hard to review _all_ needed call-sites. > There are 7 places that call skb_sender_cpu_clear() in net-next. > Plus 2 more in net. > How many such paths from rx to

Re: switchdev and VLAN ranges

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 4:30 PM, Vivien Didelot wrote: > Hi All, > > I understand that specifying a VLAN range on the command line is nice > for the user, and it makes no big deal for software implementation. [Adding Roopa, since she did the original vlan range support in the kernel/iproute2] > H

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot wrote: > Hi Jiri, > > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Some drivers need to implement both switchdev vlan ops and >> vid_add/kill ndos. For that to work in bridge code, we need to try >> switchdev op first

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 10:33 AM, Daniel Borkmann wrote: I was thinking may be we can use sign bit to distinguish between napi_id and sender_cpu. Like: if ((int)skb->sender_cpu >= 0) skb->sender_cpu = - (raw_smp_processor_id() + 1); and inside get_xps_queue() use it only if it's nega

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 4:54 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. > > Signed-off-by: Jiri Pirko > Signed-off-b

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 9:40 AM, Devon H. O'Dell wrote: I like the idea, but it seems unnecessarily magical. What about using a bitfield? Then there's just an option bit that is either OPTION_NAPI_ID or OPTION_SENDER_CPU. Then the check to set sender_cpu in netdev_pick_tx becomes if (skb->sender_napi_op

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

2015-10-09 Thread Scott Feldman
On Thu, Oct 8, 2015 at 9:38 PM, Premkumar Jonnala wrote: > > >> -Original Message- >> From: sfel...@gmail.com [mailto:sfel...@gmail.com] >> Sent: Friday, October 09, 2015 7:53 AM >> To: netdev@vger.kernel.org >> Cc: da...@davemloft.net; j...@resnulli.us; siva.mannem@gmail.com; >> Premk

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 7:36 AM, Jiri Pirko wrote: > Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote: >>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote: >>>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrote: Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wro

Re: [patch net-next RFC 2/3] switchdev: allow caller to explicitly use deferred attr_set version

2015-10-09 Thread Scott Feldman
On Thu, Oct 8, 2015 at 11:46 PM, Jiri Pirko wrote: > Fri, Oct 09, 2015 at 06:39:41AM CEST, sfel...@gmail.com wrote: >>On Thu, Oct 8, 2015 at 1:26 AM, Jiri Pirko wrote: >>> Thu, Oct 08, 2015 at 08:03:35AM CEST, sfel...@gmail.com wrote: On Wed, Oct 7, 2015 at 10:39 PM, Jiri Pirko wrote: >

Re: [patch net-next RFC 3/3] switchdev: introduce deferred variants of obj_add/del helpers

2015-10-09 Thread Scott Feldman
On Thu, Oct 8, 2015 at 6:25 AM, Jiri Pirko wrote: > Thu, Oct 08, 2015 at 03:21:44PM CEST, gerlitz...@gmail.com wrote: >>On Thu, Oct 8, 2015 at 4:09 PM, Jiri Pirko wrote: >>> Thu, Oct 08, 2015 at 10:28:58AM CEST, j...@resnulli.us wrote: Thu, Oct 08, 2015 at 08:45:58AM CEST, gerlitz...@gmail.co

switchdev and VLAN ranges

2015-10-09 Thread Vivien Didelot
Hi All, I understand that specifying a VLAN range on the command line is nice for the user, and it makes no big deal for software implementation. However, AFAICT a VLAN range does not make sense at all for hardware such as Ethernet switch chips. Am I wrong? I would suggest to make switchdev dire

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Vivien Didelot
Hi Jiri, On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. Just curious, when would a driver

[PATCH net-next] tun: use sk_fullsock() before reading sk->sk_tsflags

2015-10-09 Thread Eric Dumazet
From: Eric Dumazet timewait or request sockets are small and do not contain sk->sk_tsflags Without this fix, we might read garbage, and crash later in __skb_complete_tx_timestamp() -> sock_queue_err_skb() (These pseudo sockets do not have an error queue either) Fixes: ca6fb0651883 ("tcp: att

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-09 Thread Jesse Brandeburg
On Wed, 7 Oct 2015 22:13:19 +0200 Arnd Bergmann wrote: > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the > same code still exists in the i40evf driver and causes compilation > warnings in ARM and x86 allmodc

Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node

2015-10-09 Thread Jesse Gross
On Fri, Oct 9, 2015 at 8:54 AM, Jarno Rajahalme wrote: > > On Oct 8, 2015, at 4:03 PM, Jesse Gross wrote: > > On Wed, Oct 7, 2015 at 10:47 AM, Jarno Rajahalme > wrote: > > > On Oct 6, 2015, at 6:01 PM, Jesse Gross wrote: > > On Mon, Oct 5, 2015 at 1:25 PM, Alexander Duyck > wrote: > > On 10/05

Re: [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-09 Thread Jesse Gross
On Fri, Oct 9, 2015 at 2:46 AM, Jiri Benc wrote: > On Fri, 9 Oct 2015 11:24:53 +0200, Thomas Graf wrote: >> On 10/08/15 at 03:40pm, Jesse Gross wrote: >> > I have similar concerns as were expressed in the other thread. The >> > features listed here aren't OVS components and I don't think that it >

Re: simplify configfs attributes V2

2015-10-09 Thread Felipe Balbi
Christoph Hellwig writes: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and binary size of configfs consumers a lo

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-09 Thread Trond Myklebust
On Fri, Oct 9, 2015 at 5:18 PM, J. Bruce Fields wrote: > > On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: > > Neil Brown wrote: > > > Kosuke Tatsukawa writes: > > > > > >> There are several places in net/sunrpc/svcsock.c which calls > > >> waitqueue_active() without calling a m

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-10-09 Thread Felipe Balbi
Hi, Christoph Hellwig writes: > To simplify the configfs interface and remove boilerplate code that also > causes binary bloat. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Andrzej Pietrasiewicz I suppose this depends on other fs/configfs changes ? -- balbi signature.asc Descriptio

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-09 Thread J. Bruce Fields
On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: > Neil Brown wrote: > > Kosuke Tatsukawa writes: > > > >> There are several places in net/sunrpc/svcsock.c which calls > >> waitqueue_active() without calling a memory barrier. Add a memory > >> barrier just as in wq_has_sleeper()

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

2015-10-09 Thread Felipe Balbi
Pratyush Anand writes: > On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: >> Signed-off-by: Christoph Hellwig > > Acked-by: Pratyush Anand I don't seem to have the actual patch, care to resend? -- balbi signature.asc Description: PGP signature

[PATCH v2 6/7] Bluetooth: Add HCI device identifier for Qualcomm SMD

2015-10-09 Thread Bjorn Andersson
This patch assigns the next free HCI device identifier to Bluetooth devices based on the Qualcomm Shared Memory channels. Signed-off-by: Bjorn Andersson --- Changes since v1: - Split out this from the btqcomsmd patch include/net/bluetooth/hci.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 1/1] i40e: re-use %*ph specifier to hexdump a data

2015-10-09 Thread Jesse Brandeburg
On Fri, 2 Oct 2015 12:18:16 +0300 Andy Shevchenko wrote: > Instead of using a custom approach change the code to use %*ph format > specifier. > > Signed-off-by: Andy Shevchenko Nice catch, thanks! Acked-by: jesse Brandeburg -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH] sunrpc: avoid warning in gss_key_timeout

2015-10-09 Thread J. Bruce Fields
On Fri, Oct 09, 2015 at 04:13:45PM +0200, Arnd Bergmann wrote: > The gss_key_timeout() function causes a harmless warning in some > configurations, e.g. ARM imx_v6_v7_defconfig with gcc-5.2, if the > compiler cannot figure out the state of the 'expire' variable across > an rcu_read_unlock(): > > n

Re: [PATCH] brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver

2015-10-09 Thread Arend van Spriel
On 10/09/2015 02:35 AM, Kosuke Tatsukawa wrote: > brcmf_msgbuf_ioctl_resp_wake() seems to be missing a memory barrier > which might cause the waker to not notice the waiter and miss sending a > wake_up as in the following figure. My mail reader treats this as HTML format or so. Can you resend it i

e1000e: hard system lockup on Linux 4.2

2015-10-09 Thread Jason A. Donenfeld
Hi Jeffrey & Raanan & Yanirx, I have a Thinkpad W530 with a 82579LM inside of it, which uses the e1000e driver. Every few hours, my system does a hard lockup, and I am unable to do anything at all with it except power it off. There isn't a panic or oops, as nothing is written to /sys/fs/pstore aft

[PATCH net-next 2/3] ipv4: Pass struct net into ip_defrag and ip_check_defrag

2015-10-09 Thread Eric W. Biederman
The function ip_defrag is called on both the input and the output paths of the networking stack. In particular conntrack when it is tracking outbound packets from the local machine calls ip_defrag. So add a struct net parameter and stop making ip_defrag guess which network namespace it needs to d

[PATCH net-next 3/3] ipv6: Pass struct net into nf_ct_frag6_gather

2015-10-09 Thread Eric W. Biederman
The function nf_ct_frag6_gather is called on both the input and the output paths of the networking stack. In particular ipv6_defrag which calls nf_ct_frag6_gather is called from both the the PRE_ROUTING chain on input and the LOCAL_OUT chain on output. The addition of a net parameter makes it exp

[PATCH net-next 1/3] ipv4: Only compute net once in ip_call_ra_chain

2015-10-09 Thread Eric W. Biederman
ip_call_ra_chain is called early in the forwarding chain from ip_forward and ip_mr_input, which makes skb->dev the correct expression to get the input network device and dev_net(skb->dev) a correct expression for the network namespace the packet is being processed in. Compute the network namespace

[PATCH net-next 0/3] net: Pass net into defragmentation

2015-10-09 Thread Eric W. Biederman
This is the next installment of my work to pass struct net through the output path so the code does not need to guess how to figure out which network namespace it is in, and ultimately routes can have output devices in another network namespace. In netfilter and af_packet we defragment packets in

[PATCH v2] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread Arnd Bergmann
A recent change to the dst_output handling caused a new warning when the call to NF_HOOK() is the only used of a local variable passed as 'dev', and CONFIG_NETFILTER is disabled: net/ipv6/ip6_output.c: In function 'ip6_output': net/ipv6/ip6_output.c:135:21: warning: unused variable 'dev' [-Wunused

Re: [PATCH] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread Eric W. Biederman
Arnd Bergmann writes: > A recent change to the dst_output handling caused a new warning > when the call to NF_HOOK() is the only used of a local variable > passed as 'dev', and CONFIG_NETFILTER is disabled: > > net/ipv6/ip6_output.c: In function 'ip6_output': > net/ipv6/ip6_output.c:135:21: warni

Re: [PATCH] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread Eric W. Biederman
Arnd Bergmann writes: > On Friday 09 October 2015 21:03:57 kbuild test robot wrote: >> ^1da177e Linus Torvalds2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE; >> ^1da177e Linus Torvalds2005-04-16 819 if (rt->rt_flags & >> RTCF_DOREDIRECT) >> ^1da177e Linus Torvalds2005-04-16

[PATCH net-next] packet: fix match_fanout_group()

2015-10-09 Thread Eric Dumazet
From: Eric Dumazet Recent TCP listener patches exposed a prior af_packet bug : match_fanout_group() blindly assumes it is always safe to cast sk to a packet socket to compare fanout with af_packet_priv But SYNACK packets can be sent while attached to request_sock, which are smaller than a "struc

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Eric Dumazet
On Fri, 2015-10-09 at 20:02 +0200, Daniel Borkmann wrote: > Agreed, will fix that in trafgen. ;) Thanks! Nice ! Thanks Daniel ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Debabrata Banerjee
Andreas, I think we need to use the net_xmit defines so the errors are masked properly, how about: - if (unlikely(net_xmit_eval(err))) - pkt_len = 0; - return pkt_len; + if (likely(net_xmit_eval(err) == 0)) + return pkt_len; + else +

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Daniel Borkmann
On 10/09/2015 12:50 PM, Eric Dumazet wrote: On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: As promised in last patch series, we implement a better SO_REUSEPORT strategy, based on cpu affinities if selected by the application. We also

Re: [PATCH v2 net-next 1/3] bpf: enable non-root eBPF programs

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 10:45 AM, Daniel Borkmann wrote: On 10/09/2015 07:30 PM, Alexei Starovoitov wrote: ... Openstack use case is different. There it will be prog_type_sched_cls that can mangle packets, change skb metadata, etc under TC framework. These are not suitable for all users and this patch leaves

Re: [PATCH v2 net-next 1/3] bpf: enable non-root eBPF programs

2015-10-09 Thread Daniel Borkmann
On 10/09/2015 07:30 PM, Alexei Starovoitov wrote: ... Openstack use case is different. There it will be prog_type_sched_cls that can mangle packets, change skb metadata, etc under TC framework. These are not suitable for all users and this patch leaves them root-only. If you're proposing to add C

Re: [PATCH 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range

2015-10-09 Thread kbuild test robot
Hi Gerlando, [auto build test WARNING on net/master -- if it's inappropriate base, please ignore] config: powerpc-tqm8541_defconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chm

[PATCH] rtnetlink: fix gcc -Wconversion warning

2015-10-09 Thread Ronen Arad
RTA_ALIGNTO is currently define as 4. It has to be 4U to prevent warning for RTA_ALIGN and RTA_DATA expansions when -Wconversion gcc option is enabled. This follows NLMSG_ALIGNTO definition in . Signed-off-by: Ronen Arad --- include/uapi/linux/rtnetlink.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Daniel Borkmann
On 10/09/2015 04:35 AM, Alexei Starovoitov wrote: On 10/8/15 5:50 PM, Devon H. O'Dell wrote: with the amount of skb_sender_cpu_clear() all over the code base >I wonder whether there is a better solution to all of these. I think there is. We found that splitting the union of sender_cpu and napi_

Re: [PATCH v2 net-next 1/3] bpf: enable non-root eBPF programs

2015-10-09 Thread Alexei Starovoitov
On 10/9/15 4:45 AM, Hannes Frederic Sowa wrote: Afaics this problem hasn't even be solved in perf so far, tracepoints hit independent of the namespace currently. yes and that's exactly what we're trying to solve. The "demux+worker bpf programs" proposal is a work-in-progress solution to get con

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-09 Thread David Ahern
On 10/9/15 1:17 AM, Steffen Klassert wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst_lookup(struct net *net, int tos, int

Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit

2015-10-09 Thread Devon H. O'Dell
On Thu, Oct 8, 2015 at 7:35 PM, Alexei Starovoitov wrote: > On 10/8/15 5:50 PM, Devon H. O'Dell wrote: >>> >>> with the amount of skb_sender_cpu_clear() all over the code base >>> >I wonder whether there is a better solution to all of these. >> >> I think there is. We found that splitting the unio

Re: [PATCH v2] ipvs: drop first packet to dead server

2015-10-09 Thread Jiri Bohac
Hi, On Sun, Sep 27, 2015 at 08:25:18PM +0300, Julian Anastasov wrote: > On Fri, 25 Sep 2015, Jiri Bohac wrote: > > > if (!atomic_read(&cp->n_control)) > > ip_vs_conn_expire_now(cp); > > __ip_vs_conn_put(cp); > > - cp = NULL; > > + re

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-09 Thread David Ahern
On 10/9/15 1:17 AM, Steffen Klassert wrote: On Fri, Oct 09, 2015 at 03:54:22PM +0900, Hajime Tazaki wrote: Hello David, At Mon, 5 Oct 2015 08:32:51 -0600, David Ahern wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv

Re: [PATCH v4] net/bonding: send arp in interval if no active slave

2015-10-09 Thread Jay Vosburgh
Jarod Wilson wrote: >Jarod Wilson wrote: >... >> As Andy already stated I'm not a fan of such workarounds either but it's >> necessary sometimes so if this is going to be actually considered then a >> few things need to be fixed. Please make this a proper bonding option >> which can be changed at

Re: [PATCH v4] net/bonding: send arp in interval if no active slave

2015-10-09 Thread Nikolay Aleksandrov
On 10/09/2015 04:36 PM, Jarod Wilson wrote: > Jarod Wilson wrote: > ... >> As Andy already stated I'm not a fan of such workarounds either but it's >> necessary sometimes so if this is going to be actually considered then a >> few things need to be fixed. Please make this a proper bonding option >>

[PATCH 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range

2015-10-09 Thread Gerlando Falauto
When configuring the MDIO subsystem it is also necessary to configure the TBI register. Make sure the TBI is contained within the mapped register range in order to: a) make sure the address is computed correctly b) make users aware that we're actually accessing that register In case of error, prin

[PATCH 2/2] net/fsl_pq_mdio: fix computed address for the TBI register

2015-10-09 Thread Gerlando Falauto
commit afae5ad78b342f401c28b0bb1adb3cd494cb125a "net/fsl_pq_mdio: streamline probing of MDIO nodes" added support for different types of MDIO devices: 1) Gianfar MDIO nodes that only map the MII registers 2) Gianfar MDIO nodes that map the full MDIO register set 3) eTSEC2 MDIO nodes (which map t

pull-request: wireless-drivers-next 2015-10-09

2015-10-09 Thread Kalle Valo
Hi Dave, here's first wireless-drivers pull request for 4.4. New features and bugfixes but not really anything out of ordinary. Please let me know if there are any problems. Kalle The following changes since commit 4730b4331ec58a74a66a044341f0114b02b3: sch_dsmark: improve memory locality

Re: [PATCH v4 3/3] net: unix: optimize wakeups in unix_dgram_recvmsg()

2015-10-09 Thread Jason Baron
On 10/09/2015 12:29 AM, kbuild test robot wrote: > Hi Jason, > > [auto build test ERROR on v4.3-rc3 -- if it's inappropriate base, please > ignore] > > config: x86_64-randconfig-i0-201540 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Eric Dumazet
On Fri, 2015-10-09 at 07:29 -0700, Eric Dumazet wrote: > So the answer is : about 800,000 SYN per second in IPV6 with purely DDOS > attack My IPv6 routing setup was a bit silly ;) With a slightly better one, we reach 3.8 Mpps and kernel profile looks like : 21.22% [kernel] [k] ip6_pol_ro

Re: [PATCH 3.19 and earlier] fib_rules: Fix dump_rules() not to exit early

2015-10-09 Thread Thomas Jarosch
Hi Roland, On Monday, 5. October 2015 10:29:28 Roland Dreier wrote: > From: Roland Dreier > > Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across > multiple skbs") introduced a regression in "ip rule show" - it ends up > dumping the first rule over and over and never exiting, becaus

Re: [PATCH v4 1/3] net: unix: fix use-after-free in unix_dgram_poll()

2015-10-09 Thread Hannes Frederic Sowa
Hi, Jason Baron writes: > The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait > queue associated with the socket s that we are poll'ing against, but also > calls > sock_poll_wait() for a remote peer socket p, if it is connected. Thus, > if we call poll()/select()/epoll()

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-09 Thread Jiri Pirko
Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote: >Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote: >>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrote: >>> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote: On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko wro

Re: [PATCH-next v2 0/4] make non-modular code explicitly non-modular

2015-10-09 Thread David Miller
From: Paul Gortmaker Date: Wed, 7 Oct 2015 17:27:42 -0400 > [v2: drop m68k patches that Geert converted to modules; add one ARM > driver patch ; update net-next baseline to today; switch to ARM > for build testing.] > > In a previous merge window, we made changes to allow better > delineation

Re: [PATCH v4] net/bonding: send arp in interval if no active slave

2015-10-09 Thread Jarod Wilson
Jarod Wilson wrote: ... As Andy already stated I'm not a fan of such workarounds either but it's necessary sometimes so if this is going to be actually considered then a few things need to be fixed. Please make this a proper bonding option which can be changed at runtime and not only via a module

Re: [PATCH 0/9] net: small improvement

2015-10-09 Thread David Miller
From: Yaowei Bai Date: Thu, 8 Oct 2015 21:28:53 +0800 > This patchset makes several functions in net return bool to improve > readability and/or simplicity because these functions only use one > or zero as their return value. > > No functional changes. Series applied, thank you. -- To unsubscr

[PATCH] sunrpc: avoid warning in gss_key_timeout

2015-10-09 Thread Arnd Bergmann
The gss_key_timeout() function causes a harmless warning in some configurations, e.g. ARM imx_v6_v7_defconfig with gcc-5.2, if the compiler cannot figure out the state of the 'expire' variable across an rcu_read_unlock(): net/sunrpc/auth_gss/auth_gss.c: In function 'gss_key_timeout': net/sunrpc/au

Re: [PATCH net 0/5] Mellanox driver update to 4.3-rc4

2015-10-09 Thread David Miller
From: Or Gerlitz Date: Thu, 8 Oct 2015 15:26:14 +0300 > Small set of fixes for net, which includes Carol's patches, a fix > from Achiad to have the right behaviour for mlx5 Eth devices w.r.t > VLANs in promiscuous mode, a good-bye patch from Ido who left Mellanox > and the 1st patch from Jiri t

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Eric Dumazet
On Fri, 2015-10-09 at 03:50 -0700, Eric Dumazet wrote: > On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: > > On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > > > As promised in last patch series, we implement a better SO_REUSEPORT > > > strategy, based on cpu affinities if selected by t

Re: [PATCH 4/9] net/can: can_dropped_invalid_skb can be boolean

2015-10-09 Thread Yaowei Bai
On Fri, Oct 09, 2015 at 12:14:31PM +0200, Marc Kleine-Budde wrote: > On 10/08/2015 03:28 PM, Yaowei Bai wrote: > > This patch makes can_dropped_invalid_skb return bool due to this > > particular function only using either one or zero as its return > > value. > > > > No functional change. > > > >

[4.1.3-rt8] [report][cpuhotplug] BUG: spinlock bad magic on CPU#0, sh/137

2015-10-09 Thread Grygorii Strashko
Hi All, I can constantly see below error report with 4.1 RT-kernel on TI ARM dra7-evm if I'm trying to unplug cpu1: [ 57.737589] CPU1: shutdown [ 57.767537] BUG: spinlock bad magic on CPU#0, sh/137 [ 57.767546] lock: 0xee994730, .magic: , .owner: /-1, .owner_cpu: 0 [ 57.767552]

Re: [PATCH net-next 0/7] Mellanox driver update for net-next

2015-10-09 Thread David Miller
From: Or Gerlitz Date: Thu, 8 Oct 2015 17:13:56 +0300 > Some small fixes and small enhancements from the team. > > Series applies over net-next commit acb4a6b "tcp: ensure prior synack rtx > behavior > with small backlogs". Series applied, thanks. -- To unsubscribe from this list: send the li

Re: [net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-10-08

2015-10-09 Thread David Miller
From: Jeff Kirsher Date: Thu, 8 Oct 2015 18:32:38 -0700 > This series contains updates to i40e and i40evf only (again). Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread Arnd Bergmann
On Friday 09 October 2015 21:03:57 kbuild test robot wrote: > ^1da177e Linus Torvalds2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE; > ^1da177e Linus Torvalds2005-04-16 819 if (rt->rt_flags & > RTCF_DOREDIRECT) > ^1da177e Linus Torvalds2005-04-16 820 cb->rt_flags

Re: [PATCH] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread kbuild test robot
Hi Arnd, [auto build test ERROR on next-20151009 -- if it's inappropriate base, please ignore] config: i386-randconfig-i0-201540 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>):

Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Sergei Shtylyov
Hello. On 10/9/2015 12:27 PM, Andreas Schultz wrote: All users of iptunnel_xmit expect the return value to be the packet length on success (>0), negative for a tx error and zero for a tx dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the Didn't checkpatch.pl compalin about

Re: [PATCHv2 net-next] cxgb4: Enhance driver to update FW, when FW is too old

2015-10-09 Thread Neil Horman
> ret = t4_get_fw_version(adap, &adap->params.fw_vers); >+ /* Try multiple times before returning error */ >+ for (i = 0; (ret == -EBUSY || ret == -EAGAIN) && i < 3; i++) >+ ret = t4_get_fw_version(adap, &adap->params.fw_vers); >+ > if (ret) > retur

[PATCH] net: HNS: fix MDIO dependencies

2015-10-09 Thread Arnd Bergmann
The newly introduced HNS_MDIO Kconfig symbol selects 'MDIO', but that is the wrong symbol as the code used by this driver is provided by PHYLIB rather than the MDIO driver. Also, there is no need to make this driver user selectable, because it is already selected by all drivers that need it. This

[PATCH] netfilter: turn NF_HOOK into an inline function

2015-10-09 Thread Arnd Bergmann
A recent change to the dst_output handling caused a new warning when the call to NF_HOOK() is the only used of a local variable passed as 'dev', and CONFIG_NETFILTER is disabled: net/ipv6/ip6_output.c: In function 'ip6_output': net/ipv6/ip6_output.c:135:21: warning: unused variable 'dev' [-Wunused

[PATCH net] ipv4/icmp: redirect messages can use the ingress daddr as source

2015-10-09 Thread Paolo Abeni
This patch allows configuring how the source address of ICMP redirect messages is selected; by default the old behaviour is retained, while setting icmp_redirects_use_orig_daddr force the usage of the destination address of the packet that caused the redirect. The new behaviour fits closely the RF

RE: question about potential integer truncation in mwifiex_set_wapi_ie and mwifiex_set_wps_ie

2015-10-09 Thread Amitkumar Karwar
Hi James/PaX Team, > -Original Message- > From: qu...@laptop.org [mailto:qu...@laptop.org] > Sent: Wednesday, September 30, 2015 4:41 AM > To: PaX Team > Cc: Amitkumar Karwar; Avinash Patil; Kalle Valo; linux- > wirel...@vger.kernel.org; netdev@vger.kernel.org; re.em...@gmail.com; > spen..

[patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Jiri Pirko
From: Jiri Pirko Some drivers need to implement both switchdev vlan ops and vid_add/kill ndos. For that to work in bridge code, we need to try switchdev op first when adding/deleting vlan id. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- net/bridge/br_vlan.c | 58 +

Re: [PATCH v2 net-next 1/3] bpf: enable non-root eBPF programs

2015-10-09 Thread Hannes Frederic Sowa
Hi, Alexei Starovoitov writes: > On 10/8/15 11:20 AM, Hannes Frederic Sowa wrote: >> Hi Alexei, >> >> On Thu, Oct 8, 2015, at 07:23, Alexei Starovoitov wrote: >>> The feature is controlled by sysctl kernel.unprivileged_bpf_disabled. >>> This toggle defaults to off (0), but can be set true (1).

RE: [PATCH] mwifiex: fix a comment typo

2015-10-09 Thread Amitkumar Karwar
> From: Geliang Tang [mailto:geliangt...@163.com] > Sent: Sunday, October 04, 2015 2:17 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: Geliang Tang; linux-wirel...@vger.kernel.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH] mwifiex: fix a comment typo

RE: [PATCH 04/12] mwifiex: use ktime_get_real for timestamping

2015-10-09 Thread Amitkumar Karwar
Hi Arnd, > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, September 30, 2015 4:57 PM > To: netdev@vger.kernel.org > Cc: y2...@lists.linaro.org; linux-ker...@vger.kernel.org; David S. > Miller; Arnd Bergmann; Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; > linux-wirel...@vger.ker

RE: [PATCH 05/12] mwifiex: avoid gettimeofday in ba_threshold setting

2015-10-09 Thread Amitkumar Karwar
Hi Arnd, > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, September 30, 2015 4:57 PM > To: netdev@vger.kernel.org > Cc: y2...@lists.linaro.org; linux-ker...@vger.kernel.org; David S. > Miller; Arnd Bergmann; Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; > linux-wirel...@vger.ker

Re: [PATCH v3 net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Eric Dumazet
On Thu, 2015-10-08 at 21:16 -0700, Grant Zhang wrote: > > Does it make sense to make the listener hash table percpu? Socket with > SO_INCOMING_CPU set could just be add to the hashtable for that specific > cpu. Not sure : We plan to upstream a patch adding a soreuseport specific table to make

Re: [PATCH net-next 0/4] tcp: better smp listener behavior

2015-10-09 Thread Eric Dumazet
On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote: > On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > > As promised in last patch series, we implement a better SO_REUSEPORT > > strategy, based on cpu affinities if selected by the application. > > > > We also moved sk_refcnt out of the cach

[PATCH] pcnet32: fix a logic error with pci_set_dma_mask

2015-10-09 Thread Geliang Tang
pcnet32 can't work on my machine recently. It says "architecture does not support 32bit PCI busmaster DMA". There is a logic error in it: pci_set_dma_mask() return 0 means return successfully. Signed-off-by: Geliang Tang --- drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(

Re: [RHEL6.8 net PATCH] ipv4/icmp: redirect messages can use the ingress daddr as source

2015-10-09 Thread Paolo Abeni
Hi all, I'm sorry, I messed with the subject tag. I'm going to resubmit. Sorry for the noise, Paolo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9] net/can: can_dropped_invalid_skb can be boolean

2015-10-09 Thread Marc Kleine-Budde
On 10/08/2015 03:28 PM, Yaowei Bai wrote: > This patch makes can_dropped_invalid_skb return bool due to this > particular function only using either one or zero as its return > value. > > No functional change. > > Signed-off-by: Yaowei Bai Acked-by: Marc Kleine-Budde Yaowei, feel free to send

[net-next PATCH] driver: net: cpsw: add no_bd_ram dt parsing

2015-10-09 Thread Mugunthan V N
cpdma is capable of placing the dma descriptors in ddr using dma_alloc_coherent() when the internal bd ram size is not enough. To utilize this feature pass the DT parameter "no_bd_ram" and increase bd_ram_size and number of rx descriptors. Signed-off-by: Mugunthan V N --- drivers/net/ethernet/ti

Re: [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-09 Thread Jiri Benc
On Fri, 9 Oct 2015 11:24:53 +0200, Thomas Graf wrote: > On 10/08/15 at 03:40pm, Jesse Gross wrote: > > I have similar concerns as were expressed in the other thread. The > > features listed here aren't OVS components and I don't think that it > > makes sense for OVS to try to cover everything that

Re: [PATCH v3 net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-09 Thread Eric Dumazet
On Thu, 2015-10-08 at 20:40 -0700, Tom Herbert wrote: > Do we care about losing this optimization? It's not done in IPv4 but I > can imagine that there is some arguments that address comparisons in > IPv6 are more expensive hence this might make sense... I do not think we care. You removed the 'o

[PATCH net-next 1/1] sfc: fully reset if MC_REBOOT event received without warm_boot_count increment

2015-10-09 Thread Shradha Shah
From: Daniel Pieczko On EF10, MC_CMD_VPORT_RECONFIGURE can cause a CODE_MC_REBOOT event to be sent to a function without incrementing the (adapter-wide) warm_boot_count. In this case, the reboot is not detected by the loop on efx_mcdi_poll_reboot(), so prepare for recovery from an MC reboot anyw

[RHEL6.8 net PATCH] ipv4/icmp: redirect messages can use the ingress daddr as source

2015-10-09 Thread Paolo Abeni
This patch allows configuring how the source address of ICMP redirect messages is selected; by default the old behaviour is retained, while setting icmp_redirects_use_orig_daddr force the usage of the destination address of the packet that caused the redirect. The new behaviour fits closely the RF

[PATCH net-next 1/1] sfc: replace spinlocks with bit ops for busy poll locking

2015-10-09 Thread Shradha Shah
From: Bert Kenward This patch reduces the overhead of locking for busy poll. Previously the state was protected by a lock, whereas now it's manipulated solely with atomic operations. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/efx.c| 31 +--- drivers/net/ethernet/sfc/

Re: [PATCH v2 net-next 1/3] bpf: enable non-root eBPF programs

2015-10-09 Thread Thomas Graf
On 10/08/15 at 08:20pm, Hannes Frederic Sowa wrote: > Hi Alexei, > > On Thu, Oct 8, 2015, at 07:23, Alexei Starovoitov wrote: > > The feature is controlled by sysctl kernel.unprivileged_bpf_disabled. > > This toggle defaults to off (0), but can be set true (1). Once true, > > bpf programs and map

[PATCH net-next v4 2/2] tipc: remove invalid ip_rt_put

2015-10-09 Thread Andreas Schultz
udp_tunnel_xmit_skb() will free the skb and release the rt->dst reference in the error case. There is no need (and it would actully trigger a warning) when we did. This problem was not visible before, as udp_tunnel_xmit_skb() would never return a value < 0 Signed-off-by: Andreas Schultz Acked-by:

[PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Andreas Schultz
All users of iptunnel_xmit expect the return value to be the packet length on success (>0), negative for a tx error and zero for a tx dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the negative return case was lost. This bug was introduced when the ip_tunnel_core code was refactor

[PATCH net-next v4 0/2] fix tunnel statistics handling

2015-10-09 Thread Andreas Schultz
These are the two changes I send earlier, rebased to net-next to avoid a merge conflict. The statistics bug they fix has been noted before, so I can wait a bit longer in net-next. This first patch changes to the return of iptunnel_xmit to return the real err value when err < 0. Before the return v

Re: [Intel-wired-lan] [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless node

2015-10-09 Thread Jiang Liu
On 2015/10/9 17:08, Kamezawa Hiroyuki wrote: > On 2015/10/09 14:52, Jiang Liu wrote: >> On 2015/10/9 4:20, Andrew Morton wrote: >>> On Wed, 19 Aug 2015 17:18:15 -0700 (PDT) David Rientjes >>> wrote: >>> On Wed, 19 Aug 2015, Patil, Kiran wrote: > Acked-by: Kiran Patil Where

  1   2   >