On 10/9/15 9:40 AM, Devon H. O'Dell wrote:
I like the idea, but it seems unnecessarily magical. What about using a bitfield? Then there's just an option bit that is either OPTION_NAPI_ID or OPTION_SENDER_CPU. Then the check to set sender_cpu in netdev_pick_tx becomesif (skb->sender_napi_option == OPTION_NAPI_ID || skb->sender_cpu == 0) ..
It's less magical, but slower since two loads from skb and two cmp/jmp are needed instead of one. and this is critical path of xmit executed for every skb. that's why I proposed a sign. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
