On Thu, Oct 8, 2015 at 10:26 AM, Roopa Prabhu <[email protected]> wrote:
> From: Roopa Prabhu <[email protected]>
>
> This patch makes ip6_route_info_create return err pointer instead of
> returning the rt pointer by reference as suggested by Dave
>
> Signed-off-by: Roopa Prabhu <[email protected]>
> ---
> Dave, sorry abt the delay on this one. net-next was closed when i got to it
> and its been in my queue since then.
>
> net/ipv6/route.c | 30 ++++++++++++++++--------------
> 1 file changed, 16 insertions(+), 14 deletions(-)
<snip>
> int ip6_route_add(struct fib6_config *cfg)
> @@ -1980,9 +1976,12 @@ int ip6_route_add(struct fib6_config *cfg)
> struct rt6_info *rt = NULL;
nit: don't need to init rt since it's now set unconditionally.
> int err;
>
> - err = ip6_route_info_create(cfg, &rt);
> - if (err)
> + rt = ip6_route_info_create(cfg);
> + if (IS_ERR(rt)) {
> + err = PTR_ERR(rt);
> + rt = NULL;
> goto out;
> + }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
