Re: 2.6.24-rc5-mm1 -- inconsistent {in-softirq-W} -> {softirq-on-R} usage.

2007-12-14 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > > I'd say you hit a networking locking bug and then when trying to report > that bug, lockdep crashed. > > The networking bug looks to be around sock_i_ino()'s taking of > sk_callback_lock with softirq's enabled. Perhaps this will fix it. > > diff -puN

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Ray Lee
On Dec 14, 2007 6:41 PM, Gabriel C <[EMAIL PROTECTED]> wrote: > Rafael J. Wysocki wrote: > > On Friday, 14 of December 2007, Ray Lee wrote: > >> tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just > >> fine. A quick scan of the log between 2.6.24-rc3 and current tip > >> (-rc5) doesn'

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-14 Thread Herbert Xu
On Fri, Dec 14, 2007 at 09:44:18PM -0800, Andrew Morton wrote: > > That sounds like a bug in mutex_trylock() to me. I was relying on http://kerneltrap.org/mailarchive/linux-netdev/2007/9/28/325129 which seems to be a bogus claim now that I actually look at the source code. So in that ca

Re: 2.6.24-rc5-mm1 -- inconsistent {in-softirq-W} -> {softirq-on-R} usage.

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 22:58:24 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > On Dec 14, 2007 6:36 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Fri, 14 Dec 2007 17:13:21 -0500 > > "Miles Lane" <[EMAIL PROTECTED]> wrote: > > > > > > > Sorry Andrew, I don't know who to forward this problem to.

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-14 Thread Andrew Morton
On Sat, 15 Dec 2007 12:18:27 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, Dec 14, 2007 at 03:11:36PM -0800, Andrew Morton wrote: > > > > I don't believe that ASSERT_RTNL() presently warns when called from atomic > > contexts. If it does then I missed it. > > It does when mutex debugging

[PATCH 4/4] [UDP]: memory accounting in IPv4

2007-12-14 Thread Hideo AOKI
This patch adds UDP memory usage accounting in IPv4. Send buffer accounting is performed by IP layer, because skbuff is allocated in the layer. Receive buffer is charged, when the buffer successfully received. Destructor of the buffer does un charging and reclaiming, when the buffer is freed. To

[PATCH 3/4] [UDP]: add udp_mem, udp_rmem_min and udp_wmem_min

2007-12-14 Thread Hideo AOKI
This patch adds sysctl parameters for customizing UDP memory accounting: /proc/sys/net/ipv4/udp_mem /proc/sys/net/ipv4/udp_rmem_min /proc/sys/net/ipv4/udp_wmem_min Udp_mem indicates number of pages which can be used for all UDP sockets. Each UDP packet is dropped, when the number of

[PATCH 2/4] [CORE]: datagram: mem_scheudle functions

2007-12-14 Thread Hideo AOKI
This patch includes changes in network core sub system for memory accounting. Memory scheduling, charging, uncharging and reclaiming functions are added. These functions use sk_forward_alloc to store socket local accounting. They also need to use lock to keep consistency of sk_forward_alloc and me

[PATCH 1/4] [UDP]: fix send buffer check

2007-12-14 Thread Hideo AOKI
This patch introduces sndbuf size check before memory allocation for send buffer. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> --- ip_output.c |5 + 1 file changed, 5 insertions(+) diff -pruN net-2.6/net/ipv4/ip_output.c net-2.6-udp-ta

[PATCH 0/4] [UDP]: memory accounting and limitation (take 10)

2007-12-14 Thread Hideo AOKI
Hello, This is the latest patch set of UDP memory accounting and limitation. To reduce number of atomic access to global variable, the patch set supports per socket accounting using sk_forward_alloc like stream protocols. My colleagues and I tested the patch set on net-2.6 tree. Please consider

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Bill Fink
On Fri, 14 Dec 2007, Andrew Morton wrote: > On Fri, 14 Dec 2007 15:39:26 -0500 > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > [EMAIL PROTECTED] wrote: > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > > > Make E1000E default to the same kconfig setting as E1000. So people's > > > machiens do

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-14 Thread Herbert Xu
On Fri, Dec 14, 2007 at 03:11:36PM -0800, Andrew Morton wrote: > > I don't believe that ASSERT_RTNL() presently warns when called from atomic > contexts. If it does then I missed it. It does when mutex debugging is enabled. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-14 Thread Herbert Xu
On Fri, Dec 14, 2007 at 05:47:22PM -0500, Andy Gospodarek wrote: > > I'm guessing if we go back to using a write-lock for bond->lock this > will go back to working again, but I'm not totally convinced since there > are plenty of places where we used a read-lock with it. Sorry I forgot to cc you ea

[PATCH] [IPV4]: Make tcp_input_metrics() get minimum RTO via tcp_rto_min()

2007-12-14 Thread Satoru SATOH
tcp_input_metrics() refers to the built-time constant TCP_RTO_MIN regardless of configured minimum RTO with iproute2. The following fixes that. Signed-off-by: Satoru SATOH <[EMAIL PROTECTED]> net/ipv4/tcp_input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Gabriel C
Rafael J. Wysocki wrote: > On Friday, 14 of December 2007, Ray Lee wrote: >> tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just >> fine. A quick scan of the log between 2.6.24-rc3 and current tip >> (-rc5) doesn't show any obvious fixes, but then again, what do I know. >> I'll check

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Rafael J. Wysocki
On Friday, 14 of December 2007, Ray Lee wrote: > tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just > fine. A quick scan of the log between 2.6.24-rc3 and current tip > (-rc5) doesn't show any obvious fixes, but then again, what do I know. > I'll check current tip on the weekend when

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-14 Thread Jouni Malinen
On Fri, Dec 14, 2007 at 07:58:47AM -0500, Dan Williams wrote: > On Fri, 2007-12-14 at 14:03 +0900, Masakazu Mokuno wrote: > > The PS3 wireless device does the association and 4way handshake in its > > firmware/hypervisor. No interventions between them are allowed to the guest > > OSes. > That s

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Joe Perches
On Fri, 2007-12-14 at 15:35 -0800, Auke Kok wrote: > + printk(KERN_ERR "/*/\n"); > + printk(KERN_ERR "Current EEPROM: 0x%04x\nCalculated: 0x%04x\n", > +csum_old, csum_new); Multiline printks need a KERN_ after every newline. Perhaps: printk(KE

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Randy Dunlap
On Fri, 14 Dec 2007 15:35:30 -0800 Auke Kok wrote: > To help supporting users with a bad eeprom checksum, dump the > eeprom info when such a situation is encountered by a user. > > Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > --- > > drivers/net/e1000/e1000_main.c | 90 > +++

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Adrian Bunk
On Fri, Dec 14, 2007 at 06:17:55PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: >> On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: >>> [EMAIL PROTECTED] wrote: From: Randy Dunlap <[EMAIL PROTECTED]> >>> ... >>> So I think the breakage that occurs is mitigated by two factors: >>>

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Stephen Hemminger
Andrew Morton wrote: On Fri, 14 Dec 2007 15:39:26 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Make E1000E default to the same kconfig setting as E1000. So people's machiens don't stop working when they use oldconfig. S

Re: 2.6.24-rc5-mm1 -- inconsistent {in-softirq-W} -> {softirq-on-R} usage.

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 17:13:21 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > Sorry Andrew, I don't know who to forward this problem to. > > I tried running: find /proc | xargs cat > and got this: > > = > [ INFO: inconsistent lock state ] > 2.6.24-rc5-mm1 #26 > --

[PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Auke Kok
To help supporting users with a bad eeprom checksum, dump the eeprom info when such a situation is encountered by a user. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 90 +++- 1 files changed, 79 insertions(+), 11 deletion

Re: [patch 04/10] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 16:14:00 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Cc: "David S. Miller" <[EMAIL PROTECTED]> > > Cc: Emil Medve <[EMAIL PROTECTED]> > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > > Cc: Kumar Gala <[EM

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 15:39:26 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > Make E1000E default to the same kconfig setting as E1000. So people's > > machiens don't stop working when they use oldconfig. > > > > Signed-o

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Jeff Garzik
Adrian Bunk wrote: On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap <[EMAIL PROTECTED]> ... So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers that do their own configs are expected to be able to figure th

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 11:15:14 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Fri, 14 Dec 2007 16:30:37 +0800 > > > On Fri, Dec 14, 2007 at 12:22:09AM -0800, Andrew Morton wrote: > > > > > > I don't see how it could warn about that. Nor should it

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-14 Thread Divy Le Ray
Divy Le Ray wrote: Jeff Garzik wrote: Divy Le Ray wrote: > Jeff Garzik wrote: >> Divy Le Ray wrote: >>> From: Divy Le Ray <[EMAIL PROTECTED]> >>> >>> Add parity initialization for T3C adapters. >>> >>> Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> >>> --- >>> >>> drivers/net/cxgb3/adapter.h

[PATCH] [ROSE] ax25_send_frame() called with a constant paclen = 260

2007-12-14 Thread Bernard Pidoux
Hi, In rose_link.c ax25_send_frame() was called with a constant paclen parameter of 260 bytes. This value looked odd to me for it did not correspond to any defined or possible computed length.Replacing this value by 0 (zero) allowed ax25_send_frame() to substitute it by the default AX25 frame

[PATCH] [ROSE] reverts commits d85838c55d836c33077344fab424f200f2827d84

2007-12-14 Thread Bernard Pidoux
Hi, This patch against 2.6.24-rc5 reverts commit d85838c55d836c33077344fab424f200f2827d84, that was supposed to detect all connected ROSE node neighbors. Actually the loop was misplaced and the node list was not completely explored.Next sublitted patch gives a solution. signed off by Bernard P

[PATCH] [ROSE] ROSE_PACLEN definition used a number constant value

2007-12-14 Thread Bernard Pidoux
Hi, ROSE_PACLEN was defined by a substraction using a fixed constant value of 256 in af_rose.c #define ROSE_PACLEN (256-ROSE_MIN_LEN) For more convenience 256 is replaced by AX25_DEF_PACLEN default size declared in ax25.h which is the actual AX25 MTU. signed off by Bernard Pidoux, [EMAIL

[PATCH] [ROSE] static const struct proto_ops in af_rose.c

2007-12-14 Thread Bernard Pidoux
This patch corrects the declaration of struct proto_ops as static const like in struct socket signed off by Bernard Pidoux, [EMAIL PROTECTED] --- linux-2.6.24-rc5/net/rose/af_rose.c 2007-12-11 04:48:43.0 +0100 +++ b/net/rose/af_rose.c2007-12-14 14:32:06.0 +0100 @@ -63,7

[PATCH] [ROSE] finding a connected ROSE neighbor node

2007-12-14 Thread Bernard Pidoux
Hi, This patch introduces a test to determine if a neighbor node with a given ROSE address is already connected and if so returns its address. The previous test was only performed on timer t0 and not on parameter restarted that is true when a node is connected. Also, previously the test was no

[PATCH] [AX25] circular locking with AX25 connection timeout

2007-12-14 Thread Bernard Pidoux
Hi, This patch cancels a circular locking conflict that appeared with a timeout of an AX25 connection. signed off by Jarek Poplawski --- linux-2.6.24-rc5/net/ax25/ax25_subr.c 2007-12-11 04:48:43.0 +0100 +++ b/net/ax25/ax25_subr.c 2007-12-14 14:30:02.0 +0100 @@ -279,

Re: Packet per Second

2007-12-14 Thread Glen Turner
On Fri, 2007-12-14 at 15:34 +, Flávio Pires wrote: > Well, I work on an ISP and we have a linux box acting as a > bridge+firewall. With this bridge+firewall we control the packet rate > per second from each client and from our repeaters. But I can`t > measure the packet rate per IP. Is there

Re: [PATCH 03/29] mm: slb: add knowledge of reserve pages

2007-12-14 Thread Daniel Phillips
On Friday 14 December 2007 07:39, Peter Zijlstra wrote: > Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to > allocation contexts that are entitled to it. This is done to ensure > reserve pages don't leak out and get consumed. Tighter definitions of "leak out" and "get consumed" would b

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-14 Thread Andy Gospodarek
On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote: > > > On Fri, 14 Dec 2007, Andy Gospodarek wrote: > > >On Fri, Dec 14, 2007 at 05:14:57PM +0100, Krzysztof Oledzki wrote: > >> > >> > >>On Wed, 12 Dec 2007, Jay Vosburgh wrote: > >> > >>>Herbert Xu <[EMAIL PROTECTED]> wrote: > >>

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Adrian Bunk
On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: >> From: Randy Dunlap <[EMAIL PROTECTED]> >... > So I think the breakage that occurs is mitigated by two factors: > 1) kernel hackers that do their own configs are expected to be able to > figure this stuff. >

[PATCH 04/11] drivers/net/mac89x0.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/mac89x0.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mac89x0.c b/drivers/net/mac89x0.c index a19b595..45b56ca 100644 --- a/drivers/net/mac89x0.c +++ b/drivers/net/mac89x0.c @@ -584,11 +5

[PATCH 11/11] drivers/net/usb/catc.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/usb/catc.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 76752d8..e20db50 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -757

[PATCH 02/11] drivers/net/hplance.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/hplance.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/hplance.c b/drivers/net/hplance.c index be6e5bc..2748b47 100644 --- a/drivers/net/hplance.c +++ b/drivers/net/hplance.c @@ -77,7

[PATCH 10/11] drivers/net/tulip/de4x5.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/tulip/de4x5.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c index 41f34bb..288f994 100644 --- a/drivers/net/tulip/de4x5.c +++ b/drivers/net/tulip/d

[PATCH 09/11] drivers/net/tg3.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/tg3.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4942f7d..eea7da9 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -12351,9 +12351,10 @@ st

[PATCH 08/11] drivers/net/sunvnet.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/sunvnet.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/sunvnet.c b/drivers/net/sunvnet.c index ff1028a..4a0035f 100644 --- a/drivers/net/sunvnet.c +++ b/drivers/net/sunvnet.c @@ -1149,6

[PATCH 05/11] drivers/net/niu.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/niu.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/niu.c b/drivers/net/niu.c index abfc61c..8a0f8f8 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -7392,12 +7392,10 @@ static v

[PATCH 06/11] drivers/net/pcnet32.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/pcnet32.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index ff92aca..87edeb6 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -1769,8 +1769

[PATCH 07/11] drivers/net/smc911x.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 76cc1d3..f503b73 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -2086,10 +

[PATCH 03/11] drivers/net/mac8390.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/mac8390.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c index 9e70074..4eccebb 100644 --- a/drivers/net/mac8390.c +++ b/drivers/net/mac8390.c @

[PATCH 01/11] drivers/net/ax88796.c: Use print_mac

2007-12-14 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/ax88796.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c index 7495a9e..107c11f 100644 --- a/drivers/net/ax88796.c +++ b/drivers/net/ax88796.c @@ -750,

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-14 Thread Andy Gospodarek
On Fri, Dec 14, 2007 at 11:11:15PM +0100, Krzysztof Oledzki wrote: > > > On Fri, 14 Dec 2007, Andy Gospodarek wrote: > > >On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote: > >> > >> > >>On Fri, 14 Dec 2007, Andy Gospodarek wrote: > >> > >>>On Fri, Dec 14, 2007 at 05:14:57PM +010

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-14 Thread Krzysztof Oledzki
On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote: On Fri, 14 Dec 2007, Andy Gospodarek wrote: On Fri, Dec 14, 2007 at 05:14:57PM +0100, Krzysztof Oledzki wrote: On Wed, 12 Dec 2007, Jay Vosburgh wrote: Herbert Xu <[EMAIL PR

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-14 Thread Andy Gospodarek
On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote: > > > On Fri, 14 Dec 2007, Andy Gospodarek wrote: > > >On Fri, Dec 14, 2007 at 05:14:57PM +0100, Krzysztof Oledzki wrote: > >> > >> > >>On Wed, 12 Dec 2007, Jay Vosburgh wrote: > >> > >>>Herbert Xu <[EMAIL PROTECTED]> wrote: > >>

Re: [PATCH 04/29] mm: kmem_estimate_pages()

2007-12-14 Thread Daniel Phillips
On Friday 14 December 2007 07:39, Peter Zijlstra wrote: > Provide a method to get the upper bound on the pages needed to > allocate a given number of objects from a given kmem_cache. > > This lays the foundation for a generic reserve framework as presented > in a later patch in this series. This fr

Re: [NETFILTER] xt_hashlimit : speedups hash_dst()

2007-12-14 Thread Jarek Poplawski
Jarek Poplawski wrote, On 12/14/2007 09:59 PM: > Eric Dumazet wrote, On 12/14/2007 12:09 PM: > ... > >> +/* >> + * Instead of returning hash % ht->cfg.size (implying a divide) >> + * we return the high 32 bits of the (hash * ht->cfg.size) that will >> + * give results between [0 a

Re: [NETFILTER] xt_hashlimit : speedups hash_dst()

2007-12-14 Thread Eric Dumazet
Jarek Poplawski a écrit : Eric Dumazet wrote, On 12/14/2007 12:09 PM: ... + /* +* Instead of returning hash % ht->cfg.size (implying a divide) +* we return the high 32 bits of the (hash * ht->cfg.size) that will +* give results between [0 and cfg.size-1] and same h

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-14 Thread David Miller
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 22:28:07 +0100 > Wang Chen <[EMAIL PROTECTED]> writes: > > > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > > > Since the caller and the upper caller doesn't hod the rtnl semaphore. > > We should use

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-14 Thread Krzysztof Halasa
Wang Chen <[EMAIL PROTECTED]> writes: > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Since the caller and the upper caller doesn't hod the rtnl semaphore. > We should use unregister_netdev instead of unregister_netdevice. NAK, not-a-bug. The caller actually holds

Re: [PATCHES 0/3]: DCCP patches for 2.6.25

2007-12-14 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 14, 2007 at 11:29:14AM -0800, David Miller escreveu: > From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 23:41:59 -0200 > > > Please consider pulling from: > > > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 > > Pulled, but could you plea

Re: [PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster

2007-12-14 Thread Jeff Garzik
Wang Chen wrote: [PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the loop will be faster for this approach. Signed-off-by: Wa

Re: [patch 08/10] net: smc911x: shut up compiler warnings

2007-12-14 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Paul Mundt <[EMAIL PROTECTED]> Trivial fix to shut up gcc. Signed-off-by: Paul Mundt <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/smc911x.h |2 +- 1 file changed, 1 insertion(+), 1 d

Re: [patch 06/10] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

2007-12-14 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jiri Slaby <[EMAIL PROTECTED]> SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/debug.c |

Re: [patch 04/10] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-12-14 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Emil Medve <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Kumar Gala <[EMAIL PROTECTED]> Cc: Li Yang <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-b

Re: [PATCH 1/2] ixgb: make sure jumbos stay enabled after reset

2007-12-14 Thread Jeff Garzik
Auke Kok wrote: From: Matheos Worku <[EMAIL PROTECTED]> Currently a device reset (ethtool -r ethX) would cause the adapter to fall back to regular MTU sizes. Signed-off-by: Matheos Worku <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROT

Re: [PATCH 16/29] netvm: INET reserves.

2007-12-14 Thread Daniel Phillips
Hi Peter, sysctl_intvec_fragment, proc_dointvec_fragment, sysctl_intvec_fragment seem to suffer from cut-n-pastitis. Regards, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [PATCH 00/29] Swap over NFS -v15

2007-12-14 Thread Daniel Phillips
Hi Peter, A major feature of this patch set is the network receive deadlock avoidance, but there is quite a bit of stuff bundled with it, the NFS user accounting for a big part of the patch by itself. Is it possible to provide a before and after demonstration case for just the network receive

[PATCH] Re: [patch 03/10] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-12-14 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Michael Pyne <[EMAIL PROTECTED]> Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of th

Re: [NETFILTER] xt_hashlimit : speedups hash_dst()

2007-12-14 Thread Jarek Poplawski
Eric Dumazet wrote, On 12/14/2007 12:09 PM: ... > + /* > + * Instead of returning hash % ht->cfg.size (implying a divide) > + * we return the high 32 bits of the (hash * ht->cfg.size) that will > + * give results between [0 and cfg.size-1] and same hash distribution, > + *

Re: kernel 2.6.23.8: KERNEL: assertion in net/ipv4/tcp_input.c

2007-12-14 Thread Ilpo Järvinen
On Thu, 13 Dec 2007, Wolfgang Walter wrote: > it happened again with your patch applied: > > WARNING: at net/ipv4/tcp_input.c:1018 tcp_sacktag_write_queue() > > Call Trace: > [] tcp_sacktag_write_queue+0x7d0/0xa60 > [] add_partial+0x19/0x60 > [] tcp_ack+0x5a4/0x1d70 > [] tcp_rcv_established+0x

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Make E1000E default to the same kconfig setting as E1000. So people's machiens don't stop working when they use oldconfig. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PR

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-14 Thread Ayaz Abdulla
Ed, You mention that the phy will become 100Mbit half duplex, but during nv_close, the phy setting is not modified. This might be a separate issue. Ayaz -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13, 2007 5:07 PM To: Ed Swierk Cc: Ayaz Abdu

Re: [2.6 patch] drivers/net/s2io.c section fixes

2007-12-14 Thread Jeff Garzik
Adrian Bunk wrote: Code used by the non-__devinit s2io_open() mustn't be __devinit. This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.text+0x6f6e3e): Section mismatch: reference to .init.text.20:s2io_test_intr (between 's2io_open' an

Re: [PATCH] e100: free IRQ to remove warningwhenrebooting

2007-12-14 Thread Jeff Garzik
Auke Kok wrote: Adapted from Ian Wienand <[EMAIL PROTECTED]> Explicitly free the IRQ before removing the device to remove a warning "Destroying IRQ without calling free_irq" Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Ian Wienand <[EMAIL PROTECTED]> --- drivers/net/e100.c |5 - 1

Re: [2.6 patch] drivers/net/sis190.c section fix

2007-12-14 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') ... <-- snip --> Signed-off-by:

Re: [PATCH] sky2: RX lockup fix

2007-12-14 Thread Jeff Garzik
Stephen Hemminger wrote: I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX lockups while validating the sky2 driver. The receive MAC FIFO would become stuck during testing with high traffic. One port of the 88E8062 would lockup, while the other port remained functional. Re-in

Re: [PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-14 Thread Jeff Garzik
Scott Wood wrote: Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Jeff, can you ack this to go through Paul's tree (assuming nothing wrong with it)? drivers/net/gianfar.c | 137 - drivers/net/gianfar.h | 13 +++- drivers/net/gianfar_e

[PATCH net-2.6.25] Revert recent TCP work

2007-12-14 Thread Ilpo Järvinen
On Fri, 14 Dec 2007, Ilpo Järvinen wrote: > So, I might soon prepare a revert patch for most of the questionable > TCP parts and ask Dave to apply it (and drop them fully during next > rebase) unless I suddently figure something out soon which explains > all/most of the problems, then return to

[PATCH 1/2] ixgb: make sure jumbos stay enabled after reset

2007-12-14 Thread Auke Kok
From: Matheos Worku <[EMAIL PROTECTED]> Currently a device reset (ethtool -r ethX) would cause the adapter to fall back to regular MTU sizes. Signed-off-by: Matheos Worku <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- driv

[PATCH 2/2] ixgb: enable sun hardware support for broadcom phy

2007-12-14 Thread Auke Kok
From: Matheos Worku <[EMAIL PROTECTED]> Implement support for a SUN-specific PHY. SUN provides a modified 82597-based board with their own PHY that works with very little modification to the code. This patch implements this new PHY which is identified by the subvendor device ID. The device ID of

Re: [PATCH][XFRM] Fix potential race vs xfrm_state(only)_find and xfrm_hash_resize.

2007-12-14 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 13:56:14 +0300 > The _find calls calculate the hash value using the > xfrm_state_hmask, without the xfrm_state_lock. But the > value of this mask can change in the _resize call under > the state_lock, so we risk to fail in finding

Re: [patch 4/4] PPP synchronous tty: convert dead_sem to completion

2007-12-14 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 16:02:37 -0800 > From: Matthias Kaehlcke <[EMAIL PROTECTED]> > > PPP synchronous tty channel driver: convert the semaphore dead_sem to a > completion > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> > Cc: Paul Mackerras <[EMAIL PROTECTED]> >

Re: [patch 3/4] tipc: fix semaphore handling

2007-12-14 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 16:02:36 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > As noted by Kevin, tipc's release() does down_interruptible() and ignores the > return value. So if signal_pending() we'll end up doing up() on a non-downed > semaphore. Fix. > > Cc: Kev

Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-14 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 16:02:36 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > ASSERT_RTNL() uses mutex_trylock(), but it's better to use mutex_is_locked(). > > Make that change, and remove rtnl_trylock() altogether. > > (not tested yet!) > > Cc: "David S. Miller"

Re: [patch 1/4] Updates to nfsroot documentation

2007-12-14 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 16:02:33 -0800 > From: Amos Waterland <[EMAIL PROTECTED]> > > The difference between ip=off and ip=::off has been a cause of much > confusion. Document how each behaves, and do not contradict ourselves by > saying that "off" is the default when

Re: [PATCHES 0/3]: DCCP patches for 2.6.25

2007-12-14 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 23:41:59 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Pulled, but could you please reformat Gerrit's changelog entries in the future? They have these 80+ long

Re: 2.6.24-rc5-mm1

2007-12-14 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 10:08:07 +0800 > [UDP]: Move udp_stats_in6 into net/ipv4/udp.c > > Now that external users may increment the counters directly, we need to > ensure that udp_stats_in6 is always available. Otherwise we'd either > have to requrie the exte

[PATCH 13/29] net: packet split receive api

2007-12-14 Thread Peter Zijlstra
Add some packet-split receive hooks. For one this allows to do NUMA node affine page allocs. Later on these hooks will be extended to do emergency reserve allocations for fragments. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |8 ++-- drivers/net/

[PATCH 12/29] net: wrap sk->sk_backlog_rcv()

2007-12-14 Thread Peter Zijlstra
Wrap calling sk->sk_backlog_rcv() in a function. This will allow extending the generic sk_backlog_rcv behaviour. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/net/sock.h |5 + net/core/sock.c |4 ++-- net/ipv4/tcp.c |2 +- net/ipv4/tcp_timer.c |2 +

[PATCH 06/29] mm: serialize access to min_free_kbytes

2007-12-14 Thread Peter Zijlstra
There is a small race between the procfs caller and the memory hotplug caller of setup_per_zone_pages_min(). Not a big deal, but the next patch will add yet another caller. Time to close the gap. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/page_alloc.c | 16 +--- 1 file

[PATCH 02/29] mm: tag reseve pages

2007-12-14 Thread Peter Zijlstra
Tag pages allocated from the reserves with a non-zero page->reserve. This allows us to distinguish and account reserve pages. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/mm_types.h |1 + mm/page_alloc.c |4 +++- 2 files changed, 4 insertions(+), 1 deletion

[PATCH 09/29] mm: __GFP_MEMALLOC

2007-12-14 Thread Peter Zijlstra
__GFP_MEMALLOC will allow the allocation to disregard the watermarks, much like PF_MEMALLOC. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/gfp.h |3 ++- mm/page_alloc.c |4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) Index: linux-2.6/include/linux/gfp

[PATCH 14/29] net: sk_allocation() - concentrate socket related allocations

2007-12-14 Thread Peter Zijlstra
Introduce sk_allocation(), this function allows to inject sock specific flags to each sock related allocation. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/net/sock.h|5 + net/ipv4/tcp.c|2 +- net/ipv4/tcp_output.c | 11 ++- net/ipv6/tcp_ipv6.c

[PATCH 04/29] mm: kmem_estimate_pages()

2007-12-14 Thread Peter Zijlstra
Provide a method to get the upper bound on the pages needed to allocate a given number of objects from a given kmem_cache. This lays the foundation for a generic reserve framework as presented in a later patch in this series. This framework needs to convert object demand (kmalloc() bytes, kmem_cac

[PATCH 05/29] mm: allow PF_MEMALLOC from softirq context

2007-12-14 Thread Peter Zijlstra
Allow PF_MEMALLOC to be set in softirq context. When running softirqs from a borrowed context save current->flags, ksoftirqd will have its own task_struct. This is needed to allow network softirq packet processing to make use of PF_MEMALLOC. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> ---

[PATCH 11/29] selinux: tag avc cache alloc as non-critical

2007-12-14 Thread Peter Zijlstra
Failing to allocate a cache entry will only harm performance not correctness. Do not consume valuable reserve pages for something like that. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> --- security/selinux/avc.c |2 +- 1 file changed, 1 inserti

[PATCH 17/29] netvm: hook skb allocation to reserves

2007-12-14 Thread Peter Zijlstra
Change the skb allocation api to indicate RX usage and use this to fall back to the reserve when needed. SKBs allocated from the reserve are tagged in skb->emergency. Teach all other skb ops about emergency skbs and the reserve accounting. Use the (new) packet split API to allocate and track frag

[PATCH 19/29] netvm: prevent a TCP specific deadlock

2007-12-14 Thread Peter Zijlstra
It could happen that all !SOCK_MEMALLOC sockets have buffered so much data that we're over the global rmem limit. This will prevent SOCK_MEMALLOC buffers from receiving data, which will prevent userspace from running, which is needed to reduce the buffered data. Fix this by exempting the SOCK_MEMA

[PATCH 16/29] netvm: INET reserves.

2007-12-14 Thread Peter Zijlstra
Add reserves for INET. The two big users seem to be the route cache and ip-fragment cache. Reserve the route cache under generic RX reserve, its usage is bounded by the high reclaim watermark, and thus does not need further accounting. Reserve the ip-fragement caches under SKB data reserve, thes

[PATCH 27/29] nfs: disable data cache revalidation for swapfiles

2007-12-14 Thread Peter Zijlstra
Do as Trond suggested: http://lkml.org/lkml/2006/8/25/348 Disable NFS data cache revalidation on swap files since it doesn't really make sense to have other clients change the file while you are using it. Thereby we can stop setting PG_private on swap pages, since there ought to be no further

[PATCH 03/29] mm: slb: add knowledge of reserve pages

2007-12-14 Thread Peter Zijlstra
Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to allocation contexts that are entitled to it. This is done to ensure reserve pages don't leak out and get consumed. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/slub_def.h |1 mm/slab.c| 59 +

[PATCH 08/29] mm: system wide ALLOC_NO_WATERMARK

2007-12-14 Thread Peter Zijlstra
Change ALLOC_NO_WATERMARK page allocation such that the reserves are system wide - which they are per setup_per_zone_pages_min(), when we scrape the barrel, do it properly. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/page_alloc.c |6 ++ 1 file changed, 6 insertions(+) Index:

  1   2   >