[PATCH] virtio_net: remove double ether_setup

2007-12-11 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Rusty Russell: > Can you send straight to akpm or davem? I'm supposed to be on vacation at this is a small fix for virtio_net. virtnet_probe already calls alloc_etherdev, which calls ether_setup. There is no need to do that again. Signed-off-by: Christian

Re: Labeled IPsec with NAT

2007-12-11 Thread sreeniva
Hi Joy, >>I am working on setting up Labeled IPsec along with iptables nat >>rules. Once I insert nat related rules, the ipsec connection breaks >>and the system tries to re-negotiate and creates multiple SAs. I am >>using 2.6.19 kernel (with Venkat's MLSXFRM patches & bugfixes). I >>guess those w

Re: [RFC] net: napi fix

2007-12-11 Thread Joonwoo Park
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>: > Isn't this a better fix for all drivers, rather than peppering every > driver with the special case. This is how the logic worked up until > 2.6.24. > > > --- a/net/core/dev.c2007-12-11 12:16:20.0 -0800 > +++ b/net/core/dev.c2007-

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Stephen Hemminger
On Wed, 12 Dec 2007 14:48:27 +0900 "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > 2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>: > > On Wed, 12 Dec 2007 13:01:27 +0900 > > "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > > > > > [NETDEV]: tehuti Fix possible causing oops of net_rx_action > > > > > > S

[RFC] net: napi fix

2007-12-11 Thread Stephen Hemminger
Isn't this a better fix for all drivers, rather than peppering every driver with the special case. This is how the logic worked up until 2.6.24. --- a/net/core/dev.c2007-12-11 12:16:20.0 -0800 +++ b/net/core/dev.c2007-12-11 21:43:39.0 -0800 @@ -2184,7 +2184,7 @@ static voi

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>: > On Wed, 12 Dec 2007 13:01:27 +0900 > "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > > > [NETDEV]: tehuti Fix possible causing oops of net_rx_action > > > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> > > --- > > drivers/net/tehuti.c |2 ++ >

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Stephen Hemminger
On Wed, 12 Dec 2007 13:01:27 +0900 "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > [NETDEV]: tehuti Fix possible causing oops of net_rx_action > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> > --- > drivers/net/tehuti.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --gi

Re: [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set

2007-12-11 Thread Stephen Hemminger
On Wed, 12 Dec 2007 09:51:05 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Tue, Dec 11, 2007 at 02:52:43PM -0800, Stephen Hemminger wrote: > > > > The tap devices have to have addresses don't they. So bringing up an empty > > bridge is meaningless. If you just add the device first then it will

Re: Labeled IPsec with NAT

2007-12-11 Thread Joy Latten
>I am working on setting up Labeled IPsec along with iptables nat >rules. Once I insert nat related rules, the ipsec connection breaks >and the system tries to re-negotiate and creates multiple SAs. I am >using 2.6.19 kernel (with Venkat's MLSXFRM patches & bugfixes). I >guess those were i

Labeled IPsec with NAT

2007-12-11 Thread Yogesh Raju Sreenivasan
I am working on setting up Labeled IPsec along with iptables nat rules. Once I insert nat related rules, the ipsec connection breaks and the system tries to re-negotiate and creates multiple SAs. I am using 2.6.19 kernel (with Venkat's MLSXFRM patches & bugfixes). I guess those were incor

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Rik van Riel
On Tue, 4 Dec 2007 21:17:01 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > Changes since 2.6.24-rc3-mm2: 2.6.24-rc4-mm1 brought a nice TCP oops on my x86_64 system, while I was stress-testing the VM and watching via ssh: general protection fault: [1] SMP last sysfs file: /sys/devices/pci

[PATCH 2/7] [NETDEV]: e1000e Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e1000e Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 4fd2e23..8e4861a 10

[PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e1000 Fix possible causing oops of net_rx_action returning work_done == weight as true after calling netif_rx_complete will cause oops in net_rx_action. Thanks Joonwoo Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 ++ 1 files changed, 2 inse

[PATCH 4/7] [NETDEV]: ixgbe Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: ixgbe Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 00bc525..

[PATCH 3/7] [NETDEV]: ixgb Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: ixgb Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 3021234..afe95d1 1

[PATCH 5/7] [NETDEV]: e100 Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e100 Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e100.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index e1c8a0d..7cb4ed0 100644 --- a/drivers/net/e100.c

[PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: myri10ge Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c index 8def8

[PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: tehuti Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/tehuti.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index 21230c9..955e749 100644 --- a/drivers/ne

[PATCH] [IPSEC]: Add populate from packet (PFP) support

2007-12-11 Thread Tyler Hicks
RFC 4301 requires us to associate each SPD entry with a set of flags to determine how to assign the selector values when creating a new SAD entry. Each selector in the new xfrm_state can either be assigned using the corresponding selector in the xfrm_policy or with the corresponding value in the f

[PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-11 Thread Wang Chen
[PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice Since the caller and the upper caller doesn't hod the rtnl semaphore. We should use unregister_netdev instead of unregister_netdevice. Signed-off-by: Wang Chen <[EMAIL PROTECTED]> --- hdlc_fr.c |6 +++--- 1 files chan

[PATCH 2/3] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-11 Thread Herbert Xu
[IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch adds the functions xfrm_decode_session_reverse and xfrmX_policy_check_reverse so we can get the rev

[PATCH 3/3] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread Herbert Xu
[IPSEC]: Add ICMP host relookup support RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch implements this for ICMP traffic that originates from or terminates on localhost. This is activated on outbound with the new policy

[PATCH 1/3] [IPSEC]: Make xfrm_lookup flags argument a bit-field

2007-12-11 Thread Herbert Xu
[IPSEC]: Make xfrm_lookup flags argument a bit-field This patch introduces an enum for bits in the flags argument of xfrm_lookup. This is so that we can cram more information into it later. Since all current users use just the values 0 and 1, XFRM_LOOKUP_WAIT has been added with the value 1 << 0

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-11 Thread Rusty Russell
On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote: > That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in > virtio_ring.c - maybe we can use that. Its hidden in callback and > restart handling, what about adding an explicit startup? Yes, I debated whether to make th

Re: [IPSEC] RFC 4301 PFP Support

2007-12-11 Thread Herbert Xu
On Tue, Dec 11, 2007 at 01:34:45PM -0800, Tyler Hicks wrote: > > Should we just use the larval selectors or should we assume that > openswan will begin to send valid selectors? I asked for the openswan > dev's opinions and they referred me to Herbert Xu. It seems as though > the correct solution

Re: [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set

2007-12-11 Thread Herbert Xu
On Tue, Dec 11, 2007 at 02:52:43PM -0800, Stephen Hemminger wrote: > > The tap devices have to have addresses don't they. So bringing up an empty > bridge is meaningless. If you just add the device first then it will work. Actually bringing up a bridge with no constituents is useful for a bridge t

Re: [PATCH resend] virtio_net: remove double ether_setup

2007-12-11 Thread Rusty Russell
On Tuesday 11 December 2007 22:38:53 Christian Borntraeger wrote: > Hello Rusty, > > this is a small fix for virtio_net. > virtnet_probe already calls alloc_etherdev, which calls ether_setup. > There is no need to do that again. > > Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> Acked-by

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-11 Thread Rusty Russell
On Tuesday 11 December 2007 05:50:08 Sam Ravnborg wrote: > On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > This way gcc can warn for wrong format strings > > This loks good. Can I get i s-o-b then I will apply it. Even better, switch the code to the standard warn/warnx/err/errx. C

Re: [PATCH 2/2] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread Herbert Xu
On Tue, Dec 11, 2007 at 09:10:56AM -0800, David Miller wrote: > > This enumeration doesn't exist in my tree, what are you generating > these patches against? Sorry, I forgot to include the first patch because I made it before the xfrm_lookup bug fix. Here's the complete set against net-2.6.25.

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-11 Thread Stephen Hemminger
On Sun, 09 Dec 2007 18:10:22 +0100 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > > On lör, 2007-12-08 at 00:41 +0100, Andreas Henriksson wrote: > > On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote: > > > On Tue, 4 Dec 2007 14:58:18 +0100 > > > Andreas Henriksson <[EMAIL PROTECTED]> wr

Re: [patch 1/1] Convert the semaphore to a mutex in net/tipc/socket.c

2007-12-11 Thread Andrew Morton
On Sun, 09 Dec 2007 21:17:42 -0400 Kevin Winchester <[EMAIL PROTECTED]> wrote: > Note also that in the release method, down_interruptible() was being called > without checking the return value. I converted it to > mutex_lock_interruptible() > and made the interrupted case return -ERESTARTSYS, as

RE: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Brandeburg, Jesse
Joonwoo Park wrote: > 2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>: >> >> all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, >> after calling netif_rx_complete. netif_rx_complete plus work_done >> != 0 causes a bug. >> > > Brandeburg, > Don't we need to return non-zero wor

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-11 Thread Lachlan Andrew
Greetings all, On 11/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > > we should > get it right as it might have network driver interface implications. If you're redoing the driver interface, could I put in a request for packet time-stamping at a lower level? This thread started because TCP p

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>: > > all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, after > calling netif_rx_complete. netif_rx_complete plus work_done != 0 causes > a bug. > Brandeburg, Don't we need to return non-zero work_done after netif_rx_complete if wo

Re: [2.6 patch] drivers/net/ipg.c: add __devexit annotation

2007-12-11 Thread Francois Romieu
Adrian Bunk <[EMAIL PROTECTED]> : > ipg_remove() can become __devexit. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> I'll add it to the pending ipg queue. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More major

Re: [PATCH] bridge: assign random address

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 15:48:35 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Assigning a valid random address to bridge device solves problems > when bridge device is brought up before adding real device to bridge. > When the first real device is added to the bridge, it's address > will overi

[PATCH] bridge: assign random address

2007-12-11 Thread Stephen Hemminger
Assigning a valid random address to bridge device solves problems when bridge device is brought up before adding real device to bridge. When the first real device is added to the bridge, it's address will overide the bridges random address. Note: any device added to a bridge must already have a va

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Stephen Hemminger
Perhaps we should change the warning to identify the guilty device. --- a/net/core/dev.c2007-11-19 09:09:57.0 -0800 +++ b/net/core/dev.c2007-12-07 15:54:03.0 -0800 @@ -2196,7 +2196,13 @@ static void net_rx_action(struct softirq if (test_bit(NAPI_STATE_SCHED

delay via-rhine irq initialisation.

2007-12-11 Thread Dave Jones
With CONFIG_DEBUG_SHIRQ set, via-rhine complains during init. (See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=377721 for a report). Does this diff look right? (I don't have a via-rhine handy to test with) We may be able to get away with moving the request_irq to just after the alloc_tbu

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-11 Thread Dor Laor
Christian Borntraeger wrote: Am Dienstag, 11. Dezember 2007 schrieb Christian Borntraeger: The way other physical NICs doing it is by dis/en/abling interrupt using registers (look at e1000). I suggest we can export add_status and use the original code but before enabling napi add a call to a

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>: > Joonwoo Park wrote: > > /* If no Tx and not enough Rx work done, exit the polling mode */ > > if ((!tx_cleaned && (work_done == 0)) || > >!netif_running(poll_dev)) { > > quit_polling: > > if (likely(adapter->itr_setting &

RE: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Brandeburg, Jesse
Joonwoo Park wrote: > /* If no Tx and not enough Rx work done, exit the polling mode */ > if ((!tx_cleaned && (work_done == 0)) || >!netif_running(poll_dev)) { > quit_polling: > if (likely(adapter->itr_setting & 3)) > e1000_set_itr(adapter); > netif_rx_co

RE: [2.6 patch] drivers/net/s2io.c section fixes

2007-12-11 Thread Ramkrishna Vepa
Thanks. Patch looks good. Please accept. Ram > -Original Message- > From: Adrian Bunk [mailto:[EMAIL PROTECTED] > Sent: Tuesday, December 11, 2007 2:23 PM > To: [EMAIL PROTECTED]; Rastapur Santosh; Sivakumar Subramani; > Sreenivasa Honnur; [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org; [

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Randy Dunlap
On Tue, 11 Dec 2007 14:17:16 -0800 Kok, Auke wrote: > Andrew Morton wrote: > > On Tue, 11 Dec 2007 13:26:58 -0800 > > "Kok, Auke" <[EMAIL PROTECTED]> wrote: > > > >> Andrew Morton wrote: > >>> On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> > >>> wrote: > >>> > > - Lots

sk_prot->sendmsg(...) giving me a kernel oops on kernels past 2.6.20

2007-12-11 Thread Kevin Wilson
I've searched everywhere (including this list) for a report but couldn't find anything that can tell me what implementation step(s) I am missing. Essentially all the kernels past 2.6.20 gives me a kernel oops on the sendmsg code. I know the sk_buff changes worked things over quite a bit but I have

Re: [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 14:52:43 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Tue, 11 Dec 2007 13:26:14 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > (please respond via emailed reply-to-all, not via the bugzilla web > > interface). > > > > On Tue, 11 Dec 2007 11:04:55 -0800

Re: [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set

2007-12-11 Thread Stephen Hemminger
On Tue, 11 Dec 2007 13:26:14 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > (please respond via emailed reply-to-all, not via the bugzilla web > interface). > > On Tue, 11 Dec 2007 11:04:55 -0800 (PST) > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=9545 > > > >

Re: [PATCH 0/3] cxgb - driver fixes.

2007-12-11 Thread Greg KH
On Sat, Dec 01, 2007 at 03:26:15PM -0800, Divy Le Ray wrote: > Ben Greear wrote: >> Divy Le Ray wrote: >>> Jeff, >>> >>> I'm submitting a patch series for inclusion in 2.6.24 for the cxgb >>> driver. >>> The patches are built against Linus'git tree. >>> >>> Here is a brief description: >>> - Ensur

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-11 Thread Junio C Hamano
Divy Le Ray <[EMAIL PROTECTED]> writes: > On this topic, I have a question: how do I get to see all the > netdev-2.6 branches ? > After cloning a free netdev-2.6 tree, 'git branch' shows only the > master branch: > ... > Cloning > "git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Kok, Auke
Andrew Morton wrote: > On Tue, 11 Dec 2007 13:26:58 -0800 > "Kok, Auke" <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >>> On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote: >>> > - Lots of device IDs have been removed from the e1000 driver and moved > over

[2.6 patch] drivers/net/sis190.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL P

[2.6 patch] drivers/net/s2io.c section fixes

2007-12-11 Thread Adrian Bunk
Code used by the non-__devinit s2io_open() mustn't be __devinit. This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.text+0x6f6e3e): Section mismatch: reference to .init.text.20:s2io_test_intr (between 's2io_open' and 's2io_ethtool_sset'

[2.6 patch] drivers/net/ipg.c: add __devexit annotation

2007-12-11 Thread Adrian Bunk
ipg_remove() can become __devexit. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 97ace7a0e52ceac30caae20e1a3fe72c4644bce7 diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..285ebbc 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c @@ -2214,7 +2214,7 @@ static struct etht

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 13:26:58 -0800 "Kok, Auke" <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote: > > > >>> > >>> - Lots of device IDs have been removed from the e1000 driver and moved > >>> over > >>> to e1000e. So

Re: [Bug 9542] BUG: bad unlock balance detected!

2007-12-11 Thread Andrew Morton
(switching to email - please respond via emailed reply-to-all, not via the bugzilla web interface) On Tue, 11 Dec 2007 07:03:13 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9542 > > > > > > --- Comment #2 from [EMAIL PROTECTED] 2007-12-11 07:03

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Kok, Auke
Kok, Auke wrote: > Andrew Morton wrote: >> On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote: >> - Lots of device IDs have been removed from the e1000 driver and moved over to e1000e. So if your e1000 stops working, you forgot to set CONFIG_E1000E. >>

Re: net-2.6.25 being rebased...

2007-12-11 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : [...] > [remote "origin"] > url = git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git ^^^ "net-2.6.25", sorry. While reading the answers, I have the strange feeling

Re: net-2.6.25 being rebased...

2007-12-11 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : [...] > I have an earlier unmodified git repository of net-2.6.25. > Does anyone know the appropriate git commands to resync > to the rebased content? > > $ git branch > * master > $ git-pull > [...] > Automatic merge failed; fix conflicts and then commit the resu

[IPSEC] RFC 4301 PFP Support

2007-12-11 Thread Tyler Hicks
I'm working on adding populate from packet (PFP) support to the kernel, as specified in RFC 4301. While testing with openswan (2.4.9), I noticed that the state selector values in the SAD were empty. It seems that when openswan sends a ALLOCSPI message, the kernel finds the larval xfrm_state with

Re: net-2.6.25 being rebased...

2007-12-11 Thread Kok, Auke
David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 13:04:59 -0800 > >> On Tue, 2007-12-11 at 11:56 -0800, David Miller wrote: >>> The rebase of net-2.6.25 is complete >> I have an earlier unmodified git repository of net-2.6.25. >> Does anyone know the appropriate

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Kok, Auke
Andrew Morton wrote: > On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote: > >>> >>> - Lots of device IDs have been removed from the e1000 driver and moved >>> over >>> to e1000e. So if your e1000 stops working, you forgot to set >>> CONFIG_E1000E. >>> >>> >> Wouldn't it

Re: [Bugme-new] [Bug 9545] New: Cannot bring up a bridge interface without a MAC address set

2007-12-11 Thread Andrew Morton
(please respond via emailed reply-to-all, not via the bugzilla web interface). On Tue, 11 Dec 2007 11:04:55 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9545 > >Summary: Cannot bring up a bridge interface without a MAC address >

Re: net-2.6.25 being rebased...

2007-12-11 Thread Joe Perches
On Tue, 2007-12-11 at 19:09 -0200, Arnaldo Carvalho de Melo wrote: > git-clone --reference linux-2.6 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25 That works well. Just ~3MB in objects downloaded. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > I can't see this compile failure posted anywhere: > > http://test.kernel.org/results/IBM/126049/build/debug/stderr > > > > arch/x86/vdso/vdso32/sigreturn.S: Assembler messages: > > arch/x86/vdso/vdso32/sigreturn.S:23: Error: suffix or operands inval

Re: net-2.6.25 being rebased...

2007-12-11 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 13:04:59 -0800 > On Tue, 2007-12-11 at 11:56 -0800, David Miller wrote: > > The rebase of net-2.6.25 is complete > > I have an earlier unmodified git repository of net-2.6.25. > Does anyone know the appropriate git commands to resync >

Re: net-2.6.25 being rebased...

2007-12-11 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 11, 2007 at 01:04:59PM -0800, Joe Perches escreveu: > On Tue, 2007-12-11 at 11:56 -0800, David Miller wrote: > > The rebase of net-2.6.25 is complete > > I have an earlier unmodified git repository of net-2.6.25. > Does anyone know the appropriate git commands to resync > to the rebase

Re: net-2.6.25 being rebased...

2007-12-11 Thread Joe Perches
On Tue, 2007-12-11 at 11:56 -0800, David Miller wrote: > The rebase of net-2.6.25 is complete I have an earlier unmodified git repository of net-2.6.25. Does anyone know the appropriate git commands to resync to the rebased content? $ git branch * master $ git-pull [...] Automatic merge failed; f

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote: > > > > > > - Lots of device IDs have been removed from the e1000 driver and moved > > over > > to e1000e. So if your e1000 stops working, you forgot to set > > CONFIG_E1000E. > > > > > Wouldn't it make sense to just de

Re: DM9000_IRQ_FLAGS

2007-12-11 Thread Remy Bohmer
Hello Daniel, This controller is also used on many other boards, like the e.g. Atmel AT91sam9261-ek board. On that board on both the rising _and_ falling edge an interrupt is generated. I can test tomorrow if this patch leaves this board in tact, but should the board-specific code not add this fl

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 16:04:27 +0100 (CET) Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: > >> [<783bfa72>] rt_run_flush+0x43/0x8b > >> [<783bfa93>] rt_run_flush+0x64/0x8b > >> [<7813ac54>] notifier_call_chain+0x2a/0x52 > >> [<7813ac9e>] raw_notifier_call_chain+0x17/0x1a > >> [<783a3471>] netdev

Re: net-2.6.25 being rebased...

2007-12-11 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 09:26:38 -0800 (PST) > I want to work out all the conflicts now that Linus has pulled > in my most recent batch of fixes. > > I hope to have it done in the next hour or so. The rebase of net-2.6.25 is complete, sorry for taking so lon

[PATCH] enable SMC911X for ARCH_MX3

2007-12-11 Thread Daniel Mack
Hi, this patch enables SMX911X support for Freescale's MX3 platforms. Signed-off-by: Daniel Mack <[EMAIL PROTECTED]> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6cde4ed..1011735 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -926,7 +926,7 @@ config SMC911X tris

DM9000_IRQ_FLAGS

2007-12-11 Thread Daniel Mack
Hi, on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. If I understood the code behind request_irq() correctly, it's not recommended to register an IRQ without any of the IRQT_* flags set. Is there any concerns a

Problem with cxgb, mac-vlans, and UDP checksum offloading.

2007-12-11 Thread Ben Greear
Hello! This is with kernel 2.6.23, plus our hacks, but the mac-vlan logic is part of the official kernel now. OS is Fedora 8. I have applied patch 1 and 3 of those sent a few weeks ago for the cxgb as well. While testing NFS on mac-vlans on cxgb, we noticed that UDP packets have incorrect chec

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 19:00:08 +0100), Aurélien Charbon <[EMAIL PROTECTED]> says: > --- linux-2.6.24-rc4/include/net/ipv6.h 2007-12-10 16:11:38.0 > +0100 > +++ linux-2.6.24-rc4-IPv6-cache-based/include/net/ipv6.h 2007-12-11 > 17:52:39.0 +

[PATCH net-2.6.25 7/7] Switch users of ipv4_devconf(_all) to use the pernet one

2007-12-11 Thread Pavel Emelyanov
These are scattered over the code, but almost all the "critical" places already have the proper struct net at hand except for snmp proc showing function and routing rtnl handler. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/linux/inetdevice.h b/include/linux/inet

[PATCH net-2.6.25 6/7] Switch users of ipv4_devconf_dflt to use the pernet one

2007-12-11 Thread Pavel Emelyanov
They are all collected in the net/ipv4/devinet.c file and mostly use the IPV4_DEVCONF_DFLT macro. So I add the net parameter to it and patch users accordingly. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 996f07e..cd957f4 1006

[PATCH net-2.6.25 5/7] Move the devinet pointers on the struct net

2007-12-11 Thread Pavel Emelyanov
This is the core. Add all and default pointers on the netns_ipv4 and register a new pernet subsys to initialize them. Also add the ctl_table_header to register the net.ipv4.ip_forward ctl. I don't allocate additional memory for init_net, but use global devinets. Signed-off-by: Pavel Emelyanov

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Aurélien Charbon
Brian Haley wrote: In an email back on October 29th I sent-out a similar patch with a new ipv6_addr_set_v4mapped() inline - it might be useful to pull that piece into your patch since it cleans it up a bit to get rid of the ipv6_addr_set() calls. I can re-send you that patch off-line if you

[PATCH net-2.6.25 4/7] Store the net pointer on devinet's ctl tables

2007-12-11 Thread Pavel Emelyanov
Some handers and strategies of devinet sysctl tables need to know the net to propagate the ctl change to all the net devices. I use the (currently unused) extra2 pointer on the tables to get it. Holding the reference on the struct net is not possible, because otherwise we'll get a net->ctl_table-

[PATCH net-2.6.25 3/7] Pass the net pointer to the arp_req_set_proxy()

2007-12-11 Thread Pavel Emelyanov
This one will need to set the IPV4_DEVCONF_ALL(PROXY_ARP), but there's no ways to get the net right in place, so we have to pull one from the inet_ioctl's struct sock. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/arp.h b/include/net/arp.h index f026645..36482bf

[PATCH net-2.6.25 2/7] Make __devinet_sysctl_register return an error

2007-12-11 Thread Pavel Emelyanov
Currently, this function is void, so failures in creating sysctls for new/renamed devices are not reported to anywhere. Fixing this is another complex (needed?) task, but this return value is needed during the namespaces creation to handle the case, when we failed to create "all" and "default" ent

[PATCH net-2.6.25 1/7] Add the netns_ipv4 struct

2007-12-11 Thread Pavel Emelyanov
The ipv4 will store its parameters inside this structure. This one is empty now, but it will be eventually filled. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 18da0af..d04ddf2 100644 --- a/include/net/net_nam

[PATCH net-2.6.25 0/7] Make ipv4_devconf (all and default) live in net namespaces

2007-12-11 Thread Pavel Emelyanov
The ipv4_devconf_(all) and ipv4_devconf_dflt are currently global, but should be per-namespace. This set moves them on the struct net. Or, more precisely, on the struct netns_ipv4, which in turn is on the struct net. There are two minor things that are to be done additionally to this set: 1. Th

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:21:26 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 12:15:00 -0500 > > > I still would like to see the rest of the changes make it into > > 2.6.25 (the SPI byte order thing is particularly troublesome) so if > > you don't mind

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:19:57 pm YOSHIFUJI Hideaki / 吉藤英明 wrote: > Please do not mangle tabs into spaces. Yes indeed. Not quite sure what happened there but I just fixed it. Thanks for pointing that out. -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "

net-2.6.25 being rebased...

2007-12-11 Thread David Miller
I want to work out all the conflicts now that Linus has pulled in my most recent batch of fixes. I hope to have it done in the next hour or so. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

Re: [PATCH 1/2] add driver for enc28j60 ethernet chip

2007-12-11 Thread Stephen Hemminger
On Tue, 11 Dec 2007 15:57:10 +0100 Claudio Lanconelli <[EMAIL PROTECTED]> wrote: > These patches add support for Microchip enc28j60 ethernet chip > controlled via SPI. > I tested it on my custom board (S162) with ARM9 s3c2442 SoC. > Any comments are welcome. > > Signed-off-by: Claudio Lanconelli

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-11 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 11, 2007 at 09:42:38AM +, Gerrit Renker escreveu: > | When interfacing we must make sure that ccid3 tfrc_lh_slab is created > | and then tfrc_li_cachep is not needed. I'm doing this while keeping > | the structure of the patches, i.e. one introducing, the other removing. > | But we

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 12:15:00 -0500 > I still would like to see the rest of the changes make it into > 2.6.25 (the SPI byte order thing is particularly troublesome) so if > you don't mind a "v3" I'll respin this patch right now to remove the > "sid -> secid"

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 11:30:19 -0500), Paul Moore <[EMAIL PROTECTED]> says: > diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c > index 5b860b6..e2a3dd1 100644 > --- a/net/xfrm/xfrm_state.c > +++ b/net/xfrm/xfrm_state.c : > @@ -1994,67 +1995,59 @@ void __ini

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:06:11 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 11:30:19 -0500 > > Sorry for not pointing this out sooner: No problem, better late than never ... despite reports to the contrary, breaking userspace doesn't excite me as mu

Re: [PATCH 2/2] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 00:55:02 +0800 > diff --git a/include/net/dst.h b/include/net/dst.h > index aaa2dbb..31468c9 100644 > --- a/include/net/dst.h > +++ b/include/net/dst.h > @@ -268,6 +268,7 @@ extern void dst_init(void); > /* Flags for xfrm_l

Re: [PATCH 1/2] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-11 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 00:55:01 +0800 > [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse > > RFC 4301 requires us to relookup ICMP traffic that does not match any > policies using the reverse of its payload. This patch adds the functi

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 11:30:19 -0500 Sorry for not pointing this out sooner: > * Convert 'sid' to 'secid' >The 'sid' name is specific to SELinux, 'secid' is the common naming >convention used by the kernel when refering to tokenized LSM labels ... >

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Joakim Tjernlund
On Tue, 2007-12-11 at 19:51 +0800, Li Yang wrote: > > -Original Message- > > From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, December 11, 2007 6:58 PM > > To: Li Yang > > Cc: netdev@vger.kernel.org > > Subject: RE: [PATCH] Increase virtual FIFOs in ucc_geth. > > > >

[PATCH 1/2] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-11 Thread Herbert Xu
[IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch adds the functions xfrm_decode_session_reverse and xfrmX_policy_check_reverse so we can get the rev

[PATCH 2/2] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread Herbert Xu
[IPSEC]: Add ICMP host relookup support RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch implements this for ICMP traffic that originates from or terminates on localhost. This is activated on outbound with the new policy

[0/2] [IPSEC]: Add host ICMP relookup support

2007-12-11 Thread Herbert Xu
Hi Dave: These two patches implement the ICMP relookup feature for hosts that's required by RFC 4301. I've made it conditional on policy and state flags so it should have no impact on existing users. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROT

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Brian Haley
Hi Aurelien, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) In an email back on October 29th I sent-out

  1   2   >