(please respond via emailed reply-to-all, not via the bugzilla web interface).
On Tue, 11 Dec 2007 11:04:55 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9545 > > Summary: Cannot bring up a bridge interface without a MAC address > set > Product: Networking > Version: 2.5 > KernelVersion: 2.6.24-0.81.rc4.git7.fc9 > Platform: All > OS/Version: Linux > Tree: Fedora > Status: NEW > Severity: normal > Priority: P1 > Component: Other > AssignedTo: [EMAIL PROTECTED] > ReportedBy: [EMAIL PROTECTED] > > > Most recent kernel where this bug did not occur: Any 2.6.23 or earlier > Distribution: Fedora 9 rawhide > Hardware Environment: Intel(R) Core(TM)2 Duo CPU E6850, x86_64 > Software Environment: 2.6.24-0.81.rc4.git7.fc9 #1 SMP x86_64 GNU/Linux > Problem Description: > It is not possible to bring up a bridge interface unless one first assigns a > MAC address to it. This is a regression from earlier kernels where one could > always bring up a bridge device immediately after creating it. The bridge > should not require a MAC address because it is not going to be configured with > any IP addr - in my scenario I merely wish to use it to connect a number of > 'tap' devices associated with KVM guests. > > Steps to reproduce: > # brctl addbr demobr > # ifconfig demobr up > SIOCSIFFLAGS: Invalid argument > > It is failing on the ioctl to bring up the interface > > ioctl(4, SIOCGIFFLAGS, {ifr_name="demobr", > ifr_flags=IFF_BROADCAST|IFF_MULTICAST}) = 0 > ioctl(4, SIOCSIFFLAGS, 0x7fff38a6f180) = -1 EINVAL (Invalid argument) > > > The following Fedora kernel BZ has the original problem report: > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=390991 > > The problem appears to have been introduced by this patch: > > Commit bada339ba24dee9e143bfb42e1dc61f146619846 > Author: Jeff Garzik <[EMAIL PROTECTED]> > Date: Tue Oct 23 20:19:37 2007 -0700 > > [NET]: Validate device addr prior to interface-up > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > diff --git a/net/core/dev.c b/net/core/dev.c > index 8726589..f861555 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1007,17 +1007,20 @@ int dev_open(struct net_device *dev) > * Call device private open method > */ > set_bit(__LINK_STATE_START, &dev->state); > - if (dev->open) { > + > + if (dev->validate_addr) > + ret = dev->validate_addr(dev); > > > > Which rejects MAC addresses with all 0s > > Herbert Xu tells me... > > "This is clearly a bug in the upstream bridge device. It should override the > default address validator so that when there are no devices attached that a > zero MAC address is allowed." > Rafael, another for the regression list please. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
