Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Michael Ellerman
On Fri, 2007-10-19 at 17:53 -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 19 Oct 2007 19:46:10 -0500 > > > FWIW, it looks like not all that many arches do this; the output > > for grep -r address_hi * is pretty thin. Then, looking at > > i386/kernel/io_apic.c a

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Roland Dreier
> You are starting off on the wrong foot. ??? > > +if(!(expr)) { > > \ > > + printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \ > > + #expr, __FILE__, __FU

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Stephen Hemminger
On Fri, 19 Oct 2007 22:22:44 -0700 Roland Dreier <[EMAIL PROTECTED]> wrote: > > You are starting off on the wrong foot. > > ??? That was a introductory comment because even in reviewing the first file (which had almost no code), I saw so many style issues. > > > +if(!(expr)) {

Re: [PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread Stephen Hemminger
On Fri, 19 Oct 2007 15:04:08 -0500 [EMAIL PROTECTED] wrote: > Main include file for device structures and defines. > > Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> You are starting off on the wrong foot. > +#ifdef CONFIG_INFINIBAND_NES_DEBUG > +#define assert(expr)

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-19 Thread Valdis . Kletnieks
On Sat, 20 Oct 2007 06:40:02 +0300, Al Boldi said: > Sure, the idea was to mark the filter table obsolete as to make people start > using the mangle table to do their filtering for new setups. The filter > table would then still be available for legacy/special setups. But this > would only be

FYI - linux-net.osdl.org

2007-10-19 Thread Stephen Hemminger
The existing wiki has been migrated into the Linux Foundation wiki system. This is to reduce the administrative overhead and management effort. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-19 Thread Al Boldi
Bill Davidsen wrote: > Bill Davidsen wrote: > If not, then shouldn't the filter table be obsoleted to avoid > confusion? > >>> > >>> That would probably confuse people. Just don't use it if you don't > >>> need to. > > > > That is a most practical suggestion. > > > >> The problem is that

Re: [PATCH 1/14 v2] nes: module and device initialization

2007-10-19 Thread Roland Dreier
Thanks... I am kind of overloaded trying to handle the last few things for the 2.6.24 merge window, but I will look at this next week, and I expect we should be able to merge the driver for 2.6.25 unless there are unexpected hangups. - To unsubscribe from this list: send the line "unsubscribe netde

[git patches] net driver fixes

2007-10-19 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig | 41 - drivers/net/dm9000.c|6 ++-- dri

Re: [PATCH] zd1211rw: fix a double include

2007-10-19 Thread Jeff Garzik
John W. Linville wrote: From: Holger Schurig <[EMAIL PROTECTED]> This patch removes all double includes of the same file. This makes scripts/checkincludes.pl happy. Signed-off-by: Holger Schurig <[EMAIL PROTECTED]> Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- Jeff, I missed the zd121

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-10-19 Thread Jeff Garzik
pulled - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix build break in tsi108.c

2007-10-19 Thread Jeff Garzik
Olof Johansson wrote: Fix build break: drivers/net/tsi108_eth.c: In function 'tsi108_init_one': drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev' drivers/net/tsi108_eth.c:1633: warning: too few arguments for format make[2]: *** [drivers/net/tsi108_eth.o] Error 1 Signed-off-by: Ol

Re: [patch 1/1] qeth: remove header_ops bug

2007-10-19 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-19 Thread Jeff Garzik
Randy Dunlap wrote: [EMAIL PROTECTED] wrote:] From: Randy Dunlap <[EMAIL PROTECTED]> Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems. ERROR: "lro_f

Re: [PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-19 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Missing MODULE_LICENSE(), loading this module taints the kernel. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/net/phy/mdio-bitbang.c |2 ++ 1 file changed, 2 insertions(+) applied this and the NAPI_Howto Kconfig pa

Re: linux kernel networking code review request

2007-10-19 Thread Dmitry Torokhov
On Friday 19 October 2007, Templin, Fred L wrote: > Hello, > > I would like to get a review on some new Linux > kernel networking code. The code is based on the > 2.6.23 source tree and touches three files - two > in ./net/ipv6 and one in ./include/net. What is > the proper procedure for requestin

[PATCH] Fix build break in tsi108.c

2007-10-19 Thread Olof Johansson
Fix build break: drivers/net/tsi108_eth.c: In function 'tsi108_init_one': drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev' drivers/net/tsi108_eth.c:1633: warning: too few arguments for format make[2]: *** [drivers/net/tsi108_eth.o] Error 1 Signed-off-by: Olof Johansson <[EMAIL PRO

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Benjamin Herrenschmidt
> I'm cc'ing the powerpc mailing list to point this out: > it looks like only cell/axon_msi.c and mpic_u3msi.c > bother do do anything. I guess that there aren't any old > macintosh laptops that have msi on them? Because without > this, suspend and resume breaks. The only macs that can do any

Re: atm: panic when loading clip 2nd time

2007-10-19 Thread Randy Dunlap
On Tue, 16 Oct 2007 14:33:38 -0700 Nish Aravamudan wrote: > On 10/16/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > 2.6.23-git7, using SLAB (not SLUB) [config attached]: > > > > # modprobe clip > > # rmmod clip > > # modprobe clip > > > > results in panic: > > > > kmem_cache_create: duplicate cac

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Fri, 19 Oct 2007 19:46:10 -0500 > FWIW, it looks like not all that many arches do this; the output > for grep -r address_hi * is pretty thin. Then, looking at > i386/kernel/io_apic.c as an example, one can see that the > msi state save happens "by acc

[BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
Hi, On Fri, Oct 19, 2007 at 05:27:06PM -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 19 Oct 2007 19:04:21 -0500 > > > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see > > that happening. viz. read_msi_msg() is not called anywhere, and I need >

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Fri, 19 Oct 2007 19:04:21 -0500 > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see > that happening. viz. read_msi_msg() is not called anywhere, and I need > to have valid msg->address_lo and msg->address_hi and msg->data > in order t

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 06:12:03PM -0700, Michael Chan wrote: > On Fri, 2007-10-19 at 19:04 -0500, [EMAIL PROTECTED] wrote: > > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see > > that happening. viz. read_msi_msg() is not called anywhere, and I need > > to have valid msg->addres

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Michael Chan
On Fri, 2007-10-19 at 19:04 -0500, [EMAIL PROTECTED] wrote: > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see > that happening. viz. read_msi_msg() is not called anywhere, and I need > to have valid msg->address_lo and msg->address_hi and msg->data > in order to be able to restor

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 05:36:17PM -0700, Michael Chan wrote: > On Fri, 2007-10-19 at 18:29 -0500, [EMAIL PROTECTED] wrote: > > On Fri, Oct 19, 2007 at 02:36:56PM -0700, Matt Carlson wrote: > > > This patch exports the pci_restore_msi_state() function. This function > > > is needed to restore the

linux kernel networking code review request

2007-10-19 Thread Templin, Fred L
Hello, I would like to get a review on some new Linux kernel networking code. The code is based on the 2.6.23 source tree and touches three files - two in ./net/ipv6 and one in ./include/net. What is the proper procedure for requesting a review? Thanks - Fred [EMAIL PROTECTED] - To unsubscribe fr

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-19 Thread David Miller
From: "Medve Emilian-EMMEDVE1" <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 06:39:12 -0700 > For the current situation, 32-bit QE, 32-bit PowerPC, do you find > the patch acceptable? No piece of code in the kernel should live in a vacuum. In order to improve overall code quality, every piece of dr

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Michael Chan
On Fri, 2007-10-19 at 18:29 -0500, [EMAIL PROTECTED] wrote: > On Fri, Oct 19, 2007 at 02:36:56PM -0700, Matt Carlson wrote: > > This patch exports the pci_restore_msi_state() function. This function > > is needed to restore the MSI state during PCI error recovery. > > > > Signed-off-by: Linas Vep

Re: [PATCH] netdev: Interfamily support for IPSEC BEET

2007-10-19 Thread David Miller
Please fix up these whitespace errors in your patch, thank you: + git apply --check --whitespace=error-all diff Space in indent is followed by a tab. diff:329: if (x->sel.family == AF_INET) { Space in indent is followed by a tab. diff:330: x->props.header_len +

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 02:36:56PM -0700, Matt Carlson wrote: > This patch exports the pci_restore_msi_state() function. This function > is needed to restore the MSI state during PCI error recovery. > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > Signed-off-by: Matt Carlson <[EMAIL PROTECT

[patch 1/1] qeth: remove header_ops bug

2007-10-19 Thread Ursula Braun
From: Ursula Braun <[EMAIL PROTECTED]> Remove qeth bug caused by commit: [NET]: Move hardware header operations out of netdevice. Signed-off-by: Ursula Braun <[EMAIL PROTECTED]> --- drivers/s390/net/qeth_main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6-uschi/dr

[patch 0/1] remove header_ops bug in qeth driver

2007-10-19 Thread Ursula Braun
-- Remove qeth driver bug introduced by this commit: commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f Author: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue Oct 9 01:40:57 2007 -0700 [NET]: Move hardware header operations out of netdevice. - To unsubscribe from this list: send the line "u

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-19 Thread Benjamin Herrenschmidt
> Actually I'm not convinced with this explanation. It seems to me that > since there are such serious locking problems (especially with rntl), > there could be once more considered a private workqueue. You've > written earlier about being a lonely user of this code. But, since > Benjamin offered

[PATCH 6/7] tg3: Add PCI error recovery

2007-10-19 Thread Matt Carlson
This patch adds PCI error recovery support. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 9920751..d866387 100644 --- a/drivers/net/tg3.c +++

[PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Matt Carlson
This patch exports the pci_restore_msi_state() function. This function is needed to restore the MSI state during PCI error recovery. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drive

[PATCH 7/7] tg3: Update version to 3.85

2007-10-19 Thread Matt Carlson
This patch updates the version number to 3.85. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index d866387..e5cf97a 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #def

[PATCH 3/7] tg3: Add management FW version to ethtool report

2007-10-19 Thread Matt Carlson
This patch appends the management firmware version to the bootcode firmware string reported through ethtool. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 66682b8..68472ce 100644 --- a/drive

[PATCH 4/7] tg3: PCI command adjustment

2007-10-19 Thread Matt Carlson
This patch changes the way the driver works with the PCI command register. It adjusts the access size from dwords to words. This patch is done both as a PCI configuration space cleanup and as preparatory work for PCI error recovery. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by:

[PATCH 2/7] tg3: MII => TP

2007-10-19 Thread Matt Carlson
This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 253d761..66682b8 10064

[PATCH 1/7] tg3: Add 5723 support

2007-10-19 Thread Matt Carlson
This patch adds support for upcoming 5723 devices. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 014dc2c..253d761 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -200,6 +200,7 @@ s

[PATCH 0/7] tg3: PCI error recovery and more

2007-10-19 Thread Matt Carlson
This patchset adds PCI error recovery, 5723 support and a few other odds and ends. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: multicast: bug or "feature"

2007-10-19 Thread David Stevens
I don't know about a new knob, but it's the same notion as rp_filter, so why not use rpf for RTN_LOCAL types? Ie, allow RTN_LOCAL and RTN_UNICAST at the top, but check rpf if the devs aren't equal or RTN_LOCAL It seems like not a good thing to rely on in the first place, though; usually receiv

Re: multicast: bug or "feature"

2007-10-19 Thread Brian Haley
Hi David, David Stevens wrote: From looking at the code, it appears that validate source is failing just because of the rp_filter. Do you have rp_filter set to nonzero? If so, it may do what you want just by setting that to 0: sysctl -w net.ipv4.conf.all.rp_filter=0 rp_filter

[PATCH 14/14 v2] nes: kernel build infrastructure

2007-10-19 Thread ggrundstrom
Makefile kernel build file. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/Makefile 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,7 @@ + +EXTRA_CFLAGS += -DNES_MINICM + +obj-$(CONFIG_INFI

[PATCH 13/14 v2] nes: kernel build infrastructure

2007-10-19 Thread ggrundstrom
Kconfig kernel build file. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/Kconfig2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,15 @@ +config INFINIBAND_NES + tristate "NetEffect R

[PATCH 12/14 v2] nes: OpenFabrics kernel verbs includes

2007-10-19 Thread ggrundstrom
OpenFabrics kernel vers provider structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_verbs.h2007-10-19 09:43:33.0 -0500 @@ -0,0 +1,165 @@ +/* + * Copyr

[PATCH 10/14 v2] nes: eeprom and phy routines

2007-10-19 Thread ggrundstrom
Misc eeprom, phy, and debug routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_utils.c2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,873 @@ +/* + * Copyright (c) 2006 - 200

[PATCH 9/14 v2] nes: kernel to userspace structures

2007-10-19 Thread ggrundstrom
Kernel to userspace includes, structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_user.h 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,95 @@ +/* + * Copyright (c) 200

[PATCH 8/14 v2] nes: nic device routines

2007-10-19 Thread ggrundstrom
NIC device routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_nic.c 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,1517 @@ +/* + * Copyright (c) 2006 - 2007 NetEffect, Inc. All ri

Re: multicast: bug or "feature"

2007-10-19 Thread David Stevens
From looking at the code, it appears that validate source is failing just because of the rp_filter. Do you have rp_filter set to nonzero? If so, it may do what you want just by setting that to 0: sysctl -w net.ipv4.conf.all.rp_filter=0 +-DLS

[PATCH 7/14 v2] nes: hardware specific includes

2007-10-19 Thread ggrundstrom
Hardware structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_hw.h 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,1124 @@ +/* +* Copyright (c) 2006 - 2007 NetEffect,

[PATCH 5/14 v2] nes: context structures and defines

2007-10-19 Thread ggrundstrom
QP context structures and defines Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_context.h 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,193 @@ +/* + * Copyright (c) 2006 NetEffect

[PATCH 4/14 v2] nes: connection manager structures and defines

2007-10-19 Thread ggrundstrom
NetEffect connection manager includes, structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes_cm.h 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,433 @@ +/* + * Copyrig

[PATCH 2/14 v2] nes: device structures and defines

2007-10-19 Thread ggrundstrom
Main include file for device structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes.h 2007-10-19 09:59:12.0 -0500 @@ -0,0 +1,613 @@ +/* + * Copyright (c) 2006

[PATCH 1/14 v2] nes: module and device initialization

2007-10-19 Thread ggrundstrom
Kernel module and device initialization routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.3/drivers/infiniband/hw/nes/nes.c 2007-10-19 09:43:32.0 -0500 @@ -0,0 +1,811 @@ +/* + * Copyright (c) 2006 -

[PATCH 0/14 v2] nes: NetEffect 10Gb RNIC Driver

2007-10-19 Thread ggrundstrom
This is the second posting for the series of patches containing the source code for the NetEffect 10Gb RNIC adapter. The driver is split into two components - a kernel driver module and a userspace library. The code can also be found in the following git trees. git.openfabrics.org/~glenn/libnes

Re: multicast: bug or "feature"

2007-10-19 Thread Vlad Yasevich
David Stevens wrote: I don't know why you'd want it to be different for multicasting. If you want to hear your own multicasts, you should use MULTICAST_LOOP; hearing them off the wire indicates all the same bad things -- a forger, a duplicate address or a routing loop. Those aren't any better for

Re: Network failure with 2.6.23-git14

2007-10-19 Thread Chris Holvenstot
On Fri, 2007-10-19 at 12:28 -0400, Jeff Garzik wrote: > Chris Holvenstot wrote: > > I built 2.6.23-git14 this morning - when booted I can not access the > > network via my Ethernet connection. Fallback to 2.6.23-git11 works OK. > > One interesting message during boot: > > > [ 37.325760] forcede

Re: networking crash in current mainline: sk_filter_delayed_uncharge()

2007-10-19 Thread Pierre Ossman
Andrew Morton wrote: > powerpc mac G5 > config: http://userweb.kernel.org/~akpm/config-g5.txt > screenshot: http://userweb.kernel.org/~akpm/dsc5.jpg > > It does this shortly after bringing up eth0 (tg3), in dhclient. +1 A Pentium M laptop here. Problem both with a ipw2200 wifi card and 8139

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-19 Thread Maciej W. Rozycki
On Fri, 19 Oct 2007, Jarek Poplawski wrote: > Actually I'm not convinced with this explanation. It seems to me that > since there are such serious locking problems (especially with rntl), > there could be once more considered a private workqueue. You've > written earlier about being a lonely user

Re: multicast: bug or "feature"

2007-10-19 Thread David Stevens
I don't know why you'd want it to be different for multicasting. If you want to hear your own multicasts, you should use MULTICAST_LOOP; hearing them off the wire indicates all the same bad things -- a forger, a duplicate address or a routing loop. Those aren't any better for multicasting than they

Re: Throughput Bug?

2007-10-19 Thread Rick Jones
Matthew Faulkner wrote: I removed the socket sizes in an attempt to reproduce your results Rick and i managed to do so, but only when i launch netperf by typing in the follow cmd in to the bash shell. /home/cheka/netperf-2.4.4/src/netperf -T 0,0 -l 10 -t TCP_STREAM -c 100 -C 100 -f M -P 0 -- -m

Re: multicast: bug or "feature"

2007-10-19 Thread Vlad Yasevich
David Stevens wrote: > [EMAIL PROTECTED] wrote on 10/19/2007 04:43:27 AM: > >> Vlad Yasevich <[EMAIL PROTECTED]> wrote: >>> Now, to figure out what IPv6 does different and why it works. >>> Seems to me that the two should have the same behavior. >> IPv6 on Linux uses a per-interface addressing mod

[IFGROUPv3 1/3] rtnetlink: setlink changes atomic with single notification

2007-10-19 Thread Laszlo Attila Toth
In do_setlink the device changes are atomic and notifications will be sent at the end of the function once if any modification occured and once if address has been changed. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- net/core/rtnetlink.c | 23 --- 1 files chang

[IFGROUPv3 iproute2] Interface group as new ip link option

2007-10-19 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Symbolic names can be specified in /etc/iproute2/rt_ifgroup. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 + include/rt_names.h |2 + ip/ipad

[IFGROUPv3 3/3] Interface group match

2007-10-19 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 18 + net/netfilter/Kconfig| 16 + net/netfilter/Makefile |1 + net/netfilter/x

[IFGROUPv3 iptables] Interface group match

2007-10-19 Thread Laszlo Attila Toth
Matching ifgroup value of incoming and/or outgoing interface. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- extensions/Makefile |2 +- extensions/libip6t_ifgroup.man | 36 +++ extensions/libipt_ifgroup.man| 36 +++ extensions/libxt_ifgrou

[IFGROUPv3 2/3] Interface group: core (netlink) part

2007-10-19 Thread Laszlo Attila Toth
Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 ++ include/linux/netdevice.h |2 ++ net/core/rtnetlink.c

[IFGROUPv3 0/*] Interface groups, round 3

2007-10-19 Thread Laszlo Attila Toth
Hello, This is the 3rd version of interface group patches. Each net_device structure has a non-negative ifgroup member indicating the group it belongs to. In the ip tool it is between 0 and 256 where 0 means it is unset. Usage: ip link set eth0 group 4 ip lonk set eth0 group 0# to

Re: Network failure with 2.6.23-git14

2007-10-19 Thread Jeff Garzik
Chris Holvenstot wrote: I built 2.6.23-git14 this morning - when booted I can not access the network via my Ethernet connection. Fallback to 2.6.23-git11 works OK. One interesting message during boot: [ 37.325760] forcedeth: Reverse Engineered nForce ethernet driver. [ 37.843618] forcedet

Re: Fw: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure

2007-10-19 Thread Herbert Xu
John Heffner <[EMAIL PROTECTED]> wrote: > >> >> Backtrace #1: >> page allocation failure. order:1, mode:0x20 >> [] __alloc_pages+0x2e1/0x300 >> [] cache_alloc_refill+0x29e/0x4b0 >> [] __kmalloc+0x6e/0x80 >> [] __alloc_skb+0x53/0x110 >> [] tcp_collapse+0x1ac/0x370 >> [] tcp_prune_queue+0xf

Re: Throughput Bug?

2007-10-19 Thread Matthew Faulkner
I removed the socket sizes in an attempt to reproduce your results Rick and i managed to do so, but only when i launch netperf by typing in the follow cmd in to the bash shell. /home/cheka/netperf-2.4.4/src/netperf -T 0,0 -l 10 -t TCP_STREAM -c 100 -C 100 -f M -P 0 -- -m 523 As soon as i try to l

Re: multicast: bug or "feature"

2007-10-19 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/19/2007 04:43:27 AM: > Vlad Yasevich <[EMAIL PROTECTED]> wrote: > > > > Now, to figure out what IPv6 does different and why it works. > > Seems to me that the two should have the same behavior. > > IPv6 on Linux uses a per-interface addressing model as opposed > to t

Re: Fw: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure

2007-10-19 Thread John Heffner
Stephen Hemminger wrote: Looks like a memory over commit with small machines?? Begin forwarded message: Date: Fri, 19 Oct 2007 01:35:33 -0700 (PDT) From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure [snip]

Re: iproute2: git pull request from debian repo.

2007-10-19 Thread Andreas Henriksson
Hello maks! Thanks for your help. I had to tweak the commands a bit to git it working. I hope I did it right.. On Fri, Oct 19, 2007 at 03:06:16PM +0200, maximilian attems wrote: > > on klibc i'm asked to attach git log -p on a pull request so > that the patches can be reviewed, please do so too.

Fw: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure

2007-10-19 Thread Stephen Hemminger
Looks like a memory over commit with small machines?? Begin forwarded message: Date: Fri, 19 Oct 2007 01:35:33 -0700 (PDT) From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure http://bugzilla.kernel.org/show_bu

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-19 Thread Jarek Poplawski
On Fri, Oct 19, 2007 at 12:38:29PM +0100, Maciej W. Rozycki wrote: > On Thu, 18 Oct 2007, Maciej W. Rozycki wrote: > > > > 1) phy_change() checks PHY_HALTED flag without lock; I think it's > > > racy: eg. if it's done during phy_stop() it can check just before > > > the flag is set and reenable in

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-19 Thread Timur Tabi
Emil Medve wrote: drivers/net/ucc_geth.c: In function 'ucc_geth_startup': drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer without a cast drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer without a cast Signed-off-by: Emil Medve <[EMAIL PROT

Re: [PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec

2007-10-19 Thread Herbert Xu
Joakim Koskela <[EMAIL PROTECTED]> wrote: > > I'm not sure I follow. This affects the ipv6 bundling only where the struct > (fl_tunnel) has previously been used for ipv6 addresses. Not that we are > using the same block for holding the ipv4 info, the tos-value is really > undefined before we res

Re: [PATCH] netdev: Interfamily support for IPSEC BEET

2007-10-19 Thread Herbert Xu
Joakim Koskela <[EMAIL PROTECTED]> wrote: > Hi, > > Here's an updated version of the patch adding support for ipv4/ipv6 > interfamily addressing for the ipsec BEET (Bound End-to-End Tunnel) > mode, as specified by the ietf draft found at: > > http://www.ietf.org/internet-drafts/draft-nikander-esp

[PATCH] Compact some ifdefs in the fib code

2007-10-19 Thread Pavel Emelyanov
There are places that check for CONFIG_IP_MULTIPLE_TABLES twice in the same file, but the internals of these #ifdefs can be merged. As a side effect - remove one ifdef from inside a function. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/ip_fib.h b/include/net/

[PATCH 9/8] [MV643XX_ETH] Merge drivers/net/mv643xx_eth.h into mv643xx_eth.c

2007-10-19 Thread Lennert Buytenhek
Since drivers/net/mv643xx_eth.c is the only user of drivers/net/mv643xx_eth.h, there's not much use in having the header file as a separate file, so merge the header into the driver. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/mv643xx_eth.c ==

Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

2007-10-19 Thread Lennert Buytenhek
On Fri, Oct 19, 2007 at 05:56:54AM -0700, Dale Farnsworth wrote: > > > Isn't it a little too confusing to have two headers with the same name, > > > one in drivers/net and one in include/linux? > > > > Perhaps we can fold the drivers/net one into drivers/net/mv643xx_eth.c? > > Since nothing else

RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-19 Thread Medve Emilian-EMMEDVE1
Hello David > It only kills the warning on 32-bit systems, the cast is wrong > either way. I'm not aware of the QE being present on any 64-bit PowerPC. However, porting the entire driver to a 64-bit platform is an exercise in itself as many other things would need tweaking the QE hardware itself

Re: [PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec

2007-10-19 Thread Joakim Koskela
On Friday 19 October 2007 16:09:05 Herbert Xu wrote: > On Fri, Oct 19, 2007 at 02:40:16PM +0300, Joakim Koskela wrote: > > > > This bit was chopped off the larger patch dealing with the problems > > related to creating the bundles for inter-family tranformations. > > This changes behaviour. Previo

Re: [PATCH] netdev: Netfilters on outgoing interfamily ipsec

2007-10-19 Thread Joakim Koskela
On Friday 19 October 2007 15:55:55 Herbert Xu wrote: > While I agree that this is definitely a problem, I've already > got a solution for it which we happen to need for async crypto > anyway. > > Basically xfrm_output will invoke a continuation function based > on the external mode/family which wil

Re: [PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec

2007-10-19 Thread Herbert Xu
On Fri, Oct 19, 2007 at 02:40:16PM +0300, Joakim Koskela wrote: > This patch resets the ipv4-related flags in the new flow as their > content will otherwise depend on the bits of the ipv6 addresses the > struct was previously used for. For example, fl4_tos might have > RTO_ONLINK set, which usually

Re: iproute2: git pull request from debian repo.

2007-10-19 Thread maximilian attems
On Fri, Oct 19, 2007 at 02:27:53PM +0200, Andreas Henriksson wrote: > Hello! > > We now have our brand new git repo set up for the debian package. We have > created a branch called "patches" where we are going to put stuff that we > hope will get merged upstream. > > I'm sending out this pull req

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-19 Thread Maciej W. Rozycki
On Fri, 19 Oct 2007, Jarek Poplawski wrote: > But then... your patch seems to make it possible, because it enables > irq to the initial state of the counter. Of course, this could happen > on closing only. That's because free_irq() does not disable the interrupt in the correct manner. The scen

Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

2007-10-19 Thread Dale Farnsworth
On Fri, Oct 19, 2007 at 01:09:57PM +0200, Lennert Buytenhek wrote: > On Fri, Oct 19, 2007 at 09:30:48AM +0100, Christoph Hellwig wrote: > > Isn't it a little too confusing to have two headers with the same name, > > one in drivers/net and one in include/linux? > > Perhaps we can fold the drivers/n

Re: [PATCH] netdev: Netfilters on outgoing interfamily ipsec

2007-10-19 Thread Herbert Xu
On Fri, Oct 19, 2007 at 02:37:38PM +0300, Joakim Koskela wrote: > Hi, > > I understand that Herbert is in midst of cleaning up the output of > interfamily transformations, but I thought I'd post a couple of > patches related to that anyway, sort of to show what we've needed to > fix to get our sys

iproute2: git pull request from debian repo.

2007-10-19 Thread Andreas Henriksson
Hello! We now have our brand new git repo set up for the debian package. We have created a branch called "patches" where we are going to put stuff that we hope will get merged upstream. I'm sending out this pull request to get confirmation about if we are on the right track ... The repo url is g

[PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec

2007-10-19 Thread Joakim Koskela
This patch resets the ipv4-related flags in the new flow as their content will otherwise depend on the bits of the ipv6 addresses the struct was previously used for. For example, fl4_tos might have RTO_ONLINK set, which usually prevents the right route from being found. This bit was chopped off th

Re: multicast: bug or "feature"

2007-10-19 Thread Herbert Xu
Vlad Yasevich <[EMAIL PROTECTED]> wrote: > > Now, to figure out what IPv6 does different and why it works. > Seems to me that the two should have the same behavior. IPv6 on Linux uses a per-interface addressing model as opposed to the per-host model used by IPv4. Cheers, -- Visit Openswan at htt

[PATCH] netdev: Netfilters on outgoing interfamily ipsec

2007-10-19 Thread Joakim Koskela
Hi, I understand that Herbert is in midst of cleaning up the output of interfamily transformations, but I thought I'd post a couple of patches related to that anyway, sort of to show what we've needed to fix to get our systems working. This one changes how the netfilters are applied during output

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-19 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Maciej W. Rozycki wrote: > > 1) phy_change() checks PHY_HALTED flag without lock; I think it's > > racy: eg. if it's done during phy_stop() it can check just before > > the flag is set and reenable interrupts just after phy_stop() ends. > > I remember having a look into it,

[PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-19 Thread Domen Puncer
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC). Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- On 18/10/07 15:14 -0400, Jeff Garzik wrote: > > except a resend combining patches 3 and 4 as requested :) OK, here it goes. Sorry for the delay. diffstat: drivers/net/Kconfig |

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Martin Schwidefsky
On Fri, 2007-10-19 at 13:17 +0200, Cedric Le Goater wrote: > > please cc netdev on network issues. > > yes. > > >> Bringing up interface eth0: Ý cut here ¨ > >> Kernel BUG at 0002 Ýverbose debug info unavailable¨ > >> illegal operation: 0001 Ý#1¨ > > > >

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Cedric Le Goater
>> that helped going a little further in the boot process but we then have >> a network issue when bringing the network interface up : > > please cc netdev on network issues. yes. >> Bringing up interface eth0: Ý cut here ¨ >> Kernel BUG at 0002 Ýverbose d

Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

2007-10-19 Thread Lennert Buytenhek
On Fri, Oct 19, 2007 at 09:30:48AM +0100, Christoph Hellwig wrote: > > Move the mv643xx's ethernet-related register definitions from > > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since > > they aren't of any use outside the ethernet driver. > > > > Signed-off-by: Lennert Buytenhek <

  1   2   >