On Fri, Oct 19, 2007 at 09:30:48AM +0100, Christoph Hellwig wrote: > > Move the mv643xx's ethernet-related register definitions from > > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since > > they aren't of any use outside the ethernet driver. > > > > Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> > > Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> > > > > Index: linux-2.6/drivers/net/mv643xx_eth.h > > =================================================================== > > --- linux-2.6.orig/drivers/net/mv643xx_eth.h > > +++ linux-2.6/drivers/net/mv643xx_eth.h > > @@ -7,7 +7,7 @@ > > #include <linux/workqueue.h> > > #include <linux/mii.h> > > > > -#include <linux/mv643xx.h> > > +#include <linux/mv643xx_eth.h> > > Isn't it a little too confusing to have two headers with the same name, > one in drivers/net and one in include/linux?
Perhaps we can fold the drivers/net one into drivers/net/mv643xx_eth.c? Since nothing else includes drivers/net/mv643xx_eth.h anyway, there's not much point in having it separate. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
