On Fri, 19 Oct 2007 22:22:44 -0700
Roland Dreier <[EMAIL PROTECTED]> wrote:
> > You are starting off on the wrong foot.
>
> ???
That was a introductory comment because even in reviewing the first
file (which had almost no code), I saw so many style issues.
> > > +if(!(expr)) {
> \
> > > + printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n",
> \
> > > + #expr, __FILE__, __FUNCTION__, __LINE__);
> \
> > > +}
> >
> > Use BUG_ON
>
> I agree that there's no need to invent a driver-private assertion
> macro, but (to first order at least) drivers should never use BUG_ON.
> I don't want some glitch in a network driver that the system could
> probably survive to be turned into a panic by BUG_ON -- WARN_ON seems
> infinitely preferable.
>
> - R.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
