Oliver Hartkopp wrote:
> Varun Chandramohan wrote:
>
>> Patrick McHardy wrote:
>>
>>
>>> Varun Chandramohan wrote:
>>>
>>>
>>>
/**
+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
Varun Chandramohan wrote:
> Patrick McHardy wrote:
>
>> Varun Chandramohan wrote:
>>
>>
>>> /**
>>> + * timeval_to_sec - Convert timeval to seconds
>>> + * @tv: pointer to the timeval variable to be converted
>>> + *
>>> + * Returns the seconds representation of timeval paramete
On Mon, 2007-07-23 at 22:47 -0700, David Miller wrote:
> I don't think it's wise to implement this over and over again in each
> driver, since we already know at least a handfull of drivers will use
> this.
Yep. Alternative is a napi_struct_with_restart, but I don't think it's
worth the few-byte
On Tue, Jul 24, 2007 at 08:36:33AM +0300, Al Boldi wrote:
>
> Replaces NF_CONNTRACK_ENABLED with NF_CONNTRACK and selects it for
> NF_CONNTRACK_IPV4 and NF_CONNTRACK_IPV6
>
> This exposes IPv4/6 connection tracking options for easier Kconfig setup.
>
> Signed-off-by: Al Boldi <[EMAIL PROTECTED]
Any reason you're not sending this to the netfilter developer list
mentioned in MAINTAINERS, or it's chief maintainer Patrick McHardy?
NETFILTER/IPTABLES/IPCHAINS
P: Rusty Russell
P: Marc Boucher
P: James Morris
P: Harald Welte
P: Jozsef Kadlecsik
P: Patrick McHardy
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 14:47:19 +1000
> On Mon, 2007-07-23 at 21:07 -0700, David Miller wrote:
> > Another area of consternation are drivers that were using
> > netif_rx_reschedule(), as that interface was removed because it
> > doesn't fit well with the cal
On Mon, Jul 23, 2007 at 03:27:12PM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2007 02:04:46 +0400
> Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
>
> > On Mon, Jul 23, 2007 at 02:11:37PM -0700, Andrew Morton wrote:
> > > On Tue, 24 Jul 2007 01:01:53 +0400
> > > Alexey Dobriyan <[EMAIL PROTECTED]> w
On Mon, 2007-07-23 at 21:07 -0700, David Miller wrote:
> Another area of consternation are drivers that were using
> netif_rx_reschedule(), as that interface was removed because it
> doesn't fit well with the caller managing the dev->quota et al. I
> left race conditions in the drivers that were u
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix kernel-doc omissions in net/:
Warning(linux-2.6.23-rc1//net/core/dev.c:2728): No description found for
parameter 'addr'
Warning(linux-2.6.23-rc1//net/core/dev.c:2752): No description found for
parameter 'addr'
Warning(linux-2.6.23-rc1//net/core/dev.c:3
Stephen Hemminger wrote:
> On Mon, 23 Jul 2007 10:13:18 +0530
> Varun Chandramohan <[EMAIL PROTECTED]> wrote:
>
>
>> The age field of the ipv6 route structures are initilized with the current
>> timeval at the time of route creation. When the route dump is called
>> the route age value s
Patrick McHardy wrote:
> Varun Chandramohan wrote:
>
>> /**
>> + * timeval_to_sec - Convert timeval to seconds
>> + * @tv: pointer to the timeval variable to be converted
>> + *
>> + * Returns the seconds representation of timeval parameter.
>> + */
>> +static inline time_t timeval_to_s
Hi Jamal,
J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/23/2007 06:02:01 PM:
> Yes, and these results were sent to you as well a while back.
> When i get the time when i get back i will look em up in my test machine
> and resend.
Actually you have not sent netperf results with prep and without pr
This patch fixes a potential null dereference bug where we dereference
DEV before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---
--- a/drivers/net/pcmcia/nmclan_cs.c
+++ b/drivers/net/pcmcia/nmclan_cs.c
For the guys on netdev, would you please look at the tcp_recvmsg-
threading and TCP_NAGLE_CORK issues below and give opinions on the
best way to proceed?
One thing to remember, you don't necessarily have to merge every
feature right away. As long as the new code is configured "off" by
def
On Tue, 24 Jul 2007 02:04:46 +0400
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 23, 2007 at 02:11:37PM -0700, Andrew Morton wrote:
> > On Tue, 24 Jul 2007 01:01:53 +0400
> > Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> >
> > > On Tue, Jul 24, 2007 at 12:40:45AM +0400, Alexey Dobriyan
On Mon, 23 Jul 2007, Joy Latten wrote:
> Revised patch that modifies xfrm_audit_log() such that it
> can accomodate auditing other ipsec events
> besides add/delete of an SA or SPD entry.
>
> This patch differs from original in that it does
> not remove existing ipsec audit defines so as
> to not
On Mon, Jul 23, 2007 at 02:11:37PM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2007 01:01:53 +0400
> Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
>
> > On Tue, Jul 24, 2007 at 12:40:45AM +0400, Alexey Dobriyan wrote:
> > > > I had more complete info:
> > > > http://article.gmane.org/gmane.linux.ne
Revised patch that modifies xfrm_audit_log() such that it
can accomodate auditing other ipsec events
besides add/delete of an SA or SPD entry.
This patch differs from original in that it does
not remove existing ipsec audit defines so as
to not break existing audit apps.
This is a small change t
>
> For example, missing from the call graph is
>
> get_page_from_freelist ->
> buffered_rmqueue -> [ missing - inlined ]
> prep_new_page ->[ missing - inlined ]
> prep_zero_page -> [ missing - inlined ]
> clear_highp
On Mon, 23 Jul 2007, Andrew Morton wrote:
>
> It'd be nice to get a clean trace. Are you able to obtain the full
> trace with CONFIG_FRAME_POINTER=y?
If you are talking about
http://userweb.kernel.org/~akpm/dsc03659.jpg
then I think that _is_ a full trace. It's certainly not very mes
On Sun, 22 Jul 2007 20:43:15 -0400
Ayaz Abdulla <[EMAIL PROTECTED]> wrote:
> This patch contains new device ids for MCP73 chipset.
>
> Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>
>
no current practice is to stop cluttering pci_ids.h with specific sub-device
id's
and just have the vendor va
On Mon, 23 Jul 2007 19:06:42 +0200
Andi Kleen <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 23, 2007 at 10:58:22AM +0100, Stephen Hemminger wrote:
> > On 21 Jul 2007 15:26:00 +0200
> > Andi Kleen <[EMAIL PROTECTED]> wrote:
> >
> > > David Miller <[EMAIL PROTECTED]> writes:
> > > >
> > > > Good candid
On Tue, 24 Jul 2007 01:01:53 +0400
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> On Tue, Jul 24, 2007 at 12:40:45AM +0400, Alexey Dobriyan wrote:
> > > I had more complete info:
> > > http://article.gmane.org/gmane.linux.network/66966
> > >
> > > You're using DEBUG_PAGEALLOC, but I was not, so I
I have been seeing some occasional strange behavior when using
proxy_arp. I have a router running with an ADSL PPPoE link to the
Internet, and an Ethernet link to a local network. It has proxy_arp
enabled on the internal Ethernet port since I sometimes have ipsec
tunnels running where I use proxy
On Tue, Jul 24, 2007 at 12:40:45AM +0400, Alexey Dobriyan wrote:
> > I had more complete info: http://article.gmane.org/gmane.linux.network/66966
> >
> > You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that
> > out.
> >
> > I haven't worked out where that kmap_atomic() call i
This patch contains new device settings for MCP73 chipset.
Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>
--- old/drivers/net/forcedeth.c 2007-07-22 19:02:41.0 -0400
+++ new/drivers/net/forcedeth.c 2007-07-22 19:31:56.0 -0400
@@ -5550,6 +5550,22 @@
PCI_DEVICE(PCI
This patch contains new device ids for MCP73 chipset.
Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>
--- old/include/linux/pci_ids.h 2007-07-22 18:57:26.0 -0400
+++ new/include/linux/pci_ids.h 2007-07-22 18:57:11.0 -0400
@@ -1223,6 +1223,10 @@
#define PCI_DEVICE_ID_NVIDIA_NVENE
On Sun, 2007-07-22 at 13:43 +0200, patric wrote:
> patric wrote:
>
> > Hi,
> >
> > Think i got something working for me at least, and the fix is quite
> > minimal and only downside that i could see from it was that you might
> > get a small delay when bringing up the interface, but that's probab
On Mon, Jul 23, 2007 at 01:24:31PM -0700, Andrew Morton wrote:
> On Mon, 23 Jul 2007 23:01:52 +0400
> Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
>
> > On Mon, Jul 23, 2007 at 10:38:39PM +0400, Alexey Dobriyan wrote:
> > > Managed to hit BUG_ON() in kmap_atomic_prot() three times while doing
> > >
On Wed, 18 Jul 2007 09:55:37 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> hm. It should be the case that providing SLAB_HWCACHE_ALIGN at
> kmem_cache_create() time will override slab-debugging's offsetting
> of the returned addresses.
That is true for SLUB but not in SLAB. SLAB has always i
On Mon, 23 Jul 2007 23:01:52 +0400
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 23, 2007 at 10:38:39PM +0400, Alexey Dobriyan wrote:
> > Managed to hit BUG_ON() in kmap_atomic_prot() three times while doing
> > nothing unusual for this box (two times it was under X, so I can't
> > guar
On Mon, 23 Jul 2007 09:36:08 -0700 (PDT)
[EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8797
>
>Summary: WARNING from skb_gso_segment
>Product: Networking
>Version: 2.5
> KernelVersion: 2.6.22.1
> Platform: All
> OS
Hi Florian:
Changes look pretty good to me.
I'd also recommend deferring the call to k_init_timer() to the same
point as your list_add_tail() call. (If you don't, then there should
really be a k_term_timer() call in the clean up code that handles a
failure of tipc_node_attach_link().)
Regards,
On Thu, Jul 19, 2007 at 04:11:35PM +0200, Thomas Müller wrote:
> Hi,
>
> I already sent this two days ago, but I have the feeling it was
> overlooked or filtered because of a large attachment.
>
>
> If I try to boot 2.6.21.6, 2.6.22.1 or 2.6.22-git8 the system completely
> hangs when init tries
On Tue, 10 Jul 2007 16:53:09 -0700
Yinghai Lu <[EMAIL PROTECTED]> wrote:
> [PATCH 5/5] dma: use dev_to_node to get node for device in
> dma_alloc_pages
Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [
The ADVMSS value was incorrectly updated for ALL routes when the MTU
is updated because it's outside the effect of the if statement's
condition.
Signed-off-by: Simon Arlott <[EMAIL PROTECTED]>
---
This fixes http://bugzilla.kernel.org/show_bug.cgi?id=8756
net/ipv6/route.c |5 +++--
1 files
David Miller wrote:
From: Rick Jones <[EMAIL PROTECTED]>
Date: Fri, 13 Jul 2007 09:55:10 -0700
Fine, but so? I suspect the point of the patch is to provide a
lower cap on the accumulated backoff so data starts flowing over the
connection within that lower cap once the link is
restored/failed-
Folks -
People running netperf have reported that they have trouble with IPv6 under
Linux. Specifically, wereas the use of link-local IPv6 addresses "just works"
in netperf under a number of "other OSes" they do not under Linux. I'm
ass-u-me-ing 2.6 here, but not sure exactly which ones - I'
Bidirectional test.
87380 65536 6553660.01 7809.57 28.6630.022.405 2.519
TX
87380 65536 6553660.01 7592.90 28.6630.022.474 2.591
RX
--
87380 65536 6553660.01 7629.73 28.3229.642.433 2.546
RX
87380 65536 6553
if printbuf allocation or tipc_node_attach_link() fails, invalid
references to the link are left in the associated node and bearer
structures.
Fix by doing printbuf allocation early and adding the new link
to b_ptr->links after tipc_node_attach_link() succeeded.
Signed-off-by: Florian Westphal <[E
kAccording to git, the only one who touched this file during the last
5 years was me when removing drivers...
modinfo offers a less ancient version of this information.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
Documentation/networking/00-INDEX|2
Documentation/networking
Andrew Morton wrote:
> On Sat, 21 Jul 2007 00:44:08 -0700 (PDT) [EMAIL PROTECTED] wrote:
>
>
>>http://bugzilla.kernel.org/show_bug.cgi?id=8789
>>
>> Summary: Error inserting ipt_LOG (mod_path): Device or resource
>>busy
>
>
> A 2.6.12 -> 2.6.22 regression.
Crap,
On Monday 23 July 2007 13:49:17 Joy Latten wrote:
> > Will this cause existing applications to break?
>
> Perhaps someone in audit list could help answer this.
Probably. Its better to take a new number and let the old ones sit idle.
-Steve
-
To unsubscribe from this list: send the line "unsubscri
On Thu, 2007-07-19 at 21:45 -0400, James Morris wrote:
> On Thu, 19 Jul 2007, Joy Latten wrote:
>
> > --- linux-2.6.22/include/linux/audit.h 2007-07-19 13:17:22.0
> > -0500
> > +++ linux-2.6.22.patch/include/linux/audit.h2007-07-19
> > 13:21:29.0 -0500
> > @@ -108,10
On Mon, Jul 23, 2007 at 10:58:22AM +0100, Stephen Hemminger wrote:
> On 21 Jul 2007 15:26:00 +0200
> Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> > David Miller <[EMAIL PROTECTED]> writes:
> > >
> > > Good candidates for taking advantage of multi-napi are:
> > >
> > > 1) e1000
> > > 2) ucc_geth
> >
Thomas Graf wrote:
> Actually there is no reason to not use separate locks for the
> message serialization and the protection of the list of registered
> families. There is only one lock simply for the reason that I've
> never thought of anybody could think of registering a new genetlink
> family w
This patch modifies the xfrm state selection logic to use the inner
addresses where the outer have been (incorrectly) used. This is
required for beet mode in general and interfamily setups in both
tunnel and beet mode.
Signed-off-by: Joakim Koskela <[EMAIL PROTECTED]>
Signed-off-by: Herbert Xu
On Fri 2007-07-13 21:11:28, Kok, Auke wrote:
> [adding netdev]
>
> David Fries wrote:
> >When I did a software suspend to disk then resumed the Intel network
> >card using eepro100 driver would be unable to transmit packets. I
> >tracked this down and found a register write after the print messag
net_poll support for eHEA added
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 22 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea
KK,
On Mon, 2007-23-07 at 10:19 +0530, Krishna Kumar2 wrote:
> Hmmm ? Evgeniy has not even tested my code to find some regression :) And
> you may possibly not find much improvement in E1000 when you run iperf
> (which is what I do) compared to pktgen.
Pktgen is the correct test (or the closest
On Mon, 23 Jul 2007 10:13:18 +0530
Varun Chandramohan <[EMAIL PROTECTED]> wrote:
> The age field of the ipv6 route structures are initilized with the current
> timeval at the time of route creation. When the route dump is called
> the route age value stored in the structure is subtracted f
Varun Chandramohan wrote:
> /**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv: pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> +
Hi Evgeniy,
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 07/23/2007 04:14:28 PM:
> > +/*
> > + * dev_change_tx_batching - Enable or disable batching for a driver
that
> > + * supports batching.
> > + /* Check if new value is same as the current */
> > + if (!!(dev->features & NETIF_F_BATCH_O
Hi Evgeniy,
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 07/23/2007 04:18:26 PM:
> > static void ipoib_ib_handle_tx_wc(struct net_device *dev, struct ib_wc
*wc)
> > {
> > struct ipoib_dev_priv *priv = netdev_priv(dev);
> > + int i = 0, num_completions;
> > + int tx_ring_index = priv->t
Hi Krishna.
On Sun, Jul 22, 2007 at 02:35:25PM +0530, Krishna Kumar ([EMAIL PROTECTED])
wrote:
> diff -ruNp org/net/core/dev.c rev2/net/core/dev.c
> --- org/net/core/dev.c2007-07-20 07:49:28.0 +0530
> +++ rev2/net/core/dev.c 2007-07-21 23:08:33.0 +0530
> @@ -875,6 +8
On Sun, Jul 22, 2007 at 02:36:49PM +0530, Krishna Kumar ([EMAIL PROTECTED])
wrote:
> diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> rev2/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> --- org/drivers/infiniband/ulp/ipoib/ipoib_ib.c 2007-07-20
> 07:49:28.0 +0530
> +++ rev2/driv
Hi Jan-Bernd.
On Fri, Jul 20, 2007 at 05:41:48PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED])
wrote:
> Generic LRO patch
>
> Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
Besides couple trivial codyng/formatting nits I did not found any
problematic places after review. Details below.
Th
* Richard MUSIL <[EMAIL PROTECTED]> 2007-07-20 18:15
> Patrick McHardy wrote:
> > Export the lock/unlock/.. functions. You'll also need a new version
> > similar to __rtnl_unlock.
>
> Patrick, you might feel, I am not reading your lines, but in fact I do.
> The problem is that I do not feel compe
On Mon, Jul 23, 2007 at 11:47:30AM +0200, Michal Piotrowski wrote:
> Subject : drivers/misc/asus-laptop.c:*: error: 'struct led_classdev'
> has no member named 'class_dev'
> References : http://lkml.org/lkml/2007/7/22/299
> Last known good : ?
> Submitter : Gabriel C <[EMAIL PRO
> >Too late, Linus just closed the merge window, you had two
> >weeks to submit this :-)
> Too bad...
> I submitted it as soon as it was ready. Will we have to wait until the
> 2.6.24 merge window, or can it be applied earlier as it's a fully
> standalone driver ?
You can always send Linus a copy
On Sat, 21 Jul 2007 12:16:30 +0530
Krishna Kumar2 <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007
> 09:52:03 PM:
> > Patrick McHardy <[EMAIL PROTECTED]> wrote:
> >
> > > Krishna Kumar2 wrote:
> > > > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:
On 21 Jul 2007 15:26:00 +0200
Andi Kleen <[EMAIL PROTECTED]> wrote:
> David Miller <[EMAIL PROTECTED]> writes:
> >
> > Good candidates for taking advantage of multi-napi are:
> >
> > 1) e1000
> > 2) ucc_geth
> > 3) ehea
> > 4) sunvnet
>
> s2io.c
sky2.c could use it because of issues with dual-
> I have started a 10 run test for various buffer sizes and processes, and
> will post the results on Monday.
The 10 iteration run results for Rev2 are (average) :
--
Test Case Org New
Hi all,
Here is a list of some known regressions in 2.6.23-rc1.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Andi Kleen 4
Linus Torvalds
On Sat, 21 Jul 2007 09:46:19 -0400
jamal <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-20-07 at 08:18 +0100, Stephen Hemminger wrote:
>
> > You may see worse performance with batching in the real world when
> > running over WAN's. Like TSO, batching will generate back to back packet
> > trains that
On Mon, Jul 23, 2007 at 07:44:58AM +0200, Marcin Ślusarz wrote:
> Ok, I've bisected this problem and found that this patch broke my NIC:
Congratulations!
>
> 76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit
> commit 76d2160147f43f982dfe881404cfde9fd0a9da21
> Author: Ingo Molnar <[EMA
The Coverity checker noted that we've already dereferenced "dev" when we
check whether it's NULL.
Since it's impossible that "dev" is NULL at this place this patch
removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/drivers/net/acenic.c.old
This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing
after the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -768,11 +7
> + if (dumpflg)
> + NLA_PUT_U32(skb, RTA_AGE, timeval_to_sec(&tv) - rt->rt6i_age);
> + else
> + NLA_PUT_U32(skb, RTA_AGE, rt->rt6i_age);
Makes more sense (and easy to understand) if you use :
if (dumpflg == RT6_GET_ROUTE_INFO)
...
so that your code does not break if someone c
Hi Adrian,
> Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following
> use-after-free in net/bluetooth/rfcomm/tty.c:
>
> <-- snip -->
>
> ...
> static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
> {
> ...
> if (IS_ERR(dev->tty_dev)) {
>
On 7/23/2007, "David Miller" <[EMAIL PROTECTED]> wrote:
>From: Samuel Ortiz <[EMAIL PROTECTED]>
>Date: Mon, 23 Jul 2007 00:32:17 +0300
>
>> Last IrDA patch for 2.6.23-rc1, if it's not too late...
>
>Too late, Linus just closed the merge window, you had two
>weeks to submit this :-)
Too bad...
I s
From: "Samuel Ortiz" <[EMAIL PROTECTED]>
Date: 23 Jul 2007 07:25:06 -
> I submitted it as soon as it was ready. Will we have to wait until the
> 2.6.24 merge window, or can it be applied earlier as it's a fully
> standalone driver ?
Please wait until I open up a net-2.6.24 tree, you can submi
72 matches
Mail list logo
