On Sat, 21 Jul 2007 12:16:30 +0530 Krishna Kumar2 <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007 > 09:52:03 PM: > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > > > Krishna Kumar2 wrote: > > > > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:37:20 PM: > > > > > > > > > > > > > > > >> rtnetlink support seems more important than sysfs to me. > > > >> > > > > > > > > Thanks, I will add that as a patch. The reason to add to sysfs is > that > > > > it is easier to change for a user (and similar to tx_queue_len). > > > > > > > > > > > But since batching is so similar to TSO, i really should be part of the > > flags and controlled by ethtool like other offload flags. > > So should I add all three interfaces (or which ones) : > > 1. /sys (like for tx_queue_len) > 2. netlink > 3. ethtool. > > Or only 2 & 3 are enough ? > Yes, please do #3 and maybe #2. Sysfs api's are a long term ABI problem. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
