acx-20060215 for etch

2006-12-15 Thread jeffery
pci.c needed a fix for etch.. I added the includes for utsrelease.h as they were needed for the declaration of UTS_RELEASE in debian etch... as the acx tarball downloaded into debian etch: ~ debian:/usr/src/acx-20060215# make -C /lib/modules/`uname -r`/build M=`pwd` make: Entering

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Wu
On Thursday 14 December 2006 13:20, Michael Buesch wrote: > -int ieee80211_update_hw(struct ieee80211_hw *hw) > +int ieee80211_register_hwmode(struct ieee80211_hw *hw, > + struct ieee80211_hw_mode *mode) Looks like this function never returns nonzero now. Can it return voi

[PATCH 4/4][TG3]: Update version and reldate.

2006-12-15 Thread Michael Chan
[TG3]: Update version and reldate. Update version to 3.71. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 6ee399c..cfdbca2 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -68,8 +68,8 @@ #define DRV_MODULE_NAME

[PATCH 3/4][TG3]: Power down/up 5906 PHY correctly.

2006-12-15 Thread Michael Chan
[TG3]: Power down/up 5906 PHY correctly. The 5906 PHY requires a special register bit to power down and up the PHY. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 6804489..6ee399c 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@

[PATCH 2/4][TG3]: Fix race condition when calling register_netdev().

2006-12-15 Thread Michael Chan
[TG3]: Fix race condition when calling register_netdev(). Hot-plug scripts can call tg3_open() as soon as register_netdev() is called in tg3_init_one(). We need to call pci_set_drvdata() before register_netdev(), and netif_carrier_off() needs to be moved to tg3_open() to avoid race conditions. S

[PATCH 1/4][TG3]: Assign tp->link_config.orig_* values.

2006-12-15 Thread Michael Chan
[TG3]: Assign tp->link_config.orig_* values. tp->link_config.orig_* values must be assigned during tg3_set_settings() because these values will be used to setup the link speed during tg3_open(). Without these assignments, the link speed settings will be all messed by if tg3_set_settings() is call

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

2006-12-15 Thread Sam Leffler
Sam Leffler wrote: > David Young wrote: >> On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: >>> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: --- a/include/net/ieee80211_radiotap.h +++ b/include/net/ieee80211_radiotap.h @@ -168,6 +168,23 @@ struct ieee80211_radi

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

2006-12-15 Thread Sam Leffler
David Young wrote: > On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: >> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: >>> --- a/include/net/ieee80211_radiotap.h >>> +++ b/include/net/ieee80211_radiotap.h >>> @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { >>> *

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

2006-12-15 Thread Michael Wu
On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: >--- a/include/net/ieee80211_radiotap.h >+++ b/include/net/ieee80211_radiotap.h >@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { > * Unitless indication of the Rx/Tx antenna for this packet. > * The first antenna is antenn

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

2006-12-15 Thread David Young
On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: > On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: > >--- a/include/net/ieee80211_radiotap.h > >+++ b/include/net/ieee80211_radiotap.h > >@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { > > * Unitless indication of th

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-15 Thread Alex Romosan
Stephen Hemminger <[EMAIL PROTECTED]> writes: > I fixed a bunch of stuff (see ChangeLog) and made a 2.6.19 or later > version see: > http://developer.osdl.org/shemminger/prototypes/sk98lin-8.41.tar.gz > > It is too noisy in the console log, because it shows how many times > the driver dope s

Re: [PATCH 3/3] chelsio: more receive cleanup

2006-12-15 Thread Stephen Hemminger
On Sat, 16 Dec 2006 01:26:04 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > > Francois Romieu <[EMAIL PROTECTED]> wrote: > [...] > > Why, you can't predict copybreak on off > > Plain gut feeling. I'd rather spend extra cycles on small packets (whose >

Re: [PATCH 0/2] A bugfix patchset for NetLabel

2006-12-15 Thread James Morris
On Fri, 15 Dec 2006, [EMAIL PROTECTED] wrote: > This patch set fixes two bugs that were found recently when adding new CIPSOv4 > DOI definitions. These patches are pretty small and have been tested by a few > different people on several different platforms. Applied to git://git.infradead.org/~jm

Re: 2.6.20-rc1 sky2 problems (regression?)

2006-12-15 Thread Stephen Hemminger
On Thu, 14 Dec 2006 19:53:45 -0800 Alex Romosan <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > I have a fixed up version of the vendor driver, I'll repackage it tomorrow. > > as per the include file, i ended up replacing all the CHECKSUM_HW with > CHECkSUM_PARTI

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> +#ifdef CONFIG_DEBUG_SLAB >> + /* 82544's work arounds do not play nicely with DEBUG SLAB */ >> + if (adapter->hw.mac_type == e1000_82544) >> + netdev->features &= ~NETIF_F_TSO; >> +#endif > > NAK, same reason as the others Any cha

Re: [PATCH 3/3] chelsio: more receive cleanup

2006-12-15 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : > Francois Romieu <[EMAIL PROTECTED]> wrote: [...] > Why, you can't predict copybreak on off Plain gut feeling. I'd rather spend extra cycles on small packets (whose allocation is already optimized) and keep the normal packets less expensive on a 10Gb/s netw

[PATCH] Marvell Libertas 8388 802.11b/g USB driver

2006-12-15 Thread Marcelo Tosatti
Hi, Marvell released a GPL driver for their 8388 wireless chip for USB interface back in April. The 8388 is the device being used by the OLPC laptop. We have been working on cleaning it up for mainline inclusion. I think the moment for wider review has arrived. Since the diff is pretty large (

Re: [PATCH 3/3] chelsio: more receive cleanup

2006-12-15 Thread Stephen Hemminger
On Fri, 15 Dec 2006 21:10:19 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > [...] > > --- linux-2.6.20-rc1.orig/drivers/net/chelsio/sge.c > > +++ linux-2.6.20-rc1/drivers/net/chelsio/sge.c > [...] > > @@ -1059,37 +1062,33 @@ static void recycle_fl_buf(

Re: [PATCH] p54: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 22:38, Michael Wu wrote: > On Friday 15 December 2006 14:45, Michael Buesch wrote: > > This fixes compilation for the d80211 hwmode API change. > > > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > > > We can't specify modes before device registration now? There wou

[PATCH 1/2] NetLabel: perform input validation earlier on CIPSOv4 DOI add ops

2006-12-15 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> There are a couple of cases where the user input for a CIPSOv4 DOI add operation was not being done soon enough; the result was unexpected behavior which was resulting in oops/panics/lockups on some platforms. This patch moves the existing input validation cod

[PATCH 0/2] A bugfix patchset for NetLabel

2006-12-15 Thread paul . moore
This patch set fixes two bugs that were found recently when adding new CIPSOv4 DOI definitions. These patches are pretty small and have been tested by a few different people on several different platforms. Please apply these for 2.6.20 and they should probably be pushed to the 2.6.19 stable tree

[PATCH 2/2] NetLabel: correctly fill in unused CIPSOv4 level and category mappings

2006-12-15 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Back when the original NetLabel patches were being changed to use Netlink attributes correctly some code was accidentially dropped which set all of the undefined CIPSOv4 level and category mappings to a sentinel value. The result is the mappings data in the ke

Re: [PATCH] p54: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Wu
On Friday 15 December 2006 14:45, Michael Buesch wrote: > This fixes compilation for the d80211 hwmode API change. > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > We can't specify modes before device registration now? There would be less duplicated code here if we could. -Michael Wu pgp

Re: [PATCH] adm8211: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Wu
On Friday 15 December 2006 14:44, Michael Buesch wrote: > This fixes compilation for the d80211 hwmode API change. > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > ACK, looks good to me. -Michael Wu pgpxYbqaiCNCw.pgp Description: PGP signature

Re: [PATCH] smc911x: fix netpoll compilation faliure

2006-12-15 Thread Andrew Morton
On Fri, 15 Dec 2006 16:13:28 +0300 Vitaly Wool <[EMAIL PROTECTED]> wrote: > Hello folks, > > the trivial patch below fixes the compilation failure for smc911x.c when > NET_POLL_CONTROLLER is set. > > drivers/net/smc911x.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Signed-o

Re: [PATCH] Update Prism54 MAINTAINERS entry

2006-12-15 Thread Michael Buesch
Ah, damn crap! On Friday 15 December 2006 21:38, [EMAIL PROTECTED] wrote: > Sorry, this list is for subscribers only. We previously held incoming > mail by non-subscribers for manual approval, but due to the increase > in spam this is no longer feasible. > > If you are seriously attempting to sen

[PATCH] Update Prism54 MAINTAINERS entry

2006-12-15 Thread Michael Buesch
[EMAIL PROTECTED] bounces with SMTP error from remote mailer after RCPT TO:<[EMAIL PROTECTED]>: host mx1.tuxfamily.net [212.85.158.8]: 550 unknown user [EMAIL PROTECTED] seems to be the new mailing list. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-2.6/MAINTAINERS

Re: [PATCH 3/3] chelsio: more receive cleanup

2006-12-15 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > --- linux-2.6.20-rc1.orig/drivers/net/chelsio/sge.c > +++ linux-2.6.20-rc1/drivers/net/chelsio/sge.c [...] > @@ -1059,37 +1062,33 @@ static void recycle_fl_buf(struct freelQ > * threshold and the packet is too big to copy, or (b) the packet should

Re: [Rt2400-devel] [PATCH] rt2x00: Fix PKT_PROBE_RESP breakage

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 20:50, Ivo van Doorn wrote: > Hi, > > On Friday 15 December 2006 20:39, Michael Buesch wrote: > > Fix breakage from removal of PKT_PROBE_RESP. > > Jiri had already send a patch to the netdev list to cover this breakage. > ([PATCH 1/2] rt2x00: fix breakage after pkt_type

Re: [Rt2400-devel] [PATCH] rt2x00: Fix PKT_PROBE_RESP breakage

2006-12-15 Thread Ivo van Doorn
Hi, On Friday 15 December 2006 20:39, Michael Buesch wrote: > Fix breakage from removal of PKT_PROBE_RESP. Jiri had already send a patch to the netdev list to cover this breakage. ([PATCH 1/2] rt2x00: fix breakage after pkt_type field was removed) And I personally favour the patch from Jiri. Ivo

Re: [Rt2400-devel] [PATCH] rt2x00: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Ivo van Doorn
Hi, > This fixes compilation for the d80211 hwmode API change. I haven't had time yet to look closely at more of the benefits of the new hwmode API change, but this patch looks good. Thanks! > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> -

[PATCH] zd1211: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Buesch
This fixes compilation for the d80211 hwmode API change. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: jbenc-dscape/drivers/net/wireless/d80211/zd1211rw/zd_mac.c === --- jbenc-dscape.orig/drivers/net/wireless/d80211/zd121

[PATCH] p54: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Buesch
This fixes compilation for the d80211 hwmode API change. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: jbenc-dscape/drivers/net/wireless/d80211/p54/prism54.h === --- jbenc-dscape.orig/drivers/net/wireless/d80211/p54/prism

[PATCH] adm8211: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Buesch
This fixes compilation for the d80211 hwmode API change. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: jbenc-dscape/drivers/net/wireless/d80211/adm8211/adm8211.c === --- jbenc-dscape.orig/drivers/net/wireless/d80211/adm82

[PATCH] rt2x00: Fix compilation for d80211 hwmode API change

2006-12-15 Thread Michael Buesch
This fixes compilation for the d80211 hwmode API change. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: jbenc-dscape/drivers/net/wireless/d80211/rt2x00/rt2400pci.c === --- jbenc-dscape.orig/drivers/net/wireless/d80211/rt2x

[PATCH] rt2x00: Fix PKT_PROBE_RESP breakage

2006-12-15 Thread Michael Buesch
Fix breakage from removal of PKT_PROBE_RESP. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: jbenc-dscape/drivers/net/wireless/d80211/rt2x00/rt2400pci.c === --- jbenc-dscape.orig/drivers/net/wireless/d80211/rt2x00/rt2400pci

[PATCH 2/3] chelsio: NAPI speed improvement

2006-12-15 Thread Stephen Hemminger
Speedup and cleanup the receive processing by eliminating the mmio read and a lock round trip. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/sge.c | 82 -- 1 file changed, 37 insertions(+), 45 deletions(-) --- linux-2.

[PATCH 0/3] chelsio driver changes

2006-12-15 Thread Stephen Hemminger
One error path bug fix, and a couple of changes to improve receive performance. The performance is now up to 5+ Gbits/sec which is about the limit of the memory/bus on the test systems. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

[PATCH 1/3] chelsio: fix error path

2006-12-15 Thread Stephen Hemminger
Fix handling of allocation failure. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.20-rc1.orig/drivers/net/chelsio/my3126.c +++ linux-2.6.20-rc1/drivers/net/chelsio/my3126.c @@ -170,13 +170,14 @@ static struct cphy *my3126_phy_create(ad { struct cphy *cphy = kzalloc(s

[PATCH 3/3] chelsio: more receive cleanup

2006-12-15 Thread Stephen Hemminger
Cleanup receive processing some more: * do the reserve padding of skb during setup * don't pass constants to get_packet * do smart prefetch of skb * make copybreak a module parameter Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/sge.c | 81 +++

Re: [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-15 Thread Steve Wise
On Fri, 2006-12-15 at 12:06 -0500, Jeff Garzik wrote: > Steve Wise wrote: > > Hey Jeff, > > > > Is this driver in your queue for merging? The Chelsio T3 RDMA driver > > that depends on the T3 Ethernet driver is also ready to be merged. > > > > I was just wondering if its in queue, or if there is

Re: [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-15 Thread Jeff Garzik
Steve Wise wrote: Hey Jeff, Is this driver in your queue for merging? The Chelsio T3 RDMA driver that depends on the T3 Ethernet driver is also ready to be merged. I was just wondering if its in queue, or if there is something else we need to do. I have mainly been waiting for feedback from

Re: [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-15 Thread Steve Wise
Hey Jeff, Is this driver in your queue for merging? The Chelsio T3 RDMA driver that depends on the T3 Ethernet driver is also ready to be merged. I was just wondering if its in queue, or if there is something else we need to do. Thanks, Steve. On Wed, 2006-12-13 at 21:40 -0800, Divy Le Ray w

Re: [patch 13/14] e1000: 3 new driver stats for managability testing

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: 3 new driver stats for managability testing From: Jesse Brandeburg <[EMAIL PROTECTED]> Add 3 extra packet redirect counters for tracking purposes to make sure we can test that all packets arrive properly. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]

Re: [patch 12/14] e1000: Make the copybreak value a module parameter

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: Make the copybreak value a module parameter From: Jesse Brandeburg <[EMAIL PROTECTED]> Allow the user to vary the size that copybreak works. Currently cb is enabled for packets < 256 bytes, but various tests indicate that this should be configurable for sp

Re: [Bridge] Bridge & it's MAC address question

2006-12-15 Thread Lennert Buytenhek
[ dropped subscriber-only openvz.org list ] On Fri, Dec 15, 2006 at 07:52:36AM -0800, Stephen Hemminger wrote: > > > The bridge physical address is the minimum of all the attached devices. > > > This is done because the STP standard requires it. You can reset it > > > to be the same as any of th

Re: [PATCH] netxen: remove private ioctl

2006-12-15 Thread Christoph Hellwig
On Fri, Dec 15, 2006 at 07:57:08AM -0800, Stephen Hemminger wrote: > The netxen driver includes a private ioctl that provides access > to functionality that is already available in other ways. The PCI > layer has application access hooks (see setpci), and the statistics > are available in ethtool/n

Re: [patch 05/14] e1000: Fix Wake-on-Lan with forced gigabit speed

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: Fix Wake-on-Lan with forced gigabit speed From: Jesse Brandeburg <[EMAIL PROTECTED]> If the user has forced gigabit speed, phy power management must be disabled; otherwise the NIC would try to negotiate to a linkspeed of 10/100 mbit on shutdown, which woul

[PATCH] netxen: remove private ioctl

2006-12-15 Thread Stephen Hemminger
The netxen driver includes a private ioctl that provides access to functionality that is already available in other ways. The PCI layer has application access hooks (see setpci), and the statistics are available in ethtool/netstats. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers

Re: [patch 04/14] e1000: consolidate managability enabling/disabling

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: consolidate managability enabling/disabling From: Jesse Brandeburg <[EMAIL PROTECTED]> Several bugs existed in how we handle manageability issues all over the driver. This patch consolidates all the managability release and init code in two single function

Re: [Bridge] Bridge & it's MAC address question

2006-12-15 Thread Stephen Hemminger
On Fri, 15 Dec 2006 14:19:08 +0100 Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > On Mon, Oct 30, 2006 at 07:28:37AM -0800, Stephen Hemminger wrote: > > > > Could somebody explain, why bridge uses minimal MAC of the attached > > > devices? > > > It makes this address instable, variable during br

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 15:06, Jiri Benc wrote: > On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > > Can you also apply the bcm43xx fix for this to your tree? > > I think that should be easiest and prevent long-living breakage. > > It doesn't apply :-( It's probably easy to fix but I

Re: d80211 oops with bcm43xx-d80211

2006-12-15 Thread Johannes Berg
On Fri, 2006-12-15 at 16:23 +0100, Michael Buesch wrote: > It turns out to oops only sometimes for me. > And if, then with some very strange looking oopses. Yeah but that's probably because most of the stacktrace is from whatever was running when the softirq was run... > > the instruction c00303

Re: d80211 oops with bcm43xx-d80211

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 15:56, Johannes Berg wrote: > Turns out I was right, current bcm43xx-d80211 oopses when rmmod'ed in > use... However, it looks like d80211 is to blame. It turns out to oops only sometimes for me. And if, then with some very strange looking oopses. > the instruction c003

Re: [patch 00/14] E1000 bugfix series for 2.6.20

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Hi, this patch series contains critical bugfixes to the e1000 driver for 2.6.20 (and 3 very low intrusive features that help in testing). Without these patches e1000 is totally unusable on my test machine. Didn't Auke just submit these, and have them ACKd/NAKd as approp

d80211 oops with bcm43xx-d80211

2006-12-15 Thread Johannes Berg
Turns out I was right, current bcm43xx-d80211 oopses when rmmod'ed in use... However, it looks like d80211 is to blame. the instruction c003030c is in the middle of tasklet_action and it's a free-after-use type of thing as you can see from accessing 0x6b6b6b73, in fact, the code in question is: c

[PATCH] d80211: add missing \n in skb queue warning

2006-12-15 Thread Johannes Berg
This just adds a missing \n I noticed when I got the warning (see my other mail) Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- wireless-dev.orig/net/d80211/ieee80211.c2006-12-14 20:14:50.150611855 +0100 +++ wireless-dev/net/d80211/ieee80211.c 2006-12-14 20:14:55.118611855 +0100 @@ -47

Re: [PATCH 4/6] d80211: add IEEE802.11e/WMM Traffic Stream (TS) Management support

2006-12-15 Thread Johannes Berg
Some comments... In these cases > + init_timer(&ifsta->admit_timer); > + ifsta->admit_timer.data = (unsigned long) dev; > + ifsta->admit_timer.function = ieee80211_admit_refresh; > +void ieee80211_send_addts(struct net_device *dev, > +

Re: [patch 14/14] e1000: No-delay link detection at interface up

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: ACK, though you can also just schedule the timer to run immediately, or even run it yourself inside spin_lock_bh() sure but this is very simple, clean and obvious ;) Hence the ACK... Jeff - To unsubscribe from this list: send the line "u

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: Needs to use an "i have broken stats" feature flag, rather than adding yet another mac_type test into the code. This testing of MAC type rather than feature flags is a major e1000 problem, and it bloats the driver quite a bit. Intel has been told fo

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Arjan van de Ven
Jeff Garzik wrote: Needs to use an "i have broken stats" feature flag, rather than adding yet another mac_type test into the code. This testing of MAC type rather than feature flags is a major e1000 problem, and it bloats the driver quite a bit. Intel has been told for /months/ this is a prob

Re: [patch 14/14] e1000: No-delay link detection at interface up

2006-12-15 Thread Arjan van de Ven
Jeff Garzik wrote: ACK, though you can also just schedule the timer to run immediately, or even run it yourself inside spin_lock_bh() sure but this is very simple, clean and obvious ;) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

Re: [patch 14/14] e1000: No-delay link detection at interface up

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: No-delay link detection at interface up From: Jesse Brandeburg <[EMAIL PROTECTED]> Currently after an interface up, the link state is detected 2 seconds later when the first watchdog timer runs. This patch changes that by triggering the hardware to generat

Re: [patch 13/14] e1000: 3 new driver stats for managability testing

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: 3 new driver stats for managability testing From: Jesse Brandeburg <[EMAIL PROTECTED]> Add 3 extra packet redirect counters for tracking purposes to make sure we can test that all packets arrive properly. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]

Re: [patch 12/14] e1000: Make the copybreak value a module parameter

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: Make the copybreak value a module parameter From: Jesse Brandeburg <[EMAIL PROTECTED]> Allow the user to vary the size that copybreak works. Currently cb is enabled for packets < 256 bytes, but various tests indicate that this should be configurable for sp

Re: [patch 10/14] e1000: narrow down the scope of the tipg timer tweak

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: narrow down the scope of the tipg timer tweak From: Jesse Brandeburg <[EMAIL PROTECTED]> the driver has (ancient) code for messing with TIPG from the 82542 days. Unfortunately this code was running on our current adapters and setting TIPG for fiber to be +

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 15:06, Jiri Benc wrote: > On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > > Can you also apply the bcm43xx fix for this to your tree? > > I think that should be easiest and prevent long-living breakage. > > It doesn't apply :-( It's probably easy to fix but I

Re: [patch 07/14] e1000: workaround for the ESB2 NIC RX unit issue

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: workaround for the ESB2 NIC RX unit issue From: Jesse Brandeburg <[EMAIL PROTECTED]> In rare occasions, ESB2 systems would end up started without the RX unit being turned on. Add a check that runs post-init to work around this issue. Signed-off-by: Jesse

Re: [patch 09/14] e1000: fix ethtool reported bus type for older adapters

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: fix ethtool reported bus type for older adapters From: Jeff Kirsher <[EMAIL PROTECTED]> For older adapters we know that they are of the PCI bus type, so we can just set this. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL

Re: [patch 04/14] e1000: consolidate managability enabling/disabling

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: +static void +e1000_init_manageability(struct e1000_adapter *adapter) +{ + if (adapter->en_mng_pt) { + uint32_t manc2h = E1000_READ_REG(&adapter->hw, MANC2H); + uint32_t manc = E1000_READ_REG(&adapter->hw, MANC); + + /* disab

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: disable TSO on the 82544 with slab debugging From: Jesse Brandeburg <[EMAIL PROTECTED]> CONFIG_DEBUG_SLAB changes alignments of the data structures the slab allocators return. These break certain workarounds for TSO on the 82544. Since DEBUG_SLAB is relati

Re: [patch 05/14] e1000: Fix Wake-on-Lan with forced gigabit speed

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: Fix Wake-on-Lan with forced gigabit speed From: Jesse Brandeburg <[EMAIL PROTECTED]> If the user has forced gigabit speed, phy power management must be disabled; otherwise the NIC would try to negotiate to a linkspeed of 10/100 mbit on shutdown, which woul

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke

Re: [patch 00/14] E1000 bugfix series for 2.6.20

2006-12-15 Thread Arjan van de Ven
Jeff Garzik wrote: They didn't get applied because the patches need the revisions I requested. the patches I posted are cleaned up subset... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [patch 00/14] E1000 bugfix series for 2.6.20

2006-12-15 Thread Arjan van de Ven
Jeff Garzik wrote: Arjan van de Ven wrote: Hi, this patch series contains critical bugfixes to the e1000 driver for 2.6.20 (and 3 very low intrusive features that help in testing). Without these patches e1000 is totally unusable on my test machine. Didn't Auke just submit these, and have them

Re: [patch 00/14] E1000 bugfix series for 2.6.20

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: Arjan van de Ven wrote: Hi, this patch series contains critical bugfixes to the e1000 driver for 2.6.20 (and 3 very low intrusive features that help in testing). Without these patches e1000 is totally unusable on my test machine. Didn't Auke just su

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Jiri Benc
On Fri, 15 Dec 2006 14:54:55 +0100, Michael Buesch wrote: > Can you also apply the bcm43xx fix for this to your tree? > I think that should be easiest and prevent long-living breakage. It doesn't apply :-( It's probably easy to fix but I'd rather leave it to you to not make any damage. Thanks,

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 14:48, Jiri Benc wrote: > On Thu, 14 Dec 2006 19:20:11 +0100, Michael Buesch wrote: > > This turns the PHY-modes list into a linked list. > > The advantage is that drivers can add modes dynamically, as they probe > > them and don't have to settle to a given arraysize at t

Re: [PATCH 3/6] d80211: fix classify_1d() priority selection

2006-12-15 Thread Jiri Benc
On Thu, 14 Dec 2006 12:02:27 +0800, Zhu Yi wrote: > I don't see any reason why packets with DSCP=0x40 should have lower IEEE > 802.1D priority than packets with DSCP=0x20. Spare > Background. No? Applied to my tree, thanks. I also applied the following patch on top of it: -- Subject: [PATCH] d80

Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list

2006-12-15 Thread Jiri Benc
On Thu, 14 Dec 2006 19:20:11 +0100, Michael Buesch wrote: > This turns the PHY-modes list into a linked list. > The advantage is that drivers can add modes dynamically, as they probe > them and don't have to settle to a given arraysize at the beginning > of probing. ACK. > @@ -198,8 +200,7 @@ sta

Re: Bridge & it's MAC address question

2006-12-15 Thread Lennert Buytenhek
On Mon, Oct 30, 2006 at 07:28:37AM -0800, Stephen Hemminger wrote: > > Could somebody explain, why bridge uses minimal MAC of the attached devices? > > It makes this address instable, variable during bridge life-cycle, which is > > not good for DHCP. For example, I want to attach multiple virtual

[PATCH] smc911x: fix netpoll compilation faliure

2006-12-15 Thread Vitaly Wool
Hello folks, the trivial patch below fixes the compilation failure for smc911x.c when NET_POLL_CONTROLLER is set. drivers/net/smc911x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> diff --git a/drivers/net/smc911x.c b/drivers/net/smc9

EEPROM infrastructure (was: [PATCH] eeprom_93cx6: Add write support)

2006-12-15 Thread Ingo Oeser
Lennart Sorensen schrieb: > On Wed, Dec 13, 2006 at 07:56:50PM +0100, Ivo van Doorn wrote: > > This patch addes support for writing to the eeprom, > > this also moves some duplicate code into seperate functions. > > > > Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> > > Thank you. I will have a

[PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

2006-12-15 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long range dependency and self-similarity of cross-traffic. kernel space: The delay, drop, duplication and corruption values are readout in user space and sent to kernel space via configfs. The userspace process will "hang on write" un

[PATCH 2.6.18 0/2] LARTC: trace control for netem

2006-12-15 Thread Rainer Baumann
Hi Stephen As discussed yesterday, here our patches to integrate trace control into netem Trace Control for Netem: Emulate network properties such as long range dependency and self-similarity of cross-traffic. A new option (trace) has been added to the netem command. If the trace option is u

[PATCH 2.6.18 1/2] LARTC: trace control for netem: userspace

2006-12-15 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long range dependency and self-similarity of cross-traffic. user space (iproute2): The directory tc/netem was split in two parts, one containing the original distribution tables and the other the tools to generate trace files as well as

[patch 07/14] e1000: workaround for the ESB2 NIC RX unit issue

2006-12-15 Thread Arjan van de Ven
Subject: e1000: workaround for the ESB2 NIC RX unit issue From: Jesse Brandeburg <[EMAIL PROTECTED]> In rare occasions, ESB2 systems would end up started without the RX unit being turned on. Add a check that runs post-init to work around this issue. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECT

[patch 02/14] e1000: dynamic itr: take TSO and jumbo into account

2006-12-15 Thread Arjan van de Ven
Subject: e1000: dynamic itr: take TSO and jumbo into account From: Jesse Brandeburg <[EMAIL PROTECTED]> The dynamic interrupt rate control patches omitted proper counting for jumbo's and TSO resulting in suboptimal interrupt mitigation strategies. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED

[patch 01/14] e1000: The user-supplied itr setting needs the lower 2 bits masked off

2006-12-15 Thread Arjan van de Ven
Subject: e1000: The user-supplied itr setting needs the lower 2 bits masked off From: Jesse Brandeburg <[EMAIL PROTECTED]> The lower 2 bits of a user-supplied itr setting (via ethtool) need to be masked off: These lower two bits are used as control bits. Signed-off-by: Jesse Brandeburg <[EMAIL PR

[patch 11/14] e1000: Fix PBA allocation calculations

2006-12-15 Thread Arjan van de Ven
Subject: e1000: Fix PBA allocation calculations From: Bruce Allan <[EMAIL PROTECTED]> Assign the PBA to be large enough to contain at least 2 jumbo frames on all adapters. This dramatically increases performance on several adapters and fixes TX performance degradation issues where the PBA was misa

[patch 10/14] e1000: narrow down the scope of the tipg timer tweak

2006-12-15 Thread Arjan van de Ven
Subject: e1000: narrow down the scope of the tipg timer tweak From: Jesse Brandeburg <[EMAIL PROTECTED]> the driver has (ancient) code for messing with TIPG from the 82542 days. Unfortunately this code was running on our current adapters and setting TIPG for fiber to be +1 over the copper value.

[patch 05/14] e1000: Fix Wake-on-Lan with forced gigabit speed

2006-12-15 Thread Arjan van de Ven
Subject: e1000: Fix Wake-on-Lan with forced gigabit speed From: Jesse Brandeburg <[EMAIL PROTECTED]> If the user has forced gigabit speed, phy power management must be disabled; otherwise the NIC would try to negotiate to a linkspeed of 10/100 mbit on shutdown, which would lead to a total loss of

[patch 14/14] e1000: No-delay link detection at interface up

2006-12-15 Thread Arjan van de Ven
Subject: e1000: No-delay link detection at interface up From: Jesse Brandeburg <[EMAIL PROTECTED]> Currently after an interface up, the link state is detected 2 seconds later when the first watchdog timer runs. This patch changes that by triggering the hardware to generate a link-change interrupt

[patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Arjan van de Ven
Subject: e1000: disable TSO on the 82544 with slab debugging From: Jesse Brandeburg <[EMAIL PROTECTED]> CONFIG_DEBUG_SLAB changes alignments of the data structures the slab allocators return. These break certain workarounds for TSO on the 82544. Since DEBUG_SLAB is relatively rare and not used for

[patch 12/14] e1000: Make the copybreak value a module parameter

2006-12-15 Thread Arjan van de Ven
Subject: e1000: Make the copybreak value a module parameter From: Jesse Brandeburg <[EMAIL PROTECTED]> Allow the user to vary the size that copybreak works. Currently cb is enabled for packets < 256 bytes, but various tests indicate that this should be configurable for specific use cases. In addit

[patch 04/14] e1000: consolidate managability enabling/disabling

2006-12-15 Thread Arjan van de Ven
Subject: e1000: consolidate managability enabling/disabling From: Jesse Brandeburg <[EMAIL PROTECTED]> Several bugs existed in how we handle manageability issues all over the driver. This patch consolidates all the managability release and init code in two single functions and call them from appro

[patch 13/14] e1000: 3 new driver stats for managability testing

2006-12-15 Thread Arjan van de Ven
Subject: e1000: 3 new driver stats for managability testing From: Jesse Brandeburg <[EMAIL PROTECTED]> Add 3 extra packet redirect counters for tracking purposes to make sure we can test that all packets arrive properly. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok

[patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Arjan van de Ven
Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> S

[patch 00/14] E1000 bugfix series for 2.6.20

2006-12-15 Thread Arjan van de Ven
Hi, this patch series contains critical bugfixes to the e1000 driver for 2.6.20 (and 3 very low intrusive features that help in testing). Without these patches e1000 is totally unusable on my test machine. Greetings, Arjan van de Ven - To unsubscribe from this list: send the line "unsubscribe

  1   2   >