Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-08 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Thu, 9 Nov 2006 07:22:16 + > I haven't touch that argument yet; if there's an agreement as to what should > we switch to, I'll do that. So... does everyone agree that u32 is the way > to go? I definitely do. - To unsubscribe from this list: send the li

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Eric Dumazet
Eric Dumazet a écrit : Davide Libenzi a écrit : Lost forever means? If there are more processes watching some fd (external events), they all get their own copy of the events in their own private epoll fd. It's not that we "steal" things out of the kernel, is not a 1:1 producer/consumer thing (

Re: e1000 driver 2.6.18 - how to waste processor cycles

2006-11-08 Thread Jeffrey V. Merkey
Jesse Brandeburg wrote: included netdev... On 11/8/06, Jeff V. Merkey <[EMAIL PROTECTED]> wrote: Is there a good reason the skb refill routine in e1000_alloc_rx_buffers needs to go and touch and remap skb memory on already loaded descriptors/ This seems extremely wasteful of processor cycle

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Eric Dumazet
Davide Libenzi a écrit : On Thu, 9 Nov 2006, Eric Dumazet wrote: Davide Libenzi a ?crit : I don't care about both ways, but sys_poll() does the same thing epoll does right now, so I would not change epoll behaviour. Sure poll() cannot return a partial count, since its return value is : On s

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-08 Thread Al Viro
On Wed, Nov 08, 2006 at 11:00:59PM -0800, David Miller wrote: > From: "Chen, Kenneth W" <[EMAIL PROTECTED]> > Date: Wed, 8 Nov 2006 18:02:06 -0800 > > > The generic version of csum_ipv6_magic has the len argument declared as > > __u16, while most arch dependent version declare it as __u32. After

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread James Morris
On Thu, 9 Nov 2006, Paul Moore wrote: > It sounds like you have an idea of how you would like to see this implemented, > can you give me a rough outline? Is this the partitioned SECMARK field you > talked about earlier? No, just the fact that you are in the same kernel address space and can rea

Re: [DECnet] Don't clear memory twice.

2006-11-08 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Wed, 8 Nov 2006 15:45:07 + > When dn_neigh.c was converted from kmalloc to kzalloc in commit > 0da974f4f303a6842516b764507e3c0a03f41e5a it was missed that > dn_neigh_seq_open was actually clearing the allocation twice was > missed. > > Signed-off-b

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-08 Thread David Miller
From: "Chen, Kenneth W" <[EMAIL PROTECTED]> Date: Wed, 8 Nov 2006 18:02:06 -0800 > The generic version of csum_ipv6_magic has the len argument declared as > __u16, while most arch dependent version declare it as __u32. After > looking at the call site of this function, I come up to a conclusion >

Re: [patch 9/9] net: uninline xfrm_selector_match()

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:10 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > Six callsites, huge. > > Cc: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied, thanks Andrew. - To unsubscribe from this list: send

Re: [patch 4/9] lockdep: annotate sk_lock nesting in AF_BLUETOOTH

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:05 -0800 > From: Peter Zijlstra <[EMAIL PROTECTED]> > > = > [ INFO: possible recursive locking detected ] > 2.6.18-1.2726.fc6 #1 > - > hidd/2271 is trying t

Re: [patch 7/9] rfcomm endianness annotations

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:09 -0800 > From: Al Viro <[EMAIL PROTECTED]> > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> This one is in my net-2.6.20 GIT tree already. - To

Re: [patch 8/9] rfcomm endianness bug: param_mask is little-endian on the wire

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:10 -0800 > From: Al Viro <[EMAIL PROTECTED]> > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Also already in my net-2.6.20 tree. - To unsubscribe

Re: [patch 5/9] bnep endianness bug: filtering by packet type

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:07 -0800 > From: Al Viro <[EMAIL PROTECTED]> > > <= and => don't work well on net-endian... > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Also

Re: [patch 6/9] bnep endianness annotations

2006-11-08 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 08 Nov 2006 19:51:08 -0800 > From: Al Viro <[EMAIL PROTECTED]> > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Also already in my net-2.6.20 tree - To unsubscribe

Re: [PATCH 0/3] labeled-ipsec: Repost patchset with updates [Originally: mlsxfrm: Various Fixes]

2006-11-08 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 9 Nov 2006 01:30:05 -0500 (EST) > I think this should be aimed at 2.6.20, because we are at the last or > second-last -rc currently, and I don't think these fixes are urgent enough > to justify the risk at this stage. Also, I think this code nee

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
James Morris wrote: > On Wed, 8 Nov 2006, Paul Moore wrote: > >>James Morris wrote: >> >>>On Wed, 8 Nov 2006, Paul Moore wrote: >>> 1. Functionality is available right now, no additional kernel changes needed 2. No special handling for localhost, I tend to like the idea of having consi

Re: [PATCH 0/3] labeled-ipsec: Repost patchset with updates [Originally: mlsxfrm: Various Fixes]

2006-11-08 Thread James Morris
On Wed, 8 Nov 2006, Venkat Yekkirala wrote: > This patchset is against davem's net-2.6.git. Please apply to 2.6.19. > > The following are the changes since the previous post of this patchset: > > 1. Separate BUG_ON usage per Eric's suggestion. > > 2. Replace security_sid_compare with a simple s

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread James Morris
On Wed, 8 Nov 2006, Paul Moore wrote: > James Morris wrote: > > On Wed, 8 Nov 2006, Paul Moore wrote: > > > >>1. Functionality is available right now, no additional kernel changes needed > >>2. No special handling for localhost, I tend to like the idea of having > >>consistent behavior for all ad

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
James Morris wrote: > On Wed, 8 Nov 2006, Paul Moore wrote: > >>1. Functionality is available right now, no additional kernel changes needed >>2. No special handling for localhost, I tend to like the idea of having >>consistent behavior for all addresses/interfaces > > I don't agree. SO_PEERSEC

Re: New laptop - problems with linux

2006-11-08 Thread Tejun Heo
Stephen Clark wrote: Thanks I have that working - I am now struggling with the disk being slower than molasses ( high priority, 1.xx mb/sec ) Add 'combined_mode=libata' to kernel parameter and see what happens. This should make libata take care of all ATA ports and your harddisks will appear

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread James Morris
On Wed, 8 Nov 2006, Paul Moore wrote: > 1. Functionality is available right now, no additional kernel changes needed > 2. No special handling for localhost, I tend to like the idea of having > consistent behavior for all addresses/interfaces I don't agree. SO_PEERSEC should always just work for

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
Venkat Yekkirala wrote: >>>Fix SO_PEERSEC for tcp sockets to return the security context of >>>the peer (as represented by the SA from the peer) as opposed to the >>>SA used by the local/source socket. >> >>What about the case of a localhost TCP connection not using >>xfrm labeling? >> >>Joe Nall r

[patch 9/9] net: uninline xfrm_selector_match()

2006-11-08 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> Six callsites, huge. Cc: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/net/xfrm.h | 36 ++-- net/xfrm/xfrm_policy.c | 34 ++

[patch 3/9] iPhase: 64bit cleanup

2006-11-08 Thread akpm
From: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/atm/Kconfig |2 +- drivers/atm/iphase.c | 23 ++- 2 files changed, 11 insertions(+), 14 deletions(-) diff -puN drivers/atm/Kconf

[patch 2/9] com20020 build fix

2006-11-08 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> com20020.c needs to export functions if either of the ISA or PCI modules are built as loadable modules. Or they could always be exported. WARNING: "com20020_found" [drivers/net/arcnet/com20020-pci.ko] undefined! WARNING: "com20020_check" [drivers/net/arcnet

[patch 1/9] bonding: lockdep annotation

2006-11-08 Thread akpm
From: Peter Zijlstra <[EMAIL PROTECTED]> = [ INFO: possible recursive locking detected ] 2.6.17-1.2600.fc6 #1 - ifconfig/2411 is trying to acquire lock: (&dev->_xmit_lock){-...}, at: [] dev_mc_add+0x45/0x15f

[patch 8/9] rfcomm endianness bug: param_mask is little-endian on the wire

2006-11-08 Thread akpm
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/bluetooth/rfcomm/core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff -puN net/blu

[patch 7/9] rfcomm endianness annotations

2006-11-08 Thread akpm
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/net/bluetooth/rfcomm.h |4 ++-- net/bluetooth/rfcomm/core.c|2 +- 2 files changed, 3 insertions(+),

[patch 5/9] bnep endianness bug: filtering by packet type

2006-11-08 Thread akpm
From: Al Viro <[EMAIL PROTECTED]> <= and => don't work well on net-endian... Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/bluetooth/bnep/core.c | 16 net/bluetooth/bnep/netd

[patch 6/9] bnep endianness annotations

2006-11-08 Thread akpm
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/bluetooth/bnep/bnep.h |4 ++-- net/bluetooth/bnep/core.c | 12 ++-- 2 files changed, 8 insertions(+),

[patch 4/9] lockdep: annotate sk_lock nesting in AF_BLUETOOTH

2006-11-08 Thread akpm
From: Peter Zijlstra <[EMAIL PROTECTED]> = [ INFO: possible recursive locking detected ] 2.6.18-1.2726.fc6 #1 - hidd/2271 is trying to acquire lock: (sk_lock-AF_BLUETOOTH){--..}, at: [] bt_accept_dequeue+0x26/

[patch 1/5] 8139too: force media setting cleanup

2006-11-08 Thread akpm
From: Bernard Lee <[EMAIL PROTECTED]> Setting bit 4 & 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 & 5 to take effect. The

[patch 5/5] drivers cris: return on NULL dev_alloc_skb()

2006-11-08 Thread akpm
From: David Rientjes <[EMAIL PROTECTED]> If the next descriptor array entry cannot be allocated by dev_alloc_skb(), return immediately so it is not dereferenced later. We cannot register the device with a partial descriptor list. Cc: Mikael Starvik <[EMAIL PROTECTED]> Signed-off-by: David Rientj

[patch 3/5] sundance: solve host error problem in low performance embedded system when continune down and up

2006-11-08 Thread akpm
From: Jesse Huang <[EMAIL PROTECTED]> Solve host error problem in low performance embedded system when continune down and up. It will cause IP100A DMA TargetAbort. So we need more safe process to up and down IP100A with wait hardware completely stop and software cur_tx/ dirty_tx/cur_task/last_tx

Re: e1000 driver 2.6.18 - how to waste processor cycles

2006-11-08 Thread David Miller
From: "Jesse Brandeburg" <[EMAIL PROTECTED]> Date: Wed, 8 Nov 2006 17:01:44 -0800 > If you can show that it is faster to use pci_dma_sync_single_for_cpu > and friends I'd be glad to take a patch. The problem is if you don't recycle the buffer and really unmap, you'll flush twice. That can potent

Re: e1000: include for IA64

2006-11-08 Thread Auke Kok
Chen, Kenneth W wrote: Chen, Kenneth wrote on Wednesday, November 08, 2006 4:10 PM Auke Kok wrote on Wednesday, November 08, 2006 9:49 AM Of course, someone really should come up with an asm version for ia64 of the missing function ;) Sure, absolutely. Here is an implementation for ia64. Tes

[patch] fix up generic csum_ipv6_magic function prototype

2006-11-08 Thread Chen, Kenneth W
The generic version of csum_ipv6_magic has the len argument declared as __u16, while most arch dependent version declare it as __u32. After looking at the call site of this function, I come up to a conclusion that __u32 is a better match with the actual usage. Hence, patch to change argument type

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Rick Jones
On Wed, 2006-11-08 at 23:10 +0100, Olaf Kirch wrote: > What I'm saying though is that it doesn't rhyme with what I've seen of > Volanomark - we ran 2.6.16 on a 4p Intel box for instance and it didn't > come close to saturating a Gigabit pipe before it maxed out on CPU load. That actually supports

Re: e1000 driver 2.6.18 - how to waste processor cycles

2006-11-08 Thread Jesse Brandeburg
included netdev... On 11/8/06, Jeff V. Merkey <[EMAIL PROTECTED]> wrote: Is there a good reason the skb refill routine in e1000_alloc_rx_buffers needs to go and touch and remap skb memory on already loaded descriptors/ This seems extremely wasteful of processor cycles when refilling the ring b

RE: e1000: include for IA64

2006-11-08 Thread Chen, Kenneth W
Chen, Kenneth wrote on Wednesday, November 08, 2006 4:10 PM > Auke Kok wrote on Wednesday, November 08, 2006 9:49 AM > > Of course, someone really should come up with an asm version for ia64 of the > > missing function ;) > > Sure, absolutely. Here is an implementation for ia64. Tested heavily.

RE: e1000: include for IA64

2006-11-08 Thread Chen, Kenneth W
Auke Kok wrote on Wednesday, November 08, 2006 9:49 AM > Of course, someone really should come up with an asm version for ia64 of the > missing function ;) Sure, absolutely. Here is an implementation for ia64. Tested heavily. Tony, please merge. - Ken [patch] implement csum_ipv6_magic for i

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Davide Libenzi
On Thu, 9 Nov 2006, Eric Dumazet wrote: > Davide Libenzi a ?crit : > > > > I don't care about both ways, but sys_poll() does the same thing epoll does > > right now, so I would not change epoll behaviour. > > > > Sure poll() cannot return a partial count, since its return value is : > > On suc

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Tim Chen
On Wed, 2006-11-08 at 15:00 -0800, Stephen Hemminger wrote: > > Optimizing for loopback is perversion; perversion can be fun but it gets > to be a obsession then it's sick. > It is not my intention to optimize for this case, but rather to detect change in kernel behavior. That's why in my orig

[PATCH 1/3] labeled-ipsec: Various fixes

2006-11-08 Thread Venkat Yekkirala
Since the upstreaming of the mlsxfrm modification a few months back, testing has resulted in the identification of the following issues/bugs that are resolved in this patch set. 1. Fix the security context used in the IKE negotiation to be the context of the socket as opposed to the context of

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Eric Dumazet
Davide Libenzi a écrit : On Wed, 8 Nov 2006, Andrew Morton wrote: On Wed, 8 Nov 2006 15:51:13 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: [PATCH] eventpoll : In case a fault occurs during copy_to_user(), we should report the count of events that were successfully copied into user space, in

[PATCH 2/3] labeled-ipsec: Return correct context for SO_PEERSEC

2006-11-08 Thread Venkat Yekkirala
Fix SO_PEERSEC for tcp sockets to return the security context of the peer (as represented by the SA from the peer) as opposed to the SA used by the local/source socket. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/security.h| 14 ++ include/net/request_s

[PATCH 3/3] labeled-ipsec: Fix SA selection semantics

2006-11-08 Thread Venkat Yekkirala
Fix the selection of an SA for an outgoing packet to be at the same context as the originating socket/flow. This eliminates the SELinux policy's ability to use/sendto SAs with contexts other than the socket's. With this patch applied, the SELinux policy will require one or more of the following fo

[PATCH 0/3] labeled-ipsec: Repost patchset with updates [Originally: mlsxfrm: Various Fixes]

2006-11-08 Thread Venkat Yekkirala
This patchset is against davem's net-2.6.git. Please apply to 2.6.19. The following are the changes since the previous post of this patchset: 1. Separate BUG_ON usage per Eric's suggestion. 2. Replace security_sid_compare with a simple sid compare check per a suggestion from Paul/Stephen. - T

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Stephen Hemminger
On Wed, 8 Nov 2006 23:10:28 +0100 Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Wed, Nov 08, 2006 at 10:38:52AM -0800, Tim Chen wrote: > > The patch in question affects purely TCP and not the scheduler. I don't > > I know. > > > think the scheduler has anything to do with the slowdown seen after >

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Stephen Hemminger
On Wed, 08 Nov 2006 14:07:32 -0800 Tim Chen <[EMAIL PROTECTED]> wrote: > On Wed, 2006-11-08 at 23:10 +0100, Olaf Kirch wrote: > > > > > In fixing performance issues, the most obvious explanation isn't always > > the right one. It's quite possible you're right, sure. > > > > What I'm saying thou

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Tim Chen
On Wed, 2006-11-08 at 23:10 +0100, Olaf Kirch wrote: > > In fixing performance issues, the most obvious explanation isn't always > the right one. It's quite possible you're right, sure. > > What I'm saying though is that it doesn't rhyme with what I've seen of > Volanomark - we ran 2.6.16 on a 4

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Davide Libenzi
On Wed, 8 Nov 2006, Andrew Morton wrote: > On Wed, 8 Nov 2006 15:51:13 +0100 > Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > [PATCH] eventpoll : In case a fault occurs during copy_to_user(), we should > > report the count of events that were successfully copied into user space, > > instead of E

Re: why do we mangle checksums for v6 ICMP?

2006-11-08 Thread Al Viro
On Wed, Nov 08, 2006 at 10:13:32PM +, Al Viro wrote: > AFAICS, the rules are: > > (1) checksum is 16-bit one's complement of the one's complement sum of > relevant 16bit words. > > (2) for v4 UDP all-zeroes has special meaning - no checksum; if you get > it from (1), send all-ones inste

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Olaf Kirch
On Wed, Nov 08, 2006 at 10:38:52AM -0800, Tim Chen wrote: > The patch in question affects purely TCP and not the scheduler. I don't I know. > think the scheduler has anything to do with the slowdown seen after > the patch is applied. In fixing performance issues, the most obvious explanation is

HTB warnings

2006-11-08 Thread Ismail Donmez
Hi all, I use sabishape[1] to shape my traffic that I would normally do, sabishape -i eth1 -u 40 -d 240 for my 256/64 ADSL line , but recently in dmesg I got following warnings: HTB: quantum of class 10031 is small. Consider r2q change. HTB: quantum of class 10032 is small. Consider r2q change.

why do we mangle checksums for v6 ICMP?

2006-11-08 Thread Al Viro
AFAICS, the rules are: (1) checksum is 16-bit one's complement of the one's complement sum of relevant 16bit words. (2) for v4 UDP all-zeroes has special meaning - no checksum; if you get it from (1), send all-ones instead. (3) for v6 UDP we have the same remapping as in (2), but all-zer

[PATCH] glibc: getaddrinfo() dest. addr. selection bugfix

2006-11-08 Thread Sridhar Samudrala
While testing the default address selection support in linux, i found some issues in the getaddrinfo() implementation of Rule 3 and Rule 7 in the destination address selection process as described in RFC3484. Rule 3: Avoid deprecated addresses. --- This one turned

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Andrew Morton
On Wed, 8 Nov 2006 15:51:13 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > [PATCH] eventpoll : In case a fault occurs during copy_to_user(), we should > report the count of events that were successfully copied into user space, > instead of EFAULT. That would be consistent with behavior of read/

RE: [PATCH 3/3] mlsxfrm: Various fixes

2006-11-08 Thread Stephen Smalley
On Wed, 2006-11-08 at 13:17 -0600, Venkat Yekkirala wrote: > > > > Not sure > > > > though when > > > > that would apply here, > > > > > > It could apply to xfrms if they happen to be using the context > > > represented by any of the initial SIDs. > > > > Which would happen when? > > If one were

[RFC] d80211 naming convention

2006-11-08 Thread James Ketrenos
The discussion on another thread about ieee80211_local brought to mind a discussion from a while ago about shortening the prefix 'ieee80211' used in structures, defines, variables, function names, etc. Are people still interested in changing that name to something else? Would switching from using

Re: New laptop - problems with linux

2006-11-08 Thread Stephen Clark
Jesper Juhl wrote: On 08/11/06, Stephen Clark <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: On Wed, 08 Nov 2006 14:39:53 -0500 Stephen Clark <[EMAIL PROTECTED]> wrote: 03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG Network Connection (rev 02)

Re: New laptop - problems with linux

2006-11-08 Thread Jesper Juhl
On 08/11/06, Stephen Clark <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: >On Wed, 08 Nov 2006 14:39:53 -0500 >Stephen Clark <[EMAIL PROTECTED]> wrote: > > >>03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG >>Network Connection (rev 02) >>Subsystem: Intel Corporati

Re: New laptop - problems with linux

2006-11-08 Thread Stephen Hemminger
On Wed, 08 Nov 2006 14:39:53 -0500 Stephen Clark <[EMAIL PROTECTED]> wrote: > Francois Romieu wrote: > > >Stephen Clark <[EMAIL PROTECTED]> : > >[...] > > > > > >>No it is not loaded - i did a modprobe on it and it loaded but still no > >>ethx device. > >> > >> > > > >Send complete 'dmesg'

Re: Please pull 'upstream' branch of wireless-2.6

2006-11-08 Thread John W. Linville
On Tue, Nov 07, 2006 at 11:59:27PM -0500, John W. Linville wrote: > The following changes since commit d4f748365129ccfc9dadf6fb14331e45e33cc4ed: > John W. Linville: > Merge branch 'upstream-fixes' into upstream > > are found in the git repository at: > > git://git.kernel.org/pub/scm/l

General network driver suspend/resume (was e1000 carrier related)

2006-11-08 Thread Stephen Hemminger
On Wed, 8 Nov 2006 13:04:07 +0100 Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > >>This behavior differs from every other network card, and is also present > > >>in the > > >>7.3* version of the driver from sourceforge. > > >> > > >>I think the e1000 should try to raise the link during the

Re: Re. Please pull 'upstream' branch of wireless-2.6

2006-11-08 Thread John W. Linville
On Wed, Nov 08, 2006 at 06:27:54PM +0100, Roger While wrote: > John, you just broke a considerable number of prism54 users. > It is NOT an error if the MWI set fails. This is just a > performance tweak and has NO effect on the driver working. Yeah, looks like I was a bit overzealous on the warning

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Arjan van de Ven
> However, Volanomark is just a benchmark to alert us to changes. > If in real applications with small segment, this patch is > needed to fix congestion window adjustment as Dave pointed > out, and impact on bandwidth not as important, so be it. > > Tim if we can get the best of both worlds

Re: New laptop - problems with linux

2006-11-08 Thread Stephen Clark
Francois Romieu wrote: Stephen Clark <[EMAIL PROTECTED]> : [...] No it is not loaded - i did a modprobe on it and it loaded but still no ethx device. Send complete 'dmesg' and 'lspci -vvx' (please Cc: netdev@vger.kernel.org) lspci and dmesg attached below: Thanks, anything else I

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Tim Chen
On Wed, 2006-11-08 at 17:29 +0100, Olaf Kirch wrote: > Is it proven that the number of ACKs actually cause bandwidth problems? > I found Volanomark to exercise the scheduler more than anything else, > so maybe the slowdown, while triggered by an increased number of ACKs, > is caused by something e

RE: [PATCH 3/3] mlsxfrm: Various fixes

2006-11-08 Thread Venkat Yekkirala
> > > Not sure > > > though when > > > that would apply here, > > > > It could apply to xfrms if they happen to be using the context > > represented by any of the initial SIDs. > > Which would happen when? If one were attempting to use a context pertaining to the unlabeled init sid in the SPD and

Re: e1000: include for IA64

2006-11-08 Thread Andrew Morton
On Wed, 08 Nov 2006 09:48:35 -0800 Auke Kok <[EMAIL PROTECTED]> wrote: > Here's a slightly better patch to fix ia64 not building atm. fsvo "better". > Jeff, please apply this to netdev-2.6#upstream instead of akpm's patch that I > acked earlier. > > Of course, someone really should come up wit

Re: SKB BUG: Invalid truesize, current git

2006-11-08 Thread Benjamin LaHaise
On Tue, Nov 07, 2006 at 02:57:24PM -0800, David Miller wrote: > > Since pskb_copy tacks on the non-linear bits from the original > > skb, it needs to count them in the truesize field of the new skb. > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Applied, thanks Herbert. This seems to

e1000: include for IA64

2006-11-08 Thread Auke Kok
Here's a slightly better patch to fix ia64 not building atm. Jeff, please apply this to netdev-2.6#upstream instead of akpm's patch that I acked earlier. Of course, someone really should come up with an asm version for ia64 of the missing function ;) Cheers, Auke --- e1000: include for I

RE: [PATCH 3/3] mlsxfrm: Various fixes

2006-11-08 Thread Stephen Smalley
On Wed, 2006-11-08 at 08:34 -0600, Venkat Yekkirala wrote: > > Such duplication can occur among the initial SIDs. > > For some reason I thought that could happen between an initial SID > and a non-initial SID. I think only in the case where a non-initial SID has been invalidated by policy reload

Re. Please pull 'upstream' branch of wireless-2.6

2006-11-08 Thread Roger While
John, you just broke a considerable number of prism54 users. It is NOT an error if the MWI set fails. This is just a performance tweak and has NO effect on the driver working. Roger While - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

Re: Intel 82559 NIC corrupted EEPROM

2006-11-08 Thread Jesse Brandeburg
On 11/8/06, John <[EMAIL PROTECTED]> wrote: Hello all, [ E-mail address is a bit-bucket. I *do* monitor the mailing lists. ] I will try and summarize the problem as I understand it at this point. I've written two messages so far: http://groups.google.com/group/linux.kernel/msg/3a05d819c66474db

Re: [take23 3/5] kevent: poll/select() notifications.

2006-11-08 Thread Evgeniy Polyakov
On Wed, Nov 08, 2006 at 11:45:54AM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > Are you sure you can safely call file->f_op->poll() from inside a callback > > based wakeup? The low level driver may be calling the wakeup with one of > > its locks held, and during the file->f_op->poll ma

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Olaf Kirch
On Wed, Nov 08, 2006 at 04:55:18PM +0100, Arjan van de Ven wrote: > I wonder if it's an option to use low priority QoS fields for these acks > (heck I don't even know if ACKs have such fields in their packet) so > that they can get dropped if there are more packets then there is > bandwidth I

Re: Intel 82559 NIC corrupted EEPROM

2006-11-08 Thread Auke Kok
John wrote: I have a motherboard with three on-board 82559 NICs. o eepro100.ko properly initializes all three NICs o e100.ko fails to initialize one of them NOTE: With kernel 2.6.14, e100.ko fails to initialize the NIC with MAC address 00:30:64:04:E6:E4. With kernel 2.6.18 e100.ko fails to

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Arjan van de Ven
On Tue, 2006-11-07 at 10:32 -0800, Tim Chen wrote: > The patch > > [TCP]: Send ACKs each 2nd received segment > commit: 1ef9696c909060ccdae3ade245ca88692b49285b > http://kernel.org/git/? > p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1ef9696c909060ccdae3ade245ca88692b49285b > > reduced Vo

[DECnet] Don't clear memory twice.

2006-11-08 Thread Ralf Baechle
When dn_neigh.c was converted from kmalloc to kzalloc in commit 0da974f4f303a6842516b764507e3c0a03f41e5a it was missed that dn_neigh_seq_open was actually clearing the allocation twice was missed. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/net/decnet/dn_neigh.c b/net/decnet/dn_n

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-11-08 Thread David Kimdon
On Thu, Nov 02, 2006 at 10:30:56PM -0500, John W. Linville wrote: > David, may I presume there will be a "take4"? yes, refreshing is in progress. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [take23 0/5] kevent: Generic event handling mechanism.

2006-11-08 Thread Eric Dumazet
On Wednesday 08 November 2006 09:21, Evgeniy Polyakov wrote: > On Tue, Nov 07, 2006 at 02:17:18PM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > If kevent_user_wait() gets -EFAULT on the attempt to copy the first > > event, it will return 0, whi

RE: [PATCH 3/3] mlsxfrm: Various fixes

2006-11-08 Thread Venkat Yekkirala
> Such duplication can occur among the initial SIDs. For some reason I thought that could happen between an initial SID and a non-initial SID. > Not sure > though when > that would apply here, It could apply to xfrms if they happen to be using the context represented by any of the initial SIDs

RE: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Venkat Yekkirala
> > Fix SO_PEERSEC for tcp sockets to return the security context of > > the peer (as represented by the SA from the peer) as opposed to the > > SA used by the local/source socket. > > What about the case of a localhost TCP connection not using > xfrm labeling? > > Joe Nall raised this as an import

Re: [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set

2006-11-08 Thread David Kimdon
On Wed, Nov 01, 2006 at 12:24:01AM +0100, Thomas Graf wrote: > I think NET_SCH_FIFO doesn't need a help text, should be invisible > to the user. Just select it from NET_SCHED and d80211. sure, here is a new one: Based on patch by Patrick McHardy. Add a new option, NET_SCH_FIFO, which provid

Re: [Info]d80211 : Understanding d80211

2006-11-08 Thread Udayan Singh
thanks larry for the initial info.. pls reply.. On 11/4/06, Larry Finger <[EMAIL PROTECTED]> wrote: Udayan Singh wrote: > Hi, > > I wanted to understand the code of d80211 (thanks to James Ketrenos > for the info he provided) and also work in it. > > I found that I can get the latest patches reg

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-08 Thread Jeff Garzik
Jiri Benc wrote: On Mon, 06 Nov 2006 22:09:54 +0100, Johannes Berg wrote: What did happen with d80211: add a function to get the wiphy index d80211: add a perm_addr hardware property d80211: add a struct device* hardware property d80211: add a ethtool_ops hardware property patches? Well after s

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-08 Thread Johannes Berg
On Wed, 2006-11-08 at 13:09 +0100, Jiri Benc wrote: > Unfortunately, in case of broadcast and multicast frames, we probably > need to go through decryption handlers for each interface individually. > At least I wasn't able to find a solution which allows to perform > decryption only once for each

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-08 Thread Johannes Berg
On Wed, 2006-11-08 at 12:58 +0100, Jiri Benc wrote: > Ok. Personally, I don't care if we pass net_device or ieee80211_local > to drivers. I see pros and cons of both solutions. As I said in the other patchset, I'd prefer to not change the API for these cleanups unless we have to, so dropping this

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-08 Thread Jiri Benc
On Tue, 07 Nov 2006 00:06:34 +0100, Johannes Berg wrote: > Keeping with the protocol theme, we need to rewrite the rx path to do > the following in the order listed: > > 1) if any monitor interfaces are up, copy the skb, add the > prism/radiotap/whatever header and then clone it to all monito

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-08 Thread Jiri Benc
On Mon, 06 Nov 2006 22:09:54 +0100, Johannes Berg wrote: > > What did happen with > > d80211: add a function to get the wiphy index > > d80211: add a perm_addr hardware property > > d80211: add a struct device* hardware property > > d80211: add a ethtool_ops hardware property > > patches? > > Well

Re: Intel 82559 NIC corrupted EEPROM

2006-11-08 Thread John
Hello all, [ E-mail address is a bit-bucket. I *do* monitor the mailing lists. ] I will try and summarize the problem as I understand it at this point. I've written two messages so far: http://groups.google.com/group/linux.kernel/msg/3a05d819c66474db http://groups.google.com/group/linux.kernel/

Re: 2.6.19-rc1: Volanomark slowdown

2006-11-08 Thread Alexey Kuznetsov
Hell]! > > reduced Volanomark benchmark throughput by 10%. The irony of it is that java vm used to be one of victims of over-delayed acks. I will look, there is a little chance that it is possible to detect the situation and to stretch ACKs. There is one little question though. If you see a v

Re: [PATCH] Add support for configuring the PHY connection interface

2006-11-08 Thread Ingo Oeser
Hi Andy, Andy Fleming wrote: > diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c > index b4b5b4a..b053370 100644 > --- a/arch/powerpc/sysdev/fsl_soc.c > +++ b/arch/powerpc/sysdev/fsl_soc.c > @@ -211,6 +211,36 @@ static int __init gfar_set_flags(struct > return devic

Re: net-2.6.20 is up...

2006-11-08 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 08 Nov 2006 00:34:38 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > > At: > > kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git I guess you mean net-2.6.20.git; right? --yoshfuji - To unsubscribe from this list: send the line "unsubsc

Re: [take23 3/5] kevent: poll/select() notifications.

2006-11-08 Thread Evgeniy Polyakov
On Tue, Nov 07, 2006 at 02:53:33PM -0800, Davide Libenzi (davidel@xmailserver.org) wrote: > On Tue, 7 Nov 2006, Evgeniy Polyakov wrote: > > > +static int kevent_poll_wait_callback(wait_queue_t *wait, > > + unsigned mode, int sync, void *key) > > +{ > > + struct kevent_poll_wait_contai

net-2.6.20 is up...

2006-11-08 Thread David Miller
At: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git I've integrated a series of endianness annotations from Al Viro to start things off. I have some things to review in my queue which I'll work on putting in there including: 1) Stephen Hemminger's netpoll queueing cleanups and f

Re: [take23 1/5] kevent: Description.

2006-11-08 Thread Evgeniy Polyakov
On Tue, Nov 07, 2006 at 02:16:40PM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > On Tue, 7 Nov 2006 19:50:48 +0300 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > Description. > > I converted this into Documentation/kevent.txt. It looks like crap in an > 80-col > xterm btw. Thanks. It

Re: [take23 2/5] kevent: Core files.

2006-11-08 Thread Evgeniy Polyakov
On Tue, Nov 07, 2006 at 02:16:57PM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > On Tue, 7 Nov 2006 19:50:48 +0300 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > This patch includes core kevent files: > > * userspace controlling > > * kernelspace interfaces > > * initialization > > *

  1   2   >