On Sat, 2006-08-19 at 16:18 +1000, Michael Ellerman wrote:
>
> If you try to return an uninitialized value the compiler will warn you,
> you'll then look at the code and realise you missed a case, you might
> save yourself a bug.
You *should* look at the code :)
So should we be reporting these
On Fri, 2006-08-18 at 17:41 +0200, Thomas Klein wrote:
> Hi Alexey,
>
> first of all thanks a lot for the extensive review.
>
>
> Alexey Dobriyan wrote:
> >> + u64 hret = H_HARDWARE;
> >
> > Useless assignment here and everywhere.
> >
>
> Initializing returncodes to errorstate is a cheap way
On Fri, 2006-08-18 at 13:37 +0200, Jan-Bernd Themann wrote:
> Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
>
>
> drivers/net/Kconfig |6 ++
> drivers/net/Makefile |1 +
> 2 files changed, 7 insertions(+)
>
>
>
> diff -Nurp -X dontdiff linux-2.6.18-rc4/drivers/net/Kconfig
On Fri, 2006-08-18 at 18:45 -0500, Linas Vepstas wrote:
> On Fri, Aug 18, 2006 at 06:29:42PM -0500, linas wrote:
> >
> > I don't understand what you are saying. If I call the transmit
> > queue cleanup code from the poll() routine, nothing hapens,
> > because the kernel does not call the poll()
On Fri, 2006-08-18 at 15:51 -0700, David Miller wrote:
> From: [EMAIL PROTECTED] (Linas Vepstas)
> Date: Fri, 18 Aug 2006 17:46:18 -0500
>
> > > We're not saying to use the RX interrupt as the trigger for
> > > RX and TX work. Rather, either of RX or TX interrupt will
> > > schedule the NAPI poll
Andrew Morton wrote:
handwaving
- The mmap(MAP_SHARED)-the-whole-world scenario should be fixed by
mm-tracking-shared-dirty-pages.patch. Please test it and if you are
still able to demonstrate deadlocks, describe how, and why they
are occurring.
OK, but please see "atomic 0 order alloc
On Fri, 18 Aug 2006 17:00:30 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Fri, 18 Aug 2006 10:29:38 -0700
>
> > This small change allows for easy per-route workarounds for broken hosts or
> > middleboxes that are not compliant with TCP
On Fri, 18 Aug 2006 16:44:01 -0700
Daniel Phillips <[EMAIL PROTECTED]> wrote:
> handwaving
- The mmap(MAP_SHARED)-the-whole-world scenario should be fixed by
mm-tracking-shared-dirty-pages.patch. Please test it and if you are
still able to demonstrate deadlocks, describe how, and why they
Arnd Bergmann wrote:
On Saturday 19 August 2006 01:03, Arnd Bergmann wrote:
Someone should probably document that in
Documentation/networking/NAPI_HOWTO.txt, I might end up doing that
once we get it right for spidernet
The reason reclaim via poll() is efficient is because it avoid cau
On Saturday 19 August 2006 01:03, Arnd Bergmann wrote:
> Someone should probably document that in
> Documentation/networking/NAPI_HOWTO.txt, I might end up doing that
> once we get it right for spidernet.
Oh well, what else is there to do on a Friday night ;-)
This is a first draft, I expect to
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 18 Aug 2006 10:29:38 -0700
> This small change allows for easy per-route workarounds for broken hosts or
> middleboxes that are not compliant with TCP standards for window scaling.
> Rather than having to turn off window scaling globally. This
Andrew Morton wrote:
...in my earlier emails I asked a number of questions regarding
whether existing facilities, queued patches or further slight kernel
changes could provide a sufficient solution to these problems. The answer
may well be "no". But diligence requires that we be able to prove t
On Fri, Aug 18, 2006 at 06:29:42PM -0500, linas wrote:
>
> I don't understand what you are saying. If I call the transmit
> queue cleanup code from the poll() routine, nothing hapens,
> because the kernel does not call the poll() routine often
> enough. I've stated this several times.
OK, Ar
On Fri, Aug 18, 2006 at 03:51:16PM -0700, David Miller wrote:
> I see you moving TX reclaim into tasklets and stuff. I've vehemently
> against that because you wouldn't need it in order to move TX
> processing into software interrupts if you did it all in NAPI
> ->poll().
I don't understand what
On Saturday 19 August 2006 00:26, Linas Vepstas wrote:
> The recent set of low-waterark patches for the spider result in a
> significant amount of computing being done in an interrupt context.
> This patch moves this to a "bottom half" aka work queue, so that
> the code runs in a normal kernel cont
On Saturday 19 August 2006 00:25, Linas Vepstas wrote:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
except for
> @@ -2293,6 +2294,8 @@ static struct pci_driver spider_net_driv
> */
> static int __init s
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Fri, 18 Aug 2006 17:46:18 -0500
> > We're not saying to use the RX interrupt as the trigger for
> > RX and TX work. Rather, either of RX or TX interrupt will
> > schedule the NAPI poll.
>
> And, for a lark, this is exactly what I did. Just to see.
>
On Fri, Aug 18, 2006 at 02:25:13PM -0700, David Miller wrote:
> From: [EMAIL PROTECTED] (Linas Vepstas)
> Date: Fri, 18 Aug 2006 14:23:56 -0500
>
> > On Thu, Aug 17, 2006 at 01:43:40AM +0200, Benjamin Herrenschmidt wrote:
> > >
> > > Sounds good (without actually looking at the code though :), th
On Tue, 2006-08-15 at 11:36 +0200, Henne wrote:
> From: Henrik Kretzschmar <[EMAIL PROTECTED]>
>
> Convert the pci_device_ids to PCI_DEVICE() macro.
> Saves 1.5k in the sourcefile.
>
> Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]>
> ---
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To u
On Saturday 19 August 2006 00:20, Linas Vepstas wrote:
> This patch increases the Burst Address alignment from 64 to 1024 in the
> Spidernet driver. This improves transmit performance for arge packets
> from about 100Mbps to 300-400Mbps.
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
-
To unsubscribe
On Fri, 18 Aug 2006 14:22:07 -0700
Daniel Phillips <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> >Daniel Phillips wrote:
> >>Andrew Morton wrote:
> >
> > ...it's runtime configurable.
>
> So we default to "less than the best" because we are too lazy to fix the
> network starvation issue pro
On Fri, 18 Aug 2006 23:54:52 +0200
Michael Buesch <[EMAIL PROTECTED]> wrote:
> Hey Stephen,
>
> Please push the following fix upstream.
>
ok, but it can't make much difference, unless someone did something
like try to set ring->count to zero.
-
To unsubscribe from this list: send the line "unsu
The transmit side of the spider ethernet driver currently
places locks around some very large chunks of code. This
results in a fair amount of lock contention is some cases.
This patch makes the locks much more fine-grained, protecting
only the cirtical sections. One lock is used to protect
thr
The recent set of low-waterark patches for the spider result in a
significant amount of computing being done in an interrupt context.
This patch moves this to a "bottom half" aka work queue, so that
the code runs in a normal kernel context. Curiously, this seems to
result in a performance boost o
This patch adds version information as reported by
ethtool -i to the Spidernet driver.
From: James K Lewis <[EMAIL PROTECTED]>
Signed-off-by: James K Lewis <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Cc: Utz Bacher <[EMAIL PROTECTED]>
Cc: Jens Osterkamp <[EMAIL PROTECTE
Implement basic low-watermark support for the transmit queue.
Hardware low-watermarks allow a properly configured kernel
to continously stream data to a device and not have to handle
any interrupts at all in doing so. Correct zero-interrupt
operation can be actually observed for this driver, whe
This patch increases the Burst Address alignment from 64 to 1024 in the
Spidernet driver. This improves transmit performance for arge packets
from about 100Mbps to 300-400Mbps.
From: James K Lewis <[EMAIL PROTECTED]>
Signed-off-by: James K Lewis <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <
Turn off mis-interpretation of the queue-empty interrupt
status bit as an error. This bit is set as a part of
the previous low-watermark patch.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Signed-off-by: James K Lewis <[EMAIL PROTECTED]>
Cc: Utz Bacher <[EMAIL PROTECTED]>
Cc: Jens Osterkamp
On Mon, Aug 14, 2006 at 11:00:28PM -0700, [EMAIL PROTECTED] wrote:
> From: Alexey Dobriyan <[EMAIL PROTECTED]>
>
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
> Cc: Jeff Garzik <[EMAIL PROTECTED]>
> Cc: Dominik Brodowski <[EMAIL PROTECTED]>
> Cc: Valerie Henson <[EMAIL PROTECTED]>
> Signed-
Jeff,
Can you apply and forward upstream the following series of patches?
This is the same set of patches I sent only a few days ago; however,
it appears that I failed to cc you on some of them, and I failed to
ask anyone in particular to actually apply them. So I'm asking now. :-)
The maintaine
[SCTP]: Use the flags value that is passed as an arg to sctp_accept.
No need to do multiple dereferences - sk->sk_socket->file->f_flags
Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]>
---
net/sctp/socket.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/
On Friday 18 August 2006 23:29, Ulrich Kunitz wrote:
> On 06-08-18 09:12 Johannes Berg wrote:
>
> > On Fri, 2006-08-18 at 01:29 +0200, Ulrich Kunitz wrote:
> > > Or are here people, who
> > > really want to freely transmit on all frequencies their RF might
> > > be able to generate?
> >
> > Yes :
Hey Stephen,
Please push the following fix upstream.
--
/**
* kcalloc - allocate memory for an array. The memory is set to zero.
* @n: number of elements.
* @size: element size.
* @flags: the type of memory to allocate.
*/
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
Index: linux-2.6
On 06-08-18 09:12 Johannes Berg wrote:
> On Fri, 2006-08-18 at 01:29 +0200, Ulrich Kunitz wrote:
> > Or are here people, who
> > really want to freely transmit on all frequencies their RF might
> > be able to generate?
>
> Yes :P
> Some amateur radio people asked me about extending the spectrum a
On Fri, Jul 28, 2006 at 12:11:09PM +0200, Lennert Buytenhek wrote:
> We're currently working on getting the Thecus n2100 supported in 2.6.
>
> http://www.thecus.com/products_over.php?cid=1&pid=1
>
> Amongst other nice goodies, it has two on-board RTL8110SB gigabit
> controllers. The realt
Andrew Morton wrote:
Daniel Phillips wrote:
Andrew Morton wrote:
...it's runtime configurable.
So we default to "less than the best" because we are too lazy to fix the
network starvation issue properly? Maybe we don't really need a mempool for
struct bio either, isn't that one rather like t
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Fri, 18 Aug 2006 14:23:56 -0500
> On Thu, Aug 17, 2006 at 01:43:40AM +0200, Benjamin Herrenschmidt wrote:
> >
> > Sounds good (without actually looking at the code though :), that was a
> > long required improvement to that driver. Also, we should pro
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Fri, 18 Aug 2006 20:17:18 +0200
>
> > @@ -1136,7 +1137,8 @@ int tcp_recvmsg(struct kiocb *iocb, stru
> > skb = skb_peek_tail(&sk->sk_receive_queue);
> > if (skb)
> > available = TCP_SKB_CB(skb)->seq + skb->len - (*seq);
> > - if ((a
Davem brought up the point of how expensive IPIs are. Our own
performance tests for multi-queue weren't all that impressive...which
just proved his point. So we decided not to go forward with the patch.
Really, the hardware we coded multi-queue for was not ready for such a
feature. Hardware that
The rtl8150 (ethernet) driver uses a default MTU of 1540, which causes
all kinds of problems with for example booting off NFS root. There isn't
really any reason why we shouldn't use the default of 1500.
Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]>
Index: linux-2.6.18-rc2/drivers/usb/net
On Thu, Aug 17, 2006 at 01:43:40AM +0200, Benjamin Herrenschmidt wrote:
>
> Sounds good (without actually looking at the code though :), that was a
> long required improvement to that driver. Also, we should probably look
> into using NAPI polling for tx completion queue as well, no ?
Just for a
[SCTP]: Cleanup nomem handling in the state functions.
This patch cleans up the "nomem" conditions that may occur during the
processing by the state machine functions. In most cases we delay adding
side-effect commands until all memory allocations are done.
Signed-off-by: Vladislav Yasevich <[EMA
[SCTP]: Fix IPv6 address flag setting when doing peel-off/accept.
During accept/peeloff we try to copy the list of bound addresses from
the original endpoint to the new one. However, we forgot to set the flag
to say that IPv6 is allowed on the new endpoint.
Signed-off-by: Vladislav Yasevich <[EMA
[SCTP]: Remove multiple levels of msecs to jiffies conversions.
The SCTP sysctl entries are displayed in milliseconds, but stored
internally in jiffies. This results in multiple levels of msecs to
jiffies conversion and as a result produces a truncation error. This
patch makes things consistent in
Dave,
Please apply the following set of 5 SCTP patches to 2.6.19 tree.
Thanks
Sridhar
[SCTP]: Extend /proc/net/sctp/snmp to provide more statistics.
This patch adds more statistics info under /proc/net/sctp/snmp
that should be useful for debugging. The additional events that
are counted now inc
> +static inline void ehea_update_sqa(struct ehea_qp *qp, u16 nr_wqes)
> +{
> + struct h_epa epa = qp->epas.kernel;
> + epa_store_acc(epa, QPTEMM_OFFSET(qpx_sqa),
> + EHEA_BMASK_SET(QPX_SQA_VALUE, nr_wqes));
> +}
> +
> +static inline void ehea_update_rq3a(struct ehea_qp *q
On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein <[EMAIL PROTECTED]> wrote:
> Hi Alexey,
>
> first of all thanks a lot for the extensive review.
>
>
> Alexey Dobriyan wrote:
> >> + u64 hret = H_HARDWARE;
> >
> > Useless assignment here and everywhere.
> >
>
> Initializing returncodes to erro
This small change allows for easy per-route workarounds for broken hosts or
middleboxes that are not compliant with TCP standards for window scaling.
Rather than having to turn off window scaling globally. This patch allows
reducing or disabling window scaling if window clamp is present.
Example:
On Fri, 18 Aug 2006, Andi Kleen wrote:
> Also I must say it's still not quite clear to me if it's better to place
> network packets on the node the device is connected to or on the
> node which contains the CPU who processes the packet data
> For RX this can be three different nodes in the worst
> @@ -1136,7 +1137,8 @@ int tcp_recvmsg(struct kiocb *iocb, stru
> skb = skb_peek_tail(&sk->sk_receive_queue);
> if (skb)
> available = TCP_SKB_CB(skb)->seq + skb->len - (*seq);
> - if ((available < target) &&
> + dst = __sk_dst_get(sk);
> + if ((available < t
> From: Ravinandan Arakali
>
> Hi,
> I am trying to use I/OAT on one of the newer woodcrest boxes.
> But not sure if things are configured properly since there
> seems to be no change in performance with I/OAT enabled
> or disabled.
> Following are the steps followed.
> 1. MSI (CONFIG_PCI_MSI) is e
I did mean RSSI - just about anything that when interpreted as an 8 bit
unsigned int and goes up with increasing signal fits the bill as an RSSI
measure. RCPI requires a certain minimum accuracy and linearity (the
accuracy required is not very high).
Simon
-Original Message-
From: Johann
Michael> Cold you oplease consider IB/mthca: recover from device
Michael> errors as well?
Yes, I will. There's still plenty of time before 2.6.19 opens up.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
It might be appropriate to change it from pkt_type to a flag indicating
that a timestamp should be added at TX time "add_timestamp". This may
well also end up being used for beacons too on hardware where the
beacons are completely software generated.
Simon
-Original Message-
From: Johann
Quoting r. Roland Dreier <[EMAIL PROTECTED]>:
> o I also have the following minor changes queued in the
>for-2.6.19 branch of infiniband.git:
Cold you oplease consider IB/mthca: recover from device errors
as well?
--
MST
-
To unsubscribe from this list: send the line "unsubscribe n
On Friday 18 August 2006 16:24, Christoph Raisch wrote:
> And as always in performance tuning... one size fits all unfortunately is
> not the correct answer.
Ah, good. What is the maximum sensible value that you came up with?
> Therefore we'll leave that open to the user as most other new etherne
>
> Hi,
>
> > I asked SO to recount arguments and we've come to a conclusion that
> > there're in fact 19 args not 18 as the name suggests. 19 args is
> > I-N-S-A-N-E.
>
> It will be partially cleaned up by:
>
> http://ozlabs.org/pipermail/linuxppc-dev/2006-July/024556.html
>
> However it doesnt f
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
can
O
> + * netxen_nic_get_stats - Get System Network Statistics
> + * @netdev: network interface device structure
> + */
> +struct net_device_stats *netxen_nic_get_stats(struct net_device *netdev)
> +{
> + struct netxen_port *port = netdev_priv(netdev);
> + struct net_device_stats *stats = &po
irq leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge:
if e1000_up fails in e1000_open() we do not free allocated irq
Signed-off-by: Vasily Averin <[EMAIL PROTECTED]>
Thank you,
Vasily Averin
SWsoft Virtuozzo/OpenVZ Linux kernel team
--- linux-2.6.18-rc4/drivers/net/e1000/e100
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.h
linux-2.6.17/drivers/net/netxen/netxen_nic_hw.h
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.h1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/net
On 8/18/06, Pavel Machek <[EMAIL PROTECTED]> wrote:
Huh, two version bumps for... ONE ONE-LINER :-).
Could we get rid of embedded version? It helps no one.
Version numbers for drivers that can be built as modules are very
helpful for anyone wanting to upgrade a driver on top of a
distribution
Hi,
> I asked SO to recount arguments and we've come to a conclusion that
> there're in fact 19 args not 18 as the name suggests. 19 args is
> I-N-S-A-N-E.
It will be partially cleaned up by:
http://ozlabs.org/pipermail/linuxppc-dev/2006-July/024556.html
However it doesnt fix the fact someone
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_phan_reg.h
linux-2.6.17/drivers/net/netxen/netxen_nic_phan_reg.h
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_phan_reg.h 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/ne
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hdr.h
linux-2.6.17/drivers/net/netxen/netxen_nic_hdr.h
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hdr.h 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/n
Way to many DPRINTK()'s
> +
> +int is_flash_supported(struct netxen_adapter *adapter)
needs to be static or prefixed.
> +{
> + int locs[] = { 0, 0x4, 0x100, 0x4000, 0x4128 };
use const
> + int addr, val01, val02, i, j;
> +
> + /* if the flash size less than 4Mb, make huge war cry
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic.h
linux-2.6.17/drivers/net/netxen/netxen_nic.h
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic.h 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/netxen_nic.h
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_ethtool.c
linux-2.6.17/drivers/net/netxen/netxen_nic_ethtool.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_ethtool.c 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/
On Fri, Aug 18, 2006 at 01:30:21PM +0200, Jan-Bernd Themann wrote:
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c
> +++ kernel/drivers/net/ehea/ehea_phyp.c
> + hret = ehea_hcall_9arg_9ret(H_QUERY_HEA_QP,
> + hcp_adapter_handle, /* R4 */
> +
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_isr.c
linux-2.6.17/drivers/net/netxen/netxen_nic_isr.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_isr.c 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/n
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_init.c
linux-2.6.17/drivers/net/netxen/netxen_nic_init.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_init.c 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen
Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge:
We should free resources allocated for previous rings if following allocation
fails.
Signed-off-by: Vasily Averin <[EMAIL PROTECTED]>
Thank you,
Vasily Averin
SWsoft Virtuozzo/OpenVZ Linux kernel team
--- linux-2.6.18
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c
linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c
--- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c1969-12-31
16:00:00.0 -0800
+++ linux-2.6.17/drivers/net/netxen/net
On Fri, Aug 18, 2006 at 09:12:05AM +0200, Johannes Berg wrote:
> On Fri, 2006-08-18 at 01:29 +0200, Ulrich Kunitz wrote:
> > Or are here people, who
> > really want to freely transmit on all frequencies their RF might
> > be able to generate?
>
> Yes :P
> Some amateur radio people asked me about e
Here's a new version with a cleaned up interface and methods for each
command instead of multiplexing the commands right away. This cuts down
code in nl80211 users because attributes are already checked and
unpacked etc.
Packet injection also still works :P
johannes
--- /dev/null 1970-01-01 00
On Fri, 2006-08-18 at 07:33 -0700, Jouni Malinen wrote:
> Some hardware designs require this configuration for TX frames. It is
> used to select whether some of the fields are being filled in hardware
> (e.g., timestamp for Probe Response).
Ah ok, timestamp makes sense.
> This would only be nee
diff -Nrup -X linux-2.6.17.orig/Documentation/dontdiff
linux-2.6.17.orig/MAINTAINERS linux-2.6.17/MAINTAINERS
--- linux-2.6.17.orig/MAINTAINERS 2006-07-05 01:16:07.0 -0700
+++ linux-2.6.17/MAINTAINERS2006-08-18 02:40:30.0 -0700
@@ -1987,6 +1987,13 @@ L: netdev@vger
On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c
> +++ kernel/drivers/net/ehea/ehea_main.c
> +static struct net_device_stats *ehea_get_stats(struct net_device *dev)
> +{
> + int i;
> + u64 hret = H_HARDWARE;
Useles
On Fri, 18 August 2006 13:31:19 +0200, Jan-Bernd Themann wrote:
>
> + if (queue->current_q_offset > queue->queue_length) {
> + queue->current_q_offset -= queue->pagesize;
> + retvalue = NULL;
> + }
> + else if u64) retvalue) & (EHEA_PAGESIZE-1)) != 0) {
Hi,
I'll be sending a NetXen Multi port 1G/10G ethernet driver patch in
subsequent emails. This set of patches have changes as per the
suggestions, which we received since last post.
Kindly review it and feel free to send feedback.
Thanks,
-Amit
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED
On Fri, 18 August 2006 15:25:11 +0200, Thomas Klein wrote:
> Arjan van de Ven wrote:
> >>+ queue->queue_length = nr_of_pages * pagesize;
> >>+ queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
> >
> >
> >wow... is this really so large that it warrants a vmalloc()???
>
> Agreed: Repla
On Fri, Aug 18, 2006 at 01:41:57PM +0200, Johannes Berg wrote:
> I was pondering the ieee80211_tx_control type and don't see anyone using
> the pkt_type field. d80211 makes great effort to have it correct, but no
> driver uses it.
>
> Hence, my question: What is the purpose of this field? Under w
On Fri, Aug 18, 2006 at 01:34:57PM +0200, Jan-Bernd Themann wrote:
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h
> +++ kernel/drivers/net/ehea/ehea.h
> +#include
Not needed.
> +#include
> +#include
Really?
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
>
On Fri, Aug 18, 2006 at 01:37:44PM +0200, Jan-Bernd Themann wrote:
> --- linux-2.6.18-rc4/drivers/net/Kconfig
> +++ patched_kernel/drivers/net/Kconfig
> @@ -2277,6 +2277,12 @@ config CHELSIO_T1
>To compile this driver as a module, choose M here: the module
>will be called cx
> You should really do some measurements to see what the minimal
> queue sizes are that can get you optimal throughput.
>
>Arnd <><
we did.
And as always in performance tuning... one size fits all unfortunately is
not the correct answer.
Therefore we'll leave that open to the user as most othe
On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote:
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c
> +++ kernel/drivers/net/ehea/ehea_ethtool.c
> +static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd
> *cmd)
> +{
> + u64 hret = H_HARDWARE;
usel
On Fri, 2006-08-18 at 17:47 +0400, Alexey Dobriyan wrote:
> On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
>
> Was there noticeable performance difference when explicit prefetching is
> removed? At some (invisible) point CPUs will become smarter about prefetching
> than program
On Friday 18 August 2006 15:25, Thomas Klein wrote:
>
> > wow... is this really so large that it warrants a vmalloc()???
>
> Agreed: Replaced with kmalloc()
My understanding from the previous discussion was that it actually
is a multi-page power of two allocation, so the right choice might
be __
On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
Was there noticeable performance difference when explicit prefetching is
removed? At some (invisible) point CPUs will become smarter about prefetching
than programmers and this code will be slower than possible.
> +static inline s
Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge:
Memory allocated for new tx_ring and rx_ring leaks if e1000_setup_XX_resources()
fails.c Also this patch reduces stack usage (removed tx_new and rx_new) and uses
kzalloc instead kmalloc+memset(0)
Signed-off-by: Vasily Averin <[E
Arjan van de Ven wrote:
+ queue->queue_length = nr_of_pages * pagesize;
+ queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
wow... is this really so large that it warrants a vmalloc()???
Agreed: Replaced with kmalloc()
Regards
Thomas
-
To unsubscribe from this list: se
Hello,
First of all, thank you for your comments.
> If you have a duplicated address and the application is not using
> interface index to identify the interface, then which one you join or
> leave
> on is not unique, and which one you'll get is not defined. It is, in fact,
> an error to
On Tue, 2006-08-15 at 14:11 -0400, Bill Nottingham wrote:
> 2.6.17-1.2564.fc6 is 2.6.18rc4+.
>
> Happened with 'echo "+bond0" > /sys/class/net/bonding_masters'
>
> bonding: bond0 is being created...
>
> ===
> [ INFO: possible circular locking d
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/ehea/ehea.h| 442 +
drivers/net/ehea/ehea_hw.h | 292 +
2 files changed, 734 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 19
> + queue->queue_length = nr_of_pages * pagesize;
> + queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
wow... is this really so large that it warrants a vmalloc()???
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/Kconfig |6 ++
drivers/net/Makefile |1 +
2 files changed, 7 insertions(+)
diff -Nurp -X dontdiff linux-2.6.18-rc4/drivers/net/Kconfig
patched_kernel/drivers/net/Kconfig
--- linux-2.6.18-rc4/drivers/net/Kconfig
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/ehea/Makefile |7 +++
1 file changed, 7 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31
16:00:00.0 -0800
+++ kernel/drivers/net/ehea/Makefile2006-08-18 00:01:00.755974823 -0
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/ehea/ehea_hcall.h | 51 ++
drivers/net/ehea/ehea_phyp.c | 884 ++
drivers/net/ehea/ehea_phyp.h | 523
3 files changed, 1458 insertions(+)
--- linux-2.6.18-r
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/ehea/ehea_qmr.c | 643
drivers/net/ehea/ehea_qmr.h | 367 +
2 files changed, 1010 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_qmr.c 1969
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
drivers/net/ehea/ehea_ethtool.c | 264
1 file changed, 264 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31
16:00:00.0 -0800
+++ kernel/drivers/net/
1 - 100 of 126 matches
Mail list logo
